RFR (S): 7192916: Hotspot development launcher should use DYLD_LIBRARY_PATH on OS X

[Staffan Larsen]

On 21 aug 2012, at 15:17, Nils Loodin <nils.loodin at oracle.com> wrote:

> On 2012-08-21 15:07, Staffan Larsen wrote:
>> Please review this change to the HotSpot development launcher. The development launcher (called 'hotspot' in the build output folder) should use DYLD_LIBRARY_PATH instead of LD_LIBRARY_PATH on OS X.
>> 
>> http://cr.openjdk.java.net/~sla/7192916/webrev.00/
>> 
>> Thanks,
>> /Staffan
> There should be some indentation after the first added if statement.

I'll fix that.

> Although, since the logic is very similar, perhaps it should be a common 'logic bloc', and the 'if darwin' statement only set's if it's LD_LIBRARY_PATH or DYLD_LIBRARY_PATH that gets exported?

That would be good, except the common "logic block" needs to see if either LD_LIBRARY_PATH or DYLD_LIBRARY_PATH is set. But I could change it to something like this:

OS=`uname -s`
if [ "${OS}" = "Darwin" ]
then
    LIB_PATH=$DYLD_LIBRARY_PATH
else
    LIB_PATH=$LD_LIBRARY_PATH
fi

if [ -z "$LIB_PATH" ]
then
    LIB_PATH="$SBP"
else
    LIB_PATH="$SBP:$LIB_PATH"
fi

if [ "${OS}" = "Darwin" ]
then
    export DYLD_LIBRARY_PATH=$LIB_PATH
else
    export LD_LIBRARY_PATH=$LIB_PATH
fi


/Staffan




> 
> 
> 
> /Nils Loodin