Request for reviews (M): 6677625: Move platform specific flags from globals.hpp to globals_<arch>.hpp

David Holmes david.holmes at oracle.com
Tue Aug 21 15:16:26 PDT 2012


I see a lot of changes that aren't obviously pd flags. Is there some 
other refactoring going on here?

What happens today if these flags are specified on a platform that 
doesn't use them - is it just ignored? What happens with these changes? 
Unrecognized VM option? That could break people's scripts.

David

On 22/08/2012 7:23 AM, Christian Thalinger wrote:
> http://cr.openjdk.java.net/~twisti/6677625/
>
> 6677625: Move platform specific flags from globals.hpp to globals_<arch>.hpp
> Reviewed-by:
> Contributed-by: Tao Mao<tao.mao at oracle.com>
>
> Add new definition RUNTIME_PD_FLAGS and move platform specific flags from
> globals.hpp to globals_<arch>.hpp.
>
> src/cpu/sparc/vm/globals_sparc.cpp
> src/cpu/sparc/vm/globals_sparc.hpp
> src/cpu/x86/vm/globals_x86.cpp
> src/cpu/x86/vm/globals_x86.hpp
> src/cpu/zero/vm/globals_zero.cpp
> src/cpu/zero/vm/globals_zero.hpp
> src/share/vm/c1/c1_globals.hpp
> src/share/vm/opto/c2_globals.cpp
> src/share/vm/opto/c2_globals.hpp
> src/share/vm/opto/runtime.cpp
> src/share/vm/runtime/globals.cpp
> src/share/vm/runtime/globals_extension.hpp
> src/share/vm/runtime/globals.hpp
> src/share/vm/utilities/macros.hpp
>


More information about the hotspot-dev mailing list