Request for review 8003722: More gcc 4.7 compilation errors

[David Holmes]

On 26/11/2012 6:33 AM, David Holmes wrote:
> Hi Coleen,
>
> Okay I withdraw my objections otherwise this will never get fixed. gcc
> itself says use "this->" so be it. Plus push when ready.

Please push ...

David

> For the record I'm hitting these kind of problems with gcc 4.6 as well.
> It's in build-infra repo so may be down-rev on previous hotspot changes.
>
> Thanks,
> David
>
> On 22/11/2012 12:18 AM, Coleen Phillimore wrote:
>> On 11/20/2012 9:52 PM, David Holmes wrote:
>>> Sorry but I must protest. After the last fix we were returned to an
>>> unpleasant mixture of using directives and this-> augmentation. The
>>> fix that was lost had applied the using directive.
>>>
>>> Can we please use the using directive and just fix these once and for
>>> all.
>>
>> Okay, someone will have to contribute the "using" fix then. I don't know
>> what to use in "using"!
>>
>> Please do this very soon since the VM doesn't build on gcc 4.7 (again!)
>>
>> Thanks,
>> Coleen
>>
>>>
>>> Otherwise get rid of all using directives. But lets have a consistent
>>> approach here.
>>>
>>> Thanks,
>>> David
>>>
>>> On 21/11/2012 11:44 AM, Coleen Phillimore wrote:
>>>> Summary: Add a few more this->qualifications.
>>>> Reviewed-by: coleenp
>>>> Contributed-by: duboscq at ssw.jku.at
>>>>
>>>> http://cr.openjdk.java.net/~coleenp/8003722/
>>>>
>>>> Ran runThese tests with CMS gc. I want to check this into hotspot-gc
>>>> since it has the other changes (hotspot-rt doesn't yet).
>>>>
>>>> Thanks,
>>>> Coleen
>>