From zhengyu.gu at oracle.com  Wed May  1 07:38:36 2013
From: zhengyu.gu at oracle.com (Zhengyu Gu)
Date: Wed, 01 May 2013 10:38:36 -0400
Subject: RFR: 8013120 NMT: Kitchensink crashes with assert(next_region
	== NULL || !next_region->is_committed_region()) failed: Sanity check
In-Reply-To: <5179737D.7070800@oracle.com>
References: <5179737D.7070800@oracle.com>
Message-ID: <518128EC.4040206@oracle.com>

I added comments in remove_released_region() to explain how virtual 
memory records are arranged in snapshot, and the loop to remove 
committed records following the reservation record.

Please review updated webrev: 
http://cr.openjdk.java.net/~zgu/8013120/webrev.02/ 
<http://cr.openjdk.java.net/%7Ezgu/8013120/webrev.02/>

Thanks,

-Zhengyu


On 4/25/2013 2:18 PM, Zhengyu Gu wrote:
> NMT expects all committed regions are uncommitted before the whole 
> reserved region can be released. It was the case until 8011268.
>
> This change allows NMT to handle the scenario that virtual memory is 
> being released while there are committed segments within the reserved 
> region.
>
> It also fixed a missing virtual memory tag when ArrayAllocator 
> allocates from virtual memory.
>
> Bug: http://bugs.sun.com/view_bug.do?bug_id=8013120
> Webrev: http://cr.openjdk.java.net/~zgu/8013120/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ezgu/8013120/webrev.00/>
>
> Thanks,
>
> -Zhengyu


From daniel.daugherty at oracle.com  Wed May  1 11:04:39 2013
From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com)
Date: Wed, 01 May 2013 18:04:39 +0000
Subject: hg: hsx/hotspot-main/hotspot: 17 new changesets
Message-ID: <20130501180515.DB15B4874B@hg.openjdk.java.net>

Changeset: cc70cbbd422e
Author:    hseigel
Date:      2013-04-24 09:00 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/cc70cbbd422e

8012695: Assertion message displays %u and %s text instead of actual values
Summary: USe err_msg() to create a proper assertion message.
Reviewed-by: twisti, coleenp, iklam

! src/share/vm/classfile/classFileParser.hpp

Changeset: fbca7eaeac2e
Author:    zgu
Date:      2013-04-24 14:55 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/fbca7eaeac2e

8011218: Kitchensink hanged, likely NMT is to blame
Summary: Made NMT query safepoint aware.
Reviewed-by: dholmes, coleenp

! src/share/vm/services/memBaseline.cpp
! src/share/vm/services/memBaseline.hpp
! src/share/vm/services/memTracker.cpp

Changeset: d587a5c30bd8
Author:    coleenp
Date:      2013-04-24 16:19 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d587a5c30bd8

8011803: release_C_heap_structures is never called for anonymous classes.
Summary: Call this function from the ClassLoaderData destructor instead of the system dictionary walk.
Reviewed-by: stefank, mgerdin

! src/share/vm/classfile/classLoaderData.cpp
! src/share/vm/classfile/dictionary.cpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/instanceKlass.hpp

Changeset: d66a24adbe3f
Author:    coleenp
Date:      2013-04-24 15:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d66a24adbe3f

Merge


Changeset: 15a99ca4ee34
Author:    sspitsyn
Date:      2013-04-25 03:58 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/15a99ca4ee34

8007037: JSR 292: the VM_RedefineClasses::append_entry() should do cross-checks with indy operands
Summary: References from operands to CP entries and back must be correct after CP merge
Reviewed-by: coleenp, twisti
Contributed-by: serguei.spitsyn at oracle.com

! src/share/vm/oops/constantPool.cpp
! src/share/vm/oops/constantPool.hpp
! src/share/vm/prims/jvmtiRedefineClasses.cpp
! src/share/vm/prims/jvmtiRedefineClasses.hpp

Changeset: c115fac239eb
Author:    iklam
Date:      2013-04-25 12:55 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/c115fac239eb

8008962: NPG: Memory regression: One extra Monitor per ConstantPool
Summary: Re-use InstanceKlass::_init_lock locking ConstantPool as well.
Reviewed-by: dholmes, coleenp, acorn

! src/share/vm/ci/ciEnv.cpp
! src/share/vm/oops/constantPool.cpp
! src/share/vm/oops/constantPool.hpp
! src/share/vm/oops/cpCache.cpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/prims/jvmtiEnv.cpp

Changeset: 3c9b7ef92c61
Author:    dcubed
Date:      2013-04-26 08:40 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/3c9b7ef92c61

Merge


Changeset: d1644a010f52
Author:    emc
Date:      2013-04-26 07:34 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d1644a010f52

8007154: Remove support for u4 MethodParameter flags fields
Summary: Remove support for parsing class files with four-byte flags fields in MethodParameters attributes
Reviewed-by: jrose, coleenp

! src/share/vm/classfile/classFileParser.cpp

Changeset: f258c5828eb8
Author:    hseigel
Date:      2013-04-29 16:13 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f258c5828eb8

8011773: Some tests on Interned String crashed JVM with OOM
Summary: Instead of terminating the VM, throw OutOfMemoryError exceptions.
Reviewed-by: coleenp, dholmes

! src/share/vm/classfile/javaClasses.cpp
! src/share/vm/classfile/javaClasses.hpp
! src/share/vm/classfile/symbolTable.cpp
! src/share/vm/memory/allocation.hpp
! src/share/vm/oops/oop.cpp
! src/share/vm/prims/whitebox.cpp

Changeset: c53e49efe6a8
Author:    hseigel
Date:      2013-04-29 16:36 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/c53e49efe6a8

Merge


Changeset: f32b6c267d2e
Author:    mikael
Date:      2013-04-29 11:03 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f32b6c267d2e

8012015: Use PROT_NONE when reserving memory
Summary: Reserved memory had PROT_READ+PROT_WRITE access on Linux/bsd, now changed to PROT_NONE.
Reviewed-by: dholmes, ctornqvi

! src/os/bsd/vm/os_bsd.cpp
! src/os/linux/vm/os_linux.cpp
! src/share/vm/prims/whitebox.cpp
+ test/runtime/memory/ReserveMemory.java
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: 9f96b7a853bc
Author:    sla
Date:      2013-04-30 10:53 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/9f96b7a853bc

8013466: SA crashes when attaching to a process on OS X
Reviewed-by: coleenp, rbackman, minqi

! agent/src/os/bsd/MacosxDebuggerLocal.m

Changeset: 409d4b59e095
Author:    sla
Date:      2013-04-30 02:28 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/409d4b59e095

Merge


Changeset: ed5a590835a4
Author:    zgu
Date:      2013-04-30 09:17 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/ed5a590835a4

8013214: BigApps fails due to 'fatal error: Illegal threadstate encountered: 6'
Summary: Grab and drop SR_lock to get the thread to honor the safepoint protocol
Reviewed-by: dcubed, coleenp

! src/share/vm/services/memBaseline.cpp

Changeset: 746b070f5022
Author:    ccheung
Date:      2013-04-30 11:56 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/746b070f5022

8011661: Insufficient memory message says "malloc" when sometimes it should say "mmap"
Reviewed-by: coleenp, zgu, hseigel

! src/os/solaris/vm/os_solaris.cpp
! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp
! src/os_cpu/linux_x86/vm/os_linux_x86.cpp
! src/os_cpu/linux_zero/vm/os_linux_zero.cpp
! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp
! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp
! src/share/vm/asm/assembler.cpp
! src/share/vm/code/stubs.cpp
! src/share/vm/code/vtableStubs.cpp
! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.cpp
! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp
! src/share/vm/gc_implementation/parallelScavenge/objectStartArray.cpp
! src/share/vm/interpreter/interpreterRuntime.cpp
! src/share/vm/memory/allocation.cpp
! src/share/vm/memory/allocation.inline.hpp
! src/share/vm/memory/blockOffsetTable.cpp
! src/share/vm/memory/cardTableModRefBS.cpp
! src/share/vm/oops/oop.cpp
! src/share/vm/prims/jvmtiTagMap.cpp
! src/share/vm/prims/methodHandles.cpp
! src/share/vm/runtime/objectMonitor.cpp
! src/share/vm/runtime/stubRoutines.cpp
! src/share/vm/runtime/synchronizer.cpp
! src/share/vm/utilities/debug.cpp
! src/share/vm/utilities/debug.hpp
! src/share/vm/utilities/vmError.cpp
! src/share/vm/utilities/vmError.hpp
! src/share/vm/utilities/workgroup.cpp

Changeset: e4614b063fe1
Author:    sla
Date:      2013-04-30 21:47 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/e4614b063fe1

8013364: SA-JDI exceptions caused by lack of permissions on OSX should be more verbose about issue cause
Reviewed-by: coleenp, rbackman

! agent/src/os/bsd/MacosxDebuggerLocal.m

Changeset: 376ff861f611
Author:    sla
Date:      2013-05-01 01:07 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/376ff861f611

Merge



From nils.eliasson at oracle.com  Wed May  1 13:41:17 2013
From: nils.eliasson at oracle.com (Nils Eliasson)
Date: Wed, 01 May 2013 22:41:17 +0200
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <5176D417.3040202@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>
	<51759F6B.7080808@oracle.com>
	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>
	<51764FDE.2090205@oracle.com> <517669A6.8030705@oracle.com>
	<5176CD8E.5060704@oracle.com>
	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>
	<5176D417.3040202@oracle.com>
Message-ID: <51817DED.2050603@oracle.com>

Hi,

Here is a patch that fixes so that it still works to create vcprojs, and 
also sets defaults for the debugger commands.

I have verified with creating vcprojs and debugging hotspot in VS 2010. 
Works great except for an annoying pop-up that warns that the launcher 
doesn't have debug symbols (if the target jdk doesn't).

It will still be some extra work for those using the commandlines 
plugin. All saved command lines need the be prepended with 
"-XXaltjvm=$(TargetDir) -Dsun.java.launcher=gamma" and the target JDK 
set as executable to work. We should update the plugin to help with that.

A big thank you to Christian T?rnqvist for the proposal!

//Nils


On 2013-04-23 20:33, Mikael Gerdin wrote:
>
> On 2013-04-23 20:28, Christian Thalinger wrote:
>>
>> On Apr 23, 2013, at 11:06 AM, Nils Eliasson 
>> <nils.eliasson at oracle.com> wrote:
>>
>>> As long as we fix it first and remove gamma after - I would love to 
>>> have some redundant code removed. I would fix it myself, I just 
>>> don't think I will have the time before I go on parental leave.
>>
>> First, I'm not removing it tomorrow.  I expected a long discussion :-)
>>
>> What exactly is the problem with Visual Studio?  Why can't you just 
>> run the java launcher instead?
>>
>
> I don't know if there actually is a problem, but I don't think 
> anyone's actually tried to tell it to use the java launcher.
> The VS project is automatically setup to launch "hotspot.exe" from the 
> IDE. "hotspot.exe" is equivalent to the old option LINK_INTO=AOUT 
> (IIRC) which involves linking all the VM object files into the launcher.
>
> Nils, perhaps you can at least try this before you leave?
>
> /Mikael
>
>> -- Chris
>>
>>>
>>> //Nils
>>>
>>> On 2013-04-23 12:59, Mikael Gerdin wrote:
>>>>
>>>>
>>>> On 2013-04-23 11:09, Nils Eliasson wrote:
>>>>> The gamma launcher is used to run and debug hotspot from Visual 
>>>>> Studio.
>>>>> So removing gamma effectively kills the working environment for a 
>>>>> number
>>>>> of people that use it daily.  So I am strongly against removing it.
>>>>
>>>> Maybe the visual studio project generator could be updated to 
>>>> create a a "launch configuration" for launching java.exe from a JDK 
>>>> and use the XXaltJVM flag on to select the correct jvm.dll?
>>>>
>>>> I agree that we shouldn't break the visual studio project but 
>>>> currently there's nothing indicating that we can't fix it.
>>>>
>>>>
>>>> /Mikael
>>>>
>>>>>
>>>>> Most people working on Windows use Cygwin as the last resort since it
>>>>> makes a lot of thing excruciatingly slow.
>>>>>
>>>>> //Nils
>>>>>
>>>>> On 2013-04-22 22:55, Christian Thalinger wrote:
>>>>>> On Apr 22, 2013, at 1:36 PM, Daniel D. Daugherty
>>>>>> <daniel.daugherty at oracle.com> wrote:
>>>>>>
>>>>>>> Chris,
>>>>>>>
>>>>>>> Just an observation and not a review.
>>>>>>>
>>>>>>> Looks like you're removing launcher support on Windows, but it
>>>>>>> looks like the new hotspot.script doesn't support Windows...
>>>>>>> Am I missing something?
>>>>>> Almost certainly true.  Since I'm not a Windows user (and nobody 
>>>>>> near
>>>>>> me is one) I have no idea how people are using the gamma launcher on
>>>>>> Windows (or the hotspot script for that matter).
>>>>>>
>>>>>> I presume most people doing debugging on the command line are 
>>>>>> already
>>>>>> in cygwin?  But I might be wrong.
>>>>>>
>>>>>> -- Chris
>>>>>>
>>>>>>> Dan
>>>>>>>
>>>>>>>
>>>>>>> On 4/22/13 1:47 PM, Christian Thalinger wrote:
>>>>>>>> http://cr.openjdk.java.net/~twisti/8008772/
>>>>>>>>
>>>>>>>> 8008772: remove gamma launcher
>>>>>>>> Reviewed-by:
>>>>>>>>
>>>>>>>> Remove linking the gamma launcher and it's associated source 
>>>>>>>> files.
>>>>>>>>
>>>>>>>> make/Makefile
>>>>>>>> make/bsd/makefiles/launcher.make
>>>>>>>> make/bsd/makefiles/vm.make
>>>>>>>> make/hotspot.script
>>>>>>>> make/linux/makefiles/launcher.make
>>>>>>>> make/linux/makefiles/vm.make
>>>>>>>> make/solaris/makefiles/launcher.make
>>>>>>>> make/solaris/makefiles/vm.make
>>>>>>>> make/windows/makefiles/debug.make
>>>>>>>> make/windows/makefiles/fastdebug.make
>>>>>>>> make/windows/makefiles/launcher.make
>>>>>>>> make/windows/makefiles/product.make
>>>>>>>> make/windows/makefiles/projectcreator.make
>>>>>>>> make/windows/projectfiles/common/Makefile
>>>>>>>> src/os/posix/launcher/java_md.c
>>>>>>>> src/os/posix/launcher/java_md.h
>>>>>>>> src/os/posix/launcher/launcher.script
>>>>>>>> src/os/windows/launcher/java_md.c
>>>>>>>> src/os/windows/launcher/java_md.h
>>>>>>>> src/share/tools/launcher/java.c
>>>>>>>> src/share/tools/launcher/java.h
>>>>>>>> src/share/tools/launcher/jli_util.c
>>>>>>>> src/share/tools/launcher/jli_util.h
>>>>>>>> src/share/tools/launcher/wildcard.c
>>>>>>>> src/share/tools/launcher/wildcard.h
>>>>>>>>
>>>>>>>> This change removes the duplicated java launcher files (which were
>>>>>>>> subject to bit-rot) and modifies the hotspot script to pick up the
>>>>>>>> libjvm in the current build directory.
>>>>>>>>
>>>>>>>> The modified hotspot script works with GDB and DBX:
>>>>>>>>
>>>>>>>> cthaling at intelsdv03.us.oracle.com:/export/twisti/build/8008772/build/linux_i486_compiler2/debug$ 
>>>>>>>>
>>>>>>>> ./hotspot -gdb -version
>>>>>>>> GNU gdb (GDB) Red Hat Enterprise Linux (7.1-29.el6)
>>>>>>>> Copyright (C) 2010 Free Software Foundation, Inc.
>>>>>>>> License GPLv3+: GNU GPL version 3 or later
>>>>>>>> <http://gnu.org/licenses/gpl.html>
>>>>>>>> This is free software: you are free to change and redistribute it.
>>>>>>>> There is NO WARRANTY, to the extent permitted by law. Type "show
>>>>>>>> copying"
>>>>>>>> and "show warranty" for details.
>>>>>>>> This GDB was configured as "x86_64-redhat-linux-gnu".
>>>>>>>> For bug reporting instructions, please see:
>>>>>>>> <http://www.gnu.org/software/gdb/bugs/>.
>>>>>>>> Missing separate debuginfo for
>>>>>>>> /net/scanas404.us.oracle.com/export/java-re/jdk/8/ea/b86/binaries/linux-i586/bin/java 
>>>>>>>>
>>>>>>>>
>>>>>>>> Try: yum --disablerepo='*' --enablerepo='*-debuginfo' install
>>>>>>>> /usr/lib/debug/.build-id/5e/85e6dced3b388a7b0e50630242f4c7ee5e31a3.debug 
>>>>>>>>
>>>>>>>>
>>>>>>>> Function "JNI_CreateJavaVM" not defined.
>>>>>>>> Breakpoint 1 (JNI_CreateJavaVM) pending.
>>>>>>>> [Thread debugging using libthread_db enabled]
>>>>>>>> [New Thread 0xf7fe4b70 (LWP 13459)]
>>>>>>>> [Switching to Thread 0xf7fe4b70 (LWP 13459)]
>>>>>>>>
>>>>>>>> Breakpoint 1, JNI_CreateJavaVM (vm=0xf7fe4378, penv=0xf7fe4374,
>>>>>>>> args=0xf7fe4364)
>>>>>>>>      at
>>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/prims/jni.cpp:5062 
>>>>>>>>
>>>>>>>>
>>>>>>>> 5062      jint result = JNI_ERR;
>>>>>>>> Missing separate debuginfos, use: debuginfo-install
>>>>>>>> glibc-2.12-1.7.el6.i686
>>>>>>>> (gdb) break CompileBroker::compile_method
>>>>>>>> Breakpoint 2 at 0xaef852: file
>>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/compiler/compileBroker.cpp, 
>>>>>>>>
>>>>>>>> line 1205.
>>>>>>>> (gdb) c
>>>>>>>> Continuing.
>>>>>>>> [New Thread 0xf7f93b70 (LWP 13460)]
>>>>>>>> [New Thread 0xb4398b70 (LWP 13461)]
>>>>>>>> [New Thread 0xb41ffb70 (LWP 13462)]
>>>>>>>> [New Thread 0xb3effb70 (LWP 13463)]
>>>>>>>> [New Thread 0xb3cffb70 (LWP 13464)]
>>>>>>>> [New Thread 0xb3affb70 (LWP 13465)]
>>>>>>>> [New Thread 0xb38ffb70 (LWP 13466)]
>>>>>>>> [New Thread 0xb36ffb70 (LWP 13467)]
>>>>>>>> [New Thread 0xb34ffb70 (LWP 13468)]
>>>>>>>> [New Thread 0xb32ffb70 (LWP 13469)]
>>>>>>>> [New Thread 0xb30ffb70 (LWP 13470)]
>>>>>>>> [New Thread 0xb2effb70 (LWP 13471)]
>>>>>>>> [New Thread 0xb2cffb70 (LWP 13472)]
>>>>>>>> [New Thread 0xaf8e8b70 (LWP 13473)]
>>>>>>>> [New Thread 0xb4156b70 (LWP 13474)]
>>>>>>>> [New Thread 0xb3c7eb70 (LWP 13475)]
>>>>>>>> [New Thread 0xb3a7eb70 (LWP 13476)]
>>>>>>>> [New Thread 0xaeeffb70 (LWP 13477)]
>>>>>>>> [New Thread 0xaecffb70 (LWP 13478)]
>>>>>>>> [New Thread 0xb387eb70 (LWP 13479)]
>>>>>>>> [New Thread 0xaeaffb70 (LWP 13480)]
>>>>>>>> java version "1.8.0-ea"
>>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
>>>>>>>> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, 
>>>>>>>> mixed mode)
>>>>>>>> [Thread 0xaeaffb70 (LWP 13480) exited]
>>>>>>>> [Thread 0xb3a7eb70 (LWP 13476) exited]
>>>>>>>> [Thread 0xaf8e8b70 (LWP 13473) exited]
>>>>>>>> [Thread 0xf7fe4b70 (LWP 13459) exited]
>>>>>>>> [Thread 0xb2cffb70 (LWP 13472) exited]
>>>>>>>> [Thread 0xb2effb70 (LWP 13471) exited]
>>>>>>>> [Thread 0xaecffb70 (LWP 13478) exited]
>>>>>>>> [Thread 0xb387eb70 (LWP 13479) exited]
>>>>>>>> [Thread 0xaeeffb70 (LWP 13477) exited]
>>>>>>>> [Thread 0xb3c7eb70 (LWP 13475) exited]
>>>>>>>> [Thread 0xb4156b70 (LWP 13474) exited]
>>>>>>>> [Thread 0xb32ffb70 (LWP 13469) exited]
>>>>>>>> [Thread 0xb34ffb70 (LWP 13468) exited]
>>>>>>>> [Thread 0xb36ffb70 (LWP 13467) exited]
>>>>>>>> [Thread 0xb38ffb70 (LWP 13466) exited]
>>>>>>>> [Thread 0xb3affb70 (LWP 13465) exited]
>>>>>>>> [Thread 0xb3cffb70 (LWP 13464) exited]
>>>>>>>> [Thread 0xb3effb70 (LWP 13463) exited]
>>>>>>>> [Thread 0xb41ffb70 (LWP 13462) exited]
>>>>>>>> [Thread 0xb4398b70 (LWP 13461) exited]
>>>>>>>> [Thread 0xf7f93b70 (LWP 13460) exited]
>>>>>>>> [Thread 0xb30ffb70 (LWP 13470) exited]
>>>>>>>>
>>>>>>>> Program exited normally.
>>>>>>>> (gdb)
>>>>>>>>
>>>>>>>>
>>>>>>>> cthaling at intelsdv01:/export/twisti/build/8008772/build/solaris_i486_compiler2/debug$ 
>>>>>>>>
>>>>>>>> /bin/bash ./hotspot -dbx -version
>>>>>>>> dbx: warning: using the alternate init file: /home/cthaling/.dbxrc
>>>>>>>> Reading java
>>>>>>>> Reading ld.so.1
>>>>>>>> Reading libjli.so
>>>>>>>> Reading libthread.so.1
>>>>>>>> Reading libdl.so.1
>>>>>>>> Reading libc.so.1
>>>>>>>> Reading libjvm.so
>>>>>>>> Loaded loadobject:
>>>>>>>> /export/twisti/build/8008772/build/solaris_i486_compiler2/debug/libjvm.so 
>>>>>>>>
>>>>>>>>
>>>>>>>> Running: java -Dsun.java.launcher=gamma
>>>>>>>> -XXaltjvm=/export/twisti/build/8008772/build/solaris_i486_compiler2/debug 
>>>>>>>>
>>>>>>>> -version
>>>>>>>> (process id 29613)
>>>>>>>> Reading libsocket.so.1
>>>>>>>> Reading libsched.so.1
>>>>>>>> Reading libm.so.1
>>>>>>>> Reading libCrun.so.1
>>>>>>>> Reading libdoor.so.1
>>>>>>>> Reading libdemangle.so.1
>>>>>>>> Reading libnsl.so.1
>>>>>>>> Reading libm.so.2
>>>>>>>> Reading libscf.so.1
>>>>>>>> Reading libuutil.so.1
>>>>>>>> Reading libgen.so.1
>>>>>>>> Reading libmd.so.1
>>>>>>>> Reading libmp.so.2
>>>>>>>> t at 2 (l at 2) stopped in JNI_CreateJavaVM at line 5062 in file 
>>>>>>>> "jni.cpp"
>>>>>>>>   5062     jint result = JNI_ERR;
>>>>>>>> (dbx) stop in CompileBroker::compile_method
>>>>>>>> (2) stop in
>>>>>>>> CompileBroker::compile_method(methodHandle,int,int,methodHandle,int,const 
>>>>>>>>
>>>>>>>> char*,Thread*)
>>>>>>>> (dbx) c
>>>>>>>> Reading libverify.so
>>>>>>>> Reading libjava.so
>>>>>>>> Reading libzip.so
>>>>>>>> java version "1.8.0-ea"
>>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
>>>>>>>> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, 
>>>>>>>> mixed mode)
>>>>>>>>
>>>>>>>> execution completed, exit code is 0
>>>>>>>> (dbx)
>>>>>>>>
>>>>>
>>>
>>


From vladimir.kozlov at oracle.com  Wed May  1 14:21:42 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Wed, 01 May 2013 14:21:42 -0700
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <51817DED.2050603@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>
	<51759F6B.7080808@oracle.com>
	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>
	<51764FDE.2090205@oracle.com> <517669A6.8030705@oracle.com>
	<5176CD8E.5060704@oracle.com>
	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>
	<5176D417.3040202@oracle.com> <51817DED.2050603@oracle.com>
Message-ID: <51818766.20604@oracle.com>

Nils,

I don't see attached patch or webrev link.

thanks,
Vladimir

On 5/1/13 1:41 PM, Nils Eliasson wrote:
> Hi,
>
> Here is a patch that fixes so that it still works to create vcprojs, and
> also sets defaults for the debugger commands.
>
> I have verified with creating vcprojs and debugging hotspot in VS 2010.
> Works great except for an annoying pop-up that warns that the launcher
> doesn't have debug symbols (if the target jdk doesn't).
>
> It will still be some extra work for those using the commandlines
> plugin. All saved command lines need the be prepended with
> "-XXaltjvm=$(TargetDir) -Dsun.java.launcher=gamma" and the target JDK
> set as executable to work. We should update the plugin to help with that.
>
> A big thank you to Christian T?rnqvist for the proposal!
>
> //Nils
>
>
> On 2013-04-23 20:33, Mikael Gerdin wrote:
>>
>> On 2013-04-23 20:28, Christian Thalinger wrote:
>>>
>>> On Apr 23, 2013, at 11:06 AM, Nils Eliasson
>>> <nils.eliasson at oracle.com> wrote:
>>>
>>>> As long as we fix it first and remove gamma after - I would love to
>>>> have some redundant code removed. I would fix it myself, I just
>>>> don't think I will have the time before I go on parental leave.
>>>
>>> First, I'm not removing it tomorrow.  I expected a long discussion :-)
>>>
>>> What exactly is the problem with Visual Studio?  Why can't you just
>>> run the java launcher instead?
>>>
>>
>> I don't know if there actually is a problem, but I don't think
>> anyone's actually tried to tell it to use the java launcher.
>> The VS project is automatically setup to launch "hotspot.exe" from the
>> IDE. "hotspot.exe" is equivalent to the old option LINK_INTO=AOUT
>> (IIRC) which involves linking all the VM object files into the launcher.
>>
>> Nils, perhaps you can at least try this before you leave?
>>
>> /Mikael
>>
>>> -- Chris
>>>
>>>>
>>>> //Nils
>>>>
>>>> On 2013-04-23 12:59, Mikael Gerdin wrote:
>>>>>
>>>>>
>>>>> On 2013-04-23 11:09, Nils Eliasson wrote:
>>>>>> The gamma launcher is used to run and debug hotspot from Visual
>>>>>> Studio.
>>>>>> So removing gamma effectively kills the working environment for a
>>>>>> number
>>>>>> of people that use it daily.  So I am strongly against removing it.
>>>>>
>>>>> Maybe the visual studio project generator could be updated to
>>>>> create a a "launch configuration" for launching java.exe from a JDK
>>>>> and use the XXaltJVM flag on to select the correct jvm.dll?
>>>>>
>>>>> I agree that we shouldn't break the visual studio project but
>>>>> currently there's nothing indicating that we can't fix it.
>>>>>
>>>>>
>>>>> /Mikael
>>>>>
>>>>>>
>>>>>> Most people working on Windows use Cygwin as the last resort since it
>>>>>> makes a lot of thing excruciatingly slow.
>>>>>>
>>>>>> //Nils
>>>>>>
>>>>>> On 2013-04-22 22:55, Christian Thalinger wrote:
>>>>>>> On Apr 22, 2013, at 1:36 PM, Daniel D. Daugherty
>>>>>>> <daniel.daugherty at oracle.com> wrote:
>>>>>>>
>>>>>>>> Chris,
>>>>>>>>
>>>>>>>> Just an observation and not a review.
>>>>>>>>
>>>>>>>> Looks like you're removing launcher support on Windows, but it
>>>>>>>> looks like the new hotspot.script doesn't support Windows...
>>>>>>>> Am I missing something?
>>>>>>> Almost certainly true.  Since I'm not a Windows user (and nobody
>>>>>>> near
>>>>>>> me is one) I have no idea how people are using the gamma launcher on
>>>>>>> Windows (or the hotspot script for that matter).
>>>>>>>
>>>>>>> I presume most people doing debugging on the command line are
>>>>>>> already
>>>>>>> in cygwin?  But I might be wrong.
>>>>>>>
>>>>>>> -- Chris
>>>>>>>
>>>>>>>> Dan
>>>>>>>>
>>>>>>>>
>>>>>>>> On 4/22/13 1:47 PM, Christian Thalinger wrote:
>>>>>>>>> http://cr.openjdk.java.net/~twisti/8008772/
>>>>>>>>>
>>>>>>>>> 8008772: remove gamma launcher
>>>>>>>>> Reviewed-by:
>>>>>>>>>
>>>>>>>>> Remove linking the gamma launcher and it's associated source
>>>>>>>>> files.
>>>>>>>>>
>>>>>>>>> make/Makefile
>>>>>>>>> make/bsd/makefiles/launcher.make
>>>>>>>>> make/bsd/makefiles/vm.make
>>>>>>>>> make/hotspot.script
>>>>>>>>> make/linux/makefiles/launcher.make
>>>>>>>>> make/linux/makefiles/vm.make
>>>>>>>>> make/solaris/makefiles/launcher.make
>>>>>>>>> make/solaris/makefiles/vm.make
>>>>>>>>> make/windows/makefiles/debug.make
>>>>>>>>> make/windows/makefiles/fastdebug.make
>>>>>>>>> make/windows/makefiles/launcher.make
>>>>>>>>> make/windows/makefiles/product.make
>>>>>>>>> make/windows/makefiles/projectcreator.make
>>>>>>>>> make/windows/projectfiles/common/Makefile
>>>>>>>>> src/os/posix/launcher/java_md.c
>>>>>>>>> src/os/posix/launcher/java_md.h
>>>>>>>>> src/os/posix/launcher/launcher.script
>>>>>>>>> src/os/windows/launcher/java_md.c
>>>>>>>>> src/os/windows/launcher/java_md.h
>>>>>>>>> src/share/tools/launcher/java.c
>>>>>>>>> src/share/tools/launcher/java.h
>>>>>>>>> src/share/tools/launcher/jli_util.c
>>>>>>>>> src/share/tools/launcher/jli_util.h
>>>>>>>>> src/share/tools/launcher/wildcard.c
>>>>>>>>> src/share/tools/launcher/wildcard.h
>>>>>>>>>
>>>>>>>>> This change removes the duplicated java launcher files (which were
>>>>>>>>> subject to bit-rot) and modifies the hotspot script to pick up the
>>>>>>>>> libjvm in the current build directory.
>>>>>>>>>
>>>>>>>>> The modified hotspot script works with GDB and DBX:
>>>>>>>>>
>>>>>>>>> cthaling at intelsdv03.us.oracle.com:/export/twisti/build/8008772/build/linux_i486_compiler2/debug$
>>>>>>>>>
>>>>>>>>> ./hotspot -gdb -version
>>>>>>>>> GNU gdb (GDB) Red Hat Enterprise Linux (7.1-29.el6)
>>>>>>>>> Copyright (C) 2010 Free Software Foundation, Inc.
>>>>>>>>> License GPLv3+: GNU GPL version 3 or later
>>>>>>>>> <http://gnu.org/licenses/gpl.html>
>>>>>>>>> This is free software: you are free to change and redistribute it.
>>>>>>>>> There is NO WARRANTY, to the extent permitted by law. Type "show
>>>>>>>>> copying"
>>>>>>>>> and "show warranty" for details.
>>>>>>>>> This GDB was configured as "x86_64-redhat-linux-gnu".
>>>>>>>>> For bug reporting instructions, please see:
>>>>>>>>> <http://www.gnu.org/software/gdb/bugs/>.
>>>>>>>>> Missing separate debuginfo for
>>>>>>>>> /net/scanas404.us.oracle.com/export/java-re/jdk/8/ea/b86/binaries/linux-i586/bin/java
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Try: yum --disablerepo='*' --enablerepo='*-debuginfo' install
>>>>>>>>> /usr/lib/debug/.build-id/5e/85e6dced3b388a7b0e50630242f4c7ee5e31a3.debug
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Function "JNI_CreateJavaVM" not defined.
>>>>>>>>> Breakpoint 1 (JNI_CreateJavaVM) pending.
>>>>>>>>> [Thread debugging using libthread_db enabled]
>>>>>>>>> [New Thread 0xf7fe4b70 (LWP 13459)]
>>>>>>>>> [Switching to Thread 0xf7fe4b70 (LWP 13459)]
>>>>>>>>>
>>>>>>>>> Breakpoint 1, JNI_CreateJavaVM (vm=0xf7fe4378, penv=0xf7fe4374,
>>>>>>>>> args=0xf7fe4364)
>>>>>>>>>      at
>>>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/prims/jni.cpp:5062
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> 5062      jint result = JNI_ERR;
>>>>>>>>> Missing separate debuginfos, use: debuginfo-install
>>>>>>>>> glibc-2.12-1.7.el6.i686
>>>>>>>>> (gdb) break CompileBroker::compile_method
>>>>>>>>> Breakpoint 2 at 0xaef852: file
>>>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/compiler/compileBroker.cpp,
>>>>>>>>>
>>>>>>>>> line 1205.
>>>>>>>>> (gdb) c
>>>>>>>>> Continuing.
>>>>>>>>> [New Thread 0xf7f93b70 (LWP 13460)]
>>>>>>>>> [New Thread 0xb4398b70 (LWP 13461)]
>>>>>>>>> [New Thread 0xb41ffb70 (LWP 13462)]
>>>>>>>>> [New Thread 0xb3effb70 (LWP 13463)]
>>>>>>>>> [New Thread 0xb3cffb70 (LWP 13464)]
>>>>>>>>> [New Thread 0xb3affb70 (LWP 13465)]
>>>>>>>>> [New Thread 0xb38ffb70 (LWP 13466)]
>>>>>>>>> [New Thread 0xb36ffb70 (LWP 13467)]
>>>>>>>>> [New Thread 0xb34ffb70 (LWP 13468)]
>>>>>>>>> [New Thread 0xb32ffb70 (LWP 13469)]
>>>>>>>>> [New Thread 0xb30ffb70 (LWP 13470)]
>>>>>>>>> [New Thread 0xb2effb70 (LWP 13471)]
>>>>>>>>> [New Thread 0xb2cffb70 (LWP 13472)]
>>>>>>>>> [New Thread 0xaf8e8b70 (LWP 13473)]
>>>>>>>>> [New Thread 0xb4156b70 (LWP 13474)]
>>>>>>>>> [New Thread 0xb3c7eb70 (LWP 13475)]
>>>>>>>>> [New Thread 0xb3a7eb70 (LWP 13476)]
>>>>>>>>> [New Thread 0xaeeffb70 (LWP 13477)]
>>>>>>>>> [New Thread 0xaecffb70 (LWP 13478)]
>>>>>>>>> [New Thread 0xb387eb70 (LWP 13479)]
>>>>>>>>> [New Thread 0xaeaffb70 (LWP 13480)]
>>>>>>>>> java version "1.8.0-ea"
>>>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
>>>>>>>>> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug,
>>>>>>>>> mixed mode)
>>>>>>>>> [Thread 0xaeaffb70 (LWP 13480) exited]
>>>>>>>>> [Thread 0xb3a7eb70 (LWP 13476) exited]
>>>>>>>>> [Thread 0xaf8e8b70 (LWP 13473) exited]
>>>>>>>>> [Thread 0xf7fe4b70 (LWP 13459) exited]
>>>>>>>>> [Thread 0xb2cffb70 (LWP 13472) exited]
>>>>>>>>> [Thread 0xb2effb70 (LWP 13471) exited]
>>>>>>>>> [Thread 0xaecffb70 (LWP 13478) exited]
>>>>>>>>> [Thread 0xb387eb70 (LWP 13479) exited]
>>>>>>>>> [Thread 0xaeeffb70 (LWP 13477) exited]
>>>>>>>>> [Thread 0xb3c7eb70 (LWP 13475) exited]
>>>>>>>>> [Thread 0xb4156b70 (LWP 13474) exited]
>>>>>>>>> [Thread 0xb32ffb70 (LWP 13469) exited]
>>>>>>>>> [Thread 0xb34ffb70 (LWP 13468) exited]
>>>>>>>>> [Thread 0xb36ffb70 (LWP 13467) exited]
>>>>>>>>> [Thread 0xb38ffb70 (LWP 13466) exited]
>>>>>>>>> [Thread 0xb3affb70 (LWP 13465) exited]
>>>>>>>>> [Thread 0xb3cffb70 (LWP 13464) exited]
>>>>>>>>> [Thread 0xb3effb70 (LWP 13463) exited]
>>>>>>>>> [Thread 0xb41ffb70 (LWP 13462) exited]
>>>>>>>>> [Thread 0xb4398b70 (LWP 13461) exited]
>>>>>>>>> [Thread 0xf7f93b70 (LWP 13460) exited]
>>>>>>>>> [Thread 0xb30ffb70 (LWP 13470) exited]
>>>>>>>>>
>>>>>>>>> Program exited normally.
>>>>>>>>> (gdb)
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> cthaling at intelsdv01:/export/twisti/build/8008772/build/solaris_i486_compiler2/debug$
>>>>>>>>>
>>>>>>>>> /bin/bash ./hotspot -dbx -version
>>>>>>>>> dbx: warning: using the alternate init file: /home/cthaling/.dbxrc
>>>>>>>>> Reading java
>>>>>>>>> Reading ld.so.1
>>>>>>>>> Reading libjli.so
>>>>>>>>> Reading libthread.so.1
>>>>>>>>> Reading libdl.so.1
>>>>>>>>> Reading libc.so.1
>>>>>>>>> Reading libjvm.so
>>>>>>>>> Loaded loadobject:
>>>>>>>>> /export/twisti/build/8008772/build/solaris_i486_compiler2/debug/libjvm.so
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Running: java -Dsun.java.launcher=gamma
>>>>>>>>> -XXaltjvm=/export/twisti/build/8008772/build/solaris_i486_compiler2/debug
>>>>>>>>>
>>>>>>>>> -version
>>>>>>>>> (process id 29613)
>>>>>>>>> Reading libsocket.so.1
>>>>>>>>> Reading libsched.so.1
>>>>>>>>> Reading libm.so.1
>>>>>>>>> Reading libCrun.so.1
>>>>>>>>> Reading libdoor.so.1
>>>>>>>>> Reading libdemangle.so.1
>>>>>>>>> Reading libnsl.so.1
>>>>>>>>> Reading libm.so.2
>>>>>>>>> Reading libscf.so.1
>>>>>>>>> Reading libuutil.so.1
>>>>>>>>> Reading libgen.so.1
>>>>>>>>> Reading libmd.so.1
>>>>>>>>> Reading libmp.so.2
>>>>>>>>> t at 2 (l at 2) stopped in JNI_CreateJavaVM at line 5062 in file
>>>>>>>>> "jni.cpp"
>>>>>>>>>   5062     jint result = JNI_ERR;
>>>>>>>>> (dbx) stop in CompileBroker::compile_method
>>>>>>>>> (2) stop in
>>>>>>>>> CompileBroker::compile_method(methodHandle,int,int,methodHandle,int,const
>>>>>>>>>
>>>>>>>>> char*,Thread*)
>>>>>>>>> (dbx) c
>>>>>>>>> Reading libverify.so
>>>>>>>>> Reading libjava.so
>>>>>>>>> Reading libzip.so
>>>>>>>>> java version "1.8.0-ea"
>>>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
>>>>>>>>> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug,
>>>>>>>>> mixed mode)
>>>>>>>>>
>>>>>>>>> execution completed, exit code is 0
>>>>>>>>> (dbx)
>>>>>>>>>
>>>>>>
>>>>
>>>
>

From christian.tornqvist at oracle.com  Wed May  1 14:30:44 2013
From: christian.tornqvist at oracle.com (Christian Tornqvist)
Date: Wed, 1 May 2013 17:30:44 -0400
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <51818766.20604@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>	<51759F6B.7080808@oracle.com>	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>	<51764FDE.2090205@oracle.com>
	<517669A6.8030705@oracle.com>	<5176CD8E.5060704@oracle.com>	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>	<5176D417.3040202@oracle.com>
	<51817DED.2050603@oracle.com> <51818766.20604@oracle.com>
Message-ID: <00d901ce46b3$28037a90$780a6fb0$@tornqvist@oracle.com>

Hi Vladimir,

Nils attached the patch to the email, but I've put the patch at
http://cr.openjdk.java.net/~ctornqvi/webrev/vs.patch also

Thanks,
Christian

-----Original Message-----
From: hotspot-dev-bounces at openjdk.java.net
[mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
Sent: den 1 maj 2013 17:22
To: Nils Eliasson
Cc: build-dev at openjdk.java.net; hotspot-dev developers; Christian Thalinger
Subject: Re: RFR (M): 8008772: remove gamma launcher

Nils,

I don't see attached patch or webrev link.

thanks,
Vladimir

On 5/1/13 1:41 PM, Nils Eliasson wrote:
> Hi,
>
> Here is a patch that fixes so that it still works to create vcprojs, 
> and also sets defaults for the debugger commands.
>
> I have verified with creating vcprojs and debugging hotspot in VS 2010.
> Works great except for an annoying pop-up that warns that the launcher 
> doesn't have debug symbols (if the target jdk doesn't).
>
> It will still be some extra work for those using the commandlines 
> plugin. All saved command lines need the be prepended with
> "-XXaltjvm=$(TargetDir) -Dsun.java.launcher=gamma" and the target JDK 
> set as executable to work. We should update the plugin to help with that.
>
> A big thank you to Christian T?rnqvist for the proposal!
>
> //Nils
>
>
> On 2013-04-23 20:33, Mikael Gerdin wrote:
>>
>> On 2013-04-23 20:28, Christian Thalinger wrote:
>>>
>>> On Apr 23, 2013, at 11:06 AM, Nils Eliasson 
>>> <nils.eliasson at oracle.com> wrote:
>>>
>>>> As long as we fix it first and remove gamma after - I would love to 
>>>> have some redundant code removed. I would fix it myself, I just 
>>>> don't think I will have the time before I go on parental leave.
>>>
>>> First, I'm not removing it tomorrow.  I expected a long discussion 
>>> :-)
>>>
>>> What exactly is the problem with Visual Studio?  Why can't you just 
>>> run the java launcher instead?
>>>
>>
>> I don't know if there actually is a problem, but I don't think 
>> anyone's actually tried to tell it to use the java launcher.
>> The VS project is automatically setup to launch "hotspot.exe" from 
>> the IDE. "hotspot.exe" is equivalent to the old option LINK_INTO=AOUT
>> (IIRC) which involves linking all the VM object files into the launcher.
>>
>> Nils, perhaps you can at least try this before you leave?
>>
>> /Mikael
>>
>>> -- Chris
>>>
>>>>
>>>> //Nils
>>>>
>>>> On 2013-04-23 12:59, Mikael Gerdin wrote:
>>>>>
>>>>>
>>>>> On 2013-04-23 11:09, Nils Eliasson wrote:
>>>>>> The gamma launcher is used to run and debug hotspot from Visual 
>>>>>> Studio.
>>>>>> So removing gamma effectively kills the working environment for a 
>>>>>> number of people that use it daily.  So I am strongly against 
>>>>>> removing it.
>>>>>
>>>>> Maybe the visual studio project generator could be updated to 
>>>>> create a a "launch configuration" for launching java.exe from a 
>>>>> JDK and use the XXaltJVM flag on to select the correct jvm.dll?
>>>>>
>>>>> I agree that we shouldn't break the visual studio project but 
>>>>> currently there's nothing indicating that we can't fix it.
>>>>>
>>>>>
>>>>> /Mikael
>>>>>
>>>>>>
>>>>>> Most people working on Windows use Cygwin as the last resort 
>>>>>> since it makes a lot of thing excruciatingly slow.
>>>>>>
>>>>>> //Nils
>>>>>>
>>>>>> On 2013-04-22 22:55, Christian Thalinger wrote:
>>>>>>> On Apr 22, 2013, at 1:36 PM, Daniel D. Daugherty 
>>>>>>> <daniel.daugherty at oracle.com> wrote:
>>>>>>>
>>>>>>>> Chris,
>>>>>>>>
>>>>>>>> Just an observation and not a review.
>>>>>>>>
>>>>>>>> Looks like you're removing launcher support on Windows, but it 
>>>>>>>> looks like the new hotspot.script doesn't support Windows...
>>>>>>>> Am I missing something?
>>>>>>> Almost certainly true.  Since I'm not a Windows user (and nobody 
>>>>>>> near me is one) I have no idea how people are using the gamma 
>>>>>>> launcher on Windows (or the hotspot script for that matter).
>>>>>>>
>>>>>>> I presume most people doing debugging on the command line are 
>>>>>>> already in cygwin?  But I might be wrong.
>>>>>>>
>>>>>>> -- Chris
>>>>>>>
>>>>>>>> Dan
>>>>>>>>
>>>>>>>>
>>>>>>>> On 4/22/13 1:47 PM, Christian Thalinger wrote:
>>>>>>>>> http://cr.openjdk.java.net/~twisti/8008772/
>>>>>>>>>
>>>>>>>>> 8008772: remove gamma launcher
>>>>>>>>> Reviewed-by:
>>>>>>>>>
>>>>>>>>> Remove linking the gamma launcher and it's associated source 
>>>>>>>>> files.
>>>>>>>>>
>>>>>>>>> make/Makefile
>>>>>>>>> make/bsd/makefiles/launcher.make make/bsd/makefiles/vm.make 
>>>>>>>>> make/hotspot.script make/linux/makefiles/launcher.make
>>>>>>>>> make/linux/makefiles/vm.make
>>>>>>>>> make/solaris/makefiles/launcher.make
>>>>>>>>> make/solaris/makefiles/vm.make 
>>>>>>>>> make/windows/makefiles/debug.make 
>>>>>>>>> make/windows/makefiles/fastdebug.make
>>>>>>>>> make/windows/makefiles/launcher.make
>>>>>>>>> make/windows/makefiles/product.make
>>>>>>>>> make/windows/makefiles/projectcreator.make
>>>>>>>>> make/windows/projectfiles/common/Makefile
>>>>>>>>> src/os/posix/launcher/java_md.c 
>>>>>>>>> src/os/posix/launcher/java_md.h 
>>>>>>>>> src/os/posix/launcher/launcher.script
>>>>>>>>> src/os/windows/launcher/java_md.c 
>>>>>>>>> src/os/windows/launcher/java_md.h 
>>>>>>>>> src/share/tools/launcher/java.c 
>>>>>>>>> src/share/tools/launcher/java.h 
>>>>>>>>> src/share/tools/launcher/jli_util.c
>>>>>>>>> src/share/tools/launcher/jli_util.h
>>>>>>>>> src/share/tools/launcher/wildcard.c
>>>>>>>>> src/share/tools/launcher/wildcard.h
>>>>>>>>>
>>>>>>>>> This change removes the duplicated java launcher files (which 
>>>>>>>>> were subject to bit-rot) and modifies the hotspot script to 
>>>>>>>>> pick up the libjvm in the current build directory.
>>>>>>>>>
>>>>>>>>> The modified hotspot script works with GDB and DBX:
>>>>>>>>>
>>>>>>>>> cthaling at intelsdv03.us.oracle.com:/export/twisti/build/8008772
>>>>>>>>> /build/linux_i486_compiler2/debug$
>>>>>>>>>
>>>>>>>>> ./hotspot -gdb -version
>>>>>>>>> GNU gdb (GDB) Red Hat Enterprise Linux (7.1-29.el6) Copyright 
>>>>>>>>> (C) 2010 Free Software Foundation, Inc.
>>>>>>>>> License GPLv3+: GNU GPL version 3 or later 
>>>>>>>>> <http://gnu.org/licenses/gpl.html>
>>>>>>>>> This is free software: you are free to change and redistribute it.
>>>>>>>>> There is NO WARRANTY, to the extent permitted by law. Type 
>>>>>>>>> "show copying"
>>>>>>>>> and "show warranty" for details.
>>>>>>>>> This GDB was configured as "x86_64-redhat-linux-gnu".
>>>>>>>>> For bug reporting instructions, please see:
>>>>>>>>> <http://www.gnu.org/software/gdb/bugs/>.
>>>>>>>>> Missing separate debuginfo for 
>>>>>>>>> /net/scanas404.us.oracle.com/export/java-re/jdk/8/ea/b86/binar
>>>>>>>>> ies/linux-i586/bin/java
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Try: yum --disablerepo='*' --enablerepo='*-debuginfo' install 
>>>>>>>>> /usr/lib/debug/.build-id/5e/85e6dced3b388a7b0e50630242f4c7ee5e
>>>>>>>>> 31a3.debug
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Function "JNI_CreateJavaVM" not defined.
>>>>>>>>> Breakpoint 1 (JNI_CreateJavaVM) pending.
>>>>>>>>> [Thread debugging using libthread_db enabled] [New Thread 
>>>>>>>>> 0xf7fe4b70 (LWP 13459)] [Switching to Thread 0xf7fe4b70 (LWP 
>>>>>>>>> 13459)]
>>>>>>>>>
>>>>>>>>> Breakpoint 1, JNI_CreateJavaVM (vm=0xf7fe4378, 
>>>>>>>>> penv=0xf7fe4374,
>>>>>>>>> args=0xf7fe4364)
>>>>>>>>>      at
>>>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/pri
>>>>>>>>> ms/jni.cpp:5062
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> 5062      jint result = JNI_ERR;
>>>>>>>>> Missing separate debuginfos, use: debuginfo-install
>>>>>>>>> glibc-2.12-1.7.el6.i686
>>>>>>>>> (gdb) break CompileBroker::compile_method Breakpoint 2 at 
>>>>>>>>> 0xaef852: file 
>>>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/com
>>>>>>>>> piler/compileBroker.cpp,
>>>>>>>>>
>>>>>>>>> line 1205.
>>>>>>>>> (gdb) c
>>>>>>>>> Continuing.
>>>>>>>>> [New Thread 0xf7f93b70 (LWP 13460)] [New Thread 0xb4398b70 
>>>>>>>>> (LWP 13461)] [New Thread 0xb41ffb70 (LWP 13462)] [New Thread 
>>>>>>>>> 0xb3effb70 (LWP 13463)] [New Thread 0xb3cffb70 (LWP 13464)] 
>>>>>>>>> [New Thread 0xb3affb70 (LWP 13465)] [New Thread 0xb38ffb70 
>>>>>>>>> (LWP 13466)] [New Thread 0xb36ffb70 (LWP 13467)] [New Thread 
>>>>>>>>> 0xb34ffb70 (LWP 13468)] [New Thread 0xb32ffb70 (LWP 13469)] 
>>>>>>>>> [New Thread 0xb30ffb70 (LWP 13470)] [New Thread 0xb2effb70 
>>>>>>>>> (LWP 13471)] [New Thread 0xb2cffb70 (LWP 13472)] [New Thread 
>>>>>>>>> 0xaf8e8b70 (LWP 13473)] [New Thread 0xb4156b70 (LWP 13474)] 
>>>>>>>>> [New Thread 0xb3c7eb70 (LWP 13475)] [New Thread 0xb3a7eb70 
>>>>>>>>> (LWP 13476)] [New Thread 0xaeeffb70 (LWP 13477)] [New Thread 
>>>>>>>>> 0xaecffb70 (LWP 13478)] [New Thread 0xb387eb70 (LWP 13479)] 
>>>>>>>>> [New Thread 0xaeaffb70 (LWP 13480)] java version "1.8.0-ea"
>>>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86) Java 
>>>>>>>>> HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed 
>>>>>>>>> mode) [Thread 0xaeaffb70 (LWP 13480) exited] [Thread 
>>>>>>>>> 0xb3a7eb70 (LWP 13476) exited] [Thread 0xaf8e8b70 (LWP 13473) 
>>>>>>>>> exited] [Thread 0xf7fe4b70 (LWP 13459) exited] [Thread 
>>>>>>>>> 0xb2cffb70 (LWP 13472) exited] [Thread 0xb2effb70 (LWP 13471) 
>>>>>>>>> exited] [Thread 0xaecffb70 (LWP 13478) exited] [Thread 
>>>>>>>>> 0xb387eb70 (LWP 13479) exited] [Thread 0xaeeffb70 (LWP 13477) 
>>>>>>>>> exited] [Thread 0xb3c7eb70 (LWP 13475) exited] [Thread 
>>>>>>>>> 0xb4156b70 (LWP 13474) exited] [Thread 0xb32ffb70 (LWP 13469) 
>>>>>>>>> exited] [Thread 0xb34ffb70 (LWP 13468) exited] [Thread 
>>>>>>>>> 0xb36ffb70 (LWP 13467) exited] [Thread 0xb38ffb70 (LWP 13466) 
>>>>>>>>> exited] [Thread 0xb3affb70 (LWP 13465) exited] [Thread 
>>>>>>>>> 0xb3cffb70 (LWP 13464) exited] [Thread 0xb3effb70 (LWP 13463) 
>>>>>>>>> exited] [Thread 0xb41ffb70 (LWP 13462) exited] [Thread 
>>>>>>>>> 0xb4398b70 (LWP 13461) exited] [Thread 0xf7f93b70 (LWP 13460) 
>>>>>>>>> exited] [Thread 0xb30ffb70 (LWP 13470) exited]
>>>>>>>>>
>>>>>>>>> Program exited normally.
>>>>>>>>> (gdb)
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> cthaling at intelsdv01:/export/twisti/build/8008772/build/solaris
>>>>>>>>> _i486_compiler2/debug$
>>>>>>>>>
>>>>>>>>> /bin/bash ./hotspot -dbx -version
>>>>>>>>> dbx: warning: using the alternate init file: 
>>>>>>>>> /home/cthaling/.dbxrc Reading java Reading ld.so.1 Reading 
>>>>>>>>> libjli.so Reading libthread.so.1 Reading libdl.so.1 Reading 
>>>>>>>>> libc.so.1 Reading libjvm.so Loaded loadobject:
>>>>>>>>> /export/twisti/build/8008772/build/solaris_i486_compiler2/debu
>>>>>>>>> g/libjvm.so
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Running: java -Dsun.java.launcher=gamma 
>>>>>>>>> -XXaltjvm=/export/twisti/build/8008772/build/solaris_i486_comp
>>>>>>>>> iler2/debug
>>>>>>>>>
>>>>>>>>> -version
>>>>>>>>> (process id 29613)
>>>>>>>>> Reading libsocket.so.1
>>>>>>>>> Reading libsched.so.1
>>>>>>>>> Reading libm.so.1
>>>>>>>>> Reading libCrun.so.1
>>>>>>>>> Reading libdoor.so.1
>>>>>>>>> Reading libdemangle.so.1
>>>>>>>>> Reading libnsl.so.1
>>>>>>>>> Reading libm.so.2
>>>>>>>>> Reading libscf.so.1
>>>>>>>>> Reading libuutil.so.1
>>>>>>>>> Reading libgen.so.1
>>>>>>>>> Reading libmd.so.1
>>>>>>>>> Reading libmp.so.2
>>>>>>>>> t at 2 (l at 2) stopped in JNI_CreateJavaVM at line 5062 in file 
>>>>>>>>> "jni.cpp"
>>>>>>>>>   5062     jint result = JNI_ERR;
>>>>>>>>> (dbx) stop in CompileBroker::compile_method
>>>>>>>>> (2) stop in
>>>>>>>>> CompileBroker::compile_method(methodHandle,int,int,methodHandl
>>>>>>>>> e,int,const
>>>>>>>>>
>>>>>>>>> char*,Thread*)
>>>>>>>>> (dbx) c
>>>>>>>>> Reading libverify.so
>>>>>>>>> Reading libjava.so
>>>>>>>>> Reading libzip.so
>>>>>>>>> java version "1.8.0-ea"
>>>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86) Java 
>>>>>>>>> HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed 
>>>>>>>>> mode)
>>>>>>>>>
>>>>>>>>> execution completed, exit code is 0
>>>>>>>>> (dbx)
>>>>>>>>>
>>>>>>
>>>>
>>>
>


From vladimir.kozlov at oracle.com  Wed May  1 14:51:03 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Wed, 01 May 2013 14:51:03 -0700
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <00d901ce46b3$28037a90$780a6fb0$@tornqvist@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>	<51759F6B.7080808@oracle.com>	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>	<51764FDE.2090205@oracle.com>
	<517669A6.8030705@oracle.com>	<5176CD8E.5060704@oracle.com>	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>	<5176D417.3040202@oracle.com>
	<51817DED.2050603@oracle.com> <51818766.20604@oracle.com>
	<00d901ce46b3$28037a90$780a6fb0$@tornqvist@oracle.com>
Message-ID: <51818E47.1050605@oracle.com>

Somehow I got Nils's mail without attachment.

On 5/1/13 2:30 PM, Christian Tornqvist wrote:
> Hi Vladimir,
>
> Nils attached the patch to the email, but I've put the patch at
> http://cr.openjdk.java.net/~ctornqvi/webrev/vs.patch also

This looks good. Christian Thalinger will be happy :)

Thanks,
Vladimir

>
> Thanks,
> Christian
>
> -----Original Message-----
> From: hotspot-dev-bounces at openjdk.java.net
> [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
> Sent: den 1 maj 2013 17:22
> To: Nils Eliasson
> Cc: build-dev at openjdk.java.net; hotspot-dev developers; Christian Thalinger
> Subject: Re: RFR (M): 8008772: remove gamma launcher
>
> Nils,
>
> I don't see attached patch or webrev link.
>
> thanks,
> Vladimir
>
> On 5/1/13 1:41 PM, Nils Eliasson wrote:
>> Hi,
>>
>> Here is a patch that fixes so that it still works to create vcprojs,
>> and also sets defaults for the debugger commands.
>>
>> I have verified with creating vcprojs and debugging hotspot in VS 2010.
>> Works great except for an annoying pop-up that warns that the launcher
>> doesn't have debug symbols (if the target jdk doesn't).
>>
>> It will still be some extra work for those using the commandlines
>> plugin. All saved command lines need the be prepended with
>> "-XXaltjvm=$(TargetDir) -Dsun.java.launcher=gamma" and the target JDK
>> set as executable to work. We should update the plugin to help with that.
>>
>> A big thank you to Christian T?rnqvist for the proposal!
>>
>> //Nils
>>
>>
>> On 2013-04-23 20:33, Mikael Gerdin wrote:
>>>
>>> On 2013-04-23 20:28, Christian Thalinger wrote:
>>>>
>>>> On Apr 23, 2013, at 11:06 AM, Nils Eliasson
>>>> <nils.eliasson at oracle.com> wrote:
>>>>
>>>>> As long as we fix it first and remove gamma after - I would love to
>>>>> have some redundant code removed. I would fix it myself, I just
>>>>> don't think I will have the time before I go on parental leave.
>>>>
>>>> First, I'm not removing it tomorrow.  I expected a long discussion
>>>> :-)
>>>>
>>>> What exactly is the problem with Visual Studio?  Why can't you just
>>>> run the java launcher instead?
>>>>
>>>
>>> I don't know if there actually is a problem, but I don't think
>>> anyone's actually tried to tell it to use the java launcher.
>>> The VS project is automatically setup to launch "hotspot.exe" from
>>> the IDE. "hotspot.exe" is equivalent to the old option LINK_INTO=AOUT
>>> (IIRC) which involves linking all the VM object files into the launcher.
>>>
>>> Nils, perhaps you can at least try this before you leave?
>>>
>>> /Mikael
>>>
>>>> -- Chris
>>>>
>>>>>
>>>>> //Nils
>>>>>
>>>>> On 2013-04-23 12:59, Mikael Gerdin wrote:
>>>>>>
>>>>>>
>>>>>> On 2013-04-23 11:09, Nils Eliasson wrote:
>>>>>>> The gamma launcher is used to run and debug hotspot from Visual
>>>>>>> Studio.
>>>>>>> So removing gamma effectively kills the working environment for a
>>>>>>> number of people that use it daily.  So I am strongly against
>>>>>>> removing it.
>>>>>>
>>>>>> Maybe the visual studio project generator could be updated to
>>>>>> create a a "launch configuration" for launching java.exe from a
>>>>>> JDK and use the XXaltJVM flag on to select the correct jvm.dll?
>>>>>>
>>>>>> I agree that we shouldn't break the visual studio project but
>>>>>> currently there's nothing indicating that we can't fix it.
>>>>>>
>>>>>>
>>>>>> /Mikael
>>>>>>
>>>>>>>
>>>>>>> Most people working on Windows use Cygwin as the last resort
>>>>>>> since it makes a lot of thing excruciatingly slow.
>>>>>>>
>>>>>>> //Nils
>>>>>>>
>>>>>>> On 2013-04-22 22:55, Christian Thalinger wrote:
>>>>>>>> On Apr 22, 2013, at 1:36 PM, Daniel D. Daugherty
>>>>>>>> <daniel.daugherty at oracle.com> wrote:
>>>>>>>>
>>>>>>>>> Chris,
>>>>>>>>>
>>>>>>>>> Just an observation and not a review.
>>>>>>>>>
>>>>>>>>> Looks like you're removing launcher support on Windows, but it
>>>>>>>>> looks like the new hotspot.script doesn't support Windows...
>>>>>>>>> Am I missing something?
>>>>>>>> Almost certainly true.  Since I'm not a Windows user (and nobody
>>>>>>>> near me is one) I have no idea how people are using the gamma
>>>>>>>> launcher on Windows (or the hotspot script for that matter).
>>>>>>>>
>>>>>>>> I presume most people doing debugging on the command line are
>>>>>>>> already in cygwin?  But I might be wrong.
>>>>>>>>
>>>>>>>> -- Chris
>>>>>>>>
>>>>>>>>> Dan
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On 4/22/13 1:47 PM, Christian Thalinger wrote:
>>>>>>>>>> http://cr.openjdk.java.net/~twisti/8008772/
>>>>>>>>>>
>>>>>>>>>> 8008772: remove gamma launcher
>>>>>>>>>> Reviewed-by:
>>>>>>>>>>
>>>>>>>>>> Remove linking the gamma launcher and it's associated source
>>>>>>>>>> files.
>>>>>>>>>>
>>>>>>>>>> make/Makefile
>>>>>>>>>> make/bsd/makefiles/launcher.make make/bsd/makefiles/vm.make
>>>>>>>>>> make/hotspot.script make/linux/makefiles/launcher.make
>>>>>>>>>> make/linux/makefiles/vm.make
>>>>>>>>>> make/solaris/makefiles/launcher.make
>>>>>>>>>> make/solaris/makefiles/vm.make
>>>>>>>>>> make/windows/makefiles/debug.make
>>>>>>>>>> make/windows/makefiles/fastdebug.make
>>>>>>>>>> make/windows/makefiles/launcher.make
>>>>>>>>>> make/windows/makefiles/product.make
>>>>>>>>>> make/windows/makefiles/projectcreator.make
>>>>>>>>>> make/windows/projectfiles/common/Makefile
>>>>>>>>>> src/os/posix/launcher/java_md.c
>>>>>>>>>> src/os/posix/launcher/java_md.h
>>>>>>>>>> src/os/posix/launcher/launcher.script
>>>>>>>>>> src/os/windows/launcher/java_md.c
>>>>>>>>>> src/os/windows/launcher/java_md.h
>>>>>>>>>> src/share/tools/launcher/java.c
>>>>>>>>>> src/share/tools/launcher/java.h
>>>>>>>>>> src/share/tools/launcher/jli_util.c
>>>>>>>>>> src/share/tools/launcher/jli_util.h
>>>>>>>>>> src/share/tools/launcher/wildcard.c
>>>>>>>>>> src/share/tools/launcher/wildcard.h
>>>>>>>>>>
>>>>>>>>>> This change removes the duplicated java launcher files (which
>>>>>>>>>> were subject to bit-rot) and modifies the hotspot script to
>>>>>>>>>> pick up the libjvm in the current build directory.
>>>>>>>>>>
>>>>>>>>>> The modified hotspot script works with GDB and DBX:
>>>>>>>>>>
>>>>>>>>>> cthaling at intelsdv03.us.oracle.com:/export/twisti/build/8008772
>>>>>>>>>> /build/linux_i486_compiler2/debug$
>>>>>>>>>>
>>>>>>>>>> ./hotspot -gdb -version
>>>>>>>>>> GNU gdb (GDB) Red Hat Enterprise Linux (7.1-29.el6) Copyright
>>>>>>>>>> (C) 2010 Free Software Foundation, Inc.
>>>>>>>>>> License GPLv3+: GNU GPL version 3 or later
>>>>>>>>>> <http://gnu.org/licenses/gpl.html>
>>>>>>>>>> This is free software: you are free to change and redistribute it.
>>>>>>>>>> There is NO WARRANTY, to the extent permitted by law. Type
>>>>>>>>>> "show copying"
>>>>>>>>>> and "show warranty" for details.
>>>>>>>>>> This GDB was configured as "x86_64-redhat-linux-gnu".
>>>>>>>>>> For bug reporting instructions, please see:
>>>>>>>>>> <http://www.gnu.org/software/gdb/bugs/>.
>>>>>>>>>> Missing separate debuginfo for
>>>>>>>>>> /net/scanas404.us.oracle.com/export/java-re/jdk/8/ea/b86/binar
>>>>>>>>>> ies/linux-i586/bin/java
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Try: yum --disablerepo='*' --enablerepo='*-debuginfo' install
>>>>>>>>>> /usr/lib/debug/.build-id/5e/85e6dced3b388a7b0e50630242f4c7ee5e
>>>>>>>>>> 31a3.debug
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Function "JNI_CreateJavaVM" not defined.
>>>>>>>>>> Breakpoint 1 (JNI_CreateJavaVM) pending.
>>>>>>>>>> [Thread debugging using libthread_db enabled] [New Thread
>>>>>>>>>> 0xf7fe4b70 (LWP 13459)] [Switching to Thread 0xf7fe4b70 (LWP
>>>>>>>>>> 13459)]
>>>>>>>>>>
>>>>>>>>>> Breakpoint 1, JNI_CreateJavaVM (vm=0xf7fe4378,
>>>>>>>>>> penv=0xf7fe4374,
>>>>>>>>>> args=0xf7fe4364)
>>>>>>>>>>       at
>>>>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/pri
>>>>>>>>>> ms/jni.cpp:5062
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> 5062      jint result = JNI_ERR;
>>>>>>>>>> Missing separate debuginfos, use: debuginfo-install
>>>>>>>>>> glibc-2.12-1.7.el6.i686
>>>>>>>>>> (gdb) break CompileBroker::compile_method Breakpoint 2 at
>>>>>>>>>> 0xaef852: file
>>>>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/com
>>>>>>>>>> piler/compileBroker.cpp,
>>>>>>>>>>
>>>>>>>>>> line 1205.
>>>>>>>>>> (gdb) c
>>>>>>>>>> Continuing.
>>>>>>>>>> [New Thread 0xf7f93b70 (LWP 13460)] [New Thread 0xb4398b70
>>>>>>>>>> (LWP 13461)] [New Thread 0xb41ffb70 (LWP 13462)] [New Thread
>>>>>>>>>> 0xb3effb70 (LWP 13463)] [New Thread 0xb3cffb70 (LWP 13464)]
>>>>>>>>>> [New Thread 0xb3affb70 (LWP 13465)] [New Thread 0xb38ffb70
>>>>>>>>>> (LWP 13466)] [New Thread 0xb36ffb70 (LWP 13467)] [New Thread
>>>>>>>>>> 0xb34ffb70 (LWP 13468)] [New Thread 0xb32ffb70 (LWP 13469)]
>>>>>>>>>> [New Thread 0xb30ffb70 (LWP 13470)] [New Thread 0xb2effb70
>>>>>>>>>> (LWP 13471)] [New Thread 0xb2cffb70 (LWP 13472)] [New Thread
>>>>>>>>>> 0xaf8e8b70 (LWP 13473)] [New Thread 0xb4156b70 (LWP 13474)]
>>>>>>>>>> [New Thread 0xb3c7eb70 (LWP 13475)] [New Thread 0xb3a7eb70
>>>>>>>>>> (LWP 13476)] [New Thread 0xaeeffb70 (LWP 13477)] [New Thread
>>>>>>>>>> 0xaecffb70 (LWP 13478)] [New Thread 0xb387eb70 (LWP 13479)]
>>>>>>>>>> [New Thread 0xaeaffb70 (LWP 13480)] java version "1.8.0-ea"
>>>>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86) Java
>>>>>>>>>> HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed
>>>>>>>>>> mode) [Thread 0xaeaffb70 (LWP 13480) exited] [Thread
>>>>>>>>>> 0xb3a7eb70 (LWP 13476) exited] [Thread 0xaf8e8b70 (LWP 13473)
>>>>>>>>>> exited] [Thread 0xf7fe4b70 (LWP 13459) exited] [Thread
>>>>>>>>>> 0xb2cffb70 (LWP 13472) exited] [Thread 0xb2effb70 (LWP 13471)
>>>>>>>>>> exited] [Thread 0xaecffb70 (LWP 13478) exited] [Thread
>>>>>>>>>> 0xb387eb70 (LWP 13479) exited] [Thread 0xaeeffb70 (LWP 13477)
>>>>>>>>>> exited] [Thread 0xb3c7eb70 (LWP 13475) exited] [Thread
>>>>>>>>>> 0xb4156b70 (LWP 13474) exited] [Thread 0xb32ffb70 (LWP 13469)
>>>>>>>>>> exited] [Thread 0xb34ffb70 (LWP 13468) exited] [Thread
>>>>>>>>>> 0xb36ffb70 (LWP 13467) exited] [Thread 0xb38ffb70 (LWP 13466)
>>>>>>>>>> exited] [Thread 0xb3affb70 (LWP 13465) exited] [Thread
>>>>>>>>>> 0xb3cffb70 (LWP 13464) exited] [Thread 0xb3effb70 (LWP 13463)
>>>>>>>>>> exited] [Thread 0xb41ffb70 (LWP 13462) exited] [Thread
>>>>>>>>>> 0xb4398b70 (LWP 13461) exited] [Thread 0xf7f93b70 (LWP 13460)
>>>>>>>>>> exited] [Thread 0xb30ffb70 (LWP 13470) exited]
>>>>>>>>>>
>>>>>>>>>> Program exited normally.
>>>>>>>>>> (gdb)
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> cthaling at intelsdv01:/export/twisti/build/8008772/build/solaris
>>>>>>>>>> _i486_compiler2/debug$
>>>>>>>>>>
>>>>>>>>>> /bin/bash ./hotspot -dbx -version
>>>>>>>>>> dbx: warning: using the alternate init file:
>>>>>>>>>> /home/cthaling/.dbxrc Reading java Reading ld.so.1 Reading
>>>>>>>>>> libjli.so Reading libthread.so.1 Reading libdl.so.1 Reading
>>>>>>>>>> libc.so.1 Reading libjvm.so Loaded loadobject:
>>>>>>>>>> /export/twisti/build/8008772/build/solaris_i486_compiler2/debu
>>>>>>>>>> g/libjvm.so
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Running: java -Dsun.java.launcher=gamma
>>>>>>>>>> -XXaltjvm=/export/twisti/build/8008772/build/solaris_i486_comp
>>>>>>>>>> iler2/debug
>>>>>>>>>>
>>>>>>>>>> -version
>>>>>>>>>> (process id 29613)
>>>>>>>>>> Reading libsocket.so.1
>>>>>>>>>> Reading libsched.so.1
>>>>>>>>>> Reading libm.so.1
>>>>>>>>>> Reading libCrun.so.1
>>>>>>>>>> Reading libdoor.so.1
>>>>>>>>>> Reading libdemangle.so.1
>>>>>>>>>> Reading libnsl.so.1
>>>>>>>>>> Reading libm.so.2
>>>>>>>>>> Reading libscf.so.1
>>>>>>>>>> Reading libuutil.so.1
>>>>>>>>>> Reading libgen.so.1
>>>>>>>>>> Reading libmd.so.1
>>>>>>>>>> Reading libmp.so.2
>>>>>>>>>> t at 2 (l at 2) stopped in JNI_CreateJavaVM at line 5062 in file
>>>>>>>>>> "jni.cpp"
>>>>>>>>>>    5062     jint result = JNI_ERR;
>>>>>>>>>> (dbx) stop in CompileBroker::compile_method
>>>>>>>>>> (2) stop in
>>>>>>>>>> CompileBroker::compile_method(methodHandle,int,int,methodHandl
>>>>>>>>>> e,int,const
>>>>>>>>>>
>>>>>>>>>> char*,Thread*)
>>>>>>>>>> (dbx) c
>>>>>>>>>> Reading libverify.so
>>>>>>>>>> Reading libjava.so
>>>>>>>>>> Reading libzip.so
>>>>>>>>>> java version "1.8.0-ea"
>>>>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86) Java
>>>>>>>>>> HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed
>>>>>>>>>> mode)
>>>>>>>>>>
>>>>>>>>>> execution completed, exit code is 0
>>>>>>>>>> (dbx)
>>>>>>>>>>
>>>>>>>
>>>>>
>>>>
>>
>

From tim.bell at oracle.com  Wed May  1 15:03:14 2013
From: tim.bell at oracle.com (Tim Bell)
Date: Wed, 01 May 2013 15:03:14 -0700
Subject: Somehow I got Nils's mail without attachment. [RFR (M): 8008772:
	remove gamma launcher]
In-Reply-To: <51818E47.1050605@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>	<51759F6B.7080808@oracle.com>	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>	<51764FDE.2090205@oracle.com>
	<517669A6.8030705@oracle.com>	<5176CD8E.5060704@oracle.com>	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>	<5176D417.3040202@oracle.com>
	<51817DED.2050603@oracle.com> <51818766.20604@oracle.com>
	<00d901ce46b3$28037a90$780a6fb0$@tornqvist@oracle.com>
	<51818E47.1050605@oracle.com>
Message-ID: <51819122.5030109@oracle.com>

Off topic (sorry) but as a mail.ojn list administrator, I can't help it.

the attachment was not one of these MIME types:

multipart/mixed
multipart/alternative
text/plain
message/rfc822

As such, it was filtered (removed) by the mailing list.

What is the MIME type of a .patch file?  Maybe we can modify the filter 
rules to pass them through.

Tim


On 05/ 1/13 02:51 PM, Vladimir Kozlov wrote:
> Somehow I got Nils's mail without attachment.
>
> On 5/1/13 2:30 PM, Christian Tornqvist wrote:
>> Hi Vladimir,
>>
>> Nils attached the patch to the email, but I've put the patch at
>> http://cr.openjdk.java.net/~ctornqvi/webrev/vs.patch also
>
> This looks good. Christian Thalinger will be happy :)
>
> Thanks,
> Vladimir
>
>>
>> Thanks,
>> Christian
>>
>> -----Original Message-----
>> From: hotspot-dev-bounces at openjdk.java.net
>> [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Vladimir 
>> Kozlov
>> Sent: den 1 maj 2013 17:22
>> To: Nils Eliasson
>> Cc: build-dev at openjdk.java.net; hotspot-dev developers; Christian 
>> Thalinger
>> Subject: Re: RFR (M): 8008772: remove gamma launcher
>>
>> Nils,
>>
>> I don't see attached patch or webrev link.
>>
>> thanks,
>> Vladimir
>>
>> On 5/1/13 1:41 PM, Nils Eliasson wrote:
>>> Hi,
>>>
>>> Here is a patch that fixes so that it still works to create vcprojs,
>>> and also sets defaults for the debugger commands.
>>>
>>> I have verified with creating vcprojs and debugging hotspot in VS 2010.
>>> Works great except for an annoying pop-up that warns that the launcher
>>> doesn't have debug symbols (if the target jdk doesn't).
>>>
>>> It will still be some extra work for those using the commandlines
>>> plugin. All saved command lines need the be prepended with
>>> "-XXaltjvm=$(TargetDir) -Dsun.java.launcher=gamma" and the target JDK
>>> set as executable to work. We should update the plugin to help with 
>>> that.
>>>
>>> A big thank you to Christian T?rnqvist for the proposal!
>>>
>>> //Nils
>>>
>>>
>>> On 2013-04-23 20:33, Mikael Gerdin wrote:
>>>>
>>>> On 2013-04-23 20:28, Christian Thalinger wrote:
>>>>>
>>>>> On Apr 23, 2013, at 11:06 AM, Nils Eliasson
>>>>> <nils.eliasson at oracle.com> wrote:
>>>>>
>>>>>> As long as we fix it first and remove gamma after - I would love to
>>>>>> have some redundant code removed. I would fix it myself, I just
>>>>>> don't think I will have the time before I go on parental leave.
>>>>>
>>>>> First, I'm not removing it tomorrow.  I expected a long discussion
>>>>> :-)
>>>>>
>>>>> What exactly is the problem with Visual Studio?  Why can't you just
>>>>> run the java launcher instead?
>>>>>
>>>>
>>>> I don't know if there actually is a problem, but I don't think
>>>> anyone's actually tried to tell it to use the java launcher.
>>>> The VS project is automatically setup to launch "hotspot.exe" from
>>>> the IDE. "hotspot.exe" is equivalent to the old option LINK_INTO=AOUT
>>>> (IIRC) which involves linking all the VM object files into the 
>>>> launcher.
>>>>
>>>> Nils, perhaps you can at least try this before you leave?
>>>>
>>>> /Mikael
>>>>
>>>>> -- Chris
>>>>>
>>>>>>
>>>>>> //Nils
>>>>>>
>>>>>> On 2013-04-23 12:59, Mikael Gerdin wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 2013-04-23 11:09, Nils Eliasson wrote:
>>>>>>>> The gamma launcher is used to run and debug hotspot from Visual
>>>>>>>> Studio.
>>>>>>>> So removing gamma effectively kills the working environment for a
>>>>>>>> number of people that use it daily.  So I am strongly against
>>>>>>>> removing it.
>>>>>>>
>>>>>>> Maybe the visual studio project generator could be updated to
>>>>>>> create a a "launch configuration" for launching java.exe from a
>>>>>>> JDK and use the XXaltJVM flag on to select the correct jvm.dll?
>>>>>>>
>>>>>>> I agree that we shouldn't break the visual studio project but
>>>>>>> currently there's nothing indicating that we can't fix it.
>>>>>>>
>>>>>>>
>>>>>>> /Mikael
>>>>>>>
>>>>>>>>
>>>>>>>> Most people working on Windows use Cygwin as the last resort
>>>>>>>> since it makes a lot of thing excruciatingly slow.
>>>>>>>>
>>>>>>>> //Nils
>>>>>>>>
>>>>>>>> On 2013-04-22 22:55, Christian Thalinger wrote:
>>>>>>>>> On Apr 22, 2013, at 1:36 PM, Daniel D. Daugherty
>>>>>>>>> <daniel.daugherty at oracle.com> wrote:
>>>>>>>>>
>>>>>>>>>> Chris,
>>>>>>>>>>
>>>>>>>>>> Just an observation and not a review.
>>>>>>>>>>
>>>>>>>>>> Looks like you're removing launcher support on Windows, but it
>>>>>>>>>> looks like the new hotspot.script doesn't support Windows...
>>>>>>>>>> Am I missing something?
>>>>>>>>> Almost certainly true.  Since I'm not a Windows user (and nobody
>>>>>>>>> near me is one) I have no idea how people are using the gamma
>>>>>>>>> launcher on Windows (or the hotspot script for that matter).
>>>>>>>>>
>>>>>>>>> I presume most people doing debugging on the command line are
>>>>>>>>> already in cygwin?  But I might be wrong.
>>>>>>>>>
>>>>>>>>> -- Chris
>>>>>>>>>
>>>>>>>>>> Dan
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On 4/22/13 1:47 PM, Christian Thalinger wrote:
>>>>>>>>>>> http://cr.openjdk.java.net/~twisti/8008772/
>>>>>>>>>>>
>>>>>>>>>>> 8008772: remove gamma launcher
>>>>>>>>>>> Reviewed-by:
>>>>>>>>>>>
>>>>>>>>>>> Remove linking the gamma launcher and it's associated source
>>>>>>>>>>> files.
>>>>>>>>>>>
>>>>>>>>>>> make/Makefile
>>>>>>>>>>> make/bsd/makefiles/launcher.make make/bsd/makefiles/vm.make
>>>>>>>>>>> make/hotspot.script make/linux/makefiles/launcher.make
>>>>>>>>>>> make/linux/makefiles/vm.make
>>>>>>>>>>> make/solaris/makefiles/launcher.make
>>>>>>>>>>> make/solaris/makefiles/vm.make
>>>>>>>>>>> make/windows/makefiles/debug.make
>>>>>>>>>>> make/windows/makefiles/fastdebug.make
>>>>>>>>>>> make/windows/makefiles/launcher.make
>>>>>>>>>>> make/windows/makefiles/product.make
>>>>>>>>>>> make/windows/makefiles/projectcreator.make
>>>>>>>>>>> make/windows/projectfiles/common/Makefile
>>>>>>>>>>> src/os/posix/launcher/java_md.c
>>>>>>>>>>> src/os/posix/launcher/java_md.h
>>>>>>>>>>> src/os/posix/launcher/launcher.script
>>>>>>>>>>> src/os/windows/launcher/java_md.c
>>>>>>>>>>> src/os/windows/launcher/java_md.h
>>>>>>>>>>> src/share/tools/launcher/java.c
>>>>>>>>>>> src/share/tools/launcher/java.h
>>>>>>>>>>> src/share/tools/launcher/jli_util.c
>>>>>>>>>>> src/share/tools/launcher/jli_util.h
>>>>>>>>>>> src/share/tools/launcher/wildcard.c
>>>>>>>>>>> src/share/tools/launcher/wildcard.h
>>>>>>>>>>>
>>>>>>>>>>> This change removes the duplicated java launcher files (which
>>>>>>>>>>> were subject to bit-rot) and modifies the hotspot script to
>>>>>>>>>>> pick up the libjvm in the current build directory.
>>>>>>>>>>>
>>>>>>>>>>> The modified hotspot script works with GDB and DBX:
>>>>>>>>>>>
>>>>>>>>>>> cthaling at intelsdv03.us.oracle.com:/export/twisti/build/8008772
>>>>>>>>>>> /build/linux_i486_compiler2/debug$
>>>>>>>>>>>
>>>>>>>>>>> ./hotspot -gdb -version
>>>>>>>>>>> GNU gdb (GDB) Red Hat Enterprise Linux (7.1-29.el6) Copyright
>>>>>>>>>>> (C) 2010 Free Software Foundation, Inc.
>>>>>>>>>>> License GPLv3+: GNU GPL version 3 or later
>>>>>>>>>>> <http://gnu.org/licenses/gpl.html>
>>>>>>>>>>> This is free software: you are free to change and 
>>>>>>>>>>> redistribute it.
>>>>>>>>>>> There is NO WARRANTY, to the extent permitted by law. Type
>>>>>>>>>>> "show copying"
>>>>>>>>>>> and "show warranty" for details.
>>>>>>>>>>> This GDB was configured as "x86_64-redhat-linux-gnu".
>>>>>>>>>>> For bug reporting instructions, please see:
>>>>>>>>>>> <http://www.gnu.org/software/gdb/bugs/>.
>>>>>>>>>>> Missing separate debuginfo for
>>>>>>>>>>> /net/scanas404.us.oracle.com/export/java-re/jdk/8/ea/b86/binar
>>>>>>>>>>> ies/linux-i586/bin/java
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Try: yum --disablerepo='*' --enablerepo='*-debuginfo' install
>>>>>>>>>>> /usr/lib/debug/.build-id/5e/85e6dced3b388a7b0e50630242f4c7ee5e
>>>>>>>>>>> 31a3.debug
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Function "JNI_CreateJavaVM" not defined.
>>>>>>>>>>> Breakpoint 1 (JNI_CreateJavaVM) pending.
>>>>>>>>>>> [Thread debugging using libthread_db enabled] [New Thread
>>>>>>>>>>> 0xf7fe4b70 (LWP 13459)] [Switching to Thread 0xf7fe4b70 (LWP
>>>>>>>>>>> 13459)]
>>>>>>>>>>>
>>>>>>>>>>> Breakpoint 1, JNI_CreateJavaVM (vm=0xf7fe4378,
>>>>>>>>>>> penv=0xf7fe4374,
>>>>>>>>>>> args=0xf7fe4364)
>>>>>>>>>>>       at
>>>>>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/pri
>>>>>>>>>>> ms/jni.cpp:5062
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> 5062      jint result = JNI_ERR;
>>>>>>>>>>> Missing separate debuginfos, use: debuginfo-install
>>>>>>>>>>> glibc-2.12-1.7.el6.i686
>>>>>>>>>>> (gdb) break CompileBroker::compile_method Breakpoint 2 at
>>>>>>>>>>> 0xaef852: file
>>>>>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/com
>>>>>>>>>>> piler/compileBroker.cpp,
>>>>>>>>>>>
>>>>>>>>>>> line 1205.
>>>>>>>>>>> (gdb) c
>>>>>>>>>>> Continuing.
>>>>>>>>>>> [New Thread 0xf7f93b70 (LWP 13460)] [New Thread 0xb4398b70
>>>>>>>>>>> (LWP 13461)] [New Thread 0xb41ffb70 (LWP 13462)] [New Thread
>>>>>>>>>>> 0xb3effb70 (LWP 13463)] [New Thread 0xb3cffb70 (LWP 13464)]
>>>>>>>>>>> [New Thread 0xb3affb70 (LWP 13465)] [New Thread 0xb38ffb70
>>>>>>>>>>> (LWP 13466)] [New Thread 0xb36ffb70 (LWP 13467)] [New Thread
>>>>>>>>>>> 0xb34ffb70 (LWP 13468)] [New Thread 0xb32ffb70 (LWP 13469)]
>>>>>>>>>>> [New Thread 0xb30ffb70 (LWP 13470)] [New Thread 0xb2effb70
>>>>>>>>>>> (LWP 13471)] [New Thread 0xb2cffb70 (LWP 13472)] [New Thread
>>>>>>>>>>> 0xaf8e8b70 (LWP 13473)] [New Thread 0xb4156b70 (LWP 13474)]
>>>>>>>>>>> [New Thread 0xb3c7eb70 (LWP 13475)] [New Thread 0xb3a7eb70
>>>>>>>>>>> (LWP 13476)] [New Thread 0xaeeffb70 (LWP 13477)] [New Thread
>>>>>>>>>>> 0xaecffb70 (LWP 13478)] [New Thread 0xb387eb70 (LWP 13479)]
>>>>>>>>>>> [New Thread 0xaeaffb70 (LWP 13480)] java version "1.8.0-ea"
>>>>>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86) Java
>>>>>>>>>>> HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed
>>>>>>>>>>> mode) [Thread 0xaeaffb70 (LWP 13480) exited] [Thread
>>>>>>>>>>> 0xb3a7eb70 (LWP 13476) exited] [Thread 0xaf8e8b70 (LWP 13473)
>>>>>>>>>>> exited] [Thread 0xf7fe4b70 (LWP 13459) exited] [Thread
>>>>>>>>>>> 0xb2cffb70 (LWP 13472) exited] [Thread 0xb2effb70 (LWP 13471)
>>>>>>>>>>> exited] [Thread 0xaecffb70 (LWP 13478) exited] [Thread
>>>>>>>>>>> 0xb387eb70 (LWP 13479) exited] [Thread 0xaeeffb70 (LWP 13477)
>>>>>>>>>>> exited] [Thread 0xb3c7eb70 (LWP 13475) exited] [Thread
>>>>>>>>>>> 0xb4156b70 (LWP 13474) exited] [Thread 0xb32ffb70 (LWP 13469)
>>>>>>>>>>> exited] [Thread 0xb34ffb70 (LWP 13468) exited] [Thread
>>>>>>>>>>> 0xb36ffb70 (LWP 13467) exited] [Thread 0xb38ffb70 (LWP 13466)
>>>>>>>>>>> exited] [Thread 0xb3affb70 (LWP 13465) exited] [Thread
>>>>>>>>>>> 0xb3cffb70 (LWP 13464) exited] [Thread 0xb3effb70 (LWP 13463)
>>>>>>>>>>> exited] [Thread 0xb41ffb70 (LWP 13462) exited] [Thread
>>>>>>>>>>> 0xb4398b70 (LWP 13461) exited] [Thread 0xf7f93b70 (LWP 13460)
>>>>>>>>>>> exited] [Thread 0xb30ffb70 (LWP 13470) exited]
>>>>>>>>>>>
>>>>>>>>>>> Program exited normally.
>>>>>>>>>>> (gdb)
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> cthaling at intelsdv01:/export/twisti/build/8008772/build/solaris
>>>>>>>>>>> _i486_compiler2/debug$
>>>>>>>>>>>
>>>>>>>>>>> /bin/bash ./hotspot -dbx -version
>>>>>>>>>>> dbx: warning: using the alternate init file:
>>>>>>>>>>> /home/cthaling/.dbxrc Reading java Reading ld.so.1 Reading
>>>>>>>>>>> libjli.so Reading libthread.so.1 Reading libdl.so.1 Reading
>>>>>>>>>>> libc.so.1 Reading libjvm.so Loaded loadobject:
>>>>>>>>>>> /export/twisti/build/8008772/build/solaris_i486_compiler2/debu
>>>>>>>>>>> g/libjvm.so
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Running: java -Dsun.java.launcher=gamma
>>>>>>>>>>> -XXaltjvm=/export/twisti/build/8008772/build/solaris_i486_comp
>>>>>>>>>>> iler2/debug
>>>>>>>>>>>
>>>>>>>>>>> -version
>>>>>>>>>>> (process id 29613)
>>>>>>>>>>> Reading libsocket.so.1
>>>>>>>>>>> Reading libsched.so.1
>>>>>>>>>>> Reading libm.so.1
>>>>>>>>>>> Reading libCrun.so.1
>>>>>>>>>>> Reading libdoor.so.1
>>>>>>>>>>> Reading libdemangle.so.1
>>>>>>>>>>> Reading libnsl.so.1
>>>>>>>>>>> Reading libm.so.2
>>>>>>>>>>> Reading libscf.so.1
>>>>>>>>>>> Reading libuutil.so.1
>>>>>>>>>>> Reading libgen.so.1
>>>>>>>>>>> Reading libmd.so.1
>>>>>>>>>>> Reading libmp.so.2
>>>>>>>>>>> t at 2 (l at 2) stopped in JNI_CreateJavaVM at line 5062 in file
>>>>>>>>>>> "jni.cpp"
>>>>>>>>>>>    5062     jint result = JNI_ERR;
>>>>>>>>>>> (dbx) stop in CompileBroker::compile_method
>>>>>>>>>>> (2) stop in
>>>>>>>>>>> CompileBroker::compile_method(methodHandle,int,int,methodHandl
>>>>>>>>>>> e,int,const
>>>>>>>>>>>
>>>>>>>>>>> char*,Thread*)
>>>>>>>>>>> (dbx) c
>>>>>>>>>>> Reading libverify.so
>>>>>>>>>>> Reading libjava.so
>>>>>>>>>>> Reading libzip.so
>>>>>>>>>>> java version "1.8.0-ea"
>>>>>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86) Java
>>>>>>>>>>> HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed
>>>>>>>>>>> mode)
>>>>>>>>>>>
>>>>>>>>>>> execution completed, exit code is 0
>>>>>>>>>>> (dbx)
>>>>>>>>>>>
>>>>>>>>
>>>>>>
>>>>>
>>>
>>


From mikael.gerdin at oracle.com  Thu May  2 00:27:20 2013
From: mikael.gerdin at oracle.com (Mikael Gerdin)
Date: Thu, 02 May 2013 09:27:20 +0200
Subject: Somehow I got Nils's mail without attachment. [RFR (M): 8008772:
	remove gamma launcher]
In-Reply-To: <51819122.5030109@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>	<51759F6B.7080808@oracle.com>	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>	<51764FDE.2090205@oracle.com>
	<517669A6.8030705@oracle.com>	<5176CD8E.5060704@oracle.com>	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>	<5176D417.3040202@oracle.com>
	<51817DED.2050603@oracle.com> <51818766.20604@oracle.com>
	<00d901ce46b3$28037a90$780a6fb0$@tornqvist@oracle.com>
	<51818E47.1050605@oracle.com> <51819122.5030109@oracle.com>
Message-ID: <51821558.6080106@oracle.com>

Tim,

On 2013-05-02 00:03, Tim Bell wrote:
> Off topic (sorry) but as a mail.ojn list administrator, I can't help it.
>
> the attachment was not one of these MIME types:
>
> multipart/mixed
> multipart/alternative
> text/plain
> message/rfc822
>
> As such, it was filtered (removed) by the mailing list.
>
> What is the MIME type of a .patch file?  Maybe we can modify the filter
> rules to pass them through.

In Nils' mail the patch had the following header:
Content-Type: text/x-patch;
  name="VS with JDK launcher.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
  filename="VS with JDK launcher.patch"

I've also seen patches with MIME type text/x-diff

/Mikael


>
> Tim
>
>
> On 05/ 1/13 02:51 PM, Vladimir Kozlov wrote:
>> Somehow I got Nils's mail without attachment.
>>
>> On 5/1/13 2:30 PM, Christian Tornqvist wrote:
>>> Hi Vladimir,
>>>
>>> Nils attached the patch to the email, but I've put the patch at
>>> http://cr.openjdk.java.net/~ctornqvi/webrev/vs.patch also
>>
>> This looks good. Christian Thalinger will be happy :)
>>
>> Thanks,
>> Vladimir
>>
>>>
>>> Thanks,
>>> Christian
>>>
>>> -----Original Message-----
>>> From: hotspot-dev-bounces at openjdk.java.net
>>> [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Vladimir
>>> Kozlov
>>> Sent: den 1 maj 2013 17:22
>>> To: Nils Eliasson
>>> Cc: build-dev at openjdk.java.net; hotspot-dev developers; Christian
>>> Thalinger
>>> Subject: Re: RFR (M): 8008772: remove gamma launcher
>>>
>>> Nils,
>>>
>>> I don't see attached patch or webrev link.
>>>
>>> thanks,
>>> Vladimir
>>>
>>> On 5/1/13 1:41 PM, Nils Eliasson wrote:
>>>> Hi,
>>>>
>>>> Here is a patch that fixes so that it still works to create vcprojs,
>>>> and also sets defaults for the debugger commands.
>>>>
>>>> I have verified with creating vcprojs and debugging hotspot in VS 2010.
>>>> Works great except for an annoying pop-up that warns that the launcher
>>>> doesn't have debug symbols (if the target jdk doesn't).
>>>>
>>>> It will still be some extra work for those using the commandlines
>>>> plugin. All saved command lines need the be prepended with
>>>> "-XXaltjvm=$(TargetDir) -Dsun.java.launcher=gamma" and the target JDK
>>>> set as executable to work. We should update the plugin to help with
>>>> that.
>>>>
>>>> A big thank you to Christian T?rnqvist for the proposal!
>>>>
>>>> //Nils
>>>>
>>>>
>>>> On 2013-04-23 20:33, Mikael Gerdin wrote:
>>>>>
>>>>> On 2013-04-23 20:28, Christian Thalinger wrote:
>>>>>>
>>>>>> On Apr 23, 2013, at 11:06 AM, Nils Eliasson
>>>>>> <nils.eliasson at oracle.com> wrote:
>>>>>>
>>>>>>> As long as we fix it first and remove gamma after - I would love to
>>>>>>> have some redundant code removed. I would fix it myself, I just
>>>>>>> don't think I will have the time before I go on parental leave.
>>>>>>
>>>>>> First, I'm not removing it tomorrow.  I expected a long discussion
>>>>>> :-)
>>>>>>
>>>>>> What exactly is the problem with Visual Studio?  Why can't you just
>>>>>> run the java launcher instead?
>>>>>>
>>>>>
>>>>> I don't know if there actually is a problem, but I don't think
>>>>> anyone's actually tried to tell it to use the java launcher.
>>>>> The VS project is automatically setup to launch "hotspot.exe" from
>>>>> the IDE. "hotspot.exe" is equivalent to the old option LINK_INTO=AOUT
>>>>> (IIRC) which involves linking all the VM object files into the
>>>>> launcher.
>>>>>
>>>>> Nils, perhaps you can at least try this before you leave?
>>>>>
>>>>> /Mikael
>>>>>
>>>>>> -- Chris
>>>>>>
>>>>>>>
>>>>>>> //Nils
>>>>>>>
>>>>>>> On 2013-04-23 12:59, Mikael Gerdin wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> On 2013-04-23 11:09, Nils Eliasson wrote:
>>>>>>>>> The gamma launcher is used to run and debug hotspot from Visual
>>>>>>>>> Studio.
>>>>>>>>> So removing gamma effectively kills the working environment for a
>>>>>>>>> number of people that use it daily.  So I am strongly against
>>>>>>>>> removing it.
>>>>>>>>
>>>>>>>> Maybe the visual studio project generator could be updated to
>>>>>>>> create a a "launch configuration" for launching java.exe from a
>>>>>>>> JDK and use the XXaltJVM flag on to select the correct jvm.dll?
>>>>>>>>
>>>>>>>> I agree that we shouldn't break the visual studio project but
>>>>>>>> currently there's nothing indicating that we can't fix it.
>>>>>>>>
>>>>>>>>
>>>>>>>> /Mikael
>>>>>>>>
>>>>>>>>>
>>>>>>>>> Most people working on Windows use Cygwin as the last resort
>>>>>>>>> since it makes a lot of thing excruciatingly slow.
>>>>>>>>>
>>>>>>>>> //Nils
>>>>>>>>>
>>>>>>>>> On 2013-04-22 22:55, Christian Thalinger wrote:
>>>>>>>>>> On Apr 22, 2013, at 1:36 PM, Daniel D. Daugherty
>>>>>>>>>> <daniel.daugherty at oracle.com> wrote:
>>>>>>>>>>
>>>>>>>>>>> Chris,
>>>>>>>>>>>
>>>>>>>>>>> Just an observation and not a review.
>>>>>>>>>>>
>>>>>>>>>>> Looks like you're removing launcher support on Windows, but it
>>>>>>>>>>> looks like the new hotspot.script doesn't support Windows...
>>>>>>>>>>> Am I missing something?
>>>>>>>>>> Almost certainly true.  Since I'm not a Windows user (and nobody
>>>>>>>>>> near me is one) I have no idea how people are using the gamma
>>>>>>>>>> launcher on Windows (or the hotspot script for that matter).
>>>>>>>>>>
>>>>>>>>>> I presume most people doing debugging on the command line are
>>>>>>>>>> already in cygwin?  But I might be wrong.
>>>>>>>>>>
>>>>>>>>>> -- Chris
>>>>>>>>>>
>>>>>>>>>>> Dan
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On 4/22/13 1:47 PM, Christian Thalinger wrote:
>>>>>>>>>>>> http://cr.openjdk.java.net/~twisti/8008772/
>>>>>>>>>>>>
>>>>>>>>>>>> 8008772: remove gamma launcher
>>>>>>>>>>>> Reviewed-by:
>>>>>>>>>>>>
>>>>>>>>>>>> Remove linking the gamma launcher and it's associated source
>>>>>>>>>>>> files.
>>>>>>>>>>>>
>>>>>>>>>>>> make/Makefile
>>>>>>>>>>>> make/bsd/makefiles/launcher.make make/bsd/makefiles/vm.make
>>>>>>>>>>>> make/hotspot.script make/linux/makefiles/launcher.make
>>>>>>>>>>>> make/linux/makefiles/vm.make
>>>>>>>>>>>> make/solaris/makefiles/launcher.make
>>>>>>>>>>>> make/solaris/makefiles/vm.make
>>>>>>>>>>>> make/windows/makefiles/debug.make
>>>>>>>>>>>> make/windows/makefiles/fastdebug.make
>>>>>>>>>>>> make/windows/makefiles/launcher.make
>>>>>>>>>>>> make/windows/makefiles/product.make
>>>>>>>>>>>> make/windows/makefiles/projectcreator.make
>>>>>>>>>>>> make/windows/projectfiles/common/Makefile
>>>>>>>>>>>> src/os/posix/launcher/java_md.c
>>>>>>>>>>>> src/os/posix/launcher/java_md.h
>>>>>>>>>>>> src/os/posix/launcher/launcher.script
>>>>>>>>>>>> src/os/windows/launcher/java_md.c
>>>>>>>>>>>> src/os/windows/launcher/java_md.h
>>>>>>>>>>>> src/share/tools/launcher/java.c
>>>>>>>>>>>> src/share/tools/launcher/java.h
>>>>>>>>>>>> src/share/tools/launcher/jli_util.c
>>>>>>>>>>>> src/share/tools/launcher/jli_util.h
>>>>>>>>>>>> src/share/tools/launcher/wildcard.c
>>>>>>>>>>>> src/share/tools/launcher/wildcard.h
>>>>>>>>>>>>
>>>>>>>>>>>> This change removes the duplicated java launcher files (which
>>>>>>>>>>>> were subject to bit-rot) and modifies the hotspot script to
>>>>>>>>>>>> pick up the libjvm in the current build directory.
>>>>>>>>>>>>
>>>>>>>>>>>> The modified hotspot script works with GDB and DBX:
>>>>>>>>>>>>
>>>>>>>>>>>> cthaling at intelsdv03.us.oracle.com:/export/twisti/build/8008772
>>>>>>>>>>>> /build/linux_i486_compiler2/debug$
>>>>>>>>>>>>
>>>>>>>>>>>> ./hotspot -gdb -version
>>>>>>>>>>>> GNU gdb (GDB) Red Hat Enterprise Linux (7.1-29.el6) Copyright
>>>>>>>>>>>> (C) 2010 Free Software Foundation, Inc.
>>>>>>>>>>>> License GPLv3+: GNU GPL version 3 or later
>>>>>>>>>>>> <http://gnu.org/licenses/gpl.html>
>>>>>>>>>>>> This is free software: you are free to change and
>>>>>>>>>>>> redistribute it.
>>>>>>>>>>>> There is NO WARRANTY, to the extent permitted by law. Type
>>>>>>>>>>>> "show copying"
>>>>>>>>>>>> and "show warranty" for details.
>>>>>>>>>>>> This GDB was configured as "x86_64-redhat-linux-gnu".
>>>>>>>>>>>> For bug reporting instructions, please see:
>>>>>>>>>>>> <http://www.gnu.org/software/gdb/bugs/>.
>>>>>>>>>>>> Missing separate debuginfo for
>>>>>>>>>>>> /net/scanas404.us.oracle.com/export/java-re/jdk/8/ea/b86/binar
>>>>>>>>>>>> ies/linux-i586/bin/java
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Try: yum --disablerepo='*' --enablerepo='*-debuginfo' install
>>>>>>>>>>>> /usr/lib/debug/.build-id/5e/85e6dced3b388a7b0e50630242f4c7ee5e
>>>>>>>>>>>> 31a3.debug
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Function "JNI_CreateJavaVM" not defined.
>>>>>>>>>>>> Breakpoint 1 (JNI_CreateJavaVM) pending.
>>>>>>>>>>>> [Thread debugging using libthread_db enabled] [New Thread
>>>>>>>>>>>> 0xf7fe4b70 (LWP 13459)] [Switching to Thread 0xf7fe4b70 (LWP
>>>>>>>>>>>> 13459)]
>>>>>>>>>>>>
>>>>>>>>>>>> Breakpoint 1, JNI_CreateJavaVM (vm=0xf7fe4378,
>>>>>>>>>>>> penv=0xf7fe4374,
>>>>>>>>>>>> args=0xf7fe4364)
>>>>>>>>>>>>       at
>>>>>>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/pri
>>>>>>>>>>>> ms/jni.cpp:5062
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> 5062      jint result = JNI_ERR;
>>>>>>>>>>>> Missing separate debuginfos, use: debuginfo-install
>>>>>>>>>>>> glibc-2.12-1.7.el6.i686
>>>>>>>>>>>> (gdb) break CompileBroker::compile_method Breakpoint 2 at
>>>>>>>>>>>> 0xaef852: file
>>>>>>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/com
>>>>>>>>>>>> piler/compileBroker.cpp,
>>>>>>>>>>>>
>>>>>>>>>>>> line 1205.
>>>>>>>>>>>> (gdb) c
>>>>>>>>>>>> Continuing.
>>>>>>>>>>>> [New Thread 0xf7f93b70 (LWP 13460)] [New Thread 0xb4398b70
>>>>>>>>>>>> (LWP 13461)] [New Thread 0xb41ffb70 (LWP 13462)] [New Thread
>>>>>>>>>>>> 0xb3effb70 (LWP 13463)] [New Thread 0xb3cffb70 (LWP 13464)]
>>>>>>>>>>>> [New Thread 0xb3affb70 (LWP 13465)] [New Thread 0xb38ffb70
>>>>>>>>>>>> (LWP 13466)] [New Thread 0xb36ffb70 (LWP 13467)] [New Thread
>>>>>>>>>>>> 0xb34ffb70 (LWP 13468)] [New Thread 0xb32ffb70 (LWP 13469)]
>>>>>>>>>>>> [New Thread 0xb30ffb70 (LWP 13470)] [New Thread 0xb2effb70
>>>>>>>>>>>> (LWP 13471)] [New Thread 0xb2cffb70 (LWP 13472)] [New Thread
>>>>>>>>>>>> 0xaf8e8b70 (LWP 13473)] [New Thread 0xb4156b70 (LWP 13474)]
>>>>>>>>>>>> [New Thread 0xb3c7eb70 (LWP 13475)] [New Thread 0xb3a7eb70
>>>>>>>>>>>> (LWP 13476)] [New Thread 0xaeeffb70 (LWP 13477)] [New Thread
>>>>>>>>>>>> 0xaecffb70 (LWP 13478)] [New Thread 0xb387eb70 (LWP 13479)]
>>>>>>>>>>>> [New Thread 0xaeaffb70 (LWP 13480)] java version "1.8.0-ea"
>>>>>>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86) Java
>>>>>>>>>>>> HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed
>>>>>>>>>>>> mode) [Thread 0xaeaffb70 (LWP 13480) exited] [Thread
>>>>>>>>>>>> 0xb3a7eb70 (LWP 13476) exited] [Thread 0xaf8e8b70 (LWP 13473)
>>>>>>>>>>>> exited] [Thread 0xf7fe4b70 (LWP 13459) exited] [Thread
>>>>>>>>>>>> 0xb2cffb70 (LWP 13472) exited] [Thread 0xb2effb70 (LWP 13471)
>>>>>>>>>>>> exited] [Thread 0xaecffb70 (LWP 13478) exited] [Thread
>>>>>>>>>>>> 0xb387eb70 (LWP 13479) exited] [Thread 0xaeeffb70 (LWP 13477)
>>>>>>>>>>>> exited] [Thread 0xb3c7eb70 (LWP 13475) exited] [Thread
>>>>>>>>>>>> 0xb4156b70 (LWP 13474) exited] [Thread 0xb32ffb70 (LWP 13469)
>>>>>>>>>>>> exited] [Thread 0xb34ffb70 (LWP 13468) exited] [Thread
>>>>>>>>>>>> 0xb36ffb70 (LWP 13467) exited] [Thread 0xb38ffb70 (LWP 13466)
>>>>>>>>>>>> exited] [Thread 0xb3affb70 (LWP 13465) exited] [Thread
>>>>>>>>>>>> 0xb3cffb70 (LWP 13464) exited] [Thread 0xb3effb70 (LWP 13463)
>>>>>>>>>>>> exited] [Thread 0xb41ffb70 (LWP 13462) exited] [Thread
>>>>>>>>>>>> 0xb4398b70 (LWP 13461) exited] [Thread 0xf7f93b70 (LWP 13460)
>>>>>>>>>>>> exited] [Thread 0xb30ffb70 (LWP 13470) exited]
>>>>>>>>>>>>
>>>>>>>>>>>> Program exited normally.
>>>>>>>>>>>> (gdb)
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> cthaling at intelsdv01:/export/twisti/build/8008772/build/solaris
>>>>>>>>>>>> _i486_compiler2/debug$
>>>>>>>>>>>>
>>>>>>>>>>>> /bin/bash ./hotspot -dbx -version
>>>>>>>>>>>> dbx: warning: using the alternate init file:
>>>>>>>>>>>> /home/cthaling/.dbxrc Reading java Reading ld.so.1 Reading
>>>>>>>>>>>> libjli.so Reading libthread.so.1 Reading libdl.so.1 Reading
>>>>>>>>>>>> libc.so.1 Reading libjvm.so Loaded loadobject:
>>>>>>>>>>>> /export/twisti/build/8008772/build/solaris_i486_compiler2/debu
>>>>>>>>>>>> g/libjvm.so
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Running: java -Dsun.java.launcher=gamma
>>>>>>>>>>>> -XXaltjvm=/export/twisti/build/8008772/build/solaris_i486_comp
>>>>>>>>>>>> iler2/debug
>>>>>>>>>>>>
>>>>>>>>>>>> -version
>>>>>>>>>>>> (process id 29613)
>>>>>>>>>>>> Reading libsocket.so.1
>>>>>>>>>>>> Reading libsched.so.1
>>>>>>>>>>>> Reading libm.so.1
>>>>>>>>>>>> Reading libCrun.so.1
>>>>>>>>>>>> Reading libdoor.so.1
>>>>>>>>>>>> Reading libdemangle.so.1
>>>>>>>>>>>> Reading libnsl.so.1
>>>>>>>>>>>> Reading libm.so.2
>>>>>>>>>>>> Reading libscf.so.1
>>>>>>>>>>>> Reading libuutil.so.1
>>>>>>>>>>>> Reading libgen.so.1
>>>>>>>>>>>> Reading libmd.so.1
>>>>>>>>>>>> Reading libmp.so.2
>>>>>>>>>>>> t at 2 (l at 2) stopped in JNI_CreateJavaVM at line 5062 in file
>>>>>>>>>>>> "jni.cpp"
>>>>>>>>>>>>    5062     jint result = JNI_ERR;
>>>>>>>>>>>> (dbx) stop in CompileBroker::compile_method
>>>>>>>>>>>> (2) stop in
>>>>>>>>>>>> CompileBroker::compile_method(methodHandle,int,int,methodHandl
>>>>>>>>>>>> e,int,const
>>>>>>>>>>>>
>>>>>>>>>>>> char*,Thread*)
>>>>>>>>>>>> (dbx) c
>>>>>>>>>>>> Reading libverify.so
>>>>>>>>>>>> Reading libjava.so
>>>>>>>>>>>> Reading libzip.so
>>>>>>>>>>>> java version "1.8.0-ea"
>>>>>>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86) Java
>>>>>>>>>>>> HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed
>>>>>>>>>>>> mode)
>>>>>>>>>>>>
>>>>>>>>>>>> execution completed, exit code is 0
>>>>>>>>>>>> (dbx)
>>>>>>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>>
>>>>
>>>
>

From staffan.larsen at oracle.com  Thu May  2 04:53:32 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Thu, 2 May 2013 13:53:32 +0200
Subject: RFR: 8013785 Respect EXTRA_CFLAGS on windows 
Message-ID: <4D3D5BD2-3682-4430-8DE2-13AA79BFA3FB@oracle.com>

EXTRA_CFLAGS can be used on all platforms except windows to add extra compiler arguments to the compile. This fix improves the  windows build to also support this.

webrev: http://cr.openjdk.java.net/~sla/8013785/webrev.00/

Thanks,
/Staffan


From vladimir.kozlov at oracle.com  Thu May  2 10:03:42 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Thu, 02 May 2013 10:03:42 -0700
Subject: RFR: 8013785 Respect EXTRA_CFLAGS on windows
In-Reply-To: <4D3D5BD2-3682-4430-8DE2-13AA79BFA3FB@oracle.com>
References: <4D3D5BD2-3682-4430-8DE2-13AA79BFA3FB@oracle.com>
Message-ID: <51829C6E.602@oracle.com>

Good.

thanks,
Vladimir

On 5/2/13 4:53 AM, Staffan Larsen wrote:
> EXTRA_CFLAGS can be used on all platforms except windows to add extra compiler arguments to the compile. This fix improves the  windows build to also support this.
>
> webrev: http://cr.openjdk.java.net/~sla/8013785/webrev.00/
>
> Thanks,
> /Staffan
>

From staffan.larsen at oracle.com  Thu May  2 10:21:48 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Thu, 2 May 2013 19:21:48 +0200
Subject: RFR: 8013785 Respect EXTRA_CFLAGS on windows
In-Reply-To: <51829C6E.602@oracle.com>
References: <4D3D5BD2-3682-4430-8DE2-13AA79BFA3FB@oracle.com>
	<51829C6E.602@oracle.com>
Message-ID: <F40B1D49-2113-4BD9-9785-0F6D2D5AC88F@oracle.com>

Thanks Vladimir!

On 2 maj 2013, at 19:03, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

> Good.
> 
> thanks,
> Vladimir
> 
> On 5/2/13 4:53 AM, Staffan Larsen wrote:
>> EXTRA_CFLAGS can be used on all platforms except windows to add extra compiler arguments to the compile. This fix improves the  windows build to also support this.
>> 
>> webrev: http://cr.openjdk.java.net/~sla/8013785/webrev.00/
>> 
>> Thanks,
>> /Staffan
>> 


From alejandro.murillo at oracle.com  Thu May  2 13:01:08 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Thu, 02 May 2013 20:01:08 +0000
Subject: hg: hsx/hsx24/hotspot: 3 new changesets
Message-ID: <20130502200120.B628548790@hg.openjdk.java.net>

Changeset: 0599c2274c79
Author:    katleman
Date:      2013-05-01 14:50 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/0599c2274c79

Added tag jdk7u40-b23 for changeset 34a398422e59

! .hgtags

Changeset: 2efcfec8a6dc
Author:    amurillo
Date:      2013-05-02 09:56 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/2efcfec8a6dc

Merge


Changeset: 944e87027dc7
Author:    amurillo
Date:      2013-05-02 09:56 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/944e87027dc7

Added tag hs24-b43 for changeset 2efcfec8a6dc

! .hgtags


From daniel.daugherty at oracle.com  Thu May  2 13:06:06 2013
From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com)
Date: Thu, 02 May 2013 20:06:06 +0000
Subject: hg: hsx/hotspot-main/hotspot: 4 new changesets
Message-ID: <20130502200623.C06DA48791@hg.openjdk.java.net>

Changeset: b4081e9714ec
Author:    vladidan
Date:      2013-04-30 17:36 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b4081e9714ec

8013398: Adjust number of stack guard pages on systems with large memory page size
Summary: Auto adjust number of stack guard pages on systems with large memory page size
Reviewed-by: bobv, coleenp

! src/os/linux/vm/os_linux.cpp
! src/os/linux/vm/os_linux.hpp

Changeset: 1847df492437
Author:    vladidan
Date:      2013-05-01 10:10 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/1847df492437

Merge


Changeset: 08236d966eea
Author:    bharadwaj
Date:      2013-05-01 08:07 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/08236d966eea

8013418: assert(i == total_args_passed) in AdapterHandlerLibrary::get_adapter since 8-b87
Summary: Do not treat static methods as miranda methods.
Reviewed-by: dholmes, acorn

! src/share/vm/oops/klassVtable.cpp
+ test/runtime/lambda-features/PublicStaticInterfaceMethodHandling.java

Changeset: 8fe2542bdc8d
Author:    bharadwaj
Date:      2013-05-01 09:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/8fe2542bdc8d

Merge



From nils.eliasson at oracle.com  Thu May  2 13:52:30 2013
From: nils.eliasson at oracle.com (Nils Eliasson)
Date: Thu, 02 May 2013 22:52:30 +0200
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <51817DED.2050603@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>
	<51759F6B.7080808@oracle.com>
	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>
	<51764FDE.2090205@oracle.com> <517669A6.8030705@oracle.com>
	<5176CD8E.5060704@oracle.com>
	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>
	<5176D417.3040202@oracle.com> <51817DED.2050603@oracle.com>
Message-ID: <5182D20E.4000600@oracle.com>

Upload as a webrev too.

http://cr.openjdk.java.net/~neliasso/vs_fix/webrev.01/ 
<http://cr.openjdk.java.net/%7Eneliasso/vs_fix/webrev.01/>

//N

On 2013-05-01 22:41, Nils Eliasson wrote:
> Hi,
>
> Here is a patch that fixes so that it still works to create vcprojs, 
> and also sets defaults for the debugger commands.
>
> I have verified with creating vcprojs and debugging hotspot in VS 
> 2010. Works great except for an annoying pop-up that warns that the 
> launcher doesn't have debug symbols (if the target jdk doesn't).
>
> It will still be some extra work for those using the commandlines 
> plugin. All saved command lines need the be prepended with 
> "-XXaltjvm=$(TargetDir) -Dsun.java.launcher=gamma" and the target JDK 
> set as executable to work. We should update the plugin to help with that.
>
> A big thank you to Christian T?rnqvist for the proposal!
>
> //Nils
>
>
> On 2013-04-23 20:33, Mikael Gerdin wrote:
>>
>> On 2013-04-23 20:28, Christian Thalinger wrote:
>>>
>>> On Apr 23, 2013, at 11:06 AM, Nils Eliasson 
>>> <nils.eliasson at oracle.com> wrote:
>>>
>>>> As long as we fix it first and remove gamma after - I would love to 
>>>> have some redundant code removed. I would fix it myself, I just 
>>>> don't think I will have the time before I go on parental leave.
>>>
>>> First, I'm not removing it tomorrow.  I expected a long discussion :-)
>>>
>>> What exactly is the problem with Visual Studio?  Why can't you just 
>>> run the java launcher instead?
>>>
>>
>> I don't know if there actually is a problem, but I don't think 
>> anyone's actually tried to tell it to use the java launcher.
>> The VS project is automatically setup to launch "hotspot.exe" from 
>> the IDE. "hotspot.exe" is equivalent to the old option LINK_INTO=AOUT 
>> (IIRC) which involves linking all the VM object files into the launcher.
>>
>> Nils, perhaps you can at least try this before you leave?
>>
>> /Mikael
>>
>>> -- Chris
>>>
>>>>
>>>> //Nils
>>>>
>>>> On 2013-04-23 12:59, Mikael Gerdin wrote:
>>>>>
>>>>>
>>>>> On 2013-04-23 11:09, Nils Eliasson wrote:
>>>>>> The gamma launcher is used to run and debug hotspot from Visual 
>>>>>> Studio.
>>>>>> So removing gamma effectively kills the working environment for a 
>>>>>> number
>>>>>> of people that use it daily.  So I am strongly against removing it.
>>>>>
>>>>> Maybe the visual studio project generator could be updated to 
>>>>> create a a "launch configuration" for launching java.exe from a 
>>>>> JDK and use the XXaltJVM flag on to select the correct jvm.dll?
>>>>>
>>>>> I agree that we shouldn't break the visual studio project but 
>>>>> currently there's nothing indicating that we can't fix it.
>>>>>
>>>>>
>>>>> /Mikael
>>>>>
>>>>>>
>>>>>> Most people working on Windows use Cygwin as the last resort 
>>>>>> since it
>>>>>> makes a lot of thing excruciatingly slow.
>>>>>>
>>>>>> //Nils
>>>>>>
>>>>>> On 2013-04-22 22:55, Christian Thalinger wrote:
>>>>>>> On Apr 22, 2013, at 1:36 PM, Daniel D. Daugherty
>>>>>>> <daniel.daugherty at oracle.com> wrote:
>>>>>>>
>>>>>>>> Chris,
>>>>>>>>
>>>>>>>> Just an observation and not a review.
>>>>>>>>
>>>>>>>> Looks like you're removing launcher support on Windows, but it
>>>>>>>> looks like the new hotspot.script doesn't support Windows...
>>>>>>>> Am I missing something?
>>>>>>> Almost certainly true.  Since I'm not a Windows user (and nobody 
>>>>>>> near
>>>>>>> me is one) I have no idea how people are using the gamma 
>>>>>>> launcher on
>>>>>>> Windows (or the hotspot script for that matter).
>>>>>>>
>>>>>>> I presume most people doing debugging on the command line are 
>>>>>>> already
>>>>>>> in cygwin?  But I might be wrong.
>>>>>>>
>>>>>>> -- Chris
>>>>>>>
>>>>>>>> Dan
>>>>>>>>
>>>>>>>>
>>>>>>>> On 4/22/13 1:47 PM, Christian Thalinger wrote:
>>>>>>>>> http://cr.openjdk.java.net/~twisti/8008772/
>>>>>>>>>
>>>>>>>>> 8008772: remove gamma launcher
>>>>>>>>> Reviewed-by:
>>>>>>>>>
>>>>>>>>> Remove linking the gamma launcher and it's associated source 
>>>>>>>>> files.
>>>>>>>>>
>>>>>>>>> make/Makefile
>>>>>>>>> make/bsd/makefiles/launcher.make
>>>>>>>>> make/bsd/makefiles/vm.make
>>>>>>>>> make/hotspot.script
>>>>>>>>> make/linux/makefiles/launcher.make
>>>>>>>>> make/linux/makefiles/vm.make
>>>>>>>>> make/solaris/makefiles/launcher.make
>>>>>>>>> make/solaris/makefiles/vm.make
>>>>>>>>> make/windows/makefiles/debug.make
>>>>>>>>> make/windows/makefiles/fastdebug.make
>>>>>>>>> make/windows/makefiles/launcher.make
>>>>>>>>> make/windows/makefiles/product.make
>>>>>>>>> make/windows/makefiles/projectcreator.make
>>>>>>>>> make/windows/projectfiles/common/Makefile
>>>>>>>>> src/os/posix/launcher/java_md.c
>>>>>>>>> src/os/posix/launcher/java_md.h
>>>>>>>>> src/os/posix/launcher/launcher.script
>>>>>>>>> src/os/windows/launcher/java_md.c
>>>>>>>>> src/os/windows/launcher/java_md.h
>>>>>>>>> src/share/tools/launcher/java.c
>>>>>>>>> src/share/tools/launcher/java.h
>>>>>>>>> src/share/tools/launcher/jli_util.c
>>>>>>>>> src/share/tools/launcher/jli_util.h
>>>>>>>>> src/share/tools/launcher/wildcard.c
>>>>>>>>> src/share/tools/launcher/wildcard.h
>>>>>>>>>
>>>>>>>>> This change removes the duplicated java launcher files (which 
>>>>>>>>> were
>>>>>>>>> subject to bit-rot) and modifies the hotspot script to pick up 
>>>>>>>>> the
>>>>>>>>> libjvm in the current build directory.
>>>>>>>>>
>>>>>>>>> The modified hotspot script works with GDB and DBX:
>>>>>>>>>
>>>>>>>>> cthaling at intelsdv03.us.oracle.com:/export/twisti/build/8008772/build/linux_i486_compiler2/debug$ 
>>>>>>>>>
>>>>>>>>> ./hotspot -gdb -version
>>>>>>>>> GNU gdb (GDB) Red Hat Enterprise Linux (7.1-29.el6)
>>>>>>>>> Copyright (C) 2010 Free Software Foundation, Inc.
>>>>>>>>> License GPLv3+: GNU GPL version 3 or later
>>>>>>>>> <http://gnu.org/licenses/gpl.html>
>>>>>>>>> This is free software: you are free to change and redistribute 
>>>>>>>>> it.
>>>>>>>>> There is NO WARRANTY, to the extent permitted by law. Type "show
>>>>>>>>> copying"
>>>>>>>>> and "show warranty" for details.
>>>>>>>>> This GDB was configured as "x86_64-redhat-linux-gnu".
>>>>>>>>> For bug reporting instructions, please see:
>>>>>>>>> <http://www.gnu.org/software/gdb/bugs/>.
>>>>>>>>> Missing separate debuginfo for
>>>>>>>>> /net/scanas404.us.oracle.com/export/java-re/jdk/8/ea/b86/binaries/linux-i586/bin/java 
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Try: yum --disablerepo='*' --enablerepo='*-debuginfo' install
>>>>>>>>> /usr/lib/debug/.build-id/5e/85e6dced3b388a7b0e50630242f4c7ee5e31a3.debug 
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Function "JNI_CreateJavaVM" not defined.
>>>>>>>>> Breakpoint 1 (JNI_CreateJavaVM) pending.
>>>>>>>>> [Thread debugging using libthread_db enabled]
>>>>>>>>> [New Thread 0xf7fe4b70 (LWP 13459)]
>>>>>>>>> [Switching to Thread 0xf7fe4b70 (LWP 13459)]
>>>>>>>>>
>>>>>>>>> Breakpoint 1, JNI_CreateJavaVM (vm=0xf7fe4378, penv=0xf7fe4374,
>>>>>>>>> args=0xf7fe4364)
>>>>>>>>>      at
>>>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/prims/jni.cpp:5062 
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> 5062      jint result = JNI_ERR;
>>>>>>>>> Missing separate debuginfos, use: debuginfo-install
>>>>>>>>> glibc-2.12-1.7.el6.i686
>>>>>>>>> (gdb) break CompileBroker::compile_method
>>>>>>>>> Breakpoint 2 at 0xaef852: file
>>>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/compiler/compileBroker.cpp, 
>>>>>>>>>
>>>>>>>>> line 1205.
>>>>>>>>> (gdb) c
>>>>>>>>> Continuing.
>>>>>>>>> [New Thread 0xf7f93b70 (LWP 13460)]
>>>>>>>>> [New Thread 0xb4398b70 (LWP 13461)]
>>>>>>>>> [New Thread 0xb41ffb70 (LWP 13462)]
>>>>>>>>> [New Thread 0xb3effb70 (LWP 13463)]
>>>>>>>>> [New Thread 0xb3cffb70 (LWP 13464)]
>>>>>>>>> [New Thread 0xb3affb70 (LWP 13465)]
>>>>>>>>> [New Thread 0xb38ffb70 (LWP 13466)]
>>>>>>>>> [New Thread 0xb36ffb70 (LWP 13467)]
>>>>>>>>> [New Thread 0xb34ffb70 (LWP 13468)]
>>>>>>>>> [New Thread 0xb32ffb70 (LWP 13469)]
>>>>>>>>> [New Thread 0xb30ffb70 (LWP 13470)]
>>>>>>>>> [New Thread 0xb2effb70 (LWP 13471)]
>>>>>>>>> [New Thread 0xb2cffb70 (LWP 13472)]
>>>>>>>>> [New Thread 0xaf8e8b70 (LWP 13473)]
>>>>>>>>> [New Thread 0xb4156b70 (LWP 13474)]
>>>>>>>>> [New Thread 0xb3c7eb70 (LWP 13475)]
>>>>>>>>> [New Thread 0xb3a7eb70 (LWP 13476)]
>>>>>>>>> [New Thread 0xaeeffb70 (LWP 13477)]
>>>>>>>>> [New Thread 0xaecffb70 (LWP 13478)]
>>>>>>>>> [New Thread 0xb387eb70 (LWP 13479)]
>>>>>>>>> [New Thread 0xaeaffb70 (LWP 13480)]
>>>>>>>>> java version "1.8.0-ea"
>>>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
>>>>>>>>> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, 
>>>>>>>>> mixed mode)
>>>>>>>>> [Thread 0xaeaffb70 (LWP 13480) exited]
>>>>>>>>> [Thread 0xb3a7eb70 (LWP 13476) exited]
>>>>>>>>> [Thread 0xaf8e8b70 (LWP 13473) exited]
>>>>>>>>> [Thread 0xf7fe4b70 (LWP 13459) exited]
>>>>>>>>> [Thread 0xb2cffb70 (LWP 13472) exited]
>>>>>>>>> [Thread 0xb2effb70 (LWP 13471) exited]
>>>>>>>>> [Thread 0xaecffb70 (LWP 13478) exited]
>>>>>>>>> [Thread 0xb387eb70 (LWP 13479) exited]
>>>>>>>>> [Thread 0xaeeffb70 (LWP 13477) exited]
>>>>>>>>> [Thread 0xb3c7eb70 (LWP 13475) exited]
>>>>>>>>> [Thread 0xb4156b70 (LWP 13474) exited]
>>>>>>>>> [Thread 0xb32ffb70 (LWP 13469) exited]
>>>>>>>>> [Thread 0xb34ffb70 (LWP 13468) exited]
>>>>>>>>> [Thread 0xb36ffb70 (LWP 13467) exited]
>>>>>>>>> [Thread 0xb38ffb70 (LWP 13466) exited]
>>>>>>>>> [Thread 0xb3affb70 (LWP 13465) exited]
>>>>>>>>> [Thread 0xb3cffb70 (LWP 13464) exited]
>>>>>>>>> [Thread 0xb3effb70 (LWP 13463) exited]
>>>>>>>>> [Thread 0xb41ffb70 (LWP 13462) exited]
>>>>>>>>> [Thread 0xb4398b70 (LWP 13461) exited]
>>>>>>>>> [Thread 0xf7f93b70 (LWP 13460) exited]
>>>>>>>>> [Thread 0xb30ffb70 (LWP 13470) exited]
>>>>>>>>>
>>>>>>>>> Program exited normally.
>>>>>>>>> (gdb)
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> cthaling at intelsdv01:/export/twisti/build/8008772/build/solaris_i486_compiler2/debug$ 
>>>>>>>>>
>>>>>>>>> /bin/bash ./hotspot -dbx -version
>>>>>>>>> dbx: warning: using the alternate init file: 
>>>>>>>>> /home/cthaling/.dbxrc
>>>>>>>>> Reading java
>>>>>>>>> Reading ld.so.1
>>>>>>>>> Reading libjli.so
>>>>>>>>> Reading libthread.so.1
>>>>>>>>> Reading libdl.so.1
>>>>>>>>> Reading libc.so.1
>>>>>>>>> Reading libjvm.so
>>>>>>>>> Loaded loadobject:
>>>>>>>>> /export/twisti/build/8008772/build/solaris_i486_compiler2/debug/libjvm.so 
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Running: java -Dsun.java.launcher=gamma
>>>>>>>>> -XXaltjvm=/export/twisti/build/8008772/build/solaris_i486_compiler2/debug 
>>>>>>>>>
>>>>>>>>> -version
>>>>>>>>> (process id 29613)
>>>>>>>>> Reading libsocket.so.1
>>>>>>>>> Reading libsched.so.1
>>>>>>>>> Reading libm.so.1
>>>>>>>>> Reading libCrun.so.1
>>>>>>>>> Reading libdoor.so.1
>>>>>>>>> Reading libdemangle.so.1
>>>>>>>>> Reading libnsl.so.1
>>>>>>>>> Reading libm.so.2
>>>>>>>>> Reading libscf.so.1
>>>>>>>>> Reading libuutil.so.1
>>>>>>>>> Reading libgen.so.1
>>>>>>>>> Reading libmd.so.1
>>>>>>>>> Reading libmp.so.2
>>>>>>>>> t at 2 (l at 2) stopped in JNI_CreateJavaVM at line 5062 in file 
>>>>>>>>> "jni.cpp"
>>>>>>>>>   5062     jint result = JNI_ERR;
>>>>>>>>> (dbx) stop in CompileBroker::compile_method
>>>>>>>>> (2) stop in
>>>>>>>>> CompileBroker::compile_method(methodHandle,int,int,methodHandle,int,const 
>>>>>>>>>
>>>>>>>>> char*,Thread*)
>>>>>>>>> (dbx) c
>>>>>>>>> Reading libverify.so
>>>>>>>>> Reading libjava.so
>>>>>>>>> Reading libzip.so
>>>>>>>>> java version "1.8.0-ea"
>>>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86)
>>>>>>>>> Java HotSpot(TM) Server VM (build 25.0-b29-internal-debug, 
>>>>>>>>> mixed mode)
>>>>>>>>>
>>>>>>>>> execution completed, exit code is 0
>>>>>>>>> (dbx)
>>>>>>>>>
>>>>>>
>>>>
>>>
>


From christian.thalinger at oracle.com  Thu May  2 15:50:47 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Thu, 2 May 2013 15:50:47 -0700
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <51818E47.1050605@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>	<51759F6B.7080808@oracle.com>	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>	<51764FDE.2090205@oracle.com>
	<517669A6.8030705@oracle.com>	<5176CD8E.5060704@oracle.com>	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>	<5176D417.3040202@oracle.com>
	<51817DED.2050603@oracle.com> <51818766.20604@oracle.com>
	<00d901ce46b3$28037a90$780a6fb0$@tornqvist@oracle.com>
	<51818E47.1050605@oracle.com>
Message-ID: <96D28554-AC5A-40EA-A763-ABC554D650DC@oracle.com>


On May 1, 2013, at 2:51 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

> Somehow I got Nils's mail without attachment.
> 
> On 5/1/13 2:30 PM, Christian Tornqvist wrote:
>> Hi Vladimir,
>> 
>> Nils attached the patch to the email, but I've put the patch at
>> http://cr.openjdk.java.net/~ctornqvi/webrev/vs.patch also
> 
> This looks good. Christian Thalinger will be happy :)

Indeed :-)  Thanks Nils and Christian for making that work!

-- Chris

> 
> Thanks,
> Vladimir
> 
>> 
>> Thanks,
>> Christian
>> 
>> -----Original Message-----
>> From: hotspot-dev-bounces at openjdk.java.net
>> [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
>> Sent: den 1 maj 2013 17:22
>> To: Nils Eliasson
>> Cc: build-dev at openjdk.java.net; hotspot-dev developers; Christian Thalinger
>> Subject: Re: RFR (M): 8008772: remove gamma launcher
>> 
>> Nils,
>> 
>> I don't see attached patch or webrev link.
>> 
>> thanks,
>> Vladimir
>> 
>> On 5/1/13 1:41 PM, Nils Eliasson wrote:
>>> Hi,
>>> 
>>> Here is a patch that fixes so that it still works to create vcprojs,
>>> and also sets defaults for the debugger commands.
>>> 
>>> I have verified with creating vcprojs and debugging hotspot in VS 2010.
>>> Works great except for an annoying pop-up that warns that the launcher
>>> doesn't have debug symbols (if the target jdk doesn't).
>>> 
>>> It will still be some extra work for those using the commandlines
>>> plugin. All saved command lines need the be prepended with
>>> "-XXaltjvm=$(TargetDir) -Dsun.java.launcher=gamma" and the target JDK
>>> set as executable to work. We should update the plugin to help with that.
>>> 
>>> A big thank you to Christian T?rnqvist for the proposal!
>>> 
>>> //Nils
>>> 
>>> 
>>> On 2013-04-23 20:33, Mikael Gerdin wrote:
>>>> 
>>>> On 2013-04-23 20:28, Christian Thalinger wrote:
>>>>> 
>>>>> On Apr 23, 2013, at 11:06 AM, Nils Eliasson
>>>>> <nils.eliasson at oracle.com> wrote:
>>>>> 
>>>>>> As long as we fix it first and remove gamma after - I would love to
>>>>>> have some redundant code removed. I would fix it myself, I just
>>>>>> don't think I will have the time before I go on parental leave.
>>>>> 
>>>>> First, I'm not removing it tomorrow.  I expected a long discussion
>>>>> :-)
>>>>> 
>>>>> What exactly is the problem with Visual Studio?  Why can't you just
>>>>> run the java launcher instead?
>>>>> 
>>>> 
>>>> I don't know if there actually is a problem, but I don't think
>>>> anyone's actually tried to tell it to use the java launcher.
>>>> The VS project is automatically setup to launch "hotspot.exe" from
>>>> the IDE. "hotspot.exe" is equivalent to the old option LINK_INTO=AOUT
>>>> (IIRC) which involves linking all the VM object files into the launcher.
>>>> 
>>>> Nils, perhaps you can at least try this before you leave?
>>>> 
>>>> /Mikael
>>>> 
>>>>> -- Chris
>>>>> 
>>>>>> 
>>>>>> //Nils
>>>>>> 
>>>>>> On 2013-04-23 12:59, Mikael Gerdin wrote:
>>>>>>> 
>>>>>>> 
>>>>>>> On 2013-04-23 11:09, Nils Eliasson wrote:
>>>>>>>> The gamma launcher is used to run and debug hotspot from Visual
>>>>>>>> Studio.
>>>>>>>> So removing gamma effectively kills the working environment for a
>>>>>>>> number of people that use it daily.  So I am strongly against
>>>>>>>> removing it.
>>>>>>> 
>>>>>>> Maybe the visual studio project generator could be updated to
>>>>>>> create a a "launch configuration" for launching java.exe from a
>>>>>>> JDK and use the XXaltJVM flag on to select the correct jvm.dll?
>>>>>>> 
>>>>>>> I agree that we shouldn't break the visual studio project but
>>>>>>> currently there's nothing indicating that we can't fix it.
>>>>>>> 
>>>>>>> 
>>>>>>> /Mikael
>>>>>>> 
>>>>>>>> 
>>>>>>>> Most people working on Windows use Cygwin as the last resort
>>>>>>>> since it makes a lot of thing excruciatingly slow.
>>>>>>>> 
>>>>>>>> //Nils
>>>>>>>> 
>>>>>>>> On 2013-04-22 22:55, Christian Thalinger wrote:
>>>>>>>>> On Apr 22, 2013, at 1:36 PM, Daniel D. Daugherty
>>>>>>>>> <daniel.daugherty at oracle.com> wrote:
>>>>>>>>> 
>>>>>>>>>> Chris,
>>>>>>>>>> 
>>>>>>>>>> Just an observation and not a review.
>>>>>>>>>> 
>>>>>>>>>> Looks like you're removing launcher support on Windows, but it
>>>>>>>>>> looks like the new hotspot.script doesn't support Windows...
>>>>>>>>>> Am I missing something?
>>>>>>>>> Almost certainly true.  Since I'm not a Windows user (and nobody
>>>>>>>>> near me is one) I have no idea how people are using the gamma
>>>>>>>>> launcher on Windows (or the hotspot script for that matter).
>>>>>>>>> 
>>>>>>>>> I presume most people doing debugging on the command line are
>>>>>>>>> already in cygwin?  But I might be wrong.
>>>>>>>>> 
>>>>>>>>> -- Chris
>>>>>>>>> 
>>>>>>>>>> Dan
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>> On 4/22/13 1:47 PM, Christian Thalinger wrote:
>>>>>>>>>>> http://cr.openjdk.java.net/~twisti/8008772/
>>>>>>>>>>> 
>>>>>>>>>>> 8008772: remove gamma launcher
>>>>>>>>>>> Reviewed-by:
>>>>>>>>>>> 
>>>>>>>>>>> Remove linking the gamma launcher and it's associated source
>>>>>>>>>>> files.
>>>>>>>>>>> 
>>>>>>>>>>> make/Makefile
>>>>>>>>>>> make/bsd/makefiles/launcher.make make/bsd/makefiles/vm.make
>>>>>>>>>>> make/hotspot.script make/linux/makefiles/launcher.make
>>>>>>>>>>> make/linux/makefiles/vm.make
>>>>>>>>>>> make/solaris/makefiles/launcher.make
>>>>>>>>>>> make/solaris/makefiles/vm.make
>>>>>>>>>>> make/windows/makefiles/debug.make
>>>>>>>>>>> make/windows/makefiles/fastdebug.make
>>>>>>>>>>> make/windows/makefiles/launcher.make
>>>>>>>>>>> make/windows/makefiles/product.make
>>>>>>>>>>> make/windows/makefiles/projectcreator.make
>>>>>>>>>>> make/windows/projectfiles/common/Makefile
>>>>>>>>>>> src/os/posix/launcher/java_md.c
>>>>>>>>>>> src/os/posix/launcher/java_md.h
>>>>>>>>>>> src/os/posix/launcher/launcher.script
>>>>>>>>>>> src/os/windows/launcher/java_md.c
>>>>>>>>>>> src/os/windows/launcher/java_md.h
>>>>>>>>>>> src/share/tools/launcher/java.c
>>>>>>>>>>> src/share/tools/launcher/java.h
>>>>>>>>>>> src/share/tools/launcher/jli_util.c
>>>>>>>>>>> src/share/tools/launcher/jli_util.h
>>>>>>>>>>> src/share/tools/launcher/wildcard.c
>>>>>>>>>>> src/share/tools/launcher/wildcard.h
>>>>>>>>>>> 
>>>>>>>>>>> This change removes the duplicated java launcher files (which
>>>>>>>>>>> were subject to bit-rot) and modifies the hotspot script to
>>>>>>>>>>> pick up the libjvm in the current build directory.
>>>>>>>>>>> 
>>>>>>>>>>> The modified hotspot script works with GDB and DBX:
>>>>>>>>>>> 
>>>>>>>>>>> cthaling at intelsdv03.us.oracle.com:/export/twisti/build/8008772
>>>>>>>>>>> /build/linux_i486_compiler2/debug$
>>>>>>>>>>> 
>>>>>>>>>>> ./hotspot -gdb -version
>>>>>>>>>>> GNU gdb (GDB) Red Hat Enterprise Linux (7.1-29.el6) Copyright
>>>>>>>>>>> (C) 2010 Free Software Foundation, Inc.
>>>>>>>>>>> License GPLv3+: GNU GPL version 3 or later
>>>>>>>>>>> <http://gnu.org/licenses/gpl.html>
>>>>>>>>>>> This is free software: you are free to change and redistribute it.
>>>>>>>>>>> There is NO WARRANTY, to the extent permitted by law. Type
>>>>>>>>>>> "show copying"
>>>>>>>>>>> and "show warranty" for details.
>>>>>>>>>>> This GDB was configured as "x86_64-redhat-linux-gnu".
>>>>>>>>>>> For bug reporting instructions, please see:
>>>>>>>>>>> <http://www.gnu.org/software/gdb/bugs/>.
>>>>>>>>>>> Missing separate debuginfo for
>>>>>>>>>>> /net/scanas404.us.oracle.com/export/java-re/jdk/8/ea/b86/binar
>>>>>>>>>>> ies/linux-i586/bin/java
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> Try: yum --disablerepo='*' --enablerepo='*-debuginfo' install
>>>>>>>>>>> /usr/lib/debug/.build-id/5e/85e6dced3b388a7b0e50630242f4c7ee5e
>>>>>>>>>>> 31a3.debug
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> Function "JNI_CreateJavaVM" not defined.
>>>>>>>>>>> Breakpoint 1 (JNI_CreateJavaVM) pending.
>>>>>>>>>>> [Thread debugging using libthread_db enabled] [New Thread
>>>>>>>>>>> 0xf7fe4b70 (LWP 13459)] [Switching to Thread 0xf7fe4b70 (LWP
>>>>>>>>>>> 13459)]
>>>>>>>>>>> 
>>>>>>>>>>> Breakpoint 1, JNI_CreateJavaVM (vm=0xf7fe4378,
>>>>>>>>>>> penv=0xf7fe4374,
>>>>>>>>>>> args=0xf7fe4364)
>>>>>>>>>>>      at
>>>>>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/pri
>>>>>>>>>>> ms/jni.cpp:5062
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> 5062      jint result = JNI_ERR;
>>>>>>>>>>> Missing separate debuginfos, use: debuginfo-install
>>>>>>>>>>> glibc-2.12-1.7.el6.i686
>>>>>>>>>>> (gdb) break CompileBroker::compile_method Breakpoint 2 at
>>>>>>>>>>> 0xaef852: file
>>>>>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/com
>>>>>>>>>>> piler/compileBroker.cpp,
>>>>>>>>>>> 
>>>>>>>>>>> line 1205.
>>>>>>>>>>> (gdb) c
>>>>>>>>>>> Continuing.
>>>>>>>>>>> [New Thread 0xf7f93b70 (LWP 13460)] [New Thread 0xb4398b70
>>>>>>>>>>> (LWP 13461)] [New Thread 0xb41ffb70 (LWP 13462)] [New Thread
>>>>>>>>>>> 0xb3effb70 (LWP 13463)] [New Thread 0xb3cffb70 (LWP 13464)]
>>>>>>>>>>> [New Thread 0xb3affb70 (LWP 13465)] [New Thread 0xb38ffb70
>>>>>>>>>>> (LWP 13466)] [New Thread 0xb36ffb70 (LWP 13467)] [New Thread
>>>>>>>>>>> 0xb34ffb70 (LWP 13468)] [New Thread 0xb32ffb70 (LWP 13469)]
>>>>>>>>>>> [New Thread 0xb30ffb70 (LWP 13470)] [New Thread 0xb2effb70
>>>>>>>>>>> (LWP 13471)] [New Thread 0xb2cffb70 (LWP 13472)] [New Thread
>>>>>>>>>>> 0xaf8e8b70 (LWP 13473)] [New Thread 0xb4156b70 (LWP 13474)]
>>>>>>>>>>> [New Thread 0xb3c7eb70 (LWP 13475)] [New Thread 0xb3a7eb70
>>>>>>>>>>> (LWP 13476)] [New Thread 0xaeeffb70 (LWP 13477)] [New Thread
>>>>>>>>>>> 0xaecffb70 (LWP 13478)] [New Thread 0xb387eb70 (LWP 13479)]
>>>>>>>>>>> [New Thread 0xaeaffb70 (LWP 13480)] java version "1.8.0-ea"
>>>>>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86) Java
>>>>>>>>>>> HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed
>>>>>>>>>>> mode) [Thread 0xaeaffb70 (LWP 13480) exited] [Thread
>>>>>>>>>>> 0xb3a7eb70 (LWP 13476) exited] [Thread 0xaf8e8b70 (LWP 13473)
>>>>>>>>>>> exited] [Thread 0xf7fe4b70 (LWP 13459) exited] [Thread
>>>>>>>>>>> 0xb2cffb70 (LWP 13472) exited] [Thread 0xb2effb70 (LWP 13471)
>>>>>>>>>>> exited] [Thread 0xaecffb70 (LWP 13478) exited] [Thread
>>>>>>>>>>> 0xb387eb70 (LWP 13479) exited] [Thread 0xaeeffb70 (LWP 13477)
>>>>>>>>>>> exited] [Thread 0xb3c7eb70 (LWP 13475) exited] [Thread
>>>>>>>>>>> 0xb4156b70 (LWP 13474) exited] [Thread 0xb32ffb70 (LWP 13469)
>>>>>>>>>>> exited] [Thread 0xb34ffb70 (LWP 13468) exited] [Thread
>>>>>>>>>>> 0xb36ffb70 (LWP 13467) exited] [Thread 0xb38ffb70 (LWP 13466)
>>>>>>>>>>> exited] [Thread 0xb3affb70 (LWP 13465) exited] [Thread
>>>>>>>>>>> 0xb3cffb70 (LWP 13464) exited] [Thread 0xb3effb70 (LWP 13463)
>>>>>>>>>>> exited] [Thread 0xb41ffb70 (LWP 13462) exited] [Thread
>>>>>>>>>>> 0xb4398b70 (LWP 13461) exited] [Thread 0xf7f93b70 (LWP 13460)
>>>>>>>>>>> exited] [Thread 0xb30ffb70 (LWP 13470) exited]
>>>>>>>>>>> 
>>>>>>>>>>> Program exited normally.
>>>>>>>>>>> (gdb)
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> cthaling at intelsdv01:/export/twisti/build/8008772/build/solaris
>>>>>>>>>>> _i486_compiler2/debug$
>>>>>>>>>>> 
>>>>>>>>>>> /bin/bash ./hotspot -dbx -version
>>>>>>>>>>> dbx: warning: using the alternate init file:
>>>>>>>>>>> /home/cthaling/.dbxrc Reading java Reading ld.so.1 Reading
>>>>>>>>>>> libjli.so Reading libthread.so.1 Reading libdl.so.1 Reading
>>>>>>>>>>> libc.so.1 Reading libjvm.so Loaded loadobject:
>>>>>>>>>>> /export/twisti/build/8008772/build/solaris_i486_compiler2/debu
>>>>>>>>>>> g/libjvm.so
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> Running: java -Dsun.java.launcher=gamma
>>>>>>>>>>> -XXaltjvm=/export/twisti/build/8008772/build/solaris_i486_comp
>>>>>>>>>>> iler2/debug
>>>>>>>>>>> 
>>>>>>>>>>> -version
>>>>>>>>>>> (process id 29613)
>>>>>>>>>>> Reading libsocket.so.1
>>>>>>>>>>> Reading libsched.so.1
>>>>>>>>>>> Reading libm.so.1
>>>>>>>>>>> Reading libCrun.so.1
>>>>>>>>>>> Reading libdoor.so.1
>>>>>>>>>>> Reading libdemangle.so.1
>>>>>>>>>>> Reading libnsl.so.1
>>>>>>>>>>> Reading libm.so.2
>>>>>>>>>>> Reading libscf.so.1
>>>>>>>>>>> Reading libuutil.so.1
>>>>>>>>>>> Reading libgen.so.1
>>>>>>>>>>> Reading libmd.so.1
>>>>>>>>>>> Reading libmp.so.2
>>>>>>>>>>> t at 2 (l at 2) stopped in JNI_CreateJavaVM at line 5062 in file
>>>>>>>>>>> "jni.cpp"
>>>>>>>>>>>   5062     jint result = JNI_ERR;
>>>>>>>>>>> (dbx) stop in CompileBroker::compile_method
>>>>>>>>>>> (2) stop in
>>>>>>>>>>> CompileBroker::compile_method(methodHandle,int,int,methodHandl
>>>>>>>>>>> e,int,const
>>>>>>>>>>> 
>>>>>>>>>>> char*,Thread*)
>>>>>>>>>>> (dbx) c
>>>>>>>>>>> Reading libverify.so
>>>>>>>>>>> Reading libjava.so
>>>>>>>>>>> Reading libzip.so
>>>>>>>>>>> java version "1.8.0-ea"
>>>>>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86) Java
>>>>>>>>>>> HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed
>>>>>>>>>>> mode)
>>>>>>>>>>> 
>>>>>>>>>>> execution completed, exit code is 0
>>>>>>>>>>> (dbx)
>>>>>>>>>>> 
>>>>>>>> 
>>>>>> 
>>>>> 
>>> 
>> 


From jiangli.zhou at oracle.com  Thu May  2 16:33:47 2013
From: jiangli.zhou at oracle.com (jiangli.zhou at oracle.com)
Date: Thu, 02 May 2013 23:33:47 +0000
Subject: hg: hsx/hotspot-main/hotspot: 7 new changesets
Message-ID: <20130502233403.CD9DA487A3@hg.openjdk.java.net>

Changeset: a6e09d6dd8e5
Author:    dlong
Date:      2013-04-24 20:55 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a6e09d6dd8e5

8003853: specify offset of IC load in java_to_interp stub
Summary: refactored code to allow platform-specific differences
Reviewed-by: dlong, twisti
Contributed-by: Goetz Lindenmaier <goetz.lindenmaier at sap.com>

+ src/cpu/sparc/vm/compiledIC_sparc.cpp
! src/cpu/sparc/vm/sparc.ad
+ src/cpu/x86/vm/compiledIC_x86.cpp
! src/cpu/x86/vm/x86_32.ad
! src/cpu/x86/vm/x86_64.ad
+ src/cpu/zero/vm/compiledIC_zero.cpp
! src/share/vm/adlc/main.cpp
! src/share/vm/code/compiledIC.cpp
! src/share/vm/code/compiledIC.hpp
! src/share/vm/opto/output.cpp

Changeset: e10e43e58e92
Author:    dlong
Date:      2013-04-24 21:11 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/e10e43e58e92

Merge

- make/bsd/makefiles/jvmg.make
- make/bsd/makefiles/profiled.make
- make/linux/makefiles/jvmg.make
- make/linux/makefiles/profiled.make
- make/solaris/makefiles/jvmg.make
- make/solaris/makefiles/profiled.make
! src/cpu/sparc/vm/sparc.ad
! src/cpu/x86/vm/x86_32.ad
! src/cpu/x86/vm/x86_64.ad
- src/os/bsd/vm/chaitin_bsd.cpp
- src/os/linux/vm/chaitin_linux.cpp
- src/os/solaris/vm/chaitin_solaris.cpp
- src/os/windows/vm/chaitin_windows.cpp
! src/share/vm/opto/output.cpp
- test/gc/6941923/test6941923.sh
- test/gc/TestVerifyBeforeGCDuringStartup.java
- test/runtime/NMT/AllocTestType.java

Changeset: 3c0584fec1e6
Author:    dholmes
Date:      2013-04-28 18:24 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/3c0584fec1e6

8010428: Special -agentpath checks needed with minimal VM to produce proper error message
Reviewed-by: dholmes, alanb, cjplummer, olagneau
Contributed-by: Carlos Lucasius <carlos.lucasius at oracle.com>

! src/share/vm/runtime/arguments.cpp

Changeset: 78603aa58b1e
Author:    jiangli
Date:      2013-04-26 16:58 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/78603aa58b1e

Merge

! src/cpu/x86/vm/x86_64.ad

Changeset: e01e02a9fcb6
Author:    jiangli
Date:      2013-04-29 01:58 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/e01e02a9fcb6

Merge

! src/share/vm/runtime/arguments.cpp

Changeset: 052caeaeb771
Author:    jiangli
Date:      2013-05-02 12:16 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/052caeaeb771

Merge


Changeset: 8f9fae155577
Author:    jiangli
Date:      2013-05-02 13:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/8f9fae155577

Merge



From christian.thalinger at oracle.com  Thu May  2 16:44:28 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Thu, 2 May 2013 16:44:28 -0700
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <96D28554-AC5A-40EA-A763-ABC554D650DC@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>	<51759F6B.7080808@oracle.com>	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>	<51764FDE.2090205@oracle.com>
	<517669A6.8030705@oracle.com>	<5176CD8E.5060704@oracle.com>	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>	<5176D417.3040202@oracle.com>
	<51817DED.2050603@oracle.com> <51818766.20604@oracle.com>
	<00d901ce46b3$28037a90$780a6fb0$@tornqvist@oracle.com>
	<51818E47.1050605@oracle.com>
	<96D28554-AC5A-40EA-A763-ABC554D650DC@oracle.com>
Message-ID: <9626A9E3-7FE7-49AA-80B2-ACA6BC01EFD1@oracle.com>

Mikael Gerdin pointed out that when JAVA_HOME is not set during a build JDK ends up being empty in jdkpath.sh.

Actually, why do we have jdkpath.sh?  Can't we put the path directly into the hotspot script?

Here is a new webrev including the Windows patch, additionally removes jdkpath.sh and sets JDK to JDK_IMPORT_PATH if ALT_JAVA_HOME is not set:

http://cr.openjdk.java.net/~twisti/8008772/

Next question:  is anyone using env.{sh,csh}?  Since we removed test_gamma these files are unused and we could stop generating them.

-- Chris

On May 2, 2013, at 3:50 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:

> 
> On May 1, 2013, at 2:51 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
>> Somehow I got Nils's mail without attachment.
>> 
>> On 5/1/13 2:30 PM, Christian Tornqvist wrote:
>>> Hi Vladimir,
>>> 
>>> Nils attached the patch to the email, but I've put the patch at
>>> http://cr.openjdk.java.net/~ctornqvi/webrev/vs.patch also
>> 
>> This looks good. Christian Thalinger will be happy :)
> 
> Indeed :-)  Thanks Nils and Christian for making that work!
> 
> -- Chris
> 
>> 
>> Thanks,
>> Vladimir
>> 
>>> 
>>> Thanks,
>>> Christian
>>> 
>>> -----Original Message-----
>>> From: hotspot-dev-bounces at openjdk.java.net
>>> [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
>>> Sent: den 1 maj 2013 17:22
>>> To: Nils Eliasson
>>> Cc: build-dev at openjdk.java.net; hotspot-dev developers; Christian Thalinger
>>> Subject: Re: RFR (M): 8008772: remove gamma launcher
>>> 
>>> Nils,
>>> 
>>> I don't see attached patch or webrev link.
>>> 
>>> thanks,
>>> Vladimir
>>> 
>>> On 5/1/13 1:41 PM, Nils Eliasson wrote:
>>>> Hi,
>>>> 
>>>> Here is a patch that fixes so that it still works to create vcprojs,
>>>> and also sets defaults for the debugger commands.
>>>> 
>>>> I have verified with creating vcprojs and debugging hotspot in VS 2010.
>>>> Works great except for an annoying pop-up that warns that the launcher
>>>> doesn't have debug symbols (if the target jdk doesn't).
>>>> 
>>>> It will still be some extra work for those using the commandlines
>>>> plugin. All saved command lines need the be prepended with
>>>> "-XXaltjvm=$(TargetDir) -Dsun.java.launcher=gamma" and the target JDK
>>>> set as executable to work. We should update the plugin to help with that.
>>>> 
>>>> A big thank you to Christian T?rnqvist for the proposal!
>>>> 
>>>> //Nils
>>>> 
>>>> 
>>>> On 2013-04-23 20:33, Mikael Gerdin wrote:
>>>>> 
>>>>> On 2013-04-23 20:28, Christian Thalinger wrote:
>>>>>> 
>>>>>> On Apr 23, 2013, at 11:06 AM, Nils Eliasson
>>>>>> <nils.eliasson at oracle.com> wrote:
>>>>>> 
>>>>>>> As long as we fix it first and remove gamma after - I would love to
>>>>>>> have some redundant code removed. I would fix it myself, I just
>>>>>>> don't think I will have the time before I go on parental leave.
>>>>>> 
>>>>>> First, I'm not removing it tomorrow.  I expected a long discussion
>>>>>> :-)
>>>>>> 
>>>>>> What exactly is the problem with Visual Studio?  Why can't you just
>>>>>> run the java launcher instead?
>>>>>> 
>>>>> 
>>>>> I don't know if there actually is a problem, but I don't think
>>>>> anyone's actually tried to tell it to use the java launcher.
>>>>> The VS project is automatically setup to launch "hotspot.exe" from
>>>>> the IDE. "hotspot.exe" is equivalent to the old option LINK_INTO=AOUT
>>>>> (IIRC) which involves linking all the VM object files into the launcher.
>>>>> 
>>>>> Nils, perhaps you can at least try this before you leave?
>>>>> 
>>>>> /Mikael
>>>>> 
>>>>>> -- Chris
>>>>>> 
>>>>>>> 
>>>>>>> //Nils
>>>>>>> 
>>>>>>> On 2013-04-23 12:59, Mikael Gerdin wrote:
>>>>>>>> 
>>>>>>>> 
>>>>>>>> On 2013-04-23 11:09, Nils Eliasson wrote:
>>>>>>>>> The gamma launcher is used to run and debug hotspot from Visual
>>>>>>>>> Studio.
>>>>>>>>> So removing gamma effectively kills the working environment for a
>>>>>>>>> number of people that use it daily.  So I am strongly against
>>>>>>>>> removing it.
>>>>>>>> 
>>>>>>>> Maybe the visual studio project generator could be updated to
>>>>>>>> create a a "launch configuration" for launching java.exe from a
>>>>>>>> JDK and use the XXaltJVM flag on to select the correct jvm.dll?
>>>>>>>> 
>>>>>>>> I agree that we shouldn't break the visual studio project but
>>>>>>>> currently there's nothing indicating that we can't fix it.
>>>>>>>> 
>>>>>>>> 
>>>>>>>> /Mikael
>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> Most people working on Windows use Cygwin as the last resort
>>>>>>>>> since it makes a lot of thing excruciatingly slow.
>>>>>>>>> 
>>>>>>>>> //Nils
>>>>>>>>> 
>>>>>>>>> On 2013-04-22 22:55, Christian Thalinger wrote:
>>>>>>>>>> On Apr 22, 2013, at 1:36 PM, Daniel D. Daugherty
>>>>>>>>>> <daniel.daugherty at oracle.com> wrote:
>>>>>>>>>> 
>>>>>>>>>>> Chris,
>>>>>>>>>>> 
>>>>>>>>>>> Just an observation and not a review.
>>>>>>>>>>> 
>>>>>>>>>>> Looks like you're removing launcher support on Windows, but it
>>>>>>>>>>> looks like the new hotspot.script doesn't support Windows...
>>>>>>>>>>> Am I missing something?
>>>>>>>>>> Almost certainly true.  Since I'm not a Windows user (and nobody
>>>>>>>>>> near me is one) I have no idea how people are using the gamma
>>>>>>>>>> launcher on Windows (or the hotspot script for that matter).
>>>>>>>>>> 
>>>>>>>>>> I presume most people doing debugging on the command line are
>>>>>>>>>> already in cygwin?  But I might be wrong.
>>>>>>>>>> 
>>>>>>>>>> -- Chris
>>>>>>>>>> 
>>>>>>>>>>> Dan
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> On 4/22/13 1:47 PM, Christian Thalinger wrote:
>>>>>>>>>>>> http://cr.openjdk.java.net/~twisti/8008772/
>>>>>>>>>>>> 
>>>>>>>>>>>> 8008772: remove gamma launcher
>>>>>>>>>>>> Reviewed-by:
>>>>>>>>>>>> 
>>>>>>>>>>>> Remove linking the gamma launcher and it's associated source
>>>>>>>>>>>> files.
>>>>>>>>>>>> 
>>>>>>>>>>>> make/Makefile
>>>>>>>>>>>> make/bsd/makefiles/launcher.make make/bsd/makefiles/vm.make
>>>>>>>>>>>> make/hotspot.script make/linux/makefiles/launcher.make
>>>>>>>>>>>> make/linux/makefiles/vm.make
>>>>>>>>>>>> make/solaris/makefiles/launcher.make
>>>>>>>>>>>> make/solaris/makefiles/vm.make
>>>>>>>>>>>> make/windows/makefiles/debug.make
>>>>>>>>>>>> make/windows/makefiles/fastdebug.make
>>>>>>>>>>>> make/windows/makefiles/launcher.make
>>>>>>>>>>>> make/windows/makefiles/product.make
>>>>>>>>>>>> make/windows/makefiles/projectcreator.make
>>>>>>>>>>>> make/windows/projectfiles/common/Makefile
>>>>>>>>>>>> src/os/posix/launcher/java_md.c
>>>>>>>>>>>> src/os/posix/launcher/java_md.h
>>>>>>>>>>>> src/os/posix/launcher/launcher.script
>>>>>>>>>>>> src/os/windows/launcher/java_md.c
>>>>>>>>>>>> src/os/windows/launcher/java_md.h
>>>>>>>>>>>> src/share/tools/launcher/java.c
>>>>>>>>>>>> src/share/tools/launcher/java.h
>>>>>>>>>>>> src/share/tools/launcher/jli_util.c
>>>>>>>>>>>> src/share/tools/launcher/jli_util.h
>>>>>>>>>>>> src/share/tools/launcher/wildcard.c
>>>>>>>>>>>> src/share/tools/launcher/wildcard.h
>>>>>>>>>>>> 
>>>>>>>>>>>> This change removes the duplicated java launcher files (which
>>>>>>>>>>>> were subject to bit-rot) and modifies the hotspot script to
>>>>>>>>>>>> pick up the libjvm in the current build directory.
>>>>>>>>>>>> 
>>>>>>>>>>>> The modified hotspot script works with GDB and DBX:
>>>>>>>>>>>> 
>>>>>>>>>>>> cthaling at intelsdv03.us.oracle.com:/export/twisti/build/8008772
>>>>>>>>>>>> /build/linux_i486_compiler2/debug$
>>>>>>>>>>>> 
>>>>>>>>>>>> ./hotspot -gdb -version
>>>>>>>>>>>> GNU gdb (GDB) Red Hat Enterprise Linux (7.1-29.el6) Copyright
>>>>>>>>>>>> (C) 2010 Free Software Foundation, Inc.
>>>>>>>>>>>> License GPLv3+: GNU GPL version 3 or later
>>>>>>>>>>>> <http://gnu.org/licenses/gpl.html>
>>>>>>>>>>>> This is free software: you are free to change and redistribute it.
>>>>>>>>>>>> There is NO WARRANTY, to the extent permitted by law. Type
>>>>>>>>>>>> "show copying"
>>>>>>>>>>>> and "show warranty" for details.
>>>>>>>>>>>> This GDB was configured as "x86_64-redhat-linux-gnu".
>>>>>>>>>>>> For bug reporting instructions, please see:
>>>>>>>>>>>> <http://www.gnu.org/software/gdb/bugs/>.
>>>>>>>>>>>> Missing separate debuginfo for
>>>>>>>>>>>> /net/scanas404.us.oracle.com/export/java-re/jdk/8/ea/b86/binar
>>>>>>>>>>>> ies/linux-i586/bin/java
>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>>>> Try: yum --disablerepo='*' --enablerepo='*-debuginfo' install
>>>>>>>>>>>> /usr/lib/debug/.build-id/5e/85e6dced3b388a7b0e50630242f4c7ee5e
>>>>>>>>>>>> 31a3.debug
>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>>>> Function "JNI_CreateJavaVM" not defined.
>>>>>>>>>>>> Breakpoint 1 (JNI_CreateJavaVM) pending.
>>>>>>>>>>>> [Thread debugging using libthread_db enabled] [New Thread
>>>>>>>>>>>> 0xf7fe4b70 (LWP 13459)] [Switching to Thread 0xf7fe4b70 (LWP
>>>>>>>>>>>> 13459)]
>>>>>>>>>>>> 
>>>>>>>>>>>> Breakpoint 1, JNI_CreateJavaVM (vm=0xf7fe4378,
>>>>>>>>>>>> penv=0xf7fe4374,
>>>>>>>>>>>> args=0xf7fe4364)
>>>>>>>>>>>>     at
>>>>>>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/pri
>>>>>>>>>>>> ms/jni.cpp:5062
>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>>>> 5062      jint result = JNI_ERR;
>>>>>>>>>>>> Missing separate debuginfos, use: debuginfo-install
>>>>>>>>>>>> glibc-2.12-1.7.el6.i686
>>>>>>>>>>>> (gdb) break CompileBroker::compile_method Breakpoint 2 at
>>>>>>>>>>>> 0xaef852: file
>>>>>>>>>>>> /net/10.159.161.234/Users/cthaling/ws/8008772/src/share/vm/com
>>>>>>>>>>>> piler/compileBroker.cpp,
>>>>>>>>>>>> 
>>>>>>>>>>>> line 1205.
>>>>>>>>>>>> (gdb) c
>>>>>>>>>>>> Continuing.
>>>>>>>>>>>> [New Thread 0xf7f93b70 (LWP 13460)] [New Thread 0xb4398b70
>>>>>>>>>>>> (LWP 13461)] [New Thread 0xb41ffb70 (LWP 13462)] [New Thread
>>>>>>>>>>>> 0xb3effb70 (LWP 13463)] [New Thread 0xb3cffb70 (LWP 13464)]
>>>>>>>>>>>> [New Thread 0xb3affb70 (LWP 13465)] [New Thread 0xb38ffb70
>>>>>>>>>>>> (LWP 13466)] [New Thread 0xb36ffb70 (LWP 13467)] [New Thread
>>>>>>>>>>>> 0xb34ffb70 (LWP 13468)] [New Thread 0xb32ffb70 (LWP 13469)]
>>>>>>>>>>>> [New Thread 0xb30ffb70 (LWP 13470)] [New Thread 0xb2effb70
>>>>>>>>>>>> (LWP 13471)] [New Thread 0xb2cffb70 (LWP 13472)] [New Thread
>>>>>>>>>>>> 0xaf8e8b70 (LWP 13473)] [New Thread 0xb4156b70 (LWP 13474)]
>>>>>>>>>>>> [New Thread 0xb3c7eb70 (LWP 13475)] [New Thread 0xb3a7eb70
>>>>>>>>>>>> (LWP 13476)] [New Thread 0xaeeffb70 (LWP 13477)] [New Thread
>>>>>>>>>>>> 0xaecffb70 (LWP 13478)] [New Thread 0xb387eb70 (LWP 13479)]
>>>>>>>>>>>> [New Thread 0xaeaffb70 (LWP 13480)] java version "1.8.0-ea"
>>>>>>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86) Java
>>>>>>>>>>>> HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed
>>>>>>>>>>>> mode) [Thread 0xaeaffb70 (LWP 13480) exited] [Thread
>>>>>>>>>>>> 0xb3a7eb70 (LWP 13476) exited] [Thread 0xaf8e8b70 (LWP 13473)
>>>>>>>>>>>> exited] [Thread 0xf7fe4b70 (LWP 13459) exited] [Thread
>>>>>>>>>>>> 0xb2cffb70 (LWP 13472) exited] [Thread 0xb2effb70 (LWP 13471)
>>>>>>>>>>>> exited] [Thread 0xaecffb70 (LWP 13478) exited] [Thread
>>>>>>>>>>>> 0xb387eb70 (LWP 13479) exited] [Thread 0xaeeffb70 (LWP 13477)
>>>>>>>>>>>> exited] [Thread 0xb3c7eb70 (LWP 13475) exited] [Thread
>>>>>>>>>>>> 0xb4156b70 (LWP 13474) exited] [Thread 0xb32ffb70 (LWP 13469)
>>>>>>>>>>>> exited] [Thread 0xb34ffb70 (LWP 13468) exited] [Thread
>>>>>>>>>>>> 0xb36ffb70 (LWP 13467) exited] [Thread 0xb38ffb70 (LWP 13466)
>>>>>>>>>>>> exited] [Thread 0xb3affb70 (LWP 13465) exited] [Thread
>>>>>>>>>>>> 0xb3cffb70 (LWP 13464) exited] [Thread 0xb3effb70 (LWP 13463)
>>>>>>>>>>>> exited] [Thread 0xb41ffb70 (LWP 13462) exited] [Thread
>>>>>>>>>>>> 0xb4398b70 (LWP 13461) exited] [Thread 0xf7f93b70 (LWP 13460)
>>>>>>>>>>>> exited] [Thread 0xb30ffb70 (LWP 13470) exited]
>>>>>>>>>>>> 
>>>>>>>>>>>> Program exited normally.
>>>>>>>>>>>> (gdb)
>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>>>> cthaling at intelsdv01:/export/twisti/build/8008772/build/solaris
>>>>>>>>>>>> _i486_compiler2/debug$
>>>>>>>>>>>> 
>>>>>>>>>>>> /bin/bash ./hotspot -dbx -version
>>>>>>>>>>>> dbx: warning: using the alternate init file:
>>>>>>>>>>>> /home/cthaling/.dbxrc Reading java Reading ld.so.1 Reading
>>>>>>>>>>>> libjli.so Reading libthread.so.1 Reading libdl.so.1 Reading
>>>>>>>>>>>> libc.so.1 Reading libjvm.so Loaded loadobject:
>>>>>>>>>>>> /export/twisti/build/8008772/build/solaris_i486_compiler2/debu
>>>>>>>>>>>> g/libjvm.so
>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>>>> Running: java -Dsun.java.launcher=gamma
>>>>>>>>>>>> -XXaltjvm=/export/twisti/build/8008772/build/solaris_i486_comp
>>>>>>>>>>>> iler2/debug
>>>>>>>>>>>> 
>>>>>>>>>>>> -version
>>>>>>>>>>>> (process id 29613)
>>>>>>>>>>>> Reading libsocket.so.1
>>>>>>>>>>>> Reading libsched.so.1
>>>>>>>>>>>> Reading libm.so.1
>>>>>>>>>>>> Reading libCrun.so.1
>>>>>>>>>>>> Reading libdoor.so.1
>>>>>>>>>>>> Reading libdemangle.so.1
>>>>>>>>>>>> Reading libnsl.so.1
>>>>>>>>>>>> Reading libm.so.2
>>>>>>>>>>>> Reading libscf.so.1
>>>>>>>>>>>> Reading libuutil.so.1
>>>>>>>>>>>> Reading libgen.so.1
>>>>>>>>>>>> Reading libmd.so.1
>>>>>>>>>>>> Reading libmp.so.2
>>>>>>>>>>>> t at 2 (l at 2) stopped in JNI_CreateJavaVM at line 5062 in file
>>>>>>>>>>>> "jni.cpp"
>>>>>>>>>>>>  5062     jint result = JNI_ERR;
>>>>>>>>>>>> (dbx) stop in CompileBroker::compile_method
>>>>>>>>>>>> (2) stop in
>>>>>>>>>>>> CompileBroker::compile_method(methodHandle,int,int,methodHandl
>>>>>>>>>>>> e,int,const
>>>>>>>>>>>> 
>>>>>>>>>>>> char*,Thread*)
>>>>>>>>>>>> (dbx) c
>>>>>>>>>>>> Reading libverify.so
>>>>>>>>>>>> Reading libjava.so
>>>>>>>>>>>> Reading libzip.so
>>>>>>>>>>>> java version "1.8.0-ea"
>>>>>>>>>>>> Java(TM) SE Runtime Environment (build 1.8.0-ea-b86) Java
>>>>>>>>>>>> HotSpot(TM) Server VM (build 25.0-b29-internal-debug, mixed
>>>>>>>>>>>> mode)
>>>>>>>>>>>> 
>>>>>>>>>>>> execution completed, exit code is 0
>>>>>>>>>>>> (dbx)
>>>>>>>>>>>> 
>>>>>>>>> 
>>>>>>> 
>>>>>> 
>>>> 
>>> 
> 


From john.r.rose at oracle.com  Thu May  2 17:25:34 2013
From: john.r.rose at oracle.com (John Rose)
Date: Thu, 2 May 2013 17:25:34 -0700
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <9626A9E3-7FE7-49AA-80B2-ACA6BC01EFD1@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>	<51759F6B.7080808@oracle.com>	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>	<51764FDE.2090205@oracle.com>
	<517669A6.8030705@oracle.com>	<5176CD8E.5060704@oracle.com>	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>	<5176D417.3040202@oracle.com>
	<51817DED.2050603@oracle.com> <51818766.20604@oracle.com>
	<00d901ce46b3$28037a90$780a6fb0$@tornqvist@oracle.com>
	<51818E47.1050605@oracle.com>
	<96D28554-AC5A-40EA-A763-ABC554D650DC@oracle.com>
	<9626A9E3-7FE7-49AA-80B2-ACA6BC01EFD1@oracle.com>
Message-ID: <47BCCD49-D0D9-45C2-9DC8-9A96F1094F35@oracle.com>

On May 2, 2013, at 4:44 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:

> is anyone using env.{sh,csh}?

I'll suggest that the answer is going to be "no".  I think very few people have ever used them.  ? John


From christian.thalinger at oracle.com  Thu May  2 17:28:50 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Thu, 2 May 2013 17:28:50 -0700
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <47BCCD49-D0D9-45C2-9DC8-9A96F1094F35@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>	<51759F6B.7080808@oracle.com>	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>	<51764FDE.2090205@oracle.com>
	<517669A6.8030705@oracle.com>	<5176CD8E.5060704@oracle.com>	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>	<5176D417.3040202@oracle.com>
	<51817DED.2050603@oracle.com> <51818766.20604@oracle.com>
	<00d901ce46b3$28037a90$780a6fb0$@tornqvist@oracle.com>
	<51818E47.1050605@oracle.com>
	<96D28554-AC5A-40EA-A763-ABC554D650DC@oracle.com>
	<9626A9E3-7FE7-49AA-80B2-ACA6BC01EFD1@oracle.com>
	<47BCCD49-D0D9-45C2-9DC8-9A96F1094F35@oracle.com>
Message-ID: <920F24B7-3D5C-4170-8BAC-1E3D88AAEBE9@oracle.com>


On May 2, 2013, at 5:25 PM, John Rose <john.r.rose at oracle.com> wrote:

> On May 2, 2013, at 4:44 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
> 
>> is anyone using env.{sh,csh}?
> 
> I'll suggest that the answer is going to be "no".  I think very few people have ever used them.  ? John

I think you're right.  Let's remove them with this change then.

-- Chris

From alejandro.murillo at oracle.com  Thu May  2 19:42:44 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 03 May 2013 02:42:44 +0000
Subject: hg: hsx/hsx24/hotspot: 8013799: new hotspot build - hs24-b44
Message-ID: <20130503024249.8F995487AB@hg.openjdk.java.net>

Changeset: 32bd17a37dbb
Author:    amurillo
Date:      2013-05-02 10:10 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/32bd17a37dbb

8013799: new hotspot build - hs24-b44
Reviewed-by: jcoomes

! make/hotspot_version


From mikael.gerdin at oracle.com  Thu May  2 22:22:40 2013
From: mikael.gerdin at oracle.com (mikael.gerdin at oracle.com)
Date: Fri, 03 May 2013 05:22:40 +0000
Subject: hg: hsx/hotspot-main/hotspot: 20 new changesets
Message-ID: <20130503052320.7E5E5487B9@hg.openjdk.java.net>

Changeset: c23dbf0e8ab7
Author:    jmasa
Date:      2013-03-01 10:19 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/c23dbf0e8ab7

8011268: NPG: Free unused VirtualSpaceNodes
Reviewed-by: mgerdin, coleenp, johnc

! src/share/vm/classfile/classLoaderData.cpp
! src/share/vm/memory/metachunk.cpp
! src/share/vm/memory/metachunk.hpp
! src/share/vm/memory/metaspace.cpp
! src/share/vm/memory/metaspace.hpp

Changeset: bfe3be9ebd6c
Author:    kevinw
Date:      2013-04-18 17:02 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/bfe3be9ebd6c

7109087: gc/7072527/TestFullGCCount.java fails when GC is set in command-line
Reviewed-by: mgerdin

! test/gc/7072527/TestFullGCCount.java

Changeset: 12927badda81
Author:    kevinw
Date:      2013-04-19 05:14 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/12927badda81

Merge


Changeset: d391427ddc29
Author:    mgerdin
Date:      2013-04-22 10:10 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d391427ddc29

Merge


Changeset: a08c80e9e1e5
Author:    stefank
Date:      2013-04-22 20:27 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a08c80e9e1e5

8012687: Remove unused is_root checks and closures
Reviewed-by: tschatzl, jmasa

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.hpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp
! src/share/vm/gc_implementation/shared/markSweep.cpp
! src/share/vm/gc_implementation/shared/markSweep.hpp
! src/share/vm/gc_implementation/shared/markSweep.inline.hpp
! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/memory/genCollectedHeap.hpp
! src/share/vm/memory/genMarkSweep.cpp
! src/share/vm/memory/sharedHeap.cpp
! src/share/vm/memory/sharedHeap.hpp

Changeset: ebded0261dfc
Author:    jmasa
Date:      2013-04-22 22:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/ebded0261dfc

8012111: Remove warning about CMS generation shrinking.
Reviewed-by: johnc, brutisso, stefank

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
+ test/gc/concurrentMarkSweep/GuardShrinkWarning.java

Changeset: 1cb4795305b9
Author:    mgerdin
Date:      2013-04-23 08:39 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/1cb4795305b9

8011802: NPG: init_dependencies in class loader data graph can cause invalid CLD
Summary: Restructure initialization of ClassLoaderData to not add a new instance if init_dependencies fail
Reviewed-by: stefank, coleenp

! src/share/vm/classfile/classLoaderData.cpp
! src/share/vm/classfile/classLoaderData.hpp
! src/share/vm/classfile/classLoaderData.inline.hpp

Changeset: 5c93c1f61226
Author:    johnc
Date:      2013-04-18 10:09 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/5c93c1f61226

8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
Summary: Stack allocate instances of HeapRegionRemSetIterator during RSet scanning.
Reviewed-by: brutisso, jwilhelm

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
! src/share/vm/gc_implementation/g1/g1RemSet.cpp
! src/share/vm/gc_implementation/g1/g1RemSet.hpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp
! src/share/vm/gc_implementation/g1/sparsePRT.cpp
! src/share/vm/gc_implementation/g1/sparsePRT.hpp

Changeset: 868d87ed63c8
Author:    jmasa
Date:      2013-02-12 14:15 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/868d87ed63c8

8008966: NPG: Inefficient Metaspace counter functions cause large young GC regressions
Reviewed-by: mgerdin, coleenp

! src/share/vm/classfile/classLoaderData.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/shared/vmGCOperations.cpp
! src/share/vm/memory/filemap.cpp
! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/memory/metaspace.cpp
! src/share/vm/memory/metaspace.hpp
! src/share/vm/memory/metaspaceCounters.cpp
! src/share/vm/memory/metaspaceCounters.hpp
! src/share/vm/memory/metaspaceShared.cpp

Changeset: 9d75bcd7c890
Author:    mgerdin
Date:      2013-04-24 19:55 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/9d75bcd7c890

8013136: NPG: Parallel class loading tests fail after fix for JDK-8011802
Summary: Move initialization of dependencies to before allocation of CLD
Reviewed-by: stefank, coleenp

! src/share/vm/classfile/classLoaderData.cpp
! src/share/vm/classfile/classLoaderData.hpp

Changeset: d50cc62e94ff
Author:    johnc
Date:      2013-04-24 14:48 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d50cc62e94ff

8012715: G1: GraphKit accesses PtrQueue::_index as int but is size_t
Summary: In graphKit INT operations were generated to access PtrQueue::_index which has type size_t. This is 64 bit on 64-bit machines. No problems occur on little endian machines as long as the index fits into 32 bit, but on big endian machines the upper part is read, which is zero. This leads to unnecessary branches to the slow path in the runtime.
Reviewed-by: twisti, johnc
Contributed-by: Martin Doerr <martin.doerr at sap.com>

! src/share/vm/opto/graphKit.cpp

Changeset: b06ac540229e
Author:    stefank
Date:      2013-04-24 20:13 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b06ac540229e

8013132: Add a flag to turn off the output of the verbose verification code
Reviewed-by: johnc, brutisso

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp
! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp
! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/memory/universe.cpp
! src/share/vm/memory/universe.hpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/thread.cpp
! src/share/vm/runtime/vmThread.cpp
! src/share/vm/runtime/vm_operations.hpp

Changeset: b294421fa3c5
Author:    brutisso
Date:      2013-04-26 09:53 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b294421fa3c5

8012915: ReservedSpace::align_reserved_region() broken on Windows
Summary: remove unused constructors and helper methods for ReservedHeapSpace and ReservedSpace
Reviewed-by: mgerdin, jmasa, johnc, tschatzl

! src/share/vm/runtime/virtualspace.cpp
! src/share/vm/runtime/virtualspace.hpp

Changeset: 2f50bc369470
Author:    stefank
Date:      2013-04-26 10:40 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/2f50bc369470

8013160: NPG: Remove unnecessary mark stack draining after CodeCache::do_unloading
Reviewed-by: coleenp, mgerdin

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/memory/genMarkSweep.cpp

Changeset: 3edf23423bb2
Author:    johnc
Date:      2013-04-26 10:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/3edf23423bb2

8011898: gc/TestVerifyBeforeGCDuringStartup.java: java.lang.RuntimeException: '[Verifying' missing from stdout/stderr: [Error: Could not find or load main class]
Summary: System.getProperty("test.java.opts") can return NULL, which gets converted to to the empty string, and the child java command then interprets that as the name of the main class.
Reviewed-by: jmasa, brutisso

! test/gc/TestVerifyDuringStartup.java

Changeset: caac22686b17
Author:    mgerdin
Date:      2013-04-29 09:31 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/caac22686b17

Merge

! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
! src/share/vm/runtime/thread.cpp

Changeset: 601183f604b2
Author:    mgerdin
Date:      2013-04-29 13:07 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/601183f604b2

8013129: Possible deadlock with Metaspace locks due to mixed usage of safepoint aware and non-safepoint aware locking
Summary: Change Metaspace::deallocate to take lock with _no_safepoint_check_flag
Reviewed-by: coleenp, jmasa, dholmes

! src/share/vm/memory/metaspace.cpp

Changeset: 9075044ed66b
Author:    ehelin
Date:      2013-04-30 16:36 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/9075044ed66b

8008541: Remove old code in HotSpot that supported the jmap -permstat functionality
Reviewed-by: sla, brutisso

! agent/src/share/classes/sun/jvm/hotspot/tools/JMap.java

Changeset: d58c62b7447d
Author:    mgerdin
Date:      2013-05-02 19:28 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d58c62b7447d

Merge

! src/share/vm/classfile/classLoaderData.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp

Changeset: cbd4ce58f1f3
Author:    mgerdin
Date:      2013-05-02 16:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/cbd4ce58f1f3

Merge



From john.cuthbertson at oracle.com  Fri May  3 00:54:25 2013
From: john.cuthbertson at oracle.com (john.cuthbertson at oracle.com)
Date: Fri, 03 May 2013 07:54:25 +0000
Subject: hg: hsx/hsx24/hotspot: 2 new changesets
Message-ID: <20130503075431.DF424487BD@hg.openjdk.java.net>

Changeset: 839bc4071e51
Author:    tamao
Date:      2013-05-02 10:11 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/839bc4071e51

6761744: Hotspot crashes if process size limit is exceeded
Summary: Check overflow of total_reserved: object heap + perm gen (+ miscellaneous data structures) before reserving heap space, and VM aborts with appropriate message if overflowed.
Reviewed-by: brutisso, johnc, tschatzl
Contributed-by: tamao <tao.mao at oracle.com>

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp
! src/share/vm/gc_interface/collectedHeap.cpp
! src/share/vm/gc_interface/collectedHeap.hpp
! src/share/vm/memory/genCollectedHeap.cpp
! test/TEST.ROOT
+ test/gc/init/TestHandleExceedingProcessSizeLimitIn32BitBuilds.java

Changeset: 0285b77cb121
Author:    johnc
Date:      2013-05-02 19:48 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/0285b77cb121

Merge



From fweimer at redhat.com  Fri May  3 00:59:17 2013
From: fweimer at redhat.com (Florian Weimer)
Date: Fri, 03 May 2013 09:59:17 +0200
Subject: Always enforce ACC_SUPER
In-Reply-To: <4FB5FEFA.5010509@redhat.com>
References: <4FB5FEFA.5010509@redhat.com>
Message-ID: <51836E55.1030902@redhat.com>

On 05/18/2012 09:49 AM, Florian Weimer wrote:
> It has been observed that the easy way of creating non-cloneable classes
> does not work because classes can opt out of the ACC_SUPER handling:
>
> <http://mail.openjdk.java.net/pipermail/core-libs-dev/2010-August/004742.html>
>
>
> I don't think this is desirable, so I propose a patch to treat all
> classes as if they have ACC_SUPER set.  A new product flag is
> introduced, ForceAccSuper, which defaults to true.  Disabling it
> preserves the old behavior.  I think that assuming the presence of
> ACC_SUPER rather than rejecting classes without it completely is safer
> because non-javac bytecode generators might forget to set ACC_SUPER.
>
> The patch is against the Hotspot in OpenJDK 7u4, but it should apply to
> other versions as well.  It has been tested only lightly (on 7u4 and 8).

It seems that a variant of this patch made its way into jdk7u recently: 
<http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/db7028c8a953>

-- 
Florian Weimer / Red Hat Product Security Team

From john.coomes at oracle.com  Fri May  3 01:32:03 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 03 May 2013 08:32:03 +0000
Subject: hg: hsx/hotspot-main/corba: Added tag jdk8-b88 for changeset
	4e3a881ebb1e
Message-ID: <20130503083207.60C8F487BF@hg.openjdk.java.net>

Changeset: 1f13a798d1b8
Author:    katleman
Date:      2013-05-02 13:34 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/1f13a798d1b8

Added tag jdk8-b88 for changeset 4e3a881ebb1e

! .hgtags


From john.coomes at oracle.com  Fri May  3 01:32:28 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 03 May 2013 08:32:28 +0000
Subject: hg: hsx/hotspot-main/jaxws: Added tag jdk8-b88 for changeset
	24fa5452e5d4
Message-ID: <20130503083234.704B7487C1@hg.openjdk.java.net>

Changeset: 88838e08e4ef
Author:    katleman
Date:      2013-05-02 13:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/88838e08e4ef

Added tag jdk8-b88 for changeset 24fa5452e5d4

! .hgtags


From john.coomes at oracle.com  Fri May  3 01:31:57 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 03 May 2013 08:31:57 +0000
Subject: hg: hsx/hotspot-main: 6 new changesets
Message-ID: <20130503083158.15476487BE@hg.openjdk.java.net>

Changeset: 1dfcc874461e
Author:    omajid
Date:      2013-04-29 12:34 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/1dfcc874461e

8013480: fix zero build on arm
Reviewed-by: erikj

! common/autoconf/generated-configure.sh
! common/autoconf/platform.m4
! common/autoconf/spec.gmk.in

Changeset: 7e7582e961ba
Author:    jwilhelm
Date:      2013-04-25 16:00 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/7e7582e961ba

7074926: create Solaris Studio IDE (Netbeans) project for hotspot sources
Summary: Project files for hotspot delevopment in Solaris Studio and NetBeans. Also reviewed by vladimir.voskresensky at oracle.com
Reviewed-by: erikj, dsamersoff

+ common/nb_native/nbproject/configurations.xml
+ common/nb_native/nbproject/project.xml

Changeset: b9bf111a9547
Author:    katleman
Date:      2013-04-30 14:39 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/b9bf111a9547

Merge


Changeset: e404d321abc6
Author:    erikj
Date:      2013-05-02 15:46 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/e404d321abc6

8013786: JDK-8013480 broke configure on solaris
Reviewed-by: tbell

! common/autoconf/configure.ac
! common/autoconf/generated-configure.sh
! common/autoconf/platform.m4
! common/autoconf/toolchain.m4

Changeset: e1a929afcfc4
Author:    erikj
Date:      2013-05-02 15:56 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/e1a929afcfc4

8011687: Support correct dependencies from header files on windows and solaris
Reviewed-by: tbell

! common/autoconf/generated-configure.sh
! common/autoconf/spec.gmk.in
! common/autoconf/toolchain.m4
! common/makefiles/NativeCompilation.gmk

Changeset: 8fb91165e596
Author:    katleman
Date:      2013-05-02 13:34 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/8fb91165e596

Added tag jdk8-b88 for changeset e1a929afcfc4

! .hgtags


From john.coomes at oracle.com  Fri May  3 01:32:12 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 03 May 2013 08:32:12 +0000
Subject: hg: hsx/hotspot-main/jaxp: Added tag jdk8-b88 for changeset
	7122f7bb0fcc
Message-ID: <20130503083223.9803C487C0@hg.openjdk.java.net>

Changeset: 21f75e572cb3
Author:    katleman
Date:      2013-05-02 13:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/21f75e572cb3

Added tag jdk8-b88 for changeset 7122f7bb0fcc

! .hgtags


From john.coomes at oracle.com  Fri May  3 01:32:44 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 03 May 2013 08:32:44 +0000
Subject: hg: hsx/hotspot-main/jdk: 8 new changesets
Message-ID: <20130503083510.BD56E487C2@hg.openjdk.java.net>

Changeset: 78d08fc2dd12
Author:    mullan
Date:      2013-04-25 11:18 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/78d08fc2dd12

8011313: OCSP timeout set to wrong value if com.sun.security.ocsp.timeout not defined
Reviewed-by: vinnie

! src/share/classes/sun/security/provider/certpath/OCSP.java

Changeset: 3e282678a885
Author:    mullan
Date:      2013-04-25 15:48 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3e282678a885

8013228: Create new system properties to control allowable OCSP clock skew and CRL connection timeout
Reviewed-by: vinnie

! src/share/classes/sun/security/provider/certpath/CertPathHelper.java
! src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java
! src/share/classes/sun/security/provider/certpath/OCSPResponse.java
! src/share/classes/sun/security/provider/certpath/URICertStore.java

Changeset: 7c4eb715c5e8
Author:    ngthomas
Date:      2013-04-30 21:49 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7c4eb715c5e8

Merge


Changeset: 12af7c32c648
Author:    omajid
Date:      2013-04-29 12:34 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/12af7c32c648

8013480: fix zero build on arm
Reviewed-by: erikj

! makefiles/GensrcX11Wrappers.gmk

Changeset: 7a96ead5ea89
Author:    katleman
Date:      2013-04-30 14:40 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7a96ead5ea89

Merge


Changeset: 55c7b90fe57e
Author:    katleman
Date:      2013-05-01 14:59 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/55c7b90fe57e

Merge


Changeset: 8dbb4b159e04
Author:    erikj
Date:      2013-05-02 15:59 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/8dbb4b159e04

8013552: Add build support for different man pages for OpenJDK and OracleJDK
Reviewed-by: tbell, omajid

! makefiles/Images.gmk

Changeset: 1daef88acff2
Author:    katleman
Date:      2013-05-02 13:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/1daef88acff2

Added tag jdk8-b88 for changeset 8dbb4b159e04

! .hgtags


From john.coomes at oracle.com  Fri May  3 01:37:33 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 03 May 2013 08:37:33 +0000
Subject: hg: hsx/hotspot-main/langtools: Added tag jdk8-b88 for changeset
	a1e10f3adc47
Message-ID: <20130503083747.A0456487C3@hg.openjdk.java.net>

Changeset: adec2a5d510a
Author:    katleman
Date:      2013-05-02 13:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/adec2a5d510a

Added tag jdk8-b88 for changeset a1e10f3adc47

! .hgtags


From john.coomes at oracle.com  Fri May  3 01:37:52 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 03 May 2013 08:37:52 +0000
Subject: hg: hsx/hotspot-main/nashorn: Added tag jdk8-b88 for changeset
	40c107d1ae6f
Message-ID: <20130503083755.6AB0E487C4@hg.openjdk.java.net>

Changeset: 501bc4aeb1b1
Author:    katleman
Date:      2013-05-02 13:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/501bc4aeb1b1

Added tag jdk8-b88 for changeset 40c107d1ae6f

! .hgtags


From markus.gronlund at oracle.com  Fri May  3 02:34:03 2013
From: markus.gronlund at oracle.com (=?iso-8859-1?B?TWFya3VzIEdy9m5sdW5k?=)
Date: Fri, 3 May 2013 02:34:03 -0700 (PDT)
Subject: RFR: 8013785 Respect EXTRA_CFLAGS on windows
In-Reply-To: <4D3D5BD2-3682-4430-8DE2-13AA79BFA3FB@oracle.com>
References: <4D3D5BD2-3682-4430-8DE2-13AA79BFA3FB@oracle.com>
Message-ID: <7d65b429-3f4f-47aa-ac27-dba2be5b9987@default>

Looks good.

Thanks
Markus

-----Original Message-----
From: Staffan Larsen 
Sent: den 2 maj 2013 13:54
To: hotspot-dev at openjdk.java.net Developers
Subject: RFR: 8013785 Respect EXTRA_CFLAGS on windows

EXTRA_CFLAGS can be used on all platforms except windows to add extra compiler arguments to the compile. This fix improves the  windows build to also support this.

webrev: http://cr.openjdk.java.net/~sla/8013785/webrev.00/

Thanks,
/Staffan


From rickard.backman at oracle.com  Fri May  3 02:42:22 2013
From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=)
Date: Fri, 3 May 2013 11:42:22 +0200
Subject: RFR: 8013785 Respect EXTRA_CFLAGS on windows
In-Reply-To: <4D3D5BD2-3682-4430-8DE2-13AA79BFA3FB@oracle.com>
References: <4D3D5BD2-3682-4430-8DE2-13AA79BFA3FB@oracle.com>
Message-ID: <BCFA139E-9C5C-499E-96E7-7C138359FE18@oracle.com>

Looks good!

/R

On May 2, 2013, at 1:53 PM, Staffan Larsen wrote:

> EXTRA_CFLAGS can be used on all platforms except windows to add extra compiler arguments to the compile. This fix improves the  windows build to also support this.
> 
> webrev: http://cr.openjdk.java.net/~sla/8013785/webrev.00/
> 
> Thanks,
> /Staffan
> 


From vladimir.kozlov at oracle.com  Fri May  3 03:24:28 2013
From: vladimir.kozlov at oracle.com (vladimir.kozlov at oracle.com)
Date: Fri, 03 May 2013 10:24:28 +0000
Subject: hg: hsx/hotspot-main/hotspot: 14 new changesets
Message-ID: <20130503102501.6623F487E4@hg.openjdk.java.net>

Changeset: e12c9b3740db
Author:    vlivanov
Date:      2013-04-25 11:02 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/e12c9b3740db

8012260: ciReplay: Include PID into the name of replay data file
Reviewed-by: kvn, twisti

! src/os/bsd/vm/os_bsd.cpp
! src/os/linux/vm/os_linux.cpp
! src/os/posix/vm/os_posix.cpp
! src/os/solaris/vm/os_solaris.cpp
! src/os/windows/vm/os_windows.cpp
! src/share/vm/ci/ciEnv.cpp
! src/share/vm/ci/ciEnv.hpp
! src/share/vm/ci/ciReplay.cpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/os.hpp
! src/share/vm/utilities/ostream.hpp
! src/share/vm/utilities/vmError.cpp

Changeset: dc7db03f5aa2
Author:    iignatyev
Date:      2013-04-25 11:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/dc7db03f5aa2

8012337: Change Whitebox implementation to make absence of method in Whitebox.class not fatal
Reviewed-by: kvn, vlivanov

! src/share/vm/prims/whitebox.cpp
+ test/sanity/WhiteBox.java

Changeset: 7b23cb975cf2
Author:    iignatyev
Date:      2013-04-25 11:09 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/7b23cb975cf2

8011675: adding compilation level to replay data
Reviewed-by: kvn, vlivanov

- agent/doc/c2replay.html
+ agent/doc/cireplay.html
! agent/doc/clhsdb.html
! agent/src/share/classes/sun/jvm/hotspot/ci/ciEnv.java
! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java
! agent/src/share/classes/sun/jvm/hotspot/compiler/CompileTask.java
! src/share/vm/ci/ciEnv.cpp
! src/share/vm/ci/ciReplay.cpp
! src/share/vm/compiler/compileBroker.cpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/vmStructs.cpp
+ test/compiler/ciReplay/TestSA.sh
+ test/compiler/ciReplay/TestVM.sh
+ test/compiler/ciReplay/TestVM_no_comp_level.sh
+ test/compiler/ciReplay/common.sh

Changeset: 247342108a11
Author:    neliasso
Date:      2013-04-23 13:48 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/247342108a11

8010332: removed unused method: ciMethod::uses_monitors
Reviewed-by: twisti, roland
Contributed-by: albert.noll at oracle.com

! src/share/vm/ci/ciMethod.hpp

Changeset: a5c95fcf7cb7
Author:    neliasso
Date:      2013-04-23 18:06 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a5c95fcf7cb7

8012157: removed unused code in SharedRuntime::handle_wrong_method
Reviewed-by: kvn, roland, rbackman
Contributed-by: albert.noll at oracle.com

! src/share/vm/runtime/sharedRuntime.cpp

Changeset: d1c9384eecb4
Author:    iignatyev
Date:      2013-04-26 07:21 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d1c9384eecb4

8012322: Tiered: CompilationPolicy::can_be_compiled(CompLevel_all) mistakenly return false
Reviewed-by: kvn, vlivanov

! src/share/vm/classfile/classLoader.cpp
! src/share/vm/runtime/compilationPolicy.cpp
! test/compiler/whitebox/CompilerWhiteBoxTest.java
! test/compiler/whitebox/MakeMethodNotCompilableTest.java

Changeset: 93b8272814cf
Author:    vlivanov
Date:      2013-04-26 08:33 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/93b8272814cf

Merge


Changeset: 0b55a78c6be5
Author:    bharadwaj
Date:      2013-04-26 10:52 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/0b55a78c6be5

Merge

- agent/doc/c2replay.html
! src/os/windows/vm/os_windows.cpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: fd49109d0d88
Author:    bharadwaj
Date:      2013-04-26 14:50 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/fd49109d0d88

Merge


Changeset: 487d442ef257
Author:    jiangli
Date:      2013-04-26 16:21 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/487d442ef257

8013036: vm/runtime/simpleThresholdPolicy.cpp: assert(mcs != NULL).
Summary: Change the assert to if check as MethodCounters could be NULL under TieredCompilation.
Reviewed-by: kvn, twisti

! src/share/vm/runtime/simpleThresholdPolicy.cpp

Changeset: 62b683108582
Author:    jiangli
Date:      2013-04-26 14:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/62b683108582

Merge


Changeset: 0cfa93c2fcc4
Author:    neliasso
Date:      2013-04-29 13:20 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/0cfa93c2fcc4

8012547: Code cache flushing can get stuck reclaming of memory
Summary: Keep sweeping regardless of if we are flushing
Reviewed-by: kvn, twisti

! src/share/vm/code/codeCache.cpp
! src/share/vm/code/codeCache.hpp
! src/share/vm/compiler/compileBroker.cpp
! src/share/vm/oops/method.cpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/sweeper.cpp
! src/share/vm/runtime/sweeper.hpp

Changeset: e4e131b15d5c
Author:    roland
Date:      2013-05-02 10:27 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/e4e131b15d5c

8013532: Remove unused parameter "compiler" from DTRACE_METHOD_COMPILE* macros
Summary: remove unused parameter in dtrace macros
Reviewed-by: kvn, roland
Contributed-by: albert.noll at oracle.com

! src/share/vm/compiler/compileBroker.cpp

Changeset: 9ce110b1d14a
Author:    kvn
Date:      2013-05-02 18:50 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/9ce110b1d14a

Merge

- agent/doc/c2replay.html
! src/os/bsd/vm/os_bsd.cpp
! src/os/linux/vm/os_linux.cpp
! src/os/solaris/vm/os_solaris.cpp
! src/share/vm/ci/ciEnv.cpp
! src/share/vm/prims/whitebox.cpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/utilities/vmError.cpp


From coleen.phillimore at oracle.com  Fri May  3 04:48:18 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Fri, 03 May 2013 07:48:18 -0400
Subject: RFR: 8013785 Respect EXTRA_CFLAGS on windows
In-Reply-To: <BCFA139E-9C5C-499E-96E7-7C138359FE18@oracle.com>
References: <4D3D5BD2-3682-4430-8DE2-13AA79BFA3FB@oracle.com>
	<BCFA139E-9C5C-499E-96E7-7C138359FE18@oracle.com>
Message-ID: <5183A402.70708@oracle.com>


Looks good.
thanks,
Coleen

On 5/3/2013 5:42 AM, Rickard B?ckman wrote:
> Looks good!
>
> /R
>
> On May 2, 2013, at 1:53 PM, Staffan Larsen wrote:
>
>> EXTRA_CFLAGS can be used on all platforms except windows to add extra compiler arguments to the compile. This fix improves the  windows build to also support this.
>>
>> webrev: http://cr.openjdk.java.net/~sla/8013785/webrev.00/
>>
>> Thanks,
>> /Staffan
>>


From paul.nauman at oracle.com  Fri May  3 07:55:05 2013
From: paul.nauman at oracle.com (Paul Nauman)
Date: Fri, 03 May 2013 09:55:05 -0500
Subject: Always enforce ACC_SUPER
In-Reply-To: <51836E55.1030902@redhat.com>
References: <4FB5FEFA.5010509@redhat.com> <51836E55.1030902@redhat.com>
Message-ID: <5183CFC9.5000608@oracle.com>

Flag AllowNonVirtualCalls was introduced to address this. Spec change 
still in progressI think.

Also fixed in 6 and 8:

http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/781104609348

http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/77443715ec55

- Paul

On 5/3/2013 2:59 AM, Florian Weimer wrote:
> On 05/18/2012 09:49 AM, Florian Weimer wrote:
>> It has been observed that the easy way of creating non-cloneable classes
>> does not work because classes can opt out of the ACC_SUPER handling:
>>
>> <http://mail.openjdk.java.net/pipermail/core-libs-dev/2010-August/004742.html> 
>>
>>
>>
>> I don't think this is desirable, so I propose a patch to treat all
>> classes as if they have ACC_SUPER set.  A new product flag is
>> introduced, ForceAccSuper, which defaults to true.  Disabling it
>> preserves the old behavior.  I think that assuming the presence of
>> ACC_SUPER rather than rejecting classes without it completely is safer
>> because non-javac bytecode generators might forget to set ACC_SUPER.
>>
>> The patch is against the Hotspot in OpenJDK 7u4, but it should apply to
>> other versions as well.  It has been tested only lightly (on 7u4 and 8).
>
> It seems that a variant of this patch made its way into jdk7u 
> recently: 
> <http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/db7028c8a953>
>


From alejandro.murillo at oracle.com  Fri May  3 11:37:34 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 03 May 2013 18:37:34 +0000
Subject: hg: hsx/hsx25/hotspot: 66 new changesets
Message-ID: <20130503184010.EAC5F487F5@hg.openjdk.java.net>

Changeset: d0081bfc425c
Author:    katleman
Date:      2013-05-02 13:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d0081bfc425c

Added tag jdk8-b88 for changeset 8482058e74bc

! .hgtags

Changeset: 57ac6a688ae6
Author:    amurillo
Date:      2013-04-26 00:40 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/57ac6a688ae6

8013227: new hotspot build - hs25-b31
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: cc70cbbd422e
Author:    hseigel
Date:      2013-04-24 09:00 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/cc70cbbd422e

8012695: Assertion message displays %u and %s text instead of actual values
Summary: USe err_msg() to create a proper assertion message.
Reviewed-by: twisti, coleenp, iklam

! src/share/vm/classfile/classFileParser.hpp

Changeset: fbca7eaeac2e
Author:    zgu
Date:      2013-04-24 14:55 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/fbca7eaeac2e

8011218: Kitchensink hanged, likely NMT is to blame
Summary: Made NMT query safepoint aware.
Reviewed-by: dholmes, coleenp

! src/share/vm/services/memBaseline.cpp
! src/share/vm/services/memBaseline.hpp
! src/share/vm/services/memTracker.cpp

Changeset: d587a5c30bd8
Author:    coleenp
Date:      2013-04-24 16:19 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d587a5c30bd8

8011803: release_C_heap_structures is never called for anonymous classes.
Summary: Call this function from the ClassLoaderData destructor instead of the system dictionary walk.
Reviewed-by: stefank, mgerdin

! src/share/vm/classfile/classLoaderData.cpp
! src/share/vm/classfile/dictionary.cpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/instanceKlass.hpp

Changeset: d66a24adbe3f
Author:    coleenp
Date:      2013-04-24 15:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d66a24adbe3f

Merge


Changeset: 15a99ca4ee34
Author:    sspitsyn
Date:      2013-04-25 03:58 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/15a99ca4ee34

8007037: JSR 292: the VM_RedefineClasses::append_entry() should do cross-checks with indy operands
Summary: References from operands to CP entries and back must be correct after CP merge
Reviewed-by: coleenp, twisti
Contributed-by: serguei.spitsyn at oracle.com

! src/share/vm/oops/constantPool.cpp
! src/share/vm/oops/constantPool.hpp
! src/share/vm/prims/jvmtiRedefineClasses.cpp
! src/share/vm/prims/jvmtiRedefineClasses.hpp

Changeset: c115fac239eb
Author:    iklam
Date:      2013-04-25 12:55 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/c115fac239eb

8008962: NPG: Memory regression: One extra Monitor per ConstantPool
Summary: Re-use InstanceKlass::_init_lock locking ConstantPool as well.
Reviewed-by: dholmes, coleenp, acorn

! src/share/vm/ci/ciEnv.cpp
! src/share/vm/oops/constantPool.cpp
! src/share/vm/oops/constantPool.hpp
! src/share/vm/oops/cpCache.cpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/prims/jvmtiEnv.cpp

Changeset: 3c9b7ef92c61
Author:    dcubed
Date:      2013-04-26 08:40 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/3c9b7ef92c61

Merge


Changeset: d1644a010f52
Author:    emc
Date:      2013-04-26 07:34 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d1644a010f52

8007154: Remove support for u4 MethodParameter flags fields
Summary: Remove support for parsing class files with four-byte flags fields in MethodParameters attributes
Reviewed-by: jrose, coleenp

! src/share/vm/classfile/classFileParser.cpp

Changeset: f258c5828eb8
Author:    hseigel
Date:      2013-04-29 16:13 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/f258c5828eb8

8011773: Some tests on Interned String crashed JVM with OOM
Summary: Instead of terminating the VM, throw OutOfMemoryError exceptions.
Reviewed-by: coleenp, dholmes

! src/share/vm/classfile/javaClasses.cpp
! src/share/vm/classfile/javaClasses.hpp
! src/share/vm/classfile/symbolTable.cpp
! src/share/vm/memory/allocation.hpp
! src/share/vm/oops/oop.cpp
! src/share/vm/prims/whitebox.cpp

Changeset: c53e49efe6a8
Author:    hseigel
Date:      2013-04-29 16:36 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/c53e49efe6a8

Merge


Changeset: f32b6c267d2e
Author:    mikael
Date:      2013-04-29 11:03 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/f32b6c267d2e

8012015: Use PROT_NONE when reserving memory
Summary: Reserved memory had PROT_READ+PROT_WRITE access on Linux/bsd, now changed to PROT_NONE.
Reviewed-by: dholmes, ctornqvi

! src/os/bsd/vm/os_bsd.cpp
! src/os/linux/vm/os_linux.cpp
! src/share/vm/prims/whitebox.cpp
+ test/runtime/memory/ReserveMemory.java
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: 9f96b7a853bc
Author:    sla
Date:      2013-04-30 10:53 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/9f96b7a853bc

8013466: SA crashes when attaching to a process on OS X
Reviewed-by: coleenp, rbackman, minqi

! agent/src/os/bsd/MacosxDebuggerLocal.m

Changeset: 409d4b59e095
Author:    sla
Date:      2013-04-30 02:28 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/409d4b59e095

Merge


Changeset: ed5a590835a4
Author:    zgu
Date:      2013-04-30 09:17 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/ed5a590835a4

8013214: BigApps fails due to 'fatal error: Illegal threadstate encountered: 6'
Summary: Grab and drop SR_lock to get the thread to honor the safepoint protocol
Reviewed-by: dcubed, coleenp

! src/share/vm/services/memBaseline.cpp

Changeset: 746b070f5022
Author:    ccheung
Date:      2013-04-30 11:56 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/746b070f5022

8011661: Insufficient memory message says "malloc" when sometimes it should say "mmap"
Reviewed-by: coleenp, zgu, hseigel

! src/os/solaris/vm/os_solaris.cpp
! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp
! src/os_cpu/linux_x86/vm/os_linux_x86.cpp
! src/os_cpu/linux_zero/vm/os_linux_zero.cpp
! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp
! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp
! src/share/vm/asm/assembler.cpp
! src/share/vm/code/stubs.cpp
! src/share/vm/code/vtableStubs.cpp
! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.cpp
! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp
! src/share/vm/gc_implementation/parallelScavenge/objectStartArray.cpp
! src/share/vm/interpreter/interpreterRuntime.cpp
! src/share/vm/memory/allocation.cpp
! src/share/vm/memory/allocation.inline.hpp
! src/share/vm/memory/blockOffsetTable.cpp
! src/share/vm/memory/cardTableModRefBS.cpp
! src/share/vm/oops/oop.cpp
! src/share/vm/prims/jvmtiTagMap.cpp
! src/share/vm/prims/methodHandles.cpp
! src/share/vm/runtime/objectMonitor.cpp
! src/share/vm/runtime/stubRoutines.cpp
! src/share/vm/runtime/synchronizer.cpp
! src/share/vm/utilities/debug.cpp
! src/share/vm/utilities/debug.hpp
! src/share/vm/utilities/vmError.cpp
! src/share/vm/utilities/vmError.hpp
! src/share/vm/utilities/workgroup.cpp

Changeset: e4614b063fe1
Author:    sla
Date:      2013-04-30 21:47 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/e4614b063fe1

8013364: SA-JDI exceptions caused by lack of permissions on OSX should be more verbose about issue cause
Reviewed-by: coleenp, rbackman

! agent/src/os/bsd/MacosxDebuggerLocal.m

Changeset: 376ff861f611
Author:    sla
Date:      2013-05-01 01:07 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/376ff861f611

Merge


Changeset: b4081e9714ec
Author:    vladidan
Date:      2013-04-30 17:36 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b4081e9714ec

8013398: Adjust number of stack guard pages on systems with large memory page size
Summary: Auto adjust number of stack guard pages on systems with large memory page size
Reviewed-by: bobv, coleenp

! src/os/linux/vm/os_linux.cpp
! src/os/linux/vm/os_linux.hpp

Changeset: 1847df492437
Author:    vladidan
Date:      2013-05-01 10:10 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/1847df492437

Merge


Changeset: 08236d966eea
Author:    bharadwaj
Date:      2013-05-01 08:07 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/08236d966eea

8013418: assert(i == total_args_passed) in AdapterHandlerLibrary::get_adapter since 8-b87
Summary: Do not treat static methods as miranda methods.
Reviewed-by: dholmes, acorn

! src/share/vm/oops/klassVtable.cpp
+ test/runtime/lambda-features/PublicStaticInterfaceMethodHandling.java

Changeset: 8fe2542bdc8d
Author:    bharadwaj
Date:      2013-05-01 09:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/8fe2542bdc8d

Merge


Changeset: a6e09d6dd8e5
Author:    dlong
Date:      2013-04-24 20:55 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/a6e09d6dd8e5

8003853: specify offset of IC load in java_to_interp stub
Summary: refactored code to allow platform-specific differences
Reviewed-by: dlong, twisti
Contributed-by: Goetz Lindenmaier <goetz.lindenmaier at sap.com>

+ src/cpu/sparc/vm/compiledIC_sparc.cpp
! src/cpu/sparc/vm/sparc.ad
+ src/cpu/x86/vm/compiledIC_x86.cpp
! src/cpu/x86/vm/x86_32.ad
! src/cpu/x86/vm/x86_64.ad
+ src/cpu/zero/vm/compiledIC_zero.cpp
! src/share/vm/adlc/main.cpp
! src/share/vm/code/compiledIC.cpp
! src/share/vm/code/compiledIC.hpp
! src/share/vm/opto/output.cpp

Changeset: e10e43e58e92
Author:    dlong
Date:      2013-04-24 21:11 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/e10e43e58e92

Merge

- make/bsd/makefiles/jvmg.make
- make/bsd/makefiles/profiled.make
- make/linux/makefiles/jvmg.make
- make/linux/makefiles/profiled.make
- make/solaris/makefiles/jvmg.make
- make/solaris/makefiles/profiled.make
! src/cpu/sparc/vm/sparc.ad
! src/cpu/x86/vm/x86_32.ad
! src/cpu/x86/vm/x86_64.ad
- src/os/bsd/vm/chaitin_bsd.cpp
- src/os/linux/vm/chaitin_linux.cpp
- src/os/solaris/vm/chaitin_solaris.cpp
- src/os/windows/vm/chaitin_windows.cpp
! src/share/vm/opto/output.cpp
- test/gc/6941923/test6941923.sh
- test/gc/TestVerifyBeforeGCDuringStartup.java
- test/runtime/NMT/AllocTestType.java

Changeset: 3c0584fec1e6
Author:    dholmes
Date:      2013-04-28 18:24 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/3c0584fec1e6

8010428: Special -agentpath checks needed with minimal VM to produce proper error message
Reviewed-by: dholmes, alanb, cjplummer, olagneau
Contributed-by: Carlos Lucasius <carlos.lucasius at oracle.com>

! src/share/vm/runtime/arguments.cpp

Changeset: 78603aa58b1e
Author:    jiangli
Date:      2013-04-26 16:58 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/78603aa58b1e

Merge

! src/cpu/x86/vm/x86_64.ad

Changeset: e01e02a9fcb6
Author:    jiangli
Date:      2013-04-29 01:58 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/e01e02a9fcb6

Merge

! src/share/vm/runtime/arguments.cpp

Changeset: 052caeaeb771
Author:    jiangli
Date:      2013-05-02 12:16 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/052caeaeb771

Merge


Changeset: 8f9fae155577
Author:    jiangli
Date:      2013-05-02 13:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/8f9fae155577

Merge


Changeset: c23dbf0e8ab7
Author:    jmasa
Date:      2013-03-01 10:19 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/c23dbf0e8ab7

8011268: NPG: Free unused VirtualSpaceNodes
Reviewed-by: mgerdin, coleenp, johnc

! src/share/vm/classfile/classLoaderData.cpp
! src/share/vm/memory/metachunk.cpp
! src/share/vm/memory/metachunk.hpp
! src/share/vm/memory/metaspace.cpp
! src/share/vm/memory/metaspace.hpp

Changeset: bfe3be9ebd6c
Author:    kevinw
Date:      2013-04-18 17:02 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/bfe3be9ebd6c

7109087: gc/7072527/TestFullGCCount.java fails when GC is set in command-line
Reviewed-by: mgerdin

! test/gc/7072527/TestFullGCCount.java

Changeset: 12927badda81
Author:    kevinw
Date:      2013-04-19 05:14 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/12927badda81

Merge


Changeset: d391427ddc29
Author:    mgerdin
Date:      2013-04-22 10:10 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d391427ddc29

Merge


Changeset: a08c80e9e1e5
Author:    stefank
Date:      2013-04-22 20:27 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/a08c80e9e1e5

8012687: Remove unused is_root checks and closures
Reviewed-by: tschatzl, jmasa

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.hpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp
! src/share/vm/gc_implementation/shared/markSweep.cpp
! src/share/vm/gc_implementation/shared/markSweep.hpp
! src/share/vm/gc_implementation/shared/markSweep.inline.hpp
! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/memory/genCollectedHeap.hpp
! src/share/vm/memory/genMarkSweep.cpp
! src/share/vm/memory/sharedHeap.cpp
! src/share/vm/memory/sharedHeap.hpp

Changeset: ebded0261dfc
Author:    jmasa
Date:      2013-04-22 22:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/ebded0261dfc

8012111: Remove warning about CMS generation shrinking.
Reviewed-by: johnc, brutisso, stefank

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
+ test/gc/concurrentMarkSweep/GuardShrinkWarning.java

Changeset: 1cb4795305b9
Author:    mgerdin
Date:      2013-04-23 08:39 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/1cb4795305b9

8011802: NPG: init_dependencies in class loader data graph can cause invalid CLD
Summary: Restructure initialization of ClassLoaderData to not add a new instance if init_dependencies fail
Reviewed-by: stefank, coleenp

! src/share/vm/classfile/classLoaderData.cpp
! src/share/vm/classfile/classLoaderData.hpp
! src/share/vm/classfile/classLoaderData.inline.hpp

Changeset: 5c93c1f61226
Author:    johnc
Date:      2013-04-18 10:09 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/5c93c1f61226

8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
Summary: Stack allocate instances of HeapRegionRemSetIterator during RSet scanning.
Reviewed-by: brutisso, jwilhelm

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
! src/share/vm/gc_implementation/g1/g1RemSet.cpp
! src/share/vm/gc_implementation/g1/g1RemSet.hpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp
! src/share/vm/gc_implementation/g1/sparsePRT.cpp
! src/share/vm/gc_implementation/g1/sparsePRT.hpp

Changeset: 868d87ed63c8
Author:    jmasa
Date:      2013-02-12 14:15 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/868d87ed63c8

8008966: NPG: Inefficient Metaspace counter functions cause large young GC regressions
Reviewed-by: mgerdin, coleenp

! src/share/vm/classfile/classLoaderData.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/shared/vmGCOperations.cpp
! src/share/vm/memory/filemap.cpp
! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/memory/metaspace.cpp
! src/share/vm/memory/metaspace.hpp
! src/share/vm/memory/metaspaceCounters.cpp
! src/share/vm/memory/metaspaceCounters.hpp
! src/share/vm/memory/metaspaceShared.cpp

Changeset: 9d75bcd7c890
Author:    mgerdin
Date:      2013-04-24 19:55 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/9d75bcd7c890

8013136: NPG: Parallel class loading tests fail after fix for JDK-8011802
Summary: Move initialization of dependencies to before allocation of CLD
Reviewed-by: stefank, coleenp

! src/share/vm/classfile/classLoaderData.cpp
! src/share/vm/classfile/classLoaderData.hpp

Changeset: d50cc62e94ff
Author:    johnc
Date:      2013-04-24 14:48 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d50cc62e94ff

8012715: G1: GraphKit accesses PtrQueue::_index as int but is size_t
Summary: In graphKit INT operations were generated to access PtrQueue::_index which has type size_t. This is 64 bit on 64-bit machines. No problems occur on little endian machines as long as the index fits into 32 bit, but on big endian machines the upper part is read, which is zero. This leads to unnecessary branches to the slow path in the runtime.
Reviewed-by: twisti, johnc
Contributed-by: Martin Doerr <martin.doerr at sap.com>

! src/share/vm/opto/graphKit.cpp

Changeset: b06ac540229e
Author:    stefank
Date:      2013-04-24 20:13 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b06ac540229e

8013132: Add a flag to turn off the output of the verbose verification code
Reviewed-by: johnc, brutisso

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp
! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp
! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/memory/universe.cpp
! src/share/vm/memory/universe.hpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/thread.cpp
! src/share/vm/runtime/vmThread.cpp
! src/share/vm/runtime/vm_operations.hpp

Changeset: b294421fa3c5
Author:    brutisso
Date:      2013-04-26 09:53 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b294421fa3c5

8012915: ReservedSpace::align_reserved_region() broken on Windows
Summary: remove unused constructors and helper methods for ReservedHeapSpace and ReservedSpace
Reviewed-by: mgerdin, jmasa, johnc, tschatzl

! src/share/vm/runtime/virtualspace.cpp
! src/share/vm/runtime/virtualspace.hpp

Changeset: 2f50bc369470
Author:    stefank
Date:      2013-04-26 10:40 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/2f50bc369470

8013160: NPG: Remove unnecessary mark stack draining after CodeCache::do_unloading
Reviewed-by: coleenp, mgerdin

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/memory/genMarkSweep.cpp

Changeset: 3edf23423bb2
Author:    johnc
Date:      2013-04-26 10:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/3edf23423bb2

8011898: gc/TestVerifyBeforeGCDuringStartup.java: java.lang.RuntimeException: '[Verifying' missing from stdout/stderr: [Error: Could not find or load main class]
Summary: System.getProperty("test.java.opts") can return NULL, which gets converted to to the empty string, and the child java command then interprets that as the name of the main class.
Reviewed-by: jmasa, brutisso

! test/gc/TestVerifyDuringStartup.java

Changeset: caac22686b17
Author:    mgerdin
Date:      2013-04-29 09:31 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/caac22686b17

Merge

! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
! src/share/vm/runtime/thread.cpp

Changeset: 601183f604b2
Author:    mgerdin
Date:      2013-04-29 13:07 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/601183f604b2

8013129: Possible deadlock with Metaspace locks due to mixed usage of safepoint aware and non-safepoint aware locking
Summary: Change Metaspace::deallocate to take lock with _no_safepoint_check_flag
Reviewed-by: coleenp, jmasa, dholmes

! src/share/vm/memory/metaspace.cpp

Changeset: 9075044ed66b
Author:    ehelin
Date:      2013-04-30 16:36 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/9075044ed66b

8008541: Remove old code in HotSpot that supported the jmap -permstat functionality
Reviewed-by: sla, brutisso

! agent/src/share/classes/sun/jvm/hotspot/tools/JMap.java

Changeset: d58c62b7447d
Author:    mgerdin
Date:      2013-05-02 19:28 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d58c62b7447d

Merge

! src/share/vm/classfile/classLoaderData.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp

Changeset: cbd4ce58f1f3
Author:    mgerdin
Date:      2013-05-02 16:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/cbd4ce58f1f3

Merge


Changeset: e12c9b3740db
Author:    vlivanov
Date:      2013-04-25 11:02 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/e12c9b3740db

8012260: ciReplay: Include PID into the name of replay data file
Reviewed-by: kvn, twisti

! src/os/bsd/vm/os_bsd.cpp
! src/os/linux/vm/os_linux.cpp
! src/os/posix/vm/os_posix.cpp
! src/os/solaris/vm/os_solaris.cpp
! src/os/windows/vm/os_windows.cpp
! src/share/vm/ci/ciEnv.cpp
! src/share/vm/ci/ciEnv.hpp
! src/share/vm/ci/ciReplay.cpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/os.hpp
! src/share/vm/utilities/ostream.hpp
! src/share/vm/utilities/vmError.cpp

Changeset: dc7db03f5aa2
Author:    iignatyev
Date:      2013-04-25 11:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/dc7db03f5aa2

8012337: Change Whitebox implementation to make absence of method in Whitebox.class not fatal
Reviewed-by: kvn, vlivanov

! src/share/vm/prims/whitebox.cpp
+ test/sanity/WhiteBox.java

Changeset: 7b23cb975cf2
Author:    iignatyev
Date:      2013-04-25 11:09 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/7b23cb975cf2

8011675: adding compilation level to replay data
Reviewed-by: kvn, vlivanov

- agent/doc/c2replay.html
+ agent/doc/cireplay.html
! agent/doc/clhsdb.html
! agent/src/share/classes/sun/jvm/hotspot/ci/ciEnv.java
! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java
! agent/src/share/classes/sun/jvm/hotspot/compiler/CompileTask.java
! src/share/vm/ci/ciEnv.cpp
! src/share/vm/ci/ciReplay.cpp
! src/share/vm/compiler/compileBroker.cpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/vmStructs.cpp
+ test/compiler/ciReplay/TestSA.sh
+ test/compiler/ciReplay/TestVM.sh
+ test/compiler/ciReplay/TestVM_no_comp_level.sh
+ test/compiler/ciReplay/common.sh

Changeset: 247342108a11
Author:    neliasso
Date:      2013-04-23 13:48 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/247342108a11

8010332: removed unused method: ciMethod::uses_monitors
Reviewed-by: twisti, roland
Contributed-by: albert.noll at oracle.com

! src/share/vm/ci/ciMethod.hpp

Changeset: a5c95fcf7cb7
Author:    neliasso
Date:      2013-04-23 18:06 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/a5c95fcf7cb7

8012157: removed unused code in SharedRuntime::handle_wrong_method
Reviewed-by: kvn, roland, rbackman
Contributed-by: albert.noll at oracle.com

! src/share/vm/runtime/sharedRuntime.cpp

Changeset: d1c9384eecb4
Author:    iignatyev
Date:      2013-04-26 07:21 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d1c9384eecb4

8012322: Tiered: CompilationPolicy::can_be_compiled(CompLevel_all) mistakenly return false
Reviewed-by: kvn, vlivanov

! src/share/vm/classfile/classLoader.cpp
! src/share/vm/runtime/compilationPolicy.cpp
! test/compiler/whitebox/CompilerWhiteBoxTest.java
! test/compiler/whitebox/MakeMethodNotCompilableTest.java

Changeset: 93b8272814cf
Author:    vlivanov
Date:      2013-04-26 08:33 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/93b8272814cf

Merge


Changeset: 0b55a78c6be5
Author:    bharadwaj
Date:      2013-04-26 10:52 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/0b55a78c6be5

Merge

- agent/doc/c2replay.html
! src/os/windows/vm/os_windows.cpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: fd49109d0d88
Author:    bharadwaj
Date:      2013-04-26 14:50 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/fd49109d0d88

Merge


Changeset: 487d442ef257
Author:    jiangli
Date:      2013-04-26 16:21 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/487d442ef257

8013036: vm/runtime/simpleThresholdPolicy.cpp: assert(mcs != NULL).
Summary: Change the assert to if check as MethodCounters could be NULL under TieredCompilation.
Reviewed-by: kvn, twisti

! src/share/vm/runtime/simpleThresholdPolicy.cpp

Changeset: 62b683108582
Author:    jiangli
Date:      2013-04-26 14:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/62b683108582

Merge


Changeset: 0cfa93c2fcc4
Author:    neliasso
Date:      2013-04-29 13:20 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/0cfa93c2fcc4

8012547: Code cache flushing can get stuck reclaming of memory
Summary: Keep sweeping regardless of if we are flushing
Reviewed-by: kvn, twisti

! src/share/vm/code/codeCache.cpp
! src/share/vm/code/codeCache.hpp
! src/share/vm/compiler/compileBroker.cpp
! src/share/vm/oops/method.cpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/sweeper.cpp
! src/share/vm/runtime/sweeper.hpp

Changeset: e4e131b15d5c
Author:    roland
Date:      2013-05-02 10:27 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/e4e131b15d5c

8013532: Remove unused parameter "compiler" from DTRACE_METHOD_COMPILE* macros
Summary: remove unused parameter in dtrace macros
Reviewed-by: kvn, roland
Contributed-by: albert.noll at oracle.com

! src/share/vm/compiler/compileBroker.cpp

Changeset: 9ce110b1d14a
Author:    kvn
Date:      2013-05-02 18:50 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/9ce110b1d14a

Merge

- agent/doc/c2replay.html
! src/os/bsd/vm/os_bsd.cpp
! src/os/linux/vm/os_linux.cpp
! src/os/solaris/vm/os_solaris.cpp
! src/share/vm/ci/ciEnv.cpp
! src/share/vm/prims/whitebox.cpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/utilities/vmError.cpp

Changeset: 4ec913499722
Author:    amurillo
Date:      2013-05-03 08:10 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/4ec913499722

Merge

- agent/doc/c2replay.html

Changeset: 9c1fe0b419b4
Author:    amurillo
Date:      2013-05-03 08:10 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/9c1fe0b419b4

Added tag hs25-b31 for changeset 4ec913499722

! .hgtags


From John.Coomes at oracle.com  Fri May  3 12:54:34 2013
From: John.Coomes at oracle.com (John Coomes)
Date: Fri, 3 May 2013 12:54:34 -0700
Subject: Result: nomination of Tao Mao as hsx Committer is unsuccessful
References: <20848.19457.854901.807286@oracle.com>
	<5170C575.2030101@oracle.com>
Message-ID: <20868.5626.83206.251155@oracle.com>

Voting for Tao Mao [1] is closed.

Yes: 12
Veto: 1
Abstain: 0

There was a valid veto [2], so the nomination is unsuccessful.

-John

[1] http://mail.openjdk.java.net/pipermail/hotspot-dev/2013-April/009282.html
[2] http://mail.openjdk.java.net/pipermail/hotspot-dev/2013-April/009303.html

From karen.kinnear at oracle.com  Fri May  3 13:08:44 2013
From: karen.kinnear at oracle.com (Karen Kinnear)
Date: Fri, 3 May 2013 16:08:44 -0400
Subject: RFR: 8013120 NMT: Kitchensink crashes with assert(next_region ==
	NULL || !next_region->is_committed_region()) failed: Sanity check
In-Reply-To: <518128EC.4040206@oracle.com>
References: <5179737D.7070800@oracle.com> <518128EC.4040206@oracle.com>
Message-ID: <FE42C630-733A-46A0-9207-744CFE46C9AE@oracle.com>

Zhengyu,

Code looks good. Thanks for the comments and assertions.

A couple of minor questions/comments:
1. memSnapshot.cpp - needs 2013 copyright
2. in memSnapshot.cpp
  the assertion you have is >= low_addr and <= high_addr
  - is this correct? I couldn't figure out the correct answer, but usually it would
  be  >= low_addr and < high_addr  - I don't know that it is wrong, just asking
  for clarification

thanks,
Karen

On May 1, 2013, at 10:38 AM, Zhengyu Gu wrote:

> I added comments in remove_released_region() to explain how virtual memory records are arranged in snapshot, and the loop to remove committed records following the reservation record.
> 
> Please review updated webrev: http://cr.openjdk.java.net/~zgu/8013120/webrev.02/ <http://cr.openjdk.java.net/%7Ezgu/8013120/webrev.02/>
> 
> Thanks,
> 
> -Zhengyu
> 
> 
> On 4/25/2013 2:18 PM, Zhengyu Gu wrote:
>> NMT expects all committed regions are uncommitted before the whole reserved region can be released. It was the case until 8011268.
>> 
>> This change allows NMT to handle the scenario that virtual memory is being released while there are committed segments within the reserved region.
>> 
>> It also fixed a missing virtual memory tag when ArrayAllocator allocates from virtual memory.
>> 
>> Bug: http://bugs.sun.com/view_bug.do?bug_id=8013120
>> Webrev: http://cr.openjdk.java.net/~zgu/8013120/webrev.00/ <http://cr.openjdk.java.net/%7Ezgu/8013120/webrev.00/>
>> 
>> Thanks,
>> 
>> -Zhengyu
> 


From zhengyu.gu at oracle.com  Fri May  3 13:19:34 2013
From: zhengyu.gu at oracle.com (Zhengyu Gu)
Date: Fri, 03 May 2013 16:19:34 -0400
Subject: RFR: 8013120 NMT: Kitchensink crashes with assert(next_region
	== NULL || !next_region->is_committed_region()) failed: Sanity check
In-Reply-To: <FE42C630-733A-46A0-9207-744CFE46C9AE@oracle.com>
References: <5179737D.7070800@oracle.com> <518128EC.4040206@oracle.com>
	<FE42C630-733A-46A0-9207-744CFE46C9AE@oracle.com>
Message-ID: <51841BD6.1080305@oracle.com>

Karen,

Thanks for review.

On 5/3/2013 4:08 PM, Karen Kinnear wrote:
> Zhengyu,
>
> Code looks good. Thanks for the comments and assertions.
>
> A couple of minor questions/comments:
> 1. memSnapshot.cpp - needs 2013 copyright
I will fix it.
> 2. in memSnapshot.cpp
>    the assertion you have is >= low_addr and <= high_addr
>    - is this correct? I couldn't figure out the correct answer, but usually it would
>    be  >= low_addr and < high_addr  - I don't know that it is wrong, just asking
>    for clarification
This is correct, since this is the comparison between the reserved range 
and committed range, both high addresses are exclusive.

Thanks,

-Zhengyu


> thanks,
> Karen
>
> On May 1, 2013, at 10:38 AM, Zhengyu Gu wrote:
>
>> I added comments in remove_released_region() to explain how virtual memory records are arranged in snapshot, and the loop to remove committed records following the reservation record.
>>
>> Please review updated webrev: http://cr.openjdk.java.net/~zgu/8013120/webrev.02/ <http://cr.openjdk.java.net/%7Ezgu/8013120/webrev.02/>
>>
>> Thanks,
>>
>> -Zhengyu
>>
>>
>> On 4/25/2013 2:18 PM, Zhengyu Gu wrote:
>>> NMT expects all committed regions are uncommitted before the whole reserved region can be released. It was the case until 8011268.
>>>
>>> This change allows NMT to handle the scenario that virtual memory is being released while there are committed segments within the reserved region.
>>>
>>> It also fixed a missing virtual memory tag when ArrayAllocator allocates from virtual memory.
>>>
>>> Bug: http://bugs.sun.com/view_bug.do?bug_id=8013120
>>> Webrev: http://cr.openjdk.java.net/~zgu/8013120/webrev.00/ <http://cr.openjdk.java.net/%7Ezgu/8013120/webrev.00/>
>>>
>>> Thanks,
>>>
>>> -Zhengyu


From alejandro.murillo at oracle.com  Fri May  3 16:40:15 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 03 May 2013 23:40:15 +0000
Subject: hg: hsx/hotspot-main/hotspot: 4 new changesets
Message-ID: <20130503234026.6D60C48805@hg.openjdk.java.net>

Changeset: d0081bfc425c
Author:    katleman
Date:      2013-05-02 13:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d0081bfc425c

Added tag jdk8-b88 for changeset 8482058e74bc

! .hgtags

Changeset: 4ec913499722
Author:    amurillo
Date:      2013-05-03 08:10 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/4ec913499722

Merge

- agent/doc/c2replay.html

Changeset: 9c1fe0b419b4
Author:    amurillo
Date:      2013-05-03 08:10 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/9c1fe0b419b4

Added tag hs25-b31 for changeset 4ec913499722

! .hgtags

Changeset: 625ddb0052e1
Author:    amurillo
Date:      2013-05-03 08:19 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/625ddb0052e1

8013800: new hotspot build - hs25-b32
Reviewed-by: jcoomes

! make/hotspot_version


From volker.simonis at gmail.com  Mon May  6 06:59:06 2013
From: volker.simonis at gmail.com (Volker Simonis)
Date: Mon, 6 May 2013 15:59:06 +0200
Subject: RFR: 8013398: Adjust number of stack guard pages on systems with
	large memory page size
In-Reply-To: <51803C44.9080508@oracle.com>
References: <C6C003C8-61A5-449B-8C25-38929F845678@oracle.com>
	<CA+3eh10zoqH-b3qBH8PDugeuP39OcgyE--tB036JVzejwHwnzw@mail.gmail.com>
	<8A85EDB0-C7C1-4695-8EA0-71AD6D9EA4E0@oracle.com>
	<CA+3eh11=wdo+DgQOx=U9vx+Pc=YbuM-qwTOSmYXwycqG7HUH7A@mail.gmail.com>
	<517EAF81.4030309@oracle.com>
	<CA+3eh128OH3wYk8eE55ztGT4EOihxO=oyP-rybbeue0xzDw_xA@mail.gmail.com>
	<51803C44.9080508@oracle.com>
Message-ID: <CA+3eh13mAQRmPdpCNNOhQzONVYrQZB=noeoOyZ095n5YrzVTmw@mail.gmail.com>

On Tue, Apr 30, 2013 at 11:48 PM, Coleen Phillimore
<coleen.phillimore at oracle.com> wrote:
>
> Hi Volker,
> Besides changing the parameters to be in terms of size rather than pages,
> the os_linux.cpp change is compatible with what Vlad has done.  This part of
> the change fixes the problem with having too much reserved space on the
> stack.   Changing these parameter names is going to be problematic because
> we do have customers that we've given StackShadowPages as an option and they
> won't be happy if it goes away.
>

I don't see a problem here. The StackXXXPages parameters don't go away
in my change. They are still there and customers can still set them at
their own discretion (i.e. they should really know what page size
their operating system is using). The big advantage of the proposed
change is that the VM writers (i.e. Oracle) can supply reasonable
values for StackXXX zones in bytes and these byte values will be
mapped to meaningful page values at runtime no difference what page
size the operating system is using. All this is handled during VM
startup (in the method Arguments::process_stackguardpages_option())
which maps the new StackXXXSize values to meaningful StackXXXPages
values. On PPC for example, if we use the current scheme and specify
the StackXXXPages parameters with respect to 4K pages but the customer
run the VM on a 64K pages system (which is not unusual) he may end up
using 16 times too much Shadow/Yellow/Red space. With ~20 shadow
pages, this can be quite significant!

> I think we should integrate Vlad's fix and think about your changes or how
> we can make these work compatibly.
>

Yes, I agree.

> Vlad - Should the default page size be changed to 4K though, as Volker
> suggested in his code review?
>
> Thanks,
> Coleen
>
>
> On 04/30/2013 12:37 PM, Volker Simonis wrote:
>>
>> Hi Coleen, Vladimir,
>>
>> here you can find a first version of what I was thinking about:
>>
>> http://cr.openjdk.java.net/~simonis/webrevs/8013398.v1/
>>
>> This may still need some polishing and I haven?t done extensive testing
>> with it.
>> I just wanted to give you a quick idea of my proposal as I will be out
>> of office until Monday.
>>
>> Thank you and best regards,
>> Volker
>>
>>
>>
>> On Mon, Apr 29, 2013 at 7:36 PM, Coleen Phillimore
>> <coleen.phillimore at oracle.com> wrote:
>>>
>>> Hi Volker,
>>>
>>> When looking at Vlad's change, I was thinking along these lines.
>>> StackYellowPages, RedPages and ShadowPages would be better specified as a
>>> size in bytes rather than page size to account for the differences in
>>> page
>>> sizes on different platforms.
>>>
>>> The stack banging code is done in increments of "page_size" though, and
>>> the
>>> protection code has to be done on page size boundaries.   So there has to
>>> be
>>> some platform specific rounding to get the number of pages.   I think the
>>> code change that Vlad sent is the minimally disruptive way to do this.
>>> Adding new options for StackShadowSize and all that will just confuse
>>> people, I think.   We tell people to use different StackShadowPages all
>>> the
>>> time and it's even in our documentation.
>>>
>>> I guess we'll have to see your patch and it would be good to have your
>>> code
>>> to be in open.
>>>
>>> Thanks,
>>> Coleen
>>>
>>>
>>> On 04/29/2013 12:55 PM, Volker Simonis wrote:
>>>>
>>>> On Mon, Apr 29, 2013 at 5:38 PM, Vladimir Danushevsky
>>>> <vladimir.danushevsky at oracle.com> wrote:
>>>>>
>>>>> Hi Volker,
>>>>>
>>>>> Thanks for the suggestion.
>>>>>
>>>>> If I understand your approach correctly you suggest providing a dual
>>>>> way
>>>>> to specify guard area sizes (ether through number of pages or through
>>>>> an
>>>>> absolute size in KB) and have the VM to correlate between the two: Size
>>>>> value will dominate unless explicitly overwritten by the Page value.
>>>>> Is that correct?
>>>>>
>>>> Yes, that's correct. The *Page values should become obsolete although
>>>> I think there's currently no mechanism for that in OpenJDK.
>>>>
>>>> Internally, i.e. in globals_<ARCH>.hpp, we could define the values
>>>> independently of the actual system page size with the *Size flags.
>>>>
>>>>> Will your approach eventually get same amount of allocated guard area
>>>>> as
>>>>> the patch suggested earlier would?
>>>>
>>>> I think more or less yes:) It would depend on the settings of the
>>>> *Size flags of course.
>>>>
>>>> E.g. currently on AMD64 we have:
>>>>
>>>> define_pd_global(intx, StackYellowPages, 2);
>>>> define_pd_global(intx, StackRedPages, 1);
>>>> define_pd_global(intx, StackShadowPages, NOT_WIN64(20) WIN64_ONLY(6)
>>>> DEBUG_ONLY(+2));
>>>>
>>>> With your fix and a page size of 64K we would get:
>>>>
>>>> StackYellowPages = 1;
>>>> StackRedPages = 1;
>>>> StackShadowPages = round_to((StackShadowPages * 8K), 64K) / 64K =
>>>> round_to(20 * 8K, 64K) / 64K = 3
>>>>
>>>> and:
>>>>
>>>> min_staqck =
>>>> (StackYellowPages+StackRedPages+StackShadowPages) * Linux::page_size() +
>>>> (2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::vm_default_page_size()
>>>> =
>>>> (1 + 1 + 3) * 64K +
>>>> (16 + 1) * 8K
>>>> =
>>>> 5 * 64K + 17 * 8K
>>>> =
>>>> 456K
>>>>
>>>> With our proposed fix we would get:
>>>>
>>>> define_pd_global(intx, StackYellowSize, 8K);
>>>> define_pd_global(intx, StackRedSize, 4K);
>>>> define_pd_global(intx, StackShadowSize, NOT_WIN64(80K) WIN64_ONLY(24K)
>>>> DEBUG_ONLY(+8K));
>>>>
>>>> this would result in:
>>>>
>>>> StackYellowPages = 1;
>>>> StackRedPages = 1;
>>>> StackShadowPages = 2
>>>>
>>>> and:
>>>>
>>>> min_staqck =
>>>> (StackYellowPages+StackRedPages+StackShadowPages) * Linux::page_size() +
>>>> (2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::vm_default_page_size()
>>>> =
>>>> (1 + 1 + 2) * 64K +
>>>> (16 + 1) * 8K
>>>> =
>>>> 4 * 64K + 17 * 8K
>>>> =
>>>> 392
>>>>
>>>>> If an intent is to make the adjustments global (i.e. independent of the
>>>>> OS) should we copy those to the arguments.cpp instead of os_<OS
>>>>> name>.cpp?However  I'm not positive whether Windows, as an example,
>>>>> does
>>>>> need a guard area adjustment (but I might be wrong here).
>>>>>
>>>> I think the adjustment should stay in the platform dependent code.
>>>>
>>>>> Please post the webrev with the approach you suggested. It should be
>>>>> viewed as an alternative.
>>>>
>>>> I'll prepare it.
>>>>
>>>> Just one question - why did you choose:
>>>>
>>>> _vm_default_page_size = 8K
>>>>
>>>> Shouldn't this really be 4K?
>>>>
>>>>> Thanks,
>>>>> Vlad
>>>>>
>>>>>
>>>>> On Apr 29, 2013, at 11:03 AM, Volker Simonis wrote:
>>>>>
>>>>>> Hi Vlad,
>>>>>>
>>>>>> thanks for addressing this issue. We have this problem as well since
>>>>>> long time and we would like to propose a more general solution:
>>>>>>
>>>>>> Introduce three new platform dependant product flags:
>>>>>>
>>>>>> StackYellowSize
>>>>>> StackRedSize
>>>>>> StackShadowSize
>>>>>>
>>>>>> which are to be used to specify the concrete size of the corresponding
>>>>>> stack regions. These sizes would be rounded up to the next multiple of
>>>>>> the current OS page size (or more precisely the next multiple of the
>>>>>> current OS stack page size, because there are systems which have
>>>>>> different page sizes for stacks than for heap).
>>>>>>
>>>>>> This would allow us to make simple, (i.e. not platform dependent)
>>>>>> product flags out of:
>>>>>>
>>>>>> StackYellowPages
>>>>>> StackRedPages
>>>>>> StackShadowPages
>>>>>>
>>>>>> and set their default value to -1.
>>>>>>
>>>>>> At VM start-up, before argument parsing, we will compute the values
>>>>>> for StackYellowPages, StackRedPages, StackShadowPages from
>>>>>> StackYellowSize, StackRedSize, StackShadowSize and the actual OS page
>>>>>> size. Later on, during argument parsing, if one of these flags is
>>>>>> given on the command line, either part of these value pairs may be
>>>>>> adjusted in order to be consistent with its counterpart.
>>>>>>
>>>>>> The drawback of this approach is that you get three more options but
>>>>>> from our point of view this is outweighed by the fact that with this
>>>>>> approach you 'fix' all the places where you currently waste a lot of
>>>>>> memory if the VM is running on a system with a default page size
>>>>>> bigger than 4K.
>>>>>>
>>>>>> Notice that we use this approach since years in our commercial VM and
>>>>>> only haven't integrated it into our OpenJDK PowerPC/AIX Port because
>>>>>> we wanted to minimize the amount of shared code changes. We would be
>>>>>> happy however to contribute it now that the discussion on this problem
>>>>>> has popped up publicly on the mailing list. So if you agree, I could
>>>>>> post a webrev with the proposed changes.
>>>>>>
>>>>>> Regards,
>>>>>> Volker
>>>>>>
>>>>>> On Sat, Apr 27, 2013 at 2:34 AM, Vladimir Danushevsky
>>>>>> <vladimir.danushevsky at oracle.com> wrote:
>>>>>>>
>>>>>>> Please review the following change:
>>>>>>>
>>>>>>> http://cr.openjdk.java.net/~vladidan/8013398/webrev.00/
>>>>>>>
>>>>>>> for
>>>>>>> https://jbs.oracle.com/bugs/browse/JDK-8013398
>>>>>>>
>>>>>>> On a non-typical Linux system configuration with large page size
>>>>>>> (e.g.
>>>>>>> 64KB) significant amount of virtual memory is wasted to multiple
>>>>>>> guard pages
>>>>>>> when in fact that can be reduced to a single page per
>>>>>>> Red/Yellow/Shadow
>>>>>>> categories.
>>>>>>> In some edge cases a minimal stack requirement is calculated higher
>>>>>>> than actual stack size specified by ThreadStackSize parameter causing
>>>>>>> VM to
>>>>>>> abort unless stack size is overwritten via -Xss option.
>>>>>>>
>>>>>>> A patch currently being suggested adjusts amount of guard pages to a
>>>>>>> single memory page each along with minimal stack size when memory
>>>>>>> page size
>>>>>>> exceed 8KB unless explicitly overwritten in command line.
>>>>>>>
>>>>>>> Currently we are aware of the problem on some Linux platforms,
>>>>>>> therefore the change is specific to that OS only (Solaris carries a
>>>>>>> similar
>>>>>>> approach already).
>>>>>>>
>>>>>>> Shall the description string of StackRedPage, StackYellowPages and
>>>>>>> StackShadow pages be modified to reflect the values could be scaled
>>>>>>> down? If
>>>>>>> so the comment needs to indicate the change affects Linux and Solaris
>>>>>>> only.
>>>>>>> Any comments welcome here.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Vlad
>>>
>>>
>

From christian.thalinger at oracle.com  Mon May  6 09:35:42 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Mon, 6 May 2013 09:35:42 -0700
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <920F24B7-3D5C-4170-8BAC-1E3D88AAEBE9@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>	<51759F6B.7080808@oracle.com>	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>	<51764FDE.2090205@oracle.com>
	<517669A6.8030705@oracle.com>	<5176CD8E.5060704@oracle.com>	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>	<5176D417.3040202@oracle.com>
	<51817DED.2050603@oracle.com> <51818766.20604@oracle.com>
	<00d901ce46b3$28037a90$780a6fb0$@tornqvist@oracle.com>
	<51818E47.1050605@oracle.com>
	<96D28554-AC5A-40EA-A763-ABC554D650DC@oracle.com>
	<9626A9E3-7FE7-49AA-80B2-ACA6BC01EFD1@oracle.com>
	<47BCCD49-D0D9-45C2-9DC8-9A96F1094F35@oracle.com>
	<920F24B7-3D5C-4170-8BAC-1E3D88AAEBE9@oracle.com>
Message-ID: <7AC60D13-DEFF-41F0-9511-E19882879965@oracle.com>

Last warning!  If nobody speaks up today I'm going to push this later:

http://cr.openjdk.java.net/~twisti/8008772/

-- Chris

On May 2, 2013, at 5:28 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:

> 
> On May 2, 2013, at 5:25 PM, John Rose <john.r.rose at oracle.com> wrote:
> 
>> On May 2, 2013, at 4:44 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>> 
>>> is anyone using env.{sh,csh}?
>> 
>> I'll suggest that the answer is going to be "no".  I think very few people have ever used them.  ? John
> 
> I think you're right.  Let's remove them with this change then.
> 
> -- Chris


From vladimir.kozlov at oracle.com  Mon May  6 09:50:16 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Mon, 06 May 2013 09:50:16 -0700
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <7AC60D13-DEFF-41F0-9511-E19882879965@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>	<51759F6B.7080808@oracle.com>	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>	<51764FDE.2090205@oracle.com>
	<517669A6.8030705@oracle.com>	<5176CD8E.5060704@oracle.com>	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>	<5176D417.3040202@oracle.com>
	<51817DED.2050603@oracle.com> <51818766.20604@oracle.com>
	<00d901ce46b3$28037a90$780a6fb0$@tornqvist@oracle.com>
	<51818E47.1050605@oracle.com>
	<96D28554-AC5A-40EA-A763-ABC554D650DC@oracle.com>
	<9626A9E3-7FE7-49AA-80B2-ACA6BC01EFD1@oracle.com>
	<47BCCD49-D0D9-45C2-9DC8-9A96F1094F35@oracle.com>
	<920F24B7-3D5C-4170-8BAC-1E3D88AAEBE9@oracle.com>
	<7AC60D13-DEFF-41F0-9511-E19882879965@oracle.com>
Message-ID: <5187DF48.5070206@oracle.com>

Did you use 'hg rename' to move hotspot.script? We need to preserve history.

Thanks,
Vladimir


On 5/6/13 9:35 AM, Christian Thalinger wrote:
> Last warning!  If nobody speaks up today I'm going to push this later:
>
> http://cr.openjdk.java.net/~twisti/8008772/
>
> -- Chris
>
> On May 2, 2013, at 5:28 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>
>>
>> On May 2, 2013, at 5:25 PM, John Rose <john.r.rose at oracle.com> wrote:
>>
>>> On May 2, 2013, at 4:44 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>>
>>>> is anyone using env.{sh,csh}?
>>>
>>> I'll suggest that the answer is going to be "no".  I think very few people have ever used them.  ? John
>>
>> I think you're right.  Let's remove them with this change then.
>>
>> -- Chris
>

From christian.thalinger at oracle.com  Mon May  6 10:20:55 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Mon, 6 May 2013 10:20:55 -0700
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <5187DF48.5070206@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>	<51759F6B.7080808@oracle.com>	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>	<51764FDE.2090205@oracle.com>
	<517669A6.8030705@oracle.com>	<5176CD8E.5060704@oracle.com>	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>	<5176D417.3040202@oracle.com>
	<51817DED.2050603@oracle.com> <51818766.20604@oracle.com>
	<00d901ce46b3$28037a90$780a6fb0$@tornqvist@oracle.com>
	<51818E47.1050605@oracle.com>
	<96D28554-AC5A-40EA-A763-ABC554D650DC@oracle.com>
	<9626A9E3-7FE7-49AA-80B2-ACA6BC01EFD1@oracle.com>
	<47BCCD49-D0D9-45C2-9DC8-9A96F1094F35@oracle.com>
	<920F24B7-3D5C-4170-8BAC-1E3D88AAEBE9@oracle.com>
	<7AC60D13-DEFF-41F0-9511-E19882879965@oracle.com>
	<5187DF48.5070206@oracle.com>
Message-ID: <86D5AC97-5DE8-4E96-9B56-F7F75066302E@oracle.com>


On May 6, 2013, at 9:50 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

> Did you use 'hg rename' to move hotspot.script? We need to preserve history.

hg move, yes.  An hg diff on my machine shows a diff:

cthaling at macbook:~/ws/8008772$ hg di make/hotspot.script 
diff --git a/src/os/posix/launcher/launcher.script b/make/hotspot.script
copy from src/os/posix/launcher/launcher.script
copy to make/hotspot.script
--- a/src/os/posix/launcher/launcher.script
+++ b/make/hotspot.script
@@ -72,6 +72,7 @@
 REL_MYDIR=`dirname $0`
 MYDIR=`cd $REL_MYDIR && pwd`
 
+#
 # Look whether the user wants to run inside gdb
 case "$1" in
     -gdb)
@@ -95,16 +96,14 @@

-- Chris

> 
> Thanks,
> Vladimir
> 
> 
> On 5/6/13 9:35 AM, Christian Thalinger wrote:
>> Last warning!  If nobody speaks up today I'm going to push this later:
>> 
>> http://cr.openjdk.java.net/~twisti/8008772/
>> 
>> -- Chris
>> 
>> On May 2, 2013, at 5:28 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>> 
>>> 
>>> On May 2, 2013, at 5:25 PM, John Rose <john.r.rose at oracle.com> wrote:
>>> 
>>>> On May 2, 2013, at 4:44 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>>> 
>>>>> is anyone using env.{sh,csh}?
>>>> 
>>>> I'll suggest that the answer is going to be "no".  I think very few people have ever used them.  ? John
>>> 
>>> I think you're right.  Let's remove them with this change then.
>>> 
>>> -- Chris
>> 


From vladimir.kozlov at oracle.com  Mon May  6 10:34:41 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Mon, 06 May 2013 10:34:41 -0700
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <86D5AC97-5DE8-4E96-9B56-F7F75066302E@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>	<51759F6B.7080808@oracle.com>	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>	<51764FDE.2090205@oracle.com>
	<517669A6.8030705@oracle.com>	<5176CD8E.5060704@oracle.com>	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>	<5176D417.3040202@oracle.com>
	<51817DED.2050603@oracle.com> <51818766.20604@oracle.com>
	<00d901ce46b3$28037a90$780a6fb0$@tornqvist@oracle.com>
	<51818E47.1050605@oracle.com>
	<96D28554-AC5A-40EA-A763-ABC554D650DC@oracle.com>
	<9626A9E3-7FE7-49AA-80B2-ACA6BC01EFD1@oracle.com>
	<47BCCD49-D0D9-45C2-9DC8-9A96F1094F35@oracle.com>
	<920F24B7-3D5C-4170-8BAC-1E3D88AAEBE9@oracle.com>
	<7AC60D13-DEFF-41F0-9511-E19882879965@oracle.com>
	<5187DF48.5070206@oracle.com>
	<86D5AC97-5DE8-4E96-9B56-F7F75066302E@oracle.com>
Message-ID: <5187E9B1.8070707@oracle.com>

I see, you also modified it. Okay I agree with changes.

Thanks
Vladimir

On 5/6/13 10:20 AM, Christian Thalinger wrote:
>
> On May 6, 2013, at 9:50 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>
>> Did you use 'hg rename' to move hotspot.script? We need to preserve history.
>
> hg move, yes.  An hg diff on my machine shows a diff:
>
> cthaling at macbook:~/ws/8008772$ hg di make/hotspot.script
> diff --git a/src/os/posix/launcher/launcher.script b/make/hotspot.script
> copy from src/os/posix/launcher/launcher.script
> copy to make/hotspot.script
> --- a/src/os/posix/launcher/launcher.script
> +++ b/make/hotspot.script
> @@ -72,6 +72,7 @@
>   REL_MYDIR=`dirname $0`
>   MYDIR=`cd $REL_MYDIR && pwd`
>
> +#
>   # Look whether the user wants to run inside gdb
>   case "$1" in
>       -gdb)
> @@ -95,16 +96,14 @@
>
> -- Chris
>
>>
>> Thanks,
>> Vladimir
>>
>>
>> On 5/6/13 9:35 AM, Christian Thalinger wrote:
>>> Last warning!  If nobody speaks up today I'm going to push this later:
>>>
>>> http://cr.openjdk.java.net/~twisti/8008772/
>>>
>>> -- Chris
>>>
>>> On May 2, 2013, at 5:28 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>>
>>>>
>>>> On May 2, 2013, at 5:25 PM, John Rose <john.r.rose at oracle.com> wrote:
>>>>
>>>>> On May 2, 2013, at 4:44 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>>>>
>>>>>> is anyone using env.{sh,csh}?
>>>>>
>>>>> I'll suggest that the answer is going to be "no".  I think very few people have ever used them.  ? John
>>>>
>>>> I think you're right.  Let's remove them with this change then.
>>>>
>>>> -- Chris
>>>
>

From mike.duigou at oracle.com  Mon May  6 10:40:08 2013
From: mike.duigou at oracle.com (Mike Duigou)
Date: Mon, 6 May 2013 10:40:08 -0700
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <86D5AC97-5DE8-4E96-9B56-F7F75066302E@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>	<51759F6B.7080808@oracle.com>	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>	<51764FDE.2090205@oracle.com>
	<517669A6.8030705@oracle.com>	<5176CD8E.5060704@oracle.com>	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>	<5176D417.3040202@oracle.com>
	<51817DED.2050603@oracle.com> <51818766.20604@oracle.com>
	<00d901ce46b3$28037a90$780a6fb0$@tornqvist@oracle.com>
	<51818E47.1050605@oracle.com>
	<96D28554-AC5A-40EA-A763-ABC554D650DC@oracle.com>
	<9626A9E3-7FE7-49AA-80B2-ACA6BC01EFD1@oracle.com>
	<47BCCD49-D0D9-45C2-9DC8-9A96F1094F35@oracle.com>
	<920F24B7-3D5C-4170-8BAC-1E3D88AAEBE9@oracle.com>
	<7AC60D13-DEFF-41F0-9511-E19882879965@oracle.com>
	<5187DF48.5070206@oracle.com>
	<86D5AC97-5DE8-4E96-9B56-F7F75066302E@oracle.com>
Message-ID: <6EF8A2BF-E71B-429A-98B9-FA4F913BD3D8@oracle.com>

You may wish to sync your custom webrev script with the mainline webrev.ksh. It recently improved it's support for including a proper hg changeset rather than the patches that webrev has traditional generated. The improved changeset support handles hg copies and moves correctly whereas legacy webrev generated patches do not.

Mike

On May 6 2013, at 10:20 , Christian Thalinger wrote:

> 
> On May 6, 2013, at 9:50 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
>> Did you use 'hg rename' to move hotspot.script? We need to preserve history.
> 
> hg move, yes.  An hg diff on my machine shows a diff:
> 
> cthaling at macbook:~/ws/8008772$ hg di make/hotspot.script 
> diff --git a/src/os/posix/launcher/launcher.script b/make/hotspot.script
> copy from src/os/posix/launcher/launcher.script
> copy to make/hotspot.script
> --- a/src/os/posix/launcher/launcher.script
> +++ b/make/hotspot.script
> @@ -72,6 +72,7 @@
> REL_MYDIR=`dirname $0`
> MYDIR=`cd $REL_MYDIR && pwd`
> 
> +#
> # Look whether the user wants to run inside gdb
> case "$1" in
>     -gdb)
> @@ -95,16 +96,14 @@
> 
> -- Chris
> 
>> 
>> Thanks,
>> Vladimir
>> 
>> 
>> On 5/6/13 9:35 AM, Christian Thalinger wrote:
>>> Last warning!  If nobody speaks up today I'm going to push this later:
>>> 
>>> http://cr.openjdk.java.net/~twisti/8008772/
>>> 
>>> -- Chris
>>> 
>>> On May 2, 2013, at 5:28 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>> 
>>>> 
>>>> On May 2, 2013, at 5:25 PM, John Rose <john.r.rose at oracle.com> wrote:
>>>> 
>>>>> On May 2, 2013, at 4:44 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>>>> 
>>>>>> is anyone using env.{sh,csh}?
>>>>> 
>>>>> I'll suggest that the answer is going to be "no".  I think very few people have ever used them.  ? John
>>>> 
>>>> I think you're right.  Let's remove them with this change then.
>>>> 
>>>> -- Chris
>>> 
> 


From coleen.phillimore at oracle.com  Mon May  6 10:47:56 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Mon, 06 May 2013 13:47:56 -0400
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <6EF8A2BF-E71B-429A-98B9-FA4F913BD3D8@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>	<51759F6B.7080808@oracle.com>	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>	<51764FDE.2090205@oracle.com>
	<517669A6.8030705@oracle.com>	<5176CD8E.5060704@oracle.com>	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>	<5176D417.3040202@oracle.com>
	<51817DED.2050603@oracle.com> <51818766.20604@oracle.com>
	<00d901ce46b3$28037a90$780a6fb0$@tornqvist@oracle.com>
	<51818E47.1050605@oracle.com>
	<96D28554-AC5A-40EA-A763-ABC554D650DC@oracle.com>
	<9626A9E3-7FE7-49AA-80B2-ACA6BC01EFD1@oracle.com>
	<47BCCD49-D0D9-45C2-9DC8-9A96F1094F35@oracle.com>
	<920F24B7-3D5C-4170-8BAC-1E3D88AAEBE9@oracle.com>
	<7AC60D13-DEFF-41F0-9511-E19882879965@oracle.com>
	<5187DF48.5070206@oracle.com>
	<86D5AC97-5DE8-4E96-9B56-F7F75066302E@oracle.com>
	<6EF8A2BF-E71B-429A-98B9-FA4F913BD3D8@oracle.com>
Message-ID: <5187ECCC.1070301@oracle.com>


Does the mainline webrev have navigation from file to file yet?

*src/share/tools/ProjectCreator/BuildConfig.java*
Index <http://cr.openjdk.java.net/%7Etwisti/8008772/> Unified diffs 
<http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/BuildConfig.java.udiff.html> 
Context diffs 
<http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/BuildConfig.java.cdiff.html> 
Sdiffs 
<http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/BuildConfig.java.sdiff.html> 
Patch 
<http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/BuildConfig.java.patch> 
New 
<http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/BuildConfig.java.html> 
Old 
<http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/BuildConfig.java-.html> 
Previous File 
<http://cr.openjdk.java.net/%7Etwisti/8008772/src/os/windows/launcher/java_md.h.udiff.html> 
Next File 
<http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/WinGammaPlatformVC10.java.udiff.html>

That's why I use the custom webrev.

Coleen

On 05/06/2013 01:40 PM, Mike Duigou wrote:
> You may wish to sync your custom webrev script with the mainline webrev.ksh. It recently improved it's support for including a proper hg changeset rather than the patches that webrev has traditional generated. The improved changeset support handles hg copies and moves correctly whereas legacy webrev generated patches do not.
>
> Mike
>
> On May 6 2013, at 10:20 , Christian Thalinger wrote:
>
>> On May 6, 2013, at 9:50 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>
>>> Did you use 'hg rename' to move hotspot.script? We need to preserve history.
>> hg move, yes.  An hg diff on my machine shows a diff:
>>
>> cthaling at macbook:~/ws/8008772$ hg di make/hotspot.script
>> diff --git a/src/os/posix/launcher/launcher.script b/make/hotspot.script
>> copy from src/os/posix/launcher/launcher.script
>> copy to make/hotspot.script
>> --- a/src/os/posix/launcher/launcher.script
>> +++ b/make/hotspot.script
>> @@ -72,6 +72,7 @@
>> REL_MYDIR=`dirname $0`
>> MYDIR=`cd $REL_MYDIR && pwd`
>>
>> +#
>> # Look whether the user wants to run inside gdb
>> case "$1" in
>>      -gdb)
>> @@ -95,16 +96,14 @@
>>
>> -- Chris
>>
>>> Thanks,
>>> Vladimir
>>>
>>>
>>> On 5/6/13 9:35 AM, Christian Thalinger wrote:
>>>> Last warning!  If nobody speaks up today I'm going to push this later:
>>>>
>>>> http://cr.openjdk.java.net/~twisti/8008772/
>>>>
>>>> -- Chris
>>>>
>>>> On May 2, 2013, at 5:28 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>>>
>>>>> On May 2, 2013, at 5:25 PM, John Rose <john.r.rose at oracle.com> wrote:
>>>>>
>>>>>> On May 2, 2013, at 4:44 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>>>>>
>>>>>>> is anyone using env.{sh,csh}?
>>>>>> I'll suggest that the answer is going to be "no".  I think very few people have ever used them.  ? John
>>>>> I think you're right.  Let's remove them with this change then.
>>>>>
>>>>> -- Chris


From christian.thalinger at oracle.com  Mon May  6 12:48:56 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Mon, 6 May 2013 12:48:56 -0700
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <5187ECCC.1070301@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>	<51759F6B.7080808@oracle.com>	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>	<51764FDE.2090205@oracle.com>
	<517669A6.8030705@oracle.com>	<5176CD8E.5060704@oracle.com>	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>	<5176D417.3040202@oracle.com>
	<51817DED.2050603@oracle.com> <51818766.20604@oracle.com>
	<00d901ce46b3$28037a90$780a6fb0$@tornqvist@oracle.com>
	<51818E47.1050605@oracle.com>
	<96D28554-AC5A-40EA-A763-ABC554D650DC@oracle.com>
	<9626A9E3-7FE7-49AA-80B2-ACA6BC01EFD1@oracle.com>
	<47BCCD49-D0D9-45C2-9DC8-9A96F1094F35@oracle.com>
	<920F24B7-3D5C-4170-8BAC-1E3D88AAEBE9@oracle.com>
	<7AC60D13-DEFF-41F0-9511-E19882879965@oracle.com>
	<5187DF48.5070206@oracle.com>
	<86D5AC97-5DE8-4E96-9B56-F7F75066302E@oracle.com>
	<6EF8A2BF-E71B-429A-98B9-FA4F913BD3D8@oracle.com>
	<5187ECCC.1070301@oracle.com>
Message-ID: <BD713FA4-0A53-4679-870D-3D09C79546A9@oracle.com>


On May 6, 2013, at 10:47 AM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:

> 
> Does the mainline webrev have navigation from file to file yet?
> 
> *src/share/tools/ProjectCreator/BuildConfig.java*
> Index <http://cr.openjdk.java.net/%7Etwisti/8008772/> Unified diffs <http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/BuildConfig.java.udiff.html> Context diffs <http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/BuildConfig.java.cdiff.html> Sdiffs <http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/BuildConfig.java.sdiff.html> Patch <http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/BuildConfig.java.patch> New <http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/BuildConfig.java.html> Old <http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/BuildConfig.java-.html> Previous File <http://cr.openjdk.java.net/%7Etwisti/8008772/src/os/windows/launcher/java_md.h.udiff.html> Next File <http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/WinGammaPlatformVC10.java.udiff.html>
> 
> That's why I use the custom webrev.

That's also the main reason why I use it.  Could we add that to the mainline version?  Although I'd rather see webrev disappear completely and be replaced with something more suitable for this century.

Anyway, I tried the latest in jdk8 and I don't see a difference:

http://cr.openjdk.java.net/~twisti/8008772/webrev/make/hotspot.script.html

-- Chris

> 
> Coleen
> 
> On 05/06/2013 01:40 PM, Mike Duigou wrote:
>> You may wish to sync your custom webrev script with the mainline webrev.ksh. It recently improved it's support for including a proper hg changeset rather than the patches that webrev has traditional generated. The improved changeset support handles hg copies and moves correctly whereas legacy webrev generated patches do not.
>> 
>> Mike
>> 
>> On May 6 2013, at 10:20 , Christian Thalinger wrote:
>> 
>>> On May 6, 2013, at 9:50 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>> 
>>>> Did you use 'hg rename' to move hotspot.script? We need to preserve history.
>>> hg move, yes.  An hg diff on my machine shows a diff:
>>> 
>>> cthaling at macbook:~/ws/8008772$ hg di make/hotspot.script
>>> diff --git a/src/os/posix/launcher/launcher.script b/make/hotspot.script
>>> copy from src/os/posix/launcher/launcher.script
>>> copy to make/hotspot.script
>>> --- a/src/os/posix/launcher/launcher.script
>>> +++ b/make/hotspot.script
>>> @@ -72,6 +72,7 @@
>>> REL_MYDIR=`dirname $0`
>>> MYDIR=`cd $REL_MYDIR && pwd`
>>> 
>>> +#
>>> # Look whether the user wants to run inside gdb
>>> case "$1" in
>>>     -gdb)
>>> @@ -95,16 +96,14 @@
>>> 
>>> -- Chris
>>> 
>>>> Thanks,
>>>> Vladimir
>>>> 
>>>> 
>>>> On 5/6/13 9:35 AM, Christian Thalinger wrote:
>>>>> Last warning!  If nobody speaks up today I'm going to push this later:
>>>>> 
>>>>> http://cr.openjdk.java.net/~twisti/8008772/
>>>>> 
>>>>> -- Chris
>>>>> 
>>>>> On May 2, 2013, at 5:28 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>>>> 
>>>>>> On May 2, 2013, at 5:25 PM, John Rose <john.r.rose at oracle.com> wrote:
>>>>>> 
>>>>>>> On May 2, 2013, at 4:44 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>>>>>> 
>>>>>>>> is anyone using env.{sh,csh}?
>>>>>>> I'll suggest that the answer is going to be "no".  I think very few people have ever used them.  ? John
>>>>>> I think you're right.  Let's remove them with this change then.
>>>>>> 
>>>>>> -- Chris
> 


From dmitry.samersoff at oracle.com  Mon May  6 13:44:05 2013
From: dmitry.samersoff at oracle.com (Dmitry Samersoff)
Date: Tue, 07 May 2013 00:44:05 +0400
Subject: RR(S): 8009062 poor performance of JNI AttachCurrentThread after
	fix for 7017193
In-Reply-To: <5178114A.4030901@redhat.com>
References: <512CF7D5.2030300@redhat.com> <512D2B73.4060103@oracle.com>
	<loom.20130301T152924-79@post.gmane.org>
	<5130D0AB.8000001@oracle.com> <513780C0.9050103@redhat.com>
	<513E1210.4030406@oracle.com> <515493D5.7090308@redhat.com>
	<5175AEA2.2050408@oracle.com> <5178114A.4030901@redhat.com>
Message-ID: <51881615.3050906@oracle.com>

Adam,

Thank you very much for your efforts and patience.

I did intensive testing so please, read below.

On 2013-04-24 21:07, Adam Domurad wrote:
> On 04/22/2013 05:41 PM, Dmitry Samersoff wrote:
>> Hi Everybody,
> 
> Thanks for tackling this.
> 
>>
>> Here is webrev of proposed changes:
>>
>> http://cr.openjdk.java.net/~dsamersoff/8009062/webrev.04/
>>
>> Any comments is much appreciated.
>>
>> The problem:
>>
>> Under Linux stack of main thread is growable, so we have to make sure
>> that address we plan to put a guard pages to and below is not mapped.
>>
>> Historically we find bounds of the stack of main thread by seeking
>> /proc/self/maps for "[stack]" and parsing this line.
>>
>> I don't like buffered reading of /proc files and sometimes ago rewrite
>> this function to read it byte-to-byte. Unfortunately, resulting
>> performance penalties is not acceptable.
> 
> I'm afraid I don't follow. What did you not like about the buffered
> reading ?

If one thread changes a process mapping and another thread reads
/proc/self/maps at the same time we end up reading incorrect value.

(I was able to reproduce it with artificial testcase with stdio based
code and probably your patch is affected as well).

I'm not sure whether it possible in reality or not - artificial testcase
changes protection of top page of the stack - and I understand that it's
not a frequent condition.

But if something like this happens on customer side they comes back with
irregular crash that is very hard to debug. So it's better safe than sorry.

>  From my performance measurements this patch is slower (not
> significantly, but around 30%).
> What are your performance measurements like between get_stack_bounds_ex
> & get_stack_bounds (from this patch) ? Is there any worst-case behaviour
> that you fear from the original patch ?

My performance measurement shows about 20% slowdown to stdio based code
and about 4% slowdown to your patch.

Time taken MC 3998        tot: 83.8300 s avg: 20967.9840 clk
Time taken EX(stdio) 3998 tot: 66.9900 s avg: 16755.8779 clk

Time taken MC 3158        tot: 65.9700 s avg: 20889.8037 clk
Time taken EX(Adam) 3158  tot: 63.9000 s avg: 20234.3255 clk

So according to all above I would prefer to go ahead with mincore
based solution.

-Dmitry

>> Solution:
>>
>> Below is slightly different approach - I use mincore(2) to check whether
>> the page is mapped or not. Typically mincore(2) is used to check whether
>> the page is resides in physical memory or not, but this function returns
>> -1 and set errno to ENOMEM if a region we are asking about contains not
>> mapped memory.
>>
>> Testing:
>>
>> Passed jprt and couple of jtreg tests. No special regression test
>> necessary as the test for 6929067 covers this case as well.
>>
>> -Dmitry
>>
>>
> 
> Overall approach looks sounds,;I have not done thorough testing but I
> did check the assert and everything is fine here.
> Libreoffice performance with the E-Porto plugin (against which a bug was
> filed) looks to be acceptable now (there is little doubt of the change -
> the pause time was *very* noticeable before).
> 
> Thanks again,
> -Adam


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer

From christian.thalinger at oracle.com  Mon May  6 14:26:40 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Mon, 6 May 2013 14:26:40 -0700
Subject: RFR (M): 8008772: remove gamma launcher
In-Reply-To: <5187E9B1.8070707@oracle.com>
References: <5C64AF5E-EDD5-4669-9777-5FF7CE6E615F@oracle.com>	<51759F6B.7080808@oracle.com>	<764DA08E-5A58-4FD4-BB48-0F4F13401BCC@oracle.com>	<51764FDE.2090205@oracle.com>
	<517669A6.8030705@oracle.com>	<5176CD8E.5060704@oracle.com>	<1897490C-0C9E-4E70-BA70-22C5CB1CDAE3@oracle.com>	<5176D417.3040202@oracle.com>
	<51817DED.2050603@oracle.com> <51818766.20604@oracle.com>
	<00d901ce46b3$28037a90$780a6fb0$@tornqvist@oracle.com>
	<51818E47.1050605@oracle.com>
	<96D28554-AC5A-40EA-A763-ABC554D650DC@oracle.com>
	<9626A9E3-7FE7-49AA-80B2-ACA6BC01EFD1@oracle.com>
	<47BCCD49-D0D9-45C2-9DC8-9A96F1094F35@oracle.com>
	<920F24B7-3D5C-4170-8BAC-1E3D88AAEBE9@oracle.com>
	<7AC60D13-DEFF-41F0-9511-E19882879965@oracle.com>
	<5187DF48.5070206@oracle.com>
	<86D5AC97-5DE8-4E96-9B56-F7F75066302E@oracle.com>
	<5187E9B1.8070707@oracle.com>
Message-ID: <A24B3944-B481-4B58-A707-F9F0FF6E7042@oracle.com>


On May 6, 2013, at 10:34 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

> I see, you also modified it. Okay I agree with changes.

FTR:

diff --git a/src/os/posix/launcher/launcher.script b/make/hotspot.script
copy from src/os/posix/launcher/launcher.script
copy to make/hotspot.script
--- a/src/os/posix/launcher/launcher.script
+++ b/make/hotspot.script
@@ -72,6 +72,7 @@
 REL_MYDIR=`dirname $0`
 MYDIR=`cd $REL_MYDIR && pwd`
 
+#
 # Look whether the user wants to run inside gdb
 case "$1" in
     -gdb)
@@ -95,16 +96,14 @@
         ;;
 esac
 
-JDK=
-if [ "${ALT_JAVA_HOME}" = "" ]; then
-    . ${MYDIR}/jdkpath.sh
+if [ "${ALT_JAVA_HOME}" != "" ]; then
+    JDK=${ALT_JAVA_HOME%%/jre}
 else
-    JDK=${ALT_JAVA_HOME%%/jre};
+    JDK=@@JDK_IMPORT_PATH@@
 fi
 
 if [ "${JDK}" = "" ]; then
-    echo Failed to find JDK. ALT_JAVA_HOME is not set or ./jdkpath.sh is empty or not found.
-    exit 1
+    echo "Failed to find JDK.  Either ALT_JAVA_HOME is not set or JDK_IMPORT_PATH is empty."
 fi
 
 # We will set the LD_LIBRARY_PATH as follows:
@@ -142,12 +141,12 @@
     export LD_LIBRARY_PATH
 fi
 
-JPARMS="$@ $JAVA_ARGS";
+JPARMS="-Dsun.java.launcher=gamma -XXaltjvm=$MYDIR $@ $JAVA_ARGS";
 
-# Locate the gamma development launcher
-LAUNCHER=${MYDIR}/gamma
+# Locate the java launcher
+LAUNCHER=$JDK/bin/java
 if [ ! -x $LAUNCHER ] ; then
-    echo Error: Cannot find the gamma development launcher \"$LAUNCHER\"
+    echo Error: Cannot find the java launcher \"$LAUNCHER\"
     exit 1
 fi
 
@@ -166,9 +165,10 @@
 file $LAUNCHER
 directory $GDBSRCDIR
 # Get us to a point where we can set breakpoints in libjvm.so
-break InitializeJVM
+set breakpoint pending on
+break JNI_CreateJavaVM
 run
-# Stop in InitializeJVM
+# Stop in JNI_CreateJavaVM
 delete 1
 # We can now set breakpoints wherever we like
 EOF
@@ -199,7 +199,7 @@
 	rm -f $GDBSCR
         ;;
     dbx)
-        $DBX -s $HOME/.dbxrc $LAUNCHER $JPARMS
+        $DBX -s $HOME/.dbxrc -c "loadobject -load libjvm.so; stop in JNI_CreateJavaVM; run $JPARMS; delete all" $LAUNCHER
         ;;
     valgrind)
         echo Warning: Defaulting to 16Mb heap to make Valgrind run faster, use -Xmx for larger heap

> 
> Thanks
> Vladimir
> 
> On 5/6/13 10:20 AM, Christian Thalinger wrote:
>> 
>> On May 6, 2013, at 9:50 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>> 
>>> Did you use 'hg rename' to move hotspot.script? We need to preserve history.
>> 
>> hg move, yes.  An hg diff on my machine shows a diff:
>> 
>> cthaling at macbook:~/ws/8008772$ hg di make/hotspot.script
>> diff --git a/src/os/posix/launcher/launcher.script b/make/hotspot.script
>> copy from src/os/posix/launcher/launcher.script
>> copy to make/hotspot.script
>> --- a/src/os/posix/launcher/launcher.script
>> +++ b/make/hotspot.script
>> @@ -72,6 +72,7 @@
>>  REL_MYDIR=`dirname $0`
>>  MYDIR=`cd $REL_MYDIR && pwd`
>> 
>> +#
>>  # Look whether the user wants to run inside gdb
>>  case "$1" in
>>      -gdb)
>> @@ -95,16 +96,14 @@
>> 
>> -- Chris
>> 
>>> 
>>> Thanks,
>>> Vladimir
>>> 
>>> 
>>> On 5/6/13 9:35 AM, Christian Thalinger wrote:
>>>> Last warning!  If nobody speaks up today I'm going to push this later:
>>>> 
>>>> http://cr.openjdk.java.net/~twisti/8008772/
>>>> 
>>>> -- Chris
>>>> 
>>>> On May 2, 2013, at 5:28 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>>> 
>>>>> 
>>>>> On May 2, 2013, at 5:25 PM, John Rose <john.r.rose at oracle.com> wrote:
>>>>> 
>>>>>> On May 2, 2013, at 4:44 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>>>>> 
>>>>>>> is anyone using env.{sh,csh}?
>>>>>> 
>>>>>> I'll suggest that the answer is going to be "no".  I think very few people have ever used them.  ? John
>>>>> 
>>>>> I think you're right.  Let's remove them with this change then.
>>>>> 
>>>>> -- Chris
>>>> 
>> 


From john.cuthbertson at oracle.com  Mon May  6 18:32:28 2013
From: john.cuthbertson at oracle.com (john.cuthbertson at oracle.com)
Date: Tue, 07 May 2013 01:32:28 +0000
Subject: hg: hsx/hsx24/hotspot: 2 new changesets
Message-ID: <20130507013234.C6D5648858@hg.openjdk.java.net>

Changeset: d6242467ff21
Author:    johnc
Date:      2013-05-06 10:29 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/d6242467ff21

8005032: G1: Cleanup serial reference processing closures in concurrent marking
Summary: Reuse the parallel reference processing oop closures during serial reference processing.
Reviewed-by: brutisso, tschatzl

! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/concurrentMark.hpp

Changeset: 627cf9e9ea31
Author:    johnc
Date:      2013-05-06 10:29 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/627cf9e9ea31

8009536: G1: Apache Lucene hang during reference processing
Summary: In CMTask::do_marking_step(), Skip offering termination and entering the first and second synchronization barriers if called from a serial context, i.e. the VM thread.
Reviewed-by: brutisso, tschatzl

! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/concurrentMark.hpp


From david.holmes at oracle.com  Mon May  6 19:53:53 2013
From: david.holmes at oracle.com (David Holmes)
Date: Tue, 07 May 2013 12:53:53 +1000
Subject: Always enforce ACC_SUPER
In-Reply-To: <51836E55.1030902@redhat.com>
References: <4FB5FEFA.5010509@redhat.com> <51836E55.1030902@redhat.com>
Message-ID: <51886CC1.6030504@oracle.com>

On 3/05/2013 5:59 PM, Florian Weimer wrote:
> On 05/18/2012 09:49 AM, Florian Weimer wrote:
>> It has been observed that the easy way of creating non-cloneable classes
>> does not work because classes can opt out of the ACC_SUPER handling:
>>
>> <http://mail.openjdk.java.net/pipermail/core-libs-dev/2010-August/004742.html>
>>
>>
>>
>> I don't think this is desirable, so I propose a patch to treat all
>> classes as if they have ACC_SUPER set.  A new product flag is
>> introduced, ForceAccSuper, which defaults to true.  Disabling it
>> preserves the old behavior.  I think that assuming the presence of
>> ACC_SUPER rather than rejecting classes without it completely is safer
>> because non-javac bytecode generators might forget to set ACC_SUPER.
>>
>> The patch is against the Hotspot in OpenJDK 7u4, but it should apply to
>> other versions as well.  It has been tested only lightly (on 7u4 and 8).
>
> It seems that a variant of this patch made its way into jdk7u recently:
> <http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/db7028c8a953>

Yes it was part of the latest CPU release.

David



From adomurad at redhat.com  Tue May  7 07:27:03 2013
From: adomurad at redhat.com (Adam Domurad)
Date: Tue, 07 May 2013 10:27:03 -0400
Subject: RR(S): 8009062 poor performance of JNI AttachCurrentThread after
	fix for 7017193
In-Reply-To: <51881615.3050906@oracle.com>
References: <512CF7D5.2030300@redhat.com> <512D2B73.4060103@oracle.com>
	<loom.20130301T152924-79@post.gmane.org>
	<5130D0AB.8000001@oracle.com> <513780C0.9050103@redhat.com>
	<513E1210.4030406@oracle.com> <515493D5.7090308@redhat.com>
	<5175AEA2.2050408@oracle.com> <5178114A.4030901@redhat.com>
	<51881615.3050906@oracle.com>
Message-ID: <51890F37.9020500@redhat.com>

On 05/06/2013 04:44 PM, Dmitry Samersoff wrote:
> Adam,
>
> Thank you very much for your efforts and patience.
>
> I did intensive testing so please, read below.

Sorry if I implied otherwise. Thanks for the deep look.

> On 2013-04-24 21:07, Adam Domurad wrote:
>> On 04/22/2013 05:41 PM, Dmitry Samersoff wrote:
>>> Hi Everybody,
>> Thanks for tackling this.
>>
>>> Here is webrev of proposed changes:
>>>
>>> http://cr.openjdk.java.net/~dsamersoff/8009062/webrev.04/
>>>
>>> Any comments is much appreciated.
>>>
>>> The problem:
>>>
>>> Under Linux stack of main thread is growable, so we have to make sure
>>> that address we plan to put a guard pages to and below is not mapped.
>>>
>>> Historically we find bounds of the stack of main thread by seeking
>>> /proc/self/maps for "[stack]" and parsing this line.
>>>
>>> I don't like buffered reading of /proc files and sometimes ago rewrite
>>> this function to read it byte-to-byte. Unfortunately, resulting
>>> performance penalties is not acceptable.
>> I'm afraid I don't follow. What did you not like about the buffered
>> reading ?
> If one thread changes a process mapping and another thread reads
> /proc/self/maps at the same time we end up reading incorrect value.
>
> (I was able to reproduce it with artificial testcase with stdio based
> code and probably your patch is affected as well).
>
> I'm not sure whether it possible in reality or not - artificial testcase
> changes protection of top page of the stack - and I understand that it's
> not a frequent condition.
>
> But if something like this happens on customer side they comes back with
> irregular crash that is very hard to debug. So it's better safe than sorry.

Sounds reasonable to me.

>
>>   From my performance measurements this patch is slower (not
>> significantly, but around 30%).
>> What are your performance measurements like between get_stack_bounds_ex
>> & get_stack_bounds (from this patch) ? Is there any worst-case behaviour
>> that you fear from the original patch ?
> My performance measurement shows about 20% slowdown to stdio based code
> and about 4% slowdown to your patch.
>
> Time taken MC 3998        tot: 83.8300 s avg: 20967.9840 clk
> Time taken EX(stdio) 3998 tot: 66.9900 s avg: 16755.8779 clk
>
> Time taken MC 3158        tot: 65.9700 s avg: 20889.8037 clk
> Time taken EX(Adam) 3158  tot: 63.9000 s avg: 20234.3255 clk
>
> So according to all above I would prefer to go ahead with mincore
> based solution.

Thanks for your numbers, and yes I think 20% slower is acceptable. The 
pause in LibreOffice was not noticable.
Looks good from my end.

> -Dmitry

Thanks,
-Adam


From erik.helin at oracle.com  Tue May  7 08:13:06 2013
From: erik.helin at oracle.com (erik.helin at oracle.com)
Date: Tue, 07 May 2013 15:13:06 +0000
Subject: hg: hsx/hsx24/hotspot: 8011425: NPE in
	TestObjectCountAfterGCEvent.java on Linux32
Message-ID: <20130507151308.BE1954887B@hg.openjdk.java.net>

Changeset: 0ba44b7d8f02
Author:    ehelin
Date:      2013-05-07 11:58 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/0ba44b7d8f02

8011425: NPE in TestObjectCountAfterGCEvent.java on Linux32
Reviewed-by: stefank, brutisso

! src/share/vm/gc_implementation/shared/gcTrace.cpp


From zhengyu.gu at oracle.com  Tue May  7 11:09:49 2013
From: zhengyu.gu at oracle.com (zhengyu.gu at oracle.com)
Date: Tue, 07 May 2013 18:09:49 +0000
Subject: hg: hsx/hsx24/hotspot: 4 new changesets
Message-ID: <20130507180959.A7D894888F@hg.openjdk.java.net>

Changeset: 0682fce0ecfb
Author:    zgu
Date:      2013-05-06 15:25 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/0682fce0ecfb

8011218: Kitchensink hanged, likely NMT is to blame
Summary: Made NMT query safepoint aware.
Reviewed-by: dholmes, coleenp

! src/share/vm/services/memBaseline.cpp
! src/share/vm/services/memBaseline.hpp
! src/share/vm/services/memTracker.cpp

Changeset: 7641cf42feb0
Author:    zgu
Date:      2013-05-07 10:38 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/7641cf42feb0

8013214: BigApps fails due to 'fatal error: Illegal threadstate encountered: 6'
Summary: Grab and drop SR_lock to get the thread to honor the safepoint protocol
Reviewed-by: dcubed, coleenp

! src/share/vm/services/memBaseline.cpp

Changeset: 127c4f0798b4
Author:    zgu
Date:      2013-05-07 08:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/127c4f0798b4

Merge


Changeset: 0d3d60dfa1ab
Author:    zgu
Date:      2013-05-07 08:16 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/0d3d60dfa1ab

Merge



From john.cuthbertson at oracle.com  Tue May  7 15:44:29 2013
From: john.cuthbertson at oracle.com (john.cuthbertson at oracle.com)
Date: Tue, 07 May 2013 22:44:29 +0000
Subject: hg: hsx/hsx24/hotspot: 4 new changesets
Message-ID: <20130507224440.406AD488B1@hg.openjdk.java.net>

Changeset: ea5503c5095e
Author:    johnc
Date:      2013-03-19 00:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/ea5503c5095e

8009940: G1: assert(_finger == _heap_end) failed, concurrentMark.cpp:809
Summary: Skip reference processing if the global marking stack overflows during remark. Refactor and rename set_phase(); move code that sets the concurrency level into its own routine. Do not call set_phase() from within parallel reference processing; use the concurrency level routine instead. The marking state should only set reset by CMTask[0] during the concurrent phase of the marking cycle; if an overflow occurs at any stage during the remark, the marking state will be reset after reference processing.
Reviewed-by: brutisso, jmasa, tschatzl

! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/concurrentMark.hpp

Changeset: 76599c6f6f43
Author:    johnc
Date:      2013-03-19 09:38 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/76599c6f6f43

8008301: G1: guarantee(satb_mq_set.completed_buffers_num() == 0) failure
Summary: If the marking stack overflows while the marking tasks are draining the SATB buffers, remark will exit with some SATB buffers left unprocessed. Relax the guarantee to allow for overflow.
Reviewed-by: jmasa, brutisso

! src/share/vm/gc_implementation/g1/concurrentMark.cpp

Changeset: 44247af929fb
Author:    johnc
Date:      2013-03-29 13:49 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/44247af929fb

8010463: G1: Crashes with -UseTLAB and heap verification
Summary: Some parts of the G1 heap can only be walked during a safepoint. Skip verifying these parts of the heap when verifying during JVM startup.
Reviewed-by: brutisso, tschatzl

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/memory/universe.cpp
! src/share/vm/runtime/init.cpp
! src/share/vm/runtime/thread.cpp
+ test/gc/TestVerifyBeforeGCDuringStartup.java

Changeset: c375b802ab3d
Author:    johnc
Date:      2013-05-07 12:23 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/c375b802ab3d

Merge



From david.holmes at oracle.com  Tue May  7 18:18:10 2013
From: david.holmes at oracle.com (David Holmes)
Date: Wed, 08 May 2013 11:18:10 +1000
Subject: RR(S): 8009062 poor performance of JNI AttachCurrentThread after
	fix for 7017193
In-Reply-To: <5175AEA2.2050408@oracle.com>
References: <512CF7D5.2030300@redhat.com> <512D2B73.4060103@oracle.com>
	<loom.20130301T152924-79@post.gmane.org>
	<5130D0AB.8000001@oracle.com> <513780C0.9050103@redhat.com>
	<513E1210.4030406@oracle.com> <515493D5.7090308@redhat.com>
	<5175AEA2.2050408@oracle.com>
Message-ID: <5189A7D2.1090805@oracle.com>

Hi Dmitry,

First a few minor cleanups:

- use spaces around all operators ie imax = imid; not imax=imid; etc
- don't use %p use appropriate *FORMAT macro
- don't leave commented out tty->print (either delete or guard with a 
trace/debug flag or Verbose flag)

---

os_linux.cpp:

I'm not sure about the "#ifdef DEBUG_STACK_GUARD_PAGES". Do we need to 
keep this code? If so should it just be non-product?

I don't understand this guarantee:

2930     } else{
2931            guarantee(res == false, "growable stack in non-initial 
thread");
2932     }

What in the previous code indicates this is a growable stack?


2961   bool chk_bounds = os::Linux::is_initial_thread();
2962   if (chk_bounds) {

We don't need the chk_bounds local any more.

If I'm reading things right get_stack_bounds is only called for the 
initial thread, but you then call pthread_getattr_np  but that isn't 
valid as stated elsewhere:

1124 // Locate initial thread stack. This special handling of initial 
thread stack
1125 // is needed because pthread_getattr_np() on most (all?) Linux 
distros returns
1126 // bogus value for initial thread.

??? So how is this working?

Also you should save the return values of the pthread_* functions and 
use assert_state to check them for errors. (Yes I know this is handled 
very inconsistently through the code but we should be moving towards 
full error checking.)

Overall I'm unclear about the detailed logic being applied here (in both 
old code and new!).

Thanks,
David
-----

On 23/04/2013 7:41 AM, Dmitry Samersoff wrote:
> Hi Everybody,
>
> Here is webrev of proposed changes:
>
> http://cr.openjdk.java.net/~dsamersoff/8009062/webrev.04/
>
> Any comments is much appreciated.
>
> The problem:
>
> Under Linux stack of main thread is growable, so we have to make sure
> that address we plan to put a guard pages to and below is not mapped.
>
> Historically we find bounds of the stack of main thread by seeking
> /proc/self/maps for "[stack]" and parsing this line.
>
> I don't like buffered reading of /proc files and sometimes ago rewrite
> this function to read it byte-to-byte. Unfortunately, resulting
> performance penalties is not acceptable.
>
>
> Solution:
>
> Below is slightly different approach - I use mincore(2) to check whether
> the page is mapped or not. Typically mincore(2) is used to check whether
> the page is resides in physical memory or not, but this function returns
> -1 and set errno to ENOMEM if a region we are asking about contains not
> mapped memory.
>
> Testing:
>
> Passed jprt and couple of jtreg tests. No special regression test
> necessary as the test for 6929067 covers this case as well.
>
> -Dmitry
>
>
>
> On 2013-03-28 23:02, Adam Domurad wrote:
>> On 03/11/2013 01:19 PM, Dmitry Samersoff wrote:
>>> Adam,
>>>
>>> Sorry! I can't provide any estimations right now. But it's a high
>>> priority issue in my queue, and I plan to provide a fix as soon as it
>>> become possible.
>>>
>>> -Dmitry
>>>
>>> On 2013-03-06 21:45, Adam Domurad wrote:
>>>> On 03/01/2013 11:00 AM, Dmitry Samersoff wrote:
>>>>> Adam,
>>>>>
>>>>> Thank you for advice! I'm looking for a possibility to remove
>>>>> get_stack_bounds function entirely as Dean suggested. But it takes some
>>>>> time.
>>>> Hi again, not to be a bother, but do you have a rough time-frame that
>>>> the fix will take?
>>>>
>>>> Thanks,
>>>> -Adam
>>>
>>
>> As per our off-list chat, I have attached my implementation of a revised
>> implementation of get_stack_bounds with a small test-case. As far as
>> performance is concerned, it's an order of magnitude faster from my
>> timings. This should be suitable given that no problems were reported
>> with the old implementation.
>>
>> Happy hacking,
>> -Adam
>
>

From john.cuthbertson at oracle.com  Tue May  7 21:50:20 2013
From: john.cuthbertson at oracle.com (john.cuthbertson at oracle.com)
Date: Wed, 08 May 2013 04:50:20 +0000
Subject: hg: hsx/hsx24/hotspot: 3 new changesets
Message-ID: <20130508045028.8CF34488C2@hg.openjdk.java.net>

Changeset: 38f92c5bc54d
Author:    johnc
Date:      2013-04-10 10:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/38f92c5bc54d

8010780: G1: Eden occupancy/capacity output wrong after a full GC
Summary: Move the calculation and recording of eden capacity to the start of a GC and print a detailed heap transition for full GCs.
Reviewed-by: tschatzl, jmasa, brutisso

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp

Changeset: 7ba81e455f0f
Author:    johnc
Date:      2013-04-17 10:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/7ba81e455f0f

8012335: G1: Fix bug with compressed oops in template interpreter on x86 and sparc.
Summary: In do_oop_store the uncompressed value of the oop being stored needs to be preserved and passed to g1_write_barrier_post. This is necessary for the heap region cross check to work correctly.
Reviewed-by: coleenp, johnc
Contributed-by: Martin Doerr <martin.doerr at sap.com>

! src/cpu/sparc/vm/templateTable_sparc.cpp
! src/cpu/x86/vm/templateTable_x86_64.cpp

Changeset: 8e59680f4573
Author:    johnc
Date:      2013-04-24 14:48 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/8e59680f4573

8012715: G1: GraphKit accesses PtrQueue::_index as int but is size_t
Summary: In graphKit INT operations were generated to access PtrQueue::_index which has type size_t. This is 64 bit on 64-bit machines. No problems occur on little endian machines as long as the index fits into 32 bit, but on big endian machines the upper part is read, which is zero. This leads to unnecessary branches to the slow path in the runtime.
Reviewed-by: twisti, johnc
Contributed-by: Martin Doerr <martin.doerr at sap.com>

! src/share/vm/opto/graphKit.cpp


From staffan.larsen at oracle.com  Wed May  8 01:17:06 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Wed, 8 May 2013 10:17:06 +0200
Subject: RFR(S): 8013591 compiler/ciReplay/TestSA.sh fails in nightly
Message-ID: <5DD5C851-4E13-4815-8138-F291AF685419@oracle.com>

When JDK-8010862 (Method counter fields used for profiling can be allocated lazily) was fixed, SA was not updated to reflect this change. 

The problem is with Method.getInvocationCounter() and Method.getBackedgeCounter() which do not handle the case where MethodCounters are not allocated.

The fix is to check for null and return 0 as the counter value.

webrev: http://cr.openjdk.java.net/~sla/8013591/webrev.00/
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013591

Thanks,
/Staffan

From david.holmes at oracle.com  Wed May  8 01:46:49 2013
From: david.holmes at oracle.com (David Holmes)
Date: Wed, 08 May 2013 18:46:49 +1000
Subject: RFR(S): 8013591 compiler/ciReplay/TestSA.sh fails in nightly
In-Reply-To: <5DD5C851-4E13-4815-8138-F291AF685419@oracle.com>
References: <5DD5C851-4E13-4815-8138-F291AF685419@oracle.com>
Message-ID: <518A10F9.9020103@oracle.com>

Looks good to me Staffan!

(Those methods should have been called getXXXCount not Counter though :( )

David

On 8/05/2013 6:17 PM, Staffan Larsen wrote:
> When JDK-8010862 (Method counter fields used for profiling can be allocated lazily) was fixed, SA was not updated to reflect this change.
>
> The problem is with Method.getInvocationCounter() and Method.getBackedgeCounter() which do not handle the case where MethodCounters are not allocated.
>
> The fix is to check for null and return 0 as the counter value.
>
> webrev: http://cr.openjdk.java.net/~sla/8013591/webrev.00/
> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013591
>
> Thanks,
> /Staffan
>

From staffan.larsen at oracle.com  Wed May  8 01:58:13 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Wed, 8 May 2013 10:58:13 +0200
Subject: RFR(S): 8013591 compiler/ciReplay/TestSA.sh fails in nightly
In-Reply-To: <518A10F9.9020103@oracle.com>
References: <5DD5C851-4E13-4815-8138-F291AF685419@oracle.com>
	<518A10F9.9020103@oracle.com>
Message-ID: <FD6A2329-C10B-4909-8A70-0EB5ADF3D26F@oracle.com>


On 8 maj 2013, at 10:46, David Holmes <David.Holmes at oracle.com> wrote:

> Looks good to me Staffan!

Thanks.

> (Those methods should have been called getXXXCount not Counter though :( )

We can fix that at the same time: http://cr.openjdk.java.net/~sla/8013591/webrev.01/

/Staffan

> 
> David
> 
> On 8/05/2013 6:17 PM, Staffan Larsen wrote:
>> When JDK-8010862 (Method counter fields used for profiling can be allocated lazily) was fixed, SA was not updated to reflect this change.
>> 
>> The problem is with Method.getInvocationCounter() and Method.getBackedgeCounter() which do not handle the case where MethodCounters are not allocated.
>> 
>> The fix is to check for null and return 0 as the counter value.
>> 
>> webrev: http://cr.openjdk.java.net/~sla/8013591/webrev.00/
>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013591
>> 
>> Thanks,
>> /Staffan
>> 


From rickard.backman at oracle.com  Wed May  8 03:37:53 2013
From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=)
Date: Wed, 8 May 2013 12:37:53 +0200
Subject: RFR(S): 8013591 compiler/ciReplay/TestSA.sh fails in nightly
In-Reply-To: <FD6A2329-C10B-4909-8A70-0EB5ADF3D26F@oracle.com>
References: <5DD5C851-4E13-4815-8138-F291AF685419@oracle.com>
	<518A10F9.9020103@oracle.com>
	<FD6A2329-C10B-4909-8A70-0EB5ADF3D26F@oracle.com>
Message-ID: <F66874DA-1788-4B0F-B176-EF20E838A46C@oracle.com>

Looks good!

/R

On May 8, 2013, at 10:58 AM, Staffan Larsen wrote:

> 
> On 8 maj 2013, at 10:46, David Holmes <David.Holmes at oracle.com> wrote:
> 
>> Looks good to me Staffan!
> 
> Thanks.
> 
>> (Those methods should have been called getXXXCount not Counter though :( )
> 
> We can fix that at the same time: http://cr.openjdk.java.net/~sla/8013591/webrev.01/
> 
> /Staffan
> 
>> 
>> David
>> 
>> On 8/05/2013 6:17 PM, Staffan Larsen wrote:
>>> When JDK-8010862 (Method counter fields used for profiling can be allocated lazily) was fixed, SA was not updated to reflect this change.
>>> 
>>> The problem is with Method.getInvocationCounter() and Method.getBackedgeCounter() which do not handle the case where MethodCounters are not allocated.
>>> 
>>> The fix is to check for null and return 0 as the counter value.
>>> 
>>> webrev: http://cr.openjdk.java.net/~sla/8013591/webrev.00/
>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013591
>>> 
>>> Thanks,
>>> /Staffan
>>> 
> 


From coleen.phillimore at oracle.com  Wed May  8 04:50:32 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Wed, 08 May 2013 07:50:32 -0400
Subject: RFR(S): 8013591 compiler/ciReplay/TestSA.sh fails in nightly
In-Reply-To: <5DD5C851-4E13-4815-8138-F291AF685419@oracle.com>
References: <5DD5C851-4E13-4815-8138-F291AF685419@oracle.com>
Message-ID: <518A3C08.3040903@oracle.com>


This looks fine.   What tests did you run to find this bug?   I think 
Jiangli ran the sajdi and probably tmtools tests and the previous 
changes looked good to me.   They passed nightly which also should have 
exercised this code.   Can we add a test somewhere since the SA insists 
on bit-rotting with everything we touch?

thanks,
Coleen

On 5/8/2013 4:17 AM, Staffan Larsen wrote:
> When JDK-8010862 (Method counter fields used for profiling can be allocated lazily) was fixed, SA was not updated to reflect this change.
>
> The problem is with Method.getInvocationCounter() and Method.getBackedgeCounter() which do not handle the case where MethodCounters are not allocated.
>
> The fix is to check for null and return 0 as the counter value.
>
> webrev: http://cr.openjdk.java.net/~sla/8013591/webrev.00/
> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013591
>
> Thanks,
> /Staffan


From staffan.larsen at oracle.com  Wed May  8 05:20:39 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Wed, 8 May 2013 14:20:39 +0200
Subject: RFR(S): 8013591 compiler/ciReplay/TestSA.sh fails in nightly
In-Reply-To: <518A3C08.3040903@oracle.com>
References: <5DD5C851-4E13-4815-8138-F291AF685419@oracle.com>
	<518A3C08.3040903@oracle.com>
Message-ID: <653F1900-2EE6-4DA3-B189-7D9C396F47D5@oracle.com>


On 8 maj 2013, at 13:50, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:

> 
> This looks fine.   What tests did you run to find this bug?   I think Jiangli ran the sajdi and probably tmtools tests and the previous changes looked good to me.   They passed nightly which also should have exercised this code.   Can we add a test somewhere since the SA insists on bit-rotting with everything we touch?

The test name is in the subject. It is part of the hotspot jtreg suite, but added relatively recently: 2013-04-25. Jiangli's changes were made on 2013-04-10. It's possible that this is the first sighting of running with these two changes together.

/Staffan

> 
> thanks,
> Coleen
> 
> On 5/8/2013 4:17 AM, Staffan Larsen wrote:
>> When JDK-8010862 (Method counter fields used for profiling can be allocated lazily) was fixed, SA was not updated to reflect this change.
>> 
>> The problem is with Method.getInvocationCounter() and Method.getBackedgeCounter() which do not handle the case where MethodCounters are not allocated.
>> 
>> The fix is to check for null and return 0 as the counter value.
>> 
>> webrev: http://cr.openjdk.java.net/~sla/8013591/webrev.00/
>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013591
>> 
>> Thanks,
>> /Staffan
> 


From coleen.phillimore at oracle.com  Wed May  8 05:57:05 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Wed, 08 May 2013 08:57:05 -0400
Subject: RFR(S): 8013591 compiler/ciReplay/TestSA.sh fails in nightly
In-Reply-To: <653F1900-2EE6-4DA3-B189-7D9C396F47D5@oracle.com>
References: <5DD5C851-4E13-4815-8138-F291AF685419@oracle.com>
	<518A3C08.3040903@oracle.com>
	<653F1900-2EE6-4DA3-B189-7D9C396F47D5@oracle.com>
Message-ID: <518A4BA1.3030407@oracle.com>

On 5/8/2013 8:20 AM, Staffan Larsen wrote:
> On 8 maj 2013, at 13:50, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
>
>> This looks fine.   What tests did you run to find this bug?   I think Jiangli ran the sajdi and probably tmtools tests and the previous changes looked good to me.   They passed nightly which also should have exercised this code.   Can we add a test somewhere since the SA insists on bit-rotting with everything we touch?
> The test name is in the subject. It is part of the hotspot jtreg suite, but added relatively recently: 2013-04-25. Jiangli's changes were made on 2013-04-10. It's possible that this is the first sighting of running with these two changes together.

Ok,  I didn't see it.   Thanks,
Coleen

>
> /Staffan
>
>> thanks,
>> Coleen
>>
>> On 5/8/2013 4:17 AM, Staffan Larsen wrote:
>>> When JDK-8010862 (Method counter fields used for profiling can be allocated lazily) was fixed, SA was not updated to reflect this change.
>>>
>>> The problem is with Method.getInvocationCounter() and Method.getBackedgeCounter() which do not handle the case where MethodCounters are not allocated.
>>>
>>> The fix is to check for null and return 0 as the counter value.
>>>
>>> webrev: http://cr.openjdk.java.net/~sla/8013591/webrev.00/
>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013591
>>>
>>> Thanks,
>>> /Staffan


From dmitry.samersoff at oracle.com  Wed May  8 06:27:46 2013
From: dmitry.samersoff at oracle.com (Dmitry Samersoff)
Date: Wed, 08 May 2013 17:27:46 +0400
Subject: RR(S): 8009062 poor performance of JNI AttachCurrentThread after
	fix for 7017193
In-Reply-To: <5189A7D2.1090805@oracle.com>
References: <512CF7D5.2030300@redhat.com> <512D2B73.4060103@oracle.com>
	<loom.20130301T152924-79@post.gmane.org>
	<5130D0AB.8000001@oracle.com> <513780C0.9050103@redhat.com>
	<513E1210.4030406@oracle.com> <515493D5.7090308@redhat.com>
	<5175AEA2.2050408@oracle.com> <5189A7D2.1090805@oracle.com>
Message-ID: <518A52D2.4090108@oracle.com>

David,

Thank you for detailed review:

Updated webrev is here:

http://cr.openjdk.java.net/~dsamersoff/8009062/webrev.05/

1. Formatting nits fixed (hopefully)
2. More comments added
3. Debug code is placed under #ifndef PRODUCT and cleaned up.
   I plan to remove it somewhere in the future when my
   changes bakes for some time in nightlies.


> 1124 // Locate initial thread stack. This special handling of initial
> thread stack
> 1125 // is needed because pthread_getattr_np() on most (all?) Linux
> distros returns
> 1126 // bogus value for initial thread.
>
> ??? So how is this working?

I suspect this code is not updated for a long time. e.g. modern hotspot
will not work at all if /proc is not mounted and statement about bogus
pthread_getattr_np results is not true since NPTL (i.e. 2.6 kernel)

Since we don't support 2.4 kernel anymore lots of code could be
simplified drastically.

Do you want me to cleanup this code as well?

-Dmitry


On 2013-05-08 05:18, David Holmes wrote:
> Hi Dmitry,
> 
> First a few minor cleanups:
> 
> - use spaces around all operators ie imax = imid; not imax=imid; etc
> - don't use %p use appropriate *FORMAT macro
> - don't leave commented out tty->print (either delete or guard with a
> trace/debug flag or Verbose flag)
> 
> ---
> 
> os_linux.cpp:
> 
> I'm not sure about the "#ifdef DEBUG_STACK_GUARD_PAGES". Do we need to
> keep this code? If so should it just be non-product?
> 
> I don't understand this guarantee:
> 
> 2930     } else{
> 2931            guarantee(res == false, "growable stack in non-initial
> thread");
> 2932     }
> 
> What in the previous code indicates this is a growable stack?
> 
> 
> 2961   bool chk_bounds = os::Linux::is_initial_thread();
> 2962   if (chk_bounds) {
> 
> We don't need the chk_bounds local any more.
> 
> If I'm reading things right get_stack_bounds is only called for the
> initial thread, but you then call pthread_getattr_np  but that isn't
> valid as stated elsewhere:
> 
> 1124 // Locate initial thread stack. This special handling of initial
> thread stack
> 1125 // is needed because pthread_getattr_np() on most (all?) Linux
> distros returns
> 1126 // bogus value for initial thread.
> 
> ??? So how is this working?
> 
> Also you should save the return values of the pthread_* functions and
> use assert_state to check them for errors. (Yes I know this is handled
> very inconsistently through the code but we should be moving towards
> full error checking.)
> 
> Overall I'm unclear about the detailed logic being applied here (in both
> old code and new!).
> 
> Thanks,
> David
> -----
> 
> On 23/04/2013 7:41 AM, Dmitry Samersoff wrote:
>> Hi Everybody,
>>
>> Here is webrev of proposed changes:
>>
>> http://cr.openjdk.java.net/~dsamersoff/8009062/webrev.04/
>>
>> Any comments is much appreciated.
>>
>> The problem:
>>
>> Under Linux stack of main thread is growable, so we have to make sure
>> that address we plan to put a guard pages to and below is not mapped.
>>
>> Historically we find bounds of the stack of main thread by seeking
>> /proc/self/maps for "[stack]" and parsing this line.
>>
>> I don't like buffered reading of /proc files and sometimes ago rewrite
>> this function to read it byte-to-byte. Unfortunately, resulting
>> performance penalties is not acceptable.
>>
>>
>> Solution:
>>
>> Below is slightly different approach - I use mincore(2) to check whether
>> the page is mapped or not. Typically mincore(2) is used to check whether
>> the page is resides in physical memory or not, but this function returns
>> -1 and set errno to ENOMEM if a region we are asking about contains not
>> mapped memory.
>>
>> Testing:
>>
>> Passed jprt and couple of jtreg tests. No special regression test
>> necessary as the test for 6929067 covers this case as well.
>>
>> -Dmitry
>>
>>
>>
>> On 2013-03-28 23:02, Adam Domurad wrote:
>>> On 03/11/2013 01:19 PM, Dmitry Samersoff wrote:
>>>> Adam,
>>>>
>>>> Sorry! I can't provide any estimations right now. But it's a high
>>>> priority issue in my queue, and I plan to provide a fix as soon as it
>>>> become possible.
>>>>
>>>> -Dmitry
>>>>
>>>> On 2013-03-06 21:45, Adam Domurad wrote:
>>>>> On 03/01/2013 11:00 AM, Dmitry Samersoff wrote:
>>>>>> Adam,
>>>>>>
>>>>>> Thank you for advice! I'm looking for a possibility to remove
>>>>>> get_stack_bounds function entirely as Dean suggested. But it takes
>>>>>> some
>>>>>> time.
>>>>> Hi again, not to be a bother, but do you have a rough time-frame that
>>>>> the fix will take?
>>>>>
>>>>> Thanks,
>>>>> -Adam
>>>>
>>>
>>> As per our off-list chat, I have attached my implementation of a revised
>>> implementation of get_stack_bounds with a small test-case. As far as
>>> performance is concerned, it's an order of magnitude faster from my
>>> timings. This should be suitable given that no problems were reported
>>> with the old implementation.
>>>
>>> Happy hacking,
>>> -Adam
>>
>>


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer

From rickard.backman at oracle.com  Wed May  8 08:18:34 2013
From: rickard.backman at oracle.com (rickard.backman at oracle.com)
Date: Wed, 08 May 2013 15:18:34 +0000
Subject: hg: hsx/hotspot-main/hotspot: 20 new changesets
Message-ID: <20130508151923.3716F488DC@hg.openjdk.java.net>

Changeset: c456f4510385
Author:    sla
Date:      2013-05-03 12:24 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/c456f4510385

8008453: JvmtiClassFileReconstituter does not recognize default methods
Reviewed-by: acorn, sspitsyn

! src/share/vm/prims/jvmtiClassFileReconstituter.cpp

Changeset: 0380df7c3cd0
Author:    sla
Date:      2013-05-03 12:26 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/0380df7c3cd0

8013785: Respect EXTRA_CFLAGS on windows
Reviewed-by: mgronlun, rbackman, kvn

! make/windows/makefiles/compile.make
! make/windows/makefiles/defs.make

Changeset: 31a4e55f8c9d
Author:    fparain
Date:      2013-05-03 05:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/31a4e55f8c9d

8004095: Add support for JMX interface to Diagnostic Framework and Commands
Reviewed-by: acorn, sla

! src/share/vm/classfile/vmSymbols.hpp
! src/share/vm/runtime/serviceThread.cpp
! src/share/vm/services/attachListener.cpp
! src/share/vm/services/diagnosticCommand.cpp
! src/share/vm/services/diagnosticCommand.hpp
! src/share/vm/services/diagnosticFramework.cpp
! src/share/vm/services/diagnosticFramework.hpp
! src/share/vm/services/jmm.h
! src/share/vm/services/management.cpp
! src/share/vm/services/management.hpp
! src/share/vm/services/nmtDCmd.cpp
! src/share/vm/services/nmtDCmd.hpp

Changeset: 39fba0d6d9ad
Author:    fparain
Date:      2013-05-03 05:17 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/39fba0d6d9ad

Merge


Changeset: bf089b838c9e
Author:    ccheung
Date:      2013-05-02 16:55 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/bf089b838c9e

8012641: Perf_CreateLong creates perf counter of incorrect type
Reviewed-by: mchung, hseigel, coleenp

! src/share/vm/prims/perf.cpp

Changeset: a55b7b8c34af
Author:    zgu
Date:      2013-05-03 13:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a55b7b8c34af

Merge


Changeset: 9c8e2f44228d
Author:    dcubed
Date:      2013-05-03 15:51 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/9c8e2f44228d

Merge


Changeset: 800078be49d2
Author:    hseigel
Date:      2013-05-06 09:10 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/800078be49d2

8013648: Guarantee(VerifyBeforeGC || VerifyDuringGC || VerifyBeforeExit || VerifyAfterGC) failed: too expensive
Summary: Fix code to call correct version of function find_class().
Reviewed-by: coleenp, rdurbin, dcubed

! src/share/vm/classfile/systemDictionary.cpp

Changeset: c18152e0554e
Author:    zgu
Date:      2013-05-06 11:15 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/c18152e0554e

8013120: NMT: Kitchensink crashes with assert(next_region == NULL || !next_region->is_committed_region()) failed: Sanity check
Summary: Fixed NMT to deal with releasing virtual memory region when there are still committed regions within it
Reviewed-by: acorn, coleenp

! src/share/vm/memory/allocation.inline.hpp
! src/share/vm/runtime/os.cpp
! src/share/vm/runtime/os.hpp
! src/share/vm/services/memSnapshot.cpp
+ test/runtime/NMT/ReleaseCommittedMemory.java

Changeset: da4d87770781
Author:    zgu
Date:      2013-05-06 08:49 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/da4d87770781

Merge


Changeset: d9b08d62b95e
Author:    acorn
Date:      2013-05-02 10:58 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d9b08d62b95e

8010783: assert(s->refcount() != 0) failed: for create_overpasses
Reviewed-by: kvn, dcubed

! src/share/vm/classfile/bytecodeAssembler.cpp

Changeset: b7f3bf2ba33b
Author:    acorn
Date:      2013-05-06 10:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b7f3bf2ba33b

Merge

- agent/doc/c2replay.html

Changeset: f916d5986c86
Author:    acorn
Date:      2013-05-06 12:36 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f916d5986c86

Merge


Changeset: 187154b7a226
Author:    sla
Date:      2013-05-06 19:49 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/187154b7a226

8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes
Reviewed-by: coleenp, sspitsyn

! src/share/vm/prims/jvmtiClassFileReconstituter.cpp
! src/share/vm/prims/jvmtiClassFileReconstituter.hpp

Changeset: 3ecc6b9940de
Author:    sla
Date:      2013-05-07 01:25 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/3ecc6b9940de

Merge


Changeset: b5fef8013a95
Author:    sla
Date:      2013-05-07 14:04 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b5fef8013a95

8014044: Spelling error in JDK-8009615: boostrapmethod
Reviewed-by: sspitsyn, coleenp

! src/share/vm/prims/jvmtiClassFileReconstituter.cpp
! src/share/vm/prims/jvmtiClassFileReconstituter.hpp

Changeset: f6a055fcf47d
Author:    sla
Date:      2013-05-07 14:33 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f6a055fcf47d

8005038: remove crufty '_g' support from SA
Reviewed-by: coleenp, mgronlun, rbackman

! agent/src/os/bsd/ps_core.c
! agent/src/os/linux/ps_core.c
! agent/src/os/solaris/proc/saproc.cpp
! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java
! agent/src/share/classes/sun/jvm/hotspot/LinuxVtblAccess.java
! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java
! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebuggerLocal.java

Changeset: 33bcd9ead1d5
Author:    ctornqvi
Date:      2013-05-07 21:36 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/33bcd9ead1d5

8009577: Test test/closed/runtime/classunload broken
Summary: Fixed tests to use new way of utilizing the WB API, fixed issue with where custom classloader got the classes from
Reviewed-by: collins, mgerdin, zgu

+ test/runtime/ClassUnload/KeepAliveClass.java
+ test/runtime/ClassUnload/KeepAliveClassLoader.java
+ test/runtime/ClassUnload/KeepAliveObject.java
+ test/runtime/ClassUnload/KeepAliveSoftReference.java
+ test/runtime/ClassUnload/UnloadTest.java
+ test/runtime/ClassUnload/classes/test/Empty.java
+ test/runtime/testlibrary/ClassUnloadCommon.java

Changeset: 58bb870a0cbd
Author:    emc
Date:      2013-05-07 13:45 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/58bb870a0cbd

8009729: Refix hotspot jni_<cpu>.h JNIEXPORT and JNIIMPORT definitions to match jdk version
Summary: Update JNIEXPORT and JNIIMPORT to work with other compilers that don't necessarily have the __attribute__ type qualifier
Reviewed-by: dholmes, dcubed, coleenp

! src/cpu/sparc/vm/jni_sparc.h
! src/cpu/x86/vm/jni_x86.h
! src/cpu/zero/vm/jni_zero.h

Changeset: 7243490a6847
Author:    coleenp
Date:      2013-05-07 14:30 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/7243490a6847

Merge



From david.holmes at oracle.com  Wed May  8 19:00:01 2013
From: david.holmes at oracle.com (David Holmes)
Date: Thu, 09 May 2013 12:00:01 +1000
Subject: RR(S): 8009062 poor performance of JNI AttachCurrentThread after
	fix for 7017193
In-Reply-To: <518A52D2.4090108@oracle.com>
References: <512CF7D5.2030300@redhat.com> <512D2B73.4060103@oracle.com>
	<loom.20130301T152924-79@post.gmane.org>
	<5130D0AB.8000001@oracle.com> <513780C0.9050103@redhat.com>
	<513E1210.4030406@oracle.com> <515493D5.7090308@redhat.com>
	<5175AEA2.2050408@oracle.com> <5189A7D2.1090805@oracle.com>
	<518A52D2.4090108@oracle.com>
Message-ID: <518B0321.1090209@oracle.com>

Hi Dmitry,

On 8/05/2013 11:27 PM, Dmitry Samersoff wrote:
> David,
>
> Thank you for detailed review:
>
> Updated webrev is here:
>
> http://cr.openjdk.java.net/~dsamersoff/8009062/webrev.05/
>
> 1. Formatting nits fixed (hopefully)
> 2. More comments added
> 3. Debug code is placed under #ifndef PRODUCT and cleaned up.
>     I plan to remove it somewhere in the future when my
>     changes bakes for some time in nightlies.

I haven't re-examined this yet.

>> 1124 // Locate initial thread stack. This special handling of initial
>> thread stack
>> 1125 // is needed because pthread_getattr_np() on most (all?) Linux
>> distros returns
>> 1126 // bogus value for initial thread.
>>
>> ??? So how is this working?
>
> I suspect this code is not updated for a long time. e.g. modern hotspot
> will not work at all if /proc is not mounted and statement about bogus
> pthread_getattr_np results is not true since NPTL (i.e. 2.6 kernel)

The manpage for pthread_getattr_np still states:

"In addition, if thread refers to the main thread, then 
pthread_getattr_np() can fail because of errors from various underlying 
calls: fopen(3), if /proc/self/maps can't be opened; and getrlimit(2), 
if the RLIMIT_STACK resource limit is not supported. "

so it is far from clear to me that this main thread problem no longer 
applies on 2.6 systems. The hotspot code essentially does the same as 
the pthread_getattr_np implementation but has various fallbacks if it 
encounters the above errors (they do not cause the VM to abort AFAICS).

So I don't think you can just use pthread_getattr_np for the main thread 
without having a way to handle failure. That said we already jump 
through all these hoops in os::Linux::capture_initial_stack so why 
aren't we simply using the values of

  _initial_thread_stack_size
  _initial_thread_stack_bottom

that we calculated at startup?


Thanks,
David
-----


> Since we don't support 2.4 kernel anymore lots of code could be
> simplified drastically.
>
> Do you want me to cleanup this code as well?
>
> -Dmitry
>
>
> On 2013-05-08 05:18, David Holmes wrote:
>> Hi Dmitry,
>>
>> First a few minor cleanups:
>>
>> - use spaces around all operators ie imax = imid; not imax=imid; etc
>> - don't use %p use appropriate *FORMAT macro
>> - don't leave commented out tty->print (either delete or guard with a
>> trace/debug flag or Verbose flag)
>>
>> ---
>>
>> os_linux.cpp:
>>
>> I'm not sure about the "#ifdef DEBUG_STACK_GUARD_PAGES". Do we need to
>> keep this code? If so should it just be non-product?
>>
>> I don't understand this guarantee:
>>
>> 2930     } else{
>> 2931            guarantee(res == false, "growable stack in non-initial
>> thread");
>> 2932     }
>>
>> What in the previous code indicates this is a growable stack?
>>
>>
>> 2961   bool chk_bounds = os::Linux::is_initial_thread();
>> 2962   if (chk_bounds) {
>>
>> We don't need the chk_bounds local any more.
>>
>> If I'm reading things right get_stack_bounds is only called for the
>> initial thread, but you then call pthread_getattr_np  but that isn't
>> valid as stated elsewhere:
>>
>> 1124 // Locate initial thread stack. This special handling of initial
>> thread stack
>> 1125 // is needed because pthread_getattr_np() on most (all?) Linux
>> distros returns
>> 1126 // bogus value for initial thread.
>>
>> ??? So how is this working?
>>
>> Also you should save the return values of the pthread_* functions and
>> use assert_state to check them for errors. (Yes I know this is handled
>> very inconsistently through the code but we should be moving towards
>> full error checking.)
>>
>> Overall I'm unclear about the detailed logic being applied here (in both
>> old code and new!).
>>
>> Thanks,
>> David
>> -----
>>
>> On 23/04/2013 7:41 AM, Dmitry Samersoff wrote:
>>> Hi Everybody,
>>>
>>> Here is webrev of proposed changes:
>>>
>>> http://cr.openjdk.java.net/~dsamersoff/8009062/webrev.04/
>>>
>>> Any comments is much appreciated.
>>>
>>> The problem:
>>>
>>> Under Linux stack of main thread is growable, so we have to make sure
>>> that address we plan to put a guard pages to and below is not mapped.
>>>
>>> Historically we find bounds of the stack of main thread by seeking
>>> /proc/self/maps for "[stack]" and parsing this line.
>>>
>>> I don't like buffered reading of /proc files and sometimes ago rewrite
>>> this function to read it byte-to-byte. Unfortunately, resulting
>>> performance penalties is not acceptable.
>>>
>>>
>>> Solution:
>>>
>>> Below is slightly different approach - I use mincore(2) to check whether
>>> the page is mapped or not. Typically mincore(2) is used to check whether
>>> the page is resides in physical memory or not, but this function returns
>>> -1 and set errno to ENOMEM if a region we are asking about contains not
>>> mapped memory.
>>>
>>> Testing:
>>>
>>> Passed jprt and couple of jtreg tests. No special regression test
>>> necessary as the test for 6929067 covers this case as well.
>>>
>>> -Dmitry
>>>
>>>
>>>
>>> On 2013-03-28 23:02, Adam Domurad wrote:
>>>> On 03/11/2013 01:19 PM, Dmitry Samersoff wrote:
>>>>> Adam,
>>>>>
>>>>> Sorry! I can't provide any estimations right now. But it's a high
>>>>> priority issue in my queue, and I plan to provide a fix as soon as it
>>>>> become possible.
>>>>>
>>>>> -Dmitry
>>>>>
>>>>> On 2013-03-06 21:45, Adam Domurad wrote:
>>>>>> On 03/01/2013 11:00 AM, Dmitry Samersoff wrote:
>>>>>>> Adam,
>>>>>>>
>>>>>>> Thank you for advice! I'm looking for a possibility to remove
>>>>>>> get_stack_bounds function entirely as Dean suggested. But it takes
>>>>>>> some
>>>>>>> time.
>>>>>> Hi again, not to be a bother, but do you have a rough time-frame that
>>>>>> the fix will take?
>>>>>>
>>>>>> Thanks,
>>>>>> -Adam
>>>>>
>>>>
>>>> As per our off-list chat, I have attached my implementation of a revised
>>>> implementation of get_stack_bounds with a small test-case. As far as
>>>> performance is concerned, it's an order of magnitude faster from my
>>>> timings. This should be suitable given that no problems were reported
>>>> with the old implementation.
>>>>
>>>> Happy hacking,
>>>> -Adam
>>>
>>>
>
>

From alejandro.murillo at oracle.com  Thu May  9 08:55:15 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Thu, 09 May 2013 15:55:15 +0000
Subject: hg: hsx/hsx24/hotspot: 8 new changesets
Message-ID: <20130509155532.AF5EE48931@hg.openjdk.java.net>

Changeset: 2cf0bc894c52
Author:    amurillo
Date:      2013-04-23 13:52 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/2cf0bc894c52

Merge

! .hgtags
! make/hotspot_version

Changeset: 1ff1748e332f
Author:    lana
Date:      2013-04-24 18:27 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/1ff1748e332f

Merge

! .hgtags

Changeset: 4048835037c9
Author:    amurillo
Date:      2013-04-30 14:44 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/4048835037c9

Merge

! .hgtags

Changeset: b2290f206d67
Author:    lana
Date:      2013-05-06 09:55 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/b2290f206d67

Merge

! .hgtags

Changeset: a36051465050
Author:    jcoomes
Date:      2013-05-07 22:16 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/a36051465050

Merge

! .hgtags

Changeset: e085458ffacf
Author:    katleman
Date:      2013-05-08 16:51 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/e085458ffacf

Added tag jdk7u40-b24 for changeset a36051465050

! .hgtags

Changeset: 7eabf05bddea
Author:    amurillo
Date:      2013-05-09 06:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/7eabf05bddea

Merge


Changeset: f8075a623349
Author:    amurillo
Date:      2013-05-09 06:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/f8075a623349

Added tag hs24-b44 for changeset 7eabf05bddea

! .hgtags


From kevin.walls at oracle.com  Thu May  9 10:49:57 2013
From: kevin.walls at oracle.com (kevin.walls at oracle.com)
Date: Thu, 09 May 2013 17:49:57 +0000
Subject: hg: hsx/hsx24/hotspot: 3 new changesets
Message-ID: <20130509175007.BE36248937@hg.openjdk.java.net>

Changeset: c8ebb78f7fce
Author:    kevinw
Date:      2013-04-18 17:02 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/c8ebb78f7fce

7109087: gc/7072527/TestFullGCCount.java fails when GC is set in command-line
Reviewed-by: mgerdin

! test/gc/7072527/TestFullGCCount.java

Changeset: 41757aca677e
Author:    kevinw
Date:      2013-05-09 14:45 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/41757aca677e

Merge


Changeset: f6fd93a613f7
Author:    kevinw
Date:      2013-05-09 17:59 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/f6fd93a613f7

Merge



From alejandro.murillo at oracle.com  Thu May  9 14:27:11 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Thu, 09 May 2013 21:27:11 +0000
Subject: hg: hsx/hsx24/hotspot: 2 new changesets
Message-ID: <20130509212719.C40314895E@hg.openjdk.java.net>

Changeset: 6af72a80f8d8
Author:    amurillo
Date:      2013-05-09 06:26 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/6af72a80f8d8

8014278: new hotspot build - hs24-b45
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: 78039199d8e5
Author:    amurillo
Date:      2013-05-09 10:52 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/78039199d8e5

Merge



From jiangli.zhou at oracle.com  Thu May  9 18:27:42 2013
From: jiangli.zhou at oracle.com (jiangli.zhou at oracle.com)
Date: Fri, 10 May 2013 01:27:42 +0000
Subject: hg: hsx/hotspot-main/hotspot: 5 new changesets
Message-ID: <20130510012759.EA95548988@hg.openjdk.java.net>

Changeset: e60b3fce2b02
Author:    jiangli
Date:      2013-05-06 19:57 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/e60b3fce2b02

8013067: Zero builds are broken after 8010862.
Summary: Fixed broken Zero build.
Reviewed-by: twisti, coleenp, kvn

! src/cpu/zero/vm/cppInterpreter_zero.cpp
! src/share/vm/interpreter/bytecodeInterpreter.cpp
! src/share/vm/oops/method.hpp

Changeset: 27d2d456cd96
Author:    jiangli
Date:      2013-05-06 20:11 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/27d2d456cd96

Merge


Changeset: 6b388e7d4905
Author:    bpittore
Date:      2013-05-07 10:19 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/6b388e7d4905

8013633: Cleanup platform ifdefs in unsafe.cpp
Summary: Replace ifdefs with SUPPORTS_NATIVE_CX8 set in platform include file
Reviewed-by: dholmes, dlong

! src/cpu/sparc/vm/globalDefinitions_sparc.hpp
! src/cpu/x86/vm/globalDefinitions_x86.hpp
! src/share/vm/prims/unsafe.cpp

Changeset: a258a8351528
Author:    vladidan
Date:      2013-05-07 10:36 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a258a8351528

Merge

- agent/doc/c2replay.html

Changeset: d3c98423c146
Author:    jiangli
Date:      2013-05-09 16:27 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d3c98423c146

Merge



From stefan.karlsson at oracle.com  Fri May 10 04:25:30 2013
From: stefan.karlsson at oracle.com (stefan.karlsson at oracle.com)
Date: Fri, 10 May 2013 11:25:30 +0000
Subject: hg: hsx/hotspot-main/hotspot: 10 new changesets
Message-ID: <20130510112645.6A4C3489A9@hg.openjdk.java.net>

Changeset: 1d0fba8a2a6d
Author:    brutisso
Date:      2013-05-02 22:35 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/1d0fba8a2a6d

8013574: PrintMalloc conflicts with the command line parsing
Summary: Make sure that _num_jvm_args is not updated until the new entry to _jvm_args_array has been added
Reviewed-by: johnc, tamao, tschatzl

! src/share/vm/runtime/arguments.cpp

Changeset: f14063dcd52a
Author:    brutisso
Date:      2013-05-06 09:16 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f14063dcd52a

8013791: G1: G1CollectorPolicy::initialize_flags() may set min_alignment > max_alignment
Summary: Make sure max alignemnt is at least as large as min alignment
Reviewed-by: johnc, jmasa, tschatzl

! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp
! src/share/vm/memory/collectorPolicy.cpp
+ test/gc/g1/TestRegionAlignment.java

Changeset: 30860066ae8f
Author:    jwilhelm
Date:      2013-05-06 13:03 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/30860066ae8f

Merge

! src/share/vm/runtime/arguments.cpp

Changeset: d17700c82d7d
Author:    tschatzl
Date:      2013-05-06 17:19 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d17700c82d7d

8006088: Incompatible heap size flags accepted by VM
Summary: Make processing of minimum, initial and maximum heap size more intiutive by removing previous limitations on allowed values, and make error reporting consistent. Further, fix errors in ergonomic heap sizing.
Reviewed-by: johnc, jwilhelm, tamao

! src/share/vm/memory/collectorPolicy.cpp
! src/share/vm/prims/whitebox.cpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: b0d20fa374b4
Author:    brutisso
Date:      2013-05-06 21:30 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b0d20fa374b4

8013872: G1: HeapRegionSeq::shrink_by() has invalid assert
Summary: Refactored shrink_by() to only use region counts and not byte sizes
Reviewed-by: johnc, tschatzl

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp
! src/share/vm/gc_implementation/g1/heapRegionSeq.hpp
+ test/gc/g1/TestShrinkToOneRegion.java

Changeset: a9d568b7df60
Author:    jmasa
Date:      2013-05-08 16:28 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a9d568b7df60

8013032: CMS: assert(used() == used_after_gc && used_after_gc <= capacity()) failed: used: 0 used_after_gc: 292080 capacity: 1431699456
Reviewed-by: tschatzl, mgerdin, johnc

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
+ test/gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java

Changeset: 06ab37f08701
Author:    jmasa
Date:      2013-05-08 17:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/06ab37f08701

8013184: CMS: Call reset_after_compaction() only if a compaction has been done
Reviewed-by: mgerdin, johnc, tschatzl

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp
+ test/gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java

Changeset: 923ac8d1df95
Author:    jwilhelm
Date:      2013-05-09 12:23 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/923ac8d1df95

Merge


Changeset: 194f52aa2f23
Author:    johnc
Date:      2013-05-09 11:16 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/194f52aa2f23

7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
Summary: Refactor G1's hot card cache and card counts table into their own files. Simplify the card counts table, including removing the encoding of the card index in each entry. The card counts table now has a 1:1 correspondence with the cards spanned by heap. Space for the card counts table is reserved from virtual memory (rather than C heap) during JVM startup and is committed/expanded when the heap is expanded. Changes were also reviewed-by Vitaly Davidovich.
Reviewed-by: tschatzl, jmasa

! make/excludeSrc.make
! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp
! src/share/vm/gc_implementation/g1/concurrentG1Refine.hpp
+ src/share/vm/gc_implementation/g1/g1CardCounts.cpp
+ src/share/vm/gc_implementation/g1/g1CardCounts.hpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp
! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.hpp
+ src/share/vm/gc_implementation/g1/g1HotCardCache.cpp
+ src/share/vm/gc_implementation/g1/g1HotCardCache.hpp
! src/share/vm/gc_implementation/g1/g1RemSet.cpp
! src/share/vm/gc_implementation/g1/g1RemSet.hpp
! src/share/vm/gc_implementation/g1/g1_globals.hpp
! src/share/vm/runtime/arguments.cpp

Changeset: 73652d89e7c4
Author:    stefank
Date:      2013-05-10 09:24 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/73652d89e7c4

Merge



From alejandro.murillo at oracle.com  Fri May 10 15:14:16 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 10 May 2013 22:14:16 +0000
Subject: hg: hsx/hsx25/hotspot: 39 new changesets
Message-ID: <20130510221721.EE524489F6@hg.openjdk.java.net>

Changeset: 7d56b68a9672
Author:    katleman
Date:      2013-05-09 10:03 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/7d56b68a9672

Added tag jdk8-b89 for changeset 9c1fe0b419b4

! .hgtags

Changeset: 625ddb0052e1
Author:    amurillo
Date:      2013-05-03 08:19 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/625ddb0052e1

8013800: new hotspot build - hs25-b32
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: c456f4510385
Author:    sla
Date:      2013-05-03 12:24 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/c456f4510385

8008453: JvmtiClassFileReconstituter does not recognize default methods
Reviewed-by: acorn, sspitsyn

! src/share/vm/prims/jvmtiClassFileReconstituter.cpp

Changeset: 0380df7c3cd0
Author:    sla
Date:      2013-05-03 12:26 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/0380df7c3cd0

8013785: Respect EXTRA_CFLAGS on windows
Reviewed-by: mgronlun, rbackman, kvn

! make/windows/makefiles/compile.make
! make/windows/makefiles/defs.make

Changeset: 31a4e55f8c9d
Author:    fparain
Date:      2013-05-03 05:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/31a4e55f8c9d

8004095: Add support for JMX interface to Diagnostic Framework and Commands
Reviewed-by: acorn, sla

! src/share/vm/classfile/vmSymbols.hpp
! src/share/vm/runtime/serviceThread.cpp
! src/share/vm/services/attachListener.cpp
! src/share/vm/services/diagnosticCommand.cpp
! src/share/vm/services/diagnosticCommand.hpp
! src/share/vm/services/diagnosticFramework.cpp
! src/share/vm/services/diagnosticFramework.hpp
! src/share/vm/services/jmm.h
! src/share/vm/services/management.cpp
! src/share/vm/services/management.hpp
! src/share/vm/services/nmtDCmd.cpp
! src/share/vm/services/nmtDCmd.hpp

Changeset: 39fba0d6d9ad
Author:    fparain
Date:      2013-05-03 05:17 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/39fba0d6d9ad

Merge


Changeset: bf089b838c9e
Author:    ccheung
Date:      2013-05-02 16:55 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/bf089b838c9e

8012641: Perf_CreateLong creates perf counter of incorrect type
Reviewed-by: mchung, hseigel, coleenp

! src/share/vm/prims/perf.cpp

Changeset: a55b7b8c34af
Author:    zgu
Date:      2013-05-03 13:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/a55b7b8c34af

Merge


Changeset: 9c8e2f44228d
Author:    dcubed
Date:      2013-05-03 15:51 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/9c8e2f44228d

Merge


Changeset: 800078be49d2
Author:    hseigel
Date:      2013-05-06 09:10 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/800078be49d2

8013648: Guarantee(VerifyBeforeGC || VerifyDuringGC || VerifyBeforeExit || VerifyAfterGC) failed: too expensive
Summary: Fix code to call correct version of function find_class().
Reviewed-by: coleenp, rdurbin, dcubed

! src/share/vm/classfile/systemDictionary.cpp

Changeset: c18152e0554e
Author:    zgu
Date:      2013-05-06 11:15 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/c18152e0554e

8013120: NMT: Kitchensink crashes with assert(next_region == NULL || !next_region->is_committed_region()) failed: Sanity check
Summary: Fixed NMT to deal with releasing virtual memory region when there are still committed regions within it
Reviewed-by: acorn, coleenp

! src/share/vm/memory/allocation.inline.hpp
! src/share/vm/runtime/os.cpp
! src/share/vm/runtime/os.hpp
! src/share/vm/services/memSnapshot.cpp
+ test/runtime/NMT/ReleaseCommittedMemory.java

Changeset: da4d87770781
Author:    zgu
Date:      2013-05-06 08:49 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/da4d87770781

Merge


Changeset: d9b08d62b95e
Author:    acorn
Date:      2013-05-02 10:58 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d9b08d62b95e

8010783: assert(s->refcount() != 0) failed: for create_overpasses
Reviewed-by: kvn, dcubed

! src/share/vm/classfile/bytecodeAssembler.cpp

Changeset: b7f3bf2ba33b
Author:    acorn
Date:      2013-05-06 10:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b7f3bf2ba33b

Merge

- agent/doc/c2replay.html

Changeset: f916d5986c86
Author:    acorn
Date:      2013-05-06 12:36 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/f916d5986c86

Merge


Changeset: 187154b7a226
Author:    sla
Date:      2013-05-06 19:49 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/187154b7a226

8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes
Reviewed-by: coleenp, sspitsyn

! src/share/vm/prims/jvmtiClassFileReconstituter.cpp
! src/share/vm/prims/jvmtiClassFileReconstituter.hpp

Changeset: 3ecc6b9940de
Author:    sla
Date:      2013-05-07 01:25 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/3ecc6b9940de

Merge


Changeset: b5fef8013a95
Author:    sla
Date:      2013-05-07 14:04 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b5fef8013a95

8014044: Spelling error in JDK-8009615: boostrapmethod
Reviewed-by: sspitsyn, coleenp

! src/share/vm/prims/jvmtiClassFileReconstituter.cpp
! src/share/vm/prims/jvmtiClassFileReconstituter.hpp

Changeset: f6a055fcf47d
Author:    sla
Date:      2013-05-07 14:33 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/f6a055fcf47d

8005038: remove crufty '_g' support from SA
Reviewed-by: coleenp, mgronlun, rbackman

! agent/src/os/bsd/ps_core.c
! agent/src/os/linux/ps_core.c
! agent/src/os/solaris/proc/saproc.cpp
! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java
! agent/src/share/classes/sun/jvm/hotspot/LinuxVtblAccess.java
! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java
! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebuggerLocal.java

Changeset: 33bcd9ead1d5
Author:    ctornqvi
Date:      2013-05-07 21:36 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/33bcd9ead1d5

8009577: Test test/closed/runtime/classunload broken
Summary: Fixed tests to use new way of utilizing the WB API, fixed issue with where custom classloader got the classes from
Reviewed-by: collins, mgerdin, zgu

+ test/runtime/ClassUnload/KeepAliveClass.java
+ test/runtime/ClassUnload/KeepAliveClassLoader.java
+ test/runtime/ClassUnload/KeepAliveObject.java
+ test/runtime/ClassUnload/KeepAliveSoftReference.java
+ test/runtime/ClassUnload/UnloadTest.java
+ test/runtime/ClassUnload/classes/test/Empty.java
+ test/runtime/testlibrary/ClassUnloadCommon.java

Changeset: 58bb870a0cbd
Author:    emc
Date:      2013-05-07 13:45 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/58bb870a0cbd

8009729: Refix hotspot jni_<cpu>.h JNIEXPORT and JNIIMPORT definitions to match jdk version
Summary: Update JNIEXPORT and JNIIMPORT to work with other compilers that don't necessarily have the __attribute__ type qualifier
Reviewed-by: dholmes, dcubed, coleenp

! src/cpu/sparc/vm/jni_sparc.h
! src/cpu/x86/vm/jni_x86.h
! src/cpu/zero/vm/jni_zero.h

Changeset: 7243490a6847
Author:    coleenp
Date:      2013-05-07 14:30 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/7243490a6847

Merge


Changeset: e60b3fce2b02
Author:    jiangli
Date:      2013-05-06 19:57 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/e60b3fce2b02

8013067: Zero builds are broken after 8010862.
Summary: Fixed broken Zero build.
Reviewed-by: twisti, coleenp, kvn

! src/cpu/zero/vm/cppInterpreter_zero.cpp
! src/share/vm/interpreter/bytecodeInterpreter.cpp
! src/share/vm/oops/method.hpp

Changeset: 27d2d456cd96
Author:    jiangli
Date:      2013-05-06 20:11 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/27d2d456cd96

Merge


Changeset: 6b388e7d4905
Author:    bpittore
Date:      2013-05-07 10:19 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/6b388e7d4905

8013633: Cleanup platform ifdefs in unsafe.cpp
Summary: Replace ifdefs with SUPPORTS_NATIVE_CX8 set in platform include file
Reviewed-by: dholmes, dlong

! src/cpu/sparc/vm/globalDefinitions_sparc.hpp
! src/cpu/x86/vm/globalDefinitions_x86.hpp
! src/share/vm/prims/unsafe.cpp

Changeset: a258a8351528
Author:    vladidan
Date:      2013-05-07 10:36 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/a258a8351528

Merge

- agent/doc/c2replay.html

Changeset: d3c98423c146
Author:    jiangli
Date:      2013-05-09 16:27 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d3c98423c146

Merge


Changeset: 1d0fba8a2a6d
Author:    brutisso
Date:      2013-05-02 22:35 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/1d0fba8a2a6d

8013574: PrintMalloc conflicts with the command line parsing
Summary: Make sure that _num_jvm_args is not updated until the new entry to _jvm_args_array has been added
Reviewed-by: johnc, tamao, tschatzl

! src/share/vm/runtime/arguments.cpp

Changeset: f14063dcd52a
Author:    brutisso
Date:      2013-05-06 09:16 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/f14063dcd52a

8013791: G1: G1CollectorPolicy::initialize_flags() may set min_alignment > max_alignment
Summary: Make sure max alignemnt is at least as large as min alignment
Reviewed-by: johnc, jmasa, tschatzl

! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp
! src/share/vm/memory/collectorPolicy.cpp
+ test/gc/g1/TestRegionAlignment.java

Changeset: 30860066ae8f
Author:    jwilhelm
Date:      2013-05-06 13:03 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/30860066ae8f

Merge

! src/share/vm/runtime/arguments.cpp

Changeset: d17700c82d7d
Author:    tschatzl
Date:      2013-05-06 17:19 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d17700c82d7d

8006088: Incompatible heap size flags accepted by VM
Summary: Make processing of minimum, initial and maximum heap size more intiutive by removing previous limitations on allowed values, and make error reporting consistent. Further, fix errors in ergonomic heap sizing.
Reviewed-by: johnc, jwilhelm, tamao

! src/share/vm/memory/collectorPolicy.cpp
! src/share/vm/prims/whitebox.cpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: b0d20fa374b4
Author:    brutisso
Date:      2013-05-06 21:30 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b0d20fa374b4

8013872: G1: HeapRegionSeq::shrink_by() has invalid assert
Summary: Refactored shrink_by() to only use region counts and not byte sizes
Reviewed-by: johnc, tschatzl

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp
! src/share/vm/gc_implementation/g1/heapRegionSeq.hpp
+ test/gc/g1/TestShrinkToOneRegion.java

Changeset: a9d568b7df60
Author:    jmasa
Date:      2013-05-08 16:28 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/a9d568b7df60

8013032: CMS: assert(used() == used_after_gc && used_after_gc <= capacity()) failed: used: 0 used_after_gc: 292080 capacity: 1431699456
Reviewed-by: tschatzl, mgerdin, johnc

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
+ test/gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java

Changeset: 06ab37f08701
Author:    jmasa
Date:      2013-05-08 17:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/06ab37f08701

8013184: CMS: Call reset_after_compaction() only if a compaction has been done
Reviewed-by: mgerdin, johnc, tschatzl

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp
+ test/gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java

Changeset: 923ac8d1df95
Author:    jwilhelm
Date:      2013-05-09 12:23 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/923ac8d1df95

Merge


Changeset: 194f52aa2f23
Author:    johnc
Date:      2013-05-09 11:16 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/194f52aa2f23

7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
Summary: Refactor G1's hot card cache and card counts table into their own files. Simplify the card counts table, including removing the encoding of the card index in each entry. The card counts table now has a 1:1 correspondence with the cards spanned by heap. Space for the card counts table is reserved from virtual memory (rather than C heap) during JVM startup and is committed/expanded when the heap is expanded. Changes were also reviewed-by Vitaly Davidovich.
Reviewed-by: tschatzl, jmasa

! make/excludeSrc.make
! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp
! src/share/vm/gc_implementation/g1/concurrentG1Refine.hpp
+ src/share/vm/gc_implementation/g1/g1CardCounts.cpp
+ src/share/vm/gc_implementation/g1/g1CardCounts.hpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp
! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.hpp
+ src/share/vm/gc_implementation/g1/g1HotCardCache.cpp
+ src/share/vm/gc_implementation/g1/g1HotCardCache.hpp
! src/share/vm/gc_implementation/g1/g1RemSet.cpp
! src/share/vm/gc_implementation/g1/g1RemSet.hpp
! src/share/vm/gc_implementation/g1/g1_globals.hpp
! src/share/vm/runtime/arguments.cpp

Changeset: 73652d89e7c4
Author:    stefank
Date:      2013-05-10 09:24 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/73652d89e7c4

Merge


Changeset: 69494caf5790
Author:    amurillo
Date:      2013-05-10 11:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/69494caf5790

Merge


Changeset: 1ae0472ff3a0
Author:    amurillo
Date:      2013-05-10 11:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/1ae0472ff3a0

Added tag hs25-b32 for changeset 69494caf5790

! .hgtags


From alejandro.murillo at oracle.com  Fri May 10 16:32:14 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 10 May 2013 23:32:14 +0000
Subject: hg: hsx/hotspot-main/hotspot: 4 new changesets
Message-ID: <20130510233234.964B4489FC@hg.openjdk.java.net>

Changeset: 7d56b68a9672
Author:    katleman
Date:      2013-05-09 10:03 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/7d56b68a9672

Added tag jdk8-b89 for changeset 9c1fe0b419b4

! .hgtags

Changeset: 69494caf5790
Author:    amurillo
Date:      2013-05-10 11:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/69494caf5790

Merge


Changeset: 1ae0472ff3a0
Author:    amurillo
Date:      2013-05-10 11:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/1ae0472ff3a0

Added tag hs25-b32 for changeset 69494caf5790

! .hgtags

Changeset: 6114c49b31b5
Author:    amurillo
Date:      2013-05-10 11:27 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/6114c49b31b5

8014279: new hotspot build - hs25-b33
Reviewed-by: jcoomes

! make/hotspot_version


From coleen.phillimore at oracle.com  Mon May 13 09:33:48 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Mon, 13 May 2013 12:33:48 -0400
Subject: CFV: New HSX Reviewer: Staffan Larsen
Message-ID: <519115EC.5090004@oracle.com>

I hereby nominate Staffan Larsen (openjdk username: sla) to be an 
OpenJDK HSX [0] Reviewer [1].

Staffan is technical lead of the serviceability team of the Hotspot JVM 
in the past three years and has contributed 33 changesets [4] to hsx in 
openjdk.    These changes have been fixing the serviceability agent on 
all platforms, fixing build problems particularly on windows, and adding 
various improvements to debugging support. Staffan has deep knowledge of 
the serviceability area of the JVM and has reviewed many changes for his 
fellow committers in this area as well.

Votes are due by Monday, May 27th at 16:00:00 UTC (two week voting period).

Only current HSX project Reviewers [2] are eligible to vote on this 
nomination.

For Three-Vote Consensus voting instructions, see [3].

Regards,
Coleen Phillimore

[0]http://openjdk.java.net/census/#hsx
[1]http://openjdk.java.net/bylaws#reviewer
[2]http://openjdk.java.net/projects/#reviewer-vote
[3]http://openjdk.java.net/bylaws#three-vote-consensus
[4] list here:

http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cbfe859bd244
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f6a055fcf47d
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5fef8013a95
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/187154b7a226
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0380df7c3cd0
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c456f4510385
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e4614b063fe1
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9f96b7a853bc
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/255c0a4cb4eb
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5ed317b25e23
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5e3ec9c69fa
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f82bcc429e8c
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5d5c577296fd
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/49618582fc5b
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/758935f7c23f
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a1b8cf9cf970
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0af5da0c9d9d
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/15ba0e7a3ff4
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/be82ef218872
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5a1f452f8f90
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/74533f63b116
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/588f559105c1
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/29ee40a082d3
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/10c12fb36ed2
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/77591ef8983a
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0368109684cb
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/74e790c48cd4
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5584e20db481
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/da091bb67459
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/15d6977f04b0
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/aa6e219afbf1
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/017cd8bce8a8
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cb2d0a362639




From karen.kinnear at oracle.com  Mon May 13 09:45:02 2013
From: karen.kinnear at oracle.com (Karen Kinnear)
Date: Mon, 13 May 2013 12:45:02 -0400
Subject: CFV: New HSX Reviewer: Staffan Larsen
In-Reply-To: <519115EC.5090004@oracle.com>
References: <519115EC.5090004@oracle.com>
Message-ID: <2E1D7353-C094-48CE-A626-839C62543DF5@oracle.com>

vote: yes

thanks,
Karen

On May 13, 2013, at 12:33 PM, Coleen Phillimore wrote:

> I hereby nominate Staffan Larsen (openjdk username: sla) to be an OpenJDK HSX [0] Reviewer [1].
> 
> Staffan is technical lead of the serviceability team of the Hotspot JVM in the past three years and has contributed 33 changesets [4] to hsx in openjdk.    These changes have been fixing the serviceability agent on all platforms, fixing build problems particularly on windows, and adding various improvements to debugging support. Staffan has deep knowledge of the serviceability area of the JVM and has reviewed many changes for his fellow committers in this area as well.
> 
> Votes are due by Monday, May 27th at 16:00:00 UTC (two week voting period).
> 
> Only current HSX project Reviewers [2] are eligible to vote on this nomination.
> 
> For Three-Vote Consensus voting instructions, see [3].
> 
> Regards,
> Coleen Phillimore
> 
> [0]http://openjdk.java.net/census/#hsx
> [1]http://openjdk.java.net/bylaws#reviewer
> [2]http://openjdk.java.net/projects/#reviewer-vote
> [3]http://openjdk.java.net/bylaws#three-vote-consensus
> [4] list here:
> 
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cbfe859bd244
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f6a055fcf47d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5fef8013a95
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/187154b7a226
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0380df7c3cd0
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c456f4510385
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e4614b063fe1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9f96b7a853bc
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/255c0a4cb4eb
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5ed317b25e23
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5e3ec9c69fa
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f82bcc429e8c
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5d5c577296fd
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/49618582fc5b
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/758935f7c23f
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a1b8cf9cf970
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0af5da0c9d9d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/15ba0e7a3ff4
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/be82ef218872
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5a1f452f8f90
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/74533f63b116
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/588f559105c1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/29ee40a082d3
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/10c12fb36ed2
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/77591ef8983a
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0368109684cb
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/74e790c48cd4
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5584e20db481
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/da091bb67459
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/15d6977f04b0
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/aa6e219afbf1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/017cd8bce8a8
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cb2d0a362639
> 
> 
> 


From bengt.rutisson at oracle.com  Mon May 13 09:59:04 2013
From: bengt.rutisson at oracle.com (Bengt Rutisson)
Date: Mon, 13 May 2013 18:59:04 +0200
Subject: CFV: New HSX Reviewer: Staffan Larsen
In-Reply-To: <519115EC.5090004@oracle.com>
References: <519115EC.5090004@oracle.com>
Message-ID: <0FE92619-E911-45E3-BB5C-9AB973F5C6D6@oracle.com>


Vote: Yes

Bengt

13 maj 2013 kl. 18:33 skrev Coleen Phillimore <coleen.phillimore at oracle.com>:

> I hereby nominate Staffan Larsen (openjdk username: sla) to be an OpenJDK HSX [0] Reviewer [1].
> 
> Staffan is technical lead of the serviceability team of the Hotspot JVM in the past three years and has contributed 33 changesets [4] to hsx in openjdk.    These changes have been fixing the serviceability agent on all platforms, fixing build problems particularly on windows, and adding various improvements to debugging support. Staffan has deep knowledge of the serviceability area of the JVM and has reviewed many changes for his fellow committers in this area as well.
> 
> Votes are due by Monday, May 27th at 16:00:00 UTC (two week voting period).
> 
> Only current HSX project Reviewers [2] are eligible to vote on this nomination.
> 
> For Three-Vote Consensus voting instructions, see [3].
> 
> Regards,
> Coleen Phillimore
> 
> [0]http://openjdk.java.net/census/#hsx
> [1]http://openjdk.java.net/bylaws#reviewer
> [2]http://openjdk.java.net/projects/#reviewer-vote
> [3]http://openjdk.java.net/bylaws#three-vote-consensus
> [4] list here:
> 
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cbfe859bd244
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f6a055fcf47d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5fef8013a95
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/187154b7a226
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0380df7c3cd0
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c456f4510385
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e4614b063fe1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9f96b7a853bc
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/255c0a4cb4eb
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5ed317b25e23
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5e3ec9c69fa
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f82bcc429e8c
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5d5c577296fd
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/49618582fc5b
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/758935f7c23f
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a1b8cf9cf970
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0af5da0c9d9d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/15ba0e7a3ff4
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/be82ef218872
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5a1f452f8f90
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/74533f63b116
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/588f559105c1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/29ee40a082d3
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/10c12fb36ed2
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/77591ef8983a
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0368109684cb
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/74e790c48cd4
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5584e20db481
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/da091bb67459
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/15d6977f04b0
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/aa6e219afbf1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/017cd8bce8a8
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cb2d0a362639
> 
> 
> 

From zhengyu.gu at oracle.com  Mon May 13 10:03:49 2013
From: zhengyu.gu at oracle.com (Zhengyu Gu)
Date: Mon, 13 May 2013 13:03:49 -0400
Subject: CFV: New HSX Reviewer: Staffan Larsen
In-Reply-To: <519115EC.5090004@oracle.com>
References: <519115EC.5090004@oracle.com>
Message-ID: <5D8FAF5D-ADB6-48B5-858D-BF1D6A6BBB59@oracle.com>

Vote: yes

-Zhengyu

On May 13, 2013, at 12:33 PM, Coleen Phillimore wrote:

> I hereby nominate Staffan Larsen (openjdk username: sla) to be an OpenJDK HSX [0] Reviewer [1].
> 
> Staffan is technical lead of the serviceability team of the Hotspot JVM in the past three years and has contributed 33 changesets [4] to hsx in openjdk.    These changes have been fixing the serviceability agent on all platforms, fixing build problems particularly on windows, and adding various improvements to debugging support. Staffan has deep knowledge of the serviceability area of the JVM and has reviewed many changes for his fellow committers in this area as well.
> 
> Votes are due by Monday, May 27th at 16:00:00 UTC (two week voting period).
> 
> Only current HSX project Reviewers [2] are eligible to vote on this nomination.
> 
> For Three-Vote Consensus voting instructions, see [3].
> 
> Regards,
> Coleen Phillimore
> 
> [0]http://openjdk.java.net/census/#hsx
> [1]http://openjdk.java.net/bylaws#reviewer
> [2]http://openjdk.java.net/projects/#reviewer-vote
> [3]http://openjdk.java.net/bylaws#three-vote-consensus
> [4] list here:
> 
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cbfe859bd244
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f6a055fcf47d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5fef8013a95
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/187154b7a226
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0380df7c3cd0
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c456f4510385
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e4614b063fe1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9f96b7a853bc
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/255c0a4cb4eb
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5ed317b25e23
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5e3ec9c69fa
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f82bcc429e8c
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5d5c577296fd
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/49618582fc5b
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/758935f7c23f
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a1b8cf9cf970
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0af5da0c9d9d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/15ba0e7a3ff4
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/be82ef218872
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5a1f452f8f90
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/74533f63b116
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/588f559105c1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/29ee40a082d3
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/10c12fb36ed2
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/77591ef8983a
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0368109684cb
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/74e790c48cd4
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5584e20db481
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/da091bb67459
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/15d6977f04b0
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/aa6e219afbf1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/017cd8bce8a8
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cb2d0a362639
> 
> 
> 


From stefan.karlsson at oracle.com  Mon May 13 10:14:07 2013
From: stefan.karlsson at oracle.com (Stefan Karlsson)
Date: Mon, 13 May 2013 19:14:07 +0200
Subject: CFV: New HSX Reviewer: Staffan Larsen
In-Reply-To: <519115EC.5090004@oracle.com>
References: <519115EC.5090004@oracle.com>
Message-ID: <51911F5F.40901@oracle.com>

Vote: yes

StefanK

On 2013-05-13 18:33, Coleen Phillimore wrote:
> I hereby nominate Staffan Larsen (openjdk username: sla) to be an 
> OpenJDK HSX [0] Reviewer [1].
>
> Staffan is technical lead of the serviceability team of the Hotspot 
> JVM in the past three years and has contributed 33 changesets [4] to 
> hsx in openjdk.    These changes have been fixing the serviceability 
> agent on all platforms, fixing build problems particularly on windows, 
> and adding various improvements to debugging support. Staffan has deep 
> knowledge of the serviceability area of the JVM and has reviewed many 
> changes for his fellow committers in this area as well.
>
> Votes are due by Monday, May 27th at 16:00:00 UTC (two week voting 
> period).
>
> Only current HSX project Reviewers [2] are eligible to vote on this 
> nomination.
>
> For Three-Vote Consensus voting instructions, see [3].
>
> Regards,
> Coleen Phillimore
>
> [0]http://openjdk.java.net/census/#hsx
> [1]http://openjdk.java.net/bylaws#reviewer
> [2]http://openjdk.java.net/projects/#reviewer-vote
> [3]http://openjdk.java.net/bylaws#three-vote-consensus
> [4] list here:
>
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cbfe859bd244
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f6a055fcf47d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5fef8013a95
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/187154b7a226
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0380df7c3cd0
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c456f4510385
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e4614b063fe1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9f96b7a853bc
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/255c0a4cb4eb
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5ed317b25e23
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5e3ec9c69fa
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f82bcc429e8c
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5d5c577296fd
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/49618582fc5b
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/758935f7c23f
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a1b8cf9cf970
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0af5da0c9d9d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/15ba0e7a3ff4
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/be82ef218872
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5a1f452f8f90
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/74533f63b116
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/588f559105c1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/29ee40a082d3
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/10c12fb36ed2
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/77591ef8983a
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0368109684cb
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/74e790c48cd4
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5584e20db481
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/da091bb67459
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/15d6977f04b0
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/aa6e219afbf1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/017cd8bce8a8
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cb2d0a362639
>
>
>


From coleen.phillimore at oracle.com  Mon May 13 10:16:32 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Mon, 13 May 2013 13:16:32 -0400
Subject: CFV: New HSX Reviewer: Staffan Larsen
In-Reply-To: <519115EC.5090004@oracle.com>
References: <519115EC.5090004@oracle.com>
Message-ID: <51911FF0.6000400@oracle.com>


Vote: yes

On 5/13/2013 12:33 PM, Coleen Phillimore wrote:
> I hereby nominate Staffan Larsen (openjdk username: sla) to be an 
> OpenJDK HSX [0] Reviewer [1].
>
> Staffan is technical lead of the serviceability team of the Hotspot 
> JVM in the past three years and has contributed 33 changesets [4] to 
> hsx in openjdk.    These changes have been fixing the serviceability 
> agent on all platforms, fixing build problems particularly on windows, 
> and adding various improvements to debugging support. Staffan has deep 
> knowledge of the serviceability area of the JVM and has reviewed many 
> changes for his fellow committers in this area as well.
>
> Votes are due by Monday, May 27th at 16:00:00 UTC (two week voting 
> period).
>
> Only current HSX project Reviewers [2] are eligible to vote on this 
> nomination.
>
> For Three-Vote Consensus voting instructions, see [3].
>
> Regards,
> Coleen Phillimore
>
> [0]http://openjdk.java.net/census/#hsx
> [1]http://openjdk.java.net/bylaws#reviewer
> [2]http://openjdk.java.net/projects/#reviewer-vote
> [3]http://openjdk.java.net/bylaws#three-vote-consensus
> [4] list here:
>
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cbfe859bd244
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f6a055fcf47d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5fef8013a95
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/187154b7a226
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0380df7c3cd0
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c456f4510385
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e4614b063fe1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9f96b7a853bc
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/255c0a4cb4eb
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5ed317b25e23
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5e3ec9c69fa
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f82bcc429e8c
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5d5c577296fd
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/49618582fc5b
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/758935f7c23f
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a1b8cf9cf970
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0af5da0c9d9d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/15ba0e7a3ff4
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/be82ef218872
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5a1f452f8f90
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/74533f63b116
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/588f559105c1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/29ee40a082d3
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/10c12fb36ed2
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/77591ef8983a
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0368109684cb
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/74e790c48cd4
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5584e20db481
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/da091bb67459
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/15d6977f04b0
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/aa6e219afbf1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/017cd8bce8a8
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cb2d0a362639
>
>
>


From daniel.daugherty at oracle.com  Mon May 13 10:19:45 2013
From: daniel.daugherty at oracle.com (Daniel D. Daugherty)
Date: Mon, 13 May 2013 11:19:45 -0600
Subject: CFV: New HSX Reviewer: Staffan Larsen
In-Reply-To: <519115EC.5090004@oracle.com>
References: <519115EC.5090004@oracle.com>
Message-ID: <519120B1.2010007@oracle.com>

Vote: yes

Dan


On 5/13/13 10:33 AM, Coleen Phillimore wrote:
> I hereby nominate Staffan Larsen (openjdk username: sla) to be an 
> OpenJDK HSX [0] Reviewer [1].
>
> Staffan is technical lead of the serviceability team of the Hotspot 
> JVM in the past three years and has contributed 33 changesets [4] to 
> hsx in openjdk.    These changes have been fixing the serviceability 
> agent on all platforms, fixing build problems particularly on windows, 
> and adding various improvements to debugging support. Staffan has deep 
> knowledge of the serviceability area of the JVM and has reviewed many 
> changes for his fellow committers in this area as well.
>
> Votes are due by Monday, May 27th at 16:00:00 UTC (two week voting 
> period).
>
> Only current HSX project Reviewers [2] are eligible to vote on this 
> nomination.
>
> For Three-Vote Consensus voting instructions, see [3].
>
> Regards,
> Coleen Phillimore
>
> [0]http://openjdk.java.net/census/#hsx
> [1]http://openjdk.java.net/bylaws#reviewer
> [2]http://openjdk.java.net/projects/#reviewer-vote
> [3]http://openjdk.java.net/bylaws#three-vote-consensus
> [4] list here:
>
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cbfe859bd244
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f6a055fcf47d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5fef8013a95
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/187154b7a226
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0380df7c3cd0
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c456f4510385
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e4614b063fe1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9f96b7a853bc
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/255c0a4cb4eb
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5ed317b25e23
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5e3ec9c69fa
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f82bcc429e8c
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5d5c577296fd
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/49618582fc5b
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/758935f7c23f
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a1b8cf9cf970
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0af5da0c9d9d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/15ba0e7a3ff4
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/be82ef218872
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5a1f452f8f90
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/74533f63b116
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/588f559105c1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/29ee40a082d3
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/10c12fb36ed2
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/77591ef8983a
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0368109684cb
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/74e790c48cd4
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5584e20db481
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/da091bb67459
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/15d6977f04b0
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/aa6e219afbf1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/017cd8bce8a8
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cb2d0a362639
>
>
>


From vladimir.kozlov at oracle.com  Mon May 13 10:48:05 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Mon, 13 May 2013 10:48:05 -0700
Subject: CFV: New HSX Reviewer: Staffan Larsen
In-Reply-To: <519115EC.5090004@oracle.com>
References: <519115EC.5090004@oracle.com>
Message-ID: <51912755.3070303@oracle.com>

Vote: yes

Vladimir

On 5/13/13 9:33 AM, Coleen Phillimore wrote:
> I hereby nominate Staffan Larsen (openjdk username: sla) to be an
> OpenJDK HSX [0] Reviewer [1].
>
> Staffan is technical lead of the serviceability team of the Hotspot JVM
> in the past three years and has contributed 33 changesets [4] to hsx in
> openjdk.    These changes have been fixing the serviceability agent on
> all platforms, fixing build problems particularly on windows, and adding
> various improvements to debugging support. Staffan has deep knowledge of
> the serviceability area of the JVM and has reviewed many changes for his
> fellow committers in this area as well.
>
> Votes are due by Monday, May 27th at 16:00:00 UTC (two week voting period).
>
> Only current HSX project Reviewers [2] are eligible to vote on this
> nomination.
>
> For Three-Vote Consensus voting instructions, see [3].
>
> Regards,
> Coleen Phillimore
>
> [0]http://openjdk.java.net/census/#hsx
> [1]http://openjdk.java.net/bylaws#reviewer
> [2]http://openjdk.java.net/projects/#reviewer-vote
> [3]http://openjdk.java.net/bylaws#three-vote-consensus
> [4] list here:
>
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cbfe859bd244
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f6a055fcf47d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5fef8013a95
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/187154b7a226
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0380df7c3cd0
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c456f4510385
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e4614b063fe1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9f96b7a853bc
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/255c0a4cb4eb
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5ed317b25e23
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5e3ec9c69fa
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f82bcc429e8c
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5d5c577296fd
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/49618582fc5b
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/758935f7c23f
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a1b8cf9cf970
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0af5da0c9d9d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/15ba0e7a3ff4
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/be82ef218872
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5a1f452f8f90
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/74533f63b116
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/588f559105c1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/29ee40a082d3
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/10c12fb36ed2
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/77591ef8983a
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0368109684cb
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/74e790c48cd4
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5584e20db481
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/da091bb67459
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/15d6977f04b0
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/aa6e219afbf1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/017cd8bce8a8
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cb2d0a362639
>
>
>

From zhengyu.gu at oracle.com  Mon May 13 13:08:11 2013
From: zhengyu.gu at oracle.com (zhengyu.gu at oracle.com)
Date: Mon, 13 May 2013 20:08:11 +0000
Subject: hg: hsx/hsx24/hotspot: 8013120: NMT: Kitchensink crashes with
	assert(next_region == NULL ||
	!next_region->is_committed_region()) failed: Sanity check
Message-ID: <20130513200813.AC9F648A39@hg.openjdk.java.net>

Changeset: 0816789a8270
Author:    zgu
Date:      2013-05-10 16:46 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/0816789a8270

8013120: NMT: Kitchensink crashes with assert(next_region == NULL || !next_region->is_committed_region()) failed: Sanity check
Summary: Fixed NMT to deal with releasing virtual memory region when there are still committed regions within it
Reviewed-by: acorn, coleenp

! src/share/vm/runtime/os.cpp
! src/share/vm/runtime/os.hpp
! src/share/vm/services/memSnapshot.cpp
+ test/runtime/NMT/ReleaseCommittedMemory.java


From vladimir.kozlov at oracle.com  Mon May 13 14:01:30 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Mon, 13 May 2013 14:01:30 -0700
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <519152EC.80204@oracle.com>
References: <519152EC.80204@oracle.com>
Message-ID: <519154AA.2000601@oracle.com>

On 5/13/13 12:43 PM, Aleksey Shipilev wrote:
> On 05/13/2013 11:29 PM, Vladimir Kozlov wrote:
>> I meant to make it local to use place with renaming if needed.
>
> Ah, you mean at the very first change. I can do that, thanks.

I meant both places. You can simple remove

3148   int next_nonstatic_type_offset;

and add 'int' in use places because they are in different scopes.

>
>>>> I think the fix is not right. If super is contended the nonstatic size
>>>> should contain the padding already:
>>>>
>>>> 3134   int nonstatic_field_size = _super_klass() == NULL ? 0 :
>>>> _super_klass()->nonstatic_field_size();
>>>>
>>>> Why it is not?
>>>
>>> Because nonstatic_field_size was actually missing the trailing padding.
>>
>> Why? Do you mean next codes did not add padding for super class:
>>
>> 3189   // class is contended, pad before all the fields
>> 3190   if (parsed_annotations->is_contended()) {
>> 3191     first_nonstatic_field_offset += pad_size;
>> 3192   }
>> 3193
>>
>> 3586   // Entire class is contended, pad in the back.
>> 3589   if (parsed_annotations->is_contended()) {
>> 3590     notaligned_offset += pad_size;
>> 3591   }
>
> There are two parts to this story: one is adding the padding for the
> class, which obviously works, and the second one is adding the padding
> for the field, which is missing. See the regression test there: the

Then why the next code does not work in such case?:

3482     // if there is at least one contended field, we need to have
pre-padding for them
3483     if (nonstatic_contended_count > 0) {
3484       next_nonstatic_padded_offset += pad_size;
3485     }


> field from the super-class and the field in subclass are not separated
> by any padding, even though both are @Contended.
>
>>> See the assert before, it is obviously not correct: instance_size misses
>>> the padding, and we need to add it up in the right hand side.
>>
>> Yes, assert was wrong.
>>
>>>
>>>> Also your fix does double padding:
>>>>
>>>> 3588   if (parsed_annotations->is_contended()) {
>>>> 3589     notaligned_offset += pad_size;
>>>> 3590   }
>>>>
>>>> 3598              + (parsed_annotations->is_contended() ? pad_size :
>>>> 0))/heapOopSize);
>>>
>>> Yes it does, but this is not introduced by the fix. The double padding
>>
>> You added line 3598. As result it adds class padding 2 times at the end.
>
> Ah, this line is confusing. See the chunk you had already posted?
>
>   3189   // class is contended, pad before all the fields
>   3190   if (parsed_annotations->is_contended()) {
>   3191     first_nonstatic_field_offset += pad_size;
>   3192   }
>   3193
>
> What line 3598 actually does is adds the leading padding *back* so we
> can calculate the proper instance size, because
> first_nonstatic_field_offset is already not at the start of the fields.

So HERE !!! is the main problem, first_nonstatic_field_offset does not
include class pre-padding. It was totally not clear from your changes.
And my question above about fields padding still stay, why it did not
add padding for Contended fields?

I think the better fix would be to use separate variable which includes
pre-padding and use it in nonstatic_field_size and instance_size
calculation.

Vladimir

>
>>> is due to this case:
>>>
>>>    @Contended
>>>    class C {
>>>       @Contended
>>>       int field;
>>>    }
>>
>> The bug report is not for this case.
>
> Sure, I'm just demonstrating how the double padding arises. That was a
> deliberate choice for the basic implementation.
>
>> Let see.
>>
>> Next expression should give correct nonstatic_field_size with class
>> padding for super class:
>>
>> 3134   int nonstatic_field_size = _super_klass() == NULL ? 0 :
>> _super_klass()->nonstatic_field_size();
>>
>> It should be (272-head_size)/heapOopSize for bug case. If it is not,
>> then that is the bug.
>
> I had the printed debugging to demonstrate the nonstatic_field_size was
> the culprit, because we accidentally chomped off the leading field
> padding the super-class by subtracting already "off"
> first_nonstatic_field_offset.
>
> Do you want me to rework this to make the intent clearer?
>
> -Aleksey.
>



From vladimir.kozlov at oracle.com  Mon May 13 14:15:58 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Mon, 13 May 2013 14:15:58 -0700
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <519154AA.2000601@oracle.com>
References: <519152EC.80204@oracle.com> <519154AA.2000601@oracle.com>
Message-ID: <5191580E.2080307@oracle.com>

Calculation of orig_nonstatic_field_size variable is also wrong. It does 
not take into account fields padding.
But it is not important. We can skip PrintCompactFieldsSavings code if 
class or its fields are contended because we don't care about compaction 
in such case.

Vladimir

On 5/13/13 2:01 PM, Vladimir Kozlov wrote:
> On 5/13/13 12:43 PM, Aleksey Shipilev wrote:
>> On 05/13/2013 11:29 PM, Vladimir Kozlov wrote:
>>> I meant to make it local to use place with renaming if needed.
>>
>> Ah, you mean at the very first change. I can do that, thanks.
>
> I meant both places. You can simple remove
>
> 3148   int next_nonstatic_type_offset;
>
> and add 'int' in use places because they are in different scopes.
>
>>
>>>>> I think the fix is not right. If super is contended the nonstatic size
>>>>> should contain the padding already:
>>>>>
>>>>> 3134   int nonstatic_field_size = _super_klass() == NULL ? 0 :
>>>>> _super_klass()->nonstatic_field_size();
>>>>>
>>>>> Why it is not?
>>>>
>>>> Because nonstatic_field_size was actually missing the trailing padding.
>>>
>>> Why? Do you mean next codes did not add padding for super class:
>>>
>>> 3189   // class is contended, pad before all the fields
>>> 3190   if (parsed_annotations->is_contended()) {
>>> 3191     first_nonstatic_field_offset += pad_size;
>>> 3192   }
>>> 3193
>>>
>>> 3586   // Entire class is contended, pad in the back.
>>> 3589   if (parsed_annotations->is_contended()) {
>>> 3590     notaligned_offset += pad_size;
>>> 3591   }
>>
>> There are two parts to this story: one is adding the padding for the
>> class, which obviously works, and the second one is adding the padding
>> for the field, which is missing. See the regression test there: the
>
> Then why the next code does not work in such case?:
>
> 3482     // if there is at least one contended field, we need to have
> pre-padding for them
> 3483     if (nonstatic_contended_count > 0) {
> 3484       next_nonstatic_padded_offset += pad_size;
> 3485     }
>
>
>> field from the super-class and the field in subclass are not separated
>> by any padding, even though both are @Contended.
>>
>>>> See the assert before, it is obviously not correct: instance_size
>>>> misses
>>>> the padding, and we need to add it up in the right hand side.
>>>
>>> Yes, assert was wrong.
>>>
>>>>
>>>>> Also your fix does double padding:
>>>>>
>>>>> 3588   if (parsed_annotations->is_contended()) {
>>>>> 3589     notaligned_offset += pad_size;
>>>>> 3590   }
>>>>>
>>>>> 3598              + (parsed_annotations->is_contended() ? pad_size :
>>>>> 0))/heapOopSize);
>>>>
>>>> Yes it does, but this is not introduced by the fix. The double padding
>>>
>>> You added line 3598. As result it adds class padding 2 times at the end.
>>
>> Ah, this line is confusing. See the chunk you had already posted?
>>
>>   3189   // class is contended, pad before all the fields
>>   3190   if (parsed_annotations->is_contended()) {
>>   3191     first_nonstatic_field_offset += pad_size;
>>   3192   }
>>   3193
>>
>> What line 3598 actually does is adds the leading padding *back* so we
>> can calculate the proper instance size, because
>> first_nonstatic_field_offset is already not at the start of the fields.
>
> So HERE !!! is the main problem, first_nonstatic_field_offset does not
> include class pre-padding. It was totally not clear from your changes.
> And my question above about fields padding still stay, why it did not
> add padding for Contended fields?
>
> I think the better fix would be to use separate variable which includes
> pre-padding and use it in nonstatic_field_size and instance_size
> calculation.
>
> Vladimir
>
>>
>>>> is due to this case:
>>>>
>>>>    @Contended
>>>>    class C {
>>>>       @Contended
>>>>       int field;
>>>>    }
>>>
>>> The bug report is not for this case.
>>
>> Sure, I'm just demonstrating how the double padding arises. That was a
>> deliberate choice for the basic implementation.
>>
>>> Let see.
>>>
>>> Next expression should give correct nonstatic_field_size with class
>>> padding for super class:
>>>
>>> 3134   int nonstatic_field_size = _super_klass() == NULL ? 0 :
>>> _super_klass()->nonstatic_field_size();
>>>
>>> It should be (272-head_size)/heapOopSize for bug case. If it is not,
>>> then that is the bug.
>>
>> I had the printed debugging to demonstrate the nonstatic_field_size was
>> the culprit, because we accidentally chomped off the leading field
>> padding the super-class by subtracting already "off"
>> first_nonstatic_field_offset.
>>
>> Do you want me to rework this to make the intent clearer?
>>
>> -Aleksey.
>>
>
>

From aleksey.shipilev at oracle.com  Mon May 13 14:23:10 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Tue, 14 May 2013 01:23:10 +0400
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <5191580E.2080307@oracle.com>
References: <519152EC.80204@oracle.com> <519154AA.2000601@oracle.com>
	<5191580E.2080307@oracle.com>
Message-ID: <519159BE.9000504@oracle.com>

On 05/14/2013 01:15 AM, Vladimir Kozlov wrote:
> Calculation of orig_nonstatic_field_size variable is also wrong. It
> does not take into account fields padding. But it is not important.
> We can skip PrintCompactFieldsSavings code if class or its fields are
> contended because we don't care about compaction in such case.

That, btw, makes me wonder: do we care about PrintCompactFieldsSavings
anymore? Can we purge it to make the field layout code more readable?

-Aleksey.

From vladimir.kozlov at oracle.com  Mon May 13 14:28:48 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Mon, 13 May 2013 14:28:48 -0700
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <519159BE.9000504@oracle.com>
References: <519152EC.80204@oracle.com> <519154AA.2000601@oracle.com>
	<5191580E.2080307@oracle.com> <519159BE.9000504@oracle.com>
Message-ID: <51915B10.3020701@oracle.com>

On 5/13/13 2:23 PM, Aleksey Shipilev wrote:
> On 05/14/2013 01:15 AM, Vladimir Kozlov wrote:
>> Calculation of orig_nonstatic_field_size variable is also wrong. It
>> does not take into account fields padding. But it is not important.
>> We can skip PrintCompactFieldsSavings code if class or its fields are
>> contended because we don't care about compaction in such case.
>
> That, btw, makes me wonder: do we care about PrintCompactFieldsSavings
> anymore? Can we purge it to make the field layout code more readable?

It was used during fields reordering work but I doubt anyone used it 
since then. We can get similar info from fields layout output.

I agree with removing it but as separate RFE changes.

Vladimir

>
> -Aleksey.
>

From chunt at salesforce.com  Mon May 13 14:38:18 2013
From: chunt at salesforce.com (Charlie Hunt)
Date: Mon, 13 May 2013 14:38:18 -0700
Subject: meaning of {pd product} ?
Message-ID: <AD463DB4-3B60-4CD9-9410-2C4AA35BA3D4@salesforce.com>

Could someone refresh my memory as to the meaning of, {pd product} versus {product} in +PrintFlagsFinal output?

thanks,

charlie ...

From john.r.rose at oracle.com  Mon May 13 14:41:26 2013
From: john.r.rose at oracle.com (John Rose)
Date: Mon, 13 May 2013 14:41:26 -0700
Subject: CFV: New HSX Reviewer: Staffan Larsen
In-Reply-To: <519115EC.5090004@oracle.com>
References: <519115EC.5090004@oracle.com>
Message-ID: <EA4C1727-9997-4D5D-885C-7E3FB37363A5@oracle.com>

Vote: yes

From azeem.jiva at oracle.com  Mon May 13 14:41:40 2013
From: azeem.jiva at oracle.com (Azeem Jiva)
Date: Mon, 13 May 2013 14:41:40 -0700
Subject: meaning of {pd product} ?
In-Reply-To: <AD463DB4-3B60-4CD9-9410-2C4AA35BA3D4@salesforce.com>
References: <AD463DB4-3B60-4CD9-9410-2C4AA35BA3D4@salesforce.com>
Message-ID: <C196DBBB-93AD-4644-86B2-A43A0A61791E@oracle.com>

product dependent (PD)

--
Azeem Jiva
@javawithjiva

On May 13, 2013, at 2:38 PM, Charlie Hunt <chunt at salesforce.com> wrote:

> Could someone refresh my memory as to the meaning of, {pd product} versus {product} in +PrintFlagsFinal output?
> 
> thanks,
> 
> charlie ...


From azeem.jiva at oracle.com  Mon May 13 14:41:51 2013
From: azeem.jiva at oracle.com (Azeem Jiva)
Date: Mon, 13 May 2013 14:41:51 -0700
Subject: meaning of {pd product} ?
In-Reply-To: <AD463DB4-3B60-4CD9-9410-2C4AA35BA3D4@salesforce.com>
References: <AD463DB4-3B60-4CD9-9410-2C4AA35BA3D4@salesforce.com>
Message-ID: <E7246904-A24C-40EA-852A-ADA077BC0737@oracle.com>

Sorry Platform Dependent (PD)

--
Azeem Jiva
@javawithjiva

On May 13, 2013, at 2:38 PM, Charlie Hunt <chunt at salesforce.com> wrote:

> Could someone refresh my memory as to the meaning of, {pd product} versus {product} in +PrintFlagsFinal output?
> 
> thanks,
> 
> charlie ...


From john.r.rose at oracle.com  Mon May 13 14:42:12 2013
From: john.r.rose at oracle.com (John Rose)
Date: Mon, 13 May 2013 14:42:12 -0700
Subject: meaning of {pd product} ?
In-Reply-To: <AD463DB4-3B60-4CD9-9410-2C4AA35BA3D4@salesforce.com>
References: <AD463DB4-3B60-4CD9-9410-2C4AA35BA3D4@salesforce.com>
Message-ID: <DF76915C-F1B1-4DDB-BA0E-641D8CFAF0C0@oracle.com>

On May 13, 2013, at 2:38 PM, Charlie Hunt <chunt at salesforce.com> wrote:

> Could someone refresh my memory as to the meaning of, {pd product} versus {product} in +PrintFlagsFinal output?

PD = platform dependent

From azeem.jiva at oracle.com  Mon May 13 14:42:35 2013
From: azeem.jiva at oracle.com (Azeem Jiva)
Date: Mon, 13 May 2013 14:42:35 -0700
Subject: meaning of {pd product} ?
In-Reply-To: <AD463DB4-3B60-4CD9-9410-2C4AA35BA3D4@salesforce.com>
References: <AD463DB4-3B60-4CD9-9410-2C4AA35BA3D4@salesforce.com>
Message-ID: <F9D773C4-3D8D-4035-BAE2-7CDB004EF7BB@oracle.com>

Sorry Platform Dependent

--
Azeem Jiva
@javawithjiva

On May 13, 2013, at 2:38 PM, Charlie Hunt <chunt at salesforce.com> wrote:

> Could someone refresh my memory as to the meaning of, {pd product} versus {product} in +PrintFlagsFinal output?
> 
> thanks,
> 
> charlie ...


From vladimir.kozlov at oracle.com  Mon May 13 14:45:00 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Mon, 13 May 2013 14:45:00 -0700
Subject: meaning of {pd product} ?
In-Reply-To: <AD463DB4-3B60-4CD9-9410-2C4AA35BA3D4@salesforce.com>
References: <AD463DB4-3B60-4CD9-9410-2C4AA35BA3D4@salesforce.com>
Message-ID: <51915EDC.3060203@oracle.com>

'_pd' means platform dependent default value is different on different 
platforms (or Client vs Server VM):

$ grep InlineSmallCode src/*/*/*/*globals*.hpp
src/cpu/sparc/vm/globals_sparc.hpp:define_pd_global(intx, 
InlineSmallCode,       1500);
src/cpu/x86/vm/globals_x86.hpp:define_pd_global(intx, InlineSmallCode, 
         1000);
src/share/vm/runtime/globals.hpp:define_pd_global(intx, InlineSmallCode, 
              0);
src/share/vm/runtime/globals.hpp:  product_pd(intx, InlineSmallCode, 
                                      \

Vladimir

On 5/13/13 2:38 PM, Charlie Hunt wrote:
> Could someone refresh my memory as to the meaning of, {pd product} versus {product} in +PrintFlagsFinal output?
>
> thanks,
>
> charlie ...
>

From aleksey.shipilev at oracle.com  Mon May 13 14:49:07 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Tue, 14 May 2013 01:49:07 +0400
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <51915B10.3020701@oracle.com>
References: <519152EC.80204@oracle.com> <519154AA.2000601@oracle.com>
	<5191580E.2080307@oracle.com> <519159BE.9000504@oracle.com>
	<51915B10.3020701@oracle.com>
Message-ID: <51915FD3.2000307@oracle.com>

On 05/14/2013 01:28 AM, Vladimir Kozlov wrote:
> On 5/13/13 2:23 PM, Aleksey Shipilev wrote:
>> On 05/14/2013 01:15 AM, Vladimir Kozlov wrote:
>>> Calculation of orig_nonstatic_field_size variable is also wrong. It
>>> does not take into account fields padding. But it is not important.
>>> We can skip PrintCompactFieldsSavings code if class or its fields are
>>> contended because we don't care about compaction in such case.
>>
>> That, btw, makes me wonder: do we care about PrintCompactFieldsSavings
>> anymore? Can we purge it to make the field layout code more readable?
> 
> It was used during fields reordering work but I doubt anyone used it
> since then. We can get similar info from fields layout output.
> 
> I agree with removing it but as separate RFE changes.

Sounds good, I'll submit the PrintCompactFieldsSavings first then, and
base off my @Contended fix off that after.

-Aleksey.


From coleen.phillimore at oracle.com  Mon May 13 14:53:16 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Mon, 13 May 2013 17:53:16 -0400
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <51915B10.3020701@oracle.com>
References: <519152EC.80204@oracle.com> <519154AA.2000601@oracle.com>
	<5191580E.2080307@oracle.com> <519159BE.9000504@oracle.com>
	<51915B10.3020701@oracle.com>
Message-ID: <519160CC.5040907@oracle.com>

On 5/13/2013 5:28 PM, Vladimir Kozlov wrote:
> On 5/13/13 2:23 PM, Aleksey Shipilev wrote:
>> On 05/14/2013 01:15 AM, Vladimir Kozlov wrote:
>>> Calculation of orig_nonstatic_field_size variable is also wrong. It
>>> does not take into account fields padding. But it is not important.
>>> We can skip PrintCompactFieldsSavings code if class or its fields are
>>> contended because we don't care about compaction in such case.
>>
>> That, btw, makes me wonder: do we care about PrintCompactFieldsSavings
>> anymore? Can we purge it to make the field layout code more readable?
>
> It was used during fields reordering work but I doubt anyone used it 
> since then. We can get similar info from fields layout output.
>
> I agree with removing it but as separate RFE changes.

That would be nice.   I'll file or copy me on that RFE.   This code is 
almost impossible to follow.   Thank you Vladimir for doing this code 
review.

Coleen

>
> Vladimir
>
>>
>> -Aleksey.
>>


From chunt at salesforce.com  Mon May 13 16:11:04 2013
From: chunt at salesforce.com (Charlie Hunt)
Date: Mon, 13 May 2013 16:11:04 -0700
Subject: meaning of {pd product} ?
In-Reply-To: <DF76915C-F1B1-4DDB-BA0E-641D8CFAF0C0@oracle.com>
References: <AD463DB4-3B60-4CD9-9410-2C4AA35BA3D4@salesforce.com>
	<DF76915C-F1B1-4DDB-BA0E-641D8CFAF0C0@oracle.com>
Message-ID: <DBE2C92E-0A26-43B3-BFAB-ED3F8CD8836D@salesforce.com>

On May 13, 2013, at 4:42 PM, John Rose wrote:

> On May 13, 2013, at 2:38 PM, Charlie Hunt <chunt at salesforce.com> wrote:
> 
>> Could someone refresh my memory as to the meaning of, {pd product} versus {product} in +PrintFlagsFinal output?
> 
> PD = platform dependent

Oh yeah :-)  Thanks John and Azeem!

From david.holmes at oracle.com  Mon May 13 17:52:44 2013
From: david.holmes at oracle.com (David Holmes)
Date: Tue, 14 May 2013 10:52:44 +1000
Subject: CFV: New HSX Reviewer: Staffan Larsen
In-Reply-To: <519115EC.5090004@oracle.com>
References: <519115EC.5090004@oracle.com>
Message-ID: <51918ADC.3030000@oracle.com>

Vote: yes

David

On 14/05/2013 2:33 AM, Coleen Phillimore wrote:
> I hereby nominate Staffan Larsen (openjdk username: sla) to be an
> OpenJDK HSX [0] Reviewer [1].
>
> Staffan is technical lead of the serviceability team of the Hotspot JVM
> in the past three years and has contributed 33 changesets [4] to hsx in
> openjdk.    These changes have been fixing the serviceability agent on
> all platforms, fixing build problems particularly on windows, and adding
> various improvements to debugging support. Staffan has deep knowledge of
> the serviceability area of the JVM and has reviewed many changes for his
> fellow committers in this area as well.
>
> Votes are due by Monday, May 27th at 16:00:00 UTC (two week voting period).
>
> Only current HSX project Reviewers [2] are eligible to vote on this
> nomination.
>
> For Three-Vote Consensus voting instructions, see [3].
>
> Regards,
> Coleen Phillimore
>
> [0]http://openjdk.java.net/census/#hsx
> [1]http://openjdk.java.net/bylaws#reviewer
> [2]http://openjdk.java.net/projects/#reviewer-vote
> [3]http://openjdk.java.net/bylaws#three-vote-consensus
> [4] list here:
>
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cbfe859bd244
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f6a055fcf47d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5fef8013a95
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/187154b7a226
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0380df7c3cd0
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c456f4510385
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e4614b063fe1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9f96b7a853bc
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/255c0a4cb4eb
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5ed317b25e23
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5e3ec9c69fa
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f82bcc429e8c
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5d5c577296fd
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/49618582fc5b
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/758935f7c23f
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a1b8cf9cf970
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0af5da0c9d9d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/15ba0e7a3ff4
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/be82ef218872
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5a1f452f8f90
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/74533f63b116
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/588f559105c1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/29ee40a082d3
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/10c12fb36ed2
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/77591ef8983a
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0368109684cb
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/74e790c48cd4
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5584e20db481
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/da091bb67459
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/15d6977f04b0
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/aa6e219afbf1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/017cd8bce8a8
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cb2d0a362639
>
>
>

From vladimir.x.ivanov at oracle.com  Tue May 14 06:41:47 2013
From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov)
Date: Tue, 14 May 2013 17:41:47 +0400
Subject: Result: New HSX Committer: Igor Ignatyev
Message-ID: <51923F1B.8040307@oracle.com>

Voting for Igor Ignatyev [1] is now closed.

Yes: 10
Veto: 0
Abstain: 0

According to the Bylaws definition of Lazy Consensus [2], this is 
sufficient to approve the nomination.

Best regards,
Vladimir Ivanov

[1] 
http://mail.openjdk.java.net/pipermail/hotspot-dev/2013-April/009360.html
[2] http://openjdk.java.net/bylaws#lazy-consensus

From markus.gronlund at oracle.com  Tue May 14 08:17:43 2013
From: markus.gronlund at oracle.com (markus.gronlund at oracle.com)
Date: Tue, 14 May 2013 15:17:43 +0000
Subject: hg: hsx/hsx24/hotspot: 8014411: Decrease lock order rank for event
	tracing locks
Message-ID: <20130514151752.6E75E48A6C@hg.openjdk.java.net>

Changeset: 091c3bd3fcdd
Author:    mgronlun
Date:      2013-05-14 13:32 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/091c3bd3fcdd

8014411: Decrease lock order rank for event tracing locks
Reviewed-by: sla, dholmes

! src/share/vm/runtime/mutexLocker.cpp


From gary.collins at oracle.com  Tue May 14 11:21:48 2013
From: gary.collins at oracle.com (Gary Collins)
Date: Tue, 14 May 2013 11:21:48 -0700
Subject: RFR: Backports of 7115383, 8009152
Message-ID: <A1FA16F8-D341-4EE7-9EF9-B5B18A9A9A68@oracle.com>

RFR: Backports of 7115383, 8009152

These changes have been in 8 for a few months now. Just a simple backport of said changes to 7. 
The original request was for said changes to go into 7. This is the final task to make that happen.

8009152: A number of jtreg tests need review/improvement
7115383: TEST_BUG: some jtreg tests fail because they explicitly specify -server option

Combined webrev 
http://cr.openjdk.java.net/~collins/7115383-8009152-open/webrev/
Original 8: 
http://cr.openjdk.java.net/~collins/7115383/webrev.00/
http://cr.openjdk.java.net/~collins/8009152/webrev-01/

Thanks
Gary

From christian.thalinger at oracle.com  Tue May 14 11:45:11 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Tue, 14 May 2013 11:45:11 -0700
Subject: RFR: Backports of 7115383, 8009152
In-Reply-To: <A1FA16F8-D341-4EE7-9EF9-B5B18A9A9A68@oracle.com>
References: <A1FA16F8-D341-4EE7-9EF9-B5B18A9A9A68@oracle.com>
Message-ID: <B51AEF99-AFD6-413E-A124-57F8139931A9@oracle.com>


On May 14, 2013, at 11:21 AM, Gary Collins <gary.collins at oracle.com> wrote:

> RFR: Backports of 7115383, 8009152

Backports to HS24?  Then you need to send a request for approval to jdk7u-dev.

-- Chris

> 
> These changes have been in 8 for a few months now. Just a simple backport of said changes to 7. 
> The original request was for said changes to go into 7. This is the final task to make that happen.
> 
> 8009152: A number of jtreg tests need review/improvement
> 7115383: TEST_BUG: some jtreg tests fail because they explicitly specify -server option
> 
> Combined webrev 
> http://cr.openjdk.java.net/~collins/7115383-8009152-open/webrev/
> Original 8: 
> http://cr.openjdk.java.net/~collins/7115383/webrev.00/
> http://cr.openjdk.java.net/~collins/8009152/webrev-01/
> 
> Thanks
> Gary


From vladimir.kozlov at oracle.com  Tue May 14 12:18:58 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Tue, 14 May 2013 12:18:58 -0700
Subject: RFR: Backports of 7115383, 8009152
In-Reply-To: <B51AEF99-AFD6-413E-A124-57F8139931A9@oracle.com>
References: <A1FA16F8-D341-4EE7-9EF9-B5B18A9A9A68@oracle.com>
	<B51AEF99-AFD6-413E-A124-57F8139931A9@oracle.com>
Message-ID: <51928E22.6000002@oracle.com>

On 5/14/13 11:45 AM, Christian Thalinger wrote:
>
> On May 14, 2013, at 11:21 AM, Gary Collins <gary.collins at oracle.com> wrote:
>
>> RFR: Backports of 7115383, 8009152
>
> Backports to HS24?  Then you need to send a request for approval to jdk7u-dev.

Why? We still can push fixes into hs24 without approval. And this is 
tests only fix. I don't see the problem with pushing it into hs24.

Vladimir

>
> -- Chris
>
>>
>> These changes have been in 8 for a few months now. Just a simple backport of said changes to 7.
>> The original request was for said changes to go into 7. This is the final task to make that happen.
>>
>> 8009152: A number of jtreg tests need review/improvement
>> 7115383: TEST_BUG: some jtreg tests fail because they explicitly specify -server option
>>
>> Combined webrev
>> http://cr.openjdk.java.net/~collins/7115383-8009152-open/webrev/
>> Original 8:
>> http://cr.openjdk.java.net/~collins/7115383/webrev.00/
>> http://cr.openjdk.java.net/~collins/8009152/webrev-01/
>>
>> Thanks
>> Gary
>

From vladimir.kozlov at oracle.com  Tue May 14 12:23:18 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Tue, 14 May 2013 12:23:18 -0700
Subject: RFR: Backports of 7115383, 8009152
In-Reply-To: <A1FA16F8-D341-4EE7-9EF9-B5B18A9A9A68@oracle.com>
References: <A1FA16F8-D341-4EE7-9EF9-B5B18A9A9A68@oracle.com>
Message-ID: <51928F26.5070609@oracle.com>

Changes are fine. I assume you will do separate changesets for 8009152 
and 7115383. We need to preserve consistence with jdk8 and in bugs reports.

Thanks,
Vladimir

On 5/14/13 11:21 AM, Gary Collins wrote:
> RFR: Backports of 7115383, 8009152
>
> These changes have been in 8 for a few months now. Just a simple backport of said changes to 7.
> The original request was for said changes to go into 7. This is the final task to make that happen.
>
> 8009152: A number of jtreg tests need review/improvement
> 7115383: TEST_BUG: some jtreg tests fail because they explicitly specify -server option
>
> Combined webrev
> http://cr.openjdk.java.net/~collins/7115383-8009152-open/webrev/
> Original 8:
> http://cr.openjdk.java.net/~collins/7115383/webrev.00/
> http://cr.openjdk.java.net/~collins/8009152/webrev-01/
>
> Thanks
> Gary
>

From vladimir.kozlov at oracle.com  Tue May 14 12:27:26 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Tue, 14 May 2013 12:27:26 -0700
Subject: RFR: Backports of 7115383, 8009152
In-Reply-To: <51928F26.5070609@oracle.com>
References: <A1FA16F8-D341-4EE7-9EF9-B5B18A9A9A68@oracle.com>
	<51928F26.5070609@oracle.com>
Message-ID: <5192901E.30002@oracle.com>

Actually it is not fine. I don't see new test_env.sh from 8009152.

Vladimir

On 5/14/13 12:23 PM, Vladimir Kozlov wrote:
> Changes are fine. I assume you will do separate changesets for 8009152
> and 7115383. We need to preserve consistence with jdk8 and in bugs reports.
>
> Thanks,
> Vladimir
>
> On 5/14/13 11:21 AM, Gary Collins wrote:
>> RFR: Backports of 7115383, 8009152
>>
>> These changes have been in 8 for a few months now. Just a simple
>> backport of said changes to 7.
>> The original request was for said changes to go into 7. This is the
>> final task to make that happen.
>>
>> 8009152: A number of jtreg tests need review/improvement
>> 7115383: TEST_BUG: some jtreg tests fail because they explicitly
>> specify -server option
>>
>> Combined webrev
>> http://cr.openjdk.java.net/~collins/7115383-8009152-open/webrev/
>> Original 8:
>> http://cr.openjdk.java.net/~collins/7115383/webrev.00/
>> http://cr.openjdk.java.net/~collins/8009152/webrev-01/
>>
>> Thanks
>> Gary
>>

From christian.thalinger at oracle.com  Tue May 14 13:07:47 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Tue, 14 May 2013 13:07:47 -0700
Subject: RFR: Backports of 7115383, 8009152
In-Reply-To: <B51AEF99-AFD6-413E-A124-57F8139931A9@oracle.com>
References: <A1FA16F8-D341-4EE7-9EF9-B5B18A9A9A68@oracle.com>
	<B51AEF99-AFD6-413E-A124-57F8139931A9@oracle.com>
Message-ID: <131DED2E-25A5-45E7-AA51-995C9C6B59E4@oracle.com>


On May 14, 2013, at 11:45 AM, Christian Thalinger <christian.thalinger at oracle.com> wrote:

> 
> On May 14, 2013, at 11:21 AM, Gary Collins <gary.collins at oracle.com> wrote:
> 
>> RFR: Backports of 7115383, 8009152
> 
> Backports to HS24?  Then you need to send a request for approval to jdk7u-dev.

Scratch that.  I forgot that we do bulk integrations now.

-- Chris

> 
> -- Chris
> 
>> 
>> These changes have been in 8 for a few months now. Just a simple backport of said changes to 7. 
>> The original request was for said changes to go into 7. This is the final task to make that happen.
>> 
>> 8009152: A number of jtreg tests need review/improvement
>> 7115383: TEST_BUG: some jtreg tests fail because they explicitly specify -server option
>> 
>> Combined webrev 
>> http://cr.openjdk.java.net/~collins/7115383-8009152-open/webrev/
>> Original 8: 
>> http://cr.openjdk.java.net/~collins/7115383/webrev.00/
>> http://cr.openjdk.java.net/~collins/8009152/webrev-01/
>> 
>> Thanks
>> Gary
> 


From dennis.ushakov at gmail.com  Tue May 14 13:44:05 2013
From: dennis.ushakov at gmail.com (=?utf-8?B?0JTQtdC90LjRgSDQo9GI0LDQutC+0LI=?=)
Date: Wed, 15 May 2013 00:44:05 +0400
Subject: Mac OS X System.nanoTime Improvements
Message-ID: <07737C80-8B23-4DE2-83B9-E59E49638DB7@gmail.com>

Hi,

couple of days ago Aleksey Shipilev mentioned that System.nanoTime() is very slow on OS X and is non-monotonic. After some research I found that there's no clock_gettime() function in OS X and current implementation falls back to gettimeofday().

OS X provides a monotonic clock function mach_absolute_time(). According to documentation (https://developer.apple.com/library/mac/#qa/qa1398/_index.html) it can be converted to nanoseconds using results of mach_timebase_info().

Here's draft patch that uses mach_absolute_time() to provide fast and monotonic System.nanoTime() for OS X:
https://gist.github.com/denofevil/db57fa547510b2dd87fd

You can find benchmark written by Aleksey Shipilev here: https://github.com/shipilev/jmh-nanotime.
Benchmark results with system specs: https://gist.github.com/denofevil/5026294ee6de42699b41

Thanks,
Dennis

From aleksey.shipilev at oracle.com  Tue May 14 13:53:02 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Wed, 15 May 2013 00:53:02 +0400
Subject: Mac OS X System.nanoTime Improvements
In-Reply-To: <07737C80-8B23-4DE2-83B9-E59E49638DB7@gmail.com>
References: <07737C80-8B23-4DE2-83B9-E59E49638DB7@gmail.com>
Message-ID: <5192A42E.7050406@oracle.com>

Welcome to OpenJDK, Dennis!

On 05/15/2013 12:44 AM, ????? ?????? wrote:
> couple of days ago Aleksey Shipilev mentioned that System.nanoTime() 
> is very slow on OS X and is non-monotonic.

Correction: it is monotonic. It's just not monotonically *increasing*,
because the granularity is around 1us.

> OS X provides a monotonic clock function mach_absolute_time(). 
> According to documentation 
> (https://developer.apple.com/library/mac/#qa/qa1398/_index.html) it 
> can be converted to nanoseconds using results of 
> mach_timebase_info().

Any clue how this performs with the CPU power management interventions?

> Here's draft patch that uses mach_absolute_time() to provide fast
> and monotonic System.nanoTime() for OS X: 
> https://gist.github.com/denofevil/db57fa547510b2dd87fd

While others can have the proper review done, there are couple of steps
required to contribute the code to OpenJDK:
  http://openjdk.java.net/contribute/

At least two things:
  a) Signed OCA
  b) Webrev/hg patch for the changeset

> You can find benchmark written by Aleksey Shipilev here: 
> https://github.com/shipilev/jmh-nanotime. Benchmark results with 
> system specs: https://gist.github.com/denofevil/5026294ee6de42699b41

These *are* impressive. These granularities are actually on-par with my
bleeding edge Linux/OpenJDK.

Thanks,
Aleksey.

From dennis.ushakov at gmail.com  Tue May 14 14:35:27 2013
From: dennis.ushakov at gmail.com (Dennis Ushakov)
Date: Wed, 15 May 2013 01:35:27 +0400
Subject: Mac OS X System.nanoTime Improvements
In-Reply-To: <5192A42E.7050406@oracle.com>
References: <07737C80-8B23-4DE2-83B9-E59E49638DB7@gmail.com>
	<5192A42E.7050406@oracle.com>
Message-ID: <25440C53-F548-481C-A59A-C3915BEE94D1@gmail.com>


On May 15, 2013, at 12:53 AM, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
> Any clue how this performs with the CPU power management interventions?
Unfortunately documentation on these functions is very sparse, only topic except usage example says that mach_absolute_time() is absolute time value for current wall clock time in units (https://developer.apple.com/library/mac/#documentation/Darwin/Conceptual/KernelProgramming/services/services.html#//apple_ref/doc/uid/TP30000905-CH219-CHDGFEFE, Handling Version Dependencies section)

Thanks,
Dennis

From gary.collins at oracle.com  Tue May 14 15:08:53 2013
From: gary.collins at oracle.com (Gary Collins)
Date: Tue, 14 May 2013 15:08:53 -0700
Subject: RFR: Backports of 7115383, 8009152
In-Reply-To: <A1FA16F8-D341-4EE7-9EF9-B5B18A9A9A68@oracle.com>
References: <A1FA16F8-D341-4EE7-9EF9-B5B18A9A9A68@oracle.com>
Message-ID: <BE98E736-8353-4B09-9124-FB3D0C7A4074@oracle.com>

Thanks Vlad,  

Something happened with webrev with test_env.sh file missing.
Appears latest webrev below will now show all the correct files.

http://cr.openjdk.java.net/~collins/7115383-8009152-open/webrev-01/

Thanks
Gary
On May 14, 2013, at 11:21 AM, Gary Collins wrote:

> RFR: Backports of 7115383, 8009152 to hsx24
> 
> These changes have been in 8 for a few months now. Just a simple backport of said changes to 7. 
> The original request was for said changes to go into 7/hsx24. This is the final task to make that happen.
> 
> 8009152: A number of jtreg tests need review/improvement
> 7115383: TEST_BUG: some jtreg tests fail because they explicitly specify -server option
> 
> Combined webrev 
> http://cr.openjdk.java.net/~collins/7115383-8009152-open/webrev-01/
> Original 8: 
> http://cr.openjdk.java.net/~collins/7115383/webrev.00/
> http://cr.openjdk.java.net/~collins/8009152/webrev-01/
> 
> Thanks
> Gary


From vladimir.kozlov at oracle.com  Tue May 14 15:16:03 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Tue, 14 May 2013 15:16:03 -0700
Subject: RFR: Backports of 7115383, 8009152
In-Reply-To: <BE98E736-8353-4B09-9124-FB3D0C7A4074@oracle.com>
References: <A1FA16F8-D341-4EE7-9EF9-B5B18A9A9A68@oracle.com>
	<BE98E736-8353-4B09-9124-FB3D0C7A4074@oracle.com>
Message-ID: <5192B7A3.6010606@oracle.com>

Looks good.

Thanks,
Vladimir

On 5/14/13 3:08 PM, Gary Collins wrote:
> Thanks Vlad,
>
> Something happened with webrev with test_env.sh file missing.
> Appears latest webrev below will now show all the correct files.
>
> http://cr.openjdk.java.net/~collins/7115383-8009152-open/webrev-01/
>
> Thanks
> Gary
> On May 14, 2013, at 11:21 AM, Gary Collins wrote:
>
>> RFR: Backports of 7115383, 8009152 to hsx24
>>
>> These changes have been in 8 for a few months now. Just a simple backport of said changes to 7.
>> The original request was for said changes to go into 7/hsx24. This is the final task to make that happen.
>>
>> 8009152: A number of jtreg tests need review/improvement
>> 7115383: TEST_BUG: some jtreg tests fail because they explicitly specify -server option
>>
>> Combined webrev
>> http://cr.openjdk.java.net/~collins/7115383-8009152-open/webrev-01/
>> Original 8:
>> http://cr.openjdk.java.net/~collins/7115383/webrev.00/
>> http://cr.openjdk.java.net/~collins/8009152/webrev-01/
>>
>> Thanks
>> Gary
>

From aleksey.shipilev at oracle.com  Tue May 14 15:24:27 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Wed, 15 May 2013 02:24:27 +0400
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
Message-ID: <5192B99B.50405@oracle.com>

Hi,

It seems we have a plenty of failures in new SQE tests for @Contended
because of this. Please see the updated webrev for the issue:
  http://cr.openjdk.java.net/~shade/8012939/webrev.01/

This is the minimal fix. Most of the instance_size calculations use
first_nonstatic_field_offset as the boundary for the instance fields
block. @Contended on the class hijacks this boundary with padding, and
so the instance size is incorrect (also evidenced by the wrong assert).

There is also a more thorough clean up of that code:
  http://cr.openjdk.java.net/~shade/8012939/webrev.02/

...which is makes the intent cleaner. I can submit another RFE for that
cleanup, although I think it prunes the source of the original
confusion. Speak up if you want me to split these, and we push the
webrev.01 alone then.

Testing:
  - 8003985 and 8012939 tests on Linux x86_64/fastdebug
  - JPRT run for both webrevs

Thanks,
Aleksey.

From vladimir.kozlov at oracle.com  Tue May 14 16:24:41 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Tue, 14 May 2013 16:24:41 -0700
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <5192B99B.50405@oracle.com>
References: <5192B99B.50405@oracle.com>
Message-ID: <5192C7B9.6060902@oracle.com>

On 5/14/13 3:24 PM, Aleksey Shipilev wrote:
> Hi,
>
> It seems we have a plenty of failures in new SQE tests for @Contended
> because of this. Please see the updated webrev for the issue:
>    http://cr.openjdk.java.net/~shade/8012939/webrev.01/
>
> This is the minimal fix. Most of the instance_size calculations use
> first_nonstatic_field_offset as the boundary for the instance fields
> block. @Contended on the class hijacks this boundary with padding, and
> so the instance size is incorrect (also evidenced by the wrong assert).
>
> There is also a more thorough clean up of that code:
>    http://cr.openjdk.java.net/~shade/8012939/webrev.02/

I am fine with this version of the fix. But I would suggest more :) 
renaming. first_nonstatic_field_offset is not actually pointing to first 
nonstatic field, next_nonstatic_field_offset may point to it (it will 
not point to it if first field is contended (double padding)). Note that 
next_nonstatic_field_offset is not modified after we added pad to it. I 
am suggesting to rename first_nonstatic_field_offset to 
nonstatic_fields_start and next_nonstatic_field_offset to 
first_nonstatic_field_offset.

Also I think new variables names instead of aligned_*_offset should be:

  nonstatic_fields_end
  static_fields_end
  instance_end

Thanks,
Vladimir

>
> ...which is makes the intent cleaner. I can submit another RFE for that
> cleanup, although I think it prunes the source of the original
> confusion. Speak up if you want me to split these, and we push the
> webrev.01 alone then.
>
> Testing:
>    - 8003985 and 8012939 tests on Linux x86_64/fastdebug
>    - JPRT run for both webrevs
>
> Thanks,
> Aleksey.
>

From david.holmes at oracle.com  Tue May 14 20:00:09 2013
From: david.holmes at oracle.com (David Holmes)
Date: Wed, 15 May 2013 13:00:09 +1000
Subject: Mac OS X System.nanoTime Improvements
In-Reply-To: <07737C80-8B23-4DE2-83B9-E59E49638DB7@gmail.com>
References: <07737C80-8B23-4DE2-83B9-E59E49638DB7@gmail.com>
Message-ID: <5192FA39.5020804@oracle.com>

On 15/05/2013 6:44 AM, ????? ?????? wrote:
> Hi,
>
> couple of days ago Aleksey Shipilev mentioned that System.nanoTime() is very slow on OS X and is non-monotonic. After some research I found that there's no clock_gettime() function in OS X and current implementation falls back to gettimeofday().

Wow! If that is the case that is truly horrible and the OSX porters 
should have been aware of that and flagged it. :( A nanoTime() based on 
gettimeofday would not be monotonic if ntp adjustments are being made.

> OS X provides a monotonic clock function mach_absolute_time(). According to documentation (https://developer.apple.com/library/mac/#qa/qa1398/_index.html) it can be converted to nanoseconds using results of mach_timebase_info().

We need to know more about how this works, and in particular whether it 
is using the TSC and so is subject to the well known problems using the 
TSC as a "clock" base. The API sounds similar to that on Windows: 
QueryPerformanceCounter + QueryPerformanceFrequency.

Thanks,
David
-----

> Here's draft patch that uses mach_absolute_time() to provide fast and monotonic System.nanoTime() for OS X:
> https://gist.github.com/denofevil/db57fa547510b2dd87fd
>
> You can find benchmark written by Aleksey Shipilev here: https://github.com/shipilev/jmh-nanotime.
> Benchmark results with system specs: https://gist.github.com/denofevil/5026294ee6de42699b41
>
> Thanks,
> Dennis
>

From staffan.larsen at oracle.com  Tue May 14 22:46:37 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Wed, 15 May 2013 07:46:37 +0200
Subject: Mac OS X System.nanoTime Improvements
In-Reply-To: <5192FA39.5020804@oracle.com>
References: <07737C80-8B23-4DE2-83B9-E59E49638DB7@gmail.com>
	<5192FA39.5020804@oracle.com>
Message-ID: <8BF7FD34-5861-4D5C-9809-25FD03DA8F1D@oracle.com>


On 15 maj 2013, at 05:00, David Holmes <David.Holmes at oracle.com> wrote:

> On 15/05/2013 6:44 AM, ????? ?????? wrote:
>> Hi,
>> 
>> couple of days ago Aleksey Shipilev mentioned that System.nanoTime() is very slow on OS X and is non-monotonic. After some research I found that there's no clock_gettime() function in OS X and current implementation falls back to gettimeofday().
> 
> Wow! If that is the case that is truly horrible and the OSX porters should have been aware of that and flagged it. :( A nanoTime() based on gettimeofday would not be monotonic if ntp adjustments are being made.

There is this little "flag" in the source, but I can't find a bug report for it.

#ifdef __APPLE__
void os::Bsd::clock_init() {
        // XXXDARWIN: Investigate replacement monotonic clock
}
#else


/Staffan

> 
>> OS X provides a monotonic clock function mach_absolute_time(). According to documentation (https://developer.apple.com/library/mac/#qa/qa1398/_index.html) it can be converted to nanoseconds using results of mach_timebase_info().
> 
> We need to know more about how this works, and in particular whether it is using the TSC and so is subject to the well known problems using the TSC as a "clock" base. The API sounds similar to that on Windows: QueryPerformanceCounter + QueryPerformanceFrequency.
> 
> Thanks,
> David
> -----
> 
>> Here's draft patch that uses mach_absolute_time() to provide fast and monotonic System.nanoTime() for OS X:
>> https://gist.github.com/denofevil/db57fa547510b2dd87fd
>> 
>> You can find benchmark written by Aleksey Shipilev here: https://github.com/shipilev/jmh-nanotime.
>> Benchmark results with system specs: https://gist.github.com/denofevil/5026294ee6de42699b41
>> 
>> Thanks,
>> Dennis
>> 


From thomas.schatzl at oracle.com  Wed May 15 00:14:32 2013
From: thomas.schatzl at oracle.com (Thomas Schatzl)
Date: Wed, 15 May 2013 09:14:32 +0200
Subject: Mac OS X System.nanoTime Improvements
In-Reply-To: <25440C53-F548-481C-A59A-C3915BEE94D1@gmail.com>
References: <07737C80-8B23-4DE2-83B9-E59E49638DB7@gmail.com>
	<5192A42E.7050406@oracle.com>
	<25440C53-F548-481C-A59A-C3915BEE94D1@gmail.com>
Message-ID: <1368602072.2676.4.camel@cirrus>

Hi all,

On Wed, 2013-05-15 at 01:35 +0400, Dennis Ushakov wrote:
> On May 15, 2013, at 12:53 AM, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
> > Any clue how this performs with the CPU power management interventions?
> Unfortunately documentation on these functions is very sparse, only topic except usage example says that mach_absolute_time() is absolute time value for current wall clock time in units (https://developer.apple.com/library/mac/#documentation/Darwin/Conceptual/KernelProgramming/services/services.html#//apple_ref/doc/uid/TP30000905-CH219-CHDGFEFE, Handling Version Dependencies section)

One alternative (not sure if already considered) is clock_get_time()
with the SYSTEM_CLOCK clock.
(http://web.mit.edu/darwin/src/modules/xnu/osfmk/man/clock_get_time.html)

It is guaranteed to be increasing and monotonic according to the source
(http://opensource.apple.com/source/xnu/xnu-344.2/osfmk/mach/clock_types.h)

It's precision is nanoseconds, don't know about accuracy or how fast the
call(s) are.

Maybe this helps,
Thomas



From aleksey.shipilev at oracle.com  Wed May 15 00:19:04 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Wed, 15 May 2013 11:19:04 +0400
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <5192C7B9.6060902@oracle.com>
References: <5192B99B.50405@oracle.com> <5192C7B9.6060902@oracle.com>
Message-ID: <519336E8.9000101@oracle.com>

On 05/15/2013 03:24 AM, Vladimir Kozlov wrote:
> On 5/14/13 3:24 PM, Aleksey Shipilev wrote:
>> Hi,
>>
>> It seems we have a plenty of failures in new SQE tests for @Contended
>> because of this. Please see the updated webrev for the issue:
>>    http://cr.openjdk.java.net/~shade/8012939/webrev.01/
>>
>> This is the minimal fix. Most of the instance_size calculations use
>> first_nonstatic_field_offset as the boundary for the instance fields
>> block. @Contended on the class hijacks this boundary with padding, and
>> so the instance size is incorrect (also evidenced by the wrong assert).
>>
>> There is also a more thorough clean up of that code:
>>    http://cr.openjdk.java.net/~shade/8012939/webrev.02/
> 
> I am fine with this version of the fix. But I would suggest more :)
> renaming. 

Sorry, but this will complicate the patch beyond graspable. Let's commit
the minimal fix, and work on the refactoring in the separate issue:
  http://cr.openjdk.java.net/~shade/8012939/webrev.01/

-Aleksey.

From aleksey.shipilev at oracle.com  Wed May 15 00:22:50 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Wed, 15 May 2013 11:22:50 +0400
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <519336E8.9000101@oracle.com>
References: <5192B99B.50405@oracle.com> <5192C7B9.6060902@oracle.com>
	<519336E8.9000101@oracle.com>
Message-ID: <519337CA.9020403@oracle.com>

On 05/15/2013 11:19 AM, Aleksey Shipilev wrote:
> On 05/15/2013 03:24 AM, Vladimir Kozlov wrote:
>> On 5/14/13 3:24 PM, Aleksey Shipilev wrote:
>>> Hi,
>>>
>>> It seems we have a plenty of failures in new SQE tests for @Contended
>>> because of this. Please see the updated webrev for the issue:
>>>    http://cr.openjdk.java.net/~shade/8012939/webrev.01/
>>>
>>> This is the minimal fix. Most of the instance_size calculations use
>>> first_nonstatic_field_offset as the boundary for the instance fields
>>> block. @Contended on the class hijacks this boundary with padding, and
>>> so the instance size is incorrect (also evidenced by the wrong assert).
>>>
>>> There is also a more thorough clean up of that code:
>>>    http://cr.openjdk.java.net/~shade/8012939/webrev.02/
>>
>> I am fine with this version of the fix. But I would suggest more :)
>> renaming. 
> 
> Sorry, but this will complicate the patch beyond graspable. Let's commit
> the minimal fix, and work on the refactoring in the separate issue:
>   http://cr.openjdk.java.net/~shade/8012939/webrev.01/

To reiterate, this is *the* critical patch, and we desperately need this
in the code. We had already wasted two weeks waiting for reviews, and I
don't want this to drag along any further.

-Aleksey.


From staffan.larsen at oracle.com  Wed May 15 00:27:27 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Wed, 15 May 2013 09:27:27 +0200
Subject: Mac OS X System.nanoTime Improvements
In-Reply-To: <5192FA39.5020804@oracle.com>
References: <07737C80-8B23-4DE2-83B9-E59E49638DB7@gmail.com>
	<5192FA39.5020804@oracle.com>
Message-ID: <E27762AD-E4CC-4A5E-A3B1-9855CF829499@oracle.com>


On 15 maj 2013, at 05:00, David Holmes <David.Holmes at oracle.com> wrote:

> On 15/05/2013 6:44 AM, ????? ?????? wrote:
>> Hi,
>> 
>> couple of days ago Aleksey Shipilev mentioned that System.nanoTime() is very slow on OS X and is non-monotonic. After some research I found that there's no clock_gettime() function in OS X and current implementation falls back to gettimeofday().
> 
> Wow! If that is the case that is truly horrible and the OSX porters should have been aware of that and flagged it. :( A nanoTime() based on gettimeofday would not be monotonic if ntp adjustments are being made.
> 
>> OS X provides a monotonic clock function mach_absolute_time(). According to documentation (https://developer.apple.com/library/mac/#qa/qa1398/_index.html) it can be converted to nanoseconds using results of mach_timebase_info().
> 
> We need to know more about how this works, and in particular whether it is using the TSC and so is subject to the well known problems using the TSC as a "clock" base. The API sounds similar to that on Windows: QueryPerformanceCounter + QueryPerformanceFrequency.

The source is browsable here:

mach_absolute_time:
http://www.opensource.apple.com/source/xnu/xnu-2050.22.13/osfmk/i386/rtclock.c

_rtc_nanotime_read:
http://www.opensource.apple.com/source/xnu/xnu-2050.22.13/osfmk/x86_64/machine_routines_asm.s

PAL_RTC_NANOTIME_READ_FAST:
http://www.opensource.apple.com/source/xnu/xnu-2050.22.13/osfmk/i386/rtclock_asm_native.h


/Staffan


> 
> Thanks,
> David
> -----
> 
>> Here's draft patch that uses mach_absolute_time() to provide fast and monotonic System.nanoTime() for OS X:
>> https://gist.github.com/denofevil/db57fa547510b2dd87fd
>> 
>> You can find benchmark written by Aleksey Shipilev here: https://github.com/shipilev/jmh-nanotime.
>> Benchmark results with system specs: https://gist.github.com/denofevil/5026294ee6de42699b41
>> 
>> Thanks,
>> Dennis
>> 


From staffan.larsen at oracle.com  Wed May 15 00:31:46 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Wed, 15 May 2013 09:31:46 +0200
Subject: Mac OS X System.nanoTime Improvements
In-Reply-To: <1368602072.2676.4.camel@cirrus>
References: <07737C80-8B23-4DE2-83B9-E59E49638DB7@gmail.com>
	<5192A42E.7050406@oracle.com>
	<25440C53-F548-481C-A59A-C3915BEE94D1@gmail.com>
	<1368602072.2676.4.camel@cirrus>
Message-ID: <AE594487-651F-4CB2-B1A4-501B67ED7306@oracle.com>


On 15 maj 2013, at 09:14, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:

> Hi all,
> 
> On Wed, 2013-05-15 at 01:35 +0400, Dennis Ushakov wrote:
>> On May 15, 2013, at 12:53 AM, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
>>> Any clue how this performs with the CPU power management interventions?
>> Unfortunately documentation on these functions is very sparse, only topic except usage example says that mach_absolute_time() is absolute time value for current wall clock time in units (https://developer.apple.com/library/mac/#documentation/Darwin/Conceptual/KernelProgramming/services/services.html#//apple_ref/doc/uid/TP30000905-CH219-CHDGFEFE, Handling Version Dependencies section)
> 
> One alternative (not sure if already considered) is clock_get_time()
> with the SYSTEM_CLOCK clock.
> (http://web.mit.edu/darwin/src/modules/xnu/osfmk/man/clock_get_time.html)
> 
> It is guaranteed to be increasing and monotonic according to the source
> (http://opensource.apple.com/source/xnu/xnu-344.2/osfmk/mach/clock_types.h)

That file has the following notice in it:

/*
 * N.B. This interface has been deprecated and the contents
 * of this file should be considered obsolete.
 */

/Staffan


> 
> It's precision is nanoseconds, don't know about accuracy or how fast the
> call(s) are.
> 
> Maybe this helps,
> Thomas
> 
> 


From david.holmes at oracle.com  Wed May 15 01:17:16 2013
From: david.holmes at oracle.com (David Holmes)
Date: Wed, 15 May 2013 18:17:16 +1000
Subject: Mac OS X System.nanoTime Improvements
In-Reply-To: <E27762AD-E4CC-4A5E-A3B1-9855CF829499@oracle.com>
References: <07737C80-8B23-4DE2-83B9-E59E49638DB7@gmail.com>
	<5192FA39.5020804@oracle.com>
	<E27762AD-E4CC-4A5E-A3B1-9855CF829499@oracle.com>
Message-ID: <5193448C.3070905@oracle.com>

On 15/05/2013 5:27 PM, Staffan Larsen wrote:
>
> On 15 maj 2013, at 05:00, David Holmes <David.Holmes at oracle.com> wrote:
>
>> On 15/05/2013 6:44 AM, ????? ?????? wrote:
>>> Hi,
>>>
>>> couple of days ago Aleksey Shipilev mentioned that System.nanoTime() is very slow on OS X and is non-monotonic. After some research I found that there's no clock_gettime() function in OS X and current implementation falls back to gettimeofday().
>>
>> Wow! If that is the case that is truly horrible and the OSX porters should have been aware of that and flagged it. :( A nanoTime() based on gettimeofday would not be monotonic if ntp adjustments are being made.
>>
>>> OS X provides a monotonic clock function mach_absolute_time(). According to documentation (https://developer.apple.com/library/mac/#qa/qa1398/_index.html) it can be converted to nanoseconds using results of mach_timebase_info().
>>
>> We need to know more about how this works, and in particular whether it is using the TSC and so is subject to the well known problems using the TSC as a "clock" base. The API sounds similar to that on Windows: QueryPerformanceCounter + QueryPerformanceFrequency.
>
> The source is browsable here:
>
> mach_absolute_time:
> http://www.opensource.apple.com/source/xnu/xnu-2050.22.13/osfmk/i386/rtclock.c

Thanks Staffan - looks like it is a completely naive implementation that 
doesn't recognize the frequency slew you can get, nor that the TSC is 
unsynchronized across multiple processors. Maybe they don't run with any 
kind of frequency scaling enabled? And maybe they use some kind of 
external synchronization driver (like AMD had for Windows?). But I'm 
somewhat doubtful that is the case.

David
-----

> _rtc_nanotime_read:
> http://www.opensource.apple.com/source/xnu/xnu-2050.22.13/osfmk/x86_64/machine_routines_asm.s
>
> PAL_RTC_NANOTIME_READ_FAST:
> http://www.opensource.apple.com/source/xnu/xnu-2050.22.13/osfmk/i386/rtclock_asm_native.h
>
>
> /Staffan
>
>
>>
>> Thanks,
>> David
>> -----
>>
>>> Here's draft patch that uses mach_absolute_time() to provide fast and monotonic System.nanoTime() for OS X:
>>> https://gist.github.com/denofevil/db57fa547510b2dd87fd
>>>
>>> You can find benchmark written by Aleksey Shipilev here: https://github.com/shipilev/jmh-nanotime.
>>> Benchmark results with system specs: https://gist.github.com/denofevil/5026294ee6de42699b41
>>>
>>> Thanks,
>>> Dennis
>>>
>

From bengt.rutisson at oracle.com  Wed May 15 01:22:55 2013
From: bengt.rutisson at oracle.com (Bengt Rutisson)
Date: Wed, 15 May 2013 10:22:55 +0200
Subject: CFV: New hsx Committer: Thomas Schatzl
Message-ID: <519345DF.2030207@oracle.com>

I hereby nominate Thomas Schatzl to hsx Committer.

Thomas joined the HotSpot garbage collection team at Oracle earlier this year. Thomas has been active in HotSpot development for several years before starting at Oracle. He has contributed 2 changesets [1,2] before starting Oracle and 7 more since he joined the GC team [3].

Votes are due by Thu, May 29, 2013 11:00am CEST.

Only current hsx Committers [4] are eligible to vote on this
nomination.  Votes must be cast in the open by replying to to this
mailing list.

For Lazy Consensus voting instructions, see [5].

Bengt Rutisson

[1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/db823a892a55
[2] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7994a5a35fcf
[3] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tschatzl
[4]http://openjdk.java.net/census/#hsx
[5]http://openjdk.java.net/projects/#committer-vote


From staffan.larsen at oracle.com  Wed May 15 01:43:26 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Wed, 15 May 2013 10:43:26 +0200
Subject: CFV: New hsx Committer: Thomas Schatzl
In-Reply-To: <519345DF.2030207@oracle.com>
References: <519345DF.2030207@oracle.com>
Message-ID: <1B88CAEF-773F-4495-909D-C3DE7DDFDE1D@oracle.com>

Vote: yes.

/Staffan

On 15 maj 2013, at 10:22, Bengt Rutisson <bengt.rutisson at oracle.com> wrote:

> I hereby nominate Thomas Schatzl to hsx Committer.
> 
> Thomas joined the HotSpot garbage collection team at Oracle earlier this year. Thomas has been active in HotSpot development for several years before starting at Oracle. He has contributed 2 changesets [1,2] before starting Oracle and 7 more since he joined the GC team [3].
> 
> Votes are due by Thu, May 29, 2013 11:00am CEST.
> 
> Only current hsx Committers [4] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
> 
> For Lazy Consensus voting instructions, see [5].
> 
> Bengt Rutisson
> 
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/db823a892a55
> [2] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7994a5a35fcf
> [3] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tschatzl
> [4]http://openjdk.java.net/census/#hsx
> [5]http://openjdk.java.net/projects/#committer-vote
> 


From stefan.karlsson at oracle.com  Wed May 15 01:46:35 2013
From: stefan.karlsson at oracle.com (Stefan Karlsson)
Date: Wed, 15 May 2013 10:46:35 +0200
Subject: CFV: New hsx Committer: Thomas Schatzl
In-Reply-To: <519345DF.2030207@oracle.com>
References: <519345DF.2030207@oracle.com>
Message-ID: <51934B6B.6090705@oracle.com>

Vote: yes

StefanK

On 05/15/2013 10:22 AM, Bengt Rutisson wrote:
> I hereby nominate Thomas Schatzl to hsx Committer.
>
> Thomas joined the HotSpot garbage collection team at Oracle earlier 
> this year. Thomas has been active in HotSpot development for several 
> years before starting at Oracle. He has contributed 2 changesets [1,2] 
> before starting Oracle and 7 more since he joined the GC team [3].
>
> Votes are due by Thu, May 29, 2013 11:00am CEST.
>
> Only current hsx Committers [4] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [5].
>
> Bengt Rutisson
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/db823a892a55
> [2] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7994a5a35fcf
> [3] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tschatzl
> [4]http://openjdk.java.net/census/#hsx
> [5]http://openjdk.java.net/projects/#committer-vote
>


From rickard.backman at oracle.com  Wed May 15 01:55:43 2013
From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=)
Date: Wed, 15 May 2013 10:55:43 +0200
Subject: CFV: New hsx Committer: Thomas Schatzl
In-Reply-To: <519345DF.2030207@oracle.com>
References: <519345DF.2030207@oracle.com>
Message-ID: <DA74AB5A-1681-4DDB-A140-ECC395B18A9A@oracle.com>

Vote: yes

/R

On May 15, 2013, at 10:22 AM, Bengt Rutisson wrote:

> I hereby nominate Thomas Schatzl to hsx Committer.
> 
> Thomas joined the HotSpot garbage collection team at Oracle earlier this year. Thomas has been active in HotSpot development for several years before starting at Oracle. He has contributed 2 changesets [1,2] before starting Oracle and 7 more since he joined the GC team [3].
> 
> Votes are due by Thu, May 29, 2013 11:00am CEST.
> 
> Only current hsx Committers [4] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
> 
> For Lazy Consensus voting instructions, see [5].
> 
> Bengt Rutisson
> 
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/db823a892a55
> [2] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7994a5a35fcf
> [3] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tschatzl
> [4]http://openjdk.java.net/census/#hsx
> [5]http://openjdk.java.net/projects/#committer-vote
> 


From bengt.rutisson at oracle.com  Wed May 15 01:55:52 2013
From: bengt.rutisson at oracle.com (Bengt Rutisson)
Date: Wed, 15 May 2013 10:55:52 +0200
Subject: CFV: New hsx Committer: Thomas Schatzl
In-Reply-To: <519345DF.2030207@oracle.com>
References: <519345DF.2030207@oracle.com>
Message-ID: <51934D98.7080207@oracle.com>


Vote: yes

Also, the web interface for mercurial is not that great. If you are 
having problems finding Thomas' changesets maybe this list helps you:

http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/0a2986f36965
http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7a95933197d0
http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/d17700c82d7d
http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/cc5b5976d72c
http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/754c24457b20
http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/3c226052f7dc
http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/62609ffa2fc6
http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/db823a892a55
http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7994a5a35fcf

Thanks,
Bengt

On 5/15/13 10:22 AM, Bengt Rutisson wrote:
> I hereby nominate Thomas Schatzl to hsx Committer.
>
> Thomas joined the HotSpot garbage collection team at Oracle earlier 
> this year. Thomas has been active in HotSpot development for several 
> years before starting at Oracle. He has contributed 2 changesets [1,2] 
> before starting Oracle and 7 more since he joined the GC team [3].
>
> Votes are due by Thu, May 29, 2013 11:00am CEST.
>
> Only current hsx Committers [4] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [5].
>
> Bengt Rutisson
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/db823a892a55
> [2] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7994a5a35fcf
> [3] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tschatzl
> [4]http://openjdk.java.net/census/#hsx
> [5]http://openjdk.java.net/projects/#committer-vote
>


From mikael.gerdin at oracle.com  Wed May 15 01:58:30 2013
From: mikael.gerdin at oracle.com (Mikael Gerdin)
Date: Wed, 15 May 2013 10:58:30 +0200
Subject: CFV: New hsx Committer: Thomas Schatzl
In-Reply-To: <519345DF.2030207@oracle.com>
References: <519345DF.2030207@oracle.com>
Message-ID: <51934E36.3030808@oracle.com>

Vote: yes

/Mikael

On 05/15/2013 10:22 AM, Bengt Rutisson wrote:
> I hereby nominate Thomas Schatzl to hsx Committer.
>
> Thomas joined the HotSpot garbage collection team at Oracle earlier this
> year. Thomas has been active in HotSpot development for several years
> before starting at Oracle. He has contributed 2 changesets [1,2] before
> starting Oracle and 7 more since he joined the GC team [3].
>
> Votes are due by Thu, May 29, 2013 11:00am CEST.
>
> Only current hsx Committers [4] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [5].
>
> Bengt Rutisson
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/db823a892a55
> [2] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7994a5a35fcf
> [3] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tschatzl
> [4]http://openjdk.java.net/census/#hsx
> [5]http://openjdk.java.net/projects/#committer-vote
>


From vladimir.x.ivanov at oracle.com  Wed May 15 02:44:19 2013
From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov)
Date: Wed, 15 May 2013 13:44:19 +0400
Subject: CFV: New hsx Committer: Thomas Schatzl
In-Reply-To: <519345DF.2030207@oracle.com>
References: <519345DF.2030207@oracle.com>
Message-ID: <519358F3.3010802@oracle.com>

Vote: yes

Best regards,
Vladimir Ivanov

On 5/15/13 12:22 PM, Bengt Rutisson wrote:
> I hereby nominate Thomas Schatzl to hsx Committer.
>
> Thomas joined the HotSpot garbage collection team at Oracle earlier this
> year. Thomas has been active in HotSpot development for several years
> before starting at Oracle. He has contributed 2 changesets [1,2] before
> starting Oracle and 7 more since he joined the GC team [3].
>
> Votes are due by Thu, May 29, 2013 11:00am CEST.
>
> Only current hsx Committers [4] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [5].
>
> Bengt Rutisson
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/db823a892a55
> [2] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7994a5a35fcf
> [3] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tschatzl
> [4]http://openjdk.java.net/census/#hsx
> [5]http://openjdk.java.net/projects/#committer-vote
>

From rickard.backman at oracle.com  Wed May 15 04:10:55 2013
From: rickard.backman at oracle.com (rickard.backman at oracle.com)
Date: Wed, 15 May 2013 11:10:55 +0000
Subject: hg: hsx/hsx24/hotspot: 8014478: EnableTracing: output from multiple
	threads may be mixed together
Message-ID: <20130515111100.4C61648AB9@hg.openjdk.java.net>

Changeset: feb41fc13635
Author:    rbackman
Date:      2013-05-14 09:11 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/feb41fc13635

8014478: EnableTracing: output from multiple threads may be mixed together
Reviewed-by: dholmes, rbackman
Contributed-by: yunda.mly at taobao.com

! src/share/vm/runtime/globals.hpp
! src/share/vm/trace/traceEventClasses.xsl


From jesper.wilhelmsson at oracle.com  Wed May 15 04:29:44 2013
From: jesper.wilhelmsson at oracle.com (jesper.wilhelmsson at oracle.com)
Date: Wed, 15 May 2013 13:29:44 +0200
Subject: CFV: New hsx Committer: Thomas Schatzl
In-Reply-To: <519345DF.2030207@oracle.com>
References: <519345DF.2030207@oracle.com>
Message-ID: <AABBA813-9E2B-4414-9C22-437553DCD21E@oracle.com>

Vote: yes

/Jesper

15 maj 2013 kl. 10:22 skrev Bengt Rutisson <bengt.rutisson at oracle.com>:

> I hereby nominate Thomas Schatzl to hsx Committer.
> 
> Thomas joined the HotSpot garbage collection team at Oracle earlier this year. Thomas has been active in HotSpot development for several years before starting at Oracle. He has contributed 2 changesets [1,2] before starting Oracle and 7 more since he joined the GC team [3].
> 
> Votes are due by Thu, May 29, 2013 11:00am CEST.
> 
> Only current hsx Committers [4] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
> 
> For Lazy Consensus voting instructions, see [5].
> 
> Bengt Rutisson
> 
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/db823a892a55
> [2] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7994a5a35fcf
> [3] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tschatzl
> [4]http://openjdk.java.net/census/#hsx
> [5]http://openjdk.java.net/projects/#committer-vote
> 

From coleen.phillimore at oracle.com  Wed May 15 04:37:54 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Wed, 15 May 2013 07:37:54 -0400
Subject: CFV: New hsx Committer: Thomas Schatzl
In-Reply-To: <519345DF.2030207@oracle.com>
References: <519345DF.2030207@oracle.com>
Message-ID: <51937392.7070508@oracle.com>

Vote: yes

On 5/15/2013 4:22 AM, Bengt Rutisson wrote:
> I hereby nominate Thomas Schatzl to hsx Committer.
>
> Thomas joined the HotSpot garbage collection team at Oracle earlier 
> this year. Thomas has been active in HotSpot development for several 
> years before starting at Oracle. He has contributed 2 changesets [1,2] 
> before starting Oracle and 7 more since he joined the GC team [3].
>
> Votes are due by Thu, May 29, 2013 11:00am CEST.
>
> Only current hsx Committers [4] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [5].
>
> Bengt Rutisson
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/db823a892a55
> [2] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7994a5a35fcf
> [3] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tschatzl
> [4]http://openjdk.java.net/census/#hsx
> [5]http://openjdk.java.net/projects/#committer-vote
>


From erik.helin at oracle.com  Wed May 15 05:52:31 2013
From: erik.helin at oracle.com (Erik Helin)
Date: Wed, 15 May 2013 14:52:31 +0200
Subject: CFV: New hsx Committer: Thomas Schatzl
In-Reply-To: <519345DF.2030207@oracle.com>
References: <519345DF.2030207@oracle.com>
Message-ID: <5193850F.1040508@oracle.com>

Vote: yes

Erik

On 05/15/2013 10:22 AM, Bengt Rutisson wrote:
> I hereby nominate Thomas Schatzl to hsx Committer.
>
> Thomas joined the HotSpot garbage collection team at Oracle earlier this
> year. Thomas has been active in HotSpot development for several years
> before starting at Oracle. He has contributed 2 changesets [1,2] before
> starting Oracle and 7 more since he joined the GC team [3].
>
> Votes are due by Thu, May 29, 2013 11:00am CEST.
>
> Only current hsx Committers [4] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [5].
>
> Bengt Rutisson
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/db823a892a55
> [2] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7994a5a35fcf
> [3] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tschatzl
> [4]http://openjdk.java.net/census/#hsx
> [5]http://openjdk.java.net/projects/#committer-vote
>


From karen.kinnear at oracle.com  Wed May 15 06:42:37 2013
From: karen.kinnear at oracle.com (Karen Kinnear)
Date: Wed, 15 May 2013 09:42:37 -0400
Subject: CFV: New hsx Committer: Thomas Schatzl
In-Reply-To: <519345DF.2030207@oracle.com>
References: <519345DF.2030207@oracle.com>
Message-ID: <2BA4F512-6D94-437A-BBD8-CC542E07794D@oracle.com>

vote: yes


On May 15, 2013, at 4:22 AM, Bengt Rutisson wrote:

> I hereby nominate Thomas Schatzl to hsx Committer.
> 
> Thomas joined the HotSpot garbage collection team at Oracle earlier this year. Thomas has been active in HotSpot development for several years before starting at Oracle. He has contributed 2 changesets [1,2] before starting Oracle and 7 more since he joined the GC team [3].
> 
> Votes are due by Thu, May 29, 2013 11:00am CEST.
> 
> Only current hsx Committers [4] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
> 
> For Lazy Consensus voting instructions, see [5].
> 
> Bengt Rutisson
> 
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/db823a892a55
> [2] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7994a5a35fcf
> [3] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tschatzl
> [4]http://openjdk.java.net/census/#hsx
> [5]http://openjdk.java.net/projects/#committer-vote
> 


From harold.seigel at oracle.com  Wed May 15 07:08:44 2013
From: harold.seigel at oracle.com (harold seigel)
Date: Wed, 15 May 2013 10:08:44 -0400
Subject: CFV: New hsx Committer: Thomas Schatzl
In-Reply-To: <519345DF.2030207@oracle.com>
References: <519345DF.2030207@oracle.com>
Message-ID: <519396EC.8070208@oracle.com>

Vote: yes

On 5/15/2013 4:22 AM, Bengt Rutisson wrote:
> I hereby nominate Thomas Schatzl to hsx Committer.
>
> Thomas joined the HotSpot garbage collection team at Oracle earlier 
> this year. Thomas has been active in HotSpot development for several 
> years before starting at Oracle. He has contributed 2 changesets [1,2] 
> before starting Oracle and 7 more since he joined the GC team [3].
>
> Votes are due by Thu, May 29, 2013 11:00am CEST.
>
> Only current hsx Committers [4] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [5].
>
> Bengt Rutisson
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/db823a892a55
> [2] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7994a5a35fcf
> [3] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tschatzl
> [4]http://openjdk.java.net/census/#hsx
> [5]http://openjdk.java.net/projects/#committer-vote
>


From volker.simonis at gmail.com  Wed May 15 07:13:34 2013
From: volker.simonis at gmail.com (Volker Simonis)
Date: Wed, 15 May 2013 16:13:34 +0200
Subject: CFV: New hsx Committer: Thomas Schatzl
In-Reply-To: <519345DF.2030207@oracle.com>
References: <519345DF.2030207@oracle.com>
Message-ID: <CA+3eh12Sgw-TPfr9Gp1qi_eXWxw7fvpPZdimrv08x6W2z2zeog@mail.gmail.com>

Vote: yes


On Wed, May 15, 2013 at 10:22 AM, Bengt Rutisson
<bengt.rutisson at oracle.com>wrote:

> I hereby nominate Thomas Schatzl to hsx Committer.
>
> Thomas joined the HotSpot garbage collection team at Oracle earlier this
> year. Thomas has been active in HotSpot development for several years
> before starting at Oracle. He has contributed 2 changesets [1,2] before
> starting Oracle and 7 more since he joined the GC team [3].
>
> Votes are due by Thu, May 29, 2013 11:00am CEST.
>
> Only current hsx Committers [4] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [5].
>
> Bengt Rutisson
>
> [1] http://hg.openjdk.java.net/**hsx/hotspot-gc/hotspot/rev/**db823a892a55<http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/db823a892a55>
> [2] http://hg.openjdk.java.net/**hsx/hotspot-gc/hotspot/rev/**7994a5a35fcf<http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7994a5a35fcf>
> [3] http://hg.openjdk.java.net/**hsx/hotspot-gc/hotspot/log?**rev=tschatzl<http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tschatzl>
> [4]http://openjdk.java.net/**census/#hsx<http://openjdk.java.net/census/#hsx>
> [5]http://openjdk.java.net/**projects/#committer-vote<http://openjdk.java.net/projects/#committer-vote>
>
>

From rickard.backman at oracle.com  Wed May 15 07:18:29 2013
From: rickard.backman at oracle.com (rickard.backman at oracle.com)
Date: Wed, 15 May 2013 14:18:29 +0000
Subject: hg: hsx/hotspot-main/hotspot: 21 new changesets
Message-ID: <20130515141913.60AA948AC5@hg.openjdk.java.net>

Changeset: 712a1e9c91f3
Author:    coleenp
Date:      2013-05-07 09:46 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/712a1e9c91f3

8013063: nsk/jvmti/RetransformClasses/retransform001 failed debug version on os::free
Summary: Clear out class_file_bytes so they aren't deallocated twice
Reviewed-by: dcubed, sspitsyn

! src/share/vm/prims/jvmtiRedefineClasses.cpp

Changeset: 4674e409a9e6
Author:    coleenp
Date:      2013-05-07 18:51 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/4674e409a9e6

8014024: NPG: keep compiled ic methods from being deallocated in redefine classes
Summary: Walk the compiledIC relocation records to keep Method* from being deallocated.
Reviewed-by: dlong, kvn

! src/share/vm/code/nmethod.cpp

Changeset: a1cc1d1e7ce5
Author:    coleenp
Date:      2013-05-07 16:17 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a1cc1d1e7ce5

Merge


Changeset: 28ae1d38d296
Author:    coleenp
Date:      2013-05-07 18:46 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/28ae1d38d296

Merge


Changeset: 64340da5b68c
Author:    hseigel
Date:      2013-05-08 08:20 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/64340da5b68c

8007018: RFE: -XX:+UseLargePages does not work with CDS
Summary: Remove command line restriction.  It should just work.
Reviewed-by: ctornqvi, coleenp, dholmes

! src/share/vm/runtime/arguments.cpp

Changeset: cbfe859bd244
Author:    sla
Date:      2013-05-08 15:37 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/cbfe859bd244

8013591: compiler/ciReplay/TestSA.sh fails in nightly
Reviewed-by: coleenp, rbackman, dholmes

! agent/src/share/classes/sun/jvm/hotspot/ci/ciMethod.java
! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java
! agent/src/share/classes/sun/jvm/hotspot/oops/MethodData.java

Changeset: 0dc028fd5101
Author:    sla
Date:      2013-05-08 10:14 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/0dc028fd5101

Merge


Changeset: 39ead0411f07
Author:    bharadwaj
Date:      2013-05-08 14:18 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/39ead0411f07

8013875: Incorrect vtable index being set during methodHandle creation for static
Summary: Set vtable index as appropriate for static interface methods and for interface methods invoked via invokespecial. To be improved in a later enhancement to CallInfo.
Reviewed-by: jrose, twisti

! src/share/vm/prims/methodHandles.cpp

Changeset: 711016f146fd
Author:    dholmes
Date:      2013-05-08 19:28 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/711016f146fd

8006997: ContendedPaddingWidth should be range-checked
Summary: Constrain between zero and 8K
Reviewed-by: dholmes, rbackman
Contributed-by: Aleksey Shipilev <aleksey.shipilev at oracle.com>

! src/share/vm/runtime/arguments.cpp

Changeset: 9b77ca4ce35e
Author:    dholmes
Date:      2013-05-08 19:38 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/9b77ca4ce35e

Merge

! src/share/vm/runtime/arguments.cpp

Changeset: c272092594bd
Author:    dholmes
Date:      2013-05-08 21:06 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/c272092594bd

Merge


Changeset: 0b7f78069732
Author:    rbackman
Date:      2013-05-08 11:21 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/0b7f78069732

8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return
Reviewed-by: coleenp, dholmes, sla

! src/share/vm/prims/jvmtiExport.cpp

Changeset: 735c995bf1a1
Author:    rbackman
Date:      2013-05-13 07:53 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/735c995bf1a1

Merge

! src/share/vm/runtime/arguments.cpp

Changeset: 92ef81e2f571
Author:    minqi
Date:      2013-05-10 08:27 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/92ef81e2f571

8003557: NPG: Klass* const k should be const Klass* k.
Summary: With NPG, const KlassOop klass which is in fact a definition converted to Klass* const, which is not the original intention. The right usage is converting them to const Klass*.
Reviewed-by: coleenp, kvn
Contributed-by: yumin.qi at oracle.com

! src/share/vm/c1/c1_Runtime1.cpp
! src/share/vm/classfile/verifier.cpp
! src/share/vm/classfile/verifier.hpp
! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp
! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp
! src/share/vm/gc_implementation/shared/markSweep.cpp
! src/share/vm/memory/heapInspection.cpp
! src/share/vm/memory/heapInspection.hpp
! src/share/vm/memory/universe.cpp
! src/share/vm/memory/universe.hpp
! src/share/vm/oops/constantPool.hpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/oops/klass.cpp
! src/share/vm/oops/klass.hpp
! src/share/vm/oops/method.cpp
! src/share/vm/oops/method.hpp
! src/share/vm/oops/methodData.hpp
! src/share/vm/prims/jvm.cpp
! src/share/vm/prims/jvmtiTagMap.cpp

Changeset: 1fcfc045b229
Author:    minqi
Date:      2013-05-10 19:30 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/1fcfc045b229

Merge


Changeset: 8b40495b9381
Author:    minqi
Date:      2013-05-13 18:08 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/8b40495b9381

Merge

! src/share/vm/oops/method.hpp

Changeset: 43083e670adf
Author:    coleenp
Date:      2013-05-13 15:37 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/43083e670adf

8005056: NPG: Crash after redefining java.lang.Object
Summary: Need to walk array class vtables replacing old methods too if j.l.o redefined
Reviewed-by: sspitsyn, dcubed, ctornqvi

! src/share/vm/classfile/dictionary.cpp
! src/share/vm/classfile/dictionary.hpp
! src/share/vm/classfile/systemDictionary.cpp
! src/share/vm/classfile/systemDictionary.hpp
! src/share/vm/oops/klass.hpp
! src/share/vm/prims/jvmtiRedefineClasses.cpp
! src/share/vm/prims/jvmtiRedefineClasses.hpp
+ test/runtime/RedefineObject/Agent.java
+ test/runtime/RedefineObject/TestRedefineObject.java
! test/testlibrary/ClassFileInstaller.java

Changeset: a9270d9ecb13
Author:    shade
Date:      2013-05-14 11:34 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a9270d9ecb13

8014448: Purge PrintCompactFieldsSavings
Summary: Remove obsolete debugging code.
Reviewed-by: dholmes, kvn
Contributed-by: Aleksey Shipilev <aleksey.shipilev at oracle.com>

! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/runtime/globals.hpp

Changeset: f944ba972151
Author:    hseigel
Date:      2013-05-14 09:17 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f944ba972151

8014138: Add VM option to facilitate the writing of CDS tests
Summary: Added the -XX:SharedArchiveFile option.
Reviewed-by: coleenp, ccheung, acorn, dcubed, zgu

! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp
+ test/runtime/SharedArchiveFile/SharedArchiveFile.java

Changeset: f9be75d21404
Author:    minqi
Date:      2013-05-14 09:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f9be75d21404

8012902: remove use of global operator new - take 2
Summary: The fix of 8010992, disable use of global operator new and new[] which caused failure on some tests. This takes two of the bugs also add ALLOW_OPERATOR_NEW_USAGE to prevent crash for third party code calling operator new of jvm on certain platforms.
Reviewed-by: coleenp, dholmes, zgu
Contributed-by: yumin.qi at oracle.com

! make/bsd/makefiles/fastdebug.make
! make/bsd/makefiles/vm.make
! src/os/windows/vm/os_windows.cpp
! src/share/vm/ci/ciReplay.cpp
! src/share/vm/classfile/altHashing.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
! src/share/vm/memory/allocation.cpp
! src/share/vm/memory/allocation.hpp
! src/share/vm/memory/allocation.inline.hpp
! src/share/vm/memory/cardTableModRefBS.cpp
! src/share/vm/memory/cardTableModRefBS.hpp
! src/share/vm/memory/cardTableRS.cpp
! src/share/vm/memory/cardTableRS.hpp
! src/share/vm/memory/collectorPolicy.cpp
! src/share/vm/memory/memRegion.cpp
! src/share/vm/memory/memRegion.hpp
! src/share/vm/opto/idealGraphPrinter.hpp
! src/share/vm/runtime/handles.cpp
! src/share/vm/runtime/handles.hpp
! src/share/vm/runtime/objectMonitor.hpp
! src/share/vm/runtime/reflectionUtils.hpp
! src/share/vm/runtime/unhandledOops.hpp
! src/share/vm/runtime/vmStructs.cpp
! src/share/vm/utilities/events.hpp
! src/share/vm/utilities/quickSort.cpp
! src/share/vm/utilities/workgroup.cpp
! src/share/vm/utilities/workgroup.hpp

Changeset: 513a5298c1dd
Author:    minqi
Date:      2013-05-14 17:33 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/513a5298c1dd

Merge



From serguei.spitsyn at oracle.com  Wed May 15 07:51:06 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Wed, 15 May 2013 07:51:06 -0700
Subject: CFV: New hsx Committer: Thomas Schatzl
In-Reply-To: <519345DF.2030207@oracle.com>
References: <519345DF.2030207@oracle.com>
Message-ID: <5193A0DA.4070906@oracle.com>

Vote: yes

On 5/15/13 1:22 AM, Bengt Rutisson wrote:
> I hereby nominate Thomas Schatzl to hsx Committer.
>
> Thomas joined the HotSpot garbage collection team at Oracle earlier 
> this year. Thomas has been active in HotSpot development for several 
> years before starting at Oracle. He has contributed 2 changesets [1,2] 
> before starting Oracle and 7 more since he joined the GC team [3].
>
> Votes are due by Thu, May 29, 2013 11:00am CEST.
>
> Only current hsx Committers [4] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [5].
>
> Bengt Rutisson
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/db823a892a55
> [2] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7994a5a35fcf
> [3] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tschatzl
> [4]http://openjdk.java.net/census/#hsx
> [5]http://openjdk.java.net/projects/#committer-vote
>


From aleksey.shipilev at oracle.com  Wed May 15 08:36:07 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Wed, 15 May 2013 19:36:07 +0400
Subject: RFR (XS) CR 8014509: @Contended: explicit default value behaves
	differently from the implicit value
Message-ID: <5193AB67.2050201@oracle.com>

Hi,

Please review the little parameter handling fix for @Contended:
  http://cr.openjdk.java.net/~shade/8014509/webrev.01/

Bottom-line, these guys should be equivalent:
 public class Test {
    private static class T0 {
        @Contended("") private double double1;
        @Contended("") private double double2;
    }
    private static class T1 {
        @Contended()   private double double1;
        @Contended()   private double double2;
    }
    private static class T2 {
        @Contended     private double double1;
        @Contended     private double double2;
    }
}

They are not, because we handle the default value in a weird way.

Testing:
  - 8014509 regression test on Linux x86_64/fastdebug
  - full JPRT cycle against hotspot-rt

Thanks,
Aleksey.




From vladimir.kozlov at oracle.com  Wed May 15 09:18:23 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Wed, 15 May 2013 09:18:23 -0700
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <519337CA.9020403@oracle.com>
References: <5192B99B.50405@oracle.com> <5192C7B9.6060902@oracle.com>
	<519336E8.9000101@oracle.com> <519337CA.9020403@oracle.com>
Message-ID: <5193B54F.8050405@oracle.com>

You should send only one webrev then :)

Changes in webrev.01 are good.

Thanks,
Vladimir

PS: you need to become Hotspot committer to push your changes without our assistance. You should have enough changesets 
already.

On 5/15/13 12:22 AM, Aleksey Shipilev wrote:
> On 05/15/2013 11:19 AM, Aleksey Shipilev wrote:
>> On 05/15/2013 03:24 AM, Vladimir Kozlov wrote:
>>> On 5/14/13 3:24 PM, Aleksey Shipilev wrote:
>>>> Hi,
>>>>
>>>> It seems we have a plenty of failures in new SQE tests for @Contended
>>>> because of this. Please see the updated webrev for the issue:
>>>>     http://cr.openjdk.java.net/~shade/8012939/webrev.01/
>>>>
>>>> This is the minimal fix. Most of the instance_size calculations use
>>>> first_nonstatic_field_offset as the boundary for the instance fields
>>>> block. @Contended on the class hijacks this boundary with padding, and
>>>> so the instance size is incorrect (also evidenced by the wrong assert).
>>>>
>>>> There is also a more thorough clean up of that code:
>>>>     http://cr.openjdk.java.net/~shade/8012939/webrev.02/
>>>
>>> I am fine with this version of the fix. But I would suggest more :)
>>> renaming.
>>
>> Sorry, but this will complicate the patch beyond graspable. Let's commit
>> the minimal fix, and work on the refactoring in the separate issue:
>>    http://cr.openjdk.java.net/~shade/8012939/webrev.01/
>
> To reiterate, this is *the* critical patch, and we desperately need this
> in the code. We had already wasted two weeks waiting for reviews, and I
> don't want this to drag along any further.
>
> -Aleksey.
>

From aleksey.shipilev at oracle.com  Wed May 15 09:21:40 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Wed, 15 May 2013 20:21:40 +0400
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <5193B54F.8050405@oracle.com>
References: <5192B99B.50405@oracle.com> <5192C7B9.6060902@oracle.com>
	<519336E8.9000101@oracle.com> <519337CA.9020403@oracle.com>
	<5193B54F.8050405@oracle.com>
Message-ID: <5193B614.6090605@oracle.com>

On 05/15/2013 08:18 PM, Vladimir Kozlov wrote:
> You should send only one webrev then :)

Yeah, I should have mentioned that if webrev.02 takes any minimal drag,
we should fall back to webrev.01 :)

> Changes in webrev.01 are good.

Thanks for review!

-Aleksey.


From vladimir.kozlov at oracle.com  Wed May 15 09:34:10 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Wed, 15 May 2013 09:34:10 -0700
Subject: RFR (XS) CR 8014509: @Contended: explicit default value behaves
	differently from the implicit value
In-Reply-To: <5193AB67.2050201@oracle.com>
References: <5193AB67.2050201@oracle.com>
Message-ID: <5193B902.3070006@oracle.com>

Aleksey,

Why you need to test 2 fields but not class annotation?

It would be nice to have a comment in parse_annotations() explaining what formats of Contended are expected.
And the code could be rearranged to simplify it a little:

      if (id == AnnotationCollector::_sun_misc_Contended) {
        u2 group_index = 0; // default contended group
        if (count == 1
            && s_size == (index - index0)  // match size
            && s_tag_val == *(abase + tag_off)
            && member == vmSymbols::value_name()) {
          u2 group_index = Bytes::get_Java_u2(abase + s_con_off);
          if (_cp->symbol_at(group_index)->utf8_length() == 0) {
            group_index = 0; // empty tag => default contended group
          }
        }
        coll->set_contended_group(group_index);
      }

Thanks,
Vladimir

On 5/15/13 8:36 AM, Aleksey Shipilev wrote:
> Hi,
>
> Please review the little parameter handling fix for @Contended:
>    http://cr.openjdk.java.net/~shade/8014509/webrev.01/
>
> Bottom-line, these guys should be equivalent:
>   public class Test {
>      private static class T0 {
>          @Contended("") private double double1;
>          @Contended("") private double double2;
>      }
>      private static class T1 {
>          @Contended()   private double double1;
>          @Contended()   private double double2;
>      }
>      private static class T2 {
>          @Contended     private double double1;
>          @Contended     private double double2;
>      }
> }
>
> They are not, because we handle the default value in a weird way.
>
> Testing:
>    - 8014509 regression test on Linux x86_64/fastdebug
>    - full JPRT cycle against hotspot-rt
>
> Thanks,
> Aleksey.
>
>
>

From aleksey.shipilev at oracle.com  Wed May 15 09:38:29 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Wed, 15 May 2013 20:38:29 +0400
Subject: RFR (XS) CR 8014509: @Contended: explicit default value behaves
	differently from the implicit value
In-Reply-To: <5193B902.3070006@oracle.com>
References: <5193AB67.2050201@oracle.com> <5193B902.3070006@oracle.com>
Message-ID: <5193BA05.2010201@oracle.com>

Thanks!

On 05/15/2013 08:34 PM, Vladimir Kozlov wrote:
> Why you need to test 2 fields but not class annotation?

The tags are only meaningful on fields, tags are inducing the
equivalence class over the fields. The tags are plainly ignored on
class-level @Contended.

> It would be nice to have a comment in parse_annotations() explaining
> what formats of Contended are expected.

I think I really, really need to push the proper Javadoc to @Contended,
and not push the explanation about this to VM code.

> And the code could be rearranged to simplify it a little:
> 
>      if (id == AnnotationCollector::_sun_misc_Contended) {
>        u2 group_index = 0; // default contended group
>        if (count == 1
>            && s_size == (index - index0)  // match size
>            && s_tag_val == *(abase + tag_off)
>            && member == vmSymbols::value_name()) {
>          u2 group_index = Bytes::get_Java_u2(abase + s_con_off);
>          if (_cp->symbol_at(group_index)->utf8_length() == 0) {
>            group_index = 0; // empty tag => default contended group
>          }
>        }
>        coll->set_contended_group(group_index);
>      }

Good, I'll fix this and re-spin JPRT.

-Aleksey.


From jon.masamitsu at oracle.com  Wed May 15 09:47:31 2013
From: jon.masamitsu at oracle.com (Jon Masamitsu)
Date: Wed, 15 May 2013 09:47:31 -0700
Subject: CFV: New hsx Committer: Thomas Schatzl
In-Reply-To: <519345DF.2030207@oracle.com>
References: <519345DF.2030207@oracle.com>
Message-ID: <5193BC23.2030205@oracle.com>

Vote: yes

On 5/15/2013 1:22 AM, Bengt Rutisson wrote:
> I hereby nominate Thomas Schatzl to hsx Committer.
>
> Thomas joined the HotSpot garbage collection team at Oracle earlier 
> this year. Thomas has been active in HotSpot development for several 
> years before starting at Oracle. He has contributed 2 changesets [1,2] 
> before starting Oracle and 7 more since he joined the GC team [3].
>
> Votes are due by Thu, May 29, 2013 11:00am CEST.
>
> Only current hsx Committers [4] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [5].
>
> Bengt Rutisson
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/db823a892a55
> [2] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7994a5a35fcf
> [3] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tschatzl
> [4]http://openjdk.java.net/census/#hsx
> [5]http://openjdk.java.net/projects/#committer-vote
>


From vladimir.kozlov at oracle.com  Wed May 15 09:50:53 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Wed, 15 May 2013 09:50:53 -0700
Subject: RFR (XS) CR 8014509: @Contended: explicit default value behaves
	differently from the implicit value
In-Reply-To: <5193BA05.2010201@oracle.com>
References: <5193AB67.2050201@oracle.com> <5193B902.3070006@oracle.com>
	<5193BA05.2010201@oracle.com>
Message-ID: <5193BCED.60004@oracle.com>

On 5/15/13 9:38 AM, Aleksey Shipilev wrote:
> Thanks!
>
> On 05/15/2013 08:34 PM, Vladimir Kozlov wrote:
>> Why you need to test 2 fields but not class annotation?
>
> The tags are only meaningful on fields, tags are inducing the
> equivalence class over the fields. The tags are plainly ignored on
> class-level @Contended.

This should be documented (in comments).

>
>> It would be nice to have a comment in parse_annotations() explaining
>> what formats of Contended are expected.
>
> I think I really, really need to push the proper Javadoc to @Contended,
> and not push the explanation about this to VM code.

Comments in VM are big help to us, Hotspot developers.
Pointing to external documents is not helpful.

Vladimir

>
>> And the code could be rearranged to simplify it a little:
>>
>>       if (id == AnnotationCollector::_sun_misc_Contended) {
>>         u2 group_index = 0; // default contended group
>>         if (count == 1
>>             && s_size == (index - index0)  // match size
>>             && s_tag_val == *(abase + tag_off)
>>             && member == vmSymbols::value_name()) {
>>           u2 group_index = Bytes::get_Java_u2(abase + s_con_off);
>>           if (_cp->symbol_at(group_index)->utf8_length() == 0) {
>>             group_index = 0; // empty tag => default contended group
>>           }
>>         }
>>         coll->set_contended_group(group_index);
>>       }
>
> Good, I'll fix this and re-spin JPRT.
>
> -Aleksey.
>

From christian.tornqvist at oracle.com  Wed May 15 12:29:48 2013
From: christian.tornqvist at oracle.com (Christian Tornqvist)
Date: Wed, 15 May 2013 15:29:48 -0400
Subject: New hsx Committer: Thomas Schatzl
In-Reply-To: <519345DF.2030207@oracle.com>
References: <519345DF.2030207@oracle.com>
Message-ID: <049701ce51a2$90f76fd0$b2e64f70$@tornqvist@oracle.com>

Vote: yes

-----Original Message-----
From: hotspot-dev-bounces at openjdk.java.net
[mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Bengt Rutisson
Sent: den 15 maj 2013 04:23
To: hotspot-dev at openjdk.java.net
Subject: CFV: New hsx Committer: Thomas Schatzl

I hereby nominate Thomas Schatzl to hsx Committer.

Thomas joined the HotSpot garbage collection team at Oracle earlier this
year. Thomas has been active in HotSpot development for several years before
starting at Oracle. He has contributed 2 changesets [1,2] before starting
Oracle and 7 more since he joined the GC team [3].

Votes are due by Thu, May 29, 2013 11:00am CEST.

Only current hsx Committers [4] are eligible to vote on this nomination.
Votes must be cast in the open by replying to to this mailing list.

For Lazy Consensus voting instructions, see [5].

Bengt Rutisson

[1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/db823a892a55
[2] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7994a5a35fcf
[3] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tschatzl
[4]http://openjdk.java.net/census/#hsx
[5]http://openjdk.java.net/projects/#committer-vote



From gary.collins at oracle.com  Wed May 15 12:28:26 2013
From: gary.collins at oracle.com (gary.collins at oracle.com)
Date: Wed, 15 May 2013 19:28:26 +0000
Subject: hg: hsx/hsx24/hotspot: 3 new changesets
Message-ID: <20130515192835.A177448ADA@hg.openjdk.java.net>

Changeset: 1c631ba2a408
Author:    collins
Date:      2013-02-27 20:36 -0800
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/1c631ba2a408

7115383: TEST_BUG: some jtreg tests fail because they explicitly specify -server option
Summary: Small changes to hotspot tests to remove  "-server" and replace with ${TESTVMOPTS}
Reviewed-by: kvn

! test/compiler/6431242/Test.java
! test/compiler/6589834/Test_ia32.java
! test/compiler/6636138/Test1.java
! test/compiler/6636138/Test2.java
! test/compiler/6795161/Test.java
! test/compiler/6946040/TestCharShortByteSwap.java
! test/compiler/7068051/Test7068051.sh
! test/compiler/8000805/Test8000805.java

Changeset: 4071984ef4ea
Author:    collins
Date:      2013-03-27 09:49 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/4071984ef4ea

8009152: A number of jtreg tests need review/improvement
Summary: Added a new test_env.txt file to capture common shell variable. Added concept of COMPILEJAVA for use when TESTJAVA is a JRE. If COMPILEJAVA not set then TESTJAVA will be the default with assumption it is a JDK.
Reviewed-by: kvn, brutisso, coleenp

! test/compiler/5091921/Test6890943.sh
! test/compiler/5091921/Test7005594.sh
! test/compiler/6857159/Test6857159.sh
! test/compiler/7068051/Test7068051.sh
! test/compiler/7070134/Test7070134.sh
! test/compiler/7200264/Test7200264.sh
! test/gc/6941923/test6941923.sh
! test/runtime/6626217/Test6626217.sh
! test/runtime/6878713/Test6878713.sh
! test/runtime/6929067/Test6929067.sh
! test/runtime/7020373/Test7020373.sh
! test/runtime/7051189/Xchecksig.sh
! test/runtime/7107135/Test7107135.sh
! test/runtime/7110720/Test7110720.sh
! test/runtime/7158804/Test7158804.sh
! test/runtime/7162488/Test7162488.sh
+ test/test_env.sh

Changeset: 725d82a60081
Author:    collins
Date:      2013-05-15 08:37 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/725d82a60081

Merge



From christian.tornqvist at oracle.com  Wed May 15 12:33:26 2013
From: christian.tornqvist at oracle.com (Christian Tornqvist)
Date: Wed, 15 May 2013 15:33:26 -0400
Subject: RFR (XS) CR 8014509: @Contended: explicit default value
	behaves	differently from the implicit value
In-Reply-To: <5193AB67.2050201@oracle.com>
References: <5193AB67.2050201@oracle.com>
Message-ID: <049801ce51a3$12818400$37848c00$@tornqvist@oracle.com>

Hi Aleksey,

Test name and location should be something more descriptive, more
information about the Hotspot jtreg naming convention can be found at:

https://wikis.oracle.com/display/HotSpotInternals/Naming+HotSpot+JTReg+Tests

Thanks,
Christian

-----Original Message-----
From: hotspot-dev-bounces at openjdk.java.net
[mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Aleksey Shipilev
Sent: den 15 maj 2013 11:36
To: hotspot-dev at openjdk.java.net
Subject: RFR (XS) CR 8014509: @Contended: explicit default value behaves
differently from the implicit value

Hi,

Please review the little parameter handling fix for @Contended:
  http://cr.openjdk.java.net/~shade/8014509/webrev.01/

Bottom-line, these guys should be equivalent:
 public class Test {
    private static class T0 {
        @Contended("") private double double1;
        @Contended("") private double double2;
    }
    private static class T1 {
        @Contended()   private double double1;
        @Contended()   private double double2;
    }
    private static class T2 {
        @Contended     private double double1;
        @Contended     private double double2;
    }
}

They are not, because we handle the default value in a weird way.

Testing:
  - 8014509 regression test on Linux x86_64/fastdebug
  - full JPRT cycle against hotspot-rt

Thanks,
Aleksey.





From christian.tornqvist at oracle.com  Wed May 15 12:35:52 2013
From: christian.tornqvist at oracle.com (Christian Tornqvist)
Date: Wed, 15 May 2013 15:35:52 -0400
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly
	with	inheritance
In-Reply-To: <5192B99B.50405@oracle.com>
References: <5192B99B.50405@oracle.com>
Message-ID: <049901ce51a3$69a87590$3cf960b0$@tornqvist@oracle.com>

Hi Aleksey,

Same thing here as in 8014509, could you please rename the test and put it
in a folder that describes the area of the test?

Thanks,
Christian

-----Original Message-----
From: hotspot-dev-bounces at openjdk.java.net
[mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Aleksey Shipilev
Sent: den 14 maj 2013 18:24
To: hotspot-dev at openjdk.java.net
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
inheritance

Hi,

It seems we have a plenty of failures in new SQE tests for @Contended
because of this. Please see the updated webrev for the issue:
  http://cr.openjdk.java.net/~shade/8012939/webrev.01/

This is the minimal fix. Most of the instance_size calculations use
first_nonstatic_field_offset as the boundary for the instance fields block.
@Contended on the class hijacks this boundary with padding, and so the
instance size is incorrect (also evidenced by the wrong assert).

There is also a more thorough clean up of that code:
  http://cr.openjdk.java.net/~shade/8012939/webrev.02/

...which is makes the intent cleaner. I can submit another RFE for that
cleanup, although I think it prunes the source of the original confusion.
Speak up if you want me to split these, and we push the
webrev.01 alone then.

Testing:
  - 8003985 and 8012939 tests on Linux x86_64/fastdebug
  - JPRT run for both webrevs

Thanks,
Aleksey.


From aleksey.shipilev at oracle.com  Wed May 15 12:39:52 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Wed, 15 May 2013 23:39:52 +0400
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <049901ce51a3$69a87590$3cf960b0$@tornqvist@oracle.com>
References: <5192B99B.50405@oracle.com>
	<049901ce51a3$69a87590$3cf960b0$@tornqvist@oracle.com>
Message-ID: <5193E488.4040402@oracle.com>

I appreciate the effort of renaming the tests, but I would not like to
risk the integration of this change before the approaching milestone.
Can it be made after a fact (including other @Contended regression tests).

-Aleksey.

05/15/2013 11:35 PM, Christian Tornqvist wrote:
> Hi Aleksey,
> 
> Same thing here as in 8014509, could you please rename the test and put it
> in a folder that describes the area of the test?
> 
> Thanks,
> Christian
> 
> -----Original Message-----
> From: hotspot-dev-bounces at openjdk.java.net
> [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Aleksey Shipilev
> Sent: den 14 maj 2013 18:24
> To: hotspot-dev at openjdk.java.net
> Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
> inheritance
> 
> Hi,
> 
> It seems we have a plenty of failures in new SQE tests for @Contended
> because of this. Please see the updated webrev for the issue:
>   http://cr.openjdk.java.net/~shade/8012939/webrev.01/
> 
> This is the minimal fix. Most of the instance_size calculations use
> first_nonstatic_field_offset as the boundary for the instance fields block.
> @Contended on the class hijacks this boundary with padding, and so the
> instance size is incorrect (also evidenced by the wrong assert).
> 
> There is also a more thorough clean up of that code:
>   http://cr.openjdk.java.net/~shade/8012939/webrev.02/
> 
> ...which is makes the intent cleaner. I can submit another RFE for that
> cleanup, although I think it prunes the source of the original confusion.
> Speak up if you want me to split these, and we push the
> webrev.01 alone then.
> 
> Testing:
>   - 8003985 and 8012939 tests on Linux x86_64/fastdebug
>   - JPRT run for both webrevs
> 
> Thanks,
> Aleksey.
> 


From christian.tornqvist at oracle.com  Wed May 15 13:13:56 2013
From: christian.tornqvist at oracle.com (Christian Tornqvist)
Date: Wed, 15 May 2013 16:13:56 -0400
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <5193E488.4040402@oracle.com>
References: <5192B99B.50405@oracle.com>
	<049901ce51a3$69a87590$3cf960b0$@tornqvist@oracle.com>
	<5193E488.4040402@oracle.com>
Message-ID: <04c201ce51a8$bb2a9a10$317fce30$@tornqvist@oracle.com>

Seems like a trivial thing to just change 2 lines in each of the tests and
do a hg rename? It would be more of an effort to do this later than right
away. 

Thanks,
Christian

-----Original Message-----
From: Aleksey Shipilev [mailto:aleksey.shipilev at oracle.com] 
Sent: den 15 maj 2013 15:40
To: Christian Tornqvist
Cc: hotspot-dev at openjdk.java.net
Subject: Re: RFR (S): CR 8012939: @Contended doesn't work correctly with
inheritance

I appreciate the effort of renaming the tests, but I would not like to risk
the integration of this change before the approaching milestone.
Can it be made after a fact (including other @Contended regression tests).

-Aleksey.

05/15/2013 11:35 PM, Christian Tornqvist wrote:
> Hi Aleksey,
> 
> Same thing here as in 8014509, could you please rename the test and 
> put it in a folder that describes the area of the test?
> 
> Thanks,
> Christian
> 
> -----Original Message-----
> From: hotspot-dev-bounces at openjdk.java.net
> [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Aleksey 
> Shipilev
> Sent: den 14 maj 2013 18:24
> To: hotspot-dev at openjdk.java.net
> Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with 
> inheritance
> 
> Hi,
> 
> It seems we have a plenty of failures in new SQE tests for @Contended 
> because of this. Please see the updated webrev for the issue:
>   http://cr.openjdk.java.net/~shade/8012939/webrev.01/
> 
> This is the minimal fix. Most of the instance_size calculations use 
> first_nonstatic_field_offset as the boundary for the instance fields
block.
> @Contended on the class hijacks this boundary with padding, and so the 
> instance size is incorrect (also evidenced by the wrong assert).
> 
> There is also a more thorough clean up of that code:
>   http://cr.openjdk.java.net/~shade/8012939/webrev.02/
> 
> ...which is makes the intent cleaner. I can submit another RFE for 
> that cleanup, although I think it prunes the source of the original
confusion.
> Speak up if you want me to split these, and we push the
> webrev.01 alone then.
> 
> Testing:
>   - 8003985 and 8012939 tests on Linux x86_64/fastdebug
>   - JPRT run for both webrevs
> 
> Thanks,
> Aleksey.
> 



From aleksey.shipilev at oracle.com  Wed May 15 13:16:22 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Thu, 16 May 2013 00:16:22 +0400
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <04c201ce51a8$bb2a9a10$317fce30$@tornqvist@oracle.com>
References: <5192B99B.50405@oracle.com>
	<049901ce51a3$69a87590$3cf960b0$@tornqvist@oracle.com>
	<5193E488.4040402@oracle.com>
	<04c201ce51a8$bb2a9a10$317fce30$@tornqvist@oracle.com>
Message-ID: <5193ED16.3080802@oracle.com>

That assumes we would not have the bikeshed argument about the test
names and the subfolders (which we will). Really, I think it would be a
good move to move all three regression tests for @Contended at once.

-Aleksey.

On 05/16/2013 12:13 AM, Christian Tornqvist wrote:
> Seems like a trivial thing to just change 2 lines in each of the tests and
> do a hg rename? It would be more of an effort to do this later than right
> away. 
> 
> Thanks,
> Christian
> 
> -----Original Message-----
> From: Aleksey Shipilev [mailto:aleksey.shipilev at oracle.com] 
> Sent: den 15 maj 2013 15:40
> To: Christian Tornqvist
> Cc: hotspot-dev at openjdk.java.net
> Subject: Re: RFR (S): CR 8012939: @Contended doesn't work correctly with
> inheritance
> 
> I appreciate the effort of renaming the tests, but I would not like to risk
> the integration of this change before the approaching milestone.
> Can it be made after a fact (including other @Contended regression tests).
> 
> -Aleksey.
> 
> 05/15/2013 11:35 PM, Christian Tornqvist wrote:
>> Hi Aleksey,
>>
>> Same thing here as in 8014509, could you please rename the test and 
>> put it in a folder that describes the area of the test?
>>
>> Thanks,
>> Christian
>>
>> -----Original Message-----
>> From: hotspot-dev-bounces at openjdk.java.net
>> [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Aleksey 
>> Shipilev
>> Sent: den 14 maj 2013 18:24
>> To: hotspot-dev at openjdk.java.net
>> Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with 
>> inheritance
>>
>> Hi,
>>
>> It seems we have a plenty of failures in new SQE tests for @Contended 
>> because of this. Please see the updated webrev for the issue:
>>   http://cr.openjdk.java.net/~shade/8012939/webrev.01/
>>
>> This is the minimal fix. Most of the instance_size calculations use 
>> first_nonstatic_field_offset as the boundary for the instance fields
> block.
>> @Contended on the class hijacks this boundary with padding, and so the 
>> instance size is incorrect (also evidenced by the wrong assert).
>>
>> There is also a more thorough clean up of that code:
>>   http://cr.openjdk.java.net/~shade/8012939/webrev.02/
>>
>> ...which is makes the intent cleaner. I can submit another RFE for 
>> that cleanup, although I think it prunes the source of the original
> confusion.
>> Speak up if you want me to split these, and we push the
>> webrev.01 alone then.
>>
>> Testing:
>>   - 8003985 and 8012939 tests on Linux x86_64/fastdebug
>>   - JPRT run for both webrevs
>>
>> Thanks,
>> Aleksey.
>>
> 
> 


From daniel.daugherty at oracle.com  Wed May 15 13:41:11 2013
From: daniel.daugherty at oracle.com (Daniel D. Daugherty)
Date: Wed, 15 May 2013 14:41:11 -0600
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <5193ED16.3080802@oracle.com>
References: <5192B99B.50405@oracle.com>
	<049901ce51a3$69a87590$3cf960b0$@tornqvist@oracle.com>
	<5193E488.4040402@oracle.com>
	<04c201ce51a8$bb2a9a10$317fce30$@tornqvist@oracle.com>
	<5193ED16.3080802@oracle.com>
Message-ID: <5193F2E7.2000604@oracle.com>

Aleksey,

Christian's request is reasonable. Please reconsider.

I'm not sure which baseline you were planning to use for this change,
but RT_Baseline has already pushed for this week for the HSX-25-B33
snapshot.

Dan


On 5/15/13 2:16 PM, Aleksey Shipilev wrote:
> That assumes we would not have the bikeshed argument about the test
> names and the subfolders (which we will). Really, I think it would be a
> good move to move all three regression tests for @Contended at once.
>
> -Aleksey.
>
> On 05/16/2013 12:13 AM, Christian Tornqvist wrote:
>> Seems like a trivial thing to just change 2 lines in each of the tests and
>> do a hg rename? It would be more of an effort to do this later than right
>> away.
>>
>> Thanks,
>> Christian
>>
>> -----Original Message-----
>> From: Aleksey Shipilev [mailto:aleksey.shipilev at oracle.com]
>> Sent: den 15 maj 2013 15:40
>> To: Christian Tornqvist
>> Cc: hotspot-dev at openjdk.java.net
>> Subject: Re: RFR (S): CR 8012939: @Contended doesn't work correctly with
>> inheritance
>>
>> I appreciate the effort of renaming the tests, but I would not like to risk
>> the integration of this change before the approaching milestone.
>> Can it be made after a fact (including other @Contended regression tests).
>>
>> -Aleksey.
>>
>> 05/15/2013 11:35 PM, Christian Tornqvist wrote:
>>> Hi Aleksey,
>>>
>>> Same thing here as in 8014509, could you please rename the test and
>>> put it in a folder that describes the area of the test?
>>>
>>> Thanks,
>>> Christian
>>>
>>> -----Original Message-----
>>> From: hotspot-dev-bounces at openjdk.java.net
>>> [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Aleksey
>>> Shipilev
>>> Sent: den 14 maj 2013 18:24
>>> To: hotspot-dev at openjdk.java.net
>>> Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
>>> inheritance
>>>
>>> Hi,
>>>
>>> It seems we have a plenty of failures in new SQE tests for @Contended
>>> because of this. Please see the updated webrev for the issue:
>>>    http://cr.openjdk.java.net/~shade/8012939/webrev.01/
>>>
>>> This is the minimal fix. Most of the instance_size calculations use
>>> first_nonstatic_field_offset as the boundary for the instance fields
>> block.
>>> @Contended on the class hijacks this boundary with padding, and so the
>>> instance size is incorrect (also evidenced by the wrong assert).
>>>
>>> There is also a more thorough clean up of that code:
>>>    http://cr.openjdk.java.net/~shade/8012939/webrev.02/
>>>
>>> ...which is makes the intent cleaner. I can submit another RFE for
>>> that cleanup, although I think it prunes the source of the original
>> confusion.
>>> Speak up if you want me to split these, and we push the
>>> webrev.01 alone then.
>>>
>>> Testing:
>>>    - 8003985 and 8012939 tests on Linux x86_64/fastdebug
>>>    - JPRT run for both webrevs
>>>
>>> Thanks,
>>> Aleksey.
>>>
>>
>
>


From poonam.bajaj at oracle.com  Wed May 15 16:42:07 2013
From: poonam.bajaj at oracle.com (poonam.bajaj at oracle.com)
Date: Wed, 15 May 2013 23:42:07 +0000
Subject: hg: hsx/hsx24/hotspot: 2 new changesets
Message-ID: <20130515234211.7BD4C48ADF@hg.openjdk.java.net>

Changeset: f2ce8a7ee5a0
Author:    poonam
Date:      2013-05-15 10:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/f2ce8a7ee5a0

8014189: JVM crash with SEGV in ConnectionGraph::record_for_escape_analysis()
Summary: Add NULL checks and asserts for Type::make_ptr() returned value.
Reviewed-by: kvn

! src/share/vm/opto/escape.cpp
! src/share/vm/opto/lcm.cpp
! src/share/vm/opto/library_call.cpp
! src/share/vm/opto/machnode.cpp
! src/share/vm/opto/macro.cpp
! src/share/vm/opto/node.cpp
! src/share/vm/opto/node.hpp
! src/share/vm/opto/output.cpp
! src/share/vm/opto/subnode.cpp

Changeset: ec4e3a5cc748
Author:    poonam
Date:      2013-05-15 12:38 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/ec4e3a5cc748

Merge



From christian.thalinger at oracle.com  Wed May 15 19:13:14 2013
From: christian.thalinger at oracle.com (christian.thalinger at oracle.com)
Date: Thu, 16 May 2013 02:13:14 +0000
Subject: hg: hsx/hsx24/hotspot: 4 new changesets
Message-ID: <20130516021324.6A2AF48AE6@hg.openjdk.java.net>

Changeset: 275bd93474dc
Author:    roland
Date:      2013-04-04 09:33 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/275bd93474dc

8010399: Test8009761.java "Failed: init recursive calls: 5498. After deopt 5494".
Summary: test from 8009761 shouldn't be run with -Xcomp
Reviewed-by: kvn

! test/compiler/8009761/Test8009761.java

Changeset: 24560c7be569
Author:    roland
Date:      2013-05-03 09:32 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/24560c7be569

8012037: Test8009761.java "Failed: init recursive calls: 7224. After deopt 58824"
Summary: test shouldn't be run with a modified CompileThreshold
Reviewed-by: kvn

! test/compiler/8009761/Test8009761.java

Changeset: d1032a8d2096
Author:    twisti
Date:      2013-05-06 13:53 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/d1032a8d2096

7196277: JSR 292: Two jck/runtime tests crash on java.lang.invoke.MethodHandle.invokeExact
Reviewed-by: jrose, kvn

! src/share/vm/oops/methodOop.cpp
! src/share/vm/prims/methodHandles.cpp
! src/share/vm/prims/nativeLookup.cpp
! src/share/vm/runtime/sharedRuntime.cpp

Changeset: 12e522165e15
Author:    twisti
Date:      2013-05-15 19:46 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/12e522165e15

Merge



From david.holmes at oracle.com  Wed May 15 21:22:35 2013
From: david.holmes at oracle.com (David Holmes)
Date: Thu, 16 May 2013 14:22:35 +1000
Subject: CFV: New hsx Committer: Thomas Schatzl
In-Reply-To: <519345DF.2030207@oracle.com>
References: <519345DF.2030207@oracle.com>
Message-ID: <51945F0B.9020206@oracle.com>

Vote: yes

David

On 15/05/2013 6:22 PM, Bengt Rutisson wrote:
> I hereby nominate Thomas Schatzl to hsx Committer.
>
> Thomas joined the HotSpot garbage collection team at Oracle earlier this
> year. Thomas has been active in HotSpot development for several years
> before starting at Oracle. He has contributed 2 changesets [1,2] before
> starting Oracle and 7 more since he joined the GC team [3].
>
> Votes are due by Thu, May 29, 2013 11:00am CEST.
>
> Only current hsx Committers [4] are eligible to vote on this
> nomination.  Votes must be cast in the open by replying to to this
> mailing list.
>
> For Lazy Consensus voting instructions, see [5].
>
> Bengt Rutisson
>
> [1] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/db823a892a55
> [2] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7994a5a35fcf
> [3] http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/log?rev=tschatzl
> [4]http://openjdk.java.net/census/#hsx
> [5]http://openjdk.java.net/projects/#committer-vote
>

From david.holmes at oracle.com  Thu May 16 03:36:21 2013
From: david.holmes at oracle.com (David Holmes)
Date: Thu, 16 May 2013 20:36:21 +1000
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <5193F2E7.2000604@oracle.com>
References: <5192B99B.50405@oracle.com>
	<049901ce51a3$69a87590$3cf960b0$@tornqvist@oracle.com>
	<5193E488.4040402@oracle.com>
	<04c201ce51a8$bb2a9a10$317fce30$@tornqvist@oracle.com>
	<5193ED16.3080802@oracle.com> <5193F2E7.2000604@oracle.com>
Message-ID: <5194B6A5.6090103@oracle.com>

On 16/05/2013 6:41 AM, Daniel D. Daugherty wrote:
> Aleksey,
>
> Christian's request is reasonable. Please reconsider.
>
> I'm not sure which baseline you were planning to use for this change,
> but RT_Baseline has already pushed for this week for the HSX-25-B33
> snapshot.

Plus this is a bug fix so there is nothing about the M7 deadline that 
impacts the ability to get this in.

David

> Dan
>
>
> On 5/15/13 2:16 PM, Aleksey Shipilev wrote:
>> That assumes we would not have the bikeshed argument about the test
>> names and the subfolders (which we will). Really, I think it would be a
>> good move to move all three regression tests for @Contended at once.
>>
>> -Aleksey.
>>
>> On 05/16/2013 12:13 AM, Christian Tornqvist wrote:
>>> Seems like a trivial thing to just change 2 lines in each of the
>>> tests and
>>> do a hg rename? It would be more of an effort to do this later than
>>> right
>>> away.
>>>
>>> Thanks,
>>> Christian
>>>
>>> -----Original Message-----
>>> From: Aleksey Shipilev [mailto:aleksey.shipilev at oracle.com]
>>> Sent: den 15 maj 2013 15:40
>>> To: Christian Tornqvist
>>> Cc: hotspot-dev at openjdk.java.net
>>> Subject: Re: RFR (S): CR 8012939: @Contended doesn't work correctly with
>>> inheritance
>>>
>>> I appreciate the effort of renaming the tests, but I would not like
>>> to risk
>>> the integration of this change before the approaching milestone.
>>> Can it be made after a fact (including other @Contended regression
>>> tests).
>>>
>>> -Aleksey.
>>>
>>> 05/15/2013 11:35 PM, Christian Tornqvist wrote:
>>>> Hi Aleksey,
>>>>
>>>> Same thing here as in 8014509, could you please rename the test and
>>>> put it in a folder that describes the area of the test?
>>>>
>>>> Thanks,
>>>> Christian
>>>>
>>>> -----Original Message-----
>>>> From: hotspot-dev-bounces at openjdk.java.net
>>>> [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Aleksey
>>>> Shipilev
>>>> Sent: den 14 maj 2013 18:24
>>>> To: hotspot-dev at openjdk.java.net
>>>> Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
>>>> inheritance
>>>>
>>>> Hi,
>>>>
>>>> It seems we have a plenty of failures in new SQE tests for @Contended
>>>> because of this. Please see the updated webrev for the issue:
>>>>    http://cr.openjdk.java.net/~shade/8012939/webrev.01/
>>>>
>>>> This is the minimal fix. Most of the instance_size calculations use
>>>> first_nonstatic_field_offset as the boundary for the instance fields
>>> block.
>>>> @Contended on the class hijacks this boundary with padding, and so the
>>>> instance size is incorrect (also evidenced by the wrong assert).
>>>>
>>>> There is also a more thorough clean up of that code:
>>>>    http://cr.openjdk.java.net/~shade/8012939/webrev.02/
>>>>
>>>> ...which is makes the intent cleaner. I can submit another RFE for
>>>> that cleanup, although I think it prunes the source of the original
>>> confusion.
>>>> Speak up if you want me to split these, and we push the
>>>> webrev.01 alone then.
>>>>
>>>> Testing:
>>>>    - 8003985 and 8012939 tests on Linux x86_64/fastdebug
>>>>    - JPRT run for both webrevs
>>>>
>>>> Thanks,
>>>> Aleksey.
>>>>
>>>
>>
>>
>

From alejandro.murillo at oracle.com  Thu May 16 11:27:54 2013
From: alejandro.murillo at oracle.com (Alejandro E Murillo)
Date: Thu, 16 May 2013 12:27:54 -0600
Subject: CFV: New hsx Committer: Thomas Schatzl
In-Reply-To: <519345DF.2030207@oracle.com>
References: <519345DF.2030207@oracle.com>
Message-ID: <5195252A.2070901@oracle.com>

vote: yes

On 5/15/2013 2:22 AM, Bengt Rutisson wrote:
> I hereby nominate Thomas Schatzl to hsx Committer.

-- 
Alejandro


From aleksey.shipilev at oracle.com  Thu May 16 12:22:18 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Thu, 16 May 2013 23:22:18 +0400
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <5194B6A5.6090103@oracle.com>
References: <5192B99B.50405@oracle.com>
	<049901ce51a3$69a87590$3cf960b0$@tornqvist@oracle.com>
	<5193E488.4040402@oracle.com>
	<04c201ce51a8$bb2a9a10$317fce30$@tornqvist@oracle.com>
	<5193ED16.3080802@oracle.com> <5193F2E7.2000604@oracle.com>
	<5194B6A5.6090103@oracle.com>
Message-ID: <519531EA.4060303@oracle.com>

On 05/16/2013 02:36 PM, David Holmes wrote:
> On 16/05/2013 6:41 AM, Daniel D. Daugherty wrote:
>> Aleksey,
>>
>> Christian's request is reasonable. Please reconsider.
>>
>> I'm not sure which baseline you were planning to use for this change,
>> but RT_Baseline has already pushed for this week for the HSX-25-B33
>> snapshot.
> 
> Plus this is a bug fix so there is nothing about the M7 deadline that
> impacts the ability to get this in.

Ok, fine. Here's the updated webrev with the test renaming:
  http://cr.openjdk.java.net/~shade/8012939/webrev.03/

Vladimir K. had already reviewed, we need a second reviewer.

-Aleksey.


From aleksey.shipilev at oracle.com  Thu May 16 12:36:24 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Thu, 16 May 2013 23:36:24 +0400
Subject: RFR (XS) CR 8014509: @Contended: explicit default value behaves
	differently from the implicit value
In-Reply-To: <5193BCED.60004@oracle.com>
References: <5193AB67.2050201@oracle.com> <5193B902.3070006@oracle.com>
	<5193BA05.2010201@oracle.com> <5193BCED.60004@oracle.com>
Message-ID: <51953538.6040701@oracle.com>

On 05/15/2013 08:50 PM, Vladimir Kozlov wrote:
> On 5/15/13 9:38 AM, Aleksey Shipilev wrote:
>> Thanks!

Please see the updated webrev here:
  http://cr.openjdk.java.net/~shade/8014509/webrev.02/

-Aleksey.


From christian.tornqvist at oracle.com  Thu May 16 13:11:40 2013
From: christian.tornqvist at oracle.com (Christian Tornqvist)
Date: Thu, 16 May 2013 16:11:40 -0400
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly
	with	inheritance
In-Reply-To: <519531EA.4060303@oracle.com>
References: <5192B99B.50405@oracle.com>	<049901ce51a3$69a87590$3cf960b0$@tornqvist@oracle.com>	<5193E488.4040402@oracle.com>	<04c201ce51a8$bb2a9a10$317fce30$@tornqvist@oracle.com>	<5193ED16.3080802@oracle.com>
	<5193F2E7.2000604@oracle.com>	<5194B6A5.6090103@oracle.com>
	<519531EA.4060303@oracle.com>
Message-ID: <000501ce5271$94837bb0$bd8a7310$@tornqvist@oracle.com>

Thanks for renaming the tests :)

-----Original Message-----
From: hotspot-dev-bounces at openjdk.java.net
[mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Aleksey Shipilev
Sent: den 16 maj 2013 15:22
To: David Holmes
Cc: hotspot-dev at openjdk.java.net
Subject: Re: RFR (S): CR 8012939: @Contended doesn't work correctly with
inheritance

On 05/16/2013 02:36 PM, David Holmes wrote:
> On 16/05/2013 6:41 AM, Daniel D. Daugherty wrote:
>> Aleksey,
>>
>> Christian's request is reasonable. Please reconsider.
>>
>> I'm not sure which baseline you were planning to use for this change, 
>> but RT_Baseline has already pushed for this week for the HSX-25-B33 
>> snapshot.
> 
> Plus this is a bug fix so there is nothing about the M7 deadline that 
> impacts the ability to get this in.

Ok, fine. Here's the updated webrev with the test renaming:
  http://cr.openjdk.java.net/~shade/8012939/webrev.03/

Vladimir K. had already reviewed, we need a second reviewer.

-Aleksey.



From vladimir.kozlov at oracle.com  Thu May 16 13:50:06 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Thu, 16 May 2013 13:50:06 -0700
Subject: RFR (XS) CR 8014509: @Contended: explicit default value behaves
	differently from the implicit value
In-Reply-To: <51953538.6040701@oracle.com>
References: <5193AB67.2050201@oracle.com> <5193B902.3070006@oracle.com>
	<5193BA05.2010201@oracle.com> <5193BCED.60004@oracle.com>
	<51953538.6040701@oracle.com>
Message-ID: <5195467E.3050007@oracle.com>

You forgot to change != to ==

+        if (_cp->symbol_at(group_index)->utf8_length() != 0) {
+          group_index = 0; // default contended group

Otherwise it is good. Thank you for the comment.

Vladimir

On 5/16/13 12:36 PM, Aleksey Shipilev wrote:
> On 05/15/2013 08:50 PM, Vladimir Kozlov wrote:
>> On 5/15/13 9:38 AM, Aleksey Shipilev wrote:
>>> Thanks!
>
> Please see the updated webrev here:
>    http://cr.openjdk.java.net/~shade/8014509/webrev.02/
>
> -Aleksey.
>

From aleksey.shipilev at oracle.com  Thu May 16 14:25:16 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Fri, 17 May 2013 01:25:16 +0400
Subject: RFR (XS) CR 8014509: @Contended: explicit default value behaves
	differently from the implicit value
In-Reply-To: <5195467E.3050007@oracle.com>
References: <5193AB67.2050201@oracle.com> <5193B902.3070006@oracle.com>
	<5193BA05.2010201@oracle.com> <5193BCED.60004@oracle.com>
	<51953538.6040701@oracle.com> <5195467E.3050007@oracle.com>
Message-ID: <51954EBC.4010609@oracle.com>

On 05/17/2013 12:50 AM, Vladimir Kozlov wrote:
> You forgot to change != to ==
> 
> +        if (_cp->symbol_at(group_index)->utf8_length() != 0) {
> +          group_index = 0; // default contended group
> 
> Otherwise it is good. Thank you for the comment.

Darn. Now I see why test renamings are good: it had actually regressed
the 8003985 test.

Fixed:
  http://cr.openjdk.java.net/~shade/8014509/webrev.03/

We need the second reviewer.

-Aleksey.


From john.r.rose at oracle.com  Thu May 16 14:31:41 2013
From: john.r.rose at oracle.com (John Rose)
Date: Thu, 16 May 2013 14:31:41 -0700
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <5192B99B.50405@oracle.com>
References: <5192B99B.50405@oracle.com>
Message-ID: <FD45D2AE-DAF2-49F9-B948-963C003351C9@oracle.com>

On May 14, 2013, at 3:24 PM, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:

> It seems we have a plenty of failures in new SQE tests for @Contended
> because of this. Please see the updated webrev for the issue:
>  http://cr.openjdk.java.net/~shade/8012939/webrev.01/
> 
> This is the minimal fix.

Aleksey, you can count me as a reviewer on the minimal fix.

Sadly, I (like Vladimir) have spent too much time learning the spaghetti code that does class file layout.  This makes it hard to easily evaluate the benefits of the renaming you propose.

I have always thought that this code should be factored into small structs.  It seems to me that renaming has limited value given the large number of state variables.

(Reminds me of a 1970's implementation of the Star Trek game in Basic, but with longer names.)

? John

From john.r.rose at oracle.com  Thu May 16 14:32:11 2013
From: john.r.rose at oracle.com (John Rose)
Date: Thu, 16 May 2013 14:32:11 -0700
Subject: RFR (XS) CR 8014509: @Contended: explicit default value
	behaves	differently from the implicit value
In-Reply-To: <049801ce51a3$12818400$37848c00$@tornqvist@oracle.com>
References: <5193AB67.2050201@oracle.com>
	<049801ce51a3$12818400$37848c00$@tornqvist@oracle.com>
Message-ID: <3F5C6C60-7868-4436-A28D-A0CE6C846793@oracle.com>

On May 15, 2013, at 12:33 PM, "Christian Tornqvist" <christian.tornqvist at oracle.com> wrote:

> Test name and location should be something more descriptive, more
> information about the Hotspot jtreg naming convention can be found at:
> 
> https://wikis.oracle.com/display/HotSpotInternals/Naming+HotSpot+JTReg+Tests

Note that the new location of this wiki page is now:
  https://wiki.openjdk.java.net/display/HotSpot/Naming+HotSpot+JTReg+Tests

Thank you, Christian, for reminding us of this effort to improve test names.

Also thanks to Bengt for initiating it and to Aleksey for being an early adopter.

The relevant OpenJDK message is:
  http://mail.openjdk.java.net/pipermail/hotspot-dev/2013-April/009218.html

Cheers,
? John

From aleksey.shipilev at oracle.com  Thu May 16 14:46:23 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Fri, 17 May 2013 01:46:23 +0400
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <FD45D2AE-DAF2-49F9-B948-963C003351C9@oracle.com>
References: <5192B99B.50405@oracle.com>
	<FD45D2AE-DAF2-49F9-B948-963C003351C9@oracle.com>
Message-ID: <519553AF.8090805@oracle.com>

On 05/17/2013 01:31 AM, John Rose wrote:
> On May 14, 2013, at 3:24 PM, Aleksey Shipilev
> <aleksey.shipilev at oracle.com <mailto:aleksey.shipilev at oracle.com>> wrote:
> 
>> It seems we have a plenty of failures in new SQE tests for @Contended
>> because of this. Please see the updated webrev for the issue:
>>  http://cr.openjdk.java.net/~shade/8012939/webrev.01/
>> <http://cr.openjdk.java.net/%7Eshade/8012939/webrev.01/>
>>
>> This is the minimal fix.
> 
> Aleksey, you can count me as a reviewer on the minimal fix.

Thanks!

For the record, the updated webrev with test renaming is here:
  http://cr.openjdk.java.net/~shade/8012939/webrev.03/

Now I need a sponsor to push this. The changeset with all the meta-info
is here:
  http://cr.openjdk.java.net/~shade/8012939/8012939.changeset

-Aleksey.

From christian.thalinger at oracle.com  Thu May 16 14:52:53 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Thu, 16 May 2013 14:52:53 -0700
Subject: RFR (XS) CR 8014509: @Contended: explicit default value behaves
	differently from the implicit value
In-Reply-To: <51954EBC.4010609@oracle.com>
References: <5193AB67.2050201@oracle.com> <5193B902.3070006@oracle.com>
	<5193BA05.2010201@oracle.com> <5193BCED.60004@oracle.com>
	<51953538.6040701@oracle.com> <5195467E.3050007@oracle.com>
	<51954EBC.4010609@oracle.com>
Message-ID: <3BF2D919-2F26-4FF2-9B6A-6E08F2C31F76@oracle.com>

Looks good.  -- Chris

On May 16, 2013, at 2:25 PM, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:

> On 05/17/2013 12:50 AM, Vladimir Kozlov wrote:
>> You forgot to change != to ==
>> 
>> +        if (_cp->symbol_at(group_index)->utf8_length() != 0) {
>> +          group_index = 0; // default contended group
>> 
>> Otherwise it is good. Thank you for the comment.
> 
> Darn. Now I see why test renamings are good: it had actually regressed
> the 8003985 test.
> 
> Fixed:
>  http://cr.openjdk.java.net/~shade/8014509/webrev.03/
> 
> We need the second reviewer.
> 
> -Aleksey.
> 


From aleksey.shipilev at oracle.com  Thu May 16 14:59:41 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Fri, 17 May 2013 01:59:41 +0400
Subject: RFR (XS) CR 8014509: @Contended: explicit default value behaves
	differently from the implicit value
In-Reply-To: <3BF2D919-2F26-4FF2-9B6A-6E08F2C31F76@oracle.com>
References: <5193AB67.2050201@oracle.com> <5193B902.3070006@oracle.com>
	<5193BA05.2010201@oracle.com> <5193BCED.60004@oracle.com>
	<51953538.6040701@oracle.com> <5195467E.3050007@oracle.com>
	<51954EBC.4010609@oracle.com>
	<3BF2D919-2F26-4FF2-9B6A-6E08F2C31F76@oracle.com>
Message-ID: <519556CD.60809@oracle.com>

On 05/17/2013 01:52 AM, Christian Thalinger wrote:
> Looks good.  -- Chris
> 
> On May 16, 2013, at 2:25 PM, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
> 
>> On 05/17/2013 12:50 AM, Vladimir Kozlov wrote:
>>> You forgot to change != to ==
>>>
>>> +        if (_cp->symbol_at(group_index)->utf8_length() != 0) {
>>> +          group_index = 0; // default contended group
>>>
>>> Otherwise it is good. Thank you for the comment.
>>
>> Darn. Now I see why test renamings are good: it had actually regressed
>> the 8003985 test.
>>
>> Fixed:
>>  http://cr.openjdk.java.net/~shade/8014509/webrev.03/
>>
>> We need the second reviewer.

Great, thanks.

Any sponsors around? :) Please push:
 http://cr.openjdk.java.net/~shade/8014509/8014509.changeset

-Aleksey.


From John.Coomes at oracle.com  Thu May 16 16:32:42 2013
From: John.Coomes at oracle.com (John Coomes)
Date: Thu, 16 May 2013 16:32:42 -0700
Subject: CFV: New hsx Committer: Thomas Schatzl
In-Reply-To: <519345DF.2030207@oracle.com>
References: <519345DF.2030207@oracle.com>
Message-ID: <20885.27802.988199.343086@oracle.com>

Vote: yes

-John

From david.holmes at oracle.com  Thu May 16 17:28:07 2013
From: david.holmes at oracle.com (David Holmes)
Date: Fri, 17 May 2013 10:28:07 +1000
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <519553AF.8090805@oracle.com>
References: <5192B99B.50405@oracle.com>
	<FD45D2AE-DAF2-49F9-B948-963C003351C9@oracle.com>
	<519553AF.8090805@oracle.com>
Message-ID: <51957997.2040407@oracle.com>

I will sponsor the push to hotspot-rt.

Thanks,
David

On 17/05/2013 7:46 AM, Aleksey Shipilev wrote:
> On 05/17/2013 01:31 AM, John Rose wrote:
>> On May 14, 2013, at 3:24 PM, Aleksey Shipilev
>> <aleksey.shipilev at oracle.com <mailto:aleksey.shipilev at oracle.com>> wrote:
>>
>>> It seems we have a plenty of failures in new SQE tests for @Contended
>>> because of this. Please see the updated webrev for the issue:
>>>   http://cr.openjdk.java.net/~shade/8012939/webrev.01/
>>> <http://cr.openjdk.java.net/%7Eshade/8012939/webrev.01/>
>>>
>>> This is the minimal fix.
>>
>> Aleksey, you can count me as a reviewer on the minimal fix.
>
> Thanks!
>
> For the record, the updated webrev with test renaming is here:
>    http://cr.openjdk.java.net/~shade/8012939/webrev.03/
>
> Now I need a sponsor to push this. The changeset with all the meta-info
> is here:
>    http://cr.openjdk.java.net/~shade/8012939/8012939.changeset
>
> -Aleksey.
>

From david.holmes at oracle.com  Thu May 16 19:04:15 2013
From: david.holmes at oracle.com (David Holmes)
Date: Fri, 17 May 2013 12:04:15 +1000
Subject: RFR (XS) CR 8014509: @Contended: explicit default value behaves
	differently from the implicit value
In-Reply-To: <519556CD.60809@oracle.com>
References: <5193AB67.2050201@oracle.com> <5193B902.3070006@oracle.com>
	<5193BA05.2010201@oracle.com> <5193BCED.60004@oracle.com>
	<51953538.6040701@oracle.com> <5195467E.3050007@oracle.com>
	<51954EBC.4010609@oracle.com>
	<3BF2D919-2F26-4FF2-9B6A-6E08F2C31F76@oracle.com>
	<519556CD.60809@oracle.com>
Message-ID: <5195901F.9070201@oracle.com>

Sponsored and submitted to JPRT.

David

On 17/05/2013 7:59 AM, Aleksey Shipilev wrote:
> On 05/17/2013 01:52 AM, Christian Thalinger wrote:
>> Looks good.  -- Chris
>>
>> On May 16, 2013, at 2:25 PM, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
>>
>>> On 05/17/2013 12:50 AM, Vladimir Kozlov wrote:
>>>> You forgot to change != to ==
>>>>
>>>> +        if (_cp->symbol_at(group_index)->utf8_length() != 0) {
>>>> +          group_index = 0; // default contended group
>>>>
>>>> Otherwise it is good. Thank you for the comment.
>>>
>>> Darn. Now I see why test renamings are good: it had actually regressed
>>> the 8003985 test.
>>>
>>> Fixed:
>>>   http://cr.openjdk.java.net/~shade/8014509/webrev.03/
>>>
>>> We need the second reviewer.
>
> Great, thanks.
>
> Any sponsors around? :) Please push:
>   http://cr.openjdk.java.net/~shade/8014509/8014509.changeset
>
> -Aleksey.
>

From alejandro.murillo at oracle.com  Thu May 16 19:56:07 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 17 May 2013 02:56:07 +0000
Subject: hg: hsx/hsx24/hotspot: 6 new changesets
Message-ID: <20130517025622.9283A48B32@hg.openjdk.java.net>

Changeset: 6955417355e3
Author:    aywang
Date:      2013-05-09 15:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/6955417355e3

8014129: makefile changes to allow integration of new features
Reviewed-by: tbell, robilad

! make/windows/makefiles/compile.make
! make/windows/makefiles/defs.make

Changeset: b6796efaadca
Author:    lana
Date:      2013-05-10 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/b6796efaadca

Merge


Changeset: a8a071629df4
Author:    amurillo
Date:      2013-05-14 15:18 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/a8a071629df4

Merge


Changeset: 7c93562242eb
Author:    katleman
Date:      2013-05-16 12:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/7c93562242eb

Added tag jdk7u40-b25 for changeset a8a071629df4

! .hgtags

Changeset: 69fecd3e0689
Author:    amurillo
Date:      2013-05-16 16:09 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/69fecd3e0689

Merge


Changeset: 43fd44b89792
Author:    amurillo
Date:      2013-05-16 16:09 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/43fd44b89792

Added tag hs24-b45 for changeset 69fecd3e0689

! .hgtags


From john.coomes at oracle.com  Thu May 16 20:31:58 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 17 May 2013 03:31:58 +0000
Subject: hg: hsx/hotspot-main: 9 new changesets
Message-ID: <20130517033158.DBECD48B33@hg.openjdk.java.net>

Changeset: e34781a0566b
Author:    mduigou
Date:      2013-04-24 21:46 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/e34781a0566b

8013185: Add java.util.stream to CORE_PKGS.gmk in root repo
Reviewed-by: mduigou
Contributed-by: Henry Jen <henry.jen at oracle.com>

! common/makefiles/javadoc/CORE_PKGS.gmk

Changeset: e4794ae1016e
Author:    mduigou
Date:      2013-04-24 21:46 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/e4794ae1016e

Merge


Changeset: 10775618db00
Author:    aharlap
Date:      2013-04-26 15:54 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/10775618db00

8011152: Precision problems on sflt builds
Summary: Need to add global flag to the linker
Reviewed-by: tbell, dholmes

! common/makefiles/NativeCompilation.gmk

Changeset: a7a8302473d3
Author:    mduigou
Date:      2013-04-29 14:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/a7a8302473d3

8008632: Additional JavaDoc tags @apiNote, @implSpec and @implNote
Reviewed-by: briangoetz, alanb, rriggs

! common/makefiles/javadoc/Javadoc.gmk

Changeset: f171aa801ea5
Author:    mduigou
Date:      2013-04-29 14:21 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/f171aa801ea5

Merge


Changeset: 1603c9216e83
Author:    lana
Date:      2013-04-30 17:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/1603c9216e83

Merge


Changeset: 892a0196d10c
Author:    lana
Date:      2013-05-06 11:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/892a0196d10c

Merge

! common/makefiles/NativeCompilation.gmk

Changeset: 69b773a221b9
Author:    katleman
Date:      2013-05-09 10:03 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/69b773a221b9

Added tag jdk8-b89 for changeset 892a0196d10c

! .hgtags

Changeset: 83b519cafa68
Author:    katleman
Date:      2013-05-16 12:13 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/83b519cafa68

Added tag jdk8-b90 for changeset 69b773a221b9

! .hgtags


From john.coomes at oracle.com  Thu May 16 20:32:03 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 17 May 2013 03:32:03 +0000
Subject: hg: hsx/hotspot-main/corba: 6 new changesets
Message-ID: <20130517033209.EE66B48B34@hg.openjdk.java.net>

Changeset: 8f0a461776a9
Author:    dmeetry
Date:      2013-04-29 16:44 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/8f0a461776a9

4504275: CORBA boolean type unions do not generate compilable code from idlj
Summary: JLS doesn't allow boolean type in switch statement, hence substituted by if statement.
Reviewed-by: lancea

! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/UnionGen.java

Changeset: 846aaf02e516
Author:    dmeetry
Date:      2013-04-29 16:51 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/846aaf02e516

8011986: [corba] idlj generates read/write union helper methods that throw wrong exception in some cases
Reviewed-by: lancea

! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/UnionGen.java

Changeset: ed59110eecdb
Author:    lana
Date:      2013-04-30 17:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/ed59110eecdb

Merge


Changeset: fe4150590ee5
Author:    lana
Date:      2013-05-06 11:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/fe4150590ee5

Merge


Changeset: c8286839d0df
Author:    katleman
Date:      2013-05-09 10:03 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/c8286839d0df

Added tag jdk8-b89 for changeset fe4150590ee5

! .hgtags

Changeset: 8f7ffb296385
Author:    katleman
Date:      2013-05-16 12:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/8f7ffb296385

Added tag jdk8-b90 for changeset c8286839d0df

! .hgtags


From john.coomes at oracle.com  Thu May 16 20:32:45 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 17 May 2013 03:32:45 +0000
Subject: hg: hsx/hotspot-main/jaxws: 2 new changesets
Message-ID: <20130517033254.BC92B48B36@hg.openjdk.java.net>

Changeset: 3e5b9ea5ac35
Author:    katleman
Date:      2013-05-09 10:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/3e5b9ea5ac35

Added tag jdk8-b89 for changeset 88838e08e4ef

! .hgtags

Changeset: 0bb1a9fa56b0
Author:    katleman
Date:      2013-05-16 12:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/0bb1a9fa56b0

Added tag jdk8-b90 for changeset 3e5b9ea5ac35

! .hgtags


From john.coomes at oracle.com  Thu May 16 20:32:15 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 17 May 2013 03:32:15 +0000
Subject: hg: hsx/hotspot-main/jaxp: 7 new changesets
Message-ID: <20130517033240.1900F48B35@hg.openjdk.java.net>

Changeset: fad6560cb32a
Author:    dfuchs
Date:      2013-04-17 15:23 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/fad6560cb32a

8005954: JAXP Plugability Layer should use java.util.ServiceLoader
Summary: This fix replaces manual processing of files under META-INF/services in JAXP factories by calls to java.util.ServiceLoader.
Reviewed-by: alanb, joehw, mchung

! src/javax/xml/datatype/DatatypeFactory.java
! src/javax/xml/datatype/FactoryFinder.java
! src/javax/xml/parsers/DocumentBuilderFactory.java
! src/javax/xml/parsers/FactoryFinder.java
! src/javax/xml/parsers/SAXParserFactory.java
! src/javax/xml/stream/FactoryFinder.java
! src/javax/xml/stream/XMLEventFactory.java
! src/javax/xml/stream/XMLInputFactory.java
! src/javax/xml/stream/XMLOutputFactory.java
! src/javax/xml/transform/FactoryFinder.java
! src/javax/xml/transform/TransformerFactory.java
! src/javax/xml/validation/SchemaFactory.java
+ src/javax/xml/validation/SchemaFactoryConfigurationError.java
! src/javax/xml/validation/SchemaFactoryFinder.java
! src/javax/xml/xpath/XPathFactory.java
! src/javax/xml/xpath/XPathFactoryFinder.java

Changeset: 1c2079d11a79
Author:    dfuchs
Date:      2013-04-19 17:22 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/1c2079d11a79

8010495: Update JAXP NetBeans project - add support for generating javadoc
Summary: Make it possible to use NetBeans to edit the jaxp sources and to generate a preview of the associated javadoc.
Reviewed-by: joehw, alanb

! build.xml
! nbproject/project.xml

Changeset: 6c6411a7070f
Author:    lana
Date:      2013-04-23 15:03 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/6c6411a7070f

Merge


Changeset: be5d6853d821
Author:    lana
Date:      2013-04-30 17:50 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/be5d6853d821

Merge


Changeset: 893d2ba8bbea
Author:    lana
Date:      2013-05-06 11:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/893d2ba8bbea

Merge


Changeset: 668acc0e1034
Author:    katleman
Date:      2013-05-09 10:03 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/668acc0e1034

Added tag jdk8-b89 for changeset 893d2ba8bbea

! .hgtags

Changeset: f39d61028d2f
Author:    katleman
Date:      2013-05-16 12:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/f39d61028d2f

Added tag jdk8-b90 for changeset 668acc0e1034

! .hgtags


From john.coomes at oracle.com  Thu May 16 20:36:31 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 17 May 2013 03:36:31 +0000
Subject: hg: hsx/hotspot-main/jdk: 81 new changesets
Message-ID: <20130517035331.BEFFF48B38@hg.openjdk.java.net>

Changeset: b0c41789f500
Author:    jgodinez
Date:      2013-04-25 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b0c41789f500

8009199: Printed text become garbage on Mac OSX
Reviewed-by: bae, prr

! src/macosx/native/sun/awt/CTextPipe.m

Changeset: f4aa34a7a44d
Author:    jchen
Date:      2013-04-29 10:02 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/f4aa34a7a44d

8005302: [findbugs] public methods return internal arrays; may be private
Reviewed-by: bae, prr

! src/share/classes/sun/java2d/pipe/AAShapePipe.java

Changeset: 46686202aa23
Author:    lana
Date:      2013-04-30 22:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/46686202aa23

Merge


Changeset: c70346f4c0a9
Author:    pchelko
Date:      2013-04-18 15:09 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c70346f4c0a9

8011686: AWT accidentally disables the NSApplicationDelegate of SWT, causing loss of OS X integration functionality
Reviewed-by: anthony, serb
Contributed-by: Markus Persson <markus.persson at oracle.com>

! src/macosx/native/sun/awt/awt.m

Changeset: ac92ac05dde4
Author:    kshefov
Date:      2013-04-22 18:39 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ac92ac05dde4

8011230: [TEST_BUG] java/awt/Toolkit/BadDisplayTest/BadDisplayTest.java failed on solaris
Reviewed-by: serb, anthony

! test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.sh

Changeset: 578fb8766200
Author:    leonidr
Date:      2013-04-22 19:24 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/578fb8766200

8008366: [macosx] ActionListener called twice for JMenuItem using ScreenMenuBar
Reviewed-by: anthony, serb

! src/macosx/native/sun/awt/AWTEvent.h
! src/macosx/native/sun/awt/AWTEvent.m
! src/macosx/native/sun/awt/CMenuItem.m
! test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java

Changeset: 0894b8476a49
Author:    lana
Date:      2013-04-23 15:17 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/0894b8476a49

Merge

- src/share/classes/java/time/chrono/HijrahDeviationReader.java
- src/share/classes/java/time/format/DateTimeBuilder.java
- src/share/classes/java/time/format/DateTimeFormatStyleProvider.java
- src/share/classes/java/time/temporal/Adjusters.java
- src/share/classes/java/time/temporal/Queries.java
- src/share/classes/sun/java2d/cmm/lcms/META-INF/services/sun.java2d.cmm.PCMM
- src/share/native/java/lang/ResourceBundle.c
- test/java/time/tck/java/time/TestChronology.java
- test/java/time/tck/java/time/chrono/TestChronoLocalDate.java
- test/java/time/tck/java/time/chrono/TestChronoLocalDateTime.java
- test/java/time/tck/java/time/chrono/TestHijrahChronology.java
- test/java/time/tck/java/time/chrono/TestJapaneseChronology.java
- test/java/time/tck/java/time/chrono/TestMinguoChronology.java
- test/java/time/tck/java/time/chrono/TestThaiBuddhistChronology.java
- test/java/time/tck/java/time/temporal/TCKDateTimeAdjusters.java
- test/java/time/tck/java/time/temporal/TestChronoLocalDate.java
- test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java
- test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java
- test/java/time/test/java/time/temporal/TestDateTimeAdjusters.java
- test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java
- test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java
- test/java/util/ComparatorsTest.java

Changeset: 7103434eefe2
Author:    kshefov
Date:      2013-04-24 11:48 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7103434eefe2

8011186: [TEST_BUG] java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java failed on windows 8
Reviewed-by: anthony, serb, ant

- test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java
+ test/java/awt/Focus/SimpleWindowActivationTest/SimpleWindowActivationTest.java

Changeset: 854f60ec4bfb
Author:    anthony
Date:      2013-04-26 18:48 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/854f60ec4bfb

8012586: [x11] Modal dialogs for fullscreen window may show behind its owner
Summary: Use the _NET_WM_WINDOW_TYPE_DIALOG type for owned windows
Reviewed-by: anthony, art, serb
Contributed-by: Vladimir Kravets <vova.kravets at gmail.com>

! src/solaris/classes/sun/awt/X11/XWindowPeer.java
+ test/java/awt/WMSpecificTests/Metacity/FullscreenDialogModality.java

Changeset: e76f3e8e653f
Author:    malenkov
Date:      2013-04-29 16:42 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e76f3e8e653f

8007458: [findbugs] One more beans issue, with ReflectionUtils
Reviewed-by: art, alexsch

! src/share/classes/java/beans/MetaData.java
- src/share/classes/java/beans/ReflectionUtils.java
! src/share/classes/java/beans/XMLEncoder.java
! test/java/beans/XMLEncoder/AbstractTest.java
! test/java/beans/XMLEncoder/BeanValidator.java
! test/java/beans/XMLEncoder/Test4631471.java
! test/java/beans/XMLEncoder/Test4679556.java
! test/java/beans/XMLEncoder/java_awt_BorderLayout.java
+ test/java/beans/XMLEncoder/java_awt_CardLayout.java
+ test/java/beans/XMLEncoder/java_awt_GridBagLayout.java
! test/java/beans/XMLEncoder/javax_swing_DefaultCellEditor.java

Changeset: 358acb00cb2d
Author:    mcherkas
Date:      2013-04-30 13:24 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/358acb00cb2d

8012004: JInternalFrame not being finalized after closing
Reviewed-by: alexsch, alexp

! src/share/classes/javax/swing/JDesktopPane.java
+ test/javax/swing/JInternalFrame/InternalFrameIsNotCollectedTest.java

Changeset: 31e111f82993
Author:    serb
Date:      2013-04-30 17:27 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/31e111f82993

7166296: closed/java/awt/Frame/DisabledParentOfToplevel/DisabledParentOfToplevel.html failed since 1.8.0b36
Reviewed-by: anthony, art

! src/macosx/classes/sun/lwawt/LWComponentPeer.java
! src/macosx/classes/sun/lwawt/LWWindowPeer.java
! src/share/classes/java/awt/Component.java
! src/share/classes/java/awt/Window.java
! src/windows/classes/sun/awt/windows/WComponentPeer.java
! src/windows/classes/sun/awt/windows/WWindowPeer.java

Changeset: caeedce39396
Author:    serb
Date:      2013-05-01 12:19 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/caeedce39396

8009012: [macosx] DisplayChangedListener is not implemented in LWWindowPeer/CGraphicsEnvironment
Reviewed-by: anthony, bae

! src/macosx/classes/sun/awt/CGraphicsDevice.java
! src/macosx/classes/sun/awt/CGraphicsEnvironment.java
! src/macosx/classes/sun/lwawt/LWWindowPeer.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java
! src/macosx/native/sun/awt/CGraphicsEnv.m
! src/macosx/native/sun/java2d/opengl/CGLLayer.m

Changeset: c357c11f076f
Author:    lana
Date:      2013-05-01 09:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c357c11f076f

Merge


Changeset: 920ad6c95d93
Author:    lana
Date:      2013-05-01 11:27 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/920ad6c95d93

Merge

- src/share/classes/java/beans/ReflectionUtils.java
- test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java

Changeset: 296c9ec816c6
Author:    alanb
Date:      2013-04-18 11:13 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/296c9ec816c6

8011536: (fs) BasicFileAttributes.creationTime() should return birth time (mac)
Reviewed-by: chegar

! src/share/classes/java/nio/file/attribute/BasicFileAttributeView.java
! src/solaris/classes/sun/nio/fs/UnixChannelFactory.java
! src/solaris/classes/sun/nio/fs/UnixCopyFile.java
! src/solaris/classes/sun/nio/fs/UnixFileAttributeViews.java
! src/solaris/classes/sun/nio/fs/UnixFileAttributes.java
! src/solaris/classes/sun/nio/fs/UnixFileSystemProvider.java
! src/solaris/classes/sun/nio/fs/UnixNativeDispatcher.java
! src/solaris/classes/sun/nio/fs/UnixPath.java
! src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c
! test/java/nio/file/attribute/BasicFileAttributeView/Basic.java
+ test/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java

Changeset: 3c8724085cf7
Author:    alanb
Date:      2013-04-18 12:24 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3c8724085cf7

8009648: Tests fail in -agentvm -concurrency mode
Reviewed-by: alanb
Contributed-by: roger.riggs at oracle.com

! test/Makefile
! test/java/time/TEST.properties

Changeset: 3cc833b1fd0c
Author:    dxu
Date:      2013-04-18 10:22 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3cc833b1fd0c

8011946: java.util.Currency javadoc has broken link to iso.org
Reviewed-by: mduigou

! src/share/classes/java/util/Currency.java

Changeset: 32c3a580812b
Author:    mchung
Date:      2013-04-18 11:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/32c3a580812b

8012624: Add sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java in ProblemList.txt
Reviewed-by: lancea, alanb

! test/ProblemList.txt

Changeset: 3b81fac25d26
Author:    mchung
Date:      2013-04-18 13:02 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3b81fac25d26

8011934: sun.misc.PerfCounter calls Perf.createLong with incorrect parameters
Reviewed-by: mchung
Contributed-by: Yasumasa Suenaga <yasu at ysfactory.dip.jp>

! src/share/classes/sun/misc/PerfCounter.java

Changeset: 3e4a0fddeb00
Author:    jgish
Date:      2013-04-18 16:33 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3e4a0fddeb00

8012005: LogManager needs test to ensure stack trace is not being done to find bundle
Reviewed-by: mchung

+ test/java/util/logging/bundlesearch/ClassPathTestBundle_en.properties
+ test/java/util/logging/bundlesearch/IndirectlyLoadABundle.java
+ test/java/util/logging/bundlesearch/LoadItUp.java
+ test/java/util/logging/bundlesearch/ResourceBundleSearchTest.java
+ test/java/util/logging/bundlesearch/resources/ContextClassLoaderTestBundle_en.properties
+ test/java/util/logging/bundlesearch/resources/StackSearchableResource_en.properties

Changeset: 7bdb3e186497
Author:    xuelei
Date:      2013-04-18 22:23 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7bdb3e186497

8006935: Need to take care of long secret keys in HMAC/PRF compuation
Reviewed-by: valeriep

! src/share/classes/com/sun/crypto/provider/TlsPrfGenerator.java

Changeset: 778b16225d85
Author:    weijun
Date:      2013-04-19 15:41 +0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/778b16225d85

8009636: JARSigner including TimeStamp PolicyID (TSAPolicyID) as defined in RFC3161
Reviewed-by: mullan

! src/share/classes/com/sun/jarsigner/ContentSignerParameters.java
! src/share/classes/sun/security/pkcs/PKCS7.java
! src/share/classes/sun/security/timestamp/TSRequest.java
! src/share/classes/sun/security/timestamp/TimestampToken.java
! src/share/classes/sun/security/tools/jarsigner/Main.java
! src/share/classes/sun/security/tools/jarsigner/Resources.java
! src/share/classes/sun/security/tools/jarsigner/TimestampedSigner.java
! test/sun/security/tools/jarsigner/TimestampCheck.java
! test/sun/security/tools/jarsigner/ts.sh

Changeset: 90b03f9a2e77
Author:    jzavgren
Date:      2013-04-17 11:47 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/90b03f9a2e77

8010505: HTTP DIGEST implementation incorrectly quotes header values, fails auth
Summary: The extraneous quotes were removed.
Reviewed-by: chegar

! src/share/classes/sun/net/www/protocol/http/DigestAuthentication.java

Changeset: 6139f8fb0137
Author:    mduigou
Date:      2013-04-16 22:50 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/6139f8fb0137

8008670: Initial java.util.stream putback -- internal API classes
Reviewed-by: mduigou, dholmes
Contributed-by: Brian Goetz <brian.goetz at oracle.com>, Doug Lea <dl at cs.oswego.edu>, Paul Sandoz <paul.sandoz at oracle.com>

+ src/share/classes/java/util/stream/AbstractShortCircuitTask.java
+ src/share/classes/java/util/stream/AbstractTask.java
+ src/share/classes/java/util/stream/FindOps.java
+ src/share/classes/java/util/stream/ForEachOps.java
+ src/share/classes/java/util/stream/MatchOps.java
+ src/share/classes/java/util/stream/Node.java
+ src/share/classes/java/util/stream/PipelineHelper.java
+ src/share/classes/java/util/stream/Sink.java
+ src/share/classes/java/util/stream/StreamOpFlag.java
+ src/share/classes/java/util/stream/StreamShape.java
+ src/share/classes/java/util/stream/TerminalOp.java
+ src/share/classes/java/util/stream/TerminalSink.java
+ src/share/classes/java/util/stream/Tripwire.java

Changeset: e8f1dc6d0c0c
Author:    jgish
Date:      2013-04-19 16:50 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e8f1dc6d0c0c

8010939: Deadlock in LogManager
Summary: re-order locks to avoid deadlock
Reviewed-by: mchung

! src/share/classes/java/util/logging/LogManager.java
+ test/java/util/logging/DrainFindDeadlockTest.java

Changeset: 22a27dfd0510
Author:    weijun
Date:      2013-04-22 11:39 +0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/22a27dfd0510

8005527: [TEST_BUG] console.sh failed Automatically with exit code 1.
Reviewed-by: xuelei

! test/sun/security/tools/keytool/console.sh

Changeset: 3ca33647db95
Author:    akhil
Date:      2013-04-22 09:19 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3ca33647db95

8001647: default methods for Collections - forEach, removeIf, replaceAll, sort
Reviewed-by: alanb, dholmes, mduigou, psandoz, smarks
Contributed-by: Akhil Arora <akhil.arora at oracle.com>, Arne Siegel <v.a.ammodytes at googlemail.com>, Brian Goetz <brian.goetz at oracle.com>

! src/share/classes/java/util/ArrayList.java
! src/share/classes/java/util/Collection.java
! src/share/classes/java/util/Collections.java
! src/share/classes/java/util/List.java
! src/share/classes/java/util/Vector.java
! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java
+ test/java/util/Collection/CollectionDefaults.java
+ test/java/util/Collection/ListDefaults.java
+ test/java/util/Collection/testlibrary/CollectionAsserts.java
+ test/java/util/Collection/testlibrary/CollectionSupplier.java

Changeset: 2a78d8f1fec1
Author:    briangoetz
Date:      2013-04-17 14:39 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/2a78d8f1fec1

8008682: Inital Streams public API
Reviewed-by: mduigou, dholmes, darcy
Contributed-by: Brian Goetz <brian.goetz at oracle.com>, Mike Duigou <mike.duigou at oracle.com>, Paul Sandoz <paul.sandoz at oracle.com>, JSR-335 EG <lambda-libs-spec-experts at openjdk.java.net>

+ src/share/classes/java/util/stream/BaseStream.java
+ src/share/classes/java/util/stream/CloseableStream.java
+ src/share/classes/java/util/stream/Collector.java
+ src/share/classes/java/util/stream/DelegatingStream.java
+ src/share/classes/java/util/stream/DoubleStream.java
+ src/share/classes/java/util/stream/IntStream.java
+ src/share/classes/java/util/stream/LongStream.java
+ src/share/classes/java/util/stream/Stream.java
+ src/share/classes/java/util/stream/package-info.java

Changeset: 98a7bb7baa76
Author:    psandoz
Date:      2013-04-17 11:34 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/98a7bb7baa76

8011426: java.util collection Spliterator implementations
Summary: Spliterator implementations for collection classes in java.util.
Reviewed-by: mduigou, briangoetz
Contributed-by: Doug Lea <dl at cs.oswego.edu>, Paul Sandoz <paul.sandoz at oracle.com>

! src/share/classes/java/util/ArrayDeque.java
! src/share/classes/java/util/ArrayList.java
! src/share/classes/java/util/Collections.java
! src/share/classes/java/util/HashMap.java
! src/share/classes/java/util/HashSet.java
! src/share/classes/java/util/IdentityHashMap.java
! src/share/classes/java/util/LinkedHashSet.java
! src/share/classes/java/util/LinkedList.java
! src/share/classes/java/util/PriorityQueue.java
! src/share/classes/java/util/TreeMap.java
! src/share/classes/java/util/TreeSet.java
! src/share/classes/java/util/Vector.java
! src/share/classes/java/util/WeakHashMap.java
! test/java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java

Changeset: 62fb9e2b5da1
Author:    naoto
Date:      2013-04-22 13:37 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/62fb9e2b5da1

8010666: Implement Currency/LocaleNameProvider in Windows Host LocaleProviderAdapter
Reviewed-by: okutsu

! src/macosx/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java
! src/windows/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java
! src/windows/native/sun/util/locale/provider/HostLocaleProviderAdapter_md.c
! test/java/util/Locale/LocaleProviders.java
! test/java/util/Locale/LocaleProviders.sh

Changeset: 8b07b318f713
Author:    alanb
Date:      2013-04-23 15:01 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/8b07b318f713

8012930: (fs) Eliminate recursion from FileTreeWalker
Reviewed-by: chegar

! src/share/classes/java/nio/file/FileTreeWalker.java
! src/share/classes/java/nio/file/Files.java
! test/java/nio/file/Files/walkFileTree/CreateFileTree.java
! test/java/nio/file/Files/walkFileTree/MaxDepth.java
! test/java/nio/file/Files/walkFileTree/SkipSiblings.java
+ test/java/nio/file/Files/walkFileTree/SkipSubtree.java
! test/java/nio/file/Files/walkFileTree/TerminateWalk.java
+ test/java/nio/file/Files/walkFileTree/find.sh
- test/java/nio/file/Files/walkFileTree/walk_file_tree.sh

Changeset: b456f25c2075
Author:    lancea
Date:      2013-04-23 11:17 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b456f25c2075

8011620: adding free form netbeans project for jdbc to jdk/make/netbeans
Reviewed-by: chegar

! make/netbeans/common/shared.xml
+ make/netbeans/jdbc/README
+ make/netbeans/jdbc/build.properties
+ make/netbeans/jdbc/build.xml
+ make/netbeans/jdbc/nbproject/project.xml

Changeset: 57b02a7558f3
Author:    lana
Date:      2013-04-23 15:07 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/57b02a7558f3

Merge

- src/share/classes/sun/java2d/cmm/lcms/META-INF/services/sun.java2d.cmm.PCMM

Changeset: 754c9bb4f085
Author:    sla
Date:      2013-04-24 14:49 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/754c9bb4f085

8009985: [parfait] Uninitialised variable at jdk/src/solaris/native/com/sun/management/UnixOperatingSystem_md.c
Reviewed-by: sla, rbackman, alanb, dholmes, rdurbin
Contributed-by: peter.allwin at oracle.com

! src/solaris/native/com/sun/management/UnixOperatingSystem_md.c

Changeset: bbcebf893b83
Author:    alanb
Date:      2013-04-24 19:03 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/bbcebf893b83

8005555: TEST_BUG: java/io/Serializable/accessConstants/AccessConstants.java should be removed
Reviewed-by: chegar

- test/java/io/Serializable/accessConstants/AccessConstants.java

Changeset: 8c06a38aa2c5
Author:    sherman
Date:      2013-04-24 21:27 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/8c06a38aa2c5

8012638: test/java/time/test/java/util/TestFormatter fails in UTC TZ
Summary: updated the offending test case
Reviewed-by: alanb

! test/java/time/test/java/util/TestFormatter.java

Changeset: 4da1d43f5843
Author:    darcy
Date:      2013-04-25 09:37 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/4da1d43f5843

8012044: Give more information about self-suppression from Throwable.addSuppressed
Reviewed-by: alanb, dholmes

! src/share/classes/java/lang/Throwable.java
! test/java/lang/Throwable/SuppressedExceptions.java

Changeset: ca0957f0d408
Author:    emc
Date:      2013-04-25 14:23 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ca0957f0d408

8012937: Correct errors in javadoc comments.
Summary: Correct some errors in the javadoc comments for parameter reflection.
Reviewed-by: darcy

! src/share/classes/java/lang/reflect/Executable.java
! src/share/classes/java/lang/reflect/Parameter.java

Changeset: 5871d7b1673c
Author:    coffeys
Date:      2013-04-25 21:12 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5871d7b1673c

8000529: Regression: SimpleDateFormat incorrectly parses dates formatted with Z and z pattern letters
Reviewed-by: okutsu

! src/share/classes/java/text/CalendarBuilder.java
! src/share/classes/java/text/SimpleDateFormat.java
! test/java/text/Format/DateFormat/Bug7130335.java

Changeset: b600d637ef77
Author:    wetmore
Date:      2013-04-25 17:10 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b600d637ef77

8012530: test/sun/security/provider/SecureRandom/StrongSeedReader.java failing
Reviewed-by: wetmore
Contributed-by: alan.bateman at oracle.com

! test/sun/security/provider/SecureRandom/StrongSeedReader.java

Changeset: a8da4e516bc3
Author:    akhil
Date:      2013-04-23 11:54 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/a8da4e516bc3

8005051: optimized defaults for Iterator.forEachRemaining
Reviewed-by: alanb, mduigou, psandoz, ulfzibis
Contributed-by: Akhil Arora <akhil.arora at oracle.com>

! src/share/classes/java/util/ArrayList.java
! src/share/classes/java/util/LinkedList.java
! src/share/classes/java/util/Vector.java
! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java

Changeset: ceeed0fcb371
Author:    jgish
Date:      2013-04-02 18:41 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ceeed0fcb371

5015163: (str) String merge/join that is the inverse of String.split()
7172553: A utility class that forms the basis of a String.join() operation
Summary: Integrate StringJoiner changes from lambda
Reviewed-by: alanb, mduigou

! make/java/java/FILES_java.gmk
! src/share/classes/java/lang/String.java
+ src/share/classes/java/util/StringJoiner.java
+ test/java/lang/String/StringJoinTest.java
+ test/java/util/StringJoiner/StringJoinerTest.java

Changeset: 2cb55846c9bb
Author:    mduigou
Date:      2013-04-24 16:15 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/2cb55846c9bb

8011920: Main streams implementation
8012542: Stream methods on Collection
Reviewed-by: dholmes, mduigou
Contributed-by: Brian Goetz <brian.goetz at oracle.com>, Mike Duigou <mike.duigou at oracle.com>, Paul Sandoz <paul.sandoz at oracle.com>

! make/docs/CORE_PKGS.gmk
! src/share/classes/java/util/Collection.java
+ src/share/classes/java/util/stream/AbstractPipeline.java
+ src/share/classes/java/util/stream/AbstractSpinedBuffer.java
+ src/share/classes/java/util/stream/DistinctOps.java
+ src/share/classes/java/util/stream/DoublePipeline.java
+ src/share/classes/java/util/stream/IntPipeline.java
+ src/share/classes/java/util/stream/LongPipeline.java
+ src/share/classes/java/util/stream/Nodes.java
+ src/share/classes/java/util/stream/ReduceOps.java
+ src/share/classes/java/util/stream/ReferencePipeline.java
+ src/share/classes/java/util/stream/SliceOps.java
+ src/share/classes/java/util/stream/SortedOps.java
+ src/share/classes/java/util/stream/SpinedBuffer.java
+ src/share/classes/java/util/stream/StreamSpliterators.java
+ src/share/classes/java/util/stream/StreamSupport.java

Changeset: 5144db7f0f88
Author:    sherman
Date:      2013-04-26 13:59 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5144db7f0f88

8007395: StringIndexOutofBoundsException in Match.find() when input String contains surrogate UTF-16 characters
Summary: updated GroupCurly.match0() to backtrack correctly
Reviewed-by: mchung

! src/share/classes/java/util/regex/Pattern.java
! test/java/util/regex/RegExTest.java

Changeset: f5fbd8065920
Author:    mfang
Date:      2013-03-25 16:49 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/f5fbd8065920

8010521: jdk8 l10n resource file translation update 2
Reviewed-by: naoto, yhuang

+ src/macosx/classes/com/apple/laf/resources/aqua_de.properties
+ src/macosx/classes/com/apple/laf/resources/aqua_es.properties
+ src/macosx/classes/com/apple/laf/resources/aqua_fr.properties
+ src/macosx/classes/com/apple/laf/resources/aqua_it.properties
+ src/macosx/classes/com/apple/laf/resources/aqua_ja.properties
+ src/macosx/classes/com/apple/laf/resources/aqua_ko.properties
+ src/macosx/classes/com/apple/laf/resources/aqua_pt_BR.properties
+ src/macosx/classes/com/apple/laf/resources/aqua_sv.properties
+ src/macosx/classes/com/apple/laf/resources/aqua_zh_CN.properties
+ src/macosx/classes/com/apple/laf/resources/aqua_zh_TW.properties
! src/share/classes/com/sun/accessibility/internal/resources/accessibility_pt_BR.properties
! src/share/classes/com/sun/accessibility/internal/resources/accessibility_zh_CN.properties
! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_de.properties
! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_es.properties
! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_fr.properties
! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_it.properties
! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_ja.properties
! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_ko.properties
! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_pt_BR.properties
! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_sv.properties
! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_zh_CN.properties
! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_zh_TW.properties
! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_de.properties
! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_es.properties
! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_fr.properties
! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_it.properties
! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_pt_BR.properties
! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_sv.properties
! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_CN.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_de.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_es.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_fr.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_it.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ja.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ko.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_pt_BR.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_sv.properties
! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_CN.properties
! src/share/classes/com/sun/rowset/RowSetResourceBundle_de.properties
! src/share/classes/com/sun/rowset/RowSetResourceBundle_es.properties
! src/share/classes/com/sun/rowset/RowSetResourceBundle_fr.properties
! src/share/classes/com/sun/rowset/RowSetResourceBundle_it.properties
! src/share/classes/com/sun/rowset/RowSetResourceBundle_ja.properties
! src/share/classes/com/sun/rowset/RowSetResourceBundle_ko.properties
! src/share/classes/com/sun/rowset/RowSetResourceBundle_pt_BR.properties
! src/share/classes/com/sun/rowset/RowSetResourceBundle_sv.properties
! src/share/classes/com/sun/rowset/RowSetResourceBundle_zh_CN.properties
! src/share/classes/com/sun/rowset/RowSetResourceBundle_zh_TW.properties
! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_de.properties
! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_es.properties
! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_fr.properties
! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_it.properties
! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ja.properties
! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ko.properties
! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_pt_BR.properties
! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_sv.properties
! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_CN.properties
! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_TW.properties
! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_de.properties
! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_es.properties
! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_fr.properties
! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_it.properties
! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ja.properties
! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ko.properties
! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_pt_BR.properties
! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_sv.properties
! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_CN.properties
! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_TW.properties
! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_de.properties
! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_es.properties
! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_fr.properties
! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_it.properties
! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_ja.properties
! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_ko.properties
! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_pt_BR.properties
! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_sv.properties
! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_zh_CN.properties
! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_zh_TW.properties
! src/share/classes/com/sun/tools/example/debug/tty/TTYResources_ja.java
! src/share/classes/com/sun/tools/example/debug/tty/TTYResources_zh_CN.java
! src/share/classes/sun/applet/resources/MsgAppletViewer_de.java
! src/share/classes/sun/applet/resources/MsgAppletViewer_ja.java
! src/share/classes/sun/applet/resources/MsgAppletViewer_pt_BR.java
! src/share/classes/sun/applet/resources/MsgAppletViewer_sv.java
! src/share/classes/sun/applet/resources/MsgAppletViewer_zh_CN.java
! src/share/classes/sun/awt/resources/awt_de.properties
! src/share/classes/sun/awt/resources/awt_es.properties
! src/share/classes/sun/awt/resources/awt_pt_BR.properties
! src/share/classes/sun/awt/resources/awt_zh_CN.properties
! src/share/classes/sun/launcher/resources/launcher_de.properties
! src/share/classes/sun/launcher/resources/launcher_es.properties
! src/share/classes/sun/launcher/resources/launcher_fr.properties
! src/share/classes/sun/launcher/resources/launcher_it.properties
! src/share/classes/sun/launcher/resources/launcher_ja.properties
! src/share/classes/sun/launcher/resources/launcher_ko.properties
! src/share/classes/sun/launcher/resources/launcher_pt_BR.properties
! src/share/classes/sun/launcher/resources/launcher_sv.properties
! src/share/classes/sun/launcher/resources/launcher_zh_CN.properties
! src/share/classes/sun/launcher/resources/launcher_zh_TW.properties
! src/share/classes/sun/management/resources/agent_de.properties
! src/share/classes/sun/management/resources/agent_es.properties
! src/share/classes/sun/management/resources/agent_fr.properties
! src/share/classes/sun/management/resources/agent_it.properties
! src/share/classes/sun/management/resources/agent_ja.properties
! src/share/classes/sun/management/resources/agent_ko.properties
! src/share/classes/sun/management/resources/agent_pt_BR.properties
! src/share/classes/sun/management/resources/agent_sv.properties
! src/share/classes/sun/management/resources/agent_zh_CN.properties
! src/share/classes/sun/management/resources/agent_zh_TW.properties
! src/share/classes/sun/misc/resources/Messages_de.java
! src/share/classes/sun/misc/resources/Messages_es.java
! src/share/classes/sun/misc/resources/Messages_fr.java
! src/share/classes/sun/misc/resources/Messages_it.java
! src/share/classes/sun/misc/resources/Messages_ja.java
! src/share/classes/sun/misc/resources/Messages_ko.java
! src/share/classes/sun/misc/resources/Messages_pt_BR.java
! src/share/classes/sun/misc/resources/Messages_sv.java
! src/share/classes/sun/misc/resources/Messages_zh_CN.java
! src/share/classes/sun/misc/resources/Messages_zh_TW.java
! src/share/classes/sun/print/resources/serviceui_de.properties
! src/share/classes/sun/print/resources/serviceui_es.properties
! src/share/classes/sun/print/resources/serviceui_fr.properties
! src/share/classes/sun/print/resources/serviceui_it.properties
! src/share/classes/sun/print/resources/serviceui_ja.properties
! src/share/classes/sun/print/resources/serviceui_ko.properties
! src/share/classes/sun/print/resources/serviceui_pt_BR.properties
! src/share/classes/sun/print/resources/serviceui_sv.properties
! src/share/classes/sun/print/resources/serviceui_zh_CN.properties
! src/share/classes/sun/print/resources/serviceui_zh_TW.properties
! src/share/classes/sun/rmi/registry/resources/rmiregistry_de.properties
! src/share/classes/sun/rmi/registry/resources/rmiregistry_es.properties
! src/share/classes/sun/rmi/registry/resources/rmiregistry_fr.properties
! src/share/classes/sun/rmi/registry/resources/rmiregistry_it.properties
! src/share/classes/sun/rmi/registry/resources/rmiregistry_ja.properties
! src/share/classes/sun/rmi/registry/resources/rmiregistry_ko.properties
! src/share/classes/sun/rmi/registry/resources/rmiregistry_pt_BR.properties
! src/share/classes/sun/rmi/registry/resources/rmiregistry_sv.properties
! src/share/classes/sun/rmi/registry/resources/rmiregistry_zh_CN.properties
! src/share/classes/sun/rmi/registry/resources/rmiregistry_zh_TW.properties
! src/share/classes/sun/rmi/rmic/resources/rmic_ja.properties
! src/share/classes/sun/rmi/rmic/resources/rmic_zh_CN.properties
! src/share/classes/sun/rmi/server/resources/rmid_de.properties
! src/share/classes/sun/rmi/server/resources/rmid_es.properties
! src/share/classes/sun/rmi/server/resources/rmid_fr.properties
! src/share/classes/sun/rmi/server/resources/rmid_it.properties
! src/share/classes/sun/rmi/server/resources/rmid_ja.properties
! src/share/classes/sun/rmi/server/resources/rmid_ko.properties
! src/share/classes/sun/rmi/server/resources/rmid_pt_BR.properties
! src/share/classes/sun/rmi/server/resources/rmid_sv.properties
! src/share/classes/sun/rmi/server/resources/rmid_zh_CN.properties
! src/share/classes/sun/rmi/server/resources/rmid_zh_TW.properties
! src/share/classes/sun/security/tools/jarsigner/Resources_ja.java
! src/share/classes/sun/security/tools/jarsigner/Resources_zh_CN.java
! src/share/classes/sun/security/util/AuthResources_pt_BR.java
! src/share/classes/sun/security/util/AuthResources_zh_TW.java
! src/share/classes/sun/security/util/Resources_es.java
! src/share/classes/sun/security/util/Resources_pt_BR.java
! src/share/classes/sun/tools/jar/resources/jar_de.properties
! src/share/classes/sun/tools/jar/resources/jar_es.properties
! src/share/classes/sun/tools/jar/resources/jar_fr.properties
! src/share/classes/sun/tools/jar/resources/jar_it.properties
! src/share/classes/sun/tools/jar/resources/jar_ja.properties
! src/share/classes/sun/tools/jar/resources/jar_ko.properties
! src/share/classes/sun/tools/jar/resources/jar_pt_BR.properties
! src/share/classes/sun/tools/jar/resources/jar_sv.properties
! src/share/classes/sun/tools/jar/resources/jar_zh_CN.properties
! src/share/classes/sun/tools/jar/resources/jar_zh_TW.properties
! src/share/classes/sun/tools/jconsole/resources/messages_ja.properties
! src/share/classes/sun/tools/jconsole/resources/messages_zh_CN.properties
! src/share/classes/sun/tools/native2ascii/resources/MsgNative2ascii_ja.java
! src/share/classes/sun/tools/native2ascii/resources/MsgNative2ascii_zh_CN.java
! src/share/demo/jfc/Notepad/resources/Notepad_ja.properties
! src/share/demo/jfc/Notepad/resources/Notepad_zh_CN.properties

Changeset: 6d8cd4f28a2f
Author:    mfang
Date:      2013-04-22 23:17 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/6d8cd4f28a2f

Merge

- make/com/sun/servicetag/Makefile
- src/share/classes/com/sun/servicetag/BrowserSupport.java
- src/share/classes/com/sun/servicetag/Installer.java
- src/share/classes/com/sun/servicetag/LinuxSystemEnvironment.java
- src/share/classes/com/sun/servicetag/RegistrationData.java
- src/share/classes/com/sun/servicetag/RegistrationDocument.java
- src/share/classes/com/sun/servicetag/Registry.java
- src/share/classes/com/sun/servicetag/ServiceTag.java
- src/share/classes/com/sun/servicetag/SolarisServiceTag.java
- src/share/classes/com/sun/servicetag/SolarisSystemEnvironment.java
- src/share/classes/com/sun/servicetag/SunConnection.java
- src/share/classes/com/sun/servicetag/SystemEnvironment.java
- src/share/classes/com/sun/servicetag/UnauthorizedAccessException.java
- src/share/classes/com/sun/servicetag/Util.java
- src/share/classes/com/sun/servicetag/WindowsSystemEnvironment.java
- src/share/classes/com/sun/servicetag/package.html
- src/share/classes/com/sun/servicetag/resources/Putback-Notes.txt
- src/share/classes/com/sun/servicetag/resources/javase_5_swordfish.properties
- src/share/classes/com/sun/servicetag/resources/javase_6_swordfish.properties
- src/share/classes/com/sun/servicetag/resources/javase_7_swordfish.properties
- src/share/classes/com/sun/servicetag/resources/javase_servicetag.properties
- src/share/classes/com/sun/servicetag/resources/jdk_header.png
- src/share/classes/com/sun/servicetag/resources/product_registration.xsd
- src/share/classes/com/sun/servicetag/resources/register.html
- src/share/classes/com/sun/servicetag/resources/register_ja.html
- src/share/classes/com/sun/servicetag/resources/register_zh_CN.html
- src/share/classes/java/time/chrono/HijrahDeviationReader.java
- src/share/classes/java/time/format/DateTimeBuilder.java
- src/share/classes/java/time/format/DateTimeFormatStyleProvider.java
- src/share/classes/java/time/temporal/Adjusters.java
- src/share/classes/java/time/temporal/Queries.java
! src/share/classes/sun/security/ssl/Authenticator.java
- src/share/classes/sun/security/util/KeyLength.java
- src/share/native/java/lang/ResourceBundle.c
- test/com/sun/servicetag/DeleteServiceTag.java
- test/com/sun/servicetag/DuplicateNotFound.java
- test/com/sun/servicetag/FindServiceTags.java
- test/com/sun/servicetag/InstanceUrnCheck.java
- test/com/sun/servicetag/InvalidRegistrationData.java
- test/com/sun/servicetag/InvalidServiceTag.java
- test/com/sun/servicetag/JavaServiceTagTest.java
- test/com/sun/servicetag/JavaServiceTagTest1.java
- test/com/sun/servicetag/NewRegistrationData.java
- test/com/sun/servicetag/SvcTagClient.java
- test/com/sun/servicetag/SystemRegistryTest.java
- test/com/sun/servicetag/TestLoadFromXML.java
- test/com/sun/servicetag/UpdateServiceTagTest.java
- test/com/sun/servicetag/Util.java
- test/com/sun/servicetag/ValidRegistrationData.java
- test/com/sun/servicetag/environ.properties
- test/com/sun/servicetag/missing-environ-field.xml
- test/com/sun/servicetag/newer-registry-version.xml
- test/com/sun/servicetag/registration.xml
- test/com/sun/servicetag/servicetag1.properties
- test/com/sun/servicetag/servicetag2.properties
- test/com/sun/servicetag/servicetag3.properties
- test/com/sun/servicetag/servicetag4.properties
- test/com/sun/servicetag/servicetag5.properties
- test/java/time/tck/java/time/TestChronology.java
- test/java/time/tck/java/time/chrono/TestChronoLocalDate.java
- test/java/time/tck/java/time/chrono/TestChronoLocalDateTime.java
- test/java/time/tck/java/time/chrono/TestHijrahChronology.java
- test/java/time/tck/java/time/chrono/TestJapaneseChronology.java
- test/java/time/tck/java/time/chrono/TestMinguoChronology.java
- test/java/time/tck/java/time/chrono/TestThaiBuddhistChronology.java
- test/java/time/tck/java/time/temporal/TCKDateTimeAdjusters.java
- test/java/time/tck/java/time/temporal/TestChronoLocalDate.java
- test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java
- test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java
- test/java/time/test/java/time/temporal/TestDateTimeAdjusters.java
- test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java
- test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java
- test/java/util/ComparatorsTest.java
! test/sun/security/ssl/javax/net/ssl/TLSv12/ShortRSAKeyGCM.java
- test/sun/tools/jstat/gcPermCapacityOutput1.awk
- test/sun/tools/jstat/jstatGcPermCapacityOutput1.sh

Changeset: a6781797ae53
Author:    mfang
Date:      2013-04-26 09:19 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/a6781797ae53

Merge


Changeset: 890485cafb8b
Author:    mfang
Date:      2013-04-26 14:16 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/890485cafb8b

Merge


Changeset: 5e7ae178b24d
Author:    plevart
Date:      2013-04-26 16:09 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5e7ae178b24d

7123493: (proxy) Proxy.getProxyClass doesn't scale under high load
Reviewed-by: mchung

! src/share/classes/java/lang/reflect/Proxy.java
+ src/share/classes/java/lang/reflect/WeakCache.java

Changeset: 964b95a59656
Author:    weijun
Date:      2013-04-27 18:25 +0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/964b95a59656

8005523: Unbound krb5 for TLS
Reviewed-by: xuelei

! src/share/classes/sun/security/ssl/KerberosClientKeyExchange.java
! src/share/classes/sun/security/ssl/Krb5Helper.java
! src/share/classes/sun/security/ssl/Krb5Proxy.java
! src/share/classes/sun/security/ssl/ServerHandshaker.java
! src/share/classes/sun/security/ssl/krb5/KerberosClientKeyExchangeImpl.java
! src/share/classes/sun/security/ssl/krb5/Krb5ProxyImpl.java
! test/sun/security/krb5/auto/SSL.java

Changeset: c5d7bdee8c64
Author:    alanb
Date:      2013-04-28 21:06 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c5d7bdee8c64

8013413: javadoc warnings
Reviewed-by: lancea, chegar

! src/share/classes/java/nio/file/attribute/FileTime.java
! src/share/classes/java/util/Spliterator.java

Changeset: 94b05be10eec
Author:    alanb
Date:      2013-04-29 10:28 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/94b05be10eec

8013415: Changes for JDK-8005523 requires updates to refs.allowed
Reviewed-by: chegar

! make/tools/src/build/tools/deps/refs.allowed

Changeset: 138f767b8eff
Author:    dholmes
Date:      2013-04-29 07:40 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/138f767b8eff

8010280: jvm.cfg needs updating for non-server builds
Summary: Generate jvm.cfg based on chosen VMs for non-"standard" builds and remove legacy entries from committed jvm.cfg files
Reviewed-by: mduigou, tbell

! makefiles/CopyFiles.gmk
! src/macosx/bin/x86_64/jvm.cfg
! src/solaris/bin/amd64/jvm.cfg
! src/solaris/bin/arm/jvm.cfg
! src/solaris/bin/i586/jvm.cfg
! src/solaris/bin/ia64/jvm.cfg
! src/solaris/bin/ppc/jvm.cfg
! src/solaris/bin/sparc/jvm.cfg
! src/solaris/bin/sparcv9/jvm.cfg
! src/solaris/bin/zero/jvm.cfg
! src/windows/bin/amd64/jvm.cfg
! src/windows/bin/i586/jvm.cfg
! src/windows/bin/ia64/jvm.cfg

Changeset: 9d324d667bb3
Author:    jzavgren
Date:      2013-04-29 08:17 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/9d324d667bb3

8012108: Memory leak in jdk/src/windows/native/java/net/NetworkInterface_winXP.c
Summary: Modified code to fix this leak and then proactively fixed improper calls to realloc() in the windows native code that can also cause leaks.
Reviewed-by: chegar, khazra, dsamersoff

! src/windows/native/java/net/NetworkInterface.c
! src/windows/native/java/net/NetworkInterface_winXP.c
! src/windows/native/sun/net/dns/ResolverConfigurationImpl.c

Changeset: b013d7433184
Author:    chegar
Date:      2013-04-29 18:12 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b013d7433184

Merge


Changeset: 7857129859bd
Author:    briangoetz
Date:      2013-04-20 18:53 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7857129859bd

8012650: Arrays streams methods
8011918: java.util.stream.Streams
Reviewed-by: alanb, mduigou, darcy, henryjen
Contributed-by: brian.goetz at oracle.com, paul.sandoz at oracle.com

! src/share/classes/java/util/Arrays.java
! src/share/classes/java/util/stream/DoubleStream.java
! src/share/classes/java/util/stream/IntStream.java
! src/share/classes/java/util/stream/LongStream.java
! src/share/classes/java/util/stream/Stream.java
+ src/share/classes/java/util/stream/StreamBuilder.java
+ src/share/classes/java/util/stream/Streams.java
+ test/java/util/Arrays/SetAllTest.java

Changeset: 46ddd9d272b5
Author:    mduigou
Date:      2013-04-29 22:03 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/46ddd9d272b5

8011917: Add java.util.stream.Collectors utilities
Reviewed-by: darcy, mduigou
Contributed-by: Brian Goetz <brian.goetz at oracle.com>

+ src/share/classes/java/util/stream/Collectors.java

Changeset: fff665e54df0
Author:    sla
Date:      2013-04-30 10:48 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/fff665e54df0

8003671: [findbugs] sun.management.AgentConfigurationError.getParams() may expose internal representation by returning AgentConfigurationError.params
Reviewed-by: mchung, rbackman, jbachorik

! src/share/classes/sun/management/AgentConfigurationError.java

Changeset: 49d6596100db
Author:    msheppar
Date:      2013-04-29 23:07 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/49d6596100db

8007373: Inet6Address serialization incompatibility
Reviewed-by: alanb, chegar

! src/share/classes/java/net/Inet6Address.java
+ test/java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java

Changeset: ac3e189c9099
Author:    lancea
Date:      2013-04-30 14:44 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ac3e189c9099

8010416: Add a way for java.sql.Driver to be notified when it is deregistered
Reviewed-by: alanb, ulfzibis

! src/share/classes/java/sql/Driver.java
+ src/share/classes/java/sql/DriverAction.java
! src/share/classes/java/sql/DriverManager.java
! src/share/classes/java/sql/SQLPermission.java

Changeset: 0e6f412f5536
Author:    mduigou
Date:      2013-04-30 12:31 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/0e6f412f5536

8011814: Add testng.jar to Netbeans projects test compile classpath
8013271: Add MacOS sources to J2SE Netbeans project
8013272: JDK Netbeans projects should use ASCII encoding for sources
Reviewed-by: lancea

! make/netbeans/common/closed-share-sources.ent
! make/netbeans/common/demo-view.ent
! make/netbeans/common/java-data-native.ent
! make/netbeans/common/java-data-no-native.ent
! make/netbeans/common/jtreg-view.ent
+ make/netbeans/common/macosx-sources.ent
+ make/netbeans/common/macosx-view.ent
! make/netbeans/common/properties.ent
! make/netbeans/common/sample-view.ent
! make/netbeans/common/share-sources.ent
! make/netbeans/common/unix-sources.ent
! make/netbeans/common/windows-sources.ent
! make/netbeans/j2se/nbproject/project.xml
! make/netbeans/world/nbproject/project.xml

Changeset: 2fba6ae13ed8
Author:    mduigou
Date:      2013-04-30 12:32 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/2fba6ae13ed8

Merge


Changeset: 1432a6247ac9
Author:    ksrini
Date:      2013-04-30 13:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/1432a6247ac9

8009389: Unpack200 native library should be removed from profiles
Reviewed-by: alanb, bobv, jrose

! makefiles/profile-includes.txt
! src/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java

Changeset: eda99449ab26
Author:    alanb
Date:      2013-04-30 21:19 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/eda99449ab26

8013647: JPRT unable to clean-up after tests that leave file trees with loops
Reviewed-by: chegar, tbell

! test/java/nio/file/Files/walkFileTree/MaxDepth.java
! test/java/nio/file/Files/walkFileTree/SkipSiblings.java
! test/java/nio/file/Files/walkFileTree/SkipSubtree.java
! test/java/nio/file/Files/walkFileTree/TerminateWalk.java

Changeset: 4a82d2b86c75
Author:    mchung
Date:      2013-04-30 15:42 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/4a82d2b86c75

8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
Reviewed-by: alanb

! test/sun/reflect/CallerSensitive/CallerSensitiveFinder.java
- test/sun/reflect/CallerSensitive/MethodFinder.java
! test/sun/reflect/CallerSensitive/MissingCallerSensitive.java

Changeset: 4550ba263cbf
Author:    lana
Date:      2013-04-30 17:51 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/4550ba263cbf

Merge


Changeset: dddd17cf61ff
Author:    chegar
Date:      2013-05-01 10:03 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/dddd17cf61ff

6594296: NetworkInterface.getHardwareAddress returns zero length byte array
Reviewed-by: alanb

! src/windows/native/java/net/NetworkInterface_winXP.c
! test/java/net/NetworkInterface/Test.java

Changeset: 73793f2af80a
Author:    msheppar
Date:      2013-04-30 16:24 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/73793f2af80a

8007799: Base64.getEncoder(0, byte[]) returns an encoder that unexpectedly inserts line separators
Reviewed-by: sherman, iris

! src/share/classes/java/util/Base64.java
+ test/java/util/Base64/Base64GetEncoderTest.java

Changeset: 5941f7c9c76a
Author:    chegar
Date:      2013-05-01 11:15 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5941f7c9c76a

8013723: ProblemList.txt updates (5/2013)
Reviewed-by: alanb

! test/ProblemList.txt

Changeset: ae4a82e69da2
Author:    weijun
Date:      2013-05-01 21:05 +0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ae4a82e69da2

8012082: SASL: auth-conf negotiated, but unencrypted data is accepted, reset to unencrypt
Reviewed-by: vinnie

! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Base.java
! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Client.java
! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Server.java
+ test/sun/security/krb5/auto/SaslGSS.java

Changeset: c6aef650e615
Author:    mduigou
Date:      2013-05-01 08:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c6aef650e615

8012665: add CharSequence.chars, CharSequence.codePoints
Reviewed-by: martin, alanb, ulfzibis, mduigou
Contributed-by: Stuart Marks <stuart.marks at oracle.com>, Henry Jen <henry.jen at oracle.com>

! src/share/classes/java/lang/CharSequence.java
+ test/java/lang/CharSequence/DefaultTest.java
! test/java/lang/StringBuffer/TestSynchronization.java

Changeset: f6f2802f980c
Author:    lana
Date:      2013-05-01 11:34 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/f6f2802f980c

Merge

- test/java/io/Serializable/accessConstants/AccessConstants.java
- test/java/nio/file/Files/walkFileTree/walk_file_tree.sh
- test/sun/reflect/CallerSensitive/MethodFinder.java

Changeset: 336a110f1196
Author:    lana
Date:      2013-05-06 11:50 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/336a110f1196

Merge

- src/share/classes/java/beans/ReflectionUtils.java
- test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java
- test/java/io/Serializable/accessConstants/AccessConstants.java
- test/java/nio/file/Files/walkFileTree/walk_file_tree.sh
- test/sun/reflect/CallerSensitive/MethodFinder.java

Changeset: 88125d32eb06
Author:    andrew
Date:      2013-05-04 17:04 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/88125d32eb06

8011366: Enable debug info on all libraries for OpenJDK builds
Summary: The build should not be turning off debugging if it has been requested.
Reviewed-by: erikj, dholmes

! makefiles/CompileNativeLibraries.gmk

Changeset: 7ba77fff0ef6
Author:    katleman
Date:      2013-05-07 10:51 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7ba77fff0ef6

Merge


Changeset: 845025546e35
Author:    katleman
Date:      2013-05-07 13:13 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/845025546e35

Merge


Changeset: b8e7d145abc2
Author:    katleman
Date:      2013-05-09 10:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b8e7d145abc2

Added tag jdk8-b89 for changeset 845025546e35

! .hgtags

Changeset: 1f1699686504
Author:    katleman
Date:      2013-05-09 15:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/1f1699686504

8014289: JDK8 b89 source with GPL header errors
Reviewed-by: mchung, mduigou, tbell, dsamersoff

! src/share/classes/java/util/Base64.java
! src/share/classes/java/util/StringJoiner.java
! test/java/lang/CharSequence/DefaultTest.java
! test/java/util/StringJoiner/StringJoinerTest.java

Changeset: c63eda8f6300
Author:    katleman
Date:      2013-05-14 12:19 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c63eda8f6300

Merge


Changeset: 08c28cdacd7b
Author:    katleman
Date:      2013-05-16 12:15 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/08c28cdacd7b

Added tag jdk8-b90 for changeset c63eda8f6300

! .hgtags


From john.coomes at oracle.com  Thu May 16 20:56:46 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 17 May 2013 03:56:46 +0000
Subject: hg: hsx/hotspot-main/langtools: 17 new changesets
Message-ID: <20130517035740.DECEC48B39@hg.openjdk.java.net>

Changeset: ed918a442b83
Author:    jlahoda
Date:      2013-04-17 15:54 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/ed918a442b83

8008174: DocTree API should provide start and end positions for tree nodes
Summary: Adding DocSourcePositions to allow access to DocTree starting/ending position
Reviewed-by: jjg, darcy
Contributed-by: Ralph Benjamin Ruijs <ralphbenjamin at netbeans.org>, Jan Lahoda <jlahoda at netbeans.org>

+ src/share/classes/com/sun/source/util/DocSourcePositions.java
! src/share/classes/com/sun/source/util/DocTrees.java
! src/share/classes/com/sun/source/util/SourcePositions.java
! src/share/classes/com/sun/tools/javac/api/JavacTrees.java
! src/share/classes/com/sun/tools/javac/parser/DocCommentParser.java
! src/share/classes/com/sun/tools/javac/tree/DCTree.java
+ test/tools/javac/doctree/positions/TestPosition.java
+ test/tools/javac/doctree/positions/TestPosition.out
+ test/tools/javac/doctree/positions/TestPositionSource.java

Changeset: 891b88acf47a
Author:    jjg
Date:      2013-04-18 19:58 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/891b88acf47a

8012658: Change default langtools source level to 7
Reviewed-by: darcy

! make/netbeans/langtools/nbproject/project.xml

Changeset: 95d29b99e5b3
Author:    jjg
Date:      2013-04-18 20:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/95d29b99e5b3

8012656: cache frequently used name strings for DocImpl classes
Reviewed-by: darcy

! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java
! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java
! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java
! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java

Changeset: a3655c24e232
Author:    jfranck
Date:      2013-04-19 11:57 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/a3655c24e232

8012681: Commit for JDK-8012656 breaks tl build
Reviewed-by: vromero, chegar, alanb

! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java

Changeset: d59730bd3162
Author:    jjg
Date:      2013-04-19 11:10 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/d59730bd3162

8012661: remove langtools Makefile-classic
Reviewed-by: erikj, tbell

- make/Makefile-classic

Changeset: bae8387d16aa
Author:    jfranck
Date:      2013-04-22 10:24 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/bae8387d16aa

8011027: Type parameter annotations not passed through to javax.lang.model
Reviewed-by: jjg, darcy

! src/share/classes/com/sun/tools/javac/code/Symbol.java
! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java
! src/share/classes/com/sun/tools/javac/model/JavacAnnoConstructs.java
! src/share/classes/com/sun/tools/javac/model/JavacElements.java
+ test/tools/javac/processing/model/element/TestTypeParameterAnnotations.java

Changeset: da0bd69335d4
Author:    lana
Date:      2013-04-23 15:09 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/da0bd69335d4

Merge


Changeset: 4b0038f66d66
Author:    jjg
Date:      2013-04-25 17:45 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/4b0038f66d66

8013256: javac test failing after Lambda changes to java.util.List
Reviewed-by: mduigou

! test/tools/javac/api/TestJavacTaskScanner.java

Changeset: 3c02d2f1a421
Author:    vromero
Date:      2013-04-26 10:04 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/3c02d2f1a421

8012723: strictfp interface misses strictfp modifer on default method
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/comp/Check.java
+ test/tools/javac/defaultMethods/CheckACC_STRICTFlagOnDefaultMethodTest.java

Changeset: 2ca9e7d50136
Author:    vromero
Date:      2013-04-26 10:17 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/2ca9e7d50136

8008562: javac, a refactoring to Bits is necessary in order to provide a change history
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/comp/Flow.java
! src/share/classes/com/sun/tools/javac/jvm/Code.java
! src/share/classes/com/sun/tools/javac/util/Bits.java

Changeset: f3f3ac1273e8
Author:    vromero
Date:      2013-04-26 15:59 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/f3f3ac1273e8

8010304: javac should detect all mutable implicit static fields in langtools using a plugin
Reviewed-by: jjg

! make/build.xml
+ make/tools/crules/AbstractCodingRulesAnalyzer.java
+ make/tools/crules/MutableFieldsAnalyzer.java
+ make/tools/crules/resources/crules.properties

Changeset: 57648bad3287
Author:    mchung
Date:      2013-04-30 15:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/57648bad3287

8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
Reviewed-by: alanb

! src/share/classes/com/sun/tools/classfile/Dependencies.java
+ src/share/classes/com/sun/tools/classfile/ReferenceFinder.java

Changeset: 260013a710ef
Author:    lana
Date:      2013-04-30 17:53 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/260013a710ef

Merge


Changeset: 8e27e84de2e9
Author:    rfield
Date:      2013-05-01 08:46 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/8e27e84de2e9

8011591: BootstrapMethodError when capturing constructor ref to local classes
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
+ test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestNewInnerImplicitArgs.java

Changeset: ec434cfd2752
Author:    lana
Date:      2013-05-06 11:53 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/ec434cfd2752

Merge

- make/Makefile-classic

Changeset: e19283cd30a4
Author:    katleman
Date:      2013-05-09 10:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/e19283cd30a4

Added tag jdk8-b89 for changeset ec434cfd2752

! .hgtags

Changeset: 9717b9523d46
Author:    katleman
Date:      2013-05-16 12:16 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/9717b9523d46

Added tag jdk8-b90 for changeset e19283cd30a4

! .hgtags


From john.coomes at oracle.com  Thu May 16 20:57:52 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 17 May 2013 03:57:52 +0000
Subject: hg: hsx/hotspot-main/nashorn: 40 new changesets
Message-ID: <20130517035822.35ACC48B3A@hg.openjdk.java.net>

Changeset: aa8170c0dec9
Author:    sundar
Date:      2013-04-15 20:12 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/aa8170c0dec9

8012240: Array.prototype.map.call({length: -1, get 0(){throw 0}}, function(){}).length does not throw error
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/runtime/arrays/MapIterator.java
+ test/script/basic/JDK-8012240.js

Changeset: 486d92559c37
Author:    sundar
Date:      2013-04-17 16:52 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/486d92559c37

8012457: Function.prototype.apply should accept any array-like argument for function arguments
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/objects/NativeFunction.java
+ test/script/basic/JDK-8012457.js

Changeset: d4468316fe73
Author:    jlaskey
Date:      2013-04-17 08:48 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/d4468316fe73

Merge


Changeset: 04b36c02c0e2
Author:    jlaskey
Date:      2013-04-17 15:36 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/04b36c02c0e2

8012529: Remove -esa from testing jvmargs
Reviewed-by: sundar
Contributed-by: james.laskey at oracle.com

! make/project.properties

Changeset: 2bb3b22392d7
Author:    sundar
Date:      2013-04-18 15:47 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/2bb3b22392d7

Merge


Changeset: ac309d492b8d
Author:    sundar
Date:      2013-04-18 15:50 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/ac309d492b8d

8012462: Date.prototype.toJSON does not handle non-Date 'this' as per the spec.
Reviewed-by: jlaskey, hannesw

! src/jdk/nashorn/internal/objects/NativeDate.java
+ test/script/basic/JDK-8012462.js

Changeset: d1d564f5cf82
Author:    hannesw
Date:      2013-04-18 14:25 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/d1d564f5cf82

8012460: RegExp regression
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/runtime/regexp/joni/Parser.java
+ test/script/basic/JDK-8012460.js
+ test/script/basic/JDK-8012460.js.EXPECTED

Changeset: bc251a7b5103
Author:    sundar
Date:      2013-04-19 17:46 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/bc251a7b5103

8012612: Compile failed
Reviewed-by: hannesw, jlaskey, attila

! src/jdk/nashorn/internal/runtime/Context.java

Changeset: c8460f668d0c
Author:    sundar
Date:      2013-04-19 18:23 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/c8460f668d0c

8012593: JSAdapter overrides impacts strongly construction time
Reviewed-by: jlaskey, attila

! src/jdk/nashorn/internal/objects/NativeJSAdapter.java

Changeset: 3a209cbd1d8f
Author:    lagergren
Date:      2013-04-19 16:11 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/3a209cbd1d8f

8010701: Immutable nodes - final iteration
Reviewed-by: sundar, hannesw, jlaskey

! bin/verbose_octane.sh
! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/ClassEmitter.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/CompilationPhase.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/codegen/CompilerConstants.java
! src/jdk/nashorn/internal/codegen/FieldObjectCreator.java
! src/jdk/nashorn/internal/codegen/FinalizeTypes.java
! src/jdk/nashorn/internal/codegen/FoldConstants.java
- src/jdk/nashorn/internal/codegen/Frame.java
! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/codegen/Namespace.java
! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java
! src/jdk/nashorn/internal/codegen/ObjectCreator.java
+ src/jdk/nashorn/internal/codegen/SplitMethodEmitter.java
! src/jdk/nashorn/internal/codegen/Splitter.java
! src/jdk/nashorn/internal/codegen/WeighNodes.java
! src/jdk/nashorn/internal/ir/AccessNode.java
! src/jdk/nashorn/internal/ir/BaseNode.java
! src/jdk/nashorn/internal/ir/BinaryNode.java
! src/jdk/nashorn/internal/ir/Block.java
+ src/jdk/nashorn/internal/ir/BlockLexicalContext.java
! src/jdk/nashorn/internal/ir/BreakNode.java
! src/jdk/nashorn/internal/ir/BreakableNode.java
! src/jdk/nashorn/internal/ir/CallNode.java
! src/jdk/nashorn/internal/ir/CaseNode.java
! src/jdk/nashorn/internal/ir/CatchNode.java
! src/jdk/nashorn/internal/ir/ContinueNode.java
- src/jdk/nashorn/internal/ir/DoWhileNode.java
! src/jdk/nashorn/internal/ir/EmptyNode.java
! src/jdk/nashorn/internal/ir/ExecuteNode.java
+ src/jdk/nashorn/internal/ir/Flags.java
! src/jdk/nashorn/internal/ir/ForNode.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/ir/IdentNode.java
! src/jdk/nashorn/internal/ir/IfNode.java
! src/jdk/nashorn/internal/ir/IndexNode.java
! src/jdk/nashorn/internal/ir/LabelNode.java
- src/jdk/nashorn/internal/ir/LabeledNode.java
! src/jdk/nashorn/internal/ir/LexicalContext.java
+ src/jdk/nashorn/internal/ir/LexicalContextNode.java
! src/jdk/nashorn/internal/ir/LineNumberNode.java
! src/jdk/nashorn/internal/ir/LiteralNode.java
! src/jdk/nashorn/internal/ir/Location.java
+ src/jdk/nashorn/internal/ir/LoopNode.java
! src/jdk/nashorn/internal/ir/Node.java
! src/jdk/nashorn/internal/ir/ObjectNode.java
! src/jdk/nashorn/internal/ir/PropertyNode.java
! src/jdk/nashorn/internal/ir/ReturnNode.java
! src/jdk/nashorn/internal/ir/RuntimeNode.java
! src/jdk/nashorn/internal/ir/SplitNode.java
! src/jdk/nashorn/internal/ir/SwitchNode.java
! src/jdk/nashorn/internal/ir/Symbol.java
! src/jdk/nashorn/internal/ir/TernaryNode.java
! src/jdk/nashorn/internal/ir/ThrowNode.java
! src/jdk/nashorn/internal/ir/TryNode.java
! src/jdk/nashorn/internal/ir/UnaryNode.java
! src/jdk/nashorn/internal/ir/VarNode.java
! src/jdk/nashorn/internal/ir/WhileNode.java
! src/jdk/nashorn/internal/ir/WithNode.java
+ src/jdk/nashorn/internal/ir/annotations/Immutable.java
! src/jdk/nashorn/internal/ir/debug/ASTWriter.java
! src/jdk/nashorn/internal/ir/debug/JSONWriter.java
! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java
! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java
! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java
! src/jdk/nashorn/internal/lookup/MethodHandleFactory.java
! src/jdk/nashorn/internal/objects/NativeString.java
! src/jdk/nashorn/internal/parser/AbstractParser.java
! src/jdk/nashorn/internal/parser/JSONParser.java
! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/parser/TokenType.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/DebugLogger.java
! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java
! src/jdk/nashorn/internal/runtime/StructureLoader.java
! src/jdk/nashorn/internal/runtime/linker/ClassAndLoader.java
! src/jdk/nashorn/tools/Shell.java
+ test/script/basic/try2.js
+ test/script/basic/try2.js.EXPECTED

Changeset: e599a1cad89a
Author:    jlaskey
Date:      2013-04-20 08:54 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/e599a1cad89a

8011578: -Dnashorn.unstable.relink.threshold=1 causes tests to fail.
Reviewed-by: sundar, lagergren
Contributed-by: james.laskey at oracle.com

! src/jdk/nashorn/internal/runtime/FindProperty.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/WithObject.java
+ test/script/basic/JDK-8011578.js
+ test/script/basic/JDK-8011578.js.EXPECTED

Changeset: ead94bc57939
Author:    sundar
Date:      2013-04-22 18:09 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/ead94bc57939

8012673: Nashorn's package name vs class name inferring logic is wrong
Reviewed-by: hannesw, jlaskey, attila

! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java

Changeset: 812e9cc70320
Author:    jlaskey
Date:      2013-04-22 10:37 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/812e9cc70320

8012919: findMegaMorphicSetMethod should not cast result type
Reviewed-by: attila, sundar
Contributed-by: james.laskey at oracle.com

! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/WithObject.java

Changeset: cfda59f3d827
Author:    sundar
Date:      2013-04-22 19:57 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/cfda59f3d827

Merge

- src/jdk/nashorn/internal/codegen/Frame.java
- src/jdk/nashorn/internal/ir/DoWhileNode.java
- src/jdk/nashorn/internal/ir/LabeledNode.java

Changeset: 08143fa6b3da
Author:    lana
Date:      2013-04-23 15:09 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/08143fa6b3da

Merge


Changeset: 0547a1c76259
Author:    attila
Date:      2013-04-23 12:52 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/0547a1c76259

8011065: Problems when script implements an interface with variadic methods
Reviewed-by: jlaskey, hannesw, sundar

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterServices.java
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java
+ test/src/jdk/nashorn/api/scripting/VariableArityTestInterface.java

Changeset: 32036918585d
Author:    attila
Date:      2013-04-23 16:48 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/32036918585d

8010731: Don't expose internal symbols to scripts
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/codegen/CompilerConstants.java
! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java

Changeset: a6c53280343d
Author:    hannesw
Date:      2013-04-24 13:28 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/a6c53280343d

8012334: ToUint32, ToInt32, and ToUint16 don't conform to spec
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/FoldConstants.java
! src/jdk/nashorn/internal/objects/NativeArray.java
! src/jdk/nashorn/internal/objects/NativeUint32Array.java
! src/jdk/nashorn/internal/runtime/JSType.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/arrays/SparseArrayData.java
+ test/examples/int-micro.js
+ test/script/basic/JDK-8012334.js
+ test/script/basic/JDK-8012334.js.EXPECTED
! test/src/jdk/nashorn/internal/runtime/JSTypeTest.java

Changeset: 3974ce844f17
Author:    hannesw
Date:      2013-04-24 13:34 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/3974ce844f17

8012931: NativeDate.safeToString() throws RangeError for invalid date
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/objects/NativeDate.java
+ test/script/basic/JDK-8012931.js
+ test/script/basic/JDK-8012931.js.EXPECTED

Changeset: e959c7969f3b
Author:    hannesw
Date:      2013-04-24 13:36 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/e959c7969f3b

8008238: Labeled break in finally causes stack overflow in Node copy
Reviewed-by: lagergren, attila

+ test/script/basic/JDK-8008238.js

Changeset: c0a10bbf6752
Author:    jlaskey
Date:      2013-04-24 14:25 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/c0a10bbf6752

8012251: jjs should support -fx option
Reviewed-by: sundar, attila, lagergren
Contributed-by: james.laskey at oracle.com

! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java
! src/jdk/nashorn/internal/runtime/resources/Options.properties
+ src/jdk/nashorn/internal/runtime/resources/fx/base.js
+ src/jdk/nashorn/internal/runtime/resources/fx/bootstrap.js
+ src/jdk/nashorn/internal/runtime/resources/fx/controls.js
+ src/jdk/nashorn/internal/runtime/resources/fx/fxml.js
+ src/jdk/nashorn/internal/runtime/resources/fx/graphics.js
+ src/jdk/nashorn/internal/runtime/resources/fx/media.js
+ src/jdk/nashorn/internal/runtime/resources/fx/swing.js
+ src/jdk/nashorn/internal/runtime/resources/fx/swt.js
+ src/jdk/nashorn/internal/runtime/resources/fx/web.js
! src/jdk/nashorn/tools/Shell.java
! tools/fxshell/jdk/nashorn/tools/FXShell.java

Changeset: 9ad1ebb44c86
Author:    hannesw
Date:      2013-04-25 14:20 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/9ad1ebb44c86

8013131: Various compatibility issues in String.prototype.split()
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/objects/NativeJSON.java
! src/jdk/nashorn/internal/objects/NativeRegExp.java
! src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java
! src/jdk/nashorn/internal/objects/NativeString.java
+ test/script/basic/JDK-8013131.js
+ test/script/basic/JDK-8013131.js.EXPECTED

Changeset: ff1e4655a57f
Author:    attila
Date:      2013-04-25 14:47 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/ff1e4655a57f

8013203: A collection of smaller speedups to compilation pipeline
Reviewed-by: hannesw, jlaskey

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/FinalizeTypes.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java
! src/jdk/nashorn/internal/parser/Lexer.java
! src/jdk/nashorn/internal/runtime/AccessorProperty.java

Changeset: fd0b969a6d07
Author:    attila
Date:      2013-04-25 15:31 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/fd0b969a6d07

8013167: Vararg constructor not found
Reviewed-by: jlaskey, lagergren, sundar

! src/jdk/internal/dynalink/beans/StaticClassIntrospector.java
! src/jdk/internal/dynalink/beans/StaticClassLinker.java
+ test/script/basic/JDK-8013167.js
+ test/script/basic/JDK-8013167.js.EXPECTED
+ test/src/jdk/nashorn/test/models/VarArgConstructor.java

Changeset: 215d9b042cb6
Author:    sundar
Date:      2013-04-26 12:17 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/215d9b042cb6

8013295: ScriptEngineTest.java fails with compilation error when running under jtreg
Reviewed-by: attila, hannesw

! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

Changeset: 7917ef020898
Author:    attila
Date:      2013-04-26 09:20 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/7917ef020898

8013325: function named 'arguments' should set DEFINES_ARGUMENTS flag in its parent, not itself
Reviewed-by: hannesw, sundar

! src/jdk/internal/dynalink/beans/StaticClassIntrospector.java
! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/ir/LexicalContext.java
! src/jdk/nashorn/internal/objects/NativeString.java
! src/jdk/nashorn/internal/parser/Parser.java
+ test/script/basic/JDK-8013325.js
+ test/script/basic/JDK-8013325.js.EXPECTED

Changeset: 5c98cc846f92
Author:    jlaskey
Date:      2013-04-26 09:48 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/5c98cc846f92

8013208: Octane performance regression
Reviewed-by: hannesw, sundar
Contributed-by: james.laskey at oracle.com

! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayIndex.java

Changeset: b532eeab085f
Author:    sundar
Date:      2013-04-26 18:31 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/b532eeab085f

8013337: Issues with Date.prototype's get, set functions
Reviewed-by: jlaskey, hannesw, lagergren

! src/jdk/nashorn/internal/objects/NativeDate.java
+ test/script/basic/JDK-8013337.js
+ test/script/basic/JDK-8013337.js.EXPECTED

Changeset: c62144b08c65
Author:    hannesw
Date:      2013-04-26 17:35 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/c62144b08c65

8006559: Octane:pdfjs leaks memory, runs slower iteration to iteration
Reviewed-by: attila, sundar, jlaskey

! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ConstructorGenerator.java
! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/StringConstants.java
! src/jdk/nashorn/internal/objects/BoundScriptFunctionImpl.java
! src/jdk/nashorn/internal/objects/NativeDebug.java
! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
! src/jdk/nashorn/internal/runtime/PropertyListenerManager.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java

Changeset: 241904013024
Author:    sundar
Date:      2013-04-26 22:29 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/241904013024

8013369: nashorn build failure with jdk8 b84
Reviewed-by: hannesw

! make/build-nasgen.xml

Changeset: ef4c1f3aa9ed
Author:    jlaskey
Date:      2013-04-26 15:13 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/ef4c1f3aa9ed

8013360: Should be using JavaFX 8 classes for -fx support
Reviewed-by: hannesw, sundar
Contributed-by: james.laskey at oracle.com

! src/jdk/nashorn/internal/runtime/resources/fx/base.js
! src/jdk/nashorn/internal/runtime/resources/fx/controls.js
! src/jdk/nashorn/internal/runtime/resources/fx/fxml.js
! src/jdk/nashorn/internal/runtime/resources/fx/graphics.js
! src/jdk/nashorn/internal/runtime/resources/fx/media.js
! src/jdk/nashorn/internal/runtime/resources/fx/swing.js
! src/jdk/nashorn/internal/runtime/resources/fx/swt.js
! src/jdk/nashorn/internal/runtime/resources/fx/web.js

Changeset: e8d7298f29a1
Author:    attila
Date:      2013-04-29 13:21 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/e8d7298f29a1

8013419: Streamline handling of with and eval
Reviewed-by: hannesw, lagergren

! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/ir/CallNode.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/ir/LexicalContext.java
! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java

Changeset: ada2ca9aeac5
Author:    sundar
Date:      2013-04-29 18:40 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/ada2ca9aeac5

8013444: JSON.parse does not invoke "reviver" callback as per spec.
Reviewed-by: jlaskey, hannesw

! src/jdk/nashorn/internal/runtime/JSONFunctions.java
+ test/script/basic/JDK-8013444.js
+ test/script/basic/JDK-8013444.js.EXPECTED

Changeset: 630372cb8f2a
Author:    attila
Date:      2013-04-29 23:22 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/630372cb8f2a

8008814: Configurable ignore/warning/error behavior for function declaration as statement
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/parser/AbstractParser.java
! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java
! src/jdk/nashorn/internal/runtime/options/Options.java
! src/jdk/nashorn/internal/runtime/resources/Options.properties
+ test/script/basic/JDK-8008814-3.js
+ test/script/basic/JDK-8008814-3.js.EXPECTED
+ test/script/basic/JDK-8008814-4.js
+ test/script/basic/JDK-8008814-4.js.EXPECTED
+ test/script/error/JDK-8008814-1.js
+ test/script/error/JDK-8008814-1.js.EXPECTED
+ test/script/error/JDK-8008814-2.js
+ test/script/error/JDK-8008814-2.js.EXPECTED

Changeset: 3f339ab2d050
Author:    jlaskey
Date:      2013-04-29 21:38 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/3f339ab2d050

Merge


Changeset: ad28f2b52b12
Author:    lagergren
Date:      2013-04-30 09:42 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/ad28f2b52b12

8013533: Increase code coverage report for types and logging
Reviewed-by: hannesw, sundar

! src/jdk/nashorn/internal/codegen/types/BooleanType.java
! src/jdk/nashorn/internal/codegen/types/IntType.java
! src/jdk/nashorn/internal/codegen/types/LongType.java
! src/jdk/nashorn/internal/codegen/types/NumberType.java
! src/jdk/nashorn/internal/codegen/types/Type.java
! test/script/error/JDK-8008814-1.js.EXPECTED
! test/script/error/JDK-8008814-2.js.EXPECTED
+ test/script/trusted/logcoverage.js
+ test/script/trusted/logcoverage.js.EXPECTED

Changeset: 9fee4992f796
Author:    lana
Date:      2013-04-30 17:53 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/9fee4992f796

Merge


Changeset: 45ce27fbe272
Author:    lana
Date:      2013-05-06 11:53 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/45ce27fbe272

Merge

- src/jdk/nashorn/internal/codegen/Frame.java
- src/jdk/nashorn/internal/ir/DoWhileNode.java
- src/jdk/nashorn/internal/ir/LabeledNode.java

Changeset: 67ca019e3713
Author:    katleman
Date:      2013-05-09 10:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/67ca019e3713

Added tag jdk8-b89 for changeset 45ce27fbe272

! .hgtags

Changeset: 4ce88eec5078
Author:    katleman
Date:      2013-05-16 12:16 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/4ce88eec5078

Added tag jdk8-b90 for changeset 67ca019e3713

! .hgtags


From christian.thalinger at oracle.com  Thu May 16 22:56:49 2013
From: christian.thalinger at oracle.com (christian.thalinger at oracle.com)
Date: Fri, 17 May 2013 05:56:49 +0000
Subject: hg: hsx/hotspot-main/hotspot: 11 new changesets
Message-ID: <20130517055713.0159848B57@hg.openjdk.java.net>

Changeset: d15464bfd4d0
Author:    roland
Date:      2013-05-03 09:32 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d15464bfd4d0

8012037: Test8009761.java "Failed: init recursive calls: 7224. After deopt 58824"
Summary: test shouldn't be run with a modified CompileThreshold
Reviewed-by: kvn

! test/compiler/8009761/Test8009761.java

Changeset: e76dd894b984
Author:    roland
Date:      2013-04-24 14:26 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/e76dd894b984

8012292: optimized build with GCC broken
Summary: Some #ifndef PRODUCT should be #ifdef ASSERT
Reviewed-by: kvn, twisti
Contributed-by: gdub <duboscq at ssw.jku.at>

! make/jprt.properties
! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/classfile/vmSymbols.cpp
! src/share/vm/opto/runtime.cpp
! src/share/vm/utilities/quickSort.cpp

Changeset: d73c88e524ff
Author:    kvn
Date:      2013-05-03 15:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/d73c88e524ff

Merge

! src/share/vm/classfile/classFileParser.cpp

Changeset: f0bc60565ba8
Author:    twisti
Date:      2013-05-06 13:53 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f0bc60565ba8

7196277: JSR 292: Two jck/runtime tests crash on java.lang.invoke.MethodHandle.invokeExact
Reviewed-by: jrose, kvn

! src/share/vm/oops/method.cpp
! src/share/vm/prims/methodHandles.cpp
! src/share/vm/prims/nativeLookup.cpp
! src/share/vm/runtime/sharedRuntime.cpp

Changeset: aabf54ccedb1
Author:    twisti
Date:      2013-05-06 19:49 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/aabf54ccedb1

8008772: remove gamma launcher
Reviewed-by: kvn, neliasso, ctornqvi

! make/Makefile
! make/bsd/makefiles/buildtree.make
- make/bsd/makefiles/launcher.make
! make/bsd/makefiles/vm.make
+ make/hotspot.script
! make/linux/makefiles/buildtree.make
- make/linux/makefiles/launcher.make
! make/linux/makefiles/vm.make
! make/solaris/makefiles/buildtree.make
- make/solaris/makefiles/launcher.make
! make/solaris/makefiles/vm.make
! make/windows/makefiles/debug.make
! make/windows/makefiles/fastdebug.make
- make/windows/makefiles/launcher.make
! make/windows/makefiles/product.make
! make/windows/makefiles/projectcreator.make
! make/windows/projectfiles/common/Makefile
- src/os/posix/launcher/java_md.c
- src/os/posix/launcher/java_md.h
- src/os/posix/launcher/launcher.script
- src/os/windows/launcher/java_md.c
- src/os/windows/launcher/java_md.h
! src/share/tools/ProjectCreator/BuildConfig.java
! src/share/tools/ProjectCreator/WinGammaPlatformVC10.java
- src/share/tools/launcher/java.c
- src/share/tools/launcher/java.h
- src/share/tools/launcher/jli_util.c
- src/share/tools/launcher/jli_util.h
- src/share/tools/launcher/wildcard.c
- src/share/tools/launcher/wildcard.h

Changeset: 6f3fd5150b67
Author:    kvn
Date:      2013-05-08 15:08 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/6f3fd5150b67

6934604: enable parts of EliminateAutoBox by default
Summary: Resurrected autobox elimination code and enabled part of it by default.
Reviewed-by: roland, twisti

! src/share/vm/ci/ciInstanceKlass.cpp
! src/share/vm/ci/ciInstanceKlass.hpp
! src/share/vm/ci/ciMethod.cpp
! src/share/vm/ci/ciMethod.hpp
! src/share/vm/classfile/vmSymbols.hpp
! src/share/vm/compiler/compileBroker.cpp
! src/share/vm/opto/bytecodeInfo.cpp
! src/share/vm/opto/c2_globals.hpp
! src/share/vm/opto/c2compiler.cpp
! src/share/vm/opto/callGenerator.cpp
! src/share/vm/opto/callGenerator.hpp
! src/share/vm/opto/callnode.cpp
! src/share/vm/opto/callnode.hpp
! src/share/vm/opto/cfgnode.cpp
! src/share/vm/opto/compile.cpp
! src/share/vm/opto/compile.hpp
! src/share/vm/opto/doCall.cpp
! src/share/vm/opto/escape.cpp
! src/share/vm/opto/graphKit.cpp
! src/share/vm/opto/ifnode.cpp
! src/share/vm/opto/library_call.cpp
! src/share/vm/opto/loopPredicate.cpp
! src/share/vm/opto/macro.cpp
! src/share/vm/opto/macro.hpp
! src/share/vm/opto/memnode.cpp
! src/share/vm/opto/memnode.hpp
! src/share/vm/opto/multnode.cpp
! src/share/vm/opto/multnode.hpp
! src/share/vm/opto/node.cpp
! src/share/vm/opto/node.hpp
! src/share/vm/opto/parse.hpp
! src/share/vm/opto/parse1.cpp
! src/share/vm/opto/parse2.cpp
! src/share/vm/opto/parse3.cpp
! src/share/vm/opto/parseHelper.cpp
! src/share/vm/opto/phase.cpp
! src/share/vm/opto/phase.hpp
! src/share/vm/opto/phaseX.cpp
! src/share/vm/opto/type.cpp
! src/share/vm/opto/type.hpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/vmStructs.cpp
+ test/compiler/6934604/TestByteBoxing.java
+ test/compiler/6934604/TestDoubleBoxing.java
+ test/compiler/6934604/TestFloatBoxing.java
+ test/compiler/6934604/TestIntBoxing.java
+ test/compiler/6934604/TestLongBoxing.java
+ test/compiler/6934604/TestShortBoxing.java

Changeset: 70120f47d403
Author:    kvn
Date:      2013-05-09 17:28 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/70120f47d403

8014189: JVM crash with SEGV in ConnectionGraph::record_for_escape_analysis()
Summary: Add NULL checks and asserts for Type::make_ptr() returned value.
Reviewed-by: twisti

! src/share/vm/opto/escape.cpp
! src/share/vm/opto/lcm.cpp
! src/share/vm/opto/library_call.cpp
! src/share/vm/opto/machnode.cpp
! src/share/vm/opto/macro.cpp
! src/share/vm/opto/node.cpp
! src/share/vm/opto/node.hpp
! src/share/vm/opto/output.cpp
! src/share/vm/opto/subnode.cpp

Changeset: 8bcfd9ce2c6b
Author:    twisti
Date:      2013-05-13 12:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/8bcfd9ce2c6b

Merge

- make/bsd/makefiles/launcher.make
- make/linux/makefiles/launcher.make
- make/solaris/makefiles/launcher.make
- make/windows/makefiles/launcher.make
- src/os/posix/launcher/java_md.c
- src/os/posix/launcher/java_md.h
- src/os/posix/launcher/launcher.script
- src/os/windows/launcher/java_md.c
- src/os/windows/launcher/java_md.h
- src/share/tools/launcher/java.c
- src/share/tools/launcher/java.h
- src/share/tools/launcher/jli_util.c
- src/share/tools/launcher/jli_util.h
- src/share/tools/launcher/wildcard.c
- src/share/tools/launcher/wildcard.h
! src/share/vm/classfile/vmSymbols.hpp
! src/share/vm/runtime/arguments.cpp

Changeset: 1da5d70655e9
Author:    kvn
Date:      2013-05-13 14:36 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/1da5d70655e9

8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
Summary: Corrected escape state for the result of boxing method. Added force inlining executed boxing methods.
Reviewed-by: twisti

! src/share/vm/opto/bytecodeInfo.cpp
! src/share/vm/opto/escape.cpp

Changeset: cd6f6fccd287
Author:    iignatyev
Date:      2013-05-15 22:44 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/cd6f6fccd287

8014068: TEST_BUG: compiler/ciReplay/TestSA.sh fails on Windows: core wasn't generated
Reviewed-by: kvn

! test/compiler/ciReplay/TestSA.sh
! test/compiler/ciReplay/common.sh

Changeset: e484fe2abebd
Author:    twisti
Date:      2013-05-16 13:47 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/e484fe2abebd

Merge

- make/bsd/makefiles/launcher.make
! make/bsd/makefiles/vm.make
- make/linux/makefiles/launcher.make
- make/solaris/makefiles/launcher.make
- make/windows/makefiles/launcher.make
- src/os/posix/launcher/java_md.c
- src/os/posix/launcher/java_md.h
- src/os/posix/launcher/launcher.script
- src/os/windows/launcher/java_md.c
- src/os/windows/launcher/java_md.h
- src/share/tools/launcher/java.c
- src/share/tools/launcher/java.h
- src/share/tools/launcher/jli_util.c
- src/share/tools/launcher/jli_util.h
- src/share/tools/launcher/wildcard.c
- src/share/tools/launcher/wildcard.h
! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/oops/method.cpp
! src/share/vm/prims/methodHandles.cpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/vmStructs.cpp
! src/share/vm/utilities/quickSort.cpp


From alejandro.murillo at oracle.com  Thu May 16 23:05:25 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 17 May 2013 06:05:25 +0000
Subject: hg: hsx/hsx24/hotspot: 8014759: new hotspot build - hs24-b46
Message-ID: <20130517060530.B765248B5A@hg.openjdk.java.net>

Changeset: 3a049c5a3407
Author:    amurillo
Date:      2013-05-16 16:18 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/3a049c5a3407

8014759: new hotspot build - hs24-b46
Reviewed-by: jcoomes

! make/hotspot_version


From jesper.wilhelmsson at oracle.com  Fri May 17 06:26:50 2013
From: jesper.wilhelmsson at oracle.com (jesper.wilhelmsson at oracle.com)
Date: Fri, 17 May 2013 13:26:50 +0000
Subject: hg: hsx/hotspot-main/hotspot: 11 new changesets
Message-ID: <20130517132716.407FB48B69@hg.openjdk.java.net>

Changeset: 7a95933197d0
Author:    tschatzl
Date:      2013-05-13 09:45 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/7a95933197d0

8014058: Regression tests for 8006088
Summary: The patch for 8006088 misses regression tests after a merge error, this CR provides them.
Reviewed-by: jwilhelm, tamao, jmasa

! src/share/vm/memory/collectorPolicy.cpp
+ test/gc/arguments/TestCMSHeapSizeFlags.java
+ test/gc/arguments/TestG1HeapSizeFlags.java
+ test/gc/arguments/TestMaxHeapSizeTools.java
+ test/gc/arguments/TestMinInitialErgonomics.java
+ test/gc/arguments/TestParallelHeapSizeFlags.java
+ test/gc/arguments/TestSerialHeapSizeFlags.java

Changeset: 4868caa99ecf
Author:    brutisso
Date:      2013-05-13 14:09 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/4868caa99ecf

8014339: Improve assert and remove some dead code from parMarkBitMap.hpp/cpp
Reviewed-by: stefank, tschatzl

! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp
! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp
- src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp

Changeset: 0a2986f36965
Author:    tschatzl
Date:      2013-05-14 17:08 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/0a2986f36965

8014489: tests/gc/arguments/Test(Serial|CMS|Parallel|G1)HeapSizeFlags jtreg tests invoke wrong class
Summary: Some jtreg tests reference unknown classes in the @run and @build lines. This change fixes them.
Reviewed-by: stefank, ehelin

! test/gc/arguments/TestCMSHeapSizeFlags.java
! test/gc/arguments/TestG1HeapSizeFlags.java
! test/gc/arguments/TestParallelHeapSizeFlags.java
! test/gc/arguments/TestSerialHeapSizeFlags.java

Changeset: 12f651e29f6b
Author:    tschatzl
Date:      2013-05-15 11:05 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/12f651e29f6b

6843347: Boundary values in some public GC options cause crashes
Summary: Setting some public integer options to specific values causes crashes or undefined GC behavior. This patchset adds the necessary argument checking for these options.
Reviewed-by: jmasa, brutisso

! src/cpu/sparc/vm/globals_sparc.hpp
! src/cpu/x86/vm/globals_x86.hpp
! src/cpu/zero/vm/globals_zero.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.cpp
! src/share/vm/gc_implementation/shared/markSweep.cpp
! src/share/vm/gc_implementation/shared/markSweep.hpp
! src/share/vm/memory/collectorPolicy.cpp
! src/share/vm/memory/space.hpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp

Changeset: eba99d16dc6f
Author:    tamao
Date:      2013-05-15 10:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/eba99d16dc6f

8007763: Refactoring: split up compute_generation_free_space() into two functions for class PSAdaptiveSizePolicy
Summary: split up compute_generation_free_space() into two functions: compute_eden_space_size() + compute_old_gen_free_space(), each of which (if needed) can be reused without executing an overhead of the other.
Reviewed-by: jmasa, tschatzl
Contributed-by: tamao <tao.mao at oracle.com>

! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp
! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.hpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp

Changeset: bed55d125e37
Author:    johnc
Date:      2013-05-15 22:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/bed55d125e37

8014408: G1: crashes with assert assert(prev_committed_card_num == _committed_max_card_num) failed
Summary: Mismatch in the card number calculation between next and previous committed sizes of the card counts table.
Reviewed-by: jmasa, tschatzl

! src/share/vm/gc_implementation/g1/g1CardCounts.cpp
! src/share/vm/gc_implementation/g1/g1CardCounts.hpp

Changeset: 05a17f270c7e
Author:    tschatzl
Date:      2013-05-16 13:02 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/05a17f270c7e

8014240: G1: Add remembered set size information to output of G1PrintRegionLivenessInfo
Summary: Improve the output of G1PrintRegionLivenessInfo by adding a per-region remembered set size information column
Reviewed-by: jwilhelm, johnc

! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/concurrentMark.hpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
+ test/gc/g1/TestPrintRegionRememberedSetInfo.java

Changeset: 48391ab0687e
Author:    johnc
Date:      2013-05-16 09:24 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/48391ab0687e

8010738: G1: Output for full GCs with +PrintGCDetails should contain perm gen size/meta data change info
Summary: Include metaspace information (used, allocated, reserved) in the PrintGCDetails output for full GCs.
Reviewed-by: poonam, jmasa, brutisso

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp
+ test/gc/g1/TestPrintGCDetails.java

Changeset: acac2b03a07f
Author:    tschatzl
Date:      2013-05-16 23:51 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/acac2b03a07f

8014765: VM exits if MaxTenuringThreshold is set below the default InitialTenuringThreshold, and InitialTenuringThreshold is not set
Summary: The VM exits when the condition in the subject line applies. The fix sets InitialTenuringThreshold to MaxTenuringThreshold if it is larger than MaxTenuringThreshold and InitialTenuringThreshold has not been set (is default).
Reviewed-by: jwilhelm, jmasa, brutisso, johnc

! src/share/vm/runtime/arguments.cpp
+ test/gc/arguments/TestInitialTenuringThreshold.java

Changeset: 2958af1d8c5a
Author:    jwilhelm
Date:      2013-05-17 06:01 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/2958af1d8c5a

Merge

! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
- src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp
! src/share/vm/gc_implementation/shared/markSweep.cpp
! src/share/vm/memory/collectorPolicy.cpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp

Changeset: 2f9ac66165e6
Author:    jwilhelm
Date:      2013-05-17 08:00 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/2f9ac66165e6

Merge

- src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp
! src/share/vm/runtime/arguments.cpp


From aleksey.shipilev at oracle.com  Fri May 17 06:40:47 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Fri, 17 May 2013 17:40:47 +0400
Subject: RFR (S): CR 8012939: @Contended doesn't work correctly with
	inheritance
In-Reply-To: <51957997.2040407@oracle.com>
References: <5192B99B.50405@oracle.com>
	<FD45D2AE-DAF2-49F9-B948-963C003351C9@oracle.com>
	<519553AF.8090805@oracle.com> <51957997.2040407@oracle.com>
Message-ID: <5196335F.7010006@oracle.com>

Thanks!

On 05/17/2013 04:28 AM, David Holmes wrote:
> I will sponsor the push to hotspot-rt.
> 
> Thanks,
> David
> 
> On 17/05/2013 7:46 AM, Aleksey Shipilev wrote:
>> On 05/17/2013 01:31 AM, John Rose wrote:
>>> On May 14, 2013, at 3:24 PM, Aleksey Shipilev
>>> <aleksey.shipilev at oracle.com <mailto:aleksey.shipilev at oracle.com>>
>>> wrote:
>>>
>>>> It seems we have a plenty of failures in new SQE tests for @Contended
>>>> because of this. Please see the updated webrev for the issue:
>>>>   http://cr.openjdk.java.net/~shade/8012939/webrev.01/
>>>> <http://cr.openjdk.java.net/%7Eshade/8012939/webrev.01/>
>>>>
>>>> This is the minimal fix.
>>>
>>> Aleksey, you can count me as a reviewer on the minimal fix.
>>
>> Thanks!
>>
>> For the record, the updated webrev with test renaming is here:
>>    http://cr.openjdk.java.net/~shade/8012939/webrev.03/
>>
>> Now I need a sponsor to push this. The changeset with all the meta-info
>> is here:
>>    http://cr.openjdk.java.net/~shade/8012939/8012939.changeset
>>
>> -Aleksey.
>>


From aleksey.shipilev at oracle.com  Fri May 17 06:40:59 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Fri, 17 May 2013 17:40:59 +0400
Subject: RFR (XS) CR 8014509: @Contended: explicit default value behaves
	differently from the implicit value
In-Reply-To: <5195901F.9070201@oracle.com>
References: <5193AB67.2050201@oracle.com> <5193B902.3070006@oracle.com>
	<5193BA05.2010201@oracle.com> <5193BCED.60004@oracle.com>
	<51953538.6040701@oracle.com> <5195467E.3050007@oracle.com>
	<51954EBC.4010609@oracle.com>
	<3BF2D919-2F26-4FF2-9B6A-6E08F2C31F76@oracle.com>
	<519556CD.60809@oracle.com> <5195901F.9070201@oracle.com>
Message-ID: <5196336B.7050403@oracle.com>

Thanks again!

-Aleksey.

On 05/17/2013 06:04 AM, David Holmes wrote:
> Sponsored and submitted to JPRT.
> 
> David
> 
> On 17/05/2013 7:59 AM, Aleksey Shipilev wrote:
>> On 05/17/2013 01:52 AM, Christian Thalinger wrote:
>>> Looks good.  -- Chris
>>>
>>> On May 16, 2013, at 2:25 PM, Aleksey Shipilev
>>> <aleksey.shipilev at oracle.com> wrote:
>>>
>>>> On 05/17/2013 12:50 AM, Vladimir Kozlov wrote:
>>>>> You forgot to change != to ==
>>>>>
>>>>> +        if (_cp->symbol_at(group_index)->utf8_length() != 0) {
>>>>> +          group_index = 0; // default contended group
>>>>>
>>>>> Otherwise it is good. Thank you for the comment.
>>>>
>>>> Darn. Now I see why test renamings are good: it had actually regressed
>>>> the 8003985 test.
>>>>
>>>> Fixed:
>>>>   http://cr.openjdk.java.net/~shade/8014509/webrev.03/
>>>>
>>>> We need the second reviewer.
>>
>> Great, thanks.
>>
>> Any sponsors around? :) Please push:
>>   http://cr.openjdk.java.net/~shade/8014509/8014509.changeset
>>
>> -Aleksey.
>>


From alejandro.murillo at oracle.com  Fri May 17 12:21:22 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 17 May 2013 19:21:22 +0000
Subject: hg: hsx/hsx25/hotspot: 47 new changesets
Message-ID: <20130517192256.8890848B7D@hg.openjdk.java.net>

Changeset: 1cdbd42c3e49
Author:    katleman
Date:      2013-05-16 12:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/1cdbd42c3e49

Added tag jdk8-b90 for changeset 1ae0472ff3a0

! .hgtags

Changeset: 6114c49b31b5
Author:    amurillo
Date:      2013-05-10 11:27 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/6114c49b31b5

8014279: new hotspot build - hs25-b33
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: 712a1e9c91f3
Author:    coleenp
Date:      2013-05-07 09:46 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/712a1e9c91f3

8013063: nsk/jvmti/RetransformClasses/retransform001 failed debug version on os::free
Summary: Clear out class_file_bytes so they aren't deallocated twice
Reviewed-by: dcubed, sspitsyn

! src/share/vm/prims/jvmtiRedefineClasses.cpp

Changeset: 4674e409a9e6
Author:    coleenp
Date:      2013-05-07 18:51 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/4674e409a9e6

8014024: NPG: keep compiled ic methods from being deallocated in redefine classes
Summary: Walk the compiledIC relocation records to keep Method* from being deallocated.
Reviewed-by: dlong, kvn

! src/share/vm/code/nmethod.cpp

Changeset: a1cc1d1e7ce5
Author:    coleenp
Date:      2013-05-07 16:17 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/a1cc1d1e7ce5

Merge


Changeset: 28ae1d38d296
Author:    coleenp
Date:      2013-05-07 18:46 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/28ae1d38d296

Merge


Changeset: 64340da5b68c
Author:    hseigel
Date:      2013-05-08 08:20 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/64340da5b68c

8007018: RFE: -XX:+UseLargePages does not work with CDS
Summary: Remove command line restriction.  It should just work.
Reviewed-by: ctornqvi, coleenp, dholmes

! src/share/vm/runtime/arguments.cpp

Changeset: cbfe859bd244
Author:    sla
Date:      2013-05-08 15:37 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/cbfe859bd244

8013591: compiler/ciReplay/TestSA.sh fails in nightly
Reviewed-by: coleenp, rbackman, dholmes

! agent/src/share/classes/sun/jvm/hotspot/ci/ciMethod.java
! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java
! agent/src/share/classes/sun/jvm/hotspot/oops/MethodData.java

Changeset: 0dc028fd5101
Author:    sla
Date:      2013-05-08 10:14 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/0dc028fd5101

Merge


Changeset: 39ead0411f07
Author:    bharadwaj
Date:      2013-05-08 14:18 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/39ead0411f07

8013875: Incorrect vtable index being set during methodHandle creation for static
Summary: Set vtable index as appropriate for static interface methods and for interface methods invoked via invokespecial. To be improved in a later enhancement to CallInfo.
Reviewed-by: jrose, twisti

! src/share/vm/prims/methodHandles.cpp

Changeset: 711016f146fd
Author:    dholmes
Date:      2013-05-08 19:28 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/711016f146fd

8006997: ContendedPaddingWidth should be range-checked
Summary: Constrain between zero and 8K
Reviewed-by: dholmes, rbackman
Contributed-by: Aleksey Shipilev <aleksey.shipilev at oracle.com>

! src/share/vm/runtime/arguments.cpp

Changeset: 9b77ca4ce35e
Author:    dholmes
Date:      2013-05-08 19:38 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/9b77ca4ce35e

Merge

! src/share/vm/runtime/arguments.cpp

Changeset: c272092594bd
Author:    dholmes
Date:      2013-05-08 21:06 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/c272092594bd

Merge


Changeset: 0b7f78069732
Author:    rbackman
Date:      2013-05-08 11:21 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/0b7f78069732

8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return
Reviewed-by: coleenp, dholmes, sla

! src/share/vm/prims/jvmtiExport.cpp

Changeset: 735c995bf1a1
Author:    rbackman
Date:      2013-05-13 07:53 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/735c995bf1a1

Merge

! src/share/vm/runtime/arguments.cpp

Changeset: 92ef81e2f571
Author:    minqi
Date:      2013-05-10 08:27 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/92ef81e2f571

8003557: NPG: Klass* const k should be const Klass* k.
Summary: With NPG, const KlassOop klass which is in fact a definition converted to Klass* const, which is not the original intention. The right usage is converting them to const Klass*.
Reviewed-by: coleenp, kvn
Contributed-by: yumin.qi at oracle.com

! src/share/vm/c1/c1_Runtime1.cpp
! src/share/vm/classfile/verifier.cpp
! src/share/vm/classfile/verifier.hpp
! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp
! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp
! src/share/vm/gc_implementation/shared/markSweep.cpp
! src/share/vm/memory/heapInspection.cpp
! src/share/vm/memory/heapInspection.hpp
! src/share/vm/memory/universe.cpp
! src/share/vm/memory/universe.hpp
! src/share/vm/oops/constantPool.hpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/oops/klass.cpp
! src/share/vm/oops/klass.hpp
! src/share/vm/oops/method.cpp
! src/share/vm/oops/method.hpp
! src/share/vm/oops/methodData.hpp
! src/share/vm/prims/jvm.cpp
! src/share/vm/prims/jvmtiTagMap.cpp

Changeset: 1fcfc045b229
Author:    minqi
Date:      2013-05-10 19:30 +0000
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/1fcfc045b229

Merge


Changeset: 8b40495b9381
Author:    minqi
Date:      2013-05-13 18:08 +0000
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/8b40495b9381

Merge

! src/share/vm/oops/method.hpp

Changeset: 43083e670adf
Author:    coleenp
Date:      2013-05-13 15:37 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/43083e670adf

8005056: NPG: Crash after redefining java.lang.Object
Summary: Need to walk array class vtables replacing old methods too if j.l.o redefined
Reviewed-by: sspitsyn, dcubed, ctornqvi

! src/share/vm/classfile/dictionary.cpp
! src/share/vm/classfile/dictionary.hpp
! src/share/vm/classfile/systemDictionary.cpp
! src/share/vm/classfile/systemDictionary.hpp
! src/share/vm/oops/klass.hpp
! src/share/vm/prims/jvmtiRedefineClasses.cpp
! src/share/vm/prims/jvmtiRedefineClasses.hpp
+ test/runtime/RedefineObject/Agent.java
+ test/runtime/RedefineObject/TestRedefineObject.java
! test/testlibrary/ClassFileInstaller.java

Changeset: a9270d9ecb13
Author:    shade
Date:      2013-05-14 11:34 +0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/a9270d9ecb13

8014448: Purge PrintCompactFieldsSavings
Summary: Remove obsolete debugging code.
Reviewed-by: dholmes, kvn
Contributed-by: Aleksey Shipilev <aleksey.shipilev at oracle.com>

! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/runtime/globals.hpp

Changeset: f944ba972151
Author:    hseigel
Date:      2013-05-14 09:17 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/f944ba972151

8014138: Add VM option to facilitate the writing of CDS tests
Summary: Added the -XX:SharedArchiveFile option.
Reviewed-by: coleenp, ccheung, acorn, dcubed, zgu

! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp
+ test/runtime/SharedArchiveFile/SharedArchiveFile.java

Changeset: f9be75d21404
Author:    minqi
Date:      2013-05-14 09:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/f9be75d21404

8012902: remove use of global operator new - take 2
Summary: The fix of 8010992, disable use of global operator new and new[] which caused failure on some tests. This takes two of the bugs also add ALLOW_OPERATOR_NEW_USAGE to prevent crash for third party code calling operator new of jvm on certain platforms.
Reviewed-by: coleenp, dholmes, zgu
Contributed-by: yumin.qi at oracle.com

! make/bsd/makefiles/fastdebug.make
! make/bsd/makefiles/vm.make
! src/os/windows/vm/os_windows.cpp
! src/share/vm/ci/ciReplay.cpp
! src/share/vm/classfile/altHashing.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
! src/share/vm/memory/allocation.cpp
! src/share/vm/memory/allocation.hpp
! src/share/vm/memory/allocation.inline.hpp
! src/share/vm/memory/cardTableModRefBS.cpp
! src/share/vm/memory/cardTableModRefBS.hpp
! src/share/vm/memory/cardTableRS.cpp
! src/share/vm/memory/cardTableRS.hpp
! src/share/vm/memory/collectorPolicy.cpp
! src/share/vm/memory/memRegion.cpp
! src/share/vm/memory/memRegion.hpp
! src/share/vm/opto/idealGraphPrinter.hpp
! src/share/vm/runtime/handles.cpp
! src/share/vm/runtime/handles.hpp
! src/share/vm/runtime/objectMonitor.hpp
! src/share/vm/runtime/reflectionUtils.hpp
! src/share/vm/runtime/unhandledOops.hpp
! src/share/vm/runtime/vmStructs.cpp
! src/share/vm/utilities/events.hpp
! src/share/vm/utilities/quickSort.cpp
! src/share/vm/utilities/workgroup.cpp
! src/share/vm/utilities/workgroup.hpp

Changeset: 513a5298c1dd
Author:    minqi
Date:      2013-05-14 17:33 +0000
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/513a5298c1dd

Merge


Changeset: d15464bfd4d0
Author:    roland
Date:      2013-05-03 09:32 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d15464bfd4d0

8012037: Test8009761.java "Failed: init recursive calls: 7224. After deopt 58824"
Summary: test shouldn't be run with a modified CompileThreshold
Reviewed-by: kvn

! test/compiler/8009761/Test8009761.java

Changeset: e76dd894b984
Author:    roland
Date:      2013-04-24 14:26 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/e76dd894b984

8012292: optimized build with GCC broken
Summary: Some #ifndef PRODUCT should be #ifdef ASSERT
Reviewed-by: kvn, twisti
Contributed-by: gdub <duboscq at ssw.jku.at>

! make/jprt.properties
! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/classfile/vmSymbols.cpp
! src/share/vm/opto/runtime.cpp
! src/share/vm/utilities/quickSort.cpp

Changeset: d73c88e524ff
Author:    kvn
Date:      2013-05-03 15:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/d73c88e524ff

Merge

! src/share/vm/classfile/classFileParser.cpp

Changeset: f0bc60565ba8
Author:    twisti
Date:      2013-05-06 13:53 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/f0bc60565ba8

7196277: JSR 292: Two jck/runtime tests crash on java.lang.invoke.MethodHandle.invokeExact
Reviewed-by: jrose, kvn

! src/share/vm/oops/method.cpp
! src/share/vm/prims/methodHandles.cpp
! src/share/vm/prims/nativeLookup.cpp
! src/share/vm/runtime/sharedRuntime.cpp

Changeset: aabf54ccedb1
Author:    twisti
Date:      2013-05-06 19:49 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/aabf54ccedb1

8008772: remove gamma launcher
Reviewed-by: kvn, neliasso, ctornqvi

! make/Makefile
! make/bsd/makefiles/buildtree.make
- make/bsd/makefiles/launcher.make
! make/bsd/makefiles/vm.make
+ make/hotspot.script
! make/linux/makefiles/buildtree.make
- make/linux/makefiles/launcher.make
! make/linux/makefiles/vm.make
! make/solaris/makefiles/buildtree.make
- make/solaris/makefiles/launcher.make
! make/solaris/makefiles/vm.make
! make/windows/makefiles/debug.make
! make/windows/makefiles/fastdebug.make
- make/windows/makefiles/launcher.make
! make/windows/makefiles/product.make
! make/windows/makefiles/projectcreator.make
! make/windows/projectfiles/common/Makefile
- src/os/posix/launcher/java_md.c
- src/os/posix/launcher/java_md.h
- src/os/posix/launcher/launcher.script
- src/os/windows/launcher/java_md.c
- src/os/windows/launcher/java_md.h
! src/share/tools/ProjectCreator/BuildConfig.java
! src/share/tools/ProjectCreator/WinGammaPlatformVC10.java
- src/share/tools/launcher/java.c
- src/share/tools/launcher/java.h
- src/share/tools/launcher/jli_util.c
- src/share/tools/launcher/jli_util.h
- src/share/tools/launcher/wildcard.c
- src/share/tools/launcher/wildcard.h

Changeset: 6f3fd5150b67
Author:    kvn
Date:      2013-05-08 15:08 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/6f3fd5150b67

6934604: enable parts of EliminateAutoBox by default
Summary: Resurrected autobox elimination code and enabled part of it by default.
Reviewed-by: roland, twisti

! src/share/vm/ci/ciInstanceKlass.cpp
! src/share/vm/ci/ciInstanceKlass.hpp
! src/share/vm/ci/ciMethod.cpp
! src/share/vm/ci/ciMethod.hpp
! src/share/vm/classfile/vmSymbols.hpp
! src/share/vm/compiler/compileBroker.cpp
! src/share/vm/opto/bytecodeInfo.cpp
! src/share/vm/opto/c2_globals.hpp
! src/share/vm/opto/c2compiler.cpp
! src/share/vm/opto/callGenerator.cpp
! src/share/vm/opto/callGenerator.hpp
! src/share/vm/opto/callnode.cpp
! src/share/vm/opto/callnode.hpp
! src/share/vm/opto/cfgnode.cpp
! src/share/vm/opto/compile.cpp
! src/share/vm/opto/compile.hpp
! src/share/vm/opto/doCall.cpp
! src/share/vm/opto/escape.cpp
! src/share/vm/opto/graphKit.cpp
! src/share/vm/opto/ifnode.cpp
! src/share/vm/opto/library_call.cpp
! src/share/vm/opto/loopPredicate.cpp
! src/share/vm/opto/macro.cpp
! src/share/vm/opto/macro.hpp
! src/share/vm/opto/memnode.cpp
! src/share/vm/opto/memnode.hpp
! src/share/vm/opto/multnode.cpp
! src/share/vm/opto/multnode.hpp
! src/share/vm/opto/node.cpp
! src/share/vm/opto/node.hpp
! src/share/vm/opto/parse.hpp
! src/share/vm/opto/parse1.cpp
! src/share/vm/opto/parse2.cpp
! src/share/vm/opto/parse3.cpp
! src/share/vm/opto/parseHelper.cpp
! src/share/vm/opto/phase.cpp
! src/share/vm/opto/phase.hpp
! src/share/vm/opto/phaseX.cpp
! src/share/vm/opto/type.cpp
! src/share/vm/opto/type.hpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/vmStructs.cpp
+ test/compiler/6934604/TestByteBoxing.java
+ test/compiler/6934604/TestDoubleBoxing.java
+ test/compiler/6934604/TestFloatBoxing.java
+ test/compiler/6934604/TestIntBoxing.java
+ test/compiler/6934604/TestLongBoxing.java
+ test/compiler/6934604/TestShortBoxing.java

Changeset: 70120f47d403
Author:    kvn
Date:      2013-05-09 17:28 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/70120f47d403

8014189: JVM crash with SEGV in ConnectionGraph::record_for_escape_analysis()
Summary: Add NULL checks and asserts for Type::make_ptr() returned value.
Reviewed-by: twisti

! src/share/vm/opto/escape.cpp
! src/share/vm/opto/lcm.cpp
! src/share/vm/opto/library_call.cpp
! src/share/vm/opto/machnode.cpp
! src/share/vm/opto/macro.cpp
! src/share/vm/opto/node.cpp
! src/share/vm/opto/node.hpp
! src/share/vm/opto/output.cpp
! src/share/vm/opto/subnode.cpp

Changeset: 8bcfd9ce2c6b
Author:    twisti
Date:      2013-05-13 12:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/8bcfd9ce2c6b

Merge

- make/bsd/makefiles/launcher.make
- make/linux/makefiles/launcher.make
- make/solaris/makefiles/launcher.make
- make/windows/makefiles/launcher.make
- src/os/posix/launcher/java_md.c
- src/os/posix/launcher/java_md.h
- src/os/posix/launcher/launcher.script
- src/os/windows/launcher/java_md.c
- src/os/windows/launcher/java_md.h
- src/share/tools/launcher/java.c
- src/share/tools/launcher/java.h
- src/share/tools/launcher/jli_util.c
- src/share/tools/launcher/jli_util.h
- src/share/tools/launcher/wildcard.c
- src/share/tools/launcher/wildcard.h
! src/share/vm/classfile/vmSymbols.hpp
! src/share/vm/runtime/arguments.cpp

Changeset: 1da5d70655e9
Author:    kvn
Date:      2013-05-13 14:36 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/1da5d70655e9

8014286: failed java/lang/Math/DivModTests.java after 6934604 changes
Summary: Corrected escape state for the result of boxing method. Added force inlining executed boxing methods.
Reviewed-by: twisti

! src/share/vm/opto/bytecodeInfo.cpp
! src/share/vm/opto/escape.cpp

Changeset: cd6f6fccd287
Author:    iignatyev
Date:      2013-05-15 22:44 +0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/cd6f6fccd287

8014068: TEST_BUG: compiler/ciReplay/TestSA.sh fails on Windows: core wasn't generated
Reviewed-by: kvn

! test/compiler/ciReplay/TestSA.sh
! test/compiler/ciReplay/common.sh

Changeset: e484fe2abebd
Author:    twisti
Date:      2013-05-16 13:47 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/e484fe2abebd

Merge

- make/bsd/makefiles/launcher.make
! make/bsd/makefiles/vm.make
- make/linux/makefiles/launcher.make
- make/solaris/makefiles/launcher.make
- make/windows/makefiles/launcher.make
- src/os/posix/launcher/java_md.c
- src/os/posix/launcher/java_md.h
- src/os/posix/launcher/launcher.script
- src/os/windows/launcher/java_md.c
- src/os/windows/launcher/java_md.h
- src/share/tools/launcher/java.c
- src/share/tools/launcher/java.h
- src/share/tools/launcher/jli_util.c
- src/share/tools/launcher/jli_util.h
- src/share/tools/launcher/wildcard.c
- src/share/tools/launcher/wildcard.h
! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/oops/method.cpp
! src/share/vm/prims/methodHandles.cpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/vmStructs.cpp
! src/share/vm/utilities/quickSort.cpp

Changeset: 7a95933197d0
Author:    tschatzl
Date:      2013-05-13 09:45 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/7a95933197d0

8014058: Regression tests for 8006088
Summary: The patch for 8006088 misses regression tests after a merge error, this CR provides them.
Reviewed-by: jwilhelm, tamao, jmasa

! src/share/vm/memory/collectorPolicy.cpp
+ test/gc/arguments/TestCMSHeapSizeFlags.java
+ test/gc/arguments/TestG1HeapSizeFlags.java
+ test/gc/arguments/TestMaxHeapSizeTools.java
+ test/gc/arguments/TestMinInitialErgonomics.java
+ test/gc/arguments/TestParallelHeapSizeFlags.java
+ test/gc/arguments/TestSerialHeapSizeFlags.java

Changeset: 4868caa99ecf
Author:    brutisso
Date:      2013-05-13 14:09 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/4868caa99ecf

8014339: Improve assert and remove some dead code from parMarkBitMap.hpp/cpp
Reviewed-by: stefank, tschatzl

! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp
! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp
- src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp

Changeset: 0a2986f36965
Author:    tschatzl
Date:      2013-05-14 17:08 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/0a2986f36965

8014489: tests/gc/arguments/Test(Serial|CMS|Parallel|G1)HeapSizeFlags jtreg tests invoke wrong class
Summary: Some jtreg tests reference unknown classes in the @run and @build lines. This change fixes them.
Reviewed-by: stefank, ehelin

! test/gc/arguments/TestCMSHeapSizeFlags.java
! test/gc/arguments/TestG1HeapSizeFlags.java
! test/gc/arguments/TestParallelHeapSizeFlags.java
! test/gc/arguments/TestSerialHeapSizeFlags.java

Changeset: 12f651e29f6b
Author:    tschatzl
Date:      2013-05-15 11:05 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/12f651e29f6b

6843347: Boundary values in some public GC options cause crashes
Summary: Setting some public integer options to specific values causes crashes or undefined GC behavior. This patchset adds the necessary argument checking for these options.
Reviewed-by: jmasa, brutisso

! src/cpu/sparc/vm/globals_sparc.hpp
! src/cpu/x86/vm/globals_x86.hpp
! src/cpu/zero/vm/globals_zero.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.cpp
! src/share/vm/gc_implementation/shared/markSweep.cpp
! src/share/vm/gc_implementation/shared/markSweep.hpp
! src/share/vm/memory/collectorPolicy.cpp
! src/share/vm/memory/space.hpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp

Changeset: eba99d16dc6f
Author:    tamao
Date:      2013-05-15 10:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/eba99d16dc6f

8007763: Refactoring: split up compute_generation_free_space() into two functions for class PSAdaptiveSizePolicy
Summary: split up compute_generation_free_space() into two functions: compute_eden_space_size() + compute_old_gen_free_space(), each of which (if needed) can be reused without executing an overhead of the other.
Reviewed-by: jmasa, tschatzl
Contributed-by: tamao <tao.mao at oracle.com>

! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp
! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.hpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp

Changeset: bed55d125e37
Author:    johnc
Date:      2013-05-15 22:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/bed55d125e37

8014408: G1: crashes with assert assert(prev_committed_card_num == _committed_max_card_num) failed
Summary: Mismatch in the card number calculation between next and previous committed sizes of the card counts table.
Reviewed-by: jmasa, tschatzl

! src/share/vm/gc_implementation/g1/g1CardCounts.cpp
! src/share/vm/gc_implementation/g1/g1CardCounts.hpp

Changeset: 05a17f270c7e
Author:    tschatzl
Date:      2013-05-16 13:02 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/05a17f270c7e

8014240: G1: Add remembered set size information to output of G1PrintRegionLivenessInfo
Summary: Improve the output of G1PrintRegionLivenessInfo by adding a per-region remembered set size information column
Reviewed-by: jwilhelm, johnc

! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/concurrentMark.hpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
+ test/gc/g1/TestPrintRegionRememberedSetInfo.java

Changeset: 48391ab0687e
Author:    johnc
Date:      2013-05-16 09:24 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/48391ab0687e

8010738: G1: Output for full GCs with +PrintGCDetails should contain perm gen size/meta data change info
Summary: Include metaspace information (used, allocated, reserved) in the PrintGCDetails output for full GCs.
Reviewed-by: poonam, jmasa, brutisso

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp
+ test/gc/g1/TestPrintGCDetails.java

Changeset: acac2b03a07f
Author:    tschatzl
Date:      2013-05-16 23:51 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/acac2b03a07f

8014765: VM exits if MaxTenuringThreshold is set below the default InitialTenuringThreshold, and InitialTenuringThreshold is not set
Summary: The VM exits when the condition in the subject line applies. The fix sets InitialTenuringThreshold to MaxTenuringThreshold if it is larger than MaxTenuringThreshold and InitialTenuringThreshold has not been set (is default).
Reviewed-by: jwilhelm, jmasa, brutisso, johnc

! src/share/vm/runtime/arguments.cpp
+ test/gc/arguments/TestInitialTenuringThreshold.java

Changeset: 2958af1d8c5a
Author:    jwilhelm
Date:      2013-05-17 06:01 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/2958af1d8c5a

Merge

! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
- src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp
! src/share/vm/gc_implementation/shared/markSweep.cpp
! src/share/vm/memory/collectorPolicy.cpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp

Changeset: 2f9ac66165e6
Author:    jwilhelm
Date:      2013-05-17 08:00 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/2f9ac66165e6

Merge

- src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp
! src/share/vm/runtime/arguments.cpp

Changeset: b19517cecc2e
Author:    amurillo
Date:      2013-05-17 08:59 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b19517cecc2e

Merge

- make/bsd/makefiles/launcher.make
- make/linux/makefiles/launcher.make
- make/solaris/makefiles/launcher.make
- make/windows/makefiles/launcher.make
- src/os/posix/launcher/java_md.c
- src/os/posix/launcher/java_md.h
- src/os/posix/launcher/launcher.script
- src/os/windows/launcher/java_md.c
- src/os/windows/launcher/java_md.h
- src/share/tools/launcher/java.c
- src/share/tools/launcher/java.h
- src/share/tools/launcher/jli_util.c
- src/share/tools/launcher/jli_util.h
- src/share/tools/launcher/wildcard.c
- src/share/tools/launcher/wildcard.h
- src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp

Changeset: 7cbdf0e3725c
Author:    amurillo
Date:      2013-05-17 08:59 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/7cbdf0e3725c

Added tag hs25-b33 for changeset b19517cecc2e

! .hgtags


From alejandro.murillo at oracle.com  Fri May 17 14:58:25 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 17 May 2013 21:58:25 +0000
Subject: hg: hsx/hotspot-main/hotspot: 4 new changesets
Message-ID: <20130517215836.AE00548B83@hg.openjdk.java.net>

Changeset: 1cdbd42c3e49
Author:    katleman
Date:      2013-05-16 12:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/1cdbd42c3e49

Added tag jdk8-b90 for changeset 1ae0472ff3a0

! .hgtags

Changeset: b19517cecc2e
Author:    amurillo
Date:      2013-05-17 08:59 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b19517cecc2e

Merge

- make/bsd/makefiles/launcher.make
- make/linux/makefiles/launcher.make
- make/solaris/makefiles/launcher.make
- make/windows/makefiles/launcher.make
- src/os/posix/launcher/java_md.c
- src/os/posix/launcher/java_md.h
- src/os/posix/launcher/launcher.script
- src/os/windows/launcher/java_md.c
- src/os/windows/launcher/java_md.h
- src/share/tools/launcher/java.c
- src/share/tools/launcher/java.h
- src/share/tools/launcher/jli_util.c
- src/share/tools/launcher/jli_util.h
- src/share/tools/launcher/wildcard.c
- src/share/tools/launcher/wildcard.h
- src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp

Changeset: 7cbdf0e3725c
Author:    amurillo
Date:      2013-05-17 08:59 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/7cbdf0e3725c

Added tag hs25-b33 for changeset b19517cecc2e

! .hgtags

Changeset: 7ec426e29e4c
Author:    amurillo
Date:      2013-05-17 09:10 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/7ec426e29e4c

8014760: new hotspot build - hs25-b34
Reviewed-by: jcoomes

! make/hotspot_version


From linuxhippy at gmail.com  Sat May 18 16:22:47 2013
From: linuxhippy at gmail.com (Clemens Eisserer)
Date: Sun, 19 May 2013 01:22:47 +0200
Subject: vcall wish for hotspot
In-Reply-To: <1368894030.34126.YahooMailNeo@web141104.mail.bf1.yahoo.com>
References: <1368805203.4614.YahooMailNeo@web141102.mail.bf1.yahoo.com>
	<5197974E.1060105@redhat.com>
	<1368894030.34126.YahooMailNeo@web141104.mail.bf1.yahoo.com>
Message-ID: <CAFvQSYRDutr4fr0wBDUPM-ofM5WaLZvP85uqrtiJ9ptgXHa1Jw@mail.gmail.com>

Hi Andy,

>> I do know that C++ compilers can emit much much faster vcalls,
>> especially when the class is not involving multiple inheritance.
> As to how much faster c++ is, I haven't coded in C++ at all in 5 years, and
> then it was on a much slower laptop, so I'm not set up to benchmark it.

You have not benchmarked it, yet claim to "know" C++ compilers emot
"much much" faster code for this case?


> Then in two identical warmed up loop functions of 10 billion iterations,
> one the iterates and returns the sum of Link get() and one that returns the sum of Link3 get(),
> compare the time to execute both.
> The difference is about .5 nanos per iteration on my machine.

The difference you see with your benchmark is not only the pure
overhead of bimorphic call logic, but far more important, branch
misprediction caused by the alternating branch targets.

- Clemens

From aleksey.shipilev at oracle.com  Mon May 20 02:18:03 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Mon, 20 May 2013 13:18:03 +0400
Subject: RFR (XS) CR 8014871: Move @Contended regression tests to the same
	place
Message-ID: <5199EA4B.9000700@oracle.com>

Hi,

This is the trivial test movement:
  http://cr.openjdk.java.net/~shade/8014871/webrev.00/

Please review and sponsor (can provide the changeset once I know who the
reviewers are).

-Aleksey.

From bengt.rutisson at oracle.com  Mon May 20 03:11:23 2013
From: bengt.rutisson at oracle.com (bengt.rutisson at oracle.com)
Date: Mon, 20 May 2013 10:11:23 +0000
Subject: hg: hsx/hsx24/hotspot: 7176220: 'Full GC' events miss date stamp
	information occasionally
Message-ID: <20130520101128.85D4348BB5@hg.openjdk.java.net>

Changeset: aa01d1f5fcd9
Author:    aeriksso
Date:      2013-05-17 17:24 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/aa01d1f5fcd9

7176220: 'Full GC' events miss date stamp information occasionally
Summary: Move date stamp logic into GCTraceTime
Reviewed-by: johnc, brutisso, jmasa

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp
! src/share/vm/gc_implementation/shared/gcTraceTime.cpp
! src/share/vm/memory/genCollectedHeap.cpp


From staffan.larsen at oracle.com  Mon May 20 04:12:39 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Mon, 20 May 2013 13:12:39 +0200
Subject: RFR (XS) CR 8014871: Move @Contended regression tests to the same
	place
In-Reply-To: <5199EA4B.9000700@oracle.com>
References: <5199EA4B.9000700@oracle.com>
Message-ID: <9763716F-2BC8-4907-8102-03380E86F9F0@oracle.com>

I see a file added (hotspot/test/runtime/contended/Basic.java), but no file removed.

/Staffan

On 20 maj 2013, at 11:18, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:

> Hi,
> 
> This is the trivial test movement:
>  http://cr.openjdk.java.net/~shade/8014871/webrev.00/
> 
> Please review and sponsor (can provide the changeset once I know who the
> reviewers are).
> 
> -Aleksey.


From aleksey.shipilev at oracle.com  Mon May 20 04:16:54 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Mon, 20 May 2013 15:16:54 +0400
Subject: RFR (XS) CR 8014871: Move @Contended regression tests to the
	same place
In-Reply-To: <9763716F-2BC8-4907-8102-03380E86F9F0@oracle.com>
References: <5199EA4B.9000700@oracle.com>
	<9763716F-2BC8-4907-8102-03380E86F9F0@oracle.com>
Message-ID: <519A0626.2020107@oracle.com>

That was "hg mv". Does it display properly in webrev? Should I use
something else? Alternatively, I can generate the changeset which
actually moves the file.

-Aleksey.

On 05/20/2013 03:12 PM, Staffan Larsen wrote:
> I see a file added (hotspot/test/runtime/contended/Basic.java), but no file removed.
> 
> /Staffan
> 
> On 20 maj 2013, at 11:18, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
> 
>> Hi,
>>
>> This is the trivial test movement:
>>  http://cr.openjdk.java.net/~shade/8014871/webrev.00/
>>
>> Please review and sponsor (can provide the changeset once I know who the
>> reviewers are).
>>
>> -Aleksey.
> 


From aleksey.shipilev at oracle.com  Mon May 20 04:46:49 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Mon, 20 May 2013 15:46:49 +0400
Subject: RFR (XS) CR 8014871: Move @Contended regression tests to the
	same place
In-Reply-To: <519A0626.2020107@oracle.com>
References: <5199EA4B.9000700@oracle.com>
	<9763716F-2BC8-4907-8102-03380E86F9F0@oracle.com>
	<519A0626.2020107@oracle.com>
Message-ID: <519A0D29.2050800@oracle.com>

On 05/20/2013 03:16 PM, Aleksey Shipilev wrote:
> That was "hg mv". Does it display properly in webrev? Should I use
> something else? Alternatively, I can generate the changeset which
> actually moves the file.

Nevermind, here's the changeset:
 http://cr.openjdk.java.net/~shade/8014871/8014871.01.changeset

Please review, and we can then either fix something in the changeset, or
just populate "Reviewed-by:" and get done with it.

-Aleksey.



From david.holmes at oracle.com  Mon May 20 05:31:22 2013
From: david.holmes at oracle.com (David Holmes)
Date: Mon, 20 May 2013 22:31:22 +1000
Subject: RFR (XS) CR 8014871: Move @Contended regression tests to the
	same place
In-Reply-To: <519A0D29.2050800@oracle.com>
References: <5199EA4B.9000700@oracle.com>
	<9763716F-2BC8-4907-8102-03380E86F9F0@oracle.com>
	<519A0626.2020107@oracle.com> <519A0D29.2050800@oracle.com>
Message-ID: <519A179A.9010705@oracle.com>

On 20/05/2013 9:46 PM, Aleksey Shipilev wrote:
> On 05/20/2013 03:16 PM, Aleksey Shipilev wrote:
>> That was "hg mv". Does it display properly in webrev? Should I use
>> something else? Alternatively, I can generate the changeset which
>> actually moves the file.
>
> Nevermind, here's the changeset:
>   http://cr.openjdk.java.net/~shade/8014871/8014871.01.changeset

The webrev was confused - it showed the old file contents eg:

48 public class Test8003985 {

in the new Basic.java. The changeset looks okay.

Reviewed and sponsored.

David
-----

> Please review, and we can then either fix something in the changeset, or
> just populate "Reviewed-by:" and get done with it.
>
> -Aleksey.
>
>

From staffan.larsen at oracle.com  Mon May 20 05:35:11 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Mon, 20 May 2013 14:35:11 +0200
Subject: RFR (XS) CR 8014871: Move @Contended regression tests to the same
	place
In-Reply-To: <519A0D29.2050800@oracle.com>
References: <5199EA4B.9000700@oracle.com>
	<9763716F-2BC8-4907-8102-03380E86F9F0@oracle.com>
	<519A0626.2020107@oracle.com> <519A0D29.2050800@oracle.com>
Message-ID: <AFD47D83-310E-478E-8A01-3C2854E0EC21@oracle.com>

Changeset looks good.

/Staffan

On 20 maj 2013, at 13:46, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:

> On 05/20/2013 03:16 PM, Aleksey Shipilev wrote:
>> That was "hg mv". Does it display properly in webrev? Should I use
>> something else? Alternatively, I can generate the changeset which
>> actually moves the file.
> 
> Nevermind, here's the changeset:
> http://cr.openjdk.java.net/~shade/8014871/8014871.01.changeset
> 
> Please review, and we can then either fix something in the changeset, or
> just populate "Reviewed-by:" and get done with it.
> 
> -Aleksey.
> 
> 


From aleksey.shipilev at oracle.com  Mon May 20 05:37:57 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Mon, 20 May 2013 16:37:57 +0400
Subject: RFR (XS) CR 8014871: Move @Contended regression tests to the
	same place
In-Reply-To: <519A179A.9010705@oracle.com>
References: <5199EA4B.9000700@oracle.com>
	<9763716F-2BC8-4907-8102-03380E86F9F0@oracle.com>
	<519A0626.2020107@oracle.com> <519A0D29.2050800@oracle.com>
	<519A179A.9010705@oracle.com>
Message-ID: <519A1925.8000805@oracle.com>

On 05/20/2013 04:31 PM, David Holmes wrote:
>> Nevermind, here's the changeset:
>>   http://cr.openjdk.java.net/~shade/8014871/8014871.01.changeset
> Reviewed and sponsored.

Thanks! Please make sure "Reviewed-by:" is correct.

-Aleksey.


From aleksey.shipilev at oracle.com  Mon May 20 05:38:07 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Mon, 20 May 2013 16:38:07 +0400
Subject: RFR (XS) CR 8014871: Move @Contended regression tests to the
	same place
In-Reply-To: <AFD47D83-310E-478E-8A01-3C2854E0EC21@oracle.com>
References: <5199EA4B.9000700@oracle.com>
	<9763716F-2BC8-4907-8102-03380E86F9F0@oracle.com>
	<519A0626.2020107@oracle.com> <519A0D29.2050800@oracle.com>
	<AFD47D83-310E-478E-8A01-3C2854E0EC21@oracle.com>
Message-ID: <519A192F.1080703@oracle.com>

Thanks for the review!

-Aleksey.

On 05/20/2013 04:35 PM, Staffan Larsen wrote:
> Changeset looks good.
> 
> /Staffan
> 
> On 20 maj 2013, at 13:46, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
> 
>> On 05/20/2013 03:16 PM, Aleksey Shipilev wrote:
>>> That was "hg mv". Does it display properly in webrev? Should I use
>>> something else? Alternatively, I can generate the changeset which
>>> actually moves the file.
>>
>> Nevermind, here's the changeset:
>> http://cr.openjdk.java.net/~shade/8014871/8014871.01.changeset
>>
>> Please review, and we can then either fix something in the changeset, or
>> just populate "Reviewed-by:" and get done with it.
>>
>> -Aleksey.
>>
>>
> 


From aleksey.shipilev at oracle.com  Mon May 20 05:50:31 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Mon, 20 May 2013 16:50:31 +0400
Subject: RFR (XS) CR 8014871: Move @Contended regression tests to the
	same place
In-Reply-To: <519A1925.8000805@oracle.com>
References: <5199EA4B.9000700@oracle.com>
	<9763716F-2BC8-4907-8102-03380E86F9F0@oracle.com>
	<519A0626.2020107@oracle.com> <519A0D29.2050800@oracle.com>
	<519A179A.9010705@oracle.com> <519A1925.8000805@oracle.com>
Message-ID: <519A1C17.3050808@oracle.com>

On 05/20/2013 04:37 PM, Aleksey Shipilev wrote:
> On 05/20/2013 04:31 PM, David Holmes wrote:
>>> Nevermind, here's the changeset:
>>>   http://cr.openjdk.java.net/~shade/8014871/8014871.01.changeset
>> Reviewed and sponsored.
> 
> Thanks! Please make sure "Reviewed-by:" is correct.

Yet again, nevermind, here's the changeset with updated Reviewed-by:
 http://cr.openjdk.java.net/~shade/8014871/8014871.02.changeset

-Aleksey.

From erik.helin at oracle.com  Mon May 20 06:56:32 2013
From: erik.helin at oracle.com (erik.helin at oracle.com)
Date: Mon, 20 May 2013 13:56:32 +0000
Subject: hg: hsx/hsx24/hotspot: 2 new changesets
Message-ID: <20130520135639.B43E048BB8@hg.openjdk.java.net>

Changeset: c78ea7137c06
Author:    ehelin
Date:      2013-05-17 15:28 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/c78ea7137c06

8011891: The vm/gc/heap/heap_summary_after_gc event for CMS contains old data
Reviewed-by: brutisso, stefank

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp

Changeset: 3e38b7096830
Author:    ehelin
Date:      2013-05-20 14:18 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/3e38b7096830

Merge

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp


From aleksey.shipilev at oracle.com  Mon May 20 08:57:14 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Mon, 20 May 2013 19:57:14 +0400
Subject: RFR (S) CR 8014878: Clean up class field layout code
Message-ID: <519A47DA.60002@oracle.com>

Hi,

This is the cleanup I promised to do for the CL code.

The first batch is here:
  http://cr.openjdk.java.net/~shade/8014878/webrev.01/

I would like to do this in incremental steps to ease the bisecting
should it bring any regressions. If you think something else needs the
refactoring, speak up, I'll add this to running tally of things to clean
up in the next patch.

Testing:
  - test/runtime/contended regression tests
  - full JPRT cycle vs hotspot-rt

Please review!

-Aleksey.

From aleksey.shipilev at oracle.com  Mon May 20 09:11:37 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Mon, 20 May 2013 20:11:37 +0400
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
Message-ID: <519A4B39.20208@oracle.com>

Hi again,

This is a simple, but potentially disruptive issue found during the code
review. We messed up calculating the oop maps with @Contended classes,
and so we can corrupt something adjacent.

The fix is here:
  http://cr.openjdk.java.net/~shade/8014886/webrev.01/

The issue is about nonstatic_oop_count counting only non- at Contended
fields. The fix is pretty straight-forward, although entire *_count
handling requires more refactoring, which is to be handled elsewhere,
during the class field layout cleanup.

I also put a few asserts as the range-checks, and those asserts are
failing when the max_oop_maps are calculated as before.

Testing:
  - new regression test added, fails on new asserts
  - Linux x86_64/fastdebug runtime/contended/ tests
  - full JPRT cycle against hotspot-rt

Please review!

-Aleksey.


From vladimir.kozlov at oracle.com  Mon May 20 09:29:06 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Mon, 20 May 2013 09:29:06 -0700
Subject: RFR (S) CR 8014878: Clean up class field layout code
In-Reply-To: <519A47DA.60002@oracle.com>
References: <519A47DA.60002@oracle.com>
Message-ID: <519A4F52.8080907@oracle.com>

Looks good.

Could you fix indentions in lines 3176 (move 1 space left), 3572 (move 1 
space right)?

Thanks,
Vladimir

PS: Aleksey, I am stating process to make you Hotspot Committer (HSX 
Author first) because you have already 9 changesets in our sources:

http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=aleksey.shipilev%40oracle.com
http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/571076d3c79d


On 5/20/13 8:57 AM, Aleksey Shipilev wrote:
> Hi,
>
> This is the cleanup I promised to do for the CL code.
>
> The first batch is here:
>    http://cr.openjdk.java.net/~shade/8014878/webrev.01/
>
> I would like to do this in incremental steps to ease the bisecting
> should it bring any regressions. If you think something else needs the
> refactoring, speak up, I'll add this to running tally of things to clean
> up in the next patch.
>
> Testing:
>    - test/runtime/contended regression tests
>    - full JPRT cycle vs hotspot-rt
>
> Please review!
>
> -Aleksey.
>

From erik.helin at oracle.com  Mon May 20 10:27:58 2013
From: erik.helin at oracle.com (erik.helin at oracle.com)
Date: Mon, 20 May 2013 17:27:58 +0000
Subject: hg: hsx/hsx24/hotspot: 8013934: Garbage collection event for CMS has
	wrong cause for System.gc()
Message-ID: <20130520172802.5B94148BC4@hg.openjdk.java.net>

Changeset: 244e30c23098
Author:    ehelin
Date:      2013-05-20 16:49 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/244e30c23098

8013934: Garbage collection event for CMS has wrong cause for System.gc()
Reviewed-by: brutisso, jwilhelm

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp


From aleksey.shipilev at oracle.com  Mon May 20 10:33:41 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Mon, 20 May 2013 21:33:41 +0400
Subject: RFR (S) CR 8014878: Clean up class field layout code
In-Reply-To: <519A4F52.8080907@oracle.com>
References: <519A47DA.60002@oracle.com> <519A4F52.8080907@oracle.com>
Message-ID: <519A5E75.5030102@oracle.com>

On 05/20/2013 08:29 PM, Vladimir Kozlov wrote:
> Looks good.

Thanks for the review!

> Could you fix indentions in lines 3176 (move 1 space left), 3572 (move 1
> space right)?

Done:
 http://cr.openjdk.java.net/~shade/8014878/webrev.02/

We still need a second reviewer, right?
Coleen, I bet you are anxious to see that method being refactored.

> PS: Aleksey, I am stating process to make you Hotspot Committer (HSX
> Author first) because you have already 9 changesets in our sources:

Awesome, thanks.

-Aleksey.

From coleen.phillimore at oracle.com  Mon May 20 11:31:51 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Mon, 20 May 2013 14:31:51 -0400
Subject: RFR (S) CR 8014878: Clean up class field layout code
In-Reply-To: <519A5E75.5030102@oracle.com>
References: <519A47DA.60002@oracle.com> <519A4F52.8080907@oracle.com>
	<519A5E75.5030102@oracle.com>
Message-ID: <519A6C17.7040102@oracle.com>


On 05/20/2013 01:33 PM, Aleksey Shipilev wrote:
> On 05/20/2013 08:29 PM, Vladimir Kozlov wrote:
>> Looks good.
> Thanks for the review!
>
>> Could you fix indentions in lines 3176 (move 1 space left), 3572 (move 1
>> space right)?
> Done:
>   http://cr.openjdk.java.net/~shade/8014878/webrev.02/
>
> We still need a second reviewer, right?
> Coleen, I bet you are anxious to see that method being refactored.

This looks good and helpful.
Thanks,
Coleen

>
>> PS: Aleksey, I am stating process to make you Hotspot Committer (HSX
>> Author first) because you have already 9 changesets in our sources:
> Awesome, thanks.
>
> -Aleksey.


From joseph.provino at oracle.com  Mon May 20 12:10:18 2013
From: joseph.provino at oracle.com (JOSEPH PROVINO)
Date: Mon, 20 May 2013 15:10:18 -0400
Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace
	in libjvm.symbols that does not exist in minimal/libjvm.a when
	DEBUG_LEVEL == release
Message-ID: <519A751A.5090604@oracle.com>

The change is to include forte.cpp in the minimal jvm but to 
conditionalize the code so that
only AsyncGetCallTrace() is defined with the minimal jvm.

Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/

  * JDK-8013461 <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
    a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in
    minimal/libjvm.a when DEBUG_LEVEL == release
    <https://jbs.oracle.com/bugs/browse/JDK-8013461>

Thanks.

joe



From joseph.provino at oracle.com  Mon May 20 12:26:44 2013
From: joseph.provino at oracle.com (JOSEPH PROVINO)
Date: Mon, 20 May 2013 15:26:44 -0400
Subject: review request --  JDK-801106 Some tests have failed with SIGSEGV
	on arm-hflt on build b82
Message-ID: <519A78F4.4010909@oracle.com>

Make it easy to disable NMT detail in platform specific code.

A new variable NMT_detail_supported is defined and set to true.
It can be disabled in platform specific code as needed.

Webrev is here: http://cr.openjdk.java.net/~jprovino/8011064/webrev/

JDK-8011064 <https://jbs.oracle.com/bugs/browse/JDK-8011064>Some tests 
have failed with SIGSEGV on arm-hflt on build b82 
<https://jbs.oracle.com/bugs/browse/JDK-8011064>

From aleksey.shipilev at oracle.com  Mon May 20 12:46:30 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Mon, 20 May 2013 23:46:30 +0400
Subject: RFR (S) CR 8014878: Clean up class field layout code
In-Reply-To: <519A6C17.7040102@oracle.com>
References: <519A47DA.60002@oracle.com> <519A4F52.8080907@oracle.com>
	<519A5E75.5030102@oracle.com> <519A6C17.7040102@oracle.com>
Message-ID: <519A7D96.40107@oracle.com>

On 05/20/2013 10:31 PM, Coleen Phillimore wrote:
> 
> On 05/20/2013 01:33 PM, Aleksey Shipilev wrote:
>> On 05/20/2013 08:29 PM, Vladimir Kozlov wrote:
>>> Looks good.
>> Thanks for the review!
>>
>>> Could you fix indentions in lines 3176 (move 1 space left), 3572 (move 1
>>> space right)?
>> Done:
>>   http://cr.openjdk.java.net/~shade/8014878/webrev.02/
>>
>> We still need a second reviewer, right?
>> Coleen, I bet you are anxious to see that method being refactored.
> 
> This looks good and helpful.

Thanks for the review!

The changeset is here:
  http://cr.openjdk.java.net/~shade/8014878/8014878.01.changeset

Please sponsor :)

-Aleksey.


From serguei.spitsyn at oracle.com  Mon May 20 12:51:16 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Mon, 20 May 2013 12:51:16 -0700
Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace
	in libjvm.symbols that does not exist in minimal/libjvm.a when
	DEBUG_LEVEL == release
In-Reply-To: <519A751A.5090604@oracle.com>
References: <519A751A.5090604@oracle.com>
Message-ID: <519A7EB4.5070901@oracle.com>

Hi Joe,

src/share/vm/prims/forte.cpp


These are new lines added unconditionally:

   38 // call frame copied from old .h file and renamed
   39 typedef struct {
   40     jint lineno;                      // line number in the source file
   41     jmethodID method_id;              // method executed in this frame
   42 } ASGCT_CallFrame;
   43
   44 // call trace copied from old .h file and renamed
   45 typedef struct {
   46     JNIEnv *env_id;                   // Env where trace was recorded
   47     jint num_frames;                  // number of frames in this trace
   48     ASGCT_CallFrame *frames;          // frames
   49 } ASGCT_CallTrace;
   50


Should the following lines (under #if INCLUDE_JVMTI) be removed ? :

  379 // call frame copied from old .h file and renamed
  380 typedef struct {
  381     jint lineno;                      // line number in the source file
  382     jmethodID method_id;              // method executed in this frame
  383 } ASGCT_CallFrame;
  384
  385 // call trace copied from old .h file and renamed
  386 typedef struct {
  387     JNIEnv *env_id;                   // Env where trace was recorded
  388     jint num_frames;                  // number of frames in this trace
  389     ASGCT_CallFrame *frames;          // frames
  390 } ASGCT_CallTrace;
  391

Did you build the fix for non-minimal VM configuration?

Other than that the fix looks good.
It'd be nice if Dan reviewed it too.


Thanks,
Serguei


On 5/20/13 12:10 PM, JOSEPH PROVINO wrote:
> The change is to include forte.cpp in the minimal jvm but to 
> conditionalize the code so that
> only AsyncGetCallTrace() is defined with the minimal jvm.
>
> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>
>  * JDK-8013461 <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>    a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in
>    minimal/libjvm.a when DEBUG_LEVEL == release
>    <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>
> Thanks.
>
> joe
>
>


From zhengyu.gu at oracle.com  Mon May 20 13:06:37 2013
From: zhengyu.gu at oracle.com (Zhengyu Gu)
Date: Mon, 20 May 2013 16:06:37 -0400
Subject: review request -- JDK-801106 Some tests have failed with SIGSEGV
	on arm-hflt on build b82
In-Reply-To: <519A78F4.4010909@oracle.com>
References: <519A78F4.4010909@oracle.com>
Message-ID: <56CAA8A3-800D-409E-B153-0339AEBE44E4@oracle.com>

Look good to me.

-Zhengyu

On May 20, 2013, at 3:26 PM, JOSEPH PROVINO wrote:

> Make it easy to disable NMT detail in platform specific code.
> 
> A new variable NMT_detail_supported is defined and set to true.
> It can be disabled in platform specific code as needed.
> 
> Webrev is here: http://cr.openjdk.java.net/~jprovino/8011064/webrev/
> 
> JDK-8011064 <https://jbs.oracle.com/bugs/browse/JDK-8011064>Some tests have failed with SIGSEGV on arm-hflt on build b82 <https://jbs.oracle.com/bugs/browse/JDK-8011064>


From bill.pittore at oracle.com  Mon May 20 15:02:03 2013
From: bill.pittore at oracle.com (BILL PITTORE)
Date: Mon, 20 May 2013 18:02:03 -0400
Subject: review request -- JDK-801106 Some tests have failed with SIGSEGV
	on arm-hflt on build b82
In-Reply-To: <519A78F4.4010909@oracle.com>
References: <519A78F4.4010909@oracle.com>
Message-ID: <519A9D5B.7060705@oracle.com>

  Maybe something like I did for SUPPORTS_NATIVE_CX8. This gets defined 
in globalDefinitions_<cpu>.hpp.
In this situation maybe something like:

memTracker.cpp
   bool NMT_detail_supported = PLATFORM_NMT_DETAIL_SUPPORTED;

then in globalDefinitions_<cpu>.hpp

#define PLATFORM_NMT_DETAIL_SUPPORTED {true | false} as the case may be.

Then you eliminate the need to add code to pd_initialize()

bill

On 5/20/2013 3:26 PM, JOSEPH PROVINO wrote:
> Make it easy to disable NMT detail in platform specific code.
>
> A new variable NMT_detail_supported is defined and set to true.
> It can be disabled in platform specific code as needed.
>
> Webrev is here: http://cr.openjdk.java.net/~jprovino/8011064/webrev/
>
> JDK-8011064 <https://jbs.oracle.com/bugs/browse/JDK-8011064>Some tests 
> have failed with SIGSEGV on arm-hflt on build b82 
> <https://jbs.oracle.com/bugs/browse/JDK-8011064>



From dmitry.samersoff at oracle.com  Mon May 20 15:40:37 2013
From: dmitry.samersoff at oracle.com (Dmitry Samersoff)
Date: Tue, 21 May 2013 02:40:37 +0400
Subject: review request -- JDK-801106 Some tests have failed with SIGSEGV
	on arm-hflt on build b82
In-Reply-To: <519A78F4.4010909@oracle.com>
References: <519A78F4.4010909@oracle.com>
Message-ID: <519AA665.5080809@oracle.com>

Joseph,

Does it make sense to use #ifdef directly instead of
introducing a new variable with someone responsibility to set it to
proper value?

-Dmitry

On 2013-05-20 23:26, JOSEPH PROVINO wrote:
> Make it easy to disable NMT detail in platform specific code.
> 
> A new variable NMT_detail_supported is defined and set to true.
> It can be disabled in platform specific code as needed.
> 
> Webrev is here: http://cr.openjdk.java.net/~jprovino/8011064/webrev/
> 
> JDK-8011064 <https://jbs.oracle.com/bugs/browse/JDK-8011064>Some tests
> have failed with SIGSEGV on arm-hflt on build b82
> <https://jbs.oracle.com/bugs/browse/JDK-8011064>


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.

From vladimir.kozlov at oracle.com  Mon May 20 16:30:24 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Mon, 20 May 2013 16:30:24 -0700
Subject: CFV: New HSX Committer: Aleksey Shipilev
In-Reply-To: <5111D374.2090101@oracle.com>
References: <5111D374.2090101@oracle.com>
Message-ID: <519AB210.1070901@oracle.com>

I hereby nominate Aleksey Shipilev (OpenJDK user name: shade) to
HSX Committer.

Aleksey is a member of the Hotspot Performance group. He is working on 
java concurrency related projects. He contributed 11 changesets to HSX 
project and he is qualified to be committer [1]:

http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=shipilev
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/571076d3c79d
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/205dd30230e1
http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/50e9396d5257

Votes are due by June 3, 2013.

Only current HSX Committers [2] are eligible to vote on this nomination.
Votes must be cast in the open by replying to this mailing list.

For Lazy Consensus voting instructions, see [3].

Thanks,
Vladimir Kozlov

[1] http://openjdk.java.net/projects/#project-committer
[2] http://openjdk.java.net/census#hsx
[3] http://openjdk.java.net/projects#committer-vote







From joseph.provino at oracle.com  Mon May 20 18:34:57 2013
From: joseph.provino at oracle.com (Joseph Provino)
Date: Mon, 20 May 2013 21:34:57 -0400
Subject: review request -- JDK-801106 Some tests have failed with SIGSEGV
	on arm-hflt on build b82
In-Reply-To: <519A9D5B.7060705@oracle.com>
References: <519A78F4.4010909@oracle.com> <519A9D5B.7060705@oracle.com>
Message-ID: <519ACF41.7080709@oracle.com>

That sounds like a much better way to do it!

thanks.

joe

On 05/20/2013 06:02 PM, BILL PITTORE wrote:
>  Maybe something like I did for SUPPORTS_NATIVE_CX8. This gets defined 
> in globalDefinitions_<cpu>.hpp.
> In this situation maybe something like:
>
> memTracker.cpp
>   bool NMT_detail_supported = PLATFORM_NMT_DETAIL_SUPPORTED;
>
> then in globalDefinitions_<cpu>.hpp
>
> #define PLATFORM_NMT_DETAIL_SUPPORTED {true | false} as the case may be.
>
> Then you eliminate the need to add code to pd_initialize()
>
> bill
>
> On 5/20/2013 3:26 PM, JOSEPH PROVINO wrote:
>> Make it easy to disable NMT detail in platform specific code.
>>
>> A new variable NMT_detail_supported is defined and set to true.
>> It can be disabled in platform specific code as needed.
>>
>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8011064/webrev/
>>
>> JDK-8011064 <https://jbs.oracle.com/bugs/browse/JDK-8011064>Some 
>> tests have failed with SIGSEGV on arm-hflt on build b82 
>> <https://jbs.oracle.com/bugs/browse/JDK-8011064>
>
>


From vladimir.kozlov at oracle.com  Mon May 20 19:03:47 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Mon, 20 May 2013 19:03:47 -0700
Subject: RFR (S) CR 8014878: Clean up class field layout code
In-Reply-To: <519A7D96.40107@oracle.com>
References: <519A47DA.60002@oracle.com> <519A4F52.8080907@oracle.com>
	<519A5E75.5030102@oracle.com> <519A6C17.7040102@oracle.com>
	<519A7D96.40107@oracle.com>
Message-ID: <519AD603.4000106@oracle.com>

The job in JPRT queue.

Vladimir

On 5/20/13 12:46 PM, Aleksey Shipilev wrote:
> On 05/20/2013 10:31 PM, Coleen Phillimore wrote:
>>
>> On 05/20/2013 01:33 PM, Aleksey Shipilev wrote:
>>> On 05/20/2013 08:29 PM, Vladimir Kozlov wrote:
>>>> Looks good.
>>> Thanks for the review!
>>>
>>>> Could you fix indentions in lines 3176 (move 1 space left), 3572 (move 1
>>>> space right)?
>>> Done:
>>>    http://cr.openjdk.java.net/~shade/8014878/webrev.02/
>>>
>>> We still need a second reviewer, right?
>>> Coleen, I bet you are anxious to see that method being refactored.
>>
>> This looks good and helpful.
>
> Thanks for the review!
>
> The changeset is here:
>    http://cr.openjdk.java.net/~shade/8014878/8014878.01.changeset
>
> Please sponsor :)
>
> -Aleksey.
>

From david.holmes at oracle.com  Mon May 20 19:26:54 2013
From: david.holmes at oracle.com (David Holmes)
Date: Tue, 21 May 2013 12:26:54 +1000
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
In-Reply-To: <519A4B39.20208@oracle.com>
References: <519A4B39.20208@oracle.com>
Message-ID: <519ADB6E.1010400@oracle.com>

Hi Aleksey,

What value does max_oop_maps get? And how does that compare to the old 
value of "nonstatic_oop_count + 1"? I'm just trying to get a sense of 
how much additional space we are now using here.

Thanks,
David

On 21/05/2013 2:11 AM, Aleksey Shipilev wrote:
> Hi again,
>
> This is a simple, but potentially disruptive issue found during the code
> review. We messed up calculating the oop maps with @Contended classes,
> and so we can corrupt something adjacent.
>
> The fix is here:
>    http://cr.openjdk.java.net/~shade/8014886/webrev.01/
>
> The issue is about nonstatic_oop_count counting only non- at Contended
> fields. The fix is pretty straight-forward, although entire *_count
> handling requires more refactoring, which is to be handled elsewhere,
> during the class field layout cleanup.
>
> I also put a few asserts as the range-checks, and those asserts are
> failing when the max_oop_maps are calculated as before.
>
> Testing:
>    - new regression test added, fails on new asserts
>    - Linux x86_64/fastdebug runtime/contended/ tests
>    - full JPRT cycle against hotspot-rt
>
> Please review!
>
> -Aleksey.
>

From david.holmes at oracle.com  Mon May 20 19:34:43 2013
From: david.holmes at oracle.com (David Holmes)
Date: Tue, 21 May 2013 12:34:43 +1000
Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace
	in libjvm.symbols that does not exist in minimal/libjvm.a when
	DEBUG_LEVEL == release
In-Reply-To: <519A751A.5090604@oracle.com>
References: <519A751A.5090604@oracle.com>
Message-ID: <519ADD43.1030601@oracle.com>

<added servicability>

Hi Joe,

As I have previously stated you copied the struct definitions instead of 
moving them outside the ifdef.

Serviceability folk: we are particularly interested in whether the use 
of ticks_no_class_load is deemed appropriate in this situation. Who will 
be consuming this value?

Thanks,
David

On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
> The change is to include forte.cpp in the minimal jvm but to
> conditionalize the code so that
> only AsyncGetCallTrace() is defined with the minimal jvm.
>
> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>
>   * JDK-8013461 <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>     a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in
>     minimal/libjvm.a when DEBUG_LEVEL == release
>     <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>
> Thanks.
>
> joe
>
>

From coleen.phillimore at oracle.com  Mon May 20 19:45:15 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Mon, 20 May 2013 22:45:15 -0400
Subject: CFV: New HSX Committer: Aleksey Shipilev
In-Reply-To: <519AB210.1070901@oracle.com>
References: <5111D374.2090101@oracle.com> <519AB210.1070901@oracle.com>
Message-ID: <519ADFBB.9010107@oracle.com>

Vote: yes

On 5/20/2013 7:30 PM, Vladimir Kozlov wrote:
> I hereby nominate Aleksey Shipilev (OpenJDK user name: shade) to
> HSX Committer.
>
> Aleksey is a member of the Hotspot Performance group. He is working on 
> java concurrency related projects. He contributed 11 changesets to HSX 
> project and he is qualified to be committer [1]:
>
> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=shipilev
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/571076d3c79d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/205dd30230e1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/50e9396d5257
>
> Votes are due by June 3, 2013.
>
> Only current HSX Committers [2] are eligible to vote on this nomination.
> Votes must be cast in the open by replying to this mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> Thanks,
> Vladimir Kozlov
>
> [1] http://openjdk.java.net/projects/#project-committer
> [2] http://openjdk.java.net/census#hsx
> [3] http://openjdk.java.net/projects#committer-vote
>
>
>
>
>
>


From vladimir.kozlov at oracle.com  Mon May 20 20:58:12 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Mon, 20 May 2013 20:58:12 -0700
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
In-Reply-To: <519A4B39.20208@oracle.com>
References: <519A4B39.20208@oracle.com>
Message-ID: <519AF0D4.4080102@oracle.com>

Aleksey,

Is not has_nonstatic_fields also wrong?

Rename: max_oop_maps -> max_nonstatic_oop_maps.

For FieldsAllocationStyle=2 (default) we do special oop fields layout 
for super and subclass to have only one oopmap. You need to add non-oop 
fields (class in your test has only oop fields) to test different layouts.

Next added mess to already complicated code:

3188   unsigned int nonstatic_double_count = 
fac->count[NONSTATIC_DOUBLE] - fac_contended.count[NONSTATIC_DOUBLE];
3189   unsigned int nonstatic_word_count   = fac->count[NONSTATIC_WORD] 
   - fac_contended.count[NONSTATIC_WORD];
3190   unsigned int nonstatic_short_count  = fac->count[NONSTATIC_SHORT] 
  - fac_contended.count[NONSTATIC_SHORT];
3191   unsigned int nonstatic_byte_count   = fac->count[NONSTATIC_BYTE] 
   - fac_contended.count[NONSTATIC_BYTE];
3192   unsigned int nonstatic_oop_count    = fac->count[NONSTATIC_OOP] 
   - fac_contended.count[NONSTATIC_OOP];


At least add comment that these counts are for not contended fields.

Vladimir

On 5/20/13 9:11 AM, Aleksey Shipilev wrote:
> Hi again,
>
> This is a simple, but potentially disruptive issue found during the code
> review. We messed up calculating the oop maps with @Contended classes,
> and so we can corrupt something adjacent.
>
> The fix is here:
>    http://cr.openjdk.java.net/~shade/8014886/webrev.01/
>
> The issue is about nonstatic_oop_count counting only non- at Contended
> fields. The fix is pretty straight-forward, although entire *_count
> handling requires more refactoring, which is to be handled elsewhere,
> during the class field layout cleanup.
>
> I also put a few asserts as the range-checks, and those asserts are
> failing when the max_oop_maps are calculated as before.
>
> Testing:
>    - new regression test added, fails on new asserts
>    - Linux x86_64/fastdebug runtime/contended/ tests
>    - full JPRT cycle against hotspot-rt
>
> Please review!
>
> -Aleksey.
>

From vladimir.kozlov at oracle.com  Mon May 20 21:17:51 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Mon, 20 May 2013 21:17:51 -0700
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
In-Reply-To: <519ADB6E.1010400@oracle.com>
References: <519A4B39.20208@oracle.com> <519ADB6E.1010400@oracle.com>
Message-ID: <519AF56F.6020101@oracle.com>

On 5/20/13 7:26 PM, David Holmes wrote:
> Hi Aleksey,
>
> What value does max_oop_maps get? And how does that compare to the old

max_oop_maps = fac->count[NONSTATIC_OOP] is the same as before 
@Contended changes were added. Aleksey restored original correct value.

> value of "nonstatic_oop_count + 1"? I'm just trying to get a sense of

I don't remember why I had (nonstatic_oop_count + 1) in my original 
changes from few years ago. May be because resource allocation code 
complained about size == 0 (when nonstatic_oop_count == 0). Or when we 
allocate with UseMallocOnly.

> how much additional space we are now using here.

2 thread resource array are temporary. Only used elements in these 
arrays are copied into class data based on nonstatic_oop_map_count 
(methods nonstatic_oop_map_count() and fill_oop_maps()).

Note, current code allocates oopmap per contended oop fields even fields 
in one group (not separated by padding).

Vladimir

>
> Thanks,
> David
>
> On 21/05/2013 2:11 AM, Aleksey Shipilev wrote:
>> Hi again,
>>
>> This is a simple, but potentially disruptive issue found during the code
>> review. We messed up calculating the oop maps with @Contended classes,
>> and so we can corrupt something adjacent.
>>
>> The fix is here:
>>    http://cr.openjdk.java.net/~shade/8014886/webrev.01/
>>
>> The issue is about nonstatic_oop_count counting only non- at Contended
>> fields. The fix is pretty straight-forward, although entire *_count
>> handling requires more refactoring, which is to be handled elsewhere,
>> during the class field layout cleanup.
>>
>> I also put a few asserts as the range-checks, and those asserts are
>> failing when the max_oop_maps are calculated as before.
>>
>> Testing:
>>    - new regression test added, fails on new asserts
>>    - Linux x86_64/fastdebug runtime/contended/ tests
>>    - full JPRT cycle against hotspot-rt
>>
>> Please review!
>>
>> -Aleksey.
>>

From alejandro.murillo at oracle.com  Mon May 20 21:55:43 2013
From: alejandro.murillo at oracle.com (Alejandro E Murillo)
Date: Mon, 20 May 2013 22:55:43 -0600
Subject: Code review request CR 8014941: make jdk7u40 the default jprt release
	for hs24
Message-ID: <519AFE4F.4020705@oracle.com>


Can someone please review this small change to make jdk7u40 the default 
jprt release for hs24

http://cr.openjdk.java.net/~amurillo/webrevs/8014941/

8014941 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014941

Thanks

-- 
Alejandro


From alejandro.murillo at oracle.com  Mon May 20 21:58:02 2013
From: alejandro.murillo at oracle.com (Alejandro E Murillo)
Date: Mon, 20 May 2013 22:58:02 -0600
Subject: CFV: New HSX Committer: Aleksey Shipilev
In-Reply-To: <519AB210.1070901@oracle.com>
References: <5111D374.2090101@oracle.com> <519AB210.1070901@oracle.com>
Message-ID: <519AFEDA.5080401@oracle.com>


vote: yes
Alejandro

On 5/20/2013 5:30 PM, Vladimir Kozlov wrote:
> I hereby nominate Aleksey Shipilev (OpenJDK user name: shade) to
> HSX Committer.

From david.holmes at oracle.com  Mon May 20 22:13:59 2013
From: david.holmes at oracle.com (David Holmes)
Date: Tue, 21 May 2013 15:13:59 +1000
Subject: Code review request CR 8014941: make jdk7u40 the default jprt
	release for hs24
In-Reply-To: <519AFE4F.4020705@oracle.com>
References: <519AFE4F.4020705@oracle.com>
Message-ID: <519B0297.6090608@oracle.com>

Looks good to me. (I tested this myself yesterday :) )

David
-----

On 21/05/2013 2:55 PM, Alejandro E Murillo wrote:
>
> Can someone please review this small change to make jdk7u40 the default
> jprt release for hs24
>
> http://cr.openjdk.java.net/~amurillo/webrevs/8014941/
>
> 8014941 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014941
>
> Thanks
>

From gary.collins at oracle.com  Mon May 20 22:19:50 2013
From: gary.collins at oracle.com (Gary Collins)
Date: Mon, 20 May 2013 22:19:50 -0700
Subject: Code review request CR 8014941: make jdk7u40 the default jprt
	release for hs24
In-Reply-To: <519AFE4F.4020705@oracle.com>
References: <519AFE4F.4020705@oracle.com>
Message-ID: <7AFC84FB-7483-4A5B-AC78-010F4AF44FD3@oracle.com>

Looks good to me.

Gary
On May 20, 2013, at 9:55 PM, Alejandro E Murillo wrote:

> 
> Can someone please review this small change to make jdk7u40 the default jprt release for hs24
> 
> http://cr.openjdk.java.net/~amurillo/webrevs/8014941/
> 
> 8014941 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014941
> 
> Thanks
> 
> -- 
> Alejandro
> 


From aleksey.shipilev at oracle.com  Mon May 20 22:19:56 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Tue, 21 May 2013 09:19:56 +0400
Subject: RFR (S) CR 8014878: Clean up class field layout code
In-Reply-To: <519AD603.4000106@oracle.com>
References: <519A47DA.60002@oracle.com> <519A4F52.8080907@oracle.com>
	<519A5E75.5030102@oracle.com> <519A6C17.7040102@oracle.com>
	<519A7D96.40107@oracle.com> <519AD603.4000106@oracle.com>
Message-ID: <519B03FC.5080201@oracle.com>

Thanks!

-Aleksey.

On 05/21/2013 06:03 AM, Vladimir Kozlov wrote:
> The job in JPRT queue.
> 
> Vladimir
> 
> On 5/20/13 12:46 PM, Aleksey Shipilev wrote:
>> On 05/20/2013 10:31 PM, Coleen Phillimore wrote:
>>>
>>> On 05/20/2013 01:33 PM, Aleksey Shipilev wrote:
>>>> On 05/20/2013 08:29 PM, Vladimir Kozlov wrote:
>>>>> Looks good.
>>>> Thanks for the review!
>>>>
>>>>> Could you fix indentions in lines 3176 (move 1 space left), 3572
>>>>> (move 1
>>>>> space right)?
>>>> Done:
>>>>    http://cr.openjdk.java.net/~shade/8014878/webrev.02/
>>>>
>>>> We still need a second reviewer, right?
>>>> Coleen, I bet you are anxious to see that method being refactored.
>>>
>>> This looks good and helpful.
>>
>> Thanks for the review!
>>
>> The changeset is here:
>>    http://cr.openjdk.java.net/~shade/8014878/8014878.01.changeset
>>
>> Please sponsor :)
>>
>> -Aleksey.
>>


From bengt.rutisson at oracle.com  Mon May 20 22:27:22 2013
From: bengt.rutisson at oracle.com (Bengt Rutisson)
Date: Tue, 21 May 2013 07:27:22 +0200
Subject: CFV: New HSX Committer: Aleksey Shipilev
In-Reply-To: <519AB210.1070901@oracle.com>
References: <5111D374.2090101@oracle.com> <519AB210.1070901@oracle.com>
Message-ID: <519B05BA.7060203@oracle.com>


Vote: yes

Bengt


On 5/21/13 1:30 AM, Vladimir Kozlov wrote:
> I hereby nominate Aleksey Shipilev (OpenJDK user name: shade) to
> HSX Committer.
>
> Aleksey is a member of the Hotspot Performance group. He is working on 
> java concurrency related projects. He contributed 11 changesets to HSX 
> project and he is qualified to be committer [1]:
>
> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=shipilev
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/571076d3c79d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/205dd30230e1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/50e9396d5257
>
> Votes are due by June 3, 2013.
>
> Only current HSX Committers [2] are eligible to vote on this nomination.
> Votes must be cast in the open by replying to this mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> Thanks,
> Vladimir Kozlov
>
> [1] http://openjdk.java.net/projects/#project-committer
> [2] http://openjdk.java.net/census#hsx
> [3] http://openjdk.java.net/projects#committer-vote
>
>
>
>
>
>


From alejandro.murillo at oracle.com  Mon May 20 23:08:56 2013
From: alejandro.murillo at oracle.com (Alejandro E Murillo)
Date: Tue, 21 May 2013 00:08:56 -0600
Subject: Code review request CR 8014941: make jdk7u40 the default jprt
	release for hs24
In-Reply-To: <7AFC84FB-7483-4A5B-AC78-010F4AF44FD3@oracle.com>
References: <519AFE4F.4020705@oracle.com>
	<7AFC84FB-7483-4A5B-AC78-010F4AF44FD3@oracle.com>
Message-ID: <519B0F78.3020000@oracle.com>


Thanks guys, will push this right now
Alejandro

On 5/20/2013 11:19 PM, Gary Collins wrote:
> Looks good to me.
>
> Gary
> On May 20, 2013, at 9:55 PM, Alejandro E Murillo wrote:
>
>> Can someone please review this small change to make jdk7u40 the default jprt release for hs24
>>
>> http://cr.openjdk.java.net/~amurillo/webrevs/8014941/
>>
>> 8014941 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014941
>>
>> Thanks
>>
>> -- 
>> Alejandro
>>


From staffan.larsen at oracle.com  Mon May 20 23:49:17 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Tue, 21 May 2013 08:49:17 +0200
Subject: review request for JDK-8013461 There is a symbol
	AsyncGetCallTrace in libjvm.symbols that does not exist in
	minimal/libjvm.a when DEBUG_LEVEL == release
In-Reply-To: <519ADD43.1030601@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
Message-ID: <D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>


On 21 maj 2013, at 04:34, David Holmes <David.Holmes at oracle.com> wrote:

> <added servicability>
> 
> Hi Joe,
> 
> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef.
> 
> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value?

Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report), I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error.

As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler, and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented.

/Staffan

> 
> Thanks,
> David
> 
> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>> The change is to include forte.cpp in the minimal jvm but to
>> conditionalize the code so that
>> only AsyncGetCallTrace() is defined with the minimal jvm.
>> 
>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>> 
>>  * JDK-8013461 <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>    a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in
>>    minimal/libjvm.a when DEBUG_LEVEL == release
>>    <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>> 
>> Thanks.
>> 
>> joe
>> 
>> 


From staffan.larsen at oracle.com  Mon May 20 23:49:49 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Tue, 21 May 2013 08:49:49 +0200
Subject: CFV: New HSX Committer: Aleksey Shipilev
In-Reply-To: <519AB210.1070901@oracle.com>
References: <5111D374.2090101@oracle.com> <519AB210.1070901@oracle.com>
Message-ID: <0FEED54E-2575-4F23-BBBA-DDB2F64A6783@oracle.com>

Vote: yes

/Staffan

On 21 maj 2013, at 01:30, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

> I hereby nominate Aleksey Shipilev (OpenJDK user name: shade) to
> HSX Committer.
> 
> Aleksey is a member of the Hotspot Performance group. He is working on java concurrency related projects. He contributed 11 changesets to HSX project and he is qualified to be committer [1]:
> 
> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=shipilev
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/571076d3c79d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/205dd30230e1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/50e9396d5257
> 
> Votes are due by June 3, 2013.
> 
> Only current HSX Committers [2] are eligible to vote on this nomination.
> Votes must be cast in the open by replying to this mailing list.
> 
> For Lazy Consensus voting instructions, see [3].
> 
> Thanks,
> Vladimir Kozlov
> 
> [1] http://openjdk.java.net/projects/#project-committer
> [2] http://openjdk.java.net/census#hsx
> [3] http://openjdk.java.net/projects#committer-vote
> 
> 
> 
> 
> 
> 


From david.holmes at oracle.com  Tue May 21 00:06:06 2013
From: david.holmes at oracle.com (David Holmes)
Date: Tue, 21 May 2013 17:06:06 +1000
Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace
	in libjvm.symbols that does not exist in minimal/libjvm.a when
	DEBUG_LEVEL == release
In-Reply-To: <D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
Message-ID: <519B1CDE.4090507@oracle.com>

Hi Staffan,

On 21/05/2013 4:49 PM, Staffan Larsen wrote:
>
> On 21 maj 2013, at 04:34, David Holmes <David.Holmes at oracle.com> wrote:
>
>> <added servicability>
>>
>> Hi Joe,
>>
>> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef.
>>
>> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value?
>
> Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report),

That would be a simpler solution semantically but the only way I can see 
to do that is to use a text replacement mechanism in the build files - 
as is done for the dynamic vtable symbols. I find that less appealing 
than simply exporting an interface that is configured to report an error 
(which is essentially what all the optional interfaces do under the 
minimal VM).

> I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error.
>
> As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler, and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented.

I guess we need to try and run it to find out.

Thanks,
David

> /Staffan
>
>>
>> Thanks,
>> David
>>
>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>>> The change is to include forte.cpp in the minimal jvm but to
>>> conditionalize the code so that
>>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>>
>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>>
>>>   * JDK-8013461 <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>>     a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in
>>>     minimal/libjvm.a when DEBUG_LEVEL == release
>>>     <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>>
>>> Thanks.
>>>
>>> joe
>>>
>>>
>

From volker.simonis at gmail.com  Tue May 21 00:10:10 2013
From: volker.simonis at gmail.com (Volker Simonis)
Date: Tue, 21 May 2013 09:10:10 +0200
Subject: CFV: New HSX Committer: Aleksey Shipilev
In-Reply-To: <519AB210.1070901@oracle.com>
References: <5111D374.2090101@oracle.com>
	<519AB210.1070901@oracle.com>
Message-ID: <CA+3eh12xV-oB7QWw6inYWtPXKxXNwZK2NTiFEZT2anLRc2VGjQ@mail.gmail.com>

Vote: yes


On Tue, May 21, 2013 at 1:30 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com
> wrote:

> I hereby nominate Aleksey Shipilev (OpenJDK user name: shade) to
> HSX Committer.
>
> Aleksey is a member of the Hotspot Performance group. He is working on
> java concurrency related projects. He contributed 11 changesets to HSX
> project and he is qualified to be committer [1]:
>
> http://hg.openjdk.java.net/**hsx/hotspot-main/hotspot/log?**rev=shipilev<http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=shipilev>
> http://hg.openjdk.java.net/**hsx/hotspot-rt/hotspot/rev/**571076d3c79d<http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/571076d3c79d>
> http://hg.openjdk.java.net/**hsx/hotspot-rt/hotspot/rev/**205dd30230e1<http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/205dd30230e1>
> http://hg.openjdk.java.net/**hsx/hotspot-rt/hotspot/rev/**50e9396d5257<http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/50e9396d5257>
>
> Votes are due by June 3, 2013.
>
> Only current HSX Committers [2] are eligible to vote on this nomination.
> Votes must be cast in the open by replying to this mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> Thanks,
> Vladimir Kozlov
>
> [1] http://openjdk.java.net/**projects/#project-committer<http://openjdk.java.net/projects/#project-committer>
> [2] http://openjdk.java.net/**census#hsx<http://openjdk.java.net/census#hsx>
> [3] http://openjdk.java.net/**projects#committer-vote<http://openjdk.java.net/projects#committer-vote>
>
>
>
>
>
>
>

From vladimir.x.ivanov at oracle.com  Tue May 21 00:10:36 2013
From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov)
Date: Tue, 21 May 2013 11:10:36 +0400
Subject: CFV: New HSX Committer: Aleksey Shipilev
In-Reply-To: <519AB210.1070901@oracle.com>
References: <5111D374.2090101@oracle.com> <519AB210.1070901@oracle.com>
Message-ID: <519B1DEC.9060709@oracle.com>

Vote: yes

Best regards,
Vladimir Ivanov

On 5/21/13 3:30 AM, Vladimir Kozlov wrote:
> I hereby nominate Aleksey Shipilev (OpenJDK user name: shade) to
> HSX Committer.
>
> Aleksey is a member of the Hotspot Performance group. He is working on
> java concurrency related projects. He contributed 11 changesets to HSX
> project and he is qualified to be committer [1]:
>
> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=shipilev
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/571076d3c79d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/205dd30230e1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/50e9396d5257
>
> Votes are due by June 3, 2013.
>
> Only current HSX Committers [2] are eligible to vote on this nomination.
> Votes must be cast in the open by replying to this mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> Thanks,
> Vladimir Kozlov
>
> [1] http://openjdk.java.net/projects/#project-committer
> [2] http://openjdk.java.net/census#hsx
> [3] http://openjdk.java.net/projects#committer-vote
>
>
>
>
>
>

From serguei.spitsyn at oracle.com  Tue May 21 00:23:40 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Tue, 21 May 2013 00:23:40 -0700
Subject: CFV: New HSX Committer: Aleksey Shipilev
In-Reply-To: <519AB210.1070901@oracle.com>
References: <5111D374.2090101@oracle.com> <519AB210.1070901@oracle.com>
Message-ID: <519B20FC.3000702@oracle.com>

Vote: yes

On 5/20/13 4:30 PM, Vladimir Kozlov wrote:
> I hereby nominate Aleksey Shipilev (OpenJDK user name: shade) to
> HSX Committer.
>
> Aleksey is a member of the Hotspot Performance group. He is working on 
> java concurrency related projects. He contributed 11 changesets to HSX 
> project and he is qualified to be committer [1]:
>
> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=shipilev
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/571076d3c79d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/205dd30230e1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/50e9396d5257
>
> Votes are due by June 3, 2013.
>
> Only current HSX Committers [2] are eligible to vote on this nomination.
> Votes must be cast in the open by replying to this mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> Thanks,
> Vladimir Kozlov
>
> [1] http://openjdk.java.net/projects/#project-committer
> [2] http://openjdk.java.net/census#hsx
> [3] http://openjdk.java.net/projects#committer-vote
>
>
>
>
>
>


From stefan.karlsson at oracle.com  Tue May 21 00:42:35 2013
From: stefan.karlsson at oracle.com (Stefan Karlsson)
Date: Tue, 21 May 2013 09:42:35 +0200
Subject: CFV: New HSX Committer: Aleksey Shipilev
In-Reply-To: <519AB210.1070901@oracle.com>
References: <5111D374.2090101@oracle.com> <519AB210.1070901@oracle.com>
Message-ID: <519B256B.10903@oracle.com>

Vote: yes

StefanK

On 05/21/2013 01:30 AM, Vladimir Kozlov wrote:
> I hereby nominate Aleksey Shipilev (OpenJDK user name: shade) to
> HSX Committer.
>
> Aleksey is a member of the Hotspot Performance group. He is working on 
> java concurrency related projects. He contributed 11 changesets to HSX 
> project and he is qualified to be committer [1]:
>
> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=shipilev
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/571076d3c79d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/205dd30230e1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/50e9396d5257
>
> Votes are due by June 3, 2013.
>
> Only current HSX Committers [2] are eligible to vote on this nomination.
> Votes must be cast in the open by replying to this mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> Thanks,
> Vladimir Kozlov
>
> [1] http://openjdk.java.net/projects/#project-committer
> [2] http://openjdk.java.net/census#hsx
> [3] http://openjdk.java.net/projects#committer-vote
>
>
>
>
>
>


From aleksey.shipilev at oracle.com  Tue May 21 01:50:23 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Tue, 21 May 2013 12:50:23 +0400
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
In-Reply-To: <519AF56F.6020101@oracle.com>
References: <519A4B39.20208@oracle.com> <519ADB6E.1010400@oracle.com>
	<519AF56F.6020101@oracle.com>
Message-ID: <519B354F.4020607@oracle.com>

On 05/21/2013 08:17 AM, Vladimir Kozlov wrote:
> On 5/20/13 7:26 PM, David Holmes wrote:
>> Hi Aleksey,
>>
>> What value does max_oop_maps get? And how does that compare to the old
> 
> max_oop_maps = fac->count[NONSTATIC_OOP] is the same as before
> @Contended changes were added. Aleksey restored original correct value.
> 
>> value of "nonstatic_oop_count + 1"? I'm just trying to get a sense of
> 
> I don't remember why I had (nonstatic_oop_count + 1) in my original
> changes from few years ago. May be because resource allocation code
> complained about size == 0 (when nonstatic_oop_count == 0). Or when we
> allocate with UseMallocOnly.

I was puzzled about this one as well; traced down the code looking for
the uses beyond the limit, found none. This hack for zero allocations
intrigues me... so, I will return +1 in this changeset, and then submit
another CR for pruning it (this will allow us to have proper regression
test).

-Aleksey.

From aleksey.shipilev at oracle.com  Tue May 21 01:54:24 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Tue, 21 May 2013 12:54:24 +0400
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
In-Reply-To: <519AF56F.6020101@oracle.com>
References: <519A4B39.20208@oracle.com> <519ADB6E.1010400@oracle.com>
	<519AF56F.6020101@oracle.com>
Message-ID: <519B3640.8040401@oracle.com>

On 05/21/2013 08:17 AM, Vladimir Kozlov wrote:
> Note, current code allocates oopmap per contended oop fields even fields
> in one group (not separated by padding).

I know. This is another thing to tight up.

-Aleksey.



From jesper.wilhelmsson at oracle.com  Tue May 21 02:03:15 2013
From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson)
Date: Tue, 21 May 2013 11:03:15 +0200
Subject: CFV: New HSX Committer: Aleksey Shipilev
In-Reply-To: <519AB210.1070901@oracle.com>
References: <5111D374.2090101@oracle.com> <519AB210.1070901@oracle.com>
Message-ID: <519B3853.4070909@oracle.com>

Vote: yes

/Jesper

Vladimir Kozlov skrev 21/5/13 1:30 AM:
> I hereby nominate Aleksey Shipilev (OpenJDK user name: shade) to
> HSX Committer.
>
> Aleksey is a member of the Hotspot Performance group. He is working on java
> concurrency related projects. He contributed 11 changesets to HSX project and he
> is qualified to be committer [1]:
>
> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=shipilev
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/571076d3c79d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/205dd30230e1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/50e9396d5257
>
> Votes are due by June 3, 2013.
>
> Only current HSX Committers [2] are eligible to vote on this nomination.
> Votes must be cast in the open by replying to this mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> Thanks,
> Vladimir Kozlov
>
> [1] http://openjdk.java.net/projects/#project-committer
> [2] http://openjdk.java.net/census#hsx
> [3] http://openjdk.java.net/projects#committer-vote
>
>
>
>
>
>

From aleksey.shipilev at oracle.com  Tue May 21 02:03:53 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Tue, 21 May 2013 13:03:53 +0400
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
In-Reply-To: <519AF0D4.4080102@oracle.com>
References: <519A4B39.20208@oracle.com> <519AF0D4.4080102@oracle.com>
Message-ID: <519B3879.1050301@oracle.com>

Thanks Vladimir!

The updated webrev is here:
  http://cr.openjdk.java.net/~shade/8014886/webrev.02/

On 05/21/2013 07:58 AM, Vladimir Kozlov wrote:
> Is not has_nonstatic_fields also wrong?

Yes, it is. I haven't fixed this here for three reasons:
 a) this is not about oop maps
 b) tracked down the impact through the HS code, seems minimal
 c) because of (b): I'm still trying to get proper regression test for
has_nonstatic_fields ready

I will post another CR for fixing that one up.

> Rename: max_oop_maps -> max_nonstatic_oop_maps.

Done.

> For FieldsAllocationStyle=2 (default) we do special oop fields layout
> for super and subclass to have only one oopmap. You need to add non-oop
> fields (class in your test has only oop fields) to test different layouts.

Done. I had also the super-class to get the oops aligned in the oop chunk.

> Next added mess to already complicated code:
> 
> 3188   unsigned int nonstatic_double_count =
> fac->count[NONSTATIC_DOUBLE] - fac_contended.count[NONSTATIC_DOUBLE];
> 3189   unsigned int nonstatic_word_count   = fac->count[NONSTATIC_WORD]
>   - fac_contended.count[NONSTATIC_WORD];
> 3190   unsigned int nonstatic_short_count  = fac->count[NONSTATIC_SHORT]
>  - fac_contended.count[NONSTATIC_SHORT];
> 3191   unsigned int nonstatic_byte_count   = fac->count[NONSTATIC_BYTE]
>   - fac_contended.count[NONSTATIC_BYTE];
> 3192   unsigned int nonstatic_oop_count    = fac->count[NONSTATIC_OOP]  
> - fac_contended.count[NONSTATIC_OOP];

> At least add comment that these counts are for not contended fields.

Already taken care of in the baseline: there is a terse comment. I will
clean up that mess during further cleanup work. The regression tests
like this one will help to build enough safety net for the refactoring.

-Aleksey.

From aleksey.shipilev at oracle.com  Tue May 21 04:35:00 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Tue, 21 May 2013 15:35:00 +0400
Subject: RFR (S) CR 8014964: @Contended breaks has_nonstatic_fields invariant
Message-ID: <519B5BE4.90009@oracle.com>

Hi,

This is the fix for another issue found during the review:
   http://cr.openjdk.java.net/~shade/8014964/webrev.01/

This is the minimal fix which brings has_nonstatic_fields in order. The
whole method needs refactoring anyway to untangle *_count mess. I would
nevertheless commit this minimal fix to solve the immediate problem
while I'm working on further cleanups.

Testing:
  - adhoc Linux x86_64/fastdebug test/runtime/contended tests
  - full JPRT cycle against hotspot-rt is running now

Thanks,
-Aleksey.

From alejandro.murillo at oracle.com  Tue May 21 05:17:32 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Tue, 21 May 2013 12:17:32 +0000
Subject: hg: hsx/hsx24/hotspot: 8014941: make jdk7u40 the default jprt release
	for hs24
Message-ID: <20130521121739.B654148BEF@hg.openjdk.java.net>

Changeset: 87978e19157c
Author:    amurillo
Date:      2013-05-20 23:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/87978e19157c

8014941: make jdk7u40 the default jprt release for hs24
Reviewed-by: dholmes, collins

! make/jprt.properties


From daniel.daugherty at oracle.com  Tue May 21 05:44:45 2013
From: daniel.daugherty at oracle.com (Daniel D. Daugherty)
Date: Tue, 21 May 2013 06:44:45 -0600
Subject: CFV: New HSX Committer: Aleksey Shipilev
In-Reply-To: <519AB210.1070901@oracle.com>
References: <5111D374.2090101@oracle.com> <519AB210.1070901@oracle.com>
Message-ID: <519B6C3D.5060702@oracle.com>

Vote: yes

Dan


On 5/20/13 5:30 PM, Vladimir Kozlov wrote:
> I hereby nominate Aleksey Shipilev (OpenJDK user name: shade) to
> HSX Committer.
>
> Aleksey is a member of the Hotspot Performance group. He is working on 
> java concurrency related projects. He contributed 11 changesets to HSX 
> project and he is qualified to be committer [1]:
>
> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=shipilev
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/571076d3c79d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/205dd30230e1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/50e9396d5257
>
> Votes are due by June 3, 2013.
>
> Only current HSX Committers [2] are eligible to vote on this nomination.
> Votes must be cast in the open by replying to this mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> Thanks,
> Vladimir Kozlov
>
> [1] http://openjdk.java.net/projects/#project-committer
> [2] http://openjdk.java.net/census#hsx
> [3] http://openjdk.java.net/projects#committer-vote
>
>
>
>
>
>


From vladimir.kozlov at oracle.com  Tue May 21 07:40:32 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Tue, 21 May 2013 07:40:32 -0700
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
In-Reply-To: <519B3879.1050301@oracle.com>
References: <519A4B39.20208@oracle.com> <519AF0D4.4080102@oracle.com>
	<519B3879.1050301@oracle.com>
Message-ID: <519B8760.6000109@oracle.com>

Code is good.

On 5/21/13 2:03 AM, Aleksey Shipilev wrote:
> Thanks Vladimir!
>
> The updated webrev is here:
>    http://cr.openjdk.java.net/~shade/8014886/webrev.02/
>
> On 05/21/2013 07:58 AM, Vladimir Kozlov wrote:
>> Is not has_nonstatic_fields also wrong?
>
> Yes, it is. I haven't fixed this here for three reasons:
>   a) this is not about oop maps
>   b) tracked down the impact through the HS code, seems minimal
>   c) because of (b): I'm still trying to get proper regression test for
> has_nonstatic_fields ready

Okay.

>
> I will post another CR for fixing that one up.
>
>> Rename: max_oop_maps -> max_nonstatic_oop_maps.
>
> Done.
>
>> For FieldsAllocationStyle=2 (default) we do special oop fields layout
>> for super and subclass to have only one oopmap. You need to add non-oop
>> fields (class in your test has only oop fields) to test different layouts.
>
> Done. I had also the super-class to get the oops aligned in the oop chunk.
>
>> Next added mess to already complicated code:
>>
>> 3188   unsigned int nonstatic_double_count =
>> fac->count[NONSTATIC_DOUBLE] - fac_contended.count[NONSTATIC_DOUBLE];
>> 3189   unsigned int nonstatic_word_count   = fac->count[NONSTATIC_WORD]
>>    - fac_contended.count[NONSTATIC_WORD];
>> 3190   unsigned int nonstatic_short_count  = fac->count[NONSTATIC_SHORT]
>>   - fac_contended.count[NONSTATIC_SHORT];
>> 3191   unsigned int nonstatic_byte_count   = fac->count[NONSTATIC_BYTE]
>>    - fac_contended.count[NONSTATIC_BYTE];
>> 3192   unsigned int nonstatic_oop_count    = fac->count[NONSTATIC_OOP]
>> - fac_contended.count[NONSTATIC_OOP];
>
>> At least add comment that these counts are for not contended fields.
>
> Already taken care of in the baseline: there is a terse comment. I will
> clean up that mess during further cleanup work. The regression tests
> like this one will help to build enough safety net for the refactoring.

thanks,
Vladimir

>
> -Aleksey.
>

From aleksey.shipilev at oracle.com  Tue May 21 07:44:02 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Tue, 21 May 2013 18:44:02 +0400
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
In-Reply-To: <519B8760.6000109@oracle.com>
References: <519A4B39.20208@oracle.com> <519AF0D4.4080102@oracle.com>
	<519B3879.1050301@oracle.com> <519B8760.6000109@oracle.com>
Message-ID: <519B8832.50105@oracle.com>

Thanks!

We need second reviewer.

-Aleksey.

On 05/21/2013 06:40 PM, Vladimir Kozlov wrote:
> Code is good.
> 
> On 5/21/13 2:03 AM, Aleksey Shipilev wrote:
>> Thanks Vladimir!
>>
>> The updated webrev is here:
>>    http://cr.openjdk.java.net/~shade/8014886/webrev.02/

-Aleksey.


From vladimir.kozlov at oracle.com  Tue May 21 07:56:31 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Tue, 21 May 2013 07:56:31 -0700
Subject: RFR (S) CR 8014964: @Contended breaks has_nonstatic_fields
	invariant
In-Reply-To: <519B5BE4.90009@oracle.com>
References: <519B5BE4.90009@oracle.com>
Message-ID: <519B8B1F.20204@oracle.com>

In assert you don't need to test nonstatic_field_size > 0 because you tested it for 0 already so other tests will be 
executed only when it is != 0.
I don't understand why you don't check has_nonstatic_fields when parsed_annotations->is_contended(). With the fix 
has_nonstatic_fields also includes contended fields so it does not matter if you have annotation or not.

Thanks,
Vladimir

On 5/21/13 4:35 AM, Aleksey Shipilev wrote:
> Hi,
>
> This is the fix for another issue found during the review:
>     http://cr.openjdk.java.net/~shade/8014964/webrev.01/
>
> This is the minimal fix which brings has_nonstatic_fields in order. The
> whole method needs refactoring anyway to untangle *_count mess. I would
> nevertheless commit this minimal fix to solve the immediate problem
> while I'm working on further cleanups.
>
> Testing:
>    - adhoc Linux x86_64/fastdebug test/runtime/contended tests
>    - full JPRT cycle against hotspot-rt is running now
>
> Thanks,
> -Aleksey.
>

From aleksey.shipilev at oracle.com  Tue May 21 08:15:29 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Tue, 21 May 2013 19:15:29 +0400
Subject: RFR (S) CR 8014964: @Contended breaks has_nonstatic_fields
	invariant
In-Reply-To: <519B8B1F.20204@oracle.com>
References: <519B5BE4.90009@oracle.com> <519B8B1F.20204@oracle.com>
Message-ID: <519B8F91.7060604@oracle.com>

Thanks for the review!

Updated webrev is here:
  http://cr.openjdk.java.net/~shade/8014964/webrev.02/

On 05/21/2013 06:56 PM, Vladimir Kozlov wrote:
> In assert you don't need to test nonstatic_field_size > 0 because you
> tested it for 0 already so other tests will be executed only when it is
> != 0.

Short-circuiting... fair enough. Fixed.

> I don't understand why you don't check has_nonstatic_fields when
> parsed_annotations->is_contended(). With the fix has_nonstatic_fields
> also includes contended fields so it does not matter if you have
> annotation or not.

It does matter: for @Contended class without fields, we actually have
nonstatic_field_size > 0 (because it includes padding), but still no
fields. R3 class in regression test will fail the assert otherwise. I
added the comment about this before the assert. I'll keep in mind during
the cleanup whether something can be done to make @Contended class case
assertable as well.

(In grand scheme of things, we might allow @Contended to skip generating
the padding if no fields are present, but this is messy to do with
current one-pass code).

-Aleksey.

From aleksey.shipilev at oracle.com  Tue May 21 08:22:32 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Tue, 21 May 2013 19:22:32 +0400
Subject: RFR (S) CR 8014964: @Contended breaks has_nonstatic_fields
	invariant
In-Reply-To: <519B8F91.7060604@oracle.com>
References: <519B5BE4.90009@oracle.com> <519B8B1F.20204@oracle.com>
	<519B8F91.7060604@oracle.com>
Message-ID: <519B9138.90508@oracle.com>

On 05/21/2013 07:15 PM, Aleksey Shipilev wrote:
> (In grand scheme of things, we might allow @Contended to skip generating
> the padding if no fields are present, but this is messy to do with
> current one-pass code).

Correction: nope, it actually seems simple enough.

The trouble is whether users can rely on this to get the isolation via
inheritance, which is completely another story...

-Aleksey.

From joseph.provino at oracle.com  Tue May 21 08:26:48 2013
From: joseph.provino at oracle.com (JOSEPH PROVINO)
Date: Tue, 21 May 2013 11:26:48 -0400
Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace
	in libjvm.symbols that does not exist in minimal/libjvm.a when
	DEBUG_LEVEL == release
In-Reply-To: <519ADD43.1030601@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
Message-ID: <519B9238.5030601@oracle.com>


On 5/20/2013 10:34 PM, David Holmes wrote:
> <added servicability>
>
> Hi Joe,
>
> As I have previously stated you copied the struct definitions instead 
> of moving them outside the ifdef.

I fixed this and will send out a new webrev.

joe

>
> Serviceability folk: we are particularly interested in whether the use 
> of ticks_no_class_load is deemed appropriate in this situation. Who 
> will be consuming this value?
>
> Thanks,
> David
>
> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>> The change is to include forte.cpp in the minimal jvm but to
>> conditionalize the code so that
>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>
>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>
>>   * JDK-8013461 <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>     a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in
>>     minimal/libjvm.a when DEBUG_LEVEL == release
>>     <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>
>> Thanks.
>>
>> joe
>>
>>


From joseph.provino at oracle.com  Tue May 21 08:33:19 2013
From: joseph.provino at oracle.com (JOSEPH PROVINO)
Date: Tue, 21 May 2013 11:33:19 -0400
Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace
	in libjvm.symbols that does not exist in minimal/libjvm.a when
	DEBUG_LEVEL == release
In-Reply-To: <D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
Message-ID: <519B93BF.4030309@oracle.com>


On 5/21/2013 2:49 AM, Staffan Larsen wrote:
> On 21 maj 2013, at 04:34, David Holmes <David.Holmes at oracle.com> wrote:
>
>> <added servicability>
>>
>> Hi Joe,
>>
>> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef.
>>
>> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value?
> Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report), I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error.

Okay, it sounds like I should abandon this approach and look into 
removing the symbol from the symbol files.

>
> As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler, and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented.

Sounds like returning an error isn't a good idea...

joe

>
> /Staffan
>
>> Thanks,
>> David
>>
>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>>> The change is to include forte.cpp in the minimal jvm but to
>>> conditionalize the code so that
>>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>>
>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>>
>>>   * JDK-8013461 <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>>     a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in
>>>     minimal/libjvm.a when DEBUG_LEVEL == release
>>>     <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>>
>>> Thanks.
>>>
>>> joe
>>>
>>>


From joseph.provino at oracle.com  Tue May 21 08:35:14 2013
From: joseph.provino at oracle.com (JOSEPH PROVINO)
Date: Tue, 21 May 2013 11:35:14 -0400
Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace
	in libjvm.symbols that does not exist in minimal/libjvm.a when
	DEBUG_LEVEL == release
In-Reply-To: <519B1CDE.4090507@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
	<519B1CDE.4090507@oracle.com>
Message-ID: <519B9432.50808@oracle.com>


On 5/21/2013 3:06 AM, David Holmes wrote:
> Hi Staffan,
>
> On 21/05/2013 4:49 PM, Staffan Larsen wrote:
>>
>> On 21 maj 2013, at 04:34, David Holmes <David.Holmes at oracle.com> wrote:
>>
>>> <added servicability>
>>>
>>> Hi Joe,
>>>
>>> As I have previously stated you copied the struct definitions 
>>> instead of moving them outside the ifdef.
>>>
>>> Serviceability folk: we are particularly interested in whether the 
>>> use of ticks_no_class_load is deemed appropriate in this situation. 
>>> Who will be consuming this value?
>>
>> Since you have opted for the simple fix of having an exported but 
>> non-functional AsyncGetCallTrace instead of actually removing the 
>> symbol from the symbol files (which is the proposed solution in the 
>> bug report),
>
> That would be a simpler solution semantically but the only way I can 
> see to do that is to use a text replacement mechanism in the build 
> files - as is done for the dynamic vtable symbols. I find that less 
> appealing than simply exporting an interface that is configured to 
> report an error (which is essentially what all the optional interfaces 
> do under the minimal VM).
>
>> I would like you to include a comment about this in the source. Right 
>> now it's very unclear why there is an exported function that only 
>> returns an error.
>>
>> As to the appropriate return value, I don't know. The only caller 
>> should be the Sun Studio profiler, and I'm not sure how it will 
>> handle this case if ever run. The possible return values aren't very 
>> well documented.
>
> I guess we need to try and run it to find out.

Okay, do either of you feel strongly about how this should be fixed -- 
return an error or remove the symbol?

joe

>
> Thanks,
> David
>
>> /Staffan
>>
>>>
>>> Thanks,
>>> David
>>>
>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>>>> The change is to include forte.cpp in the minimal jvm but to
>>>> conditionalize the code so that
>>>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>>>
>>>> Webrev is here: 
>>>> http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>>>
>>>>   * JDK-8013461 
>>>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>>>     a symbol AsyncGetCallTrace in libjvm.symbols that does not 
>>>> exist in
>>>>     minimal/libjvm.a when DEBUG_LEVEL == release
>>>>     <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>>>
>>>> Thanks.
>>>>
>>>> joe
>>>>
>>>>
>>


From vladimir.kozlov at oracle.com  Tue May 21 09:06:59 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Tue, 21 May 2013 09:06:59 -0700
Subject: RFR (S) CR 8014964: @Contended breaks has_nonstatic_fields
	invariant
In-Reply-To: <519B8F91.7060604@oracle.com>
References: <519B5BE4.90009@oracle.com> <519B8B1F.20204@oracle.com>
	<519B8F91.7060604@oracle.com>
Message-ID: <519B9BA3.5070404@oracle.com>


On 5/21/13 8:15 AM, Aleksey Shipilev wrote:
> Thanks for the review!
>
> Updated webrev is here:
>    http://cr.openjdk.java.net/~shade/8014964/webrev.02/
>
> On 05/21/2013 06:56 PM, Vladimir Kozlov wrote:
>> In assert you don't need to test nonstatic_field_size > 0 because you
>> tested it for 0 already so other tests will be executed only when it is
>> != 0.
>
> Short-circuiting... fair enough. Fixed.

Could you move third check on next line so you can see all on one screen?

>
>> I don't understand why you don't check has_nonstatic_fields when
>> parsed_annotations->is_contended(). With the fix has_nonstatic_fields
>> also includes contended fields so it does not matter if you have
>> annotation or not.
>
> It does matter: for @Contended class without fields, we actually have
> nonstatic_field_size > 0 (because it includes padding), but still no
> fields. R3 class in regression test will fail the assert otherwise. I
> added the comment about this before the assert. I'll keep in mind during
> the cleanup whether something can be done to make @Contended class case
> assertable as well.

You are right. So parsed_annotations->is_contended() is true for any combinations of class and fields annotation. Right?

Is it possible nonstatic_field_size > 0 without fields due to align_size_up() (for example, with compressed klass 
pointer in 64 bit VM)?

An other issue. The assert is not precise for current class because from one hand it includes data from super and on an 
other hand it checks annotation for current class. Can you add second assert? Something like:

assert(nonstatic_fields_count == 0 || parsed_annotations->is_contended() ||
        (nonstatic_fields_end > nonstatic_fields_start)

This could be affected by alignment even more than your assert. Could you look?

Thanks,
Vladimir

>
> (In grand scheme of things, we might allow @Contended to skip generating
> the padding if no fields are present, but this is messy to do with
> current one-pass code).
>
> -Aleksey.
>

From vladimir.kozlov at oracle.com  Tue May 21 09:14:48 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Tue, 21 May 2013 09:14:48 -0700
Subject: RFR (S) CR 8014964: @Contended breaks has_nonstatic_fields
	invariant
In-Reply-To: <519B9BA3.5070404@oracle.com>
References: <519B5BE4.90009@oracle.com> <519B8B1F.20204@oracle.com>
	<519B8F91.7060604@oracle.com> <519B9BA3.5070404@oracle.com>
Message-ID: <519B9D78.70107@oracle.com>

On 5/21/13 9:06 AM, Vladimir Kozlov wrote:
>
> On 5/21/13 8:15 AM, Aleksey Shipilev wrote:
>> Thanks for the review!
>>
>> Updated webrev is here:
>>    http://cr.openjdk.java.net/~shade/8014964/webrev.02/
>>
>> On 05/21/2013 06:56 PM, Vladimir Kozlov wrote:
>>> In assert you don't need to test nonstatic_field_size > 0 because you
>>> tested it for 0 already so other tests will be executed only when it is
>>> != 0.
>>
>> Short-circuiting... fair enough. Fixed.
>
> Could you move third check on next line so you can see all on one screen?
>
>>
>>> I don't understand why you don't check has_nonstatic_fields when
>>> parsed_annotations->is_contended(). With the fix has_nonstatic_fields
>>> also includes contended fields so it does not matter if you have
>>> annotation or not.
>>
>> It does matter: for @Contended class without fields, we actually have
>> nonstatic_field_size > 0 (because it includes padding), but still no
>> fields. R3 class in regression test will fail the assert otherwise. I
>> added the comment about this before the assert. I'll keep in mind during
>> the cleanup whether something can be done to make @Contended class case
>> assertable as well.
>
> You are right. So parsed_annotations->is_contended() is true for any combinations of class and fields annotation. Right?
>
> Is it possible nonstatic_field_size > 0 without fields due to align_size_up() (for example, with compressed klass
> pointer in 64 bit VM)?
>
> An other issue. The assert is not precise for current class because from one hand it includes data from super and on an
> other hand it checks annotation for current class. Can you add second assert? Something like:
>
> assert(nonstatic_fields_count == 0 || parsed_annotations->is_contended() ||
>         (nonstatic_fields_end > nonstatic_fields_start)

Correction, checks should be reversed:

assert((nonstatic_fields_end == nonstatic_fields_start) ||
        parsed_annotations->is_contended() ||
        (nonstatic_fields_count > 0)

Vladimir

>
> This could be affected by alignment even more than your assert. Could you look?
>
> Thanks,
> Vladimir
>
>>
>> (In grand scheme of things, we might allow @Contended to skip generating
>> the padding if no fields are present, but this is messy to do with
>> current one-pass code).
>>
>> -Aleksey.
>>

From joseph.provino at oracle.com  Tue May 21 09:31:25 2013
From: joseph.provino at oracle.com (JOSEPH PROVINO)
Date: Tue, 21 May 2013 12:31:25 -0400
Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace
	in libjvm.symbols that does not exist in minimal/libjvm.a when
	DEBUG_LEVEL == release
In-Reply-To: <519A7EB4.5070901@oracle.com>
References: <519A751A.5090604@oracle.com> <519A7EB4.5070901@oracle.com>
Message-ID: <519BA15D.5090203@oracle.com>


On 5/20/2013 3:51 PM, serguei.spitsyn at oracle.com wrote:
> Hi Joe,
>
> src/share/vm/prims/forte.cpp
>
>
> These are new lines added unconditionally:
>    38 // call frame copied from old .h file and renamed
>    39 typedef struct {
>    40     jint lineno;                      // line number in the source file
>    41     jmethodID method_id;              // method executed in this frame
>    42 } ASGCT_CallFrame;
>    43
>    44 // call trace copied from old .h file and renamed
>    45 typedef struct {
>    46     JNIEnv *env_id;                   // Env where trace was recorded
>    47     jint num_frames;                  // number of frames in this trace
>    48     ASGCT_CallFrame *frames;          // frames
>    49 } ASGCT_CallTrace;
>    50
>
> Should the following lines (under #if INCLUDE_JVMTI) be removed ? :

Yes, I fixed that.  I'll put out another webrev.

>   379 // call frame copied from old .h file and renamed
>   380 typedef struct {
>   381     jint lineno;                      // line number in the source file
>   382     jmethodID method_id;              // method executed in this frame
>   383 } ASGCT_CallFrame;
>   384
>   385 // call trace copied from old .h file and renamed
>   386 typedef struct {
>   387     JNIEnv *env_id;                   // Env where trace was recorded
>   388     jint num_frames;                  // number of frames in this trace
>   389     ASGCT_CallFrame *frames;          // frames
>   390 } ASGCT_CallTrace;
>   391
>
> Did you build the fix for non-minimal VM configuration?

I did with the new changes.

thanks.

joe

>
> Other than that the fix looks good.
> It'd be nice if Dan reviewed it too.
>
>
> Thanks,
> Serguei
>
>
> On 5/20/13 12:10 PM, JOSEPH PROVINO wrote:
>> The change is to include forte.cpp in the minimal jvm but to 
>> conditionalize the code so that
>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>
>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>
>>  * JDK-8013461 <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>    a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in
>>    minimal/libjvm.a when DEBUG_LEVEL == release
>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>
>> Thanks.
>>
>> joe
>>
>>
>


From kellyohair at gmail.com  Tue May 21 09:33:22 2013
From: kellyohair at gmail.com (Kelly O'Hair)
Date: Tue, 21 May 2013 09:33:22 -0700
Subject: review request for JDK-8013461 There is a symbol
	AsyncGetCallTrace in libjvm.symbols that does not exist in
	minimal/libjvm.a when DEBUG_LEVEL == release
In-Reply-To: <519B9432.50808@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
	<519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com>
Message-ID: <365E7794-6CAD-4FB8-A6F8-7A5424BFE378@gmail.com>

http://jeremymanson.blogspot.com/2007/05/profiling-with-jvmtijvmpi-sigprof-and.html
http://stackoverflow.com/questions/3426537/how-to-properly-write-a-sigprof-handler-that-invokes-asyncgetcalltrace
http://hiroshiyamauchi.blogspot.com/2008/12/stabilizing-asyncgetcalltrace.html

The AsyncGetCallTrace symbol is a public extern symbol, unfortunately.
So there may be third party shared libraries dependent on the extern, and optionally calling it.
Removing the symbol will prevent those libraries from linking into the VM, even if they don't call it.

Just FYI...

-kto

On May 21, 2013, at 8:35 AM, JOSEPH PROVINO wrote:

> 
> On 5/21/2013 3:06 AM, David Holmes wrote:
>> Hi Staffan,
>> 
>> On 21/05/2013 4:49 PM, Staffan Larsen wrote:
>>> 
>>> On 21 maj 2013, at 04:34, David Holmes <David.Holmes at oracle.com> wrote:
>>> 
>>>> <added servicability>
>>>> 
>>>> Hi Joe,
>>>> 
>>>> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef.
>>>> 
>>>> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value?
>>> 
>>> Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report),
>> 
>> That would be a simpler solution semantically but the only way I can see to do that is to use a text replacement mechanism in the build files - as is done for the dynamic vtable symbols. I find that less appealing than simply exporting an interface that is configured to report an error (which is essentially what all the optional interfaces do under the minimal VM).
>> 
>>> I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error.
>>> 
>>> As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler, and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented.
>> 
>> I guess we need to try and run it to find out.
> 
> Okay, do either of you feel strongly about how this should be fixed -- return an error or remove the symbol?
> 
> joe
> 
>> 
>> Thanks,
>> David
>> 
>>> /Staffan
>>> 
>>>> 
>>>> Thanks,
>>>> David
>>>> 
>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>>>>> The change is to include forte.cpp in the minimal jvm but to
>>>>> conditionalize the code so that
>>>>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>>>> 
>>>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>>>> 
>>>>>  * JDK-8013461 <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>>>>    a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in
>>>>>    minimal/libjvm.a when DEBUG_LEVEL == release
>>>>>    <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>>>> 
>>>>> Thanks.
>>>>> 
>>>>> joe
>>>>> 
>>>>> 
>>> 
> 


From joseph.provino at oracle.com  Tue May 21 10:57:50 2013
From: joseph.provino at oracle.com (JOSEPH PROVINO)
Date: Tue, 21 May 2013 13:57:50 -0400
Subject: review request -- JDK-801106 Some tests have failed with SIGSEGV
	on arm-hflt on build b82
In-Reply-To: <519A9D5B.7060705@oracle.com>
References: <519A78F4.4010909@oracle.com> <519A9D5B.7060705@oracle.com>
Message-ID: <519BB59E.3020801@oracle.com>

That's a good solution.  Is there any reason NMT_detail_supported can't 
be made const or
better yet eliminate the variable and just use if 
(PLATFORM_NMT_DETAIL_SUPPORTED) ?

joe

On 5/20/2013 6:02 PM, BILL PITTORE wrote:
>  Maybe something like I did for SUPPORTS_NATIVE_CX8. This gets defined 
> in globalDefinitions_<cpu>.hpp.
> In this situation maybe something like:
>
> memTracker.cpp
>   bool NMT_detail_supported = PLATFORM_NMT_DETAIL_SUPPORTED;
>
> then in globalDefinitions_<cpu>.hpp
>
> #define PLATFORM_NMT_DETAIL_SUPPORTED {true | false} as the case may be.
>
> Then you eliminate the need to add code to pd_initialize()
>
> bill
>
> On 5/20/2013 3:26 PM, JOSEPH PROVINO wrote:
>> Make it easy to disable NMT detail in platform specific code.
>>
>> A new variable NMT_detail_supported is defined and set to true.
>> It can be disabled in platform specific code as needed.
>>
>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8011064/webrev/
>>
>> JDK-8011064 <https://jbs.oracle.com/bugs/browse/JDK-8011064>Some 
>> tests have failed with SIGSEGV on arm-hflt on build b82 
>> <https://jbs.oracle.com/bugs/browse/JDK-8011064>
>
>


From staffan.larsen at oracle.com  Tue May 21 11:21:27 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Tue, 21 May 2013 20:21:27 +0200
Subject: review request for JDK-8013461 There is a symbol
	AsyncGetCallTrace in libjvm.symbols that does not exist in
	minimal/libjvm.a when DEBUG_LEVEL == release
In-Reply-To: <365E7794-6CAD-4FB8-A6F8-7A5424BFE378@gmail.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
	<519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com>
	<365E7794-6CAD-4FB8-A6F8-7A5424BFE378@gmail.com>
Message-ID: <1D9DF5EB-89CA-4DDF-9B5A-4DA0B2851E23@oracle.com>


On 21 maj 2013, at 18:33, Kelly O'Hair <kellyohair at gmail.com> wrote:

> http://jeremymanson.blogspot.com/2007/05/profiling-with-jvmtijvmpi-sigprof-and.html
> http://stackoverflow.com/questions/3426537/how-to-properly-write-a-sigprof-handler-that-invokes-asyncgetcalltrace
> http://hiroshiyamauchi.blogspot.com/2008/12/stabilizing-asyncgetcalltrace.html
> 
> The AsyncGetCallTrace symbol is a public extern symbol, unfortunately.
> So there may be third party shared libraries dependent on the extern, and optionally calling it.
> Removing the symbol will prevent those libraries from linking into the VM, even if they don't call it.

I'm willing to break this compatibility for the minimal JVM, given that it's never been supported or official in any way.

/Staffan

> 
> Just FYI...
> 
> -kto
> 
> On May 21, 2013, at 8:35 AM, JOSEPH PROVINO wrote:
> 
>> 
>> On 5/21/2013 3:06 AM, David Holmes wrote:
>>> Hi Staffan,
>>> 
>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote:
>>>> 
>>>> On 21 maj 2013, at 04:34, David Holmes <David.Holmes at oracle.com> wrote:
>>>> 
>>>>> <added servicability>
>>>>> 
>>>>> Hi Joe,
>>>>> 
>>>>> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef.
>>>>> 
>>>>> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value?
>>>> 
>>>> Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report),
>>> 
>>> That would be a simpler solution semantically but the only way I can see to do that is to use a text replacement mechanism in the build files - as is done for the dynamic vtable symbols. I find that less appealing than simply exporting an interface that is configured to report an error (which is essentially what all the optional interfaces do under the minimal VM).
>>> 
>>>> I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error.
>>>> 
>>>> As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler, and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented.
>>> 
>>> I guess we need to try and run it to find out.
>> 
>> Okay, do either of you feel strongly about how this should be fixed -- return an error or remove the symbol?
>> 
>> joe
>> 
>>> 
>>> Thanks,
>>> David
>>> 
>>>> /Staffan
>>>> 
>>>>> 
>>>>> Thanks,
>>>>> David
>>>>> 
>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>>>>>> The change is to include forte.cpp in the minimal jvm but to
>>>>>> conditionalize the code so that
>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>>>>> 
>>>>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>>>>> 
>>>>>> * JDK-8013461 <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>>>>>   a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in
>>>>>>   minimal/libjvm.a when DEBUG_LEVEL == release
>>>>>>   <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>>>>> 
>>>>>> Thanks.
>>>>>> 
>>>>>> joe
>>>>>> 
>>>>>> 
>>>> 
>> 
> 


From staffan.larsen at oracle.com  Tue May 21 11:23:51 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Tue, 21 May 2013 20:23:51 +0200
Subject: review request for JDK-8013461 There is a symbol
	AsyncGetCallTrace in libjvm.symbols that does not exist in
	minimal/libjvm.a when DEBUG_LEVEL == release
In-Reply-To: <519B9432.50808@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
	<519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com>
Message-ID: <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com>


On 21 maj 2013, at 17:35, JOSEPH PROVINO <joseph.provino at oracle.com> wrote:

> 
> On 5/21/2013 3:06 AM, David Holmes wrote:
>> Hi Staffan,
>> 
>> On 21/05/2013 4:49 PM, Staffan Larsen wrote:
>>> 
>>> On 21 maj 2013, at 04:34, David Holmes <David.Holmes at oracle.com> wrote:
>>> 
>>>> <added servicability>
>>>> 
>>>> Hi Joe,
>>>> 
>>>> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef.
>>>> 
>>>> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value?
>>> 
>>> Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report),
>> 
>> That would be a simpler solution semantically but the only way I can see to do that is to use a text replacement mechanism in the build files - as is done for the dynamic vtable symbols. I find that less appealing than simply exporting an interface that is configured to report an error (which is essentially what all the optional interfaces do under the minimal VM).
>> 
>>> I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error.
>>> 
>>> As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler, and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented.
>> 
>> I guess we need to try and run it to find out.
> 
> Okay, do either of you feel strongly about how this should be fixed -- return an error or remove the symbol?

No, I don't feel strongly either way, but a comment in the code would be nice.

Thanks,
/Staffan


> 
> joe
> 
>> 
>> Thanks,
>> David
>> 
>>> /Staffan
>>> 
>>>> 
>>>> Thanks,
>>>> David
>>>> 
>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>>>>> The change is to include forte.cpp in the minimal jvm but to
>>>>> conditionalize the code so that
>>>>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>>>> 
>>>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>>>> 
>>>>>  * JDK-8013461 <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>>>>    a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in
>>>>>    minimal/libjvm.a when DEBUG_LEVEL == release
>>>>>    <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>>>> 
>>>>> Thanks.
>>>>> 
>>>>> joe
>>>>> 
>>>>> 
>>> 
> 


From joseph.provino at oracle.com  Tue May 21 11:26:29 2013
From: joseph.provino at oracle.com (JOSEPH PROVINO)
Date: Tue, 21 May 2013 14:26:29 -0400
Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace
	in libjvm.symbols that does not exist in minimal/libjvm.a when
	DEBUG_LEVEL == release
In-Reply-To: <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
	<519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com>
	<5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com>
Message-ID: <519BBC55.706@oracle.com>


On 5/21/2013 2:23 PM, Staffan Larsen wrote:
> On 21 maj 2013, at 17:35, JOSEPH PROVINO <joseph.provino at oracle.com> wrote:
>
>> On 5/21/2013 3:06 AM, David Holmes wrote:
>>> Hi Staffan,
>>>
>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote:
>>>> On 21 maj 2013, at 04:34, David Holmes <David.Holmes at oracle.com> wrote:
>>>>
>>>>> <added servicability>
>>>>>
>>>>> Hi Joe,
>>>>>
>>>>> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef.
>>>>>
>>>>> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value?
>>>> Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report),
>>> That would be a simpler solution semantically but the only way I can see to do that is to use a text replacement mechanism in the build files - as is done for the dynamic vtable symbols. I find that less appealing than simply exporting an interface that is configured to report an error (which is essentially what all the optional interfaces do under the minimal VM).
>>>
>>>> I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error.
>>>>
>>>> As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler,
Does anyone know where to find instructions on how to run the collector 
which would get the error return value?
>>>>   and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented.
>>> I guess we need to try and run it to find out.
>> Okay, do either of you feel strongly about how this should be fixed -- return an error or remove the symbol?
> No, I don't feel strongly either way, but a comment in the code would be nice.
How much effort should I put into finding out what Sun Studio profiler 
does when it gets -1?

joe

>
> Thanks,
> /Staffan
>
>
>> joe
>>
>>> Thanks,
>>> David
>>>
>>>> /Staffan
>>>>
>>>>> Thanks,
>>>>> David
>>>>>
>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>>>>>> The change is to include forte.cpp in the minimal jvm but to
>>>>>> conditionalize the code so that
>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>>>>>
>>>>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>>>>>
>>>>>>   * JDK-8013461 <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>>>>>     a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in
>>>>>>     minimal/libjvm.a when DEBUG_LEVEL == release
>>>>>>     <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>>>>>
>>>>>> Thanks.
>>>>>>
>>>>>> joe
>>>>>>
>>>>>>


From bengt.rutisson at oracle.com  Tue May 21 11:44:08 2013
From: bengt.rutisson at oracle.com (bengt.rutisson at oracle.com)
Date: Tue, 21 May 2013 18:44:08 +0000
Subject: hg: hsx/hsx24/hotspot: 7066063: CMS: "Conservation Principle" assert
	failed
Message-ID: <20130521184411.6522148C0A@hg.openjdk.java.net>

Changeset: 41f1dfc8331b
Author:    brutisso
Date:      2013-05-21 08:50 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/41f1dfc8331b

7066063: CMS: "Conservation Principle" assert failed
Summary: Add call to coalBirth() in CompactibleFreeListSpace::reset()
Reviewed-by: ysr, jmasa

! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp


From serguei.spitsyn at oracle.com  Tue May 21 12:08:21 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Tue, 21 May 2013 12:08:21 -0700
Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace
	in libjvm.symbols that does not exist in minimal/libjvm.a when
	DEBUG_LEVEL == release
In-Reply-To: <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
	<519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com>
	<5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com>
Message-ID: <519BC625.3050801@oracle.com>

On 5/21/13 11:23 AM, Staffan Larsen wrote:
> On 21 maj 2013, at 17:35, JOSEPH PROVINO <joseph.provino at oracle.com> wrote:
>
>> On 5/21/2013 3:06 AM, David Holmes wrote:
>>> Hi Staffan,
>>>
>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote:
>>>> On 21 maj 2013, at 04:34, David Holmes <David.Holmes at oracle.com> wrote:
>>>>
>>>>> <added servicability>
>>>>>
>>>>> Hi Joe,
>>>>>
>>>>> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef.
>>>>>
>>>>> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value?
>>>> Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report),
>>> That would be a simpler solution semantically but the only way I can see to do that is to use a text replacement mechanism in the build files - as is done for the dynamic vtable symbols. I find that less appealing than simply exporting an interface that is configured to report an error (which is essentially what all the optional interfaces do under the minimal VM).
>>>
>>>> I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error.
>>>>
>>>> As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler, and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented.
>>> I guess we need to try and run it to find out.
>> Okay, do either of you feel strongly about how this should be fixed -- return an error or remove the symbol?
> No, I don't feel strongly either way, but a comment in the code would be nice.

I do not have a strong preference  too, but returning an error looks 
acceptable to me.

Thanks,
Serguei

>
> Thanks,
> /Staffan
>
>
>> joe
>>
>>> Thanks,
>>> David
>>>
>>>> /Staffan
>>>>
>>>>> Thanks,
>>>>> David
>>>>>
>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>>>>>> The change is to include forte.cpp in the minimal jvm but to
>>>>>> conditionalize the code so that
>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>>>>>
>>>>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>>>>>
>>>>>>   * JDK-8013461 <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>>>>>     a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in
>>>>>>     minimal/libjvm.a when DEBUG_LEVEL == release
>>>>>>     <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>>>>>
>>>>>> Thanks.
>>>>>>
>>>>>> joe
>>>>>>
>>>>>>


From serguei.spitsyn at oracle.com  Tue May 21 12:16:09 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Tue, 21 May 2013 12:16:09 -0700
Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace
	in libjvm.symbols that does not exist in minimal/libjvm.a when
	DEBUG_LEVEL == release
In-Reply-To: <519BBC55.706@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
	<519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com>
	<5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com>
	<519BBC55.706@oracle.com>
Message-ID: <519BC7F9.4080904@oracle.com>

On 5/21/13 11:26 AM, JOSEPH PROVINO wrote:
>
> On 5/21/2013 2:23 PM, Staffan Larsen wrote:
>> On 21 maj 2013, at 17:35, JOSEPH PROVINO <joseph.provino at oracle.com> 
>> wrote:
>>
>>> On 5/21/2013 3:06 AM, David Holmes wrote:
>>>> Hi Staffan,
>>>>
>>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote:
>>>>> On 21 maj 2013, at 04:34, David Holmes <David.Holmes at oracle.com> 
>>>>> wrote:
>>>>>
>>>>>> <added servicability>
>>>>>>
>>>>>> Hi Joe,
>>>>>>
>>>>>> As I have previously stated you copied the struct definitions 
>>>>>> instead of moving them outside the ifdef.
>>>>>>
>>>>>> Serviceability folk: we are particularly interested in whether 
>>>>>> the use of ticks_no_class_load is deemed appropriate in this 
>>>>>> situation. Who will be consuming this value?
>>>>> Since you have opted for the simple fix of having an exported but 
>>>>> non-functional AsyncGetCallTrace instead of actually removing the 
>>>>> symbol from the symbol files (which is the proposed solution in 
>>>>> the bug report),
>>>> That would be a simpler solution semantically but the only way I 
>>>> can see to do that is to use a text replacement mechanism in the 
>>>> build files - as is done for the dynamic vtable symbols. I find 
>>>> that less appealing than simply exporting an interface that is 
>>>> configured to report an error (which is essentially what all the 
>>>> optional interfaces do under the minimal VM).
>>>>
>>>>> I would like you to include a comment about this in the source. 
>>>>> Right now it's very unclear why there is an exported function that 
>>>>> only returns an error.
>>>>>
>>>>> As to the appropriate return value, I don't know. The only caller 
>>>>> should be the Sun Studio profiler,
> Does anyone know where to find instructions on how to run the 
> collector which would get the error return value?
>>>>>   and I'm not sure how it will handle this case if ever run. The 
>>>>> possible return values aren't very well documented.
>>>> I guess we need to try and run it to find out.
>>> Okay, do either of you feel strongly about how this should be fixed 
>>> -- return an error or remove the symbol?
>> No, I don't feel strongly either way, but a comment in the code would 
>> be nice.
> How much effort should I put into finding out what Sun Studio profiler 
> does when it gets -1?

Let's ask the Solaris Studio guys directly.
I'm adding Oleg to the mailing list.

Oleg,

Could you, please, share your view on this problem?


Thanks,
Serguei




>
> joe
>
>>
>> Thanks,
>> /Staffan
>>
>>
>>> joe
>>>
>>>> Thanks,
>>>> David
>>>>
>>>>> /Staffan
>>>>>
>>>>>> Thanks,
>>>>>> David
>>>>>>
>>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>>>>>>> The change is to include forte.cpp in the minimal jvm but to
>>>>>>> conditionalize the code so that
>>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>>>>>>
>>>>>>> Webrev is here: 
>>>>>>> http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>>>>>>
>>>>>>>   * JDK-8013461 
>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>>>>>>     a symbol AsyncGetCallTrace in libjvm.symbols that does not 
>>>>>>> exist in
>>>>>>>     minimal/libjvm.a when DEBUG_LEVEL == release
>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>>>>>>
>>>>>>> Thanks.
>>>>>>>
>>>>>>> joe
>>>>>>>
>>>>>>>
>


From joseph.provino at oracle.com  Tue May 21 12:19:04 2013
From: joseph.provino at oracle.com (JOSEPH PROVINO)
Date: Tue, 21 May 2013 15:19:04 -0400
Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace
	in libjvm.symbols that does not exist in minimal/libjvm.a when
	DEBUG_LEVEL == release
In-Reply-To: <519BC7F9.4080904@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
	<519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com>
	<5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com>
	<519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com>
Message-ID: <519BC8A8.5060909@oracle.com>


On 5/21/2013 3:16 PM, serguei.spitsyn at oracle.com wrote:
> On 5/21/13 11:26 AM, JOSEPH PROVINO wrote:
>>
>> On 5/21/2013 2:23 PM, Staffan Larsen wrote:
>>> On 21 maj 2013, at 17:35, JOSEPH PROVINO <joseph.provino at oracle.com> 
>>> wrote:
>>>
>>>> On 5/21/2013 3:06 AM, David Holmes wrote:
>>>>> Hi Staffan,
>>>>>
>>>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote:
>>>>>> On 21 maj 2013, at 04:34, David Holmes <David.Holmes at oracle.com> 
>>>>>> wrote:
>>>>>>
>>>>>>> <added servicability>
>>>>>>>
>>>>>>> Hi Joe,
>>>>>>>
>>>>>>> As I have previously stated you copied the struct definitions 
>>>>>>> instead of moving them outside the ifdef.
>>>>>>>
>>>>>>> Serviceability folk: we are particularly interested in whether 
>>>>>>> the use of ticks_no_class_load is deemed appropriate in this 
>>>>>>> situation. Who will be consuming this value?
>>>>>> Since you have opted for the simple fix of having an exported but 
>>>>>> non-functional AsyncGetCallTrace instead of actually removing the 
>>>>>> symbol from the symbol files (which is the proposed solution in 
>>>>>> the bug report),
>>>>> That would be a simpler solution semantically but the only way I 
>>>>> can see to do that is to use a text replacement mechanism in the 
>>>>> build files - as is done for the dynamic vtable symbols. I find 
>>>>> that less appealing than simply exporting an interface that is 
>>>>> configured to report an error (which is essentially what all the 
>>>>> optional interfaces do under the minimal VM).
>>>>>
>>>>>> I would like you to include a comment about this in the source. 
>>>>>> Right now it's very unclear why there is an exported function 
>>>>>> that only returns an error.
>>>>>>
>>>>>> As to the appropriate return value, I don't know. The only caller 
>>>>>> should be the Sun Studio profiler,
>> Does anyone know where to find instructions on how to run the 
>> collector which would get the error return value?
>>>>>>   and I'm not sure how it will handle this case if ever run. The 
>>>>>> possible return values aren't very well documented.
>>>>> I guess we need to try and run it to find out.
>>>> Okay, do either of you feel strongly about how this should be fixed 
>>>> -- return an error or remove the symbol?
>>> No, I don't feel strongly either way, but a comment in the code 
>>> would be nice.
>> How much effort should I put into finding out what Sun Studio 
>> profiler does when it gets -1?
>
> Let's ask the Solaris Studio guys directly.
> I'm adding Oleg to the mailing list.
>
> Oleg,
>
> Could you, please, share your view on this problem?

In particular what will the Sun Studio Profiler collector do if it gets 
the error

trace->num_frames = ticks_no_class_load; // -1

Thanks.

joe

>
>
> Thanks,
> Serguei
>
>
>
>
>>
>> joe
>>
>>>
>>> Thanks,
>>> /Staffan
>>>
>>>
>>>> joe
>>>>
>>>>> Thanks,
>>>>> David
>>>>>
>>>>>> /Staffan
>>>>>>
>>>>>>> Thanks,
>>>>>>> David
>>>>>>>
>>>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>>>>>>>> The change is to include forte.cpp in the minimal jvm but to
>>>>>>>> conditionalize the code so that
>>>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>>>>>>>
>>>>>>>> Webrev is here: 
>>>>>>>> http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>>>>>>>
>>>>>>>>   * JDK-8013461 
>>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>>>>>>>     a symbol AsyncGetCallTrace in libjvm.symbols that does not 
>>>>>>>> exist in
>>>>>>>>     minimal/libjvm.a when DEBUG_LEVEL == release
>>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>>>>>>>
>>>>>>>> Thanks.
>>>>>>>>
>>>>>>>> joe
>>>>>>>>
>>>>>>>>
>>
>


From kellyohair at gmail.com  Tue May 21 12:27:25 2013
From: kellyohair at gmail.com (Kelly O'Hair)
Date: Tue, 21 May 2013 12:27:25 -0700
Subject: review request for JDK-8013461 There is a symbol
	AsyncGetCallTrace in libjvm.symbols that does not exist in
	minimal/libjvm.a when DEBUG_LEVEL == release
In-Reply-To: <519BC8A8.5060909@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
	<519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com>
	<5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com>
	<519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com>
	<519BC8A8.5060909@oracle.com>
Message-ID: <A9576DD0-5341-4CF6-A220-092699237BE4@gmail.com>


On May 21, 2013, at 12:19 PM, JOSEPH PROVINO wrote:

>> 
>> Let's ask the Solaris Studio guys directly.
>> I'm adding Oleg to the mailing list.
>> 
>> Oleg,
>> 
>> Could you, please, share your view on this problem?
> 
> In particular what will the Sun Studio Profiler collector do if it gets the error
> 
> trace->num_frames = ticks_no_class_load; // -1
> 
> Thanks.
> 
> joe

I am pretty sure you want to keep the symbol in the library and have it return an error code, rather
than remove the symbol entirely.
Most tools will not necessarily know what kind of jdk/jre is being used, and getting a runtime linker
error means the tool can't get off the ground, unless the tool library is doing a dlsym() to see if the
symbol exists or not first, and I kind of doubt they would do that in all cases, but maybe. Kind of
depends on what JDK implementations that they might expect their tool to run on. Hard to tell.

The tools will have many different features, and maybe the need for this symbol is only part of one
feature, and the other features might work fine in a minimal environment.

Granted, I'm speaking with very limited knowledge if this detailed discussion, but removing symbols
from shared libraries can be a very disruptive thing to tool vendors. Just a warning.

-kto

From joseph.provino at oracle.com  Tue May 21 12:55:39 2013
From: joseph.provino at oracle.com (JOSEPH PROVINO)
Date: Tue, 21 May 2013 15:55:39 -0400
Subject: review request -- JDK-8011064 Some tests have failed with SIGSEGV
	on arm-hflt on build b82
In-Reply-To: <519BB59E.3020801@oracle.com>
References: <519A78F4.4010909@oracle.com> <519A9D5B.7060705@oracle.com>
	<519BB59E.3020801@oracle.com>
Message-ID: <519BD13B.8030502@oracle.com>

New webrev is here:

http://cr.openjdk.java.net/~jprovino/8011064/webrev.01/

joe

On 5/21/2013 1:57 PM, JOSEPH PROVINO wrote:
> That's a good solution.  Is there any reason NMT_detail_supported 
> can't be made const or
> better yet eliminate the variable and just use if 
> (PLATFORM_NMT_DETAIL_SUPPORTED) ?
>
> joe
>
> On 5/20/2013 6:02 PM, BILL PITTORE wrote:
>>  Maybe something like I did for SUPPORTS_NATIVE_CX8. This gets 
>> defined in globalDefinitions_<cpu>.hpp.
>> In this situation maybe something like:
>>
>> memTracker.cpp
>>   bool NMT_detail_supported = PLATFORM_NMT_DETAIL_SUPPORTED;
>>
>> then in globalDefinitions_<cpu>.hpp
>>
>> #define PLATFORM_NMT_DETAIL_SUPPORTED {true | false} as the case may be.
>>
>> Then you eliminate the need to add code to pd_initialize()
>>
>> bill
>>
>> On 5/20/2013 3:26 PM, JOSEPH PROVINO wrote:
>>> Make it easy to disable NMT detail in platform specific code.
>>>
>>> A new variable NMT_detail_supported is defined and set to true.
>>> It can be disabled in platform specific code as needed.
>>>
>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8011064/webrev/
>>>
>>> JDK-8011064 <https://jbs.oracle.com/bugs/browse/JDK-8011064>Some 
>>> tests have failed with SIGSEGV on arm-hflt on build b82 
>>> <https://jbs.oracle.com/bugs/browse/JDK-8011064>
>>
>>
>


From joseph.provino at oracle.com  Tue May 21 13:52:21 2013
From: joseph.provino at oracle.com (JOSEPH PROVINO)
Date: Tue, 21 May 2013 16:52:21 -0400
Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace
	in libjvm.symbols that does not exist in minimal/libjvm.a when
	DEBUG_LEVEL == release
In-Reply-To: <519BD250.10302@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
	<519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com>
	<5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com>
	<519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com>
	<519BC8A8.5060909@oracle.com> <519BD250.10302@oracle.com>
Message-ID: <519BDE85.6000005@oracle.com>


On 5/21/2013 4:00 PM, Oleg Mazurov wrote:
> Though formally not part of the Solaris Studio team any more here is 
> my opinion based on my recollection of how I implemented interaction 
> with the JVM via AsyncGetCallTrace.
> It's looked up using dlsym. If the symbol is not there Java callstack 
> collection is shut down. I understand in your case even JVMTI is not 
> there so the dlsym call will not be made.
> From that perspective there is no difference whether the symbol is 
> present and returns an error code or not present at all.

Oleg, then it sounds like what we have will work.

Thanks for the quick reply.

joe

>
>     -- Oleg
>
> On 5/21/2013 12:19 PM, JOSEPH PROVINO wrote:
>>
>> On 5/21/2013 3:16 PM, serguei.spitsyn at oracle.com wrote:
>>> On 5/21/13 11:26 AM, JOSEPH PROVINO wrote:
>>>>
>>>> On 5/21/2013 2:23 PM, Staffan Larsen wrote:
>>>>> On 21 maj 2013, at 17:35, JOSEPH PROVINO 
>>>>> <joseph.provino at oracle.com> wrote:
>>>>>
>>>>>> On 5/21/2013 3:06 AM, David Holmes wrote:
>>>>>>> Hi Staffan,
>>>>>>>
>>>>>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote:
>>>>>>>> On 21 maj 2013, at 04:34, David Holmes 
>>>>>>>> <David.Holmes at oracle.com> wrote:
>>>>>>>>
>>>>>>>>> <added servicability>
>>>>>>>>>
>>>>>>>>> Hi Joe,
>>>>>>>>>
>>>>>>>>> As I have previously stated you copied the struct definitions 
>>>>>>>>> instead of moving them outside the ifdef.
>>>>>>>>>
>>>>>>>>> Serviceability folk: we are particularly interested in whether 
>>>>>>>>> the use of ticks_no_class_load is deemed appropriate in this 
>>>>>>>>> situation. Who will be consuming this value?
>>>>>>>> Since you have opted for the simple fix of having an exported 
>>>>>>>> but non-functional AsyncGetCallTrace instead of actually 
>>>>>>>> removing the symbol from the symbol files (which is the 
>>>>>>>> proposed solution in the bug report),
>>>>>>> That would be a simpler solution semantically but the only way I 
>>>>>>> can see to do that is to use a text replacement mechanism in the 
>>>>>>> build files - as is done for the dynamic vtable symbols. I find 
>>>>>>> that less appealing than simply exporting an interface that is 
>>>>>>> configured to report an error (which is essentially what all the 
>>>>>>> optional interfaces do under the minimal VM).
>>>>>>>
>>>>>>>> I would like you to include a comment about this in the source. 
>>>>>>>> Right now it's very unclear why there is an exported function 
>>>>>>>> that only returns an error.
>>>>>>>>
>>>>>>>> As to the appropriate return value, I don't know. The only 
>>>>>>>> caller should be the Sun Studio profiler,
>>>> Does anyone know where to find instructions on how to run the 
>>>> collector which would get the error return value?
>>>>>>>>   and I'm not sure how it will handle this case if ever run. 
>>>>>>>> The possible return values aren't very well documented.
>>>>>>> I guess we need to try and run it to find out.
>>>>>> Okay, do either of you feel strongly about how this should be 
>>>>>> fixed -- return an error or remove the symbol?
>>>>> No, I don't feel strongly either way, but a comment in the code 
>>>>> would be nice.
>>>> How much effort should I put into finding out what Sun Studio 
>>>> profiler does when it gets -1?
>>>
>>> Let's ask the Solaris Studio guys directly.
>>> I'm adding Oleg to the mailing list.
>>>
>>> Oleg,
>>>
>>> Could you, please, share your view on this problem?
>>
>> In particular what will the Sun Studio Profiler collector do if it 
>> gets the error
>>
>> trace->num_frames = ticks_no_class_load; // -1
>>
>> Thanks.
>>
>> joe
>>
>>>
>>>
>>> Thanks,
>>> Serguei
>>>
>>>
>>>
>>>
>>>>
>>>> joe
>>>>
>>>>>
>>>>> Thanks,
>>>>> /Staffan
>>>>>
>>>>>
>>>>>> joe
>>>>>>
>>>>>>> Thanks,
>>>>>>> David
>>>>>>>
>>>>>>>> /Staffan
>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> David
>>>>>>>>>
>>>>>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>>>>>>>>>> The change is to include forte.cpp in the minimal jvm but to
>>>>>>>>>> conditionalize the code so that
>>>>>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>>>>>>>>>
>>>>>>>>>> Webrev is here: 
>>>>>>>>>> http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>>>>>>>>>
>>>>>>>>>>   * JDK-8013461 
>>>>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>>>>>>>>>     a symbol AsyncGetCallTrace in libjvm.symbols that does 
>>>>>>>>>> not exist in
>>>>>>>>>>     minimal/libjvm.a when DEBUG_LEVEL == release
>>>>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>>>>>>>>>
>>>>>>>>>> Thanks.
>>>>>>>>>>
>>>>>>>>>> joe
>>>>>>>>>>
>>>>>>>>>>
>>>>
>>>
>>
>


From erik.helin at oracle.com  Tue May 21 14:05:49 2013
From: erik.helin at oracle.com (erik.helin at oracle.com)
Date: Tue, 21 May 2013 21:05:49 +0000
Subject: hg: hsx/hsx24/hotspot: 2 new changesets
Message-ID: <20130521210556.E193348C1A@hg.openjdk.java.net>

Changeset: 97eb1ea6bae8
Author:    ehelin
Date:      2013-05-21 20:29 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/97eb1ea6bae8

8011891: The vm/gc/heap/heap_summary_after_gc event for CMS contains old data
Reviewed-by: brutisso, stefank

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp

Changeset: cea88a661227
Author:    ehelin
Date:      2013-05-21 20:46 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/cea88a661227

Merge



From oleg.mazurov at oracle.com  Tue May 21 13:00:16 2013
From: oleg.mazurov at oracle.com (Oleg Mazurov)
Date: Tue, 21 May 2013 13:00:16 -0700
Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace
	in libjvm.symbols that does not exist in minimal/libjvm.a when
	DEBUG_LEVEL == release
In-Reply-To: <519BC8A8.5060909@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
	<519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com>
	<5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com>
	<519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com>
	<519BC8A8.5060909@oracle.com>
Message-ID: <519BD250.10302@oracle.com>

Though formally not part of the Solaris Studio team any more here is my 
opinion based on my recollection of how I implemented interaction with 
the JVM via AsyncGetCallTrace.
It's looked up using dlsym. If the symbol is not there Java callstack 
collection is shut down. I understand in your case even JVMTI is not 
there so the dlsym call will not be made.
 From that perspective there is no difference whether the symbol is 
present and returns an error code or not present at all.

     -- Oleg

On 5/21/2013 12:19 PM, JOSEPH PROVINO wrote:
>
> On 5/21/2013 3:16 PM, serguei.spitsyn at oracle.com wrote:
>> On 5/21/13 11:26 AM, JOSEPH PROVINO wrote:
>>>
>>> On 5/21/2013 2:23 PM, Staffan Larsen wrote:
>>>> On 21 maj 2013, at 17:35, JOSEPH PROVINO 
>>>> <joseph.provino at oracle.com> wrote:
>>>>
>>>>> On 5/21/2013 3:06 AM, David Holmes wrote:
>>>>>> Hi Staffan,
>>>>>>
>>>>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote:
>>>>>>> On 21 maj 2013, at 04:34, David Holmes <David.Holmes at oracle.com> 
>>>>>>> wrote:
>>>>>>>
>>>>>>>> <added servicability>
>>>>>>>>
>>>>>>>> Hi Joe,
>>>>>>>>
>>>>>>>> As I have previously stated you copied the struct definitions 
>>>>>>>> instead of moving them outside the ifdef.
>>>>>>>>
>>>>>>>> Serviceability folk: we are particularly interested in whether 
>>>>>>>> the use of ticks_no_class_load is deemed appropriate in this 
>>>>>>>> situation. Who will be consuming this value?
>>>>>>> Since you have opted for the simple fix of having an exported 
>>>>>>> but non-functional AsyncGetCallTrace instead of actually 
>>>>>>> removing the symbol from the symbol files (which is the proposed 
>>>>>>> solution in the bug report),
>>>>>> That would be a simpler solution semantically but the only way I 
>>>>>> can see to do that is to use a text replacement mechanism in the 
>>>>>> build files - as is done for the dynamic vtable symbols. I find 
>>>>>> that less appealing than simply exporting an interface that is 
>>>>>> configured to report an error (which is essentially what all the 
>>>>>> optional interfaces do under the minimal VM).
>>>>>>
>>>>>>> I would like you to include a comment about this in the source. 
>>>>>>> Right now it's very unclear why there is an exported function 
>>>>>>> that only returns an error.
>>>>>>>
>>>>>>> As to the appropriate return value, I don't know. The only 
>>>>>>> caller should be the Sun Studio profiler,
>>> Does anyone know where to find instructions on how to run the 
>>> collector which would get the error return value?
>>>>>>>   and I'm not sure how it will handle this case if ever run. The 
>>>>>>> possible return values aren't very well documented.
>>>>>> I guess we need to try and run it to find out.
>>>>> Okay, do either of you feel strongly about how this should be 
>>>>> fixed -- return an error or remove the symbol?
>>>> No, I don't feel strongly either way, but a comment in the code 
>>>> would be nice.
>>> How much effort should I put into finding out what Sun Studio 
>>> profiler does when it gets -1?
>>
>> Let's ask the Solaris Studio guys directly.
>> I'm adding Oleg to the mailing list.
>>
>> Oleg,
>>
>> Could you, please, share your view on this problem?
>
> In particular what will the Sun Studio Profiler collector do if it 
> gets the error
>
> trace->num_frames = ticks_no_class_load; // -1
>
> Thanks.
>
> joe
>
>>
>>
>> Thanks,
>> Serguei
>>
>>
>>
>>
>>>
>>> joe
>>>
>>>>
>>>> Thanks,
>>>> /Staffan
>>>>
>>>>
>>>>> joe
>>>>>
>>>>>> Thanks,
>>>>>> David
>>>>>>
>>>>>>> /Staffan
>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> David
>>>>>>>>
>>>>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>>>>>>>>> The change is to include forte.cpp in the minimal jvm but to
>>>>>>>>> conditionalize the code so that
>>>>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>>>>>>>>
>>>>>>>>> Webrev is here: 
>>>>>>>>> http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>>>>>>>>
>>>>>>>>>   * JDK-8013461 
>>>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>>>>>>>>     a symbol AsyncGetCallTrace in libjvm.symbols that does not 
>>>>>>>>> exist in
>>>>>>>>>     minimal/libjvm.a when DEBUG_LEVEL == release
>>>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>>>>>>>>
>>>>>>>>> Thanks.
>>>>>>>>>
>>>>>>>>> joe
>>>>>>>>>
>>>>>>>>>
>>>
>>
>


From ioi.lam at oracle.com  Tue May 21 15:29:29 2013
From: ioi.lam at oracle.com (Ioi Lam)
Date: Tue, 21 May 2013 15:29:29 -0700
Subject: RFR (S) JDK-8014912 Restore PrintSharedSpaces after NPG
Message-ID: <519BF549.3070808@oracle.com>

Please review:

http://cr.openjdk.java.net/~iklam/8014912/print_sharedspc_001/

Bug: Restore PrintSharedSpaces functionality after NPG

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014912
     https://jbs.oracle.com/bugs/browse/JDK-8014912

Summary of fix:

I added a new enum, MetaspaceObj::Type, which is passed to

     Metaspace::allocate(ClassLoaderData* loader_data, size_t word_size,
                         bool read_only, MetaspaceObj::Type type, TRAPS);

During CDS dumping, all allocations are logged in a linked list to
be processed later by metaspaceShared.cpp to generate statistics for
objects in the CDS archive. See sample output below.

* No such logging is doneat normal VM execution time so there
   is no performance impact.

* I verified that the patch can be applied cleanly on Jon's
   recentpatch for JDK-8014862 "Add fast Metasapce capacity and
   used per MetadataType"

http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/2b1a9d972fc2

Testing:

     JPRT, UTE (vm.quick.testlist)

Sample output:

                         ro_cnt   ro_bytes     % | rw_cnt   rw_bytes     
% |  all_cnt  all_bytes     %
--------------------+---------------------------+---------------------------+--------------------------
Unknown             :        1         64   0.0 | 1         64   0.0 
|        2        128   0.0
Class               :        0          0   0.0 | 2364    2006080  14.7 
|     2364    2006080   9.2
Symbol              :    49858    2507168  30.9 | 0          0   0.0 
|    49858    2507168  11.5
TypeArrayU1         :    13264     608336   7.5 | 2365     428784   3.1 
|    15629    1037120   4.8
TypeArrayU2         :     4796     341952   4.2 | 0          0   0.0 
|     4796     341952   1.6
TypeArrayU4         :     2371     178528   2.2 | 0          0   0.0 
|     2371     178528   0.8
TypeArrayU8         :     3708     365920   4.5 | 0          0   0.0 
|     3708     365920   1.7
TypeArrayOther      :        0          0   0.0 | 0          0   0.0 
|        0          0   0.0
Method              :        0          0   0.0 | 32552    3659888  26.8 
|    32552    3659888  16.8
ConstMethod         :    32552    4099008  50.6 | 0          0   0.0 
|    32552    4099008  18.8
MethodData          :        0          0   0.0 | 0          0   0.0 
|        0          0   0.0
ConstantPool        :        0          0   0.0 | 2365    3225600  23.6 
|     2365    3225600  14.8
ConstantPoolCache   :        0          0   0.0 | 2350    2212320  16.2 
|     2350    2212320  10.2
Annotation          :       26       1248   0.0 | 0          0   0.0 
|       26       1248   0.0
MethodCounters      :        0          0   0.0 | 0          0   0.0 
|        0          0   0.0
SymbolHashentry     :        0          0   0.0 | 49858    1595456  11.7 
|    49858    1595456   7.3
SymbolBuckets       :        0          0   0.0 | 20011     320176   2.3 
|    20011     320176   1.5
Other               :        0          0   0.0 | 0     203893   1.5 
|        0     203893   0.9
--------------------+---------------------------+---------------------------+--------------------------
Total               :   106576    8102224 100.0 | 111866   13652261 
100.0 |   218442   21754485 100.0


Thanks,
Ioi



From tim.bell at oracle.com  Tue May 21 19:53:59 2013
From: tim.bell at oracle.com (Tim Bell)
Date: Tue, 21 May 2013 19:53:59 -0700
Subject: JPRT east is out of disk space: "NOT ACCEPTING JOBS AT THIS TIME"
Message-ID: <519C3347.8000302@oracle.com>

> JPRT System: east
>
>     As of: Tuesday May 21, 2013 22:43:02 EDT, Wed-02:43:02-GMT
>     Wiki: http://wiki.se.oracle.com/display/JPGINFRA/JPRT
>
> NOT ACCEPTING JOBS AT THIS TIME.

Folks - the 2TByte archive for the east coast queue is full.  It is time 
to either add more storage, or shed some of these old directories:

% pwd
/net/backpack.us.oracle.com/archives

% ls -latr
total 135
drwxrwxrwx   6 666      other          6 Dec 10  2003 2003
drwxrwxrwx  29 666      other         29 Nov 30  2004 2004
drwxrwxrwx  13 666      staff         13 Nov 16  2006 2006
drwxrwxrwx  28 666      other         28 Nov 30  2006 2005
drwxrwxrwx   7 666      staff          7 Jun  5  2007 1.6
drwxrwxrwx   7 666      staff         13 Jul 25  2007 2007
drwxr-xr-x   4 root     root           5 Jun 24  2010 home
drwxr-xr-x   6 root     root           6 Aug  9  2010 EBS
drwxr-xr-x  13 root     sys           13 Nov 30  2011 .
drwxrwxrwx  14 666      other         14 Dec 18  2011 1.5
drwxrwxrwx   3 666      other          3 Dec 19  2011 main
dr-xr-xr-x  12 root     root          12 May 12 17:37 ..
drwxrwxrwx  12 666      staff         21 May 21 22:46 jprt

The current working directories are under jprt.  Everything else looks 
like old legacy files to me.  Is there anything valuable under there, 
after all this time?

Please take a look and delete anything you can.


Until we have more free space, the east coast queue will remain "NOT 
ACCEPTING JOBS AT THIS TIME. "

Thanks-

Tim


From david.holmes at oracle.com  Tue May 21 21:21:34 2013
From: david.holmes at oracle.com (David Holmes)
Date: Wed, 22 May 2013 14:21:34 +1000
Subject: CFV: New HSX Committer: Aleksey Shipilev
In-Reply-To: <519AB210.1070901@oracle.com>
References: <5111D374.2090101@oracle.com> <519AB210.1070901@oracle.com>
Message-ID: <519C47CE.8030200@oracle.com>

Vote: yes

David

On 21/05/2013 9:30 AM, Vladimir Kozlov wrote:
> I hereby nominate Aleksey Shipilev (OpenJDK user name: shade) to
> HSX Committer.
>
> Aleksey is a member of the Hotspot Performance group. He is working on
> java concurrency related projects. He contributed 11 changesets to HSX
> project and he is qualified to be committer [1]:
>
> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=shipilev
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/571076d3c79d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/205dd30230e1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/50e9396d5257
>
> Votes are due by June 3, 2013.
>
> Only current HSX Committers [2] are eligible to vote on this nomination.
> Votes must be cast in the open by replying to this mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> Thanks,
> Vladimir Kozlov
>
> [1] http://openjdk.java.net/projects/#project-committer
> [2] http://openjdk.java.net/census#hsx
> [3] http://openjdk.java.net/projects#committer-vote
>
>
>
>
>
>

From david.holmes at oracle.com  Tue May 21 21:43:45 2013
From: david.holmes at oracle.com (David Holmes)
Date: Wed, 22 May 2013 14:43:45 +1000
Subject: review request -- JDK-8011064 Some tests have failed with SIGSEGV
	on arm-hflt on build b82
In-Reply-To: <519BD13B.8030502@oracle.com>
References: <519A78F4.4010909@oracle.com> <519A9D5B.7060705@oracle.com>
	<519BB59E.3020801@oracle.com> <519BD13B.8030502@oracle.com>
Message-ID: <519C4D01.40900@oracle.com>

Just for the benefit of others watching this, the undef approach is not 
ideal and there's another alternative in the pipeline.

David

On 22/05/2013 5:55 AM, JOSEPH PROVINO wrote:
> New webrev is here:
>
> http://cr.openjdk.java.net/~jprovino/8011064/webrev.01/
>
> joe
>
> On 5/21/2013 1:57 PM, JOSEPH PROVINO wrote:
>> That's a good solution.  Is there any reason NMT_detail_supported
>> can't be made const or
>> better yet eliminate the variable and just use if
>> (PLATFORM_NMT_DETAIL_SUPPORTED) ?
>>
>> joe
>>
>> On 5/20/2013 6:02 PM, BILL PITTORE wrote:
>>>  Maybe something like I did for SUPPORTS_NATIVE_CX8. This gets
>>> defined in globalDefinitions_<cpu>.hpp.
>>> In this situation maybe something like:
>>>
>>> memTracker.cpp
>>>   bool NMT_detail_supported = PLATFORM_NMT_DETAIL_SUPPORTED;
>>>
>>> then in globalDefinitions_<cpu>.hpp
>>>
>>> #define PLATFORM_NMT_DETAIL_SUPPORTED {true | false} as the case may be.
>>>
>>> Then you eliminate the need to add code to pd_initialize()
>>>
>>> bill
>>>
>>> On 5/20/2013 3:26 PM, JOSEPH PROVINO wrote:
>>>> Make it easy to disable NMT detail in platform specific code.
>>>>
>>>> A new variable NMT_detail_supported is defined and set to true.
>>>> It can be disabled in platform specific code as needed.
>>>>
>>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8011064/webrev/
>>>>
>>>> JDK-8011064 <https://jbs.oracle.com/bugs/browse/JDK-8011064>Some
>>>> tests have failed with SIGSEGV on arm-hflt on build b82
>>>> <https://jbs.oracle.com/bugs/browse/JDK-8011064>
>>>
>>>
>>
>

From david.holmes at oracle.com  Tue May 21 21:51:07 2013
From: david.holmes at oracle.com (David Holmes)
Date: Wed, 22 May 2013 14:51:07 +1000
Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace
	in libjvm.symbols that does not exist in minimal/libjvm.a when
	DEBUG_LEVEL == release
In-Reply-To: <A9576DD0-5341-4CF6-A220-092699237BE4@gmail.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
	<519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com>
	<5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com>
	<519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com>
	<519BC8A8.5060909@oracle.com>
	<A9576DD0-5341-4CF6-A220-092699237BE4@gmail.com>
Message-ID: <519C4EBB.5070306@oracle.com>

Hi Kelly,

On 22/05/2013 5:27 AM, Kelly O'Hair wrote:
> I am pretty sure you want to keep the symbol in the library and have it
> return an error code, rather than remove the symbol entirely.
> Most tools will not necessarily know what kind of jdk/jre is being used,
> and getting a runtime linker
> error means the tool can't get off the ground, unless the tool library
> is doing a dlsym() to see if the
> symbol exists or not first, and I kind of doubt they would do that in
> all cases, but maybe. Kind of
> depends on what JDK implementations that they might expect their tool to
> run on. Hard to tell.
>
> The tools will have many different features, and maybe the need for this
> symbol is only part of one
> feature, and the other features might work fine in a minimal environment.
>
> Granted, I'm speaking with very limited knowledge if this detailed
> discussion, but removing symbols
> from shared libraries can be a very disruptive thing to tool vendors.
> Just a warning.

FYI the minimalVM doesn't provide any optional VM interfaces. This means 
that most of the JVM/TI functions are not even present in the binaries 
(just those needed to ask the question "do you have JVM/TI"). So we're 
already well done the path of removing symbols.

David
-----

> -kto

From bengt.rutisson at oracle.com  Wed May 22 03:00:53 2013
From: bengt.rutisson at oracle.com (bengt.rutisson at oracle.com)
Date: Wed, 22 May 2013 10:00:53 +0000
Subject: hg: hsx/hsx24/hotspot: 7197666: java -d64 -version core dumps in a
	box with lots of memory
Message-ID: <20130522100058.6FE4F48C32@hg.openjdk.java.net>

Changeset: dffc616548d2
Author:    brutisso
Date:      2013-05-22 07:30 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/dffc616548d2

7197666: java -d64 -version core dumps in a box with lots of memory
Summary: Allow task queues to be mmapped instead of malloced on Solaris
Reviewed-by: coleenp, jmasa, johnc, tschatzl

! src/share/vm/memory/allocation.hpp
! src/share/vm/memory/allocation.inline.hpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/utilities/taskqueue.hpp


From joseph.provino at oracle.com  Wed May 22 08:16:54 2013
From: joseph.provino at oracle.com (JOSEPH PROVINO)
Date: Wed, 22 May 2013 11:16:54 -0400
Subject: review request -- JDK-8011064 Some tests have failed with SIGSEGV
	on arm-hflt on build b82
In-Reply-To: <519C4D01.40900@oracle.com>
References: <519A78F4.4010909@oracle.com> <519A9D5B.7060705@oracle.com>
	<519BB59E.3020801@oracle.com> <519BD13B.8030502@oracle.com>
	<519C4D01.40900@oracle.com>
Message-ID: <519CE166.7050204@oracle.com>

Latest webrev is here: 
http://cr.openjdk.java.net/~jprovino/8011064/webrev.02

joe


On 5/22/2013 12:43 AM, David Holmes wrote:
> Just for the benefit of others watching this, the undef approach is 
> not ideal and there's another alternative in the pipeline.
>
> David
>
> On 22/05/2013 5:55 AM, JOSEPH PROVINO wrote:
>> New webrev is here:
>>
>> http://cr.openjdk.java.net/~jprovino/8011064/webrev.01/
>>
>> joe
>>
>> On 5/21/2013 1:57 PM, JOSEPH PROVINO wrote:
>>> That's a good solution.  Is there any reason NMT_detail_supported
>>> can't be made const or
>>> better yet eliminate the variable and just use if
>>> (PLATFORM_NMT_DETAIL_SUPPORTED) ?
>>>
>>> joe
>>>
>>> On 5/20/2013 6:02 PM, BILL PITTORE wrote:
>>>>  Maybe something like I did for SUPPORTS_NATIVE_CX8. This gets
>>>> defined in globalDefinitions_<cpu>.hpp.
>>>> In this situation maybe something like:
>>>>
>>>> memTracker.cpp
>>>>   bool NMT_detail_supported = PLATFORM_NMT_DETAIL_SUPPORTED;
>>>>
>>>> then in globalDefinitions_<cpu>.hpp
>>>>
>>>> #define PLATFORM_NMT_DETAIL_SUPPORTED {true | false} as the case 
>>>> may be.
>>>>
>>>> Then you eliminate the need to add code to pd_initialize()
>>>>
>>>> bill
>>>>
>>>> On 5/20/2013 3:26 PM, JOSEPH PROVINO wrote:
>>>>> Make it easy to disable NMT detail in platform specific code.
>>>>>
>>>>> A new variable NMT_detail_supported is defined and set to true.
>>>>> It can be disabled in platform specific code as needed.
>>>>>
>>>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8011064/webrev/
>>>>>
>>>>> JDK-8011064 <https://jbs.oracle.com/bugs/browse/JDK-8011064>Some
>>>>> tests have failed with SIGSEGV on arm-hflt on build b82
>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8011064>
>>>>
>>>>
>>>
>>


From rickard.backman at oracle.com  Wed May 22 08:19:37 2013
From: rickard.backman at oracle.com (rickard.backman at oracle.com)
Date: Wed, 22 May 2013 15:19:37 +0000
Subject: hg: hsx/hotspot-main/hotspot: 16 new changesets
Message-ID: <20130522152018.EEF2148C40@hg.openjdk.java.net>

Changeset: f49e0508a38a
Author:    rbackman
Date:      2013-05-15 11:30 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f49e0508a38a

4965252: JvmtiExport::post_raw_field_modification jni ref handling is odd
Reviewed-by: coleenp, sspitsyn

! src/share/vm/prims/jvmtiExport.cpp

Changeset: 243469d929e6
Author:    ctornqvi
Date:      2013-05-16 15:31 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/243469d929e6

8008169: test/runtime/7158804/Test7158804.sh has bad copyright header
Summary: Re-wrote test in Java in addition to fixing the Copyright notice. Also reviewed by leonid.mesnik at oracle.com
Reviewed-by: coleenp, ctornqvi
Contributed-by: Mikhailo Seledtsov <mikhailo.seledtsov at oracle.com>

- test/runtime/7158804/Test7158804.sh
+ test/runtime/CommandLine/ConfigFileParsing.java

Changeset: 17db82f22f1e
Author:    ctornqvi
Date:      2013-05-16 17:54 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/17db82f22f1e

8014511: runtime/RedefineObject/TestRedefineObject.java has incorrect classname in @run tag
Summary: Corrected the class name
Reviewed-by: coleenp, ctornqvi, hseigel
Contributed-by: Mikhailo Seledtsov <mikhailo.seledtsov at oracle.com>

! test/runtime/RedefineObject/TestRedefineObject.java

Changeset: 78332b46e604
Author:    kevinw
Date:      2013-05-16 12:40 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/78332b46e604

6313816: SA: jstack -m fails on Win32 : UnalignedAddressException
Reviewed-by: sla, poonam

- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java
- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java
! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgCDebugger.java
+ agent/src/share/classes/sun/jvm/hotspot/debugger/windows/amd64/WindowsAMD64CFrame.java
+ agent/src/share/classes/sun/jvm/hotspot/debugger/windows/x86/WindowsX86CFrame.java
! make/sa.files

Changeset: 205dd30230e1
Author:    shade
Date:      2013-05-17 01:43 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/205dd30230e1

8012939: @Contended doesn't work correctly with inheritance
Summary: Fix instance_size miscalculation.
Reviewed-by: jrose, kvn

! src/share/vm/classfile/classFileParser.cpp
+ test/runtime/contended/Inheritance1.java

Changeset: b334821dad92
Author:    dholmes
Date:      2013-05-16 21:19 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b334821dad92

Merge


Changeset: 50e9396d5257
Author:    shade
Date:      2013-05-17 01:58 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/50e9396d5257

8014509: @Contended: explicit default value behaves differently from the implicit value
Summary: Treat the empty string as the default value tag
Reviewed-by: kvn, twisti

! src/share/vm/classfile/classFileParser.cpp
+ test/runtime/contended/DefaultValue.java

Changeset: 074ba6269cf4
Author:    dholmes
Date:      2013-05-16 22:11 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/074ba6269cf4

Merge

- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java
- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java

Changeset: 1ba508fcd3e2
Author:    dholmes
Date:      2013-05-16 23:40 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/1ba508fcd3e2

Merge


Changeset: 6ce351ac7339
Author:    rdurbin
Date:      2013-05-17 08:51 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/6ce351ac7339

7145527: sscanf must use a length in the format string
Summary: Remove dead code containing last call to scanf with no string length specifier
Reviewed-by: dcubed, coleenp

! src/share/vm/utilities/debug.cpp

Changeset: a250c89cf9e3
Author:    dcubed
Date:      2013-05-17 08:56 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a250c89cf9e3

Merge


Changeset: b5be63340698
Author:    dcubed
Date:      2013-05-17 11:36 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b5be63340698

Merge

- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java
- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java
! src/share/vm/classfile/classFileParser.cpp
- test/runtime/7158804/Test7158804.sh

Changeset: 386b77bf6427
Author:    dcubed
Date:      2013-05-17 17:52 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/386b77bf6427

Merge

- make/bsd/makefiles/launcher.make
- make/linux/makefiles/launcher.make
- make/solaris/makefiles/launcher.make
- make/windows/makefiles/launcher.make
- src/os/posix/launcher/java_md.c
- src/os/posix/launcher/java_md.h
- src/os/posix/launcher/launcher.script
- src/os/windows/launcher/java_md.c
- src/os/windows/launcher/java_md.h
- src/share/tools/launcher/java.c
- src/share/tools/launcher/java.h
- src/share/tools/launcher/jli_util.c
- src/share/tools/launcher/jli_util.h
- src/share/tools/launcher/wildcard.c
- src/share/tools/launcher/wildcard.h
- src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp

Changeset: a5d6f0c3585f
Author:    iklam
Date:      2013-05-18 20:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a5d6f0c3585f

8014262: PrintStringTableStatistics should include more footprint info
Summary: Added info for the string/symbol objects and the hash entries
Reviewed-by: coleenp, rbackman

! src/share/vm/classfile/symbolTable.cpp
! src/share/vm/utilities/hashtable.cpp
! src/share/vm/utilities/hashtable.hpp

Changeset: 5e3573e08a83
Author:    shade
Date:      2013-05-20 15:43 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/5e3573e08a83

8014871: Move @Contended regression tests to the same place
Summary: Move the missing test to appropriate location.
Reviewed-by: dholmes, sla

- test/runtime/8003985/Test8003985.java
+ test/runtime/contended/Basic.java

Changeset: bbddfb08190f
Author:    shade
Date:      2013-05-20 23:41 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/bbddfb08190f

8014878: Clean up class field layout code
Summary: rename/remove local variables, re-arrange instance_size calculation, more comments.
Reviewed-by: kvn, coleenp

! src/share/vm/classfile/classFileParser.cpp


From aleksey.shipilev at oracle.com  Wed May 22 09:07:47 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Wed, 22 May 2013 20:07:47 +0400
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
In-Reply-To: <519B8832.50105@oracle.com>
References: <519A4B39.20208@oracle.com> <519AF0D4.4080102@oracle.com>
	<519B3879.1050301@oracle.com> <519B8760.6000109@oracle.com>
	<519B8832.50105@oracle.com>
Message-ID: <519CED53.2010408@oracle.com>

Still waiting for the second reviewer.
I think Runtime team wants to review this?

-Aleksey.

On 05/21/2013 06:44 PM, Aleksey Shipilev wrote:
> Thanks!
> 
> We need second reviewer.
> 
> -Aleksey.
> 
> On 05/21/2013 06:40 PM, Vladimir Kozlov wrote:
>> Code is good.
>>
>> On 5/21/13 2:03 AM, Aleksey Shipilev wrote:
>>> Thanks Vladimir!
>>>
>>> The updated webrev is here:
>>>    http://cr.openjdk.java.net/~shade/8014886/webrev.02/
> 
> -Aleksey.
> 


From joseph.provino at oracle.com  Wed May 22 12:27:12 2013
From: joseph.provino at oracle.com (Joseph Provino)
Date: Wed, 22 May 2013 15:27:12 -0400
Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace
	in libjvm.symbols that does not exist in minimal/libjvm.a when
	DEBUG_LEVEL == release
In-Reply-To: <519BDE85.6000005@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
	<519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com>
	<5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com>
	<519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com>
	<519BC8A8.5060909@oracle.com> <519BD250.10302@oracle.com>
	<519BDE85.6000005@oracle.com>
Message-ID: <519D1C10.90302@oracle.com>

Is there a consensus what is in the webrev is okay?

The change is to include forte.cpp in the minimal jvm but to
conditionalize the code so that only AsyncGetCallTrace()
is defined with the minimal jvm.

Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.01

     JDK-8013461 https://jbs.oracle.com/bugs/browse/JDK-8013461
     There is a symbol AsyncGetCallTrace in libjvm.symbols that does not 
exist in
     minimal/libjvm.a when DEBUG_LEVEL == release

joe

On 05/21/2013 04:52 PM, JOSEPH PROVINO wrote:
>
> On 5/21/2013 4:00 PM, Oleg Mazurov wrote:
>> Though formally not part of the Solaris Studio team any more here is 
>> my opinion based on my recollection of how I implemented interaction 
>> with the JVM via AsyncGetCallTrace.
>> It's looked up using dlsym. If the symbol is not there Java callstack 
>> collection is shut down. I understand in your case even JVMTI is not 
>> there so the dlsym call will not be made.
>> From that perspective there is no difference whether the symbol is 
>> present and returns an error code or not present at all.
>
> Oleg, then it sounds like what we have will work.
>
> Thanks for the quick reply.
>
> joe
>
>>
>>     -- Oleg
>>
>> On 5/21/2013 12:19 PM, JOSEPH PROVINO wrote:
>>>
>>> On 5/21/2013 3:16 PM, serguei.spitsyn at oracle.com wrote:
>>>> On 5/21/13 11:26 AM, JOSEPH PROVINO wrote:
>>>>>
>>>>> On 5/21/2013 2:23 PM, Staffan Larsen wrote:
>>>>>> On 21 maj 2013, at 17:35, JOSEPH PROVINO 
>>>>>> <joseph.provino at oracle.com> wrote:
>>>>>>
>>>>>>> On 5/21/2013 3:06 AM, David Holmes wrote:
>>>>>>>> Hi Staffan,
>>>>>>>>
>>>>>>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote:
>>>>>>>>> On 21 maj 2013, at 04:34, David Holmes 
>>>>>>>>> <David.Holmes at oracle.com> wrote:
>>>>>>>>>
>>>>>>>>>> <added servicability>
>>>>>>>>>>
>>>>>>>>>> Hi Joe,
>>>>>>>>>>
>>>>>>>>>> As I have previously stated you copied the struct definitions 
>>>>>>>>>> instead of moving them outside the ifdef.
>>>>>>>>>>
>>>>>>>>>> Serviceability folk: we are particularly interested in 
>>>>>>>>>> whether the use of ticks_no_class_load is deemed appropriate 
>>>>>>>>>> in this situation. Who will be consuming this value?
>>>>>>>>> Since you have opted for the simple fix of having an exported 
>>>>>>>>> but non-functional AsyncGetCallTrace instead of actually 
>>>>>>>>> removing the symbol from the symbol files (which is the 
>>>>>>>>> proposed solution in the bug report),
>>>>>>>> That would be a simpler solution semantically but the only way 
>>>>>>>> I can see to do that is to use a text replacement mechanism in 
>>>>>>>> the build files - as is done for the dynamic vtable symbols. I 
>>>>>>>> find that less appealing than simply exporting an interface 
>>>>>>>> that is configured to report an error (which is essentially 
>>>>>>>> what all the optional interfaces do under the minimal VM).
>>>>>>>>
>>>>>>>>> I would like you to include a comment about this in the 
>>>>>>>>> source. Right now it's very unclear why there is an exported 
>>>>>>>>> function that only returns an error.
>>>>>>>>>
>>>>>>>>> As to the appropriate return value, I don't know. The only 
>>>>>>>>> caller should be the Sun Studio profiler,
>>>>> Does anyone know where to find instructions on how to run the 
>>>>> collector which would get the error return value?
>>>>>>>>>   and I'm not sure how it will handle this case if ever run. 
>>>>>>>>> The possible return values aren't very well documented.
>>>>>>>> I guess we need to try and run it to find out.
>>>>>>> Okay, do either of you feel strongly about how this should be 
>>>>>>> fixed -- return an error or remove the symbol?
>>>>>> No, I don't feel strongly either way, but a comment in the code 
>>>>>> would be nice.
>>>>> How much effort should I put into finding out what Sun Studio 
>>>>> profiler does when it gets -1?
>>>>
>>>> Let's ask the Solaris Studio guys directly.
>>>> I'm adding Oleg to the mailing list.
>>>>
>>>> Oleg,
>>>>
>>>> Could you, please, share your view on this problem?
>>>
>>> In particular what will the Sun Studio Profiler collector do if it 
>>> gets the error
>>>
>>> trace->num_frames = ticks_no_class_load; // -1
>>>
>>> Thanks.
>>>
>>> joe
>>>
>>>>
>>>>
>>>> Thanks,
>>>> Serguei
>>>>
>>>>
>>>>
>>>>
>>>>>
>>>>> joe
>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> /Staffan
>>>>>>
>>>>>>
>>>>>>> joe
>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> David
>>>>>>>>
>>>>>>>>> /Staffan
>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>> David
>>>>>>>>>>
>>>>>>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>>>>>>>>>>> The change is to include forte.cpp in the minimal jvm but to
>>>>>>>>>>> conditionalize the code so that
>>>>>>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>>>>>>>>>>
>>>>>>>>>>> Webrev is here: 
>>>>>>>>>>> http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>>>>>>>>>>
>>>>>>>>>>>   * JDK-8013461 
>>>>>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>>>>>>>>>>     a symbol AsyncGetCallTrace in libjvm.symbols that does 
>>>>>>>>>>> not exist in
>>>>>>>>>>>     minimal/libjvm.a when DEBUG_LEVEL == release
>>>>>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>>>>>>>>>>
>>>>>>>>>>> Thanks.
>>>>>>>>>>>
>>>>>>>>>>> joe
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>
>>>>
>>>
>>
>


From bob.vandette at oracle.com  Wed May 22 13:27:45 2013
From: bob.vandette at oracle.com (Bob Vandette)
Date: Wed, 22 May 2013 16:27:45 -0400
Subject: review request for JDK-8013461 There is a symbol
	AsyncGetCallTrace in libjvm.symbols that does not exist in
	minimal/libjvm.a when DEBUG_LEVEL == release
In-Reply-To: <519D1C10.90302@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
	<519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com>
	<5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com>
	<519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com>
	<519BC8A8.5060909@oracle.com> <519BD250.10302@oracle.com>
	<519BDE85.6000005@oracle.com> <519D1C10.90302@oracle.com>
Message-ID: <BD695235-413E-4EB3-BA07-AC0C3A8A71A0@oracle.com>

Joe,

I'm ok with this approach.

Bob.

On May 22, 2013, at 3:27 PM, Joseph Provino wrote:

> Is there a consensus what is in the webrev is okay?
> 
> The change is to include forte.cpp in the minimal jvm but to
> conditionalize the code so that only AsyncGetCallTrace()
> is defined with the minimal jvm.
> 
> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.01
> 
>    JDK-8013461 https://jbs.oracle.com/bugs/browse/JDK-8013461
>    There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in
>    minimal/libjvm.a when DEBUG_LEVEL == release
> 
> joe
> 
> On 05/21/2013 04:52 PM, JOSEPH PROVINO wrote:
>> 
>> On 5/21/2013 4:00 PM, Oleg Mazurov wrote:
>>> Though formally not part of the Solaris Studio team any more here is my opinion based on my recollection of how I implemented interaction with the JVM via AsyncGetCallTrace.
>>> It's looked up using dlsym. If the symbol is not there Java callstack collection is shut down. I understand in your case even JVMTI is not there so the dlsym call will not be made.
>>> From that perspective there is no difference whether the symbol is present and returns an error code or not present at all.
>> 
>> Oleg, then it sounds like what we have will work.
>> 
>> Thanks for the quick reply.
>> 
>> joe
>> 
>>> 
>>>    -- Oleg
>>> 
>>> On 5/21/2013 12:19 PM, JOSEPH PROVINO wrote:
>>>> 
>>>> On 5/21/2013 3:16 PM, serguei.spitsyn at oracle.com wrote:
>>>>> On 5/21/13 11:26 AM, JOSEPH PROVINO wrote:
>>>>>> 
>>>>>> On 5/21/2013 2:23 PM, Staffan Larsen wrote:
>>>>>>> On 21 maj 2013, at 17:35, JOSEPH PROVINO <joseph.provino at oracle.com> wrote:
>>>>>>> 
>>>>>>>> On 5/21/2013 3:06 AM, David Holmes wrote:
>>>>>>>>> Hi Staffan,
>>>>>>>>> 
>>>>>>>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote:
>>>>>>>>>> On 21 maj 2013, at 04:34, David Holmes <David.Holmes at oracle.com> wrote:
>>>>>>>>>> 
>>>>>>>>>>> <added servicability>
>>>>>>>>>>> 
>>>>>>>>>>> Hi Joe,
>>>>>>>>>>> 
>>>>>>>>>>> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef.
>>>>>>>>>>> 
>>>>>>>>>>> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value?
>>>>>>>>>> Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report),
>>>>>>>>> That would be a simpler solution semantically but the only way I can see to do that is to use a text replacement mechanism in the build files - as is done for the dynamic vtable symbols. I find that less appealing than simply exporting an interface that is configured to report an error (which is essentially what all the optional interfaces do under the minimal VM).
>>>>>>>>> 
>>>>>>>>>> I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error.
>>>>>>>>>> 
>>>>>>>>>> As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler,
>>>>>> Does anyone know where to find instructions on how to run the collector which would get the error return value?
>>>>>>>>>>  and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented.
>>>>>>>>> I guess we need to try and run it to find out.
>>>>>>>> Okay, do either of you feel strongly about how this should be fixed -- return an error or remove the symbol?
>>>>>>> No, I don't feel strongly either way, but a comment in the code would be nice.
>>>>>> How much effort should I put into finding out what Sun Studio profiler does when it gets -1?
>>>>> 
>>>>> Let's ask the Solaris Studio guys directly.
>>>>> I'm adding Oleg to the mailing list.
>>>>> 
>>>>> Oleg,
>>>>> 
>>>>> Could you, please, share your view on this problem?
>>>> 
>>>> In particular what will the Sun Studio Profiler collector do if it gets the error
>>>> 
>>>> trace->num_frames = ticks_no_class_load; // -1
>>>> 
>>>> Thanks.
>>>> 
>>>> joe
>>>> 
>>>>> 
>>>>> 
>>>>> Thanks,
>>>>> Serguei
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>>> 
>>>>>> joe
>>>>>> 
>>>>>>> 
>>>>>>> Thanks,
>>>>>>> /Staffan
>>>>>>> 
>>>>>>> 
>>>>>>>> joe
>>>>>>>> 
>>>>>>>>> Thanks,
>>>>>>>>> David
>>>>>>>>> 
>>>>>>>>>> /Staffan
>>>>>>>>>> 
>>>>>>>>>>> Thanks,
>>>>>>>>>>> David
>>>>>>>>>>> 
>>>>>>>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>>>>>>>>>>>> The change is to include forte.cpp in the minimal jvm but to
>>>>>>>>>>>> conditionalize the code so that
>>>>>>>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>>>>>>>>>>> 
>>>>>>>>>>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>>>>>>>>>>> 
>>>>>>>>>>>>  * JDK-8013461 <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>>>>>>>>>>>    a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in
>>>>>>>>>>>>    minimal/libjvm.a when DEBUG_LEVEL == release
>>>>>>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>>>>>>>>>>> 
>>>>>>>>>>>> Thanks.
>>>>>>>>>>>> 
>>>>>>>>>>>> joe
>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>> 
>>>>> 
>>>> 
>>> 
>> 
> 


From aleksey.shipilev at oracle.com  Wed May 22 14:16:43 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Thu, 23 May 2013 01:16:43 +0400
Subject: RFR (S) CR 8014964: @Contended breaks has_nonstatic_fields
	invariant
In-Reply-To: <519B9D78.70107@oracle.com>
References: <519B5BE4.90009@oracle.com> <519B8B1F.20204@oracle.com>
	<519B8F91.7060604@oracle.com> <519B9BA3.5070404@oracle.com>
	<519B9D78.70107@oracle.com>
Message-ID: <519D35BB.80009@oracle.com>

Thanks for the ideas!

On 05/21/2013 08:14 PM, Vladimir Kozlov wrote:
>> Could you move third check on next line so you can see all on one screen?

Done.

>> You are right. So parsed_annotations->is_contended() is true for any
>> combinations of class and fields annotation. Right?

(parsed_annotations->is_contended() == true) iff (@Contended on class).

This is yet another thing to clean up.

>> This could be affected by alignment even more than your assert. Could
>> you look?

Hm... Ok, I can compare against the non-aligned offset. It can only not
equal the start if we do indeed have the fields.

But nonstatic_field_size still has the same problem. Moreover, assert
would seem to fail even in the simple case when the super-class is
@Contended; added the test case for that (class R4).

This is the current webrev:
  http://cr.openjdk.java.net/~shade/8014964/webrev.03/

Testing:
  - hotspot/test/runtime/contended/ regression tests (failing)
  - JPRT cycle vs hotspot-rt is running now  (just in case)

I actually start to wonder if no size/offset is reliable for this
assert; and counting the fields will yield the same expression over
fac[...], which is dumb to assert. The asserts there are only to fire
the regression test. Hence, this might seem to be that rare case where
the regression test is impractical?

-Aleksey.

From serguei.spitsyn at oracle.com  Wed May 22 14:32:40 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Wed, 22 May 2013 14:32:40 -0700
Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace
	in libjvm.symbols that does not exist in minimal/libjvm.a when
	DEBUG_LEVEL == release
In-Reply-To: <519D1C10.90302@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
	<519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com>
	<5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com>
	<519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com>
	<519BC8A8.5060909@oracle.com> <519BD250.10302@oracle.com>
	<519BDE85.6000005@oracle.com> <519D1C10.90302@oracle.com>
Message-ID: <519D3978.7000008@oracle.com>

The fix is good.

Thanks,
Serguei


On 5/22/13 12:27 PM, Joseph Provino wrote:
> Is there a consensus what is in the webrev is okay?
>
> The change is to include forte.cpp in the minimal jvm but to
> conditionalize the code so that only AsyncGetCallTrace()
> is defined with the minimal jvm.
>
> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.01
>
>     JDK-8013461 https://jbs.oracle.com/bugs/browse/JDK-8013461
>     There is a symbol AsyncGetCallTrace in libjvm.symbols that does 
> not exist in
>     minimal/libjvm.a when DEBUG_LEVEL == release
>
> joe
>
> On 05/21/2013 04:52 PM, JOSEPH PROVINO wrote:
>>
>> On 5/21/2013 4:00 PM, Oleg Mazurov wrote:
>>> Though formally not part of the Solaris Studio team any more here is 
>>> my opinion based on my recollection of how I implemented interaction 
>>> with the JVM via AsyncGetCallTrace.
>>> It's looked up using dlsym. If the symbol is not there Java 
>>> callstack collection is shut down. I understand in your case even 
>>> JVMTI is not there so the dlsym call will not be made.
>>> From that perspective there is no difference whether the symbol is 
>>> present and returns an error code or not present at all.
>>
>> Oleg, then it sounds like what we have will work.
>>
>> Thanks for the quick reply.
>>
>> joe
>>
>>>
>>>     -- Oleg
>>>
>>> On 5/21/2013 12:19 PM, JOSEPH PROVINO wrote:
>>>>
>>>> On 5/21/2013 3:16 PM, serguei.spitsyn at oracle.com wrote:
>>>>> On 5/21/13 11:26 AM, JOSEPH PROVINO wrote:
>>>>>>
>>>>>> On 5/21/2013 2:23 PM, Staffan Larsen wrote:
>>>>>>> On 21 maj 2013, at 17:35, JOSEPH PROVINO 
>>>>>>> <joseph.provino at oracle.com> wrote:
>>>>>>>
>>>>>>>> On 5/21/2013 3:06 AM, David Holmes wrote:
>>>>>>>>> Hi Staffan,
>>>>>>>>>
>>>>>>>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote:
>>>>>>>>>> On 21 maj 2013, at 04:34, David Holmes 
>>>>>>>>>> <David.Holmes at oracle.com> wrote:
>>>>>>>>>>
>>>>>>>>>>> <added servicability>
>>>>>>>>>>>
>>>>>>>>>>> Hi Joe,
>>>>>>>>>>>
>>>>>>>>>>> As I have previously stated you copied the struct 
>>>>>>>>>>> definitions instead of moving them outside the ifdef.
>>>>>>>>>>>
>>>>>>>>>>> Serviceability folk: we are particularly interested in 
>>>>>>>>>>> whether the use of ticks_no_class_load is deemed appropriate 
>>>>>>>>>>> in this situation. Who will be consuming this value?
>>>>>>>>>> Since you have opted for the simple fix of having an exported 
>>>>>>>>>> but non-functional AsyncGetCallTrace instead of actually 
>>>>>>>>>> removing the symbol from the symbol files (which is the 
>>>>>>>>>> proposed solution in the bug report),
>>>>>>>>> That would be a simpler solution semantically but the only way 
>>>>>>>>> I can see to do that is to use a text replacement mechanism in 
>>>>>>>>> the build files - as is done for the dynamic vtable symbols. I 
>>>>>>>>> find that less appealing than simply exporting an interface 
>>>>>>>>> that is configured to report an error (which is essentially 
>>>>>>>>> what all the optional interfaces do under the minimal VM).
>>>>>>>>>
>>>>>>>>>> I would like you to include a comment about this in the 
>>>>>>>>>> source. Right now it's very unclear why there is an exported 
>>>>>>>>>> function that only returns an error.
>>>>>>>>>>
>>>>>>>>>> As to the appropriate return value, I don't know. The only 
>>>>>>>>>> caller should be the Sun Studio profiler,
>>>>>> Does anyone know where to find instructions on how to run the 
>>>>>> collector which would get the error return value?
>>>>>>>>>>   and I'm not sure how it will handle this case if ever run. 
>>>>>>>>>> The possible return values aren't very well documented.
>>>>>>>>> I guess we need to try and run it to find out.
>>>>>>>> Okay, do either of you feel strongly about how this should be 
>>>>>>>> fixed -- return an error or remove the symbol?
>>>>>>> No, I don't feel strongly either way, but a comment in the code 
>>>>>>> would be nice.
>>>>>> How much effort should I put into finding out what Sun Studio 
>>>>>> profiler does when it gets -1?
>>>>>
>>>>> Let's ask the Solaris Studio guys directly.
>>>>> I'm adding Oleg to the mailing list.
>>>>>
>>>>> Oleg,
>>>>>
>>>>> Could you, please, share your view on this problem?
>>>>
>>>> In particular what will the Sun Studio Profiler collector do if it 
>>>> gets the error
>>>>
>>>> trace->num_frames = ticks_no_class_load; // -1
>>>>
>>>> Thanks.
>>>>
>>>> joe
>>>>
>>>>>
>>>>>
>>>>> Thanks,
>>>>> Serguei
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>>
>>>>>> joe
>>>>>>
>>>>>>>
>>>>>>> Thanks,
>>>>>>> /Staffan
>>>>>>>
>>>>>>>
>>>>>>>> joe
>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> David
>>>>>>>>>
>>>>>>>>>> /Staffan
>>>>>>>>>>
>>>>>>>>>>> Thanks,
>>>>>>>>>>> David
>>>>>>>>>>>
>>>>>>>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>>>>>>>>>>>> The change is to include forte.cpp in the minimal jvm but to
>>>>>>>>>>>> conditionalize the code so that
>>>>>>>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>>>>>>>>>>>
>>>>>>>>>>>> Webrev is here: 
>>>>>>>>>>>> http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>>>>>>>>>>>
>>>>>>>>>>>>   * JDK-8013461 
>>>>>>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>>>>>>>>>>>     a symbol AsyncGetCallTrace in libjvm.symbols that does 
>>>>>>>>>>>> not exist in
>>>>>>>>>>>>     minimal/libjvm.a when DEBUG_LEVEL == release
>>>>>>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks.
>>>>>>>>>>>>
>>>>>>>>>>>> joe
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>


From daniel.daugherty at oracle.com  Wed May 22 15:09:26 2013
From: daniel.daugherty at oracle.com (Daniel D. Daugherty)
Date: Wed, 22 May 2013 16:09:26 -0600
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
In-Reply-To: <519B3879.1050301@oracle.com>
References: <519A4B39.20208@oracle.com> <519AF0D4.4080102@oracle.com>
	<519B3879.1050301@oracle.com>
Message-ID: <519D4216.2060906@oracle.com>

On 5/21/13 3:03 AM, Aleksey Shipilev wrote:
> Thanks Vladimir!
>
> The updated webrev is here:
>    http://cr.openjdk.java.net/~shade/8014886/webrev.02/

hotspot/src/share/vm/classfile/classFileParser.cpp
     I'm OK with the switch back to the original size calculation
     (now in max_nonstatic_oop_maps). I'm also happy with the
     new asserts.

hotspot/test/runtime/contended/OopMaps.java
     Thanks for verifying that the new test fires the new asserts

For testing you listed:

 >  - new regression test added, fails on new asserts
 >  - Linux x86_64/fastdebug runtime/contended/ tests
 >  - full JPRT cycle against hotspot-rt

which does not include the vm.quick testsuite which is minimum
testing required for RT_Baseline pushes unless the change is
trivial. I don't think anything associated with the @Contended
work can be considered trivial so I would like to see vm.quick
testing done on two platforms. One of those platforms should
be Windows since it is known to be quirky with oopmaps.


Just to review the bidding on the already filed or promised new bugs:

0) refactor the entire _count handling during the class field
    layout cleanup (JDK-8014878)

1) prune the "+ 1" from the max_nonstatic_oop_maps or add a
    comment to justify why it is there

2) current code allocates oopmap per contended oop fields even fields
    in one group (not separated by padding) - tighten this up

3) has_nonstatic_fields is also wrong (JDK-8014964)

Do you have a planned time frame or time frames for these bugs?

Dan





>
> On 05/21/2013 07:58 AM, Vladimir Kozlov wrote:
>> Is not has_nonstatic_fields also wrong?
> Yes, it is. I haven't fixed this here for three reasons:
>   a) this is not about oop maps
>   b) tracked down the impact through the HS code, seems minimal
>   c) because of (b): I'm still trying to get proper regression test for
> has_nonstatic_fields ready
>
> I will post another CR for fixing that one up.
>
>> Rename: max_oop_maps -> max_nonstatic_oop_maps.
> Done.
>
>> For FieldsAllocationStyle=2 (default) we do special oop fields layout
>> for super and subclass to have only one oopmap. You need to add non-oop
>> fields (class in your test has only oop fields) to test different layouts.
> Done. I had also the super-class to get the oops aligned in the oop chunk.
>
>> Next added mess to already complicated code:
>>
>> 3188   unsigned int nonstatic_double_count =
>> fac->count[NONSTATIC_DOUBLE] - fac_contended.count[NONSTATIC_DOUBLE];
>> 3189   unsigned int nonstatic_word_count   = fac->count[NONSTATIC_WORD]
>>    - fac_contended.count[NONSTATIC_WORD];
>> 3190   unsigned int nonstatic_short_count  = fac->count[NONSTATIC_SHORT]
>>   - fac_contended.count[NONSTATIC_SHORT];
>> 3191   unsigned int nonstatic_byte_count   = fac->count[NONSTATIC_BYTE]
>>    - fac_contended.count[NONSTATIC_BYTE];
>> 3192   unsigned int nonstatic_oop_count    = fac->count[NONSTATIC_OOP]
>> - fac_contended.count[NONSTATIC_OOP];
>> At least add comment that these counts are for not contended fields.
> Already taken care of in the baseline: there is a terse comment. I will
> clean up that mess during further cleanup work. The regression tests
> like this one will help to build enough safety net for the refactoring.
>
> -Aleksey.
>


From vladimir.kozlov at oracle.com  Wed May 22 15:09:49 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Wed, 22 May 2013 15:09:49 -0700
Subject: RFR (S) CR 8014964: @Contended breaks has_nonstatic_fields
	invariant
In-Reply-To: <519D35BB.80009@oracle.com>
References: <519B5BE4.90009@oracle.com> <519B8B1F.20204@oracle.com>
	<519B8F91.7060604@oracle.com> <519B9BA3.5070404@oracle.com>
	<519B9D78.70107@oracle.com> <519D35BB.80009@oracle.com>
Message-ID: <519D422D.5050707@oracle.com>

On 5/22/13 2:16 PM, Aleksey Shipilev wrote:
> Thanks for the ideas!
>
> On 05/21/2013 08:14 PM, Vladimir Kozlov wrote:
>>> Could you move third check on next line so you can see all on one screen?
>
> Done.
>
>>> You are right. So parsed_annotations->is_contended() is true for any
>>> combinations of class and fields annotation. Right?
>
> (parsed_annotations->is_contended() == true) iff (@Contended on class).
>
> This is yet another thing to clean up.

Okay.

>>> This could be affected by alignment even more than your assert. Could
>>> you look?
>
> Hm... Ok, I can compare against the non-aligned offset. It can only not
> equal the start if we do indeed have the fields.

Good idea with notaligned_*_end variable.

>
> But nonstatic_field_size still has the same problem. Moreover, assert
> would seem to fail even in the simple case when the super-class is
> @Contended; added the test case for that (class R4).
>
> This is the current webrev:
>    http://cr.openjdk.java.net/~shade/8014964/webrev.03/

Looks good.

>
> Testing:
>    - hotspot/test/runtime/contended/ regression tests (failing)

Could you run all hotspot/test tests (you have to list them)? It should 
not take long.

>    - JPRT cycle vs hotspot-rt is running now  (just in case)
>
> I actually start to wonder if no size/offset is reliable for this
> assert; and counting the fields will yield the same expression over
> fac[...], which is dumb to assert. The asserts there are only to fire
> the regression test. Hence, this might seem to be that rare case where
> the regression test is impractical?

The asserts and test are a protection from future bugs in this code (as 
most of other asserts in VM). This code is complex and is easy to screw 
up :)

Thanks,
Vladimir

>
> -Aleksey.
>

From aleksey.shipilev at oracle.com  Wed May 22 15:31:35 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Thu, 23 May 2013 02:31:35 +0400
Subject: RFR (S) CR 8014964: @Contended breaks has_nonstatic_fields
	invariant
In-Reply-To: <519D422D.5050707@oracle.com>
References: <519B5BE4.90009@oracle.com> <519B8B1F.20204@oracle.com>
	<519B8F91.7060604@oracle.com> <519B9BA3.5070404@oracle.com>
	<519B9D78.70107@oracle.com> <519D35BB.80009@oracle.com>
	<519D422D.5050707@oracle.com>
Message-ID: <519D4747.5050306@oracle.com>

On 05/23/2013 02:09 AM, Vladimir Kozlov wrote:
>> Testing:
>>    - hotspot/test/runtime/contended/ regression tests (failing)
> 
> Could you run all hotspot/test tests (you have to list them)? It should
> not take long.

Yes, I can. Let me re-spin the testing for this one.

>>    - JPRT cycle vs hotspot-rt is running now  (just in case)
>>
>> I actually start to wonder if no size/offset is reliable for this
>> assert; and counting the fields will yield the same expression over
>> fac[...], which is dumb to assert. The asserts there are only to fire
>> the regression test. Hence, this might seem to be that rare case where
>> the regression test is impractical?
> 
> The asserts and test are a protection from future bugs in this code (as
> most of other asserts in VM). This code is complex and is easy to screw
> up :)

Yes, I know that. My inclination though is to omit the assert for
has_nonstatic_fields, because we can not reliably assert it. For
example, if you run the valid regression test (contended/HasNonStatic),
it will fail on that assert. Am I missing some good way to test
has_nonstatic_fields without putting exactly the same expression over
fac[...] in the assert?

-Aleksey.

From aleksey.shipilev at oracle.com  Wed May 22 15:38:30 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Thu, 23 May 2013 02:38:30 +0400
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
In-Reply-To: <519D4216.2060906@oracle.com>
References: <519A4B39.20208@oracle.com> <519AF0D4.4080102@oracle.com>
	<519B3879.1050301@oracle.com> <519D4216.2060906@oracle.com>
Message-ID: <519D48E6.9090801@oracle.com>

Thanks for the review!

On 05/23/2013 02:09 AM, Daniel D. Daugherty wrote:
> which does not include the vm.quick testsuite which is minimum
> testing required for RT_Baseline pushes unless the change is
> trivial. 

Fair enough.
I'll get back with the test results as soon as I able to run vm.quick.

> Do you have a planned time frame or time frames for these bugs?

Let me submit the remaining issues to the bugtracker to keep the things
in order tomorrow. I think all the functional bugfixes will be ready
early next week. What's the hotspot-rt -> hotspot-main merge window? I
would certainly like to have a few nightlies before those get into hs-main.

Other issues can wait till the next integration window. (And being the
cleanups, they will naturally entail some bike-shedding).

-Aleksey.

From coleen.phillimore at oracle.com  Wed May 22 15:40:52 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Wed, 22 May 2013 18:40:52 -0400
Subject: RFR (S) CR 8014964: @Contended breaks has_nonstatic_fields
	invariant
In-Reply-To: <519D35BB.80009@oracle.com>
References: <519B5BE4.90009@oracle.com> <519B8B1F.20204@oracle.com>
	<519B8F91.7060604@oracle.com> <519B9BA3.5070404@oracle.com>
	<519B9D78.70107@oracle.com> <519D35BB.80009@oracle.com>
Message-ID: <519D4974.6010303@oracle.com>


I've been reviewing 8014886 for a few hours which is in similar code to 
this code.   The change for 8014886 appears to still have the bug that 
you have at lines 3194.   Why are these separate changes?   Can you make 
one set of changes that fixes all of the problems in these Contended 
tests?   Are these contended tests being added to our hotspot/test tests?

http://cr.openjdk.java.net/~shade/8014964/webrev.03/hotspot/src/share/vm/classfile/classFileParser.cpp.frames.html 
<http://cr.openjdk.java.net/%7Eshade/8014964/webrev.03/hotspot/src/share/vm/classfile/classFileParser.cpp.frames.html>
lines 3456 3459 contended_count == nonstatic_contended_count always.  I 
suspect the latter was distinct and not removed when static contended 
fields were removed.

3555 leftover comment

I was looking at the code under // Handle contended cases, there isn't a 
lot of variables that are passed in and out that and it could be out-lined.

On line 3146 is there a flag to test if any contended fields are present 
so that we don't rewalk the fields again?   It seems that setting 
FieldAllocationCount while parsing fields is sort of pointless if we 
have to walk the fields again.   We could just set FieldAllocationCount 
fac in this loop if we have to do this and that would eliminate the 
confusion where sometimes you subtract fac_contended->count() and 
sometimes you don't.

I couldn't figure out the new asserts with this one and am giving up for 
now.

Since I've spent the time to look at this code, I would prefer to see a 
bigger change with all the bug fixes together.   After that, please run 
the NSK tests vm.quick.testlist and run the jtreg tests in the 
hotspot/test directories, especially the compiler tests which are likely 
to have objects with different sorts of layouts and inheritance.

thanks,
Coleen

On 5/22/2013 5:16 PM, Aleksey Shipilev wrote:
> Thanks for the ideas!
>
> On 05/21/2013 08:14 PM, Vladimir Kozlov wrote:
>>> Could you move third check on next line so you can see all on one screen?
> Done.
>
>>> You are right. So parsed_annotations->is_contended() is true for any
>>> combinations of class and fields annotation. Right?
> (parsed_annotations->is_contended() == true) iff (@Contended on class).
>
> This is yet another thing to clean up.
>
>>> This could be affected by alignment even more than your assert. Could
>>> you look?
> Hm... Ok, I can compare against the non-aligned offset. It can only not
> equal the start if we do indeed have the fields.
>
> But nonstatic_field_size still has the same problem. Moreover, assert
> would seem to fail even in the simple case when the super-class is
> @Contended; added the test case for that (class R4).
>
> This is the current webrev:
>    http://cr.openjdk.java.net/~shade/8014964/webrev.03/
>
> Testing:
>    - hotspot/test/runtime/contended/ regression tests (failing)
>    - JPRT cycle vs hotspot-rt is running now  (just in case)
>
> I actually start to wonder if no size/offset is reliable for this
> assert; and counting the fields will yield the same expression over
> fac[...], which is dumb to assert. The asserts there are only to fire
> the regression test. Hence, this might seem to be that rare case where
> the regression test is impractical?
>
> -Aleksey.


From aleksey.shipilev at oracle.com  Wed May 22 16:09:08 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Thu, 23 May 2013 03:09:08 +0400
Subject: RFR (S) CR 8014964: @Contended breaks has_nonstatic_fields
	invariant
In-Reply-To: <519D4974.6010303@oracle.com>
References: <519B5BE4.90009@oracle.com> <519B8B1F.20204@oracle.com>
	<519B8F91.7060604@oracle.com> <519B9BA3.5070404@oracle.com>
	<519B9D78.70107@oracle.com> <519D35BB.80009@oracle.com>
	<519D4974.6010303@oracle.com>
Message-ID: <519D5014.8020406@oracle.com>

Thanks for review!

On 05/23/2013 02:40 AM, Coleen Phillimore wrote:
> I've been reviewing 8014886 for a few hours which is in similar code to
> this code.   The change for 8014886 appears to still have the bug that
> you have at lines 3194.   Why are these separate changes? 

The idea is to have these changes separated to: a) fix the concrete
problems, and provide the targeted regression tests for them; b) provide
the basis for bisection should it bring any regressions in the future. I
don't think we should pack these up together.

> Are these contended tests being added to our hotspot/test tests?

Regression tests are, see the webrev. I'm not sure what @Contended tests
are you mentioning though.


> http://cr.openjdk.java.net/~shade/8014964/webrev.03/hotspot/src/share/vm/classfile/classFileParser.cpp.frames.html
> <http://cr.openjdk.java.net/%7Eshade/8014964/webrev.03/hotspot/src/share/vm/classfile/classFileParser.cpp.frames.html>
> 
> lines 3456 3459 contended_count == nonstatic_contended_count always.  I
> suspect the latter was distinct and not removed when static contended
> fields were removed.

Ah, yes, that's clearly redundant. I filed JDK-8015254 to keep up with
the list of "ugly" issues in that code, which are not the bugs per se.
Feel free to add more insights there.

> 3555 leftover comment

To be fixed, thanks.

> I was looking at the code under // Handle contended cases, there isn't a
> lot of variables that are passed in and out that and it could be out-lined.

Added to the cleanup list.

> We could just set FieldAllocationCount
> fac in this loop if we have to do this and that would eliminate the
> confusion where sometimes you subtract fac_contended->count() and
> sometimes you don't.

That's an interesting approach, I would need to explore this a bit
more... the other use is that we can select some of the field to pack in
the gaps from the alignments of other fields, and we *don't* want those
fields to be contended. So, it would be interesting to follow if
substracting the contended fields from "fac" first time will make things
less uglier, but still correct.

> I couldn't figure out the new asserts with this one and am giving up for
> now.

> Since I've spent the time to look at this code, I would prefer to see a
> bigger change with all the bug fixes together.   After that, please run
> the NSK tests vm.quick.testlist and run the jtreg tests in the
> hotspot/test directories, especially the compiler tests which are likely
> to have objects with different sorts of layouts and inheritance.

Now you're talking! :) Sure, let me run these as well.

-Aleksey.


From vladimir.kozlov at oracle.com  Wed May 22 16:10:04 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Wed, 22 May 2013 16:10:04 -0700
Subject: RFR (S) CR 8014964: @Contended breaks has_nonstatic_fields
	invariant
In-Reply-To: <519D4747.5050306@oracle.com>
References: <519B5BE4.90009@oracle.com> <519B8B1F.20204@oracle.com>
	<519B8F91.7060604@oracle.com> <519B9BA3.5070404@oracle.com>
	<519B9D78.70107@oracle.com> <519D35BB.80009@oracle.com>
	<519D422D.5050707@oracle.com> <519D4747.5050306@oracle.com>
Message-ID: <519D504C.2060907@oracle.com>

On 5/22/13 3:31 PM, Aleksey Shipilev wrote:
> On 05/23/2013 02:09 AM, Vladimir Kozlov wrote:
>>> Testing:
>>>     - hotspot/test/runtime/contended/ regression tests (failing)
>>
>> Could you run all hotspot/test tests (you have to list them)? It should
>> not take long.
>
> Yes, I can. Let me re-spin the testing for this one.
>
>>>     - JPRT cycle vs hotspot-rt is running now  (just in case)
>>>
>>> I actually start to wonder if no size/offset is reliable for this
>>> assert; and counting the fields will yield the same expression over
>>> fac[...], which is dumb to assert. The asserts there are only to fire
>>> the regression test. Hence, this might seem to be that rare case where
>>> the regression test is impractical?
>>
>> The asserts and test are a protection from future bugs in this code (as
>> most of other asserts in VM). This code is complex and is easy to screw
>> up :)
>
> Yes, I know that. My inclination though is to omit the assert for
> has_nonstatic_fields, because we can not reliably assert it. For
> example, if you run the valid regression test (contended/HasNonStatic),
> it will fail on that assert. Am I missing some good way to test
> has_nonstatic_fields without putting exactly the same expression over
> fac[...] in the assert?

That assert fails R3/R4 case because you do not take into account that 
super has padding: super_klass->super->nonstatic_field_size() > 0 but 
super_klass->has_nonstatic_fields() == 0. In general case that could be 
caused by contended annotations or by alignment. We can check for such 
case in assert. But then it will be equivalent to the second assert 
which checks only local size. Yes, I think we don't need 
has_nonstatic_fields assert.

Thanks,
Vladimir

>
> -Aleksey.
>

From aleksey.shipilev at oracle.com  Wed May 22 16:10:35 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Thu, 23 May 2013 03:10:35 +0400
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
In-Reply-To: <519D48E6.9090801@oracle.com>
References: <519A4B39.20208@oracle.com> <519AF0D4.4080102@oracle.com>
	<519B3879.1050301@oracle.com> <519D4216.2060906@oracle.com>
	<519D48E6.9090801@oracle.com>
Message-ID: <519D506B.4030905@oracle.com>

On 05/23/2013 02:38 AM, Aleksey Shipilev wrote:
> Other issues can wait till the next integration window. (And being the
> cleanups, they will naturally entail some bike-shedding).

I had submitted the tracking issue for the cleanup as JDK-8015254.
Please feel free to shove in more things that make you cry with that code.

-Aleksey.


From daniel.daugherty at oracle.com  Wed May 22 16:42:03 2013
From: daniel.daugherty at oracle.com (Daniel D. Daugherty)
Date: Wed, 22 May 2013 17:42:03 -0600
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
In-Reply-To: <519D48E6.9090801@oracle.com>
References: <519A4B39.20208@oracle.com> <519AF0D4.4080102@oracle.com>
	<519B3879.1050301@oracle.com> <519D4216.2060906@oracle.com>
	<519D48E6.9090801@oracle.com>
Message-ID: <519D57CB.6070103@oracle.com>

On 5/22/13 4:38 PM, Aleksey Shipilev wrote:
> Thanks for the review!
>
> On 05/23/2013 02:09 AM, Daniel D. Daugherty wrote:
>> which does not include the vm.quick testsuite which is minimum
>> testing required for RT_Baseline pushes unless the change is
>> trivial.
> Fair enough.
> I'll get back with the test results as soon as I able to run vm.quick.
>
>> Do you have a planned time frame or time frames for these bugs?
> Let me submit the remaining issues to the bugtracker to keep the things
> in order tomorrow. I think all the functional bugfixes will be ready
> early next week. What's the hotspot-rt -> hotspot-main merge window? I
> would certainly like to have a few nightlies before those get into hs-main.

RT_Baseline snapshots on Tuesday at 1900 PT. If the Tuesday nightly is
good, then RT_Baseline usually pushes the snapshot -> Main_Baseline on
Wednesday. On rare occasions, RT_Baseline will do two pushes in one
week, but that has to coordinated with the current RT GK (Rickard
Backman).

In some cases, RT_Baseline will snapshot on Tuesday like normal, but
will wait for two nights of nightly testing to get the full spectrum
of configurations. However, this requires very close coordination
with the RT GK and Runtime Team since we'll have to avoid pushing
anything after the Tuesday snapshot before before the Wednesday
nightly starts (again at 1900 PT).


> Other issues can wait till the next integration window. (And being the
> cleanups, they will naturally entail some bike-shedding).

I have to say that the number of deferrals of issues to new bugs during
a current bug's review cycle along with the general bug tail of @Contended
is making me very nervous. It's starting to feel like we're just stumbling
around wearing a bucket and have a very limited view of the horizon due
to the bucket.

If I was the gatekeeper this month, I would be entertaining the idea of
backing out @Contended until it could be proven to be more stable via
a whole lot of testing. Fortunately (for many reasons), I'm not the RT
GK this month. :-)

Dan


From coleen.phillimore at oracle.com  Wed May 22 16:43:58 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Wed, 22 May 2013 19:43:58 -0400
Subject: RFR (S) CR 8014964: @Contended breaks has_nonstatic_fields
	invariant
In-Reply-To: <519D5014.8020406@oracle.com>
References: <519B5BE4.90009@oracle.com> <519B8B1F.20204@oracle.com>
	<519B8F91.7060604@oracle.com> <519B9BA3.5070404@oracle.com>
	<519B9D78.70107@oracle.com> <519D35BB.80009@oracle.com>
	<519D4974.6010303@oracle.com> <519D5014.8020406@oracle.com>
Message-ID: <519D583E.3050108@oracle.com>

On 5/22/2013 7:09 PM, Aleksey Shipilev wrote:
> Thanks for review!
>
> On 05/23/2013 02:40 AM, Coleen Phillimore wrote:
>> I've been reviewing 8014886 for a few hours which is in similar code to
>> this code.   The change for 8014886 appears to still have the bug that
>> you have at lines 3194.   Why are these separate changes?
> The idea is to have these changes separated to: a) fix the concrete
> problems, and provide the targeted regression tests for them; b) provide
> the basis for bisection should it bring any regressions in the future. I
> don't think we should pack these up together.

It's pretty hard to review one change with another bug 2 lines above 
it.   I'd rather review the cleaned up code than iterating on the not 
cleaned up code.   Especially since all the bugs are in the same 
location.   I think doing the cleanups while fixing the bugs may make it 
obvious where the next bugs are, and make it easier and less time 
consuming to review.

>
>> Are these contended tests being added to our hotspot/test tests?
> Regression tests are, see the webrev. I'm not sure what @Contended tests
> are you mentioning though.

The ones that SQE wrote that are exposing these bugs.   Where are 
they?   Who wrote the SQE tests?

>> http://cr.openjdk.java.net/~shade/8014964/webrev.03/hotspot/src/share/vm/classfile/classFileParser.cpp.frames.html
>> <http://cr.openjdk.java.net/%7Eshade/8014964/webrev.03/hotspot/src/share/vm/classfile/classFileParser.cpp.frames.html>
>>
>> lines 3456 3459 contended_count == nonstatic_contended_count always.  I
>> suspect the latter was distinct and not removed when static contended
>> fields were removed.
> Ah, yes, that's clearly redundant. I filed JDK-8015254 to keep up with
> the list of "ugly" issues in that code, which are not the bugs per se.
> Feel free to add more insights there.

You don't need a bug number for this simple change.   Usually I support 
limiting changesets but not at this level.
>
>> 3555 leftover comment
> To be fixed, thanks.
>
>> I was looking at the code under // Handle contended cases, there isn't a
>> lot of variables that are passed in and out that and it could be out-lined.
> Added to the cleanup list.
>
>> We could just set FieldAllocationCount
>> fac in this loop if we have to do this and that would eliminate the
>> confusion where sometimes you subtract fac_contended->count() and
>> sometimes you don't.
> That's an interesting approach, I would need to explore this a bit
> more... the other use is that we can select some of the field to pack in
> the gaps from the alignments of other fields, and we *don't* want those
> fields to be contended. So, it would be interesting to follow if
> substracting the contended fields from "fac" first time will make things
> less uglier, but still correct.

Not subtracting, more like not adding them:

   FieldAllocationCount fac_contended;
   FieldAllocationCount fac;
   for (AllFieldStream fs(_fields, _cp); !fs.done(); fs.next()) {
     FieldAllocationType atype = (FieldAllocationType) fs.allocation_type();
     if (fs.is_contended()) {
       fac_contended.count[atype]++;
       if (!fs.access_flags().is_static()) {
         nonstatic_contended_count++;
       }
     } else {
       fac.count[atype]++;
   }

>
>> I couldn't figure out the new asserts with this one and am giving up for
>> now.

I see one that I couldn't see why you were asserting it in the first place.
>> Since I've spent the time to look at this code, I would prefer to see a
>> bigger change with all the bug fixes together.   After that, please run
>> the NSK tests vm.quick.testlist and run the jtreg tests in the
>> hotspot/test directories, especially the compiler tests which are likely
>> to have objects with different sorts of layouts and inheritance.
> Now you're talking! :) Sure, let me run these as well.

If you need directions to run these, ask me offline.

Coleen

>
> -Aleksey.
>


From david.holmes at oracle.com  Wed May 22 16:58:14 2013
From: david.holmes at oracle.com (David Holmes)
Date: Thu, 23 May 2013 09:58:14 +1000
Subject: How is JVM.cpp used
In-Reply-To: <CANYna1-k8MEvnnJ4KCx=GWZ1ip7F+cg_MOQuTKcL9f_tJzAu=g@mail.gmail.com>
References: <1369243799700-135050.post@n7.nabble.com>
	<CANYna1-k8MEvnnJ4KCx=GWZ1ip7F+cg_MOQuTKcL9f_tJzAu=g@mail.gmail.com>
Message-ID: <519D5B96.5070908@oracle.com>

Moving to hotspot-dev - please delete discuss list from any further replies.

On 23/05/2013 3:38 AM, Jipeng Huang wrote:
> The reason why I had that question is that I noted that there're some
> method entries for methods inside java.lang.System in jvm.cpp. I don't know
> whether those entries would be used by interpreter or something else.

As Doug said jvm.cpp is the native implementations for a bunch of native 
method defined in the JDK libraries. Look for JVM_ methods.

Some of those Java-level methods may also be subject to intrinsification 
by C1/C2 in which case the JVM_ version will only be used from 
interpreted code.

David

>
> On Wed, May 22, 2013 at 10:29 AM, Jipeng Huang <robinhjp at gmail.com> wrote:
>
>> Hi,
>>
>> I'm new to openjdk and currently I'm modifying some library methods like
>> methods inside java.lang.System. I can easily change the corresponding
>> method calls for c1 and c2 compilers by changing the mapping between
>> intrinsics and methods but I don't know where jvm.cpp is used and whether
>> that can affect the result.
>>
>> Thanks,
>> Jipeng
>>
>>
>>
>> --
>> View this message in context:
>> http://openjdk.5641.n7.nabble.com/How-is-JVM-cpp-used-tp135050.html
>> Sent from the OpenJDK General discussion mailing list archive at
>> Nabble.com.
>>
>
>
>

From david.holmes at oracle.com  Wed May 22 17:09:36 2013
From: david.holmes at oracle.com (David Holmes)
Date: Thu, 23 May 2013 10:09:36 +1000
Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace
	in libjvm.symbols that does not exist in minimal/libjvm.a when
	DEBUG_LEVEL == release
In-Reply-To: <519D1C10.90302@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
	<519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com>
	<5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com>
	<519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com>
	<519BC8A8.5060909@oracle.com> <519BD250.10302@oracle.com>
	<519BDE85.6000005@oracle.com> <519D1C10.90302@oracle.com>
Message-ID: <519D5E40.3010407@oracle.com>

Joe,

On 23/05/2013 5:27 AM, Joseph Provino wrote:
> Is there a consensus what is in the webrev is okay?

Yes I am now okay with it. I found this in 4889433:

"AsyncGetCallTrace() requires the CLASS_LOAD event
to be enabled because that causes jmethodID's to be created for the
methods at class load time. This increases the likelyhood of being
able to get the jmethodID for a frame during a stackwalk. Since
AsyncGetCallTrace() cannot block, it uses a special routine to the
get the jmethodID that does not block if the jmethodID is not available
immediately. So while CLASS_LOAD events are not strictly required, the
data gathered during the stackwalk would be pretty useless."

So reporting the ticks_no_class_load value seems quite reasonable and 
the clients of this interface should be expecting it.

Thanks,
David

> The change is to include forte.cpp in the minimal jvm but to
> conditionalize the code so that only AsyncGetCallTrace()
> is defined with the minimal jvm.
>
> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.01
>
>      JDK-8013461 https://jbs.oracle.com/bugs/browse/JDK-8013461
>      There is a symbol AsyncGetCallTrace in libjvm.symbols that does not
> exist in
>      minimal/libjvm.a when DEBUG_LEVEL == release
>
> joe
>
> On 05/21/2013 04:52 PM, JOSEPH PROVINO wrote:
>>
>> On 5/21/2013 4:00 PM, Oleg Mazurov wrote:
>>> Though formally not part of the Solaris Studio team any more here is
>>> my opinion based on my recollection of how I implemented interaction
>>> with the JVM via AsyncGetCallTrace.
>>> It's looked up using dlsym. If the symbol is not there Java callstack
>>> collection is shut down. I understand in your case even JVMTI is not
>>> there so the dlsym call will not be made.
>>> From that perspective there is no difference whether the symbol is
>>> present and returns an error code or not present at all.
>>
>> Oleg, then it sounds like what we have will work.
>>
>> Thanks for the quick reply.
>>
>> joe
>>
>>>
>>>     -- Oleg
>>>
>>> On 5/21/2013 12:19 PM, JOSEPH PROVINO wrote:
>>>>
>>>> On 5/21/2013 3:16 PM, serguei.spitsyn at oracle.com wrote:
>>>>> On 5/21/13 11:26 AM, JOSEPH PROVINO wrote:
>>>>>>
>>>>>> On 5/21/2013 2:23 PM, Staffan Larsen wrote:
>>>>>>> On 21 maj 2013, at 17:35, JOSEPH PROVINO
>>>>>>> <joseph.provino at oracle.com> wrote:
>>>>>>>
>>>>>>>> On 5/21/2013 3:06 AM, David Holmes wrote:
>>>>>>>>> Hi Staffan,
>>>>>>>>>
>>>>>>>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote:
>>>>>>>>>> On 21 maj 2013, at 04:34, David Holmes
>>>>>>>>>> <David.Holmes at oracle.com> wrote:
>>>>>>>>>>
>>>>>>>>>>> <added servicability>
>>>>>>>>>>>
>>>>>>>>>>> Hi Joe,
>>>>>>>>>>>
>>>>>>>>>>> As I have previously stated you copied the struct definitions
>>>>>>>>>>> instead of moving them outside the ifdef.
>>>>>>>>>>>
>>>>>>>>>>> Serviceability folk: we are particularly interested in
>>>>>>>>>>> whether the use of ticks_no_class_load is deemed appropriate
>>>>>>>>>>> in this situation. Who will be consuming this value?
>>>>>>>>>> Since you have opted for the simple fix of having an exported
>>>>>>>>>> but non-functional AsyncGetCallTrace instead of actually
>>>>>>>>>> removing the symbol from the symbol files (which is the
>>>>>>>>>> proposed solution in the bug report),
>>>>>>>>> That would be a simpler solution semantically but the only way
>>>>>>>>> I can see to do that is to use a text replacement mechanism in
>>>>>>>>> the build files - as is done for the dynamic vtable symbols. I
>>>>>>>>> find that less appealing than simply exporting an interface
>>>>>>>>> that is configured to report an error (which is essentially
>>>>>>>>> what all the optional interfaces do under the minimal VM).
>>>>>>>>>
>>>>>>>>>> I would like you to include a comment about this in the
>>>>>>>>>> source. Right now it's very unclear why there is an exported
>>>>>>>>>> function that only returns an error.
>>>>>>>>>>
>>>>>>>>>> As to the appropriate return value, I don't know. The only
>>>>>>>>>> caller should be the Sun Studio profiler,
>>>>>> Does anyone know where to find instructions on how to run the
>>>>>> collector which would get the error return value?
>>>>>>>>>>   and I'm not sure how it will handle this case if ever run.
>>>>>>>>>> The possible return values aren't very well documented.
>>>>>>>>> I guess we need to try and run it to find out.
>>>>>>>> Okay, do either of you feel strongly about how this should be
>>>>>>>> fixed -- return an error or remove the symbol?
>>>>>>> No, I don't feel strongly either way, but a comment in the code
>>>>>>> would be nice.
>>>>>> How much effort should I put into finding out what Sun Studio
>>>>>> profiler does when it gets -1?
>>>>>
>>>>> Let's ask the Solaris Studio guys directly.
>>>>> I'm adding Oleg to the mailing list.
>>>>>
>>>>> Oleg,
>>>>>
>>>>> Could you, please, share your view on this problem?
>>>>
>>>> In particular what will the Sun Studio Profiler collector do if it
>>>> gets the error
>>>>
>>>> trace->num_frames = ticks_no_class_load; // -1
>>>>
>>>> Thanks.
>>>>
>>>> joe
>>>>
>>>>>
>>>>>
>>>>> Thanks,
>>>>> Serguei
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>>
>>>>>> joe
>>>>>>
>>>>>>>
>>>>>>> Thanks,
>>>>>>> /Staffan
>>>>>>>
>>>>>>>
>>>>>>>> joe
>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> David
>>>>>>>>>
>>>>>>>>>> /Staffan
>>>>>>>>>>
>>>>>>>>>>> Thanks,
>>>>>>>>>>> David
>>>>>>>>>>>
>>>>>>>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>>>>>>>>>>>> The change is to include forte.cpp in the minimal jvm but to
>>>>>>>>>>>> conditionalize the code so that
>>>>>>>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>>>>>>>>>>>
>>>>>>>>>>>> Webrev is here:
>>>>>>>>>>>> http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>>>>>>>>>>>
>>>>>>>>>>>>   * JDK-8013461
>>>>>>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>>>>>>>>>>>     a symbol AsyncGetCallTrace in libjvm.symbols that does
>>>>>>>>>>>> not exist in
>>>>>>>>>>>>     minimal/libjvm.a when DEBUG_LEVEL == release
>>>>>>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks.
>>>>>>>>>>>>
>>>>>>>>>>>> joe
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>

From coleen.phillimore at oracle.com  Wed May 22 17:27:55 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Wed, 22 May 2013 20:27:55 -0400
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
In-Reply-To: <519D57CB.6070103@oracle.com>
References: <519A4B39.20208@oracle.com> <519AF0D4.4080102@oracle.com>
	<519B3879.1050301@oracle.com> <519D4216.2060906@oracle.com>
	<519D48E6.9090801@oracle.com> <519D57CB.6070103@oracle.com>
Message-ID: <519D628B.4020807@oracle.com>

On 5/22/2013 7:42 PM, Daniel D. Daugherty wrote:
> On 5/22/13 4:38 PM, Aleksey Shipilev wrote:
>> Thanks for the review!
>>
>> On 05/23/2013 02:09 AM, Daniel D. Daugherty wrote:
>>> which does not include the vm.quick testsuite which is minimum
>>> testing required for RT_Baseline pushes unless the change is
>>> trivial.
>> Fair enough.
>> I'll get back with the test results as soon as I able to run vm.quick.
>>
>>> Do you have a planned time frame or time frames for these bugs?
>> Let me submit the remaining issues to the bugtracker to keep the things
>> in order tomorrow. I think all the functional bugfixes will be ready
>> early next week. What's the hotspot-rt -> hotspot-main merge window? I
>> would certainly like to have a few nightlies before those get into 
>> hs-main.
>
> RT_Baseline snapshots on Tuesday at 1900 PT. If the Tuesday nightly is
> good, then RT_Baseline usually pushes the snapshot -> Main_Baseline on
> Wednesday. On rare occasions, RT_Baseline will do two pushes in one
> week, but that has to coordinated with the current RT GK (Rickard
> Backman).
>
> In some cases, RT_Baseline will snapshot on Tuesday like normal, but
> will wait for two nights of nightly testing to get the full spectrum
> of configurations. However, this requires very close coordination
> with the RT GK and Runtime Team since we'll have to avoid pushing
> anything after the Tuesday snapshot before before the Wednesday
> nightly starts (again at 1900 PT).
>
>
>> Other issues can wait till the next integration window. (And being the
>> cleanups, they will naturally entail some bike-shedding).
>
> I have to say that the number of deferrals of issues to new bugs during
> a current bug's review cycle along with the general bug tail of 
> @Contended
> is making me very nervous. It's starting to feel like we're just 
> stumbling
> around wearing a bucket and have a very limited view of the horizon due
> to the bucket.
>
> If I was the gatekeeper this month, I would be entertaining the idea of
> backing out @Contended until it could be proven to be more stable via
> a whole lot of testing. Fortunately (for many reasons), I'm not the RT
> GK this month. :-)

I interpret this as a second request to fix all the bugs and cleanups in 
one change and let us review that change.   I don't think it needs to be 
backed out because it only affects the contended tests and that's not in 
the JDK yet (or is it?)   Is it breaking code that doesn't use it?

Thanks,
Coleen
>
> Dan
>


From coleen.phillimore at oracle.com  Wed May 22 18:47:42 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Wed, 22 May 2013 21:47:42 -0400
Subject: RFR (S) JDK-8014912 Restore PrintSharedSpaces after NPG
In-Reply-To: <519BF549.3070808@oracle.com>
References: <519BF549.3070808@oracle.com>
Message-ID: <519D753E.8040009@oracle.com>


Ioi,

This looks really good.  The only thing is that we have code to create 
histograms in the VM (see utilities/histogram.hpp). Couldn't you reuse 
this class instead of writing your own histogram creating function?   It 
would sort your data for you!  I don't know if it would have the data 
you are looking for but lots of other jvm code uses this class for a 
similar purpose.

Thanks,
Coleen

On 5/21/2013 6:29 PM, Ioi Lam wrote:
> Please review:
>
> http://cr.openjdk.java.net/~iklam/8014912/print_sharedspc_001/
>
> Bug: Restore PrintSharedSpaces functionality after NPG
>
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014912
>     https://jbs.oracle.com/bugs/browse/JDK-8014912
>
> Summary of fix:
>
> I added a new enum, MetaspaceObj::Type, which is passed to
>
>     Metaspace::allocate(ClassLoaderData* loader_data, size_t word_size,
>                         bool read_only, MetaspaceObj::Type type, TRAPS);
>
> During CDS dumping, all allocations are logged in a linked list to
> be processed later by metaspaceShared.cpp to generate statistics for
> objects in the CDS archive. See sample output below.
>
> * No such logging is doneat normal VM execution time so there
>   is no performance impact.
>
> * I verified that the patch can be applied cleanly on Jon's
>   recentpatch for JDK-8014862 "Add fast Metasapce capacity and
>   used per MetadataType"
>
> http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/2b1a9d972fc2
>
> Testing:
>
>     JPRT, UTE (vm.quick.testlist)
>
> Sample output:
>
>                         ro_cnt   ro_bytes     % | rw_cnt rw_bytes     
> % |  all_cnt  all_bytes     %
> --------------------+---------------------------+---------------------------+-------------------------- 
>
> Unknown             :        1         64   0.0 | 1         64 0.0 
> |        2        128   0.0
> Class               :        0          0   0.0 | 2364    2006080 14.7 
> |     2364    2006080   9.2
> Symbol              :    49858    2507168  30.9 | 0          0 0.0 
> |    49858    2507168  11.5
> TypeArrayU1         :    13264     608336   7.5 | 2365 428784   3.1 
> |    15629    1037120   4.8
> TypeArrayU2         :     4796     341952   4.2 | 0          0 0.0 
> |     4796     341952   1.6
> TypeArrayU4         :     2371     178528   2.2 | 0          0 0.0 
> |     2371     178528   0.8
> TypeArrayU8         :     3708     365920   4.5 | 0          0 0.0 
> |     3708     365920   1.7
> TypeArrayOther      :        0          0   0.0 | 0          0 0.0 
> |        0          0   0.0
> Method              :        0          0   0.0 | 32552 3659888  26.8 
> |    32552    3659888  16.8
> ConstMethod         :    32552    4099008  50.6 | 0          0 0.0 
> |    32552    4099008  18.8
> MethodData          :        0          0   0.0 | 0          0 0.0 
> |        0          0   0.0
> ConstantPool        :        0          0   0.0 | 2365    3225600 23.6 
> |     2365    3225600  14.8
> ConstantPoolCache   :        0          0   0.0 | 2350    2212320 16.2 
> |     2350    2212320  10.2
> Annotation          :       26       1248   0.0 | 0          0 0.0 
> |       26       1248   0.0
> MethodCounters      :        0          0   0.0 | 0          0 0.0 
> |        0          0   0.0
> SymbolHashentry     :        0          0   0.0 | 49858 1595456  11.7 
> |    49858    1595456   7.3
> SymbolBuckets       :        0          0   0.0 | 20011 320176   2.3 
> |    20011     320176   1.5
> Other               :        0          0   0.0 | 0     203893 1.5 
> |        0     203893   0.9
> --------------------+---------------------------+---------------------------+-------------------------- 
>
> Total               :   106576    8102224 100.0 | 111866 13652261 
> 100.0 |   218442   21754485 100.0
>
>
> Thanks,
> Ioi
>
>


From aleksey.shipilev at oracle.com  Wed May 22 23:07:34 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Thu, 23 May 2013 10:07:34 +0400
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
In-Reply-To: <519D628B.4020807@oracle.com>
References: <519A4B39.20208@oracle.com> <519AF0D4.4080102@oracle.com>
	<519B3879.1050301@oracle.com> <519D4216.2060906@oracle.com>
	<519D48E6.9090801@oracle.com> <519D57CB.6070103@oracle.com>
	<519D628B.4020807@oracle.com>
Message-ID: <519DB226.4070405@oracle.com>

On 05/23/2013 04:27 AM, Coleen Phillimore wrote:
>> I have to say that the number of deferrals of issues to new bugs 
>> during a current bug's review cycle along with the general bug
>> tail of @Contended is making me very nervous. It's starting to feel
>> like we're just stumbling around wearing a bucket and have a very 
>> limited view of the horizon due to the bucket.
> 
> I interpret this as a second request to fix all the bugs and
> cleanups in one change and let us review that change.

Thanks, I will comply with this request.

I would like to note that requests using the form of "please merge all
bugfixes and cleanups into the single CR" are more effective as the
communication means, rather than relying on other reviewers to
re-interpret what is being requested. :)

For the record, I still think this is a bad idea to merge the histories
for several related, but distinct issues together, even if the changes
are small, on the pretense it makes the bulk review easier. But, as I
said, will disagree and commit.

> I don't think it needs to be backed out because it only affects the
> contended tests and that's not in the JDK yet (or is it?)   Is it
> breaking code that doesn't use it?

There is no @Contended classes/fields in JDK (yet). We are waiting for
this VM code to stabilize before committing to @Contended in the library.

-Aleksey.

From staffan.larsen at oracle.com  Thu May 23 00:33:43 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Thu, 23 May 2013 09:33:43 +0200
Subject: review request for JDK-8013461 There is a symbol
	AsyncGetCallTrace in libjvm.symbols that does not exist in
	minimal/libjvm.a when DEBUG_LEVEL == release
In-Reply-To: <519D1C10.90302@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
	<519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com>
	<5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com>
	<519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com>
	<519BC8A8.5060909@oracle.com> <519BD250.10302@oracle.com>
	<519BDE85.6000005@oracle.com> <519D1C10.90302@oracle.com>
Message-ID: <D2EB49CA-F496-4C55-AA80-E11C209F9CF7@oracle.com>

Ok!

/Staffan

On 22 maj 2013, at 21:27, Joseph Provino <joseph.provino at oracle.com> wrote:

> Is there a consensus what is in the webrev is okay?
> 
> The change is to include forte.cpp in the minimal jvm but to
> conditionalize the code so that only AsyncGetCallTrace()
> is defined with the minimal jvm.
> 
> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.01
> 
>    JDK-8013461 https://jbs.oracle.com/bugs/browse/JDK-8013461
>    There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in
>    minimal/libjvm.a when DEBUG_LEVEL == release
> 
> joe
> 
> On 05/21/2013 04:52 PM, JOSEPH PROVINO wrote:
>> 
>> On 5/21/2013 4:00 PM, Oleg Mazurov wrote:
>>> Though formally not part of the Solaris Studio team any more here is my opinion based on my recollection of how I implemented interaction with the JVM via AsyncGetCallTrace.
>>> It's looked up using dlsym. If the symbol is not there Java callstack collection is shut down. I understand in your case even JVMTI is not there so the dlsym call will not be made.
>>> From that perspective there is no difference whether the symbol is present and returns an error code or not present at all.
>> 
>> Oleg, then it sounds like what we have will work.
>> 
>> Thanks for the quick reply.
>> 
>> joe
>> 
>>> 
>>>    -- Oleg
>>> 
>>> On 5/21/2013 12:19 PM, JOSEPH PROVINO wrote:
>>>> 
>>>> On 5/21/2013 3:16 PM, serguei.spitsyn at oracle.com wrote:
>>>>> On 5/21/13 11:26 AM, JOSEPH PROVINO wrote:
>>>>>> 
>>>>>> On 5/21/2013 2:23 PM, Staffan Larsen wrote:
>>>>>>> On 21 maj 2013, at 17:35, JOSEPH PROVINO <joseph.provino at oracle.com> wrote:
>>>>>>> 
>>>>>>>> On 5/21/2013 3:06 AM, David Holmes wrote:
>>>>>>>>> Hi Staffan,
>>>>>>>>> 
>>>>>>>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote:
>>>>>>>>>> On 21 maj 2013, at 04:34, David Holmes <David.Holmes at oracle.com> wrote:
>>>>>>>>>> 
>>>>>>>>>>> <added servicability>
>>>>>>>>>>> 
>>>>>>>>>>> Hi Joe,
>>>>>>>>>>> 
>>>>>>>>>>> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef.
>>>>>>>>>>> 
>>>>>>>>>>> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value?
>>>>>>>>>> Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report),
>>>>>>>>> That would be a simpler solution semantically but the only way I can see to do that is to use a text replacement mechanism in the build files - as is done for the dynamic vtable symbols. I find that less appealing than simply exporting an interface that is configured to report an error (which is essentially what all the optional interfaces do under the minimal VM).
>>>>>>>>> 
>>>>>>>>>> I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error.
>>>>>>>>>> 
>>>>>>>>>> As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler,
>>>>>> Does anyone know where to find instructions on how to run the collector which would get the error return value?
>>>>>>>>>>  and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented.
>>>>>>>>> I guess we need to try and run it to find out.
>>>>>>>> Okay, do either of you feel strongly about how this should be fixed -- return an error or remove the symbol?
>>>>>>> No, I don't feel strongly either way, but a comment in the code would be nice.
>>>>>> How much effort should I put into finding out what Sun Studio profiler does when it gets -1?
>>>>> 
>>>>> Let's ask the Solaris Studio guys directly.
>>>>> I'm adding Oleg to the mailing list.
>>>>> 
>>>>> Oleg,
>>>>> 
>>>>> Could you, please, share your view on this problem?
>>>> 
>>>> In particular what will the Sun Studio Profiler collector do if it gets the error
>>>> 
>>>> trace->num_frames = ticks_no_class_load; // -1
>>>> 
>>>> Thanks.
>>>> 
>>>> joe
>>>> 
>>>>> 
>>>>> 
>>>>> Thanks,
>>>>> Serguei
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>>> 
>>>>>> joe
>>>>>> 
>>>>>>> 
>>>>>>> Thanks,
>>>>>>> /Staffan
>>>>>>> 
>>>>>>> 
>>>>>>>> joe
>>>>>>>> 
>>>>>>>>> Thanks,
>>>>>>>>> David
>>>>>>>>> 
>>>>>>>>>> /Staffan
>>>>>>>>>> 
>>>>>>>>>>> Thanks,
>>>>>>>>>>> David
>>>>>>>>>>> 
>>>>>>>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>>>>>>>>>>>> The change is to include forte.cpp in the minimal jvm but to
>>>>>>>>>>>> conditionalize the code so that
>>>>>>>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>>>>>>>>>>> 
>>>>>>>>>>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>>>>>>>>>>> 
>>>>>>>>>>>>  * JDK-8013461 <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>>>>>>>>>>>    a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in
>>>>>>>>>>>>    minimal/libjvm.a when DEBUG_LEVEL == release
>>>>>>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>>>>>>>>>>> 
>>>>>>>>>>>> Thanks.
>>>>>>>>>>>> 
>>>>>>>>>>>> joe
>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>> 
>>>>> 
>>>> 
>>> 
>> 
> 


From erik.helin at oracle.com  Thu May 23 01:38:20 2013
From: erik.helin at oracle.com (erik.helin at oracle.com)
Date: Thu, 23 May 2013 08:38:20 +0000
Subject: hg: hsx/hsx24/hotspot: 8012086: The object count event should only
	send events for instances occupying more than 0.5% of the heap
Message-ID: <20130523083824.367CE48C8F@hg.openjdk.java.net>

Changeset: 044681b8bab0
Author:    ehelin
Date:      2013-05-23 08:14 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/044681b8bab0

8012086: The object count event should only send events for instances occupying more than 0.5% of the heap
Reviewed-by: brutisso, jwilhelm

! src/share/vm/gc_implementation/shared/gcTrace.cpp
! src/share/vm/gc_implementation/shared/gcTrace.hpp
! src/share/vm/memory/heapInspection.cpp
! src/share/vm/memory/heapInspection.hpp
+ src/share/vm/memory/klassInfoClosure.hpp
! src/share/vm/runtime/globals.hpp


From coleen.phillimore at oracle.com  Thu May 23 05:40:53 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Thu, 23 May 2013 08:40:53 -0400
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
In-Reply-To: <519DB226.4070405@oracle.com>
References: <519A4B39.20208@oracle.com> <519AF0D4.4080102@oracle.com>
	<519B3879.1050301@oracle.com> <519D4216.2060906@oracle.com>
	<519D48E6.9090801@oracle.com> <519D57CB.6070103@oracle.com>
	<519D628B.4020807@oracle.com> <519DB226.4070405@oracle.com>
Message-ID: <519E0E55.1080905@oracle.com>


Thank you!  I look forward to seeing the cleaned up code.
Coleen

On 05/23/2013 02:07 AM, Aleksey Shipilev wrote:
> On 05/23/2013 04:27 AM, Coleen Phillimore wrote:
>>> I have to say that the number of deferrals of issues to new bugs
>>> during a current bug's review cycle along with the general bug
>>> tail of @Contended is making me very nervous. It's starting to feel
>>> like we're just stumbling around wearing a bucket and have a very
>>> limited view of the horizon due to the bucket.
>> I interpret this as a second request to fix all the bugs and
>> cleanups in one change and let us review that change.
> Thanks, I will comply with this request.
>
> I would like to note that requests using the form of "please merge all
> bugfixes and cleanups into the single CR" are more effective as the
> communication means, rather than relying on other reviewers to
> re-interpret what is being requested. :)
>
> For the record, I still think this is a bad idea to merge the histories
> for several related, but distinct issues together, even if the changes
> are small, on the pretense it makes the bulk review easier. But, as I
> said, will disagree and commit.
>
>> I don't think it needs to be backed out because it only affects the
>> contended tests and that's not in the JDK yet (or is it?)   Is it
>> breaking code that doesn't use it?
> There is no @Contended classes/fields in JDK (yet). We are waiting for
> this VM code to stabilize before committing to @Contended in the library.
>
> -Aleksey.


From dl at cs.oswego.edu  Thu May 23 05:54:01 2013
From: dl at cs.oswego.edu (Doug Lea)
Date: Thu, 23 May 2013 08:54:01 -0400
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
In-Reply-To: <519E0E55.1080905@oracle.com>
References: <519A4B39.20208@oracle.com> <519AF0D4.4080102@oracle.com>
	<519B3879.1050301@oracle.com> <519D4216.2060906@oracle.com>
	<519D48E6.9090801@oracle.com> <519D57CB.6070103@oracle.com>
	<519D628B.4020807@oracle.com> <519DB226.4070405@oracle.com>
	<519E0E55.1080905@oracle.com>
Message-ID: <519E1169.8020905@cs.oswego.edu>


On 05/23/2013 02:07 AM, Aleksey Shipilev wrote:

>> There is no @Contended classes/fields in JDK (yet). We are waiting for
>> this VM code to stabilize before committing to @Contended in the library.
>>

This state of affairs will change soon (we hope). A bunch of
uses in updated java.util.concurrent classes will be integrated
into jdk8/tl. None of these usages are known to hit the existing
bugs though.

-Doug



From karen.kinnear at oracle.com  Thu May 23 06:32:50 2013
From: karen.kinnear at oracle.com (Karen Kinnear)
Date: Thu, 23 May 2013 09:32:50 -0400
Subject: RFR (S) JDK-8014912 Restore PrintSharedSpaces after NPG
In-Reply-To: <519D753E.8040009@oracle.com>
References: <519BF549.3070808@oracle.com> <519D753E.8040009@oracle.com>
Message-ID: <3531252B-5041-407D-B355-68492CEBCD6E@oracle.com>

Ioi,

This will be really helpful - in fact we'd like to use it right now :-)
Would it be hard to track the read-only and read-write separately, so we could at a glance
1) see what metadata is ro vs. rw and
2) see subtotal sizes and percentages (of combined ro/rw) for ro/rw?

thanks,
Karen
On May 22, 2013, at 9:47 PM, Coleen Phillimore wrote:

> 
> Ioi,
> 
> This looks really good.  The only thing is that we have code to create histograms in the VM (see utilities/histogram.hpp). Couldn't you reuse this class instead of writing your own histogram creating function?   It would sort your data for you!  I don't know if it would have the data you are looking for but lots of other jvm code uses this class for a similar purpose.
> 
> Thanks,
> Coleen
> 
> On 5/21/2013 6:29 PM, Ioi Lam wrote:
>> Please review:
>> 
>> http://cr.openjdk.java.net/~iklam/8014912/print_sharedspc_001/
>> 
>> Bug: Restore PrintSharedSpaces functionality after NPG
>> 
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014912
>>    https://jbs.oracle.com/bugs/browse/JDK-8014912
>> 
>> Summary of fix:
>> 
>> I added a new enum, MetaspaceObj::Type, which is passed to
>> 
>>    Metaspace::allocate(ClassLoaderData* loader_data, size_t word_size,
>>                        bool read_only, MetaspaceObj::Type type, TRAPS);
>> 
>> During CDS dumping, all allocations are logged in a linked list to
>> be processed later by metaspaceShared.cpp to generate statistics for
>> objects in the CDS archive. See sample output below.
>> 
>> * No such logging is doneat normal VM execution time so there
>>  is no performance impact.
>> 
>> * I verified that the patch can be applied cleanly on Jon's
>>  recentpatch for JDK-8014862 "Add fast Metasapce capacity and
>>  used per MetadataType"
>> 
>> http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/2b1a9d972fc2
>> 
>> Testing:
>> 
>>    JPRT, UTE (vm.quick.testlist)
>> 
>> Sample output:
>> 
>>                        ro_cnt   ro_bytes     % | rw_cnt rw_bytes     % |  all_cnt  all_bytes     %
>> --------------------+---------------------------+---------------------------+-------------------------- 
>> Unknown             :        1         64   0.0 | 1         64 0.0 |        2        128   0.0
>> Class               :        0          0   0.0 | 2364    2006080 14.7 |     2364    2006080   9.2
>> Symbol              :    49858    2507168  30.9 | 0          0 0.0 |    49858    2507168  11.5
>> TypeArrayU1         :    13264     608336   7.5 | 2365 428784   3.1 |    15629    1037120   4.8
>> TypeArrayU2         :     4796     341952   4.2 | 0          0 0.0 |     4796     341952   1.6
>> TypeArrayU4         :     2371     178528   2.2 | 0          0 0.0 |     2371     178528   0.8
>> TypeArrayU8         :     3708     365920   4.5 | 0          0 0.0 |     3708     365920   1.7
>> TypeArrayOther      :        0          0   0.0 | 0          0 0.0 |        0          0   0.0
>> Method              :        0          0   0.0 | 32552 3659888  26.8 |    32552    3659888  16.8
>> ConstMethod         :    32552    4099008  50.6 | 0          0 0.0 |    32552    4099008  18.8
>> MethodData          :        0          0   0.0 | 0          0 0.0 |        0          0   0.0
>> ConstantPool        :        0          0   0.0 | 2365    3225600 23.6 |     2365    3225600  14.8
>> ConstantPoolCache   :        0          0   0.0 | 2350    2212320 16.2 |     2350    2212320  10.2
>> Annotation          :       26       1248   0.0 | 0          0 0.0 |       26       1248   0.0
>> MethodCounters      :        0          0   0.0 | 0          0 0.0 |        0          0   0.0
>> SymbolHashentry     :        0          0   0.0 | 49858 1595456  11.7 |    49858    1595456   7.3
>> SymbolBuckets       :        0          0   0.0 | 20011 320176   2.3 |    20011     320176   1.5
>> Other               :        0          0   0.0 | 0     203893 1.5 |        0     203893   0.9
>> --------------------+---------------------------+---------------------------+-------------------------- 
>> Total               :   106576    8102224 100.0 | 111866 13652261 100.0 |   218442   21754485 100.0
>> 
>> 
>> Thanks,
>> Ioi
>> 
>> 
> 


From john.coomes at oracle.com  Thu May 23 06:31:55 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Thu, 23 May 2013 13:31:55 +0000
Subject: hg: hsx/hsx24/hotspot: 8014611: reserve_and_align() assumptions are
	invalid on windows
Message-ID: <20130523133200.C0FBD48CA7@hg.openjdk.java.net>

Changeset: f2a9de120e2d
Author:    jcoomes
Date:      2013-05-23 03:08 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/f2a9de120e2d

8014611: reserve_and_align() assumptions are invalid on windows
Summary: also reviewed by ron.durbin at oracle.com, thomas.schatzl at oracle.com
Reviewed-by: dcubed, brutisso

! src/os/posix/vm/os_posix.cpp
! src/os/windows/vm/os_windows.cpp
! src/share/vm/runtime/os.cpp
! src/share/vm/runtime/os.hpp
! src/share/vm/runtime/virtualspace.cpp
! src/share/vm/runtime/virtualspace.hpp


From daniel.daugherty at oracle.com  Thu May 23 07:09:52 2013
From: daniel.daugherty at oracle.com (Daniel D. Daugherty)
Date: Thu, 23 May 2013 08:09:52 -0600
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
In-Reply-To: <519DB226.4070405@oracle.com>
References: <519A4B39.20208@oracle.com> <519AF0D4.4080102@oracle.com>
	<519B3879.1050301@oracle.com> <519D4216.2060906@oracle.com>
	<519D48E6.9090801@oracle.com> <519D57CB.6070103@oracle.com>
	<519D628B.4020807@oracle.com> <519DB226.4070405@oracle.com>
Message-ID: <519E2330.7070700@oracle.com>

Aleksey,

You can still use distinct changesets to keep the various bug fixes
separate, but send out the entire batch of fixes in one webrev. I
think my personal record was something like 7 or 8 suspend/resume
bug fixes in one batch... :-)

Of course, that complicates things if changes need to be made to
any of the changesets earlier than the tip...

Dan


On 5/23/13 12:07 AM, Aleksey Shipilev wrote:
> On 05/23/2013 04:27 AM, Coleen Phillimore wrote:
>>> I have to say that the number of deferrals of issues to new bugs
>>> during a current bug's review cycle along with the general bug
>>> tail of @Contended is making me very nervous. It's starting to feel
>>> like we're just stumbling around wearing a bucket and have a very
>>> limited view of the horizon due to the bucket.
>> I interpret this as a second request to fix all the bugs and
>> cleanups in one change and let us review that change.
> Thanks, I will comply with this request.
>
> I would like to note that requests using the form of "please merge all
> bugfixes and cleanups into the single CR" are more effective as the
> communication means, rather than relying on other reviewers to
> re-interpret what is being requested. :)
>
> For the record, I still think this is a bad idea to merge the histories
> for several related, but distinct issues together, even if the changes
> are small, on the pretense it makes the bulk review easier. But, as I
> said, will disagree and commit.
>
>> I don't think it needs to be backed out because it only affects the
>> contended tests and that's not in the JDK yet (or is it?)   Is it
>> breaking code that doesn't use it?
> There is no @Contended classes/fields in JDK (yet). We are waiting for
> this VM code to stabilize before committing to @Contended in the library.
>
> -Aleksey.


From joseph.provino at oracle.com  Thu May 23 07:52:53 2013
From: joseph.provino at oracle.com (Joseph Provino)
Date: Thu, 23 May 2013 10:52:53 -0400
Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace
	in libjvm.symbols that does not exist in minimal/libjvm.a when
	DEBUG_LEVEL == release
In-Reply-To: <519D5E40.3010407@oracle.com>
References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com>
	<D0297B1A-9156-4C1D-ADF6-6C4623F9A07E@oracle.com>
	<519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com>
	<5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com>
	<519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com>
	<519BC8A8.5060909@oracle.com> <519BD250.10302@oracle.com>
	<519BDE85.6000005@oracle.com> <519D1C10.90302@oracle.com>
	<519D5E40.3010407@oracle.com>
Message-ID: <519E2D45.3050502@oracle.com>

David, thanks for finding that!

joe

On 05/22/2013 08:09 PM, David Holmes wrote:
> Joe,
>
> On 23/05/2013 5:27 AM, Joseph Provino wrote:
>> Is there a consensus what is in the webrev is okay?
>
> Yes I am now okay with it. I found this in 4889433:
>
> "AsyncGetCallTrace() requires the CLASS_LOAD event
> to be enabled because that causes jmethodID's to be created for the
> methods at class load time. This increases the likelyhood of being
> able to get the jmethodID for a frame during a stackwalk. Since
> AsyncGetCallTrace() cannot block, it uses a special routine to the
> get the jmethodID that does not block if the jmethodID is not available
> immediately. So while CLASS_LOAD events are not strictly required, the
> data gathered during the stackwalk would be pretty useless."
>
> So reporting the ticks_no_class_load value seems quite reasonable and 
> the clients of this interface should be expecting it.
>
> Thanks,
> David
>
>> The change is to include forte.cpp in the minimal jvm but to
>> conditionalize the code so that only AsyncGetCallTrace()
>> is defined with the minimal jvm.
>>
>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.01
>>
>>      JDK-8013461 https://jbs.oracle.com/bugs/browse/JDK-8013461
>>      There is a symbol AsyncGetCallTrace in libjvm.symbols that does not
>> exist in
>>      minimal/libjvm.a when DEBUG_LEVEL == release
>>
>> joe
>>
>> On 05/21/2013 04:52 PM, JOSEPH PROVINO wrote:
>>>
>>> On 5/21/2013 4:00 PM, Oleg Mazurov wrote:
>>>> Though formally not part of the Solaris Studio team any more here is
>>>> my opinion based on my recollection of how I implemented interaction
>>>> with the JVM via AsyncGetCallTrace.
>>>> It's looked up using dlsym. If the symbol is not there Java callstack
>>>> collection is shut down. I understand in your case even JVMTI is not
>>>> there so the dlsym call will not be made.
>>>> From that perspective there is no difference whether the symbol is
>>>> present and returns an error code or not present at all.
>>>
>>> Oleg, then it sounds like what we have will work.
>>>
>>> Thanks for the quick reply.
>>>
>>> joe
>>>
>>>>
>>>>     -- Oleg
>>>>
>>>> On 5/21/2013 12:19 PM, JOSEPH PROVINO wrote:
>>>>>
>>>>> On 5/21/2013 3:16 PM, serguei.spitsyn at oracle.com wrote:
>>>>>> On 5/21/13 11:26 AM, JOSEPH PROVINO wrote:
>>>>>>>
>>>>>>> On 5/21/2013 2:23 PM, Staffan Larsen wrote:
>>>>>>>> On 21 maj 2013, at 17:35, JOSEPH PROVINO
>>>>>>>> <joseph.provino at oracle.com> wrote:
>>>>>>>>
>>>>>>>>> On 5/21/2013 3:06 AM, David Holmes wrote:
>>>>>>>>>> Hi Staffan,
>>>>>>>>>>
>>>>>>>>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote:
>>>>>>>>>>> On 21 maj 2013, at 04:34, David Holmes
>>>>>>>>>>> <David.Holmes at oracle.com> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> <added servicability>
>>>>>>>>>>>>
>>>>>>>>>>>> Hi Joe,
>>>>>>>>>>>>
>>>>>>>>>>>> As I have previously stated you copied the struct definitions
>>>>>>>>>>>> instead of moving them outside the ifdef.
>>>>>>>>>>>>
>>>>>>>>>>>> Serviceability folk: we are particularly interested in
>>>>>>>>>>>> whether the use of ticks_no_class_load is deemed appropriate
>>>>>>>>>>>> in this situation. Who will be consuming this value?
>>>>>>>>>>> Since you have opted for the simple fix of having an exported
>>>>>>>>>>> but non-functional AsyncGetCallTrace instead of actually
>>>>>>>>>>> removing the symbol from the symbol files (which is the
>>>>>>>>>>> proposed solution in the bug report),
>>>>>>>>>> That would be a simpler solution semantically but the only way
>>>>>>>>>> I can see to do that is to use a text replacement mechanism in
>>>>>>>>>> the build files - as is done for the dynamic vtable symbols. I
>>>>>>>>>> find that less appealing than simply exporting an interface
>>>>>>>>>> that is configured to report an error (which is essentially
>>>>>>>>>> what all the optional interfaces do under the minimal VM).
>>>>>>>>>>
>>>>>>>>>>> I would like you to include a comment about this in the
>>>>>>>>>>> source. Right now it's very unclear why there is an exported
>>>>>>>>>>> function that only returns an error.
>>>>>>>>>>>
>>>>>>>>>>> As to the appropriate return value, I don't know. The only
>>>>>>>>>>> caller should be the Sun Studio profiler,
>>>>>>> Does anyone know where to find instructions on how to run the
>>>>>>> collector which would get the error return value?
>>>>>>>>>>>   and I'm not sure how it will handle this case if ever run.
>>>>>>>>>>> The possible return values aren't very well documented.
>>>>>>>>>> I guess we need to try and run it to find out.
>>>>>>>>> Okay, do either of you feel strongly about how this should be
>>>>>>>>> fixed -- return an error or remove the symbol?
>>>>>>>> No, I don't feel strongly either way, but a comment in the code
>>>>>>>> would be nice.
>>>>>>> How much effort should I put into finding out what Sun Studio
>>>>>>> profiler does when it gets -1?
>>>>>>
>>>>>> Let's ask the Solaris Studio guys directly.
>>>>>> I'm adding Oleg to the mailing list.
>>>>>>
>>>>>> Oleg,
>>>>>>
>>>>>> Could you, please, share your view on this problem?
>>>>>
>>>>> In particular what will the Sun Studio Profiler collector do if it
>>>>> gets the error
>>>>>
>>>>> trace->num_frames = ticks_no_class_load; // -1
>>>>>
>>>>> Thanks.
>>>>>
>>>>> joe
>>>>>
>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> Serguei
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> joe
>>>>>>>
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> /Staffan
>>>>>>>>
>>>>>>>>
>>>>>>>>> joe
>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>> David
>>>>>>>>>>
>>>>>>>>>>> /Staffan
>>>>>>>>>>>
>>>>>>>>>>>> Thanks,
>>>>>>>>>>>> David
>>>>>>>>>>>>
>>>>>>>>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>>>>>>>>>>>>> The change is to include forte.cpp in the minimal jvm but to
>>>>>>>>>>>>> conditionalize the code so that
>>>>>>>>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Webrev is here:
>>>>>>>>>>>>> http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>>>>>>>>>>>>
>>>>>>>>>>>>>   * JDK-8013461
>>>>>>>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>>>>>>>>>>>>     a symbol AsyncGetCallTrace in libjvm.symbols that does
>>>>>>>>>>>>> not exist in
>>>>>>>>>>>>>     minimal/libjvm.a when DEBUG_LEVEL == release
>>>>>>>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks.
>>>>>>>>>>>>>
>>>>>>>>>>>>> joe
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>


From vladimir.danushevsky at oracle.com  Thu May 23 08:58:44 2013
From: vladimir.danushevsky at oracle.com (Vladimir Danushevsky)
Date: Thu, 23 May 2013 11:58:44 -0400
Subject: RFR: 8013398: Adjust number of stack guard pages on systems with
	large memory page size
In-Reply-To: <517EAF81.4030309@oracle.com>
References: <C6C003C8-61A5-449B-8C25-38929F845678@oracle.com>
	<CA+3eh10zoqH-b3qBH8PDugeuP39OcgyE--tB036JVzejwHwnzw@mail.gmail.com>
	<8A85EDB0-C7C1-4695-8EA0-71AD6D9EA4E0@oracle.com>
	<CA+3eh11=wdo+DgQOx=U9vx+Pc=YbuM-qwTOSmYXwycqG7HUH7A@mail.gmail.com>
	<517EAF81.4030309@oracle.com>
Message-ID: <65D31F0A-99CD-45D3-80BF-96D1C44BAF80@oracle.com>

I would like to backport same change to JDK7 (unless someone objects).

Please see the webrev (which no different than the JDK8 one):
http://cr.openjdk.java.net/~vladidan/8013398.jdk7/webrev.00/

Thanks,
Vlad

On Apr 29, 2013, at 1:36 PM, Coleen Phillimore wrote:

> 
> Hi Volker,
> 
> When looking at Vlad's change, I was thinking along these lines. StackYellowPages, RedPages and ShadowPages would be better specified as a size in bytes rather than page size to account for the differences in page sizes on different platforms.
> 
> The stack banging code is done in increments of "page_size" though, and the protection code has to be done on page size boundaries.   So there has to be some platform specific rounding to get the number of pages.   I think the code change that Vlad sent is the minimally disruptive way to do this.   Adding new options for StackShadowSize and all that will just confuse people, I think.   We tell people to use different StackShadowPages all the time and it's even in our documentation.
> 
> I guess we'll have to see your patch and it would be good to have your code to be in open.
> 
> Thanks,
> Coleen
> 
> On 04/29/2013 12:55 PM, Volker Simonis wrote:
>> On Mon, Apr 29, 2013 at 5:38 PM, Vladimir Danushevsky
>> <vladimir.danushevsky at oracle.com> wrote:
>>> Hi Volker,
>>> 
>>> Thanks for the suggestion.
>>> 
>>> If I understand your approach correctly you suggest providing a dual way to specify guard area sizes (ether through number of pages or through an absolute size in KB) and have the VM to correlate between the two: Size value will dominate unless explicitly overwritten by the Page value.
>>> Is that correct?
>>> 
>> Yes, that's correct. The *Page values should become obsolete although
>> I think there's currently no mechanism for that in OpenJDK.
>> 
>> Internally, i.e. in globals_<ARCH>.hpp, we could define the values
>> independently of the actual system page size with the *Size flags.
>> 
>>> Will your approach eventually get same amount of allocated guard area as the patch suggested earlier would?
>> I think more or less yes:) It would depend on the settings of the
>> *Size flags of course.
>> 
>> E.g. currently on AMD64 we have:
>> 
>> define_pd_global(intx, StackYellowPages, 2);
>> define_pd_global(intx, StackRedPages, 1);
>> define_pd_global(intx, StackShadowPages, NOT_WIN64(20) WIN64_ONLY(6)
>> DEBUG_ONLY(+2));
>> 
>> With your fix and a page size of 64K we would get:
>> 
>> StackYellowPages = 1;
>> StackRedPages = 1;
>> StackShadowPages = round_to((StackShadowPages * 8K), 64K) / 64K =
>> round_to(20 * 8K, 64K) / 64K = 3
>> 
>> and:
>> 
>> min_staqck =
>> (StackYellowPages+StackRedPages+StackShadowPages) * Linux::page_size() +
>> (2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::vm_default_page_size()
>> =
>> (1 + 1 + 3) * 64K +
>> (16 + 1) * 8K
>> =
>> 5 * 64K + 17 * 8K
>> =
>> 456K
>> 
>> With our proposed fix we would get:
>> 
>> define_pd_global(intx, StackYellowSize, 8K);
>> define_pd_global(intx, StackRedSize, 4K);
>> define_pd_global(intx, StackShadowSize, NOT_WIN64(80K) WIN64_ONLY(24K)
>> DEBUG_ONLY(+8K));
>> 
>> this would result in:
>> 
>> StackYellowPages = 1;
>> StackRedPages = 1;
>> StackShadowPages = 2
>> 
>> and:
>> 
>> min_staqck =
>> (StackYellowPages+StackRedPages+StackShadowPages) * Linux::page_size() +
>> (2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::vm_default_page_size()
>> =
>> (1 + 1 + 2) * 64K +
>> (16 + 1) * 8K
>> =
>> 4 * 64K + 17 * 8K
>> =
>> 392
>> 
>>> If an intent is to make the adjustments global (i.e. independent of the OS) should we copy those to the arguments.cpp instead of os_<OS name>.cpp?However  I'm not positive whether Windows, as an example, does need a guard area adjustment (but I might be wrong here).
>>> 
>> I think the adjustment should stay in the platform dependent code.
>> 
>>> Please post the webrev with the approach you suggested. It should be viewed as an alternative.
>> I'll prepare it.
>> 
>> Just one question - why did you choose:
>> 
>> _vm_default_page_size = 8K
>> 
>> Shouldn't this really be 4K?
>> 
>>> Thanks,
>>> Vlad
>>> 
>>> 
>>> On Apr 29, 2013, at 11:03 AM, Volker Simonis wrote:
>>> 
>>>> Hi Vlad,
>>>> 
>>>> thanks for addressing this issue. We have this problem as well since
>>>> long time and we would like to propose a more general solution:
>>>> 
>>>> Introduce three new platform dependant product flags:
>>>> 
>>>> StackYellowSize
>>>> StackRedSize
>>>> StackShadowSize
>>>> 
>>>> which are to be used to specify the concrete size of the corresponding
>>>> stack regions. These sizes would be rounded up to the next multiple of
>>>> the current OS page size (or more precisely the next multiple of the
>>>> current OS stack page size, because there are systems which have
>>>> different page sizes for stacks than for heap).
>>>> 
>>>> This would allow us to make simple, (i.e. not platform dependent)
>>>> product flags out of:
>>>> 
>>>> StackYellowPages
>>>> StackRedPages
>>>> StackShadowPages
>>>> 
>>>> and set their default value to -1.
>>>> 
>>>> At VM start-up, before argument parsing, we will compute the values
>>>> for StackYellowPages, StackRedPages, StackShadowPages from
>>>> StackYellowSize, StackRedSize, StackShadowSize and the actual OS page
>>>> size. Later on, during argument parsing, if one of these flags is
>>>> given on the command line, either part of these value pairs may be
>>>> adjusted in order to be consistent with its counterpart.
>>>> 
>>>> The drawback of this approach is that you get three more options but
>>>> from our point of view this is outweighed by the fact that with this
>>>> approach you 'fix' all the places where you currently waste a lot of
>>>> memory if the VM is running on a system with a default page size
>>>> bigger than 4K.
>>>> 
>>>> Notice that we use this approach since years in our commercial VM and
>>>> only haven't integrated it into our OpenJDK PowerPC/AIX Port because
>>>> we wanted to minimize the amount of shared code changes. We would be
>>>> happy however to contribute it now that the discussion on this problem
>>>> has popped up publicly on the mailing list. So if you agree, I could
>>>> post a webrev with the proposed changes.
>>>> 
>>>> Regards,
>>>> Volker
>>>> 
>>>> On Sat, Apr 27, 2013 at 2:34 AM, Vladimir Danushevsky
>>>> <vladimir.danushevsky at oracle.com> wrote:
>>>>> Please review the following change:
>>>>> 
>>>>> http://cr.openjdk.java.net/~vladidan/8013398/webrev.00/
>>>>> 
>>>>> for
>>>>> https://jbs.oracle.com/bugs/browse/JDK-8013398
>>>>> 
>>>>> On a non-typical Linux system configuration with large page size (e.g. 64KB) significant amount of virtual memory is wasted to multiple guard pages when in fact that can be reduced to a single page per Red/Yellow/Shadow categories.
>>>>> In some edge cases a minimal stack requirement is calculated higher than actual stack size specified by ThreadStackSize parameter causing VM to abort unless stack size is overwritten via -Xss option.
>>>>> 
>>>>> A patch currently being suggested adjusts amount of guard pages to a single memory page each along with minimal stack size when memory page size exceed 8KB unless explicitly overwritten in command line.
>>>>> 
>>>>> Currently we are aware of the problem on some Linux platforms, therefore the change is specific to that OS only (Solaris carries a similar approach already).
>>>>> 
>>>>> Shall the description string of StackRedPage, StackYellowPages and StackShadow pages be modified to reflect the values could be scaled down? If so the comment needs to indicate the change affects Linux and Solaris only. Any comments welcome here.
>>>>> 
>>>>> Thanks,
>>>>> Vlad
> 


From aleksey.shipilev at oracle.com  Thu May 23 09:33:32 2013
From: aleksey.shipilev at oracle.com (Aleksey Shipilev)
Date: Thu, 23 May 2013 20:33:32 +0400
Subject: RFR (S) CR 8014886: @Contended fields can overrun oop maps
In-Reply-To: <519E1169.8020905@cs.oswego.edu>
References: <519A4B39.20208@oracle.com> <519AF0D4.4080102@oracle.com>
	<519B3879.1050301@oracle.com> <519D4216.2060906@oracle.com>
	<519D48E6.9090801@oracle.com> <519D57CB.6070103@oracle.com>
	<519D628B.4020807@oracle.com> <519DB226.4070405@oracle.com>
	<519E0E55.1080905@oracle.com> <519E1169.8020905@cs.oswego.edu>
Message-ID: <519E44DC.5000403@oracle.com>

On 05/23/2013 04:54 PM, Doug Lea wrote:
> 
> On 05/23/2013 02:07 AM, Aleksey Shipilev wrote:
> 
>>> There is no @Contended classes/fields in JDK (yet). We are waiting for
>>> this VM code to stabilize before committing to @Contended in the
>>> library.
>>>
> 
> This state of affairs will change soon (we hope). A bunch of
> uses in updated java.util.concurrent classes will be integrated
> into jdk8/tl. None of these usages are known to hit the existing
> bugs though.

Yes, and the reason for that is, current bugs are the corner cases for
@C over the fields. Most pending jsr166 usages are for @C on the class.
I'm putting the Thread.TLR marks on hold before these issues are fixed,
hopefully next week.

-Aleksey.


From ioi.lam at oracle.com  Thu May 23 09:35:47 2013
From: ioi.lam at oracle.com (Ioi Lam)
Date: Thu, 23 May 2013 09:35:47 -0700
Subject: RFR (S) JDK-8014912 Restore PrintSharedSpaces after NPG
In-Reply-To: <3531252B-5041-407D-B355-68492CEBCD6E@oracle.com>
References: <519BF549.3070808@oracle.com> <519D753E.8040009@oracle.com>
	<3531252B-5041-407D-B355-68492CEBCD6E@oracle.com>
Message-ID: <519E4563.4000103@oracle.com>

On 05/23/2013 06:32 AM, Karen Kinnear wrote:
> Ioi,
>
> This will be really helpful - in fact we'd like to use it right now :-)
> Would it be hard to track the read-only and read-write separately, so we could at a glance
> 1) see what metadata is ro vs. rw and
> 2) see subtotal sizes and percentages (of combined ro/rw) for ro/rw?
Hi Karen,

The printed table contains 3 columns:  ro, rw, all (ro+rw combined).

Do you mean moving the ro, rw and all into separate rows?

Thanks
- Ioi

> thanks,
> Karen
> On May 22, 2013, at 9:47 PM, Coleen Phillimore wrote:
>
>> Ioi,
>>
>> This looks really good.  The only thing is that we have code to create histograms in the VM (see utilities/histogram.hpp). Couldn't you reuse this class instead of writing your own histogram creating function?   It would sort your data for you!  I don't know if it would have the data you are looking for but lots of other jvm code uses this class for a similar purpose.
>>
>> Thanks,
>> Coleen
>>
>> On 5/21/2013 6:29 PM, Ioi Lam wrote:
>>> Please review:
>>>
>>> http://cr.openjdk.java.net/~iklam/8014912/print_sharedspc_001/
>>>
>>> Bug: Restore PrintSharedSpaces functionality after NPG
>>>
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014912
>>>     https://jbs.oracle.com/bugs/browse/JDK-8014912
>>>
>>> Summary of fix:
>>>
>>> I added a new enum, MetaspaceObj::Type, which is passed to
>>>
>>>     Metaspace::allocate(ClassLoaderData* loader_data, size_t word_size,
>>>                         bool read_only, MetaspaceObj::Type type, TRAPS);
>>>
>>> During CDS dumping, all allocations are logged in a linked list to
>>> be processed later by metaspaceShared.cpp to generate statistics for
>>> objects in the CDS archive. See sample output below.
>>>
>>> * No such logging is doneat normal VM execution time so there
>>>   is no performance impact.
>>>
>>> * I verified that the patch can be applied cleanly on Jon's
>>>   recentpatch for JDK-8014862 "Add fast Metasapce capacity and
>>>   used per MetadataType"
>>>
>>> http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/2b1a9d972fc2
>>>
>>> Testing:
>>>
>>>     JPRT, UTE (vm.quick.testlist)
>>>
>>> Sample output:
>>>
>>>                         ro_cnt   ro_bytes     % | rw_cnt rw_bytes     % |  all_cnt  all_bytes     %
>>> --------------------+---------------------------+---------------------------+--------------------------
>>> Unknown             :        1         64   0.0 | 1         64 0.0 |        2        128   0.0
>>> Class               :        0          0   0.0 | 2364    2006080 14.7 |     2364    2006080   9.2
>>> Symbol              :    49858    2507168  30.9 | 0          0 0.0 |    49858    2507168  11.5
>>> TypeArrayU1         :    13264     608336   7.5 | 2365 428784   3.1 |    15629    1037120   4.8
>>> TypeArrayU2         :     4796     341952   4.2 | 0          0 0.0 |     4796     341952   1.6
>>> TypeArrayU4         :     2371     178528   2.2 | 0          0 0.0 |     2371     178528   0.8
>>> TypeArrayU8         :     3708     365920   4.5 | 0          0 0.0 |     3708     365920   1.7
>>> TypeArrayOther      :        0          0   0.0 | 0          0 0.0 |        0          0   0.0
>>> Method              :        0          0   0.0 | 32552 3659888  26.8 |    32552    3659888  16.8
>>> ConstMethod         :    32552    4099008  50.6 | 0          0 0.0 |    32552    4099008  18.8
>>> MethodData          :        0          0   0.0 | 0          0 0.0 |        0          0   0.0
>>> ConstantPool        :        0          0   0.0 | 2365    3225600 23.6 |     2365    3225600  14.8
>>> ConstantPoolCache   :        0          0   0.0 | 2350    2212320 16.2 |     2350    2212320  10.2
>>> Annotation          :       26       1248   0.0 | 0          0 0.0 |       26       1248   0.0
>>> MethodCounters      :        0          0   0.0 | 0          0 0.0 |        0          0   0.0
>>> SymbolHashentry     :        0          0   0.0 | 49858 1595456  11.7 |    49858    1595456   7.3
>>> SymbolBuckets       :        0          0   0.0 | 20011 320176   2.3 |    20011     320176   1.5
>>> Other               :        0          0   0.0 | 0     203893 1.5 |        0     203893   0.9
>>> --------------------+---------------------------+---------------------------+--------------------------
>>> Total               :   106576    8102224 100.0 | 111866 13652261 100.0 |   218442   21754485 100.0
>>>
>>>
>>> Thanks,
>>> Ioi
>>>
>>>


From ioi.lam at oracle.com  Thu May 23 09:51:06 2013
From: ioi.lam at oracle.com (Ioi Lam)
Date: Thu, 23 May 2013 09:51:06 -0700
Subject: RFR (S) JDK-8014912 Restore PrintSharedSpaces after NPG
In-Reply-To: <519D753E.8040009@oracle.com>
References: <519BF549.3070808@oracle.com> <519D753E.8040009@oracle.com>
Message-ID: <519E48FA.4000209@oracle.com>

Coleen,

I looked at histogram.hpp, but it has only one _count field:

    class HistogramElement : public CHeapObj<mtInternal> {
      protected:
       jint _count;
       const char* _name;

      public:
       HistogramElement();
       virtual int count();
       virtual const char* name();
       virtual void increment_count();
       void print_on(outputStream* st) const;
       virtual int compare(HistogramElement* e1,HistogramElement* e2);
    };

For my purpose, I would need a count and size for each subtype of 
metadata, so it doesn't look like this class is immediately usable for me.

I am actually planning (with a different bug ID) to dump a detailed "map 
file" of every object in CDS. Now that I record all the allocations 
under Metaspace::_alloc_record_head, I can iterate over them and call, 
for example, Method::print_codes_on() on all the methods. This will 
allow you to do all kinds of analysis, like

     How many unquickened getfield bytecodes are inside CDS
     How many methods contain unquickened bytecodes

... etc. When we were doing Monty's romizer, a mapfile like this was 
very helpful in identifying possible areas for improvements.

While I do that, I can also dump a table of the size distribution of 
each type objects in a histogram format, similar to 
PrintSymbolTableSizeHistogram.

Thanks
- Ioi


On 05/22/2013 06:47 PM, Coleen Phillimore wrote:
>
> Ioi,
>
> This looks really good.  The only thing is that we have code to create 
> histograms in the VM (see utilities/histogram.hpp). Couldn't you reuse 
> this class instead of writing your own histogram creating function?   
> It would sort your data for you!  I don't know if it would have the 
> data you are looking for but lots of other jvm code uses this class 
> for a similar purpose.
>
> Thanks,
> Coleen
>
> On 5/21/2013 6:29 PM, Ioi Lam wrote:
>> Please review:
>>
>> http://cr.openjdk.java.net/~iklam/8014912/print_sharedspc_001/
>>
>> Bug: Restore PrintSharedSpaces functionality after NPG
>>
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014912
>>     https://jbs.oracle.com/bugs/browse/JDK-8014912
>>
>> Summary of fix:
>>
>> I added a new enum, MetaspaceObj::Type, which is passed to
>>
>>     Metaspace::allocate(ClassLoaderData* loader_data, size_t word_size,
>>                         bool read_only, MetaspaceObj::Type type, TRAPS);
>>
>> During CDS dumping, all allocations are logged in a linked list to
>> be processed later by metaspaceShared.cpp to generate statistics for
>> objects in the CDS archive. See sample output below.
>>
>> * No such logging is doneat normal VM execution time so there
>>   is no performance impact.
>>
>> * I verified that the patch can be applied cleanly on Jon's
>>   recentpatch for JDK-8014862 "Add fast Metasapce capacity and
>>   used per MetadataType"
>>
>> http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/2b1a9d972fc2
>>
>> Testing:
>>
>>     JPRT, UTE (vm.quick.testlist)
>>
>> Sample output:
>>
>>                         ro_cnt   ro_bytes     % | rw_cnt rw_bytes     
>> % |  all_cnt  all_bytes     %
>> --------------------+---------------------------+---------------------------+-------------------------- 
>>
>> Unknown             :        1         64   0.0 | 1         64 0.0 
>> |        2        128   0.0
>> Class               :        0          0   0.0 | 2364 2006080 14.7 
>> |     2364    2006080   9.2
>> Symbol              :    49858    2507168  30.9 | 0          0 0.0 
>> |    49858    2507168  11.5
>> TypeArrayU1         :    13264     608336   7.5 | 2365 428784 3.1 
>> |    15629    1037120   4.8
>> TypeArrayU2         :     4796     341952   4.2 | 0          0 0.0 
>> |     4796     341952   1.6
>> TypeArrayU4         :     2371     178528   2.2 | 0          0 0.0 
>> |     2371     178528   0.8
>> TypeArrayU8         :     3708     365920   4.5 | 0          0 0.0 
>> |     3708     365920   1.7
>> TypeArrayOther      :        0          0   0.0 | 0          0 0.0 
>> |        0          0   0.0
>> Method              :        0          0   0.0 | 32552 3659888 26.8 
>> |    32552    3659888  16.8
>> ConstMethod         :    32552    4099008  50.6 | 0          0 0.0 
>> |    32552    4099008  18.8
>> MethodData          :        0          0   0.0 | 0          0 0.0 
>> |        0          0   0.0
>> ConstantPool        :        0          0   0.0 | 2365 3225600 23.6 
>> |     2365    3225600  14.8
>> ConstantPoolCache   :        0          0   0.0 | 2350 2212320 16.2 
>> |     2350    2212320  10.2
>> Annotation          :       26       1248   0.0 | 0          0 0.0 
>> |       26       1248   0.0
>> MethodCounters      :        0          0   0.0 | 0          0 0.0 
>> |        0          0   0.0
>> SymbolHashentry     :        0          0   0.0 | 49858 1595456 11.7 
>> |    49858    1595456   7.3
>> SymbolBuckets       :        0          0   0.0 | 20011 320176 2.3 
>> |    20011     320176   1.5
>> Other               :        0          0   0.0 | 0     203893 1.5 
>> |        0     203893   0.9
>> --------------------+---------------------------+---------------------------+-------------------------- 
>>
>> Total               :   106576    8102224 100.0 | 111866 13652261 
>> 100.0 |   218442   21754485 100.0
>>
>>
>> Thanks,
>> Ioi
>>
>>
>


From bill.pittore at oracle.com  Thu May 23 09:57:05 2013
From: bill.pittore at oracle.com (BILL PITTORE)
Date: Thu, 23 May 2013 12:57:05 -0400
Subject: Backport fix for JDK-8014669 to JDK7
Message-ID: <519E4A61.6050809@oracle.com>

Would like to backport the fix for 
https://jbs.oracle.com/bugs/browse/JDK-8014669, "arch specific flags not 
passed to some link commands" to JDK7. Same fix as for JDK8:

http://cr.openjdk.java.net/~bpittore/8014669/webrev.01/

thanks,
bill



On 5/15/2013 9:37 PM, BILL PITTORE wrote:
> I'm fine with these changes. I can commit if someone can do the push 
> if you think we need to get this in tonight.
>
> bill
>
> On 5/15/2013 8:43 PM, David Holmes wrote:
>> Hi Bill,
>>
>> On 16/05/2013 10:05 AM, David Holmes wrote:
>>> Hi Bill,
>>>
>>> (re-fixed the build-dev alias)
>>>
>>> On 16/05/2013 6:48 AM, BILL PITTORE wrote:
>>>> Some architecture dependent flags do not make it through to the
>>>> libjsig.so and libsaproc.so makefiles. As a result, the libs are not
>>>> compiled/linked with the correct flags for that particular variant. 
>>>> Fix
>>>> is to make sure EXTRA_CFLAGS propogates down correctly.
>>>>
>>>> http://cr.openjdk.java.net/~bpittore/8014669/webrev.00/
>>>
>>> I need to look closer at this. Passing all of the EXTRA_CFLAGS as link
>>> options seems wrong to me as they may not be valid linker options. That
>>> said I see that in this case we are actually using the C compiler to do
>>> the linking. But that said, in the saproc case we are also compiling C
>>> source files at the same time which means that EXTRA_CFLAGS is 
>>> needed on
>>> the main command line, not tucked onto the LD flags. And the 
>>> implication
>>> here is that cross-compilation of libsaproc has been broken all this
>>> time for any platform where the default gcc output would be wrong!
>>
>> Given in both cases we use CC to compile and link I think the more 
>> explicit solution here is to add EXTRA_CFLAGS as a primary argument 
>> to the $(CC) invocation  - see below.
>>
>> Thanks,
>> David
>>
>> diff -r 293b99787401 make/linux/makefiles/jsig.make
>> --- a/make/linux/makefiles/jsig.make
>> +++ b/make/linux/makefiles/jsig.make
>> @@ -54,7 +54,7 @@
>>  $(LIBJSIG): $(JSIGSRCDIR)/jsig.c $(LIBJSIG_MAPFILE)
>>         @echo Making signal interposition lib...
>>         $(QUIETLY) $(CC) $(SYMFLAG) $(ARCHFLAG) $(SHARED_FLAG) 
>> $(PICFLAG) \
>> -                         $(LFLAGS_JSIG) $(JSIG_DEBUG_CFLAGS) -o $@ 
>> $< -ldl
>> +                         $(LFLAGS_JSIG) $(JSIG_DEBUG_CFLAGS) 
>> $(EXTRA_CFLAGS) -o $@ $< -ldl
>>  ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
>>         $(QUIETLY) $(OBJCOPY) --only-keep-debug $@ $(LIBJSIG_DEBUGINFO)
>>         $(QUIETLY) $(OBJCOPY) 
>> --add-gnu-debuglink=$(LIBJSIG_DEBUGINFO) $@
>> diff -r 293b99787401 make/linux/makefiles/saproc.make
>> --- a/make/linux/makefiles/saproc.make
>> +++ b/make/linux/makefiles/saproc.make
>> @@ -92,6 +92,7 @@
>> $(SASRCFILES)                                        \
>> $(SA_LFLAGS)                                         \
>> $(SA_DEBUG_CFLAGS)                                   \
>> + $(EXTRA_CFLAGS) \
>>                    -o 
>> $@                                                \
>>                    -lthread_db
>>  ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
>>
>
>



From jiangli.zhou at oracle.com  Thu May 23 13:24:21 2013
From: jiangli.zhou at oracle.com (jiangli.zhou at oracle.com)
Date: Thu, 23 May 2013 20:24:21 +0000
Subject: hg: hsx/hotspot-main/hotspot: 4 new changesets
Message-ID: <20130523202432.433CD48CBF@hg.openjdk.java.net>

Changeset: 293b99787401
Author:    dholmes
Date:      2013-05-14 07:24 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/293b99787401

8014460: Need to check for non-empty EXT_LIBS_PATH before using it
Reviewed-by: tbell, collins, sla, coleenp

! make/bsd/makefiles/arm.make
! make/linux/makefiles/arm.make

Changeset: 26579ac80ce9
Author:    bpittore
Date:      2013-05-15 23:06 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/26579ac80ce9

8014669: arch specific flags not passed to some link commands
Summary: EXTRA_CFLAGS does not propagate to saproc and jsig makefiles
Reviewed-by: dholmes, tbell, collins

! make/linux/makefiles/jsig.make
! make/linux/makefiles/saproc.make

Changeset: f8c833eb2a5f
Author:    jiangli
Date:      2013-05-20 13:13 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f8c833eb2a5f

Merge


Changeset: c838b672691c
Author:    jiangli
Date:      2013-05-23 13:40 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/c838b672691c

Merge



From serguei.spitsyn at oracle.com  Thu May 23 16:19:00 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Thu, 23 May 2013 16:19:00 -0700
Subject: Review Request (S) 8014288: perf regression in nashorn JDK-8008448.js
	test after 8008511 changes
Message-ID: <519EA3E4.2040900@oracle.com>

Please, review the fix for:
   bug: http://bugs.sun.com/view_bug.do?bug_id=8014288
   jbs: https://jbs.oracle.com/bugs/browse/JDK-8014288

Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014288-JVMTI-JSR292.1/

Summary:
   The fix of the 8008511 introduced a performance regression for the 
Nashorn tests.
   The fix is to use method_idnum() for direct indexing into the 
MemberNameTable
   that replaces a linear search caused the regression.
   No new regression test is needed as the Nashorn tests show the 
performance is back to normal.

Testing:
   The vm/mlvm and Nashorn tests

Thanks,
Serguei

From christian.thalinger at oracle.com  Thu May 23 16:50:07 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Thu, 23 May 2013 16:50:07 -0700
Subject: Review Request (S) 8014288: perf regression in nashorn
	JDK-8008448.js test after 8008511 changes
In-Reply-To: <519EA3E4.2040900@oracle.com>
References: <519EA3E4.2040900@oracle.com>
Message-ID: <6AB83B9C-5C47-4A67-AF71-5187A6AA2EBA@oracle.com>

Looks good.  -- Chris

On May 23, 2013, at 4:19 PM, serguei.spitsyn at oracle.com wrote:

> Please, review the fix for:
>  bug: http://bugs.sun.com/view_bug.do?bug_id=8014288
>  jbs: https://jbs.oracle.com/bugs/browse/JDK-8014288
> 
> Open webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014288-JVMTI-JSR292.1/
> 
> Summary:
>  The fix of the 8008511 introduced a performance regression for the Nashorn tests.
>  The fix is to use method_idnum() for direct indexing into the MemberNameTable
>  that replaces a linear search caused the regression.
>  No new regression test is needed as the Nashorn tests show the performance is back to normal.
> 
> Testing:
>  The vm/mlvm and Nashorn tests
> 
> Thanks,
> Serguei


From vladimir.kozlov at oracle.com  Thu May 23 16:56:42 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Thu, 23 May 2013 16:56:42 -0700
Subject: Review Request (S) 8014288: perf regression in nashorn
	JDK-8008448.js test after 8008511 changes
In-Reply-To: <519EA3E4.2040900@oracle.com>
References: <519EA3E4.2040900@oracle.com>
Message-ID: <519EACBA.4050508@oracle.com>

This is good.

thanks,
Vladimir

On 5/23/13 4:19 PM, serguei.spitsyn at oracle.com wrote:
> Please, review the fix for:
>    bug: http://bugs.sun.com/view_bug.do?bug_id=8014288
>    jbs: https://jbs.oracle.com/bugs/browse/JDK-8014288
>
> Open webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014288-JVMTI-JSR292.1/
>
>
> Summary:
>    The fix of the 8008511 introduced a performance regression for the
> Nashorn tests.
>    The fix is to use method_idnum() for direct indexing into the
> MemberNameTable
>    that replaces a linear search caused the regression.
>    No new regression test is needed as the Nashorn tests show the
> performance is back to normal.
>
> Testing:
>    The vm/mlvm and Nashorn tests
>
> Thanks,
> Serguei

From serguei.spitsyn at oracle.com  Thu May 23 17:04:13 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Thu, 23 May 2013 17:04:13 -0700
Subject: Review Request (S) 8014288: perf regression in nashorn
	JDK-8008448.js test after 8008511 changes
In-Reply-To: <519EACBA.4050508@oracle.com>
References: <519EA3E4.2040900@oracle.com> <519EACBA.4050508@oracle.com>
Message-ID: <519EAE7D.4010304@oracle.com>

Vladimir and Christian,

Thank you for the reviews,
Serguei

On 5/23/13 4:56 PM, Vladimir Kozlov wrote:
> This is good.
>
> thanks,
> Vladimir
>
> On 5/23/13 4:19 PM, serguei.spitsyn at oracle.com wrote:
>> Please, review the fix for:
>>    bug: http://bugs.sun.com/view_bug.do?bug_id=8014288
>>    jbs: https://jbs.oracle.com/bugs/browse/JDK-8014288
>>
>> Open webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014288-JVMTI-JSR292.1/ 
>>
>>
>>
>> Summary:
>>    The fix of the 8008511 introduced a performance regression for the
>> Nashorn tests.
>>    The fix is to use method_idnum() for direct indexing into the
>> MemberNameTable
>>    that replaces a linear search caused the regression.
>>    No new regression test is needed as the Nashorn tests show the
>> performance is back to normal.
>>
>> Testing:
>>    The vm/mlvm and Nashorn tests
>>
>> Thanks,
>> Serguei


From david.holmes at oracle.com  Thu May 23 17:15:33 2013
From: david.holmes at oracle.com (David Holmes)
Date: Fri, 24 May 2013 10:15:33 +1000
Subject: Review Request (S) 8014288: perf regression in nashorn
	JDK-8008448.js test after 8008511 changes
In-Reply-To: <519EA3E4.2040900@oracle.com>
References: <519EA3E4.2040900@oracle.com>
Message-ID: <519EB125.5090007@oracle.com>

Hi Serguei,

I have two queries:

In MemberNameTable::add_member_name why do you not have 
assert_locked_or_safepoint(MemberNameTable_lock) ?

In MethodHandles::init_field_MemberName you deleted:

304   InstanceKlass::cast(field_holder())->add_member_name(mname);

apart from this seeming to be unrelated to the rest of the fix, does its 
removal make the previous 8 lines of comment unnecessary? (I confess I 
don't understand the relationship between the comment and the code anyway.)

Thanks,
David

On 24/05/2013 9:19 AM, serguei.spitsyn at oracle.com wrote:
> Please, review the fix for:
>    bug: http://bugs.sun.com/view_bug.do?bug_id=8014288
>    jbs: https://jbs.oracle.com/bugs/browse/JDK-8014288
>
> Open webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014288-JVMTI-JSR292.1/
>
>
> Summary:
>    The fix of the 8008511 introduced a performance regression for the
> Nashorn tests.
>    The fix is to use method_idnum() for direct indexing into the
> MemberNameTable
>    that replaces a linear search caused the regression.
>    No new regression test is needed as the Nashorn tests show the
> performance is back to normal.
>
> Testing:
>    The vm/mlvm and Nashorn tests
>
> Thanks,
> Serguei

From coleen.phillimore at oracle.com  Thu May 23 17:17:21 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Thu, 23 May 2013 20:17:21 -0400
Subject: Review Request (S) 8014288: perf regression in nashorn
	JDK-8008448.js test after 8008511 changes
In-Reply-To: <519EAE7D.4010304@oracle.com>
References: <519EA3E4.2040900@oracle.com> <519EACBA.4050508@oracle.com>
	<519EAE7D.4010304@oracle.com>
Message-ID: <519EB191.5010905@oracle.com>


They beat me to it.  Looks good to me too.  How did nashorn find this?  
Did they profile their tests?
Coleen

On 5/23/2013 8:04 PM, serguei.spitsyn at oracle.com wrote:
> Vladimir and Christian,
>
> Thank you for the reviews,
> Serguei
>
> On 5/23/13 4:56 PM, Vladimir Kozlov wrote:
>> This is good.
>>
>> thanks,
>> Vladimir
>>
>> On 5/23/13 4:19 PM, serguei.spitsyn at oracle.com wrote:
>>> Please, review the fix for:
>>>    bug: http://bugs.sun.com/view_bug.do?bug_id=8014288
>>>    jbs: https://jbs.oracle.com/bugs/browse/JDK-8014288
>>>
>>> Open webrev:
>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014288-JVMTI-JSR292.1/ 
>>>
>>>
>>>
>>> Summary:
>>>    The fix of the 8008511 introduced a performance regression for the
>>> Nashorn tests.
>>>    The fix is to use method_idnum() for direct indexing into the
>>> MemberNameTable
>>>    that replaces a linear search caused the regression.
>>>    No new regression test is needed as the Nashorn tests show the
>>> performance is back to normal.
>>>
>>> Testing:
>>>    The vm/mlvm and Nashorn tests
>>>
>>> Thanks,
>>> Serguei
>


From christian.thalinger at oracle.com  Thu May 23 17:22:21 2013
From: christian.thalinger at oracle.com (christian.thalinger at oracle.com)
Date: Fri, 24 May 2013 00:22:21 +0000
Subject: hg: hsx/hotspot-main/hotspot: 8 new changesets
Message-ID: <20130524002237.C337148CC6@hg.openjdk.java.net>

Changeset: 91eba9f82325
Author:    anoll
Date:      2013-05-16 15:46 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/91eba9f82325

8012371: Adjust Tiered compile threshold according to available space in code cache
Summary: Added command line parameter to define a threshold at which C1 compilation threshold for  is increased.
Reviewed-by: kvn, iveresov

! src/share/vm/code/codeCache.cpp
! src/share/vm/code/codeCache.hpp
! src/share/vm/runtime/advancedThresholdPolicy.cpp
! src/share/vm/runtime/advancedThresholdPolicy.hpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp

Changeset: ec922e5c545a
Author:    anoll
Date:      2013-05-22 10:28 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/ec922e5c545a

8012312: hsdis fails to compile with binutils-2.23.2
Summary: added <config.h> to header file to make hsdis compile with binutils 2.23.*
Reviewed-by: kvn, twisti

! src/share/tools/hsdis/hsdis.c

Changeset: b4907b24ed48
Author:    twisti
Date:      2013-05-22 11:44 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b4907b24ed48

Merge


Changeset: 1682bec79205
Author:    kvn
Date:      2013-05-22 09:02 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/1682bec79205

8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
Summary: Stop current iteration of loop opts if partial_peel() failed and it created node clones outside processed loop.
Reviewed-by: roland

! src/share/vm/opto/loopnode.hpp
! src/share/vm/opto/loopopts.cpp

Changeset: 71a2d06b9c2b
Author:    kvn
Date:      2013-05-22 17:39 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/71a2d06b9c2b

Merge


Changeset: 3f281b313240
Author:    kvn
Date:      2013-05-22 18:25 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/3f281b313240

8010927: Kitchensink crashed with SIGSEGV, Problematic frame: v ~StubRoutines::checkcast_arraycopy
Summary: Changed gen_write_ref_array_post_barrier() code on x64 to pass start address and number of copied oop elements. In generate_checkcast_copy() skip post barrier code if no elements are copied.
Reviewed-by: roland

! src/cpu/x86/vm/stubGenerator_x86_32.cpp
! src/cpu/x86/vm/stubGenerator_x86_64.cpp
+ test/compiler/8010927/Test8010927.java

Changeset: 01e51113b4f5
Author:    anoll
Date:      2013-05-23 14:11 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/01e51113b4f5

8014430: JRE crashes instead of stop compilation on full Code Cache. Internal Error (c1_Compiler.cpp:87)
Summary: Disable client compiler and switch to interpreter if there is not enough free space in the code cache.
Reviewed-by: kvn, twisti

! src/share/vm/c1/c1_Compiler.cpp
! src/share/vm/c1/c1_Compiler.hpp

Changeset: 59e18b573605
Author:    twisti
Date:      2013-05-23 15:30 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/59e18b573605

Merge



From serguei.spitsyn at oracle.com  Thu May 23 17:37:19 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Thu, 23 May 2013 17:37:19 -0700
Subject: Review Request (S) 8014288: perf regression in nashorn
	JDK-8008448.js test after 8008511 changes
In-Reply-To: <519EB125.5090007@oracle.com>
References: <519EA3E4.2040900@oracle.com> <519EB125.5090007@oracle.com>
Message-ID: <519EB63F.3050403@oracle.com>

Hi David,

On 5/23/13 5:15 PM, David Holmes wrote:
> Hi Serguei,
>
> I have two queries:
>
> In MemberNameTable::add_member_name why do you not have 
> assert_locked_or_safepoint(MemberNameTable_lock) ?

Nice catch, thanks.
It has to be there but I accidentally removed it.
Will fix it.

>
> In MethodHandles::init_field_MemberName you deleted:
>
> 304 InstanceKlass::cast(field_holder())->add_member_name(mname);
>
> apart from this seeming to be unrelated to the rest of the fix, does 
> its removal make the previous 8 lines of comment unnecessary? (I 
> confess I don't understand the relationship between the comment and 
> the code anyway.)

It is not related to the removed line.
I think, it is for the return value.
The line was removed because we decided to skip caching the field
MemberName's for now as they are not used yet.

Thanks,
Serguei

>
> Thanks,
> David
>
> On 24/05/2013 9:19 AM, serguei.spitsyn at oracle.com wrote:
>> Please, review the fix for:
>>    bug: http://bugs.sun.com/view_bug.do?bug_id=8014288
>>    jbs: https://jbs.oracle.com/bugs/browse/JDK-8014288
>>
>> Open webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014288-JVMTI-JSR292.1/ 
>>
>>
>>
>> Summary:
>>    The fix of the 8008511 introduced a performance regression for the
>> Nashorn tests.
>>    The fix is to use method_idnum() for direct indexing into the
>> MemberNameTable
>>    that replaces a linear search caused the regression.
>>    No new regression test is needed as the Nashorn tests show the
>> performance is back to normal.
>>
>> Testing:
>>    The vm/mlvm and Nashorn tests
>>
>> Thanks,
>> Serguei


From serguei.spitsyn at oracle.com  Thu May 23 17:46:39 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Thu, 23 May 2013 17:46:39 -0700
Subject: Review Request (S) 8014288: perf regression in nashorn
	JDK-8008448.js test after 8008511 changes
In-Reply-To: <519EB191.5010905@oracle.com>
References: <519EA3E4.2040900@oracle.com> <519EACBA.4050508@oracle.com>
	<519EAE7D.4010304@oracle.com> <519EB191.5010905@oracle.com>
Message-ID: <519EB86F.7090609@oracle.com>

On 5/23/13 5:17 PM, Coleen Phillimore wrote:
>
> They beat me to it.  Looks good to me too.  How did nashorn find 
> this?  Did they profile their tests?

Vladimir ran the Nashorn tests with the timing. :)
So that, I do the same to find out that a regression is disappeared.

Thanks for the review!
Serguei

> Coleen
>
> On 5/23/2013 8:04 PM, serguei.spitsyn at oracle.com wrote:
>> Vladimir and Christian,
>>
>> Thank you for the reviews,
>> Serguei
>>
>> On 5/23/13 4:56 PM, Vladimir Kozlov wrote:
>>> This is good.
>>>
>>> thanks,
>>> Vladimir
>>>
>>> On 5/23/13 4:19 PM, serguei.spitsyn at oracle.com wrote:
>>>> Please, review the fix for:
>>>>    bug: http://bugs.sun.com/view_bug.do?bug_id=8014288
>>>>    jbs: https://jbs.oracle.com/bugs/browse/JDK-8014288
>>>>
>>>> Open webrev:
>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014288-JVMTI-JSR292.1/ 
>>>>
>>>>
>>>>
>>>> Summary:
>>>>    The fix of the 8008511 introduced a performance regression for the
>>>> Nashorn tests.
>>>>    The fix is to use method_idnum() for direct indexing into the
>>>> MemberNameTable
>>>>    that replaces a linear search caused the regression.
>>>>    No new regression test is needed as the Nashorn tests show the
>>>> performance is back to normal.
>>>>
>>>> Testing:
>>>>    The vm/mlvm and Nashorn tests
>>>>
>>>> Thanks,
>>>> Serguei
>>
>


From alejandro.murillo at oracle.com  Thu May 23 17:47:42 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 24 May 2013 00:47:42 +0000
Subject: hg: hsx/hsx24/hotspot: 3 new changesets
Message-ID: <20130524004751.C047548CC7@hg.openjdk.java.net>

Changeset: af383e67806b
Author:    katleman
Date:      2013-05-22 16:01 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/af383e67806b

Added tag jdk7u40-b26 for changeset 43fd44b89792

! .hgtags

Changeset: e50c5a1869b1
Author:    amurillo
Date:      2013-05-23 13:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/e50c5a1869b1

Merge


Changeset: f2614c006bb7
Author:    amurillo
Date:      2013-05-23 13:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/f2614c006bb7

Added tag hs24-b46 for changeset e50c5a1869b1

! .hgtags


From john.coomes at oracle.com  Thu May 23 20:32:17 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 24 May 2013 03:32:17 +0000
Subject: hg: hsx/hotspot-main: 7 new changesets
Message-ID: <20130524033217.A750248CD4@hg.openjdk.java.net>

Changeset: e2eb6bc06621
Author:    mduigou
Date:      2013-05-08 21:42 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/e2eb6bc06621

8014269: Add missing .PHONY targets to Main.gmk
Reviewed-by: mchung, tbell

! common/makefiles/Main.gmk

Changeset: 49ea9293fa49
Author:    lana
Date:      2013-05-09 14:23 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/49ea9293fa49

Merge


Changeset: 40bba0507f76
Author:    lana
Date:      2013-05-17 10:06 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/40bba0507f76

Merge


Changeset: eea249c1ecee
Author:    erikj
Date:      2013-05-21 13:18 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/eea249c1ecee

8014508: Fix log levels in make
Reviewed-by: tbell

! NewMakefile.gmk
! common/autoconf/spec.gmk.in

Changeset: e83abb0a04ab
Author:    katleman
Date:      2013-05-21 12:51 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/e83abb0a04ab

Merge


Changeset: cb51fb4789ac
Author:    andrew
Date:      2013-05-22 13:49 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/cb51fb4789ac

8015087: Provide debugging information for programs
Summary: Enable debugging info on programs in OpenJDK builds
Reviewed-by: erikj

! common/makefiles/NativeCompilation.gmk

Changeset: f089df41bff5
Author:    katleman
Date:      2013-05-23 10:47 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/f089df41bff5

Added tag jdk8-b91 for changeset cb51fb4789ac

! .hgtags


From john.coomes at oracle.com  Thu May 23 20:32:21 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 24 May 2013 03:32:21 +0000
Subject: hg: hsx/hotspot-main/corba: Added tag jdk8-b91 for changeset
	8f7ffb296385
Message-ID: <20130524033225.6B3BC48CD5@hg.openjdk.java.net>

Changeset: 717aa26f8e0a
Author:    katleman
Date:      2013-05-23 10:47 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/717aa26f8e0a

Added tag jdk8-b91 for changeset 8f7ffb296385

! .hgtags


From john.coomes at oracle.com  Thu May 23 20:32:34 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 24 May 2013 03:32:34 +0000
Subject: hg: hsx/hotspot-main/jaxp: 8 new changesets
Message-ID: <20130524033300.4137748CD6@hg.openjdk.java.net>

Changeset: 452e1a182907
Author:    dfuchs
Date:      2013-05-06 18:50 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/452e1a182907

8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently
Summary: Encodings.java sometimes creates EncodingInfo objects whose java names are not recognized by the Charset API. This patch fixes that issue.
Reviewed-by: joehw, alanb

! src/com/sun/org/apache/xml/internal/serializer/Encodings.java

Changeset: 1e8d98012ab8
Author:    joehw
Date:      2013-05-08 23:38 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/1e8d98012ab8

8011653: Upgrade JDK8 to JAXP 1.5
Reviewed-by: alanb, dfuchs

! src/com/sun/org/apache/xalan/internal/XalanConstants.java
! src/com/sun/org/apache/xalan/internal/utils/SecuritySupport.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Import.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Include.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Parser.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/XSLTC.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ca.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_cs.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_de.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_es.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_fr.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_it.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ja.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ko.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_pt_BR.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sk.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sv.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_CN.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_TW.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMsg.java
! src/com/sun/org/apache/xalan/internal/xsltc/dom/LoadDocument.java
! src/com/sun/org/apache/xalan/internal/xsltc/runtime/AbstractTranslet.java
! src/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesHandlerImpl.java
! src/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesImpl.java
! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java
! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java
! src/com/sun/org/apache/xalan/internal/xsltc/trax/Util.java
! src/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java
! src/com/sun/org/apache/xerces/internal/impl/Constants.java
! src/com/sun/org/apache/xerces/internal/impl/PropertyManager.java
! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java
! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentScannerImpl.java
! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java
! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_de.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_es.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_fr.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_it.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ja.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ko.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_pt_BR.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_sv.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_CN.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_TW.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_es.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_fr.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_it.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ja.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ko.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_pt_BR.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_sv.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_CN.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_TW.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_de.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_es.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_fr.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_it.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ja.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ko.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_pt_BR.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_sv.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_CN.properties
! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_TW.properties
! src/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaLoader.java
! src/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaValidator.java
! src/com/sun/org/apache/xerces/internal/impl/xs/XSDDescription.java
! src/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java
! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderFactoryImpl.java
! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java
! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserFactoryImpl.java
! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java
! src/com/sun/org/apache/xerces/internal/jaxp/validation/AbstractXMLSchema.java
! src/com/sun/org/apache/xerces/internal/jaxp/validation/StreamValidatorHelper.java
! src/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java
! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java
! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaValidatorComponentManager.java
! src/com/sun/org/apache/xerces/internal/jaxp/validation/XSGrammarPoolContainer.java
! src/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java
! src/com/sun/org/apache/xerces/internal/utils/SecuritySupport.java
! src/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java
! src/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java
! src/com/sun/xml/internal/stream/StaxXMLInputSource.java
! src/javax/xml/XMLConstants.java
! src/javax/xml/parsers/DocumentBuilderFactory.java
! src/javax/xml/parsers/SAXParser.java
! src/javax/xml/stream/XMLInputFactory.java
! src/javax/xml/transform/TransformerFactory.java
! src/javax/xml/validation/SchemaFactory.java
! src/javax/xml/validation/Validator.java

Changeset: 6976616f5753
Author:    lana
Date:      2013-05-08 22:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/6976616f5753

Merge


Changeset: 9e4dfe933ba9
Author:    lana
Date:      2013-05-09 14:23 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/9e4dfe933ba9

Merge


Changeset: a229726149b4
Author:    joehw
Date:      2013-05-10 09:23 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/a229726149b4

8014333: javadoc error in JAXP 1.5 patch
Reviewed-by: lancea

! src/javax/xml/stream/XMLInputFactory.java

Changeset: 6443f5627744
Author:    dfuchs
Date:      2013-05-17 10:40 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/6443f5627744

8013900: More warnings compiling jaxp.
Summary: Some internal implementation classes in Jaxp were redefining equals() without redefining hashCode(). This patch adds hashCode() methods that are consistent with equals().
Reviewed-by: chegar, joehw

! src/com/sun/org/apache/bcel/internal/generic/BasicType.java
! src/com/sun/org/apache/bcel/internal/generic/BranchInstruction.java
! src/com/sun/org/apache/bcel/internal/generic/CodeExceptionGen.java
! src/com/sun/org/apache/bcel/internal/generic/LineNumberGen.java
! src/com/sun/org/apache/bcel/internal/generic/LocalVariableGen.java
! src/com/sun/org/apache/bcel/internal/generic/ReturnaddressType.java
! src/com/sun/org/apache/bcel/internal/generic/Select.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionCall.java
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/VariableRefBase.java
! src/com/sun/org/apache/xerces/internal/impl/dv/xs/AbstractDateTimeDV.java
! src/com/sun/org/apache/xerces/internal/impl/dv/xs/DecimalDV.java
! src/com/sun/org/apache/xerces/internal/impl/dv/xs/PrecisionDecimalDV.java
! src/com/sun/org/apache/xerces/internal/util/URI.java
! src/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java
! src/com/sun/org/apache/xml/internal/dtm/ref/DTMNodeProxy.java
! src/com/sun/org/apache/xml/internal/serializer/utils/URI.java
! src/com/sun/org/apache/xml/internal/utils/URI.java
! src/com/sun/org/apache/xpath/internal/Arg.java

Changeset: e3065fb07877
Author:    lana
Date:      2013-05-17 10:07 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/e3065fb07877

Merge


Changeset: 827b59af45f3
Author:    katleman
Date:      2013-05-23 10:47 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/827b59af45f3

Added tag jdk8-b91 for changeset e3065fb07877

! .hgtags


From john.coomes at oracle.com  Thu May 23 20:33:04 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 24 May 2013 03:33:04 +0000
Subject: hg: hsx/hotspot-main/jaxws: Added tag jdk8-b91 for changeset
	0bb1a9fa56b0
Message-ID: <20130524033311.7E23F48CD7@hg.openjdk.java.net>

Changeset: a0f604766ca1
Author:    katleman
Date:      2013-05-23 10:47 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/a0f604766ca1

Added tag jdk8-b91 for changeset 0bb1a9fa56b0

! .hgtags


From alejandro.murillo at oracle.com  Thu May 23 20:51:49 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 24 May 2013 03:51:49 +0000
Subject: hg: hsx/hsx24/hotspot: 8015304: new hotspot build - hs24-b47
Message-ID: <20130524035154.354A448CD8@hg.openjdk.java.net>

Changeset: 5e3f9a6c1930
Author:    amurillo
Date:      2013-05-23 14:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/5e3f9a6c1930

8015304: new hotspot build - hs24-b47
Reviewed-by: jcoomes

! make/hotspot_version


From john.coomes at oracle.com  Thu May 23 20:35:58 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 24 May 2013 03:35:58 +0000
Subject: hg: hsx/hotspot-main/jdk: 106 new changesets
Message-ID: <20130524035742.9E15C48CE0@hg.openjdk.java.net>

Changeset: 4dd6f7bb8bbd
Author:    simonis
Date:      2013-05-06 12:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/4dd6f7bb8bbd

7191872: Xrender: No text displayed using 64 bit JDK on solaris11-sparc
Reviewed-by: prr, ceisserer

! src/share/classes/sun/font/FileFontStrike.java
! src/share/classes/sun/font/GlyphList.java
! src/solaris/classes/sun/font/XRGlyphCacheEntry.java
! src/solaris/native/sun/java2d/x11/XRBackendNative.c

Changeset: 23f7ff502a89
Author:    jgodinez
Date:      2013-05-07 09:32 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/23f7ff502a89

8011069: Printing: NullPointerException since jdk8 b82 showing native Page Setup Dialog.
Reviewed-by: bae, prr

! src/macosx/classes/sun/lwawt/macosx/CPrinterJob.java
! src/share/classes/sun/print/RasterPrinterJob.java

Changeset: 8a995d335d59
Author:    lana
Date:      2013-05-09 19:17 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/8a995d335d59

Merge

- src/share/classes/java/beans/ReflectionUtils.java
- test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java
- test/java/io/Serializable/accessConstants/AccessConstants.java
- test/java/nio/file/Files/walkFileTree/walk_file_tree.sh
- test/sun/reflect/CallerSensitive/MethodFinder.java

Changeset: 103f492d8ce7
Author:    vadim
Date:      2013-05-17 17:19 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/103f492d8ce7

4892259: GIF ImageReader does not call passComplete in IIOReadUpdateListener
Reviewed-by: prr, bae

! src/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java
+ test/javax/imageio/plugins/gif/GIFPassListenerTest.java

Changeset: 4ee85e865a83
Author:    vadim
Date:      2013-05-17 14:18 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/4ee85e865a83

8000936: Enable Java2D D3D pipeline on newer Intel chipsets : Intel HD and later
Reviewed-by: prr, bae

! src/windows/native/sun/java2d/d3d/D3DBadHardware.h

Changeset: 51f5e544c88b
Author:    lana
Date:      2013-05-17 10:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/51f5e544c88b

Merge


Changeset: 90b67c9a7eb2
Author:    serb
Date:      2013-05-06 16:23 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/90b67c9a7eb2

7161575: [macosx] On MacOSX port java.awt.Toolkit.is/setDynamicLayout() are not consistent
Reviewed-by: anthony, art

! src/macosx/classes/sun/lwawt/LWToolkit.java

Changeset: 7982299cd11c
Author:    serb
Date:      2013-05-08 15:58 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7982299cd11c

8013841: [macosx] Animations not disabled for CALayers used via JAWT
Reviewed-by: anthony, alexsch

! src/macosx/native/sun/awt/AWTSurfaceLayers.m
! src/macosx/native/sun/java2d/opengl/CGLLayer.m

Changeset: 5fe0a4da863d
Author:    lana
Date:      2013-05-09 18:42 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5fe0a4da863d

Merge

- test/java/io/Serializable/accessConstants/AccessConstants.java
- test/java/nio/file/Files/walkFileTree/walk_file_tree.sh
- test/sun/reflect/CallerSensitive/MethodFinder.java

Changeset: a466a4192fea
Author:    pchelko
Date:      2013-05-14 16:39 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/a466a4192fea

8002045: Auto failed and threw exception:java.lang.UnsatisfiedLinkError:
Reviewed-by: serb, anthony

! make/sun/awt/mapfile-vers
! make/sun/awt/mapfile-vers-bsd
! make/sun/awt/mapfile-vers-linux
! makefiles/mapfiles/libawt/mapfile-vers
! makefiles/mapfiles/libawt/mapfile-vers-linux

Changeset: b1a7cc79f13d
Author:    serb
Date:      2013-05-14 17:25 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b1a7cc79f13d

8014423: [macosx] The scrollbar's block increment performs incorrectly
Reviewed-by: anthony, art

! src/macosx/classes/sun/lwawt/LWScrollBarPeer.java

Changeset: 722ee3129ce0
Author:    ant
Date:      2013-05-15 16:49 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/722ee3129ce0

8014227: JLightweightFrame needs another synchronization policy
Reviewed-by: art

! src/share/classes/sun/swing/JLightweightFrame.java

Changeset: 7a8a8e31a126
Author:    pchelko
Date:      2013-05-17 11:02 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7a8a8e31a126

7079254: Toolkit eventListener leaks memory
Reviewed-by: serb, art

! src/share/classes/java/awt/Component.java
! src/share/classes/java/awt/Container.java
+ test/java/awt/LightweightDispatcher/LWDispatcherMemoryLeakTest.java

Changeset: e944b78812a8
Author:    kshefov
Date:      2013-05-17 14:08 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e944b78812a8

8014721: TEST_BUG: java/awt/TrayIcon/DragEventSource/DragEventSource.java fails with java.lang.UnsupportedOperationException
Reviewed-by: anthony, serb

! test/java/awt/TrayIcon/DragEventSource/DragEventSource.java

Changeset: 281add053efe
Author:    kshefov
Date:      2013-05-17 14:11 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/281add053efe

8013426: TEST_BUG: java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java fails with "RuntimeException: The data should be available" on Linux
Reviewed-by: anthony, serb

! test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java

Changeset: 49871f1581b8
Author:    lana
Date:      2013-05-17 10:06 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/49871f1581b8

Merge


Changeset: 167d2dcaeeee
Author:    ksrini
Date:      2013-05-01 15:08 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/167d2dcaeeee

8013225: Refresh jdk's private ASM to the latest.
Reviewed-by: mduigou, sundar

! src/share/classes/jdk/internal/org/objectweb/asm/AnnotationVisitor.java
! src/share/classes/jdk/internal/org/objectweb/asm/AnnotationWriter.java
! src/share/classes/jdk/internal/org/objectweb/asm/Attribute.java
! src/share/classes/jdk/internal/org/objectweb/asm/ByteVector.java
! src/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java
! src/share/classes/jdk/internal/org/objectweb/asm/ClassVisitor.java
! src/share/classes/jdk/internal/org/objectweb/asm/ClassWriter.java
+ src/share/classes/jdk/internal/org/objectweb/asm/Context.java
! src/share/classes/jdk/internal/org/objectweb/asm/FieldVisitor.java
! src/share/classes/jdk/internal/org/objectweb/asm/FieldWriter.java
! src/share/classes/jdk/internal/org/objectweb/asm/Frame.java
! src/share/classes/jdk/internal/org/objectweb/asm/Handle.java
! src/share/classes/jdk/internal/org/objectweb/asm/Handler.java
! src/share/classes/jdk/internal/org/objectweb/asm/Item.java
! src/share/classes/jdk/internal/org/objectweb/asm/Label.java
! src/share/classes/jdk/internal/org/objectweb/asm/MethodVisitor.java
! src/share/classes/jdk/internal/org/objectweb/asm/MethodWriter.java
! src/share/classes/jdk/internal/org/objectweb/asm/Opcodes.java
! src/share/classes/jdk/internal/org/objectweb/asm/Type.java
+ src/share/classes/jdk/internal/org/objectweb/asm/TypePath.java
+ src/share/classes/jdk/internal/org/objectweb/asm/TypeReference.java
! src/share/classes/jdk/internal/org/objectweb/asm/commons/AdviceAdapter.java
! src/share/classes/jdk/internal/org/objectweb/asm/commons/AnalyzerAdapter.java
! src/share/classes/jdk/internal/org/objectweb/asm/commons/CodeSizeEvaluator.java
! src/share/classes/jdk/internal/org/objectweb/asm/commons/GeneratorAdapter.java
! src/share/classes/jdk/internal/org/objectweb/asm/commons/InstructionAdapter.java
! src/share/classes/jdk/internal/org/objectweb/asm/commons/JSRInlinerAdapter.java
! src/share/classes/jdk/internal/org/objectweb/asm/commons/LocalVariablesSorter.java
! src/share/classes/jdk/internal/org/objectweb/asm/commons/Method.java
! src/share/classes/jdk/internal/org/objectweb/asm/commons/Remapper.java
! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingAnnotationAdapter.java
! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingClassAdapter.java
! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingFieldAdapter.java
! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingMethodAdapter.java
! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingSignatureAdapter.java
! src/share/classes/jdk/internal/org/objectweb/asm/commons/SerialVersionUIDAdder.java
! src/share/classes/jdk/internal/org/objectweb/asm/commons/StaticInitMerger.java
! src/share/classes/jdk/internal/org/objectweb/asm/commons/TableSwitchGenerator.java
! src/share/classes/jdk/internal/org/objectweb/asm/commons/TryCatchBlockSorter.java
! src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureReader.java
! src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureVisitor.java
! src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureWriter.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/AbstractInsnNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/AnnotationNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/ClassNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/FieldInsnNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/FieldNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/FrameNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/IincInsnNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/InnerClassNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/InsnList.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/InsnNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/IntInsnNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/InvokeDynamicInsnNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/JumpInsnNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/LdcInsnNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/LineNumberNode.java
+ src/share/classes/jdk/internal/org/objectweb/asm/tree/LocalVariableAnnotationNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/LocalVariableNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/LookupSwitchInsnNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodInsnNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/MultiANewArrayInsnNode.java
+ src/share/classes/jdk/internal/org/objectweb/asm/tree/ParameterNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/TableSwitchInsnNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/TryCatchBlockNode.java
+ src/share/classes/jdk/internal/org/objectweb/asm/tree/TypeAnnotationNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/TypeInsnNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/VarInsnNode.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Analyzer.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/AnalyzerException.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicInterpreter.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicValue.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicVerifier.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Frame.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Interpreter.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SimpleVerifier.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SourceInterpreter.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SourceValue.java
! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Subroutine.java
! src/share/classes/jdk/internal/org/objectweb/asm/util/ASMifiable.java
! src/share/classes/jdk/internal/org/objectweb/asm/util/ASMifier.java
! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckAnnotationAdapter.java
! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckClassAdapter.java
! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckFieldAdapter.java
! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckMethodAdapter.java
! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckSignatureAdapter.java
! src/share/classes/jdk/internal/org/objectweb/asm/util/Printer.java
! src/share/classes/jdk/internal/org/objectweb/asm/util/Textifiable.java
! src/share/classes/jdk/internal/org/objectweb/asm/util/Textifier.java
! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceAnnotationVisitor.java
! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceClassVisitor.java
! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceFieldVisitor.java
! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceMethodVisitor.java
! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceSignatureVisitor.java
+ src/share/classes/jdk/internal/org/objectweb/asm/version.txt

Changeset: 5045eb04a579
Author:    mduigou
Date:      2013-05-02 09:18 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5045eb04a579

8012645: Stream methods on BitSet, Random, ThreadLocalRandom, ZipFile
Reviewed-by: mduigou, henryjen, alanb, martin, psandoz
Contributed-by: akhil.arora at oracle.com, brian.goetz at oracle.com

! src/share/classes/java/util/BitSet.java
! src/share/classes/java/util/Random.java
! src/share/classes/java/util/concurrent/ThreadLocalRandom.java
! src/share/classes/java/util/jar/JarFile.java
! src/share/classes/java/util/zip/ZipFile.java
+ test/java/util/BitSet/BitSetStreamTest.java
+ test/java/util/Random/RandomStreamTest.java
+ test/java/util/zip/ZipFile/StreamZipEntriesTest.java

Changeset: a6ff4a823164
Author:    kizune
Date:      2013-05-02 21:23 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/a6ff4a823164

8013155: [pack200] improve performance of pack200
Reviewed-by: ksrini, jrose

! src/share/classes/com/sun/java/util/jar/pack/Code.java
! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java

Changeset: 3062bf908281
Author:    khazra
Date:      2013-05-02 14:26 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3062bf908281

8013140: Heap corruption with NetworkInterface.getByInetAddress() and long i/f name
Summary: Remove buffer overruns in native code
Reviewed-by: alanb, chegar

! src/solaris/native/java/net/NetworkInterface.c

Changeset: 81be41c7323f
Author:    weijun
Date:      2013-05-03 10:43 +0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/81be41c7323f

8013855: DigestMD5Client has not checked RealmChoiceCallback value
Reviewed-by: xuelei, mullan

! src/share/classes/com/sun/security/sasl/digest/DigestMD5Client.java
+ test/com/sun/security/sasl/digest/AuthRealmChoices.java

Changeset: 470f19b6bfdd
Author:    jbachorik
Date:      2013-05-02 13:21 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/470f19b6bfdd

7199324: Connection ID for IPv6 addresses is not generated accordingly to the specification
Summary: RemoteServer.getClientHost is returning a String with an IPv6 literal address and we need to enclose it in [] when building the connection id
Reviewed-by: alanb, sjiang

! src/share/classes/javax/management/remote/rmi/RMIServerImpl.java
! test/javax/management/remote/mandatory/connection/ConnectionTest.java

Changeset: fc156b925259
Author:    mduigou
Date:      2013-05-03 10:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/fc156b925259

8013528: Provide SharedSecrets access to String(char[], boolean) constructor
Reviewed-by: martin, alanb, chegar, plevart

! src/share/classes/java/lang/System.java
! src/share/classes/sun/misc/JavaLangAccess.java
+ test/sun/misc/JavaLangAccess/NewUnsafeString.java

Changeset: d7f3d5659c46
Author:    juh
Date:      2013-05-03 15:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/d7f3d5659c46

8005922: TEST_BUG: There is no /tmp directory for windows system.
Reviewed-by: weijun

! test/sun/security/tools/policytool/ChangeUI.html
! test/sun/security/tools/policytool/UpdatePermissions.html
! test/sun/security/tools/policytool/i18n.html

Changeset: d8f01bfb1da4
Author:    dwanvik
Date:      2013-05-06 05:51 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/d8f01bfb1da4

8013403: Update JDK8 with Java DB 10.10.1.1.
Summary: Drop Java DB 10.10.1.1 bits into JDK 8 and update image builds
Reviewed-by: tbell

! make/common/Release.gmk
! makefiles/CompileDemos.gmk
! makefiles/Images.gmk

Changeset: 398fe07f530f
Author:    dwanvik
Date:      2013-05-06 06:05 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/398fe07f530f

Merge

- test/sun/reflect/CallerSensitive/MethodFinder.java

Changeset: bd118033e44c
Author:    dxu
Date:      2013-05-06 14:17 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/bd118033e44c

8003992: File and other classes in java.io do not handle embedded nulls properly
Summary: Have every file operation done with File, FileInputStream, FileOutputStream, or RandomAccessFile that involves a file path containing NUL fail. Also reviewed by fweimer at redhat.com
Reviewed-by: alanb, sherman, ahgross, mduigou, dholmes, aph, plevart, martin

! src/share/classes/java/io/File.java
! src/share/classes/java/io/FileInputStream.java
! src/share/classes/java/io/FileOutputStream.java
! src/share/classes/java/io/RandomAccessFile.java
+ test/java/io/File/NulFile.java

Changeset: e13cf31e5a96
Author:    mduigou
Date:      2013-05-06 20:54 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e13cf31e5a96

8013712: Add Objects.nonNull and Objects.isNull
Reviewed-by: mchung, darcy

! src/share/classes/java/util/Objects.java
! test/java/util/Objects/BasicObjectsTest.java

Changeset: 3cbb65d9af9e
Author:    mduigou
Date:      2013-05-06 20:54 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3cbb65d9af9e

8013150: Iterator.remove and forEachRemaining relationship not specified
Reviewed-by: mduigou
Contributed-by: Akhil Arora <akhil.arora at oracle.com>

! src/share/classes/java/util/ArrayList.java
! src/share/classes/java/util/LinkedList.java
! src/share/classes/java/util/Vector.java
+ test/java/util/Iterator/IteratorDefaults.java

Changeset: 8221c421490f
Author:    mduigou
Date:      2013-05-06 20:54 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/8221c421490f

8003258: BufferedReader.lines()
Reviewed-by: alanb, mduigou, psandoz
Contributed-by: Brian Goetz <brian.goetz at oracle.com>, Henry Jen <henry.jen at oracle.com>

! src/share/classes/java/io/BufferedReader.java
+ src/share/classes/java/io/UncheckedIOException.java
+ test/java/io/BufferedReader/Lines.java

Changeset: b4a013f4eff4
Author:    sherman
Date:      2013-05-06 21:24 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b4a013f4eff4

8013252: Regex Matcher .start and .end should be accessible by group name
8013254: Constructor \w need update to add the support of \p{Join_Control}
Summary: added the requested methods and updated the \w constructor
Reviewed-by: mchung, alanb

! src/share/classes/java/util/regex/Matcher.java
! src/share/classes/java/util/regex/Pattern.java
! src/share/classes/java/util/regex/UnicodeProp.java
! test/java/util/regex/POSIX_Unicode.java
! test/java/util/regex/RegExTest.java

Changeset: 814dcc08df52
Author:    weijun
Date:      2013-05-07 12:30 +0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/814dcc08df52

8010192: Enable native JGSS provider on Mac
Reviewed-by: valeriep

! make/sun/security/Makefile
! makefiles/CompileNativeLibraries.gmk
! src/share/classes/sun/security/jgss/GSSManagerImpl.java
! src/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java
! src/share/native/sun/security/jgss/wrapper/gssapi.h
! test/sun/security/krb5/runNameEquals.sh

Changeset: 9c9b2385c1b0
Author:    jfranck
Date:      2013-05-07 09:52 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/9c9b2385c1b0

8013541: Revise javadoc for Executable.getAnnotatedReturnType()
Reviewed-by: abuckley, darcy

! src/share/classes/java/lang/reflect/Executable.java

Changeset: 2602eab5f086
Author:    dfuchs
Date:      2013-05-07 11:35 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/2602eab5f086

8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently
Summary: Encodings.java sometimes creates EncodingInfo objects whose java names are not recognized by the Charset API. This patch fixes that issue.
Reviewed-by: joehw, alanb

+ test/javax/xml/jaxp/Encodings/CheckEncodingPropertiesFile.java

Changeset: 7b40394ad944
Author:    sla
Date:      2013-05-07 19:57 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7b40394ad944

6980985: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage is not robust when getMax() returns -1
7181907: TEST_BUG: j/l/management/MemoryMXBean/ResetPeakMemoryUsage fails with NegativeArraySizeException
7148492: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java failing since update to hs23-b15 or b16
Reviewed-by: mchung, brutisso

! test/ProblemList.txt
! test/java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java

Changeset: 100027950b05
Author:    sla
Date:      2013-05-07 20:00 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/100027950b05

8004007: test/sun/tools/jinfo/Basic.sh fails on when runSA is set to true
Reviewed-by: alanb, dsamersoff

! test/sun/tools/jinfo/Basic.sh

Changeset: e30396e22c6f
Author:    naoto
Date:      2013-05-07 11:31 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e30396e22c6f

8013086: NPE thrown by SimpleDateFormat with TimeZoneNameProvider supplied
Reviewed-by: okutsu

! src/share/classes/sun/util/locale/provider/TimeZoneNameUtility.java
! test/java/util/Locale/LocaleProviders.java
! test/java/util/Locale/LocaleProviders.sh

Changeset: fe4e9bc2186f
Author:    mduigou
Date:      2013-05-07 12:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/fe4e9bc2186f

4802647: Throw required NPEs from removeAll()/retainAll()
Reviewed-by: mduigou, chegar, dholmes
Contributed-by: Brandon Passanisi <brandon.passanisi at oracle.com>

! src/share/classes/java/util/AbstractCollection.java
! src/share/classes/java/util/AbstractSet.java
! src/share/classes/java/util/ArrayList.java
! test/java/util/Collection/MOAT.java

Changeset: 6feee75b0a8b
Author:    briangoetz
Date:      2013-05-06 11:43 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/6feee75b0a8b

8012664: Add tests for java.util.stream and lambda translation
Reviewed-by: mduigou, briangoetz
Contributed-by: Brian Goetz <brian.goetz at oracle.com>, Paul Sandoz <paul.sandoz at oracle.com>, Mike Duigou <mike.duigou at oracle.com>, Robert Field <robert.field at oracle.com>, Jim Gish <jim.gish at oracle.com>

! test/Makefile
+ test/java/util/concurrent/atomic/AtomicReferenceTest.java
+ test/java/util/stream/bootlib/TEST.properties
+ test/java/util/stream/bootlib/java/util/stream/CollectorOps.java
+ test/java/util/stream/bootlib/java/util/stream/DoubleStreamTestDataProvider.java
+ test/java/util/stream/bootlib/java/util/stream/DoubleStreamTestScenario.java
+ test/java/util/stream/bootlib/java/util/stream/FlagDeclaringOp.java
+ test/java/util/stream/bootlib/java/util/stream/IntStreamTestDataProvider.java
+ test/java/util/stream/bootlib/java/util/stream/IntStreamTestScenario.java
+ test/java/util/stream/bootlib/java/util/stream/IntermediateTestOp.java
+ test/java/util/stream/bootlib/java/util/stream/LambdaTestHelpers.java
+ test/java/util/stream/bootlib/java/util/stream/LongStreamTestDataProvider.java
+ test/java/util/stream/bootlib/java/util/stream/LongStreamTestScenario.java
+ test/java/util/stream/bootlib/java/util/stream/OpTestCase.java
+ test/java/util/stream/bootlib/java/util/stream/SpliteratorTestHelper.java
+ test/java/util/stream/bootlib/java/util/stream/StatefulTestOp.java
+ test/java/util/stream/bootlib/java/util/stream/StatelessTestOp.java
+ test/java/util/stream/bootlib/java/util/stream/StreamOpFlagTestHelper.java
+ test/java/util/stream/bootlib/java/util/stream/StreamTestDataProvider.java
+ test/java/util/stream/bootlib/java/util/stream/StreamTestScenario.java
+ test/java/util/stream/bootlib/java/util/stream/TestData.java
+ test/java/util/stream/bootlib/java/util/stream/TestFlagExpectedOp.java
+ test/java/util/stream/boottest/TEST.properties
+ test/java/util/stream/boottest/java/util/stream/DoubleNodeTest.java
+ test/java/util/stream/boottest/java/util/stream/FlagOpTest.java
+ test/java/util/stream/boottest/java/util/stream/IntNodeTest.java
+ test/java/util/stream/boottest/java/util/stream/LongNodeTest.java
+ test/java/util/stream/boottest/java/util/stream/NodeBuilderTest.java
+ test/java/util/stream/boottest/java/util/stream/NodeTest.java
+ test/java/util/stream/boottest/java/util/stream/SpinedBufferTest.java
+ test/java/util/stream/boottest/java/util/stream/StreamFlagsTest.java
+ test/java/util/stream/boottest/java/util/stream/StreamOpFlagsTest.java
+ test/java/util/stream/boottest/java/util/stream/StreamReuseTest.java
+ test/java/util/stream/boottest/java/util/stream/UnorderedTest.java
+ test/java/util/stream/test/TEST.properties
+ test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/DeserializeMethodTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/MHProxiesTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/SerializedLambdaTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/FillableStringTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/MapTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/NullArgsTestCase.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/CollectionAndMapModifyStreamTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/DistinctOpTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/DoublePrimitiveOpsTests.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/ExplodeOpTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/FilterOpTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/FindAnyOpTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/FindFirstOpTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/ForEachOpTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/GroupByOpTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/InfiniteStreamWithLimitOpTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntPrimitiveOpsTests.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntReduceTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntSliceOpTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntUniqOpTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/LongPrimitiveOpsTests.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/MapOpTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/MatchOpTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/MinMaxTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/PrimitiveAverageOpTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/PrimitiveSumTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/ReduceByOpTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/ReduceTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/SequentialOpTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorLateBindingFailFastTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorTraversingAndSplittingTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamBuilderTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamLinkTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamParSeqTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamSpliteratorTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/SummaryStatisticsTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/TeeOpTest.java
+ test/java/util/stream/test/org/openjdk/tests/java/util/stream/ToArrayOpTest.java
+ test/jdk/lambda/ArrayCtorRefTest.java
+ test/jdk/lambda/FDTest.java
+ test/jdk/lambda/LambdaTranslationCompoundSamTest.java
+ test/jdk/lambda/LambdaTranslationInInterface.java
+ test/jdk/lambda/LambdaTranslationInnerConstructor.java
+ test/jdk/lambda/LambdaTranslationTest1.java
+ test/jdk/lambda/LambdaTranslationTest2.java
+ test/jdk/lambda/MethodReferenceTestFDCCE.java
+ test/jdk/lambda/MethodReferenceTestInnerDefault.java
+ test/jdk/lambda/MethodReferenceTestInnerInstance.java
+ test/jdk/lambda/MethodReferenceTestInnerVarArgsThis.java
+ test/jdk/lambda/MethodReferenceTestInstance.java
+ test/jdk/lambda/MethodReferenceTestInstanceMethod.java
+ test/jdk/lambda/MethodReferenceTestKinds.java
+ test/jdk/lambda/MethodReferenceTestNew.java
+ test/jdk/lambda/MethodReferenceTestNewInner.java
+ test/jdk/lambda/MethodReferenceTestSueCase1.java
+ test/jdk/lambda/MethodReferenceTestSueCase2.java
+ test/jdk/lambda/MethodReferenceTestSueCase4.java
+ test/jdk/lambda/MethodReferenceTestSuper.java
+ test/jdk/lambda/MethodReferenceTestSuperDefault.java
+ test/jdk/lambda/MethodReferenceTestTypeConversion.java
+ test/jdk/lambda/MethodReferenceTestVarArgs.java
+ test/jdk/lambda/MethodReferenceTestVarArgsExt.java
+ test/jdk/lambda/MethodReferenceTestVarArgsSuper.java
+ test/jdk/lambda/MethodReferenceTestVarArgsSuperDefault.java
+ test/jdk/lambda/MethodReferenceTestVarArgsThis.java
+ test/jdk/lambda/TEST.properties
+ test/jdk/lambda/TestInnerCtorRef.java
+ test/jdk/lambda/TestPrivateCtorRef.java
+ test/jdk/lambda/separate/AttributeInjector.java
+ test/jdk/lambda/separate/ClassFile.java
+ test/jdk/lambda/separate/ClassFilePreprocessor.java
+ test/jdk/lambda/separate/ClassToInterfaceConverter.java
+ test/jdk/lambda/separate/Compiler.java
+ test/jdk/lambda/separate/DirectedClassLoader.java
+ test/jdk/lambda/separate/SourceModel.java
+ test/jdk/lambda/separate/TestHarness.java
+ test/jdk/lambda/shapegen/ClassCase.java
+ test/jdk/lambda/shapegen/Hierarchy.java
+ test/jdk/lambda/shapegen/HierarchyGenerator.java
+ test/jdk/lambda/shapegen/Rule.java
+ test/jdk/lambda/shapegen/RuleGroup.java
+ test/jdk/lambda/shapegen/TTNode.java
+ test/jdk/lambda/shapegen/TTParser.java
+ test/jdk/lambda/shapegen/TTShape.java
+ test/jdk/lambda/vm/DefaultMethodRegressionTests.java
+ test/jdk/lambda/vm/DefaultMethodsTest.java
+ test/jdk/lambda/vm/InterfaceAccessFlagsTest.java
+ test/jdk/lambda/vm/StrictfpDefault.java

Changeset: 7d89b0dd973c
Author:    weijun
Date:      2013-05-08 08:25 +0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/7d89b0dd973c

8012679: Let allow_weak_crypto default to false
Reviewed-by: valeriep

! src/share/classes/sun/security/krb5/internal/crypto/EType.java
! test/sun/security/krb5/auto/DupEtypes.java
! test/sun/security/krb5/etype/WeakCrypto.java

Changeset: c8f47674d105
Author:    alanb
Date:      2013-05-08 18:00 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c8f47674d105

8013652: (profiles) Add javax.script to compact1
Reviewed-by: mchung, dholmes

! makefiles/profile-rtjar-includes.txt

Changeset: 3fd83f282c61
Author:    ksrini
Date:      2013-05-07 13:15 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3fd83f282c61

8013736: [launcher] cleanup code for correctness
8005735: [parfait] False positive integer overflow in jdk/src/solaris/bin/jexec.c
8009873: [parfait] Memory leak at jdk/src/share/bin/wildcard.c
8005807: [parfait] Undefined return value at jdk/src/share/bin/java.c
Reviewed-by: alanb, martin

! src/share/bin/java.c
! src/share/bin/java.h
! src/share/bin/wildcard.c
! src/solaris/bin/jexec.c

Changeset: bb9cdfac1a7d
Author:    juh
Date:      2013-05-09 12:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/bb9cdfac1a7d

8007699: Move some tests from test/sun/security/provider/certpath/X509CertPath to closed repo
Reviewed-by: mullan

- test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java
- test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java
- test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java

Changeset: 498ea4c3a4c6
Author:    psandoz
Date:      2013-05-01 18:40 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/498ea4c3a4c6

8012646: Pattern.splitAsStream
Reviewed-by: forax, plevart, alanb
Contributed-by: Ben Evans <benjamin.john.evans at gmail.com>, Paul Sandoz <paul.sandoz at oracle.com>

! src/share/classes/java/util/regex/Pattern.java
! test/java/util/regex/RegExTest.java

Changeset: 573a593379cb
Author:    lana
Date:      2013-05-08 23:53 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/573a593379cb

Merge

! makefiles/CompileNativeLibraries.gmk
! makefiles/Images.gmk
- src/share/classes/java/beans/ReflectionUtils.java
- test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java

Changeset: 2023e3d573eb
Author:    lana
Date:      2013-05-09 14:23 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/2023e3d573eb

Merge

- test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java
- test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java
- test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java

Changeset: ba74cd79e4f6
Author:    jfranck
Date:      2013-05-10 10:20 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ba74cd79e4f6

8007073: Implement Core Reflection for Type Annotations on parameters
Reviewed-by: darcy, abuckley

! src/share/classes/java/lang/reflect/Executable.java
! src/share/classes/java/lang/reflect/Field.java
! src/share/classes/java/lang/reflect/Parameter.java
! src/share/classes/sun/reflect/annotation/TypeAnnotation.java
! src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java
! test/java/lang/annotation/TypeAnnotationReflection.java

Changeset: 09a3b08c986f
Author:    alanb
Date:      2013-05-10 14:53 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/09a3b08c986f

8011128: (fs) Files.createDirectory fails if the resolved path is exactly 248 characters long
Reviewed-by: khazra, chegar

! src/windows/classes/sun/nio/fs/WindowsFileCopy.java
! src/windows/classes/sun/nio/fs/WindowsLinkSupport.java
! src/windows/classes/sun/nio/fs/WindowsPath.java
+ test/java/nio/file/Files/NameLimits.java

Changeset: ece61e21782d
Author:    darcy
Date:      2013-05-10 08:53 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ece61e21782d

8014249: Add Modifer.parameterModifiers()
Reviewed-by: mduigou, mchung

! src/share/classes/java/lang/reflect/Modifier.java

Changeset: c26e0d29249a
Author:    rriggs
Date:      2013-05-10 09:06 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c26e0d29249a

8014296: DivModTests should not compare pointers
Reviewed-by: darcy

! test/java/lang/Math/DivModTests.java

Changeset: 2490769abdfa
Author:    mduigou
Date:      2013-05-10 09:51 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/2490769abdfa

8014316: Use Method Refs in j.u.stream.MatchOps
Reviewed-by: dholmes

! src/share/classes/java/util/stream/MatchOps.java

Changeset: 9891e4d7d5b3
Author:    mduigou
Date:      2013-05-10 10:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/9891e4d7d5b3

Merge

- src/share/classes/java/beans/ReflectionUtils.java
- test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java
- test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java
- test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java
- test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java

Changeset: f84b5498b2bb
Author:    darcy
Date:      2013-05-10 12:25 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/f84b5498b2bb

8014357: Minor refactorings to sun.reflect.generics.reflectiveObjects.*
Reviewed-by: mchung

! src/share/classes/sun/reflect/generics/reflectiveObjects/GenericArrayTypeImpl.java
! src/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java
! src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java
! src/share/classes/sun/reflect/generics/reflectiveObjects/WildcardTypeImpl.java

Changeset: 90f715cceaae
Author:    dmeetry
Date:      2013-05-10 23:56 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/90f715cceaae

7021870: GzipInputStream closes underlying stream during reading
Reviewed-by: mduigou
Contributed-by: ivan.gerasimov at oracle.com

! src/share/classes/java/util/zip/GZIPInputStream.java
+ test/java/util/zip/GZIP/GZIPInZip.java

Changeset: 76998d11a643
Author:    xuelei
Date:      2013-05-13 05:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/76998d11a643

8005535: SSLSessionImpl should have protected finalize()
Reviewed-by: weijun, wetmore

! src/share/classes/sun/security/ssl/SSLSessionImpl.java

Changeset: 46db0e633240
Author:    xuelei
Date:      2013-05-13 06:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/46db0e633240

8005598: (reopened) Need to clone array of input/output parameters
Reviewed-by: weijun

! src/share/classes/com/sun/jndi/dns/DnsContext.java
! src/share/classes/com/sun/jndi/ldap/BasicControl.java

Changeset: 536678dffa97
Author:    sundar
Date:      2013-05-13 22:23 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/536678dffa97

8012975: Remove rhino from jdk8
Reviewed-by: alanb, tbell

! make/com/sun/Makefile
- make/com/sun/script/Makefile
! make/sun/Makefile
- make/sun/org/Makefile
- make/sun/org/mozilla/Makefile
- make/sun/org/mozilla/javascript/Makefile
! make/tools/src/build/tools/deps/refs.allowed
! makefiles/CopyFiles.gmk
! makefiles/CopyIntoClasses.gmk
! makefiles/profile-rtjar-includes.txt
- src/share/classes/com/sun/script/javascript/ExternalScriptable.java
- src/share/classes/com/sun/script/javascript/JSAdapter.java
- src/share/classes/com/sun/script/javascript/JavaAdapter.java
- src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory
- src/share/classes/com/sun/script/javascript/RhinoClassShutter.java
- src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java
- src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java
- src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java
- src/share/classes/com/sun/script/javascript/RhinoTopLevel.java
- src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java
- src/share/classes/com/sun/script/util/BindingsBase.java
- src/share/classes/com/sun/script/util/BindingsEntrySet.java
- src/share/classes/com/sun/script/util/BindingsImpl.java
- src/share/classes/com/sun/script/util/InterfaceImplementor.java
- src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java

Changeset: 6175fe5b07aa
Author:    bharadwaj
Date:      2013-05-13 12:26 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/6175fe5b07aa

8008687: MethodHandle code: allow static and invokespecial calls to interface methods
Summary: Changes to support invocation of lambda methods compiled either as static interface methods and or private instance methods.
Reviewed-by: jrose, twisti

! src/share/classes/java/lang/invoke/MemberName.java

Changeset: f7fcfb204a69
Author:    mduigou
Date:      2013-05-13 13:15 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/f7fcfb204a69

Merge

- make/com/sun/script/Makefile
- make/sun/org/Makefile
- make/sun/org/mozilla/Makefile
- make/sun/org/mozilla/javascript/Makefile
- src/share/classes/com/sun/script/javascript/ExternalScriptable.java
- src/share/classes/com/sun/script/javascript/JSAdapter.java
- src/share/classes/com/sun/script/javascript/JavaAdapter.java
- src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory
- src/share/classes/com/sun/script/javascript/RhinoClassShutter.java
- src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java
- src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java
- src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java
- src/share/classes/com/sun/script/javascript/RhinoTopLevel.java
- src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java
- src/share/classes/com/sun/script/util/BindingsBase.java
- src/share/classes/com/sun/script/util/BindingsEntrySet.java
- src/share/classes/com/sun/script/util/BindingsImpl.java
- src/share/classes/com/sun/script/util/InterfaceImplementor.java
- src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java

Changeset: 86c1e8c799f5
Author:    khazra
Date:      2013-05-13 13:48 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/86c1e8c799f5

8014254: Selector in HttpServer introduces a 1000 ms delay when using KeepAlive
Summary: Rearrange event-handling code to remove bottle-neck. Also reviewed by mhall at mhcomputing.net.
Reviewed-by: chegar, alanb

! src/share/classes/sun/net/httpserver/ServerImpl.java

Changeset: ae35fdbab949
Author:    sherman
Date:      2013-05-13 20:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ae35fdbab949

8013386: (tz) Support tzdata2013c
Summary: updated tz data to version 2013c
Reviewed-by: peytoia, okutsu

! make/sun/javazic/tzdata/VERSION
! make/sun/javazic/tzdata/africa
! make/sun/javazic/tzdata/antarctica
! make/sun/javazic/tzdata/asia
! make/sun/javazic/tzdata/australasia
! make/sun/javazic/tzdata/europe
! make/sun/javazic/tzdata/northamerica
! make/sun/javazic/tzdata/southamerica
! make/sun/javazic/tzdata/zone.tab
! src/share/classes/sun/util/calendar/ZoneInfoFile.java
! src/share/classes/sun/util/resources/TimeZoneNames.java
! src/share/classes/sun/util/resources/de/TimeZoneNames_de.java
! src/share/classes/sun/util/resources/es/TimeZoneNames_es.java
! src/share/classes/sun/util/resources/fr/TimeZoneNames_fr.java
! src/share/classes/sun/util/resources/it/TimeZoneNames_it.java
! src/share/classes/sun/util/resources/ja/TimeZoneNames_ja.java
! src/share/classes/sun/util/resources/ko/TimeZoneNames_ko.java
! src/share/classes/sun/util/resources/pt/TimeZoneNames_pt_BR.java
! src/share/classes/sun/util/resources/sv/TimeZoneNames_sv.java
! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_CN.java
! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_TW.java
! test/sun/util/calendar/zi/Rule.java
! test/sun/util/calendar/zi/tzdata/VERSION
! test/sun/util/calendar/zi/tzdata/africa
! test/sun/util/calendar/zi/tzdata/antarctica
! test/sun/util/calendar/zi/tzdata/asia
! test/sun/util/calendar/zi/tzdata/australasia
! test/sun/util/calendar/zi/tzdata/europe
! test/sun/util/calendar/zi/tzdata/northamerica
! test/sun/util/calendar/zi/tzdata/southamerica
! test/sun/util/calendar/zi/tzdata/zone.tab

Changeset: a50bad038f31
Author:    darcy
Date:      2013-05-13 22:16 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/a50bad038f31

8014365: Restore Objects.requireNonNull(T, Supplier<String>)
Reviewed-by: mduigou

! src/share/classes/java/util/Objects.java
! test/java/util/Objects/BasicObjectsTest.java

Changeset: b315cb9a7544
Author:    alanb
Date:      2013-05-14 14:32 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b315cb9a7544

8014500: bootcycle-images fails after upgrade to JAXP 1.5
Reviewed-by: lancea

! make/tools/src/build/tools/cldrconverter/CLDRConverter.java

Changeset: 5ea5f5dfb96a
Author:    uta
Date:      2013-05-14 20:16 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5ea5f5dfb96a

8012453: (process) Runtime.exec(String) fails if command contains spaces [win]
Reviewed-by: alanb

! src/share/classes/java/lang/ProcessBuilder.java
! src/windows/classes/java/lang/ProcessImpl.java
+ test/java/lang/Runtime/exec/ExecCommand.java

Changeset: e0135f1a8627
Author:    sundar
Date:      2013-05-14 22:36 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/e0135f1a8627

8014519: scriptpad sample does not work with nashorn
Reviewed-by: attila, jlaskey
Contributed-by: rieberandreas at gmail.com

! src/share/sample/scripting/scriptpad/src/com/sun/sample/scriptpad/Main.java
! src/share/sample/scripting/scriptpad/src/resources/Main.js
! src/share/sample/scripting/scriptpad/src/resources/conc.js
! src/share/sample/scripting/scriptpad/src/resources/gui.js
! src/share/sample/scripting/scriptpad/src/resources/mm.js
! src/share/sample/scripting/scriptpad/src/resources/scriptpad.js
! src/share/sample/scripting/scriptpad/src/scripts/browse.js
! src/share/sample/scripting/scriptpad/src/scripts/insertfile.js
! src/share/sample/scripting/scriptpad/src/scripts/linewrap.js
! src/share/sample/scripting/scriptpad/src/scripts/mail.js
! src/share/sample/scripting/scriptpad/src/scripts/memmonitor.js
! src/share/sample/scripting/scriptpad/src/scripts/memory.js
! src/share/sample/scripting/scriptpad/src/scripts/memory.sh
! src/share/sample/scripting/scriptpad/src/scripts/textcolor.js

Changeset: 790d292ee761
Author:    khazra
Date:      2013-05-14 12:01 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/790d292ee761

6328537: Improve javadocs for Socket class by adding references to SocketOptions
Summary: Insert references to SocketOptions.java where applicable
Reviewed-by: alanb, chegar

! src/share/classes/java/net/ServerSocket.java
! src/share/classes/java/net/Socket.java

Changeset: 08ef70f60e0d
Author:    sherman
Date:      2013-05-14 14:09 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/08ef70f60e0d

8012326: Deadlock occurs when Charset.availableCharsets() is called by several threads at the same time
Summary: removed the race condition risk from  ExtendedCahrset access code
Reviewed-by: mchung, alanb

! make/sun/nio/cs/Makefile
! makefiles/CreateJars.gmk
! src/share/classes/java/nio/charset/Charset.java
! src/share/classes/sun/nio/cs/ext/ISO2022_JP_2.java
- src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider
! src/share/classes/sun/nio/cs/ext/MSISO2022JP.java

Changeset: c70fff3db913
Author:    sherman
Date:      2013-05-14 14:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/c70fff3db913

8014217: Base64.getXDecoder().wrap(...).read() doesn't throw exception for an incorrect number of padding chars in the final unit
Summary: to throw IOE for malformed final unit in base64 stream
Reviewed-by: chegar, alanb

! src/share/classes/java/util/Base64.java
! test/java/util/Base64/TestBase64.java

Changeset: a3d79a4c2a24
Author:    dholmes
Date:      2013-05-15 00:36 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/a3d79a4c2a24

8013395: StringBuffer.toString performance regression impacting embedded benchmarks
Summary: cache a copy of the char[] to use with toString() and clear it when ever the sb content is modified
Reviewed-by: alanb, plevart, mduigou, forax

! src/share/classes/java/lang/StringBuffer.java
+ test/java/lang/StringBuffer/ToStringCache.java

Changeset: 93a268759ec3
Author:    michaelm
Date:      2013-05-15 15:01 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/93a268759ec3

8010464: Evolve java networking same origin policy
Reviewed-by: alanb, chegar, dsamersoff, weijun

! src/share/classes/java/net/HttpURLConnection.java
+ src/share/classes/java/net/HttpURLPermission.java
! src/share/classes/sun/net/www/MessageHeader.java
! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java
+ test/java/net/HttpURLPermission/HttpURLPermissionTest.java
+ test/java/net/HttpURLPermission/URLTest.java
+ test/java/net/HttpURLPermission/policy.1
+ test/java/net/HttpURLPermission/policy.2
+ test/java/net/HttpURLPermission/policy.3

Changeset: ef04044f77d2
Author:    sherman
Date:      2013-05-15 07:48 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/ef04044f77d2

8013730: JSR 310 DateTime API Updates III
Summary: Integration of JSR310 Date/Time API update III
Reviewed-by: naoto
Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, masayoshi.okutsu at oracle.com, patrick.zhang at oracle.com

! src/share/classes/java/time/Clock.java
! src/share/classes/java/time/DateTimeException.java
! src/share/classes/java/time/DayOfWeek.java
! src/share/classes/java/time/Duration.java
! src/share/classes/java/time/Instant.java
! src/share/classes/java/time/LocalDate.java
! src/share/classes/java/time/LocalDateTime.java
! src/share/classes/java/time/LocalTime.java
! src/share/classes/java/time/Month.java
! src/share/classes/java/time/MonthDay.java
! src/share/classes/java/time/OffsetDateTime.java
! src/share/classes/java/time/OffsetTime.java
! src/share/classes/java/time/Period.java
! src/share/classes/java/time/Ser.java
! src/share/classes/java/time/Year.java
! src/share/classes/java/time/YearMonth.java
! src/share/classes/java/time/ZoneId.java
! src/share/classes/java/time/ZoneOffset.java
! src/share/classes/java/time/ZoneRegion.java
! src/share/classes/java/time/ZonedDateTime.java
! src/share/classes/java/time/chrono/ChronoDateImpl.java
! src/share/classes/java/time/chrono/ChronoLocalDate.java
! src/share/classes/java/time/chrono/ChronoLocalDateTime.java
! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java
! src/share/classes/java/time/chrono/ChronoZonedDateTime.java
! src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java
! src/share/classes/java/time/chrono/Chronology.java
! src/share/classes/java/time/chrono/Era.java
! src/share/classes/java/time/chrono/HijrahChronology.java
! src/share/classes/java/time/chrono/HijrahDate.java
! src/share/classes/java/time/chrono/HijrahEra.java
! src/share/classes/java/time/chrono/IsoChronology.java
! src/share/classes/java/time/chrono/IsoEra.java
! src/share/classes/java/time/chrono/JapaneseChronology.java
! src/share/classes/java/time/chrono/JapaneseDate.java
! src/share/classes/java/time/chrono/JapaneseEra.java
! src/share/classes/java/time/chrono/MinguoChronology.java
! src/share/classes/java/time/chrono/MinguoDate.java
! src/share/classes/java/time/chrono/MinguoEra.java
! src/share/classes/java/time/chrono/Ser.java
! src/share/classes/java/time/chrono/ThaiBuddhistChronology.java
! src/share/classes/java/time/chrono/ThaiBuddhistDate.java
! src/share/classes/java/time/chrono/ThaiBuddhistEra.java
- src/share/classes/java/time/format/DateTimeFormatSymbols.java
! src/share/classes/java/time/format/DateTimeFormatter.java
! src/share/classes/java/time/format/DateTimeFormatterBuilder.java
! src/share/classes/java/time/format/DateTimeParseContext.java
! src/share/classes/java/time/format/DateTimeParseException.java
! src/share/classes/java/time/format/DateTimePrintContext.java
! src/share/classes/java/time/format/DateTimeTextProvider.java
+ src/share/classes/java/time/format/DecimalStyle.java
! src/share/classes/java/time/format/FormatStyle.java
! src/share/classes/java/time/format/Parsed.java
! src/share/classes/java/time/format/ResolverStyle.java
! src/share/classes/java/time/format/SignStyle.java
! src/share/classes/java/time/format/TextStyle.java
! src/share/classes/java/time/format/package-info.java
! src/share/classes/java/time/temporal/ChronoField.java
! src/share/classes/java/time/temporal/ChronoUnit.java
! src/share/classes/java/time/temporal/IsoFields.java
! src/share/classes/java/time/temporal/JulianFields.java
! src/share/classes/java/time/temporal/Temporal.java
! src/share/classes/java/time/temporal/TemporalAccessor.java
! src/share/classes/java/time/temporal/TemporalAdjuster.java
! src/share/classes/java/time/temporal/TemporalAmount.java
! src/share/classes/java/time/temporal/TemporalField.java
! src/share/classes/java/time/temporal/TemporalQuery.java
! src/share/classes/java/time/temporal/TemporalUnit.java
! src/share/classes/java/time/temporal/UnsupportedTemporalTypeException.java
! src/share/classes/java/time/temporal/ValueRange.java
! src/share/classes/java/time/temporal/WeekFields.java
! src/share/classes/java/time/zone/Ser.java
! src/share/classes/java/time/zone/ZoneOffsetTransition.java
! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java
! src/share/classes/java/time/zone/ZoneRules.java
! src/share/classes/java/time/zone/ZoneRulesException.java
! src/share/classes/java/time/zone/ZoneRulesProvider.java
! src/share/classes/java/util/JapaneseImperialCalendar.java
! src/share/classes/sun/util/calendar/LocalGregorianCalendar.java
! test/java/time/tck/java/time/TCKInstant.java
! test/java/time/tck/java/time/TCKLocalTime.java
! test/java/time/tck/java/time/TCKOffsetTime.java
! test/java/time/tck/java/time/TCKYear.java
! test/java/time/tck/java/time/TCKYearMonth.java
! test/java/time/tck/java/time/TCKZoneOffset.java
! test/java/time/tck/java/time/chrono/TCKChronology.java
! test/java/time/tck/java/time/chrono/TCKChronologySerialization.java
! test/java/time/tck/java/time/chrono/TCKHijrahChronology.java
! test/java/time/tck/java/time/chrono/TCKJapaneseChronology.java
! test/java/time/tck/java/time/chrono/TCKThaiBuddhistChronology.java
- test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java
! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java
! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java
! test/java/time/tck/java/time/format/TCKDateTimeParseResolver.java
+ test/java/time/tck/java/time/format/TCKDecimalStyle.java
+ test/java/time/tck/java/time/format/TCKInstantPrinterParser.java
! test/java/time/tck/java/time/format/TCKTextStyle.java
! test/java/time/tck/java/time/temporal/TCKWeekFields.java
! test/java/time/test/java/time/chrono/TestChronologyPerf.java
! test/java/time/test/java/time/chrono/TestExampleCode.java
+ test/java/time/test/java/time/chrono/TestJapaneseChronology.java
! test/java/time/test/java/time/format/AbstractTestPrinterParser.java
- test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java
! test/java/time/test/java/time/format/TestDateTimeFormatter.java
! test/java/time/test/java/time/format/TestDateTimeFormatterBuilder.java
+ test/java/time/test/java/time/format/TestDecimalStyle.java
! test/java/time/test/java/time/format/TestFractionPrinterParser.java
! test/java/time/test/java/time/format/TestNonIsoFormatter.java
! test/java/time/test/java/time/format/TestNumberParser.java
! test/java/time/test/java/time/format/TestReducedParser.java
! test/java/time/test/java/time/format/TestReducedPrinter.java
! test/java/time/test/java/time/format/TestZoneTextPrinterParser.java

Changeset: bad8f5237f10
Author:    darcy
Date:      2013-05-15 09:54 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/bad8f5237f10

8014677: Correct docs warning for Objects.requireNonNull(T, Supplier<String>)
Reviewed-by: alanb

! src/share/classes/java/util/Objects.java

Changeset: 3d9f25dc630c
Author:    naoto
Date:      2013-05-15 16:48 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3d9f25dc630c

8013233: java/util/Locale/LocaleProviders.sh fails
Reviewed-by: okutsu

! test/java/util/Locale/LocaleProviders.java
! test/java/util/Locale/LocaleProviders.sh

Changeset: 2ec31660cc0e
Author:    valeriep
Date:      2013-05-07 14:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/2ec31660cc0e

8010134: A finalizer in sun.security.pkcs11.wrapper.PKCS11 perhaps should be protected
Summary: Change the finalize method of PKCS11 class to be protected.
Reviewed-by: xuelei

! src/share/classes/sun/security/pkcs11/wrapper/PKCS11.java

Changeset: 991420add35d
Author:    valeriep
Date:      2013-05-07 14:06 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/991420add35d

7196009: SunPkcs11 provider fails to parse config path containing parenthesis
Summary: Enhanced to allow quoted string as library path values.
Reviewed-by: weijun

! src/share/classes/sun/security/pkcs11/Config.java
! test/sun/security/pkcs11/Provider/ConfigShortPath.java
+ test/sun/security/pkcs11/Provider/cspQuotedPath.cfg

Changeset: 804da1e9bd04
Author:    ascarpino
Date:      2013-05-07 14:13 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/804da1e9bd04

8001284: Buffer problems with SunPKCS11-Solaris and CKM_AES_CTR
Summary: Changed output length calculation to include incomplete blocks for CTR mode.
Reviewed-by: valeriep

! src/share/classes/sun/security/pkcs11/P11Cipher.java
! test/sun/security/pkcs11/Cipher/TestSymmCiphersNoPad.java

Changeset: fc70416beef3
Author:    valeriep
Date:      2013-05-13 16:52 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/fc70416beef3

Merge

- make/com/sun/script/Makefile
- make/sun/org/Makefile
- make/sun/org/mozilla/Makefile
- make/sun/org/mozilla/javascript/Makefile
- src/share/classes/com/sun/script/javascript/ExternalScriptable.java
- src/share/classes/com/sun/script/javascript/JSAdapter.java
- src/share/classes/com/sun/script/javascript/JavaAdapter.java
- src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory
- src/share/classes/com/sun/script/javascript/RhinoClassShutter.java
- src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java
- src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java
- src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java
- src/share/classes/com/sun/script/javascript/RhinoTopLevel.java
- src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java
- src/share/classes/com/sun/script/util/BindingsBase.java
- src/share/classes/com/sun/script/util/BindingsEntrySet.java
- src/share/classes/com/sun/script/util/BindingsImpl.java
- src/share/classes/com/sun/script/util/InterfaceImplementor.java
- src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java
- src/share/classes/java/beans/ReflectionUtils.java
- test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java
- test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java
- test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java
- test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java

Changeset: 59357ea7f131
Author:    valeriep
Date:      2013-05-15 18:38 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/59357ea7f131

Merge

- src/share/classes/java/time/format/DateTimeFormatSymbols.java
- src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider
- test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java
- test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java

Changeset: bb01cc14223c
Author:    ewang
Date:      2013-05-16 10:59 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/bb01cc14223c

8004177: test/java/lang/Thread/GenerifyStackTraces.java doesn't clean-up
Reviewed-by: alanb, dholmes, chegar

! test/java/lang/Thread/GenerifyStackTraces.java
- test/java/lang/Thread/StackTraces.java

Changeset: b198389f9da4
Author:    xuelei
Date:      2013-05-16 04:30 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b198389f9da4

8010814: More buffers are stored or returned without cloning
Reviewed-by: lancea

! src/share/classes/com/sun/jndi/ldap/BerDecoder.java
! src/share/classes/com/sun/jndi/ldap/BerEncoder.java
! src/share/classes/com/sun/jndi/ldap/ext/StartTlsResponseImpl.java

Changeset: 81c449fd18fe
Author:    dmeetry
Date:      2013-05-16 19:28 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/81c449fd18fe

8014676: Java debugger may fail to run
Summary: The problem is observed when the binaries for windows are placed under a path which contains a space
Reviewed-by: sla, alanb
Contributed-by: ivan.gerasimov at oracle.com

! src/share/classes/com/sun/tools/jdi/AbstractLauncher.java
! src/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java

Changeset: 74f91b7f4b66
Author:    michaelm
Date:      2013-05-16 17:28 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/74f91b7f4b66

8012625: Incorrect handling of HTTP/1.1 " Expect: 100-continue " in HttpURLConnection
Reviewed-by: alanb, chegar

! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java
+ test/sun/net/www/protocol/http/B8012625.java

Changeset: d02d1b18d828
Author:    michaelm
Date:      2013-05-16 17:31 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/d02d1b18d828

Merge


Changeset: da203779cb33
Author:    jgish
Date:      2013-05-16 11:19 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/da203779cb33

8013380: Removal of stack walk to find resource bundle breaks Glassfish startup
Summary: Use caller's classloader to load resource as an alternative to thread context classloader and system classloader
Reviewed-by: mchung, alanb

! src/share/classes/java/util/logging/LogManager.java
! src/share/classes/java/util/logging/Logger.java
! test/java/util/logging/bundlesearch/IndirectlyLoadABundle.java
- test/java/util/logging/bundlesearch/LoadItUp.java
+ test/java/util/logging/bundlesearch/LoadItUp1.java
+ test/java/util/logging/bundlesearch/LoadItUp2.java
+ test/java/util/logging/bundlesearch/LoadItUp2Invoker.java
! test/java/util/logging/bundlesearch/ResourceBundleSearchTest.java
+ test/java/util/logging/bundlesearch/TwiceIndirectlyLoadABundle.java
+ test/java/util/logging/bundlesearch/resources/CallerSearchableResource_en.properties

Changeset: df133f9cc4c9
Author:    dfuchs
Date:      2013-05-16 18:40 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/df133f9cc4c9

Merge


Changeset: a8be9405bb4b
Author:    khazra
Date:      2013-05-16 10:58 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/a8be9405bb4b

7150552: network test hangs [macosx]
Summary: Remove usage of test/sun/net/www/httptest
Reviewed-by: chegar

! test/ProblemList.txt
! test/java/net/CookieHandler/CookieManagerTest.java
! test/sun/net/www/protocol/http/B6299712.java

Changeset: a13de892cefd
Author:    ksrini
Date:      2013-05-15 18:26 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/a13de892cefd

8001163: [pack200] should support attributes introduced by JSR-308
Reviewed-by: jrose

! src/share/classes/com/sun/java/util/jar/pack/Attribute.java
! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java
! src/share/classes/com/sun/java/util/jar/pack/Constants.java
! src/share/classes/com/sun/java/util/jar/pack/Fixups.java
! src/share/classes/com/sun/java/util/jar/pack/Package.java
! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java
! src/share/native/com/sun/java/util/jar/pack/constants.h
! src/share/native/com/sun/java/util/jar/pack/unpack.cpp
! test/tools/pack200/AttributeTests.java
+ test/tools/pack200/BandIntegrity.java
! test/tools/pack200/InstructionTests.java
! test/tools/pack200/Utils.java
! test/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java
+ test/tools/pack200/typeannos/Lambda.java
+ test/tools/pack200/typeannos/Readme.txt
+ test/tools/pack200/typeannos/TargetTypes.java
+ test/tools/pack200/typeannos/TestTypeAnnotations.java
+ test/tools/pack200/typeannos/TypeUseTarget.java

Changeset: 9abf5dc83823
Author:    vinnie
Date:      2013-05-14 18:08 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/9abf5dc83823

7194075: Various classes of sunec.jar are duplicated in rt.jar
Reviewed-by: mullan, vinnie
Contributed-by: Stephen Flores <stephen.flores at oracle.com>

! make/sun/security/ec/Makefile
! make/sun/security/other/Makefile
! makefiles/CreateJars.gmk
+ src/share/classes/sun/security/ec/CurveDB.java
! src/share/classes/sun/security/ec/ECDHKeyAgreement.java
! src/share/classes/sun/security/ec/ECDSASignature.java
! src/share/classes/sun/security/ec/ECKeyPairGenerator.java
! src/share/classes/sun/security/ec/ECParameters.java
! src/share/classes/sun/security/ec/ECPrivateKeyImpl.java
! src/share/classes/sun/security/ec/ECPublicKeyImpl.java
! src/share/classes/sun/security/ec/NamedCurve.java
! src/share/classes/sun/security/ec/SunECEntries.java
! src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java
! src/share/classes/sun/security/pkcs11/P11Key.java
! src/share/classes/sun/security/pkcs11/P11KeyStore.java
! src/share/classes/sun/security/ssl/JsseJce.java
+ src/share/classes/sun/security/util/ECKeySizeParameterSpec.java
+ src/share/classes/sun/security/util/ECUtil.java
! test/sun/security/pkcs11/ec/TestCurves.java
! test/sun/security/pkcs11/ec/TestECDH2.java
! test/sun/security/pkcs11/ec/TestECDSA2.java

Changeset: fdf082cddb69
Author:    vinnie
Date:      2013-05-14 18:11 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/fdf082cddb69

Merge


Changeset: a399b8be56ae
Author:    vinnie
Date:      2013-05-15 14:49 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/a399b8be56ae

Merge

! makefiles/CreateJars.gmk
- src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider

Changeset: 5153f5154162
Author:    vinnie
Date:      2013-05-15 15:39 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5153f5154162

Merge


Changeset: 0465f27f19f5
Author:    vinnie
Date:      2013-05-16 02:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/0465f27f19f5

Merge

- src/share/classes/java/time/format/DateTimeFormatSymbols.java
- test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java
- test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java

Changeset: 9783f07d43e6
Author:    vinnie
Date:      2013-05-16 13:22 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/9783f07d43e6

Merge

- test/java/lang/Thread/StackTraces.java
- test/java/util/logging/bundlesearch/LoadItUp.java

Changeset: 5e8959ab64af
Author:    mchung
Date:      2013-05-16 15:08 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/5e8959ab64af

4487672: (proxy) Proxy constructor should check for null argument
Reviewed-by: alanb, lancea

! src/share/classes/java/lang/reflect/Proxy.java
! test/java/lang/reflect/Proxy/Basic1.java

Changeset: 68209420aac2
Author:    dfuchs
Date:      2013-05-17 10:40 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/68209420aac2

8013900: More warnings compiling jaxp.
Summary: Some internal implementation classes in Jaxp were redefining equals() without redefining hashCode(). This patch adds hashCode() methods that are consistent with equals().
Reviewed-by: chegar, joehw

+ test/javax/xml/jaxp/PrecisionDecimalDV/XPrecisionDecimalToString.java

Changeset: 3981ad7ec458
Author:    chegar
Date:      2013-05-17 15:00 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3981ad7ec458

8014791: More ProblemList.txt updates (5/2013)
Reviewed-by: alanb

! test/ProblemList.txt

Changeset: fab0e4b682e8
Author:    chegar
Date:      2013-05-17 15:18 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/fab0e4b682e8

Merge

! test/ProblemList.txt
- test/java/util/logging/bundlesearch/LoadItUp.java

Changeset: 222da3d4692a
Author:    chegar
Date:      2013-05-17 16:44 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/222da3d4692a

8014783: java/net/HttpURLPermission/HttpURLPermissionTest.java leaves files open
Reviewed-by: michaelm

! test/java/net/HttpURLPermission/HttpURLPermissionTest.java

Changeset: fed779a87670
Author:    chegar
Date:      2013-05-17 16:44 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/fed779a87670

Merge

- test/java/util/logging/bundlesearch/LoadItUp.java

Changeset: 30101f69e66f
Author:    lana
Date:      2013-05-17 10:11 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/30101f69e66f

Merge

- make/com/sun/script/Makefile
- make/sun/org/Makefile
- make/sun/org/mozilla/Makefile
- make/sun/org/mozilla/javascript/Makefile
- src/share/classes/com/sun/script/javascript/ExternalScriptable.java
- src/share/classes/com/sun/script/javascript/JSAdapter.java
- src/share/classes/com/sun/script/javascript/JavaAdapter.java
- src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory
- src/share/classes/com/sun/script/javascript/RhinoClassShutter.java
- src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java
- src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java
- src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java
- src/share/classes/com/sun/script/javascript/RhinoTopLevel.java
- src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java
- src/share/classes/com/sun/script/util/BindingsBase.java
- src/share/classes/com/sun/script/util/BindingsEntrySet.java
- src/share/classes/com/sun/script/util/BindingsImpl.java
- src/share/classes/com/sun/script/util/InterfaceImplementor.java
- src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java
- src/share/classes/java/time/format/DateTimeFormatSymbols.java
! src/share/classes/java/util/Base64.java
- src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider
- test/java/lang/Thread/StackTraces.java
- test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java
- test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java
- test/java/util/logging/bundlesearch/LoadItUp.java
- test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java
- test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java
- test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java

Changeset: 2868607646a0
Author:    erikj
Date:      2013-05-21 17:02 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/2868607646a0

8011346: build-infra: While Constructing Javadoc information, JSpinner.java error: package sun.util.locale.provider does not exist
Reviewed-by: dholmes, tbell, naoto

! makefiles/GensrcSwing.gmk

Changeset: b61632814be2
Author:    katleman
Date:      2013-05-21 12:54 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/b61632814be2

Merge


Changeset: f559fadbf491
Author:    andrew
Date:      2013-05-22 13:48 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/f559fadbf491

8015087: Provide debugging information for programs
Summary: Add missing debug info to unpack200 and jexec
Reviewed-by: erikj

! makefiles/CompileLaunchers.gmk

Changeset: 88d6a20672ac
Author:    erikj
Date:      2013-05-22 10:31 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/88d6a20672ac

8014970: Use open man pages for non commercial builds
Reviewed-by: omajid, tbell

! makefiles/Images.gmk

Changeset: 169451cf0cc5
Author:    erikj
Date:      2013-05-22 15:00 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/169451cf0cc5

Merge


Changeset: fbd926b20201
Author:    katleman
Date:      2013-05-23 10:47 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/fbd926b20201

Added tag jdk8-b91 for changeset 169451cf0cc5

! .hgtags


From john.coomes at oracle.com  Thu May 23 21:04:00 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 24 May 2013 04:04:00 +0000
Subject: hg: hsx/hotspot-main/nashorn: 19 new changesets
Message-ID: <20130524040415.CB10248CE2@hg.openjdk.java.net>

Changeset: b754fb89367d
Author:    jlaskey
Date:      2013-04-30 10:05 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/b754fb89367d

8006220: Simplify PropertyMaps
Reviewed-by: hannesw, lagergren
Contributed-by: james.laskey at oracle.com

! src/jdk/nashorn/internal/codegen/MapCreator.java
! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java
! src/jdk/nashorn/internal/codegen/ObjectCreator.java
! src/jdk/nashorn/internal/objects/NativeDebug.java
! src/jdk/nashorn/internal/objects/NativeJSAdapter.java
! src/jdk/nashorn/internal/runtime/AccessorProperty.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/Property.java
! src/jdk/nashorn/internal/runtime/PropertyHashMap.java
! src/jdk/nashorn/internal/runtime/PropertyMap.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/SetMethodCreator.java
- src/jdk/nashorn/internal/runtime/SpillProperty.java
! src/jdk/nashorn/internal/runtime/StructureLoader.java
! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java
! src/jdk/nashorn/internal/scripts/JO.java
! src/jdk/nashorn/tools/Shell.java

Changeset: 80cb02dedc83
Author:    hannesw
Date:      2013-05-02 09:19 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/80cb02dedc83

8013729: SwitchPoint invalidation not working over prototype chain
Reviewed-by: lagergren, sundar

! src/jdk/nashorn/internal/runtime/ScriptObject.java
+ test/script/basic/JDK-8013729.js
+ test/script/basic/JDK-8013729.js.EXPECTED

Changeset: 7563c56ca565
Author:    jlaskey
Date:      2013-05-02 13:22 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/7563c56ca565

8013794: JDK-8006220 caused an octane performance regression.
Reviewed-by: lagergren, sundar
Contributed-by: james.laskey at oracle.com

! src/jdk/nashorn/internal/codegen/ObjectCreator.java

Changeset: 9c2376a250b6
Author:    jlaskey
Date:      2013-05-02 13:23 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/9c2376a250b6

Merge


Changeset: c8023561505b
Author:    jlaskey
Date:      2013-05-02 15:01 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/c8023561505b

8013796: load("fx:base.js") should not be in fx:bootstrap.js
Reviewed-by: sundar, lagergren
Contributed-by: james.laskey at oracle.com

! src/jdk/nashorn/internal/runtime/resources/fx/bootstrap.js

Changeset: 5a3f7867e19c
Author:    lagergren
Date:      2013-05-03 15:33 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/5a3f7867e19c

8013477: Node.setSymbol needs to be copy on write - enable IR snapshots for recompilation based on callsite type specialization. [not enabled by default, hidden by a flag for now]
Reviewed-by: jlaskey, hannesw

! bin/jjs
! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java
! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/CompilationPhase.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/codegen/FinalizeTypes.java
! src/jdk/nashorn/internal/codegen/ObjectCreator.java
! src/jdk/nashorn/internal/codegen/Splitter.java
! src/jdk/nashorn/internal/ir/Block.java
! src/jdk/nashorn/internal/ir/CatchNode.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/ir/LexicalContext.java
! src/jdk/nashorn/internal/ir/LexicalContextNode.java
! src/jdk/nashorn/internal/ir/LiteralNode.java
! src/jdk/nashorn/internal/ir/Node.java
! src/jdk/nashorn/internal/ir/Symbol.java
! src/jdk/nashorn/internal/objects/NativeRegExp.java
! src/jdk/nashorn/internal/parser/AbstractParser.java
! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/runtime/CompiledFunction.java
! src/jdk/nashorn/internal/runtime/CompiledFunctions.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/JSONFunctions.java
! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java
! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/regexp/DefaultRegExp.java
! src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java
! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java
! src/jdk/nashorn/internal/runtime/resources/Options.properties
! src/jdk/nashorn/tools/Shell.java
+ test/script/basic/paramspec.js
+ test/script/basic/paramspec.js.EXPECTED
! test/script/basic/runsunspider.js
+ test/script/currently-failing/logcoverage.js
- test/script/trusted/logcoverage.js

Changeset: 829b06307fb2
Author:    lagergren
Date:      2013-05-03 16:01 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/829b06307fb2

8013871: mem usage histograms enabled with compiler logging level set to more specific than or equals to info when --print-mem-usage flag is used
Reviewed-by: jlaskey, hannesw

! src/jdk/nashorn/internal/codegen/Compiler.java
+ src/jdk/nashorn/internal/ir/debug/ClassHistogramElement.java
+ src/jdk/nashorn/internal/ir/debug/ObjectSizeCalculator.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java
! src/jdk/nashorn/internal/runtime/options/Options.java
! src/jdk/nashorn/internal/runtime/resources/Options.properties
! src/jdk/nashorn/tools/Shell.java

Changeset: c0f0033d7b08
Author:    hannesw
Date:      2013-05-03 22:47 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/c0f0033d7b08

8013878: ClassCastException in Regex
Reviewed-by: jlaskey

! src/jdk/nashorn/internal/objects/NativeArray.java
+ test/script/basic/JDK-8013878.js
+ test/script/basic/JDK-8013878.js.EXPECTED

Changeset: f98d22fa3cbc
Author:    hannesw
Date:      2013-05-03 22:48 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/f98d22fa3cbc

8013873: Regexp regression for escaped dash in character class
Reviewed-by: jlaskey

! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java
+ test/script/basic/JDK-8013873.js
+ test/script/basic/JDK-8013873.js.EXPECTED

Changeset: f3dcb12c8439
Author:    hannesw
Date:      2013-05-03 22:50 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/f3dcb12c8439

8013874: Function argument's prototype seem cached and wrongly reused
Reviewed-by: jlaskey

! src/jdk/nashorn/internal/runtime/PropertyMap.java
+ test/script/basic/JDK-8013874.js
+ test/script/basic/JDK-8013874.js.EXPECTED

Changeset: 544e17632e96
Author:    lagergren
Date:      2013-05-07 14:36 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/544e17632e96

8013913: Removed Source field from all nodes except FunctionNode in order to save footprint
Reviewed-by: jlaskey, attila

! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/FinalizeTypes.java
! src/jdk/nashorn/internal/codegen/FoldConstants.java
! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/codegen/Splitter.java
! src/jdk/nashorn/internal/ir/AccessNode.java
! src/jdk/nashorn/internal/ir/BaseNode.java
! src/jdk/nashorn/internal/ir/BinaryNode.java
! src/jdk/nashorn/internal/ir/Block.java
! src/jdk/nashorn/internal/ir/BreakNode.java
! src/jdk/nashorn/internal/ir/BreakableNode.java
! src/jdk/nashorn/internal/ir/CallNode.java
! src/jdk/nashorn/internal/ir/CaseNode.java
! src/jdk/nashorn/internal/ir/CatchNode.java
! src/jdk/nashorn/internal/ir/ContinueNode.java
! src/jdk/nashorn/internal/ir/EmptyNode.java
! src/jdk/nashorn/internal/ir/ExecuteNode.java
! src/jdk/nashorn/internal/ir/ForNode.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/ir/IdentNode.java
! src/jdk/nashorn/internal/ir/IfNode.java
! src/jdk/nashorn/internal/ir/IndexNode.java
! src/jdk/nashorn/internal/ir/LabelNode.java
! src/jdk/nashorn/internal/ir/LexicalContext.java
! src/jdk/nashorn/internal/ir/LexicalContextNode.java
! src/jdk/nashorn/internal/ir/LineNumberNode.java
! src/jdk/nashorn/internal/ir/LiteralNode.java
- src/jdk/nashorn/internal/ir/Location.java
! src/jdk/nashorn/internal/ir/LoopNode.java
! src/jdk/nashorn/internal/ir/Node.java
! src/jdk/nashorn/internal/ir/ObjectNode.java
! src/jdk/nashorn/internal/ir/PropertyNode.java
! src/jdk/nashorn/internal/ir/ReturnNode.java
! src/jdk/nashorn/internal/ir/RuntimeNode.java
! src/jdk/nashorn/internal/ir/SplitNode.java
! src/jdk/nashorn/internal/ir/SwitchNode.java
! src/jdk/nashorn/internal/ir/TernaryNode.java
! src/jdk/nashorn/internal/ir/ThrowNode.java
! src/jdk/nashorn/internal/ir/TryNode.java
! src/jdk/nashorn/internal/ir/UnaryNode.java
! src/jdk/nashorn/internal/ir/VarNode.java
! src/jdk/nashorn/internal/ir/WhileNode.java
! src/jdk/nashorn/internal/ir/WithNode.java
! src/jdk/nashorn/internal/ir/debug/JSONWriter.java
! src/jdk/nashorn/internal/objects/NativeDebug.java
! src/jdk/nashorn/internal/parser/AbstractParser.java
! src/jdk/nashorn/internal/parser/JSONParser.java
! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java
! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java
! src/jdk/nashorn/tools/Shell.java

Changeset: fb1d7ea3e1b6
Author:    lagergren
Date:      2013-05-07 14:43 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/fb1d7ea3e1b6

8013914: Removed explicit LineNumberNodes that were too brittle when code moves around, and also introduced unnecessary footprint. Introduced the Statement node and fixed dead code elimination issues that were discovered by the absense of labels for LineNumberNodes.
Reviewed-by: jlaskey, attila

! make/project.properties
! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/FinalizeTypes.java
! src/jdk/nashorn/internal/codegen/FoldConstants.java
! src/jdk/nashorn/internal/codegen/Label.java
! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/codegen/Splitter.java
! src/jdk/nashorn/internal/ir/Block.java
! src/jdk/nashorn/internal/ir/BlockLexicalContext.java
! src/jdk/nashorn/internal/ir/BreakNode.java
! src/jdk/nashorn/internal/ir/BreakableNode.java
! src/jdk/nashorn/internal/ir/CallNode.java
! src/jdk/nashorn/internal/ir/CatchNode.java
! src/jdk/nashorn/internal/ir/ContinueNode.java
! src/jdk/nashorn/internal/ir/EmptyNode.java
! src/jdk/nashorn/internal/ir/ExecuteNode.java
! src/jdk/nashorn/internal/ir/ForNode.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/ir/IfNode.java
! src/jdk/nashorn/internal/ir/LabelNode.java
! src/jdk/nashorn/internal/ir/LexicalContextNode.java
- src/jdk/nashorn/internal/ir/LineNumberNode.java
! src/jdk/nashorn/internal/ir/LoopNode.java
! src/jdk/nashorn/internal/ir/Node.java
! src/jdk/nashorn/internal/ir/ReturnNode.java
! src/jdk/nashorn/internal/ir/SplitNode.java
+ src/jdk/nashorn/internal/ir/Statement.java
! src/jdk/nashorn/internal/ir/SwitchNode.java
! src/jdk/nashorn/internal/ir/Symbol.java
! src/jdk/nashorn/internal/ir/ThrowNode.java
! src/jdk/nashorn/internal/ir/TryNode.java
! src/jdk/nashorn/internal/ir/VarNode.java
! src/jdk/nashorn/internal/ir/WhileNode.java
! src/jdk/nashorn/internal/ir/WithNode.java
! src/jdk/nashorn/internal/ir/debug/JSONWriter.java
! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java
! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java
! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeDebug.java
! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java
! src/jdk/nashorn/tools/Shell.java
+ test/script/basic/no_line_numbers.js
+ test/script/basic/no_line_numbers.js.EXPECTED

Changeset: d28180d97c61
Author:    attila
Date:      2013-05-08 15:51 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/d28180d97c61

8013912: Nashorn needs to reuse temporary symbols
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/CompilationPhase.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/codegen/CompilerConstants.java
! src/jdk/nashorn/internal/codegen/FinalizeTypes.java
! src/jdk/nashorn/internal/ir/AccessNode.java
! src/jdk/nashorn/internal/ir/BlockLexicalContext.java
! src/jdk/nashorn/internal/ir/CallNode.java
! src/jdk/nashorn/internal/ir/IdentNode.java
! src/jdk/nashorn/internal/ir/IndexNode.java
! src/jdk/nashorn/internal/ir/Node.java
! src/jdk/nashorn/internal/ir/RuntimeNode.java
! src/jdk/nashorn/internal/ir/Symbol.java
+ src/jdk/nashorn/internal/ir/TemporarySymbols.java
! src/jdk/nashorn/internal/ir/TypeOverride.java

Changeset: 18ce1cd3026c
Author:    attila
Date:      2013-05-08 16:48 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/18ce1cd3026c

8014225: Rerun only failed 262 tests
Reviewed-by: jlaskey, lagergren

! make/project.properties
! test/src/jdk/nashorn/internal/test/framework/AbstractScriptRunnable.java
! test/src/jdk/nashorn/internal/test/framework/ParallelTestRunner.java
! test/src/jdk/nashorn/internal/test/framework/TestConfig.java
! test/src/jdk/nashorn/internal/test/framework/TestFinder.java

Changeset: 9073bcc4307b
Author:    lagergren
Date:      2013-05-10 13:16 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/9073bcc4307b

8014329: Slim down the label stack structure in CodeGenerator
Reviewed-by: attila, jlaskey

! .hgignore
! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/codegen/Label.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/ir/BlockLexicalContext.java

Changeset: 098a4cedcaf2
Author:    attila
Date:      2013-05-14 12:39 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/098a4cedcaf2

8014492: Make NashornLinker public
Reviewed-by: hannesw, jlaskey

! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java

Changeset: 264bb0af9e4e
Author:    jlaskey
Date:      2013-05-14 09:05 -0300
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/264bb0af9e4e

Merge

- src/jdk/nashorn/internal/ir/LineNumberNode.java
- src/jdk/nashorn/internal/ir/Location.java
- src/jdk/nashorn/internal/runtime/SpillProperty.java
- test/script/trusted/logcoverage.js

Changeset: 6b9f41203800
Author:    lana
Date:      2013-05-17 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/6b9f41203800

Merge

- src/jdk/nashorn/internal/ir/LineNumberNode.java
- src/jdk/nashorn/internal/ir/Location.java
- src/jdk/nashorn/internal/runtime/SpillProperty.java
- test/script/trusted/logcoverage.js

Changeset: dee23cce5235
Author:    katleman
Date:      2013-05-23 10:47 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/dee23cce5235

Added tag jdk8-b91 for changeset 6b9f41203800

! .hgtags


From john.coomes at oracle.com  Thu May 23 21:01:39 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 24 May 2013 04:01:39 +0000
Subject: hg: hsx/hotspot-main/langtools: 45 new changesets
Message-ID: <20130524040350.BC6ED48CE1@hg.openjdk.java.net>

Changeset: abd153854f16
Author:    jjg
Date:      2013-05-03 09:56 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/abd153854f16

8012728: Normalize @ignore comments on langtools tests
Reviewed-by: vromero, mcimadamore

! test/com/sun/javadoc/_template/Template.java
! test/com/sun/javadoc/_template/TemplateComplete.java
! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java
! test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java
! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest1.java
! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java
! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java
! test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java
! test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java
! test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java
! test/tools/javac/generics/7034511/T7034511a.java
! test/tools/javac/generics/7034511/T7034511b.java
! test/tools/javac/generics/OverrideBridge.java
! test/tools/javac/lambda/TargetType36.java
! test/tools/javac/lambda/TargetType53.java
! test/tools/javac/lambda/TargetType54.java
! test/tools/javac/lambda/TargetType58.java
! test/tools/javac/lambda/TargetType59.java
! test/tools/javac/lambda/TargetType62.java
! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedA1Test.java
! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB1Test.java
! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB2Test.java
! test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideATest.java
! test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideBTest.java
! test/tools/javap/output/RepeatingTypeAnnotations.java
! test/tools/javap/output/Tester.java

Changeset: 38c4bade0ec1
Author:    jjg
Date:      2013-05-03 10:17 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/38c4bade0ec1

8002387: Improve rendered HTML formatting for {@code}
Reviewed-by: ksrini

! src/share/classes/com/sun/tools/javadoc/Comment.java
+ test/com/sun/javadoc/testLiteralCodeInPre/TestLiteralCodeInPre.java
+ test/com/sun/javadoc/testLiteralCodeInPre/pkg/Test.java

Changeset: a2889739cf21
Author:    jjg
Date:      2013-05-03 15:08 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/a2889739cf21

8000407: remove @GenerateNativeHeader
Reviewed-by: vromero, darcy

! src/share/classes/com/sun/tools/javac/code/Symtab.java
! src/share/classes/com/sun/tools/javac/jvm/JNIWriter.java
- src/share/classes/javax/tools/annotation/GenerateNativeHeader.java
! test/tools/javac/nativeHeaders/NativeHeaderTest.java
! test/tools/javac/nativeHeaders/javahComparison/CompareTest.java
- test/tools/javac/nativeHeaders/javahComparison/TestClass2.java
- test/tools/javac/nativeHeaders/javahComparison/TestClass3.java

Changeset: d918b63a5509
Author:    jjg
Date:      2013-05-03 17:44 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/d918b63a5509

8008768: Using {@inheritDoc} in simple tag defined via -tag fails
Reviewed-by: jjg, mduigou
Contributed-by: jonathan.gibbons at oracle.com, mike.duigou at oracle.com

! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ReturnTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SeeTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SimpleTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ThrowsTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFinder.java
+ test/com/sun/javadoc/InheritDocForUserTags/DocTest.java
+ test/com/sun/javadoc/testSimpleTagInherit/TestSimpleTagInherit.java
+ test/com/sun/javadoc/testSimpleTagInherit/p/BaseClass.java
+ test/com/sun/javadoc/testSimpleTagInherit/p/TestClass.java

Changeset: e8987ce7fb4b
Author:    darcy
Date:      2013-05-05 21:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/e8987ce7fb4b

8013909: Fix doclint issues in javax.lang.model
Reviewed-by: jjg

! src/share/classes/javax/annotation/processing/SupportedAnnotationTypes.java
! src/share/classes/javax/annotation/processing/SupportedOptions.java
! src/share/classes/javax/annotation/processing/SupportedSourceVersion.java
! src/share/classes/javax/lang/model/AnnotatedConstruct.java
! src/share/classes/javax/lang/model/element/NestingKind.java
! src/share/classes/javax/lang/model/util/ElementScanner6.java
! src/share/classes/javax/lang/model/util/Elements.java
! src/share/classes/javax/lang/model/util/Types.java

Changeset: a7ff36d06fa2
Author:    jlahoda
Date:      2013-05-06 16:22 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/a7ff36d06fa2

8009724: Enhance the DocTree API with DocTreePath
Summary: Adding DocTreePath and DocTreePathScanner similar to TreePath and TreePathScanner, respectively
Reviewed-by: jjg
Contributed-by: Ralph Benjamin Ruijs <ralphbenjamin at netbeans.org>, Jan Lahoda <jlahoda at netbeans.org>

+ src/share/classes/com/sun/source/util/DocTreePath.java
+ src/share/classes/com/sun/source/util/DocTreePathScanner.java
! src/share/classes/com/sun/source/util/DocTrees.java
! src/share/classes/com/sun/tools/doclint/Checker.java
! src/share/classes/com/sun/tools/javac/api/JavacTrees.java
+ test/tools/javac/doctree/DocTreePathScannerTest.java
! test/tools/javac/doctree/ReferenceTest.java

Changeset: 68142e69cafb
Author:    rfield
Date:      2013-05-07 06:39 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/68142e69cafb

8014023: When a method reference to a local class constructor is contained in a method whose number of parameters matches the number of constructor parameters compilation fails
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
+ test/tools/javac/lambda/methodReference/TreeMakerParamsIsGoofy.java

Changeset: 43c2f7cb9c76
Author:    jjg
Date:      2013-05-07 14:27 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/43c2f7cb9c76

8004082: test/tools/javac/plugin/showtype/Test.java fails on windows: jtreg can't delete plugin.jar
Reviewed-by: vromero, mcimadamore

! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
! src/share/classes/com/sun/tools/javac/main/Main.java
! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java
+ src/share/classes/com/sun/tools/javac/util/ServiceLoader.java
! test/tools/javac/plugin/showtype/Test.java

Changeset: 780014a234fa
Author:    jfranck
Date:      2013-05-08 14:10 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/780014a234fa

8013485: javac can't handle annotations with a <clinit> from a previous compilation unit
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/comp/Check.java
+ test/tools/javac/annotations/clinit/AnnoWithClinit1.java
+ test/tools/javac/annotations/clinit/AnnoWithClinitFail.java
+ test/tools/javac/annotations/clinit/AnnoWithClinitFail.out

Changeset: c68834236058
Author:    lana
Date:      2013-05-08 23:54 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/c68834236058

Merge


Changeset: ce7e1674eb73
Author:    alanb
Date:      2013-05-10 16:10 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/ce7e1674eb73

8014318: tools/javac/profiles/ProfileOptionTest.java needs modifying now that javax.script is in compact1
Reviewed-by: mchung

! test/tools/javac/profiles/ProfileOptionTest.java

Changeset: 1c43236f6d69
Author:    darcy
Date:      2013-05-10 14:31 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/1c43236f6d69

8014365: Restore Objects.requireNonNull(T, Supplier<String>)
Reviewed-by: jjg

! makefiles/BuildLangtools.gmk

Changeset: e39669aea0bd
Author:    jjg
Date:      2013-05-12 18:18 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/e39669aea0bd

8014363: javac test class ToolTester handles classpath incorrectly
Reviewed-by: ksrini

! test/tools/javac/api/6406133/T6406133.java
! test/tools/javac/api/6410643/T6410643.java
! test/tools/javac/api/6411310/T6411310.java
! test/tools/javac/api/6411333/T6411333.java
! test/tools/javac/api/6412656/T6412656.java
! test/tools/javac/api/6415780/T6415780.java
! test/tools/javac/api/6418694/T6418694.java
! test/tools/javac/api/6421111/T6421111.java
! test/tools/javac/api/6421756/T6421756.java
! test/tools/javac/api/6422215/T6422215.java
! test/tools/javac/api/6422327/T6422327.java
! test/tools/javac/api/6423003/T6423003.java
! test/tools/javac/api/6431257/T6431257.java
! test/tools/javac/api/6437349/T6437349.java
! test/tools/javac/api/6437999/T6437999.java
! test/tools/javac/api/6440333/T6440333.java
! test/tools/javac/api/6440528/T6440528.java
! test/tools/javac/api/6468404/T6468404.java
! test/tools/javac/api/6731573/T6731573.java
! test/tools/javac/api/6733837/T6733837.java
! test/tools/javac/api/TestJavacTaskScanner.java
! test/tools/javac/api/guide/Test.java
! test/tools/javac/api/lib/ToolTester.java

Changeset: 8dd528992c15
Author:    jlahoda
Date:      2013-05-10 15:15 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/8dd528992c15

8012929: Trees.getElement should work not only for declaration trees, but also for use-trees
Reviewed-by: jjg
Contributed-by: Dusan Balek <dbalek at netbeans.org>, Jan Lahoda <jlahoda at netbeans.org>

! src/share/classes/com/sun/tools/doclint/Env.java
! src/share/classes/com/sun/tools/javac/api/JavacTrees.java
! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java
+ test/tools/javac/api/TestGetElementReference.java
+ test/tools/javac/api/TestGetElementReferenceData.java

Changeset: 8ea30d59ac41
Author:    jjg
Date:      2013-05-14 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/8ea30d59ac41

8010440: Replace int constants in LinkInfoImpl with enum
Reviewed-by: bpatel, darcy

! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java

Changeset: 74cd21f2c2fe
Author:    jjg
Date:      2013-05-14 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/74cd21f2c2fe

8011642: Remove LinkOutput in favor of direct use of Content
Reviewed-by: bpatel, darcy

! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java
+ src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocletConstants.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java
! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java
! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java

Changeset: 7a9ef837e57f
Author:    jjg
Date:      2013-05-14 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/7a9ef837e57f

8011650: reduce use of RawHtml nodes in doclet
Reviewed-by: darcy

! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java
! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/RawHtml.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java

Changeset: 6ea964c78845
Author:    jjg
Date:      2013-05-14 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/6ea964c78845

8011651: simplify LinkInfoImpl API
Reviewed-by: darcy

! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java

Changeset: e6c5b5ee9fac
Author:    jjg
Date:      2013-05-14 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/e6c5b5ee9fac

8011662: Remove single instance of resource with HTML from doclet resource bundle
Reviewed-by: bpatel, darcy

! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java
! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties

Changeset: ce4f0769b4b2
Author:    jjg
Date:      2013-05-14 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/ce4f0769b4b2

8011668: Allow HTMLWriter.getResource to take Content args
Reviewed-by: darcy

! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties
! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java

Changeset: 4c43e51433ba
Author:    jjg
Date:      2013-05-14 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/4c43e51433ba

8011288: Erratic/inconsistent indentation of signatures
Reviewed-by: darcy

! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/RawHtml.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java
+ test/com/sun/javadoc/testIndentation/TestIndentation.java
+ test/com/sun/javadoc/testIndentation/p/Indent.java
! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java
! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java
! test/com/sun/javadoc/testTypeParams/TestTypeParameters.java

Changeset: 7af0fa419a2b
Author:    jjg
Date:      2013-05-14 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/7af0fa419a2b

8012174: {@literal} and {@code} should use \"new\" Taglet, not old.
Reviewed-by: darcy

! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTag.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/CodeTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java

Changeset: 6a5288a298fd
Author:    jjg
Date:      2013-05-14 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/6a5288a298fd

8012175: Convert TagletOutputImpl to use ContentBuilder instead of StringBuilder
Reviewed-by: darcy

! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/CodeTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/Taglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletOutput.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java
! test/com/sun/javadoc/AuthorDD/AuthorDD.java
! test/com/sun/javadoc/testConstructorIndent/TestConstructorIndent.java
! test/com/sun/javadoc/testHref/TestHref.java
! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java
! test/com/sun/javadoc/testJavaFX/TestJavaFX.java
! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java
! test/com/sun/javadoc/testParamTaglet/TestParamTaglet.java
! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java
! test/com/sun/javadoc/testSimpleTagInherit/TestSimpleTagInherit.java
! test/com/sun/javadoc/testSinceTag/TestSinceTag.java
! test/com/sun/javadoc/testValueTag/TestValueTag.java

Changeset: 76a691e3e961
Author:    jjg
Date:      2013-05-14 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/76a691e3e961

8012176: reduce use of TagletOutputImpl.toString
Reviewed-by: darcy

! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java
! test/com/sun/javadoc/testConstructorIndent/TestConstructorIndent.java
! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java
! test/com/sun/javadoc/testJavaFX/TestJavaFX.java
! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java
! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java
! test/com/sun/javadoc/testSinceTag/TestSinceTag.java

Changeset: 937aa020c667
Author:    jjg
Date:      2013-05-14 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/937aa020c667

8012177: HTMLDocletWriter methods should generate Content, not Strings
Reviewed-by: darcy

! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java

Changeset: bd51ca92c013
Author:    jjg
Date:      2013-05-14 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/bd51ca92c013

8012178: Cleanup use of Util.escapeHtmlChars
Reviewed-by: darcy

! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java

Changeset: df4f44800923
Author:    jjg
Date:      2013-05-14 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/df4f44800923

8012183: replace some uses of Configuration.getText with Configuration.getResource
Reviewed-by: darcy

! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/ProfileIndexFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java

Changeset: 051b728cfe90
Author:    jjg
Date:      2013-05-14 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/051b728cfe90

8012180: Speed up removeNonInlineHtmlTags
Reviewed-by: darcy

! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTag.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java

Changeset: 25c89a492f14
Author:    jjg
Date:      2013-05-14 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/25c89a492f14

8012295: Cleanup JavaFX features in standard doclet
Reviewed-by: darcy

! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BasePropertyTaglet.java
- src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java
! test/com/sun/javadoc/testJavaFX/TestJavaFX.java

Changeset: 081d7c72ee92
Author:    jjg
Date:      2013-05-14 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/081d7c72ee92

8012311: Cleanup names and duplicatre code in TagletManager
Reviewed-by: darcy

! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java
! test/com/sun/javadoc/testJavaFX/TestJavaFX.java

Changeset: ca8808c88f94
Author:    jjg
Date:      2013-05-14 10:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/ca8808c88f94

8012308: Remove TagletOutput in favor of direct use of Content
Reviewed-by: darcy

! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java
- src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BasePropertyTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BaseTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/CodeTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/DeprecatedTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/DocRootTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LegacyTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ReturnTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SeeTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SimpleTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/Taglet.java
- src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletOutput.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ThrowsTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java
! test/com/sun/javadoc/testNestedInlineTag/testtaglets/BoldTaglet.java
! test/com/sun/javadoc/testNestedInlineTag/testtaglets/GreenTaglet.java
! test/com/sun/javadoc/testNestedInlineTag/testtaglets/UnderlineTaglet.java
! test/com/sun/javadoc/testTaglets/taglets/Foo.java

Changeset: c09b7234cded
Author:    rfield
Date:      2013-05-14 11:11 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/c09b7234cded

8012556: Implement lambda methods on interfaces as static
8006140: Javac NPE compiling Lambda expression on initialization expression of static field in interface
Summary: Lambdas occurring in static contexts or those not needing instance information should be generated into static methods.  This has long been the case for classes.  However, as a work-around to the lack of support for statics on interfaces, interface lambda methods have been generated into default methods.  For lambdas in interface static contexts (fields and static methods) this causes an NPE in javac because there is no 'this'.  MethodHandles now support static methods on interfaces.  This changeset allows lambda methods to be generated as static interface methods.  An existing bug in Hotspot (8013875) is exposed in a test when the "-esa" flag is used.  This test and another test that already exposed this bug have been marked with @ignore.
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
+ test/tools/javac/lambda/LambdaInterfaceStaticField.java
! test/tools/javac/lambda/MethodReference66.java
! test/tools/javac/lambda/bytecode/TestLambdaBytecode.java
! test/tools/javac/lambda/lambdaExecution/InInterface.java

Changeset: 46b9c25f7024
Author:    jjg
Date:      2013-05-14 12:55 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/46b9c25f7024

8014461: genstubs creates default native methods
Reviewed-by: alanb

! make/tools/genstubs/GenStubs.java

Changeset: 0384683c64be
Author:    jjg
Date:      2013-05-14 13:55 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/0384683c64be

8014557: Mutable static field in HtmlDocletWriter
Reviewed-by: ksrini

! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java

Changeset: ddb4a2bfcd82
Author:    jjg
Date:      2013-05-14 15:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/ddb4a2bfcd82

8013852: update reference impl for type-annotations
Reviewed-by: jjg
Contributed-by: wdietl at gmail.com, steve.sides at oracle.com, joel.franck at oracle.com, alex.buckley at oracle.com

! src/share/classes/com/sun/tools/classfile/ClassWriter.java
! src/share/classes/com/sun/tools/classfile/TypeAnnotation.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! src/share/classes/com/sun/tools/javac/code/Annotations.java
! src/share/classes/com/sun/tools/javac/code/Attribute.java
! src/share/classes/com/sun/tools/javac/code/Printer.java
! src/share/classes/com/sun/tools/javac/code/Type.java
! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java
! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java
! src/share/classes/com/sun/tools/javac/code/Types.java
! src/share/classes/com/sun/tools/javac/comp/Annotate.java
! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/Check.java
! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
! src/share/classes/com/sun/tools/javac/comp/Lower.java
! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java
! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java
! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java
! src/share/classes/com/sun/tools/javac/jvm/Code.java
! src/share/classes/com/sun/tools/javac/jvm/Gen.java
! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
! src/share/classes/com/sun/tools/javac/parser/JavacParser.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
! src/share/classes/com/sun/tools/javac/tree/JCTree.java
! src/share/classes/com/sun/tools/javac/tree/Pretty.java
! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java
! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java
! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java
! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java
! src/share/classes/com/sun/tools/javac/util/List.java
! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java
! src/share/classes/com/sun/tools/javadoc/AnnotationTypeElementDocImpl.java
! src/share/classes/com/sun/tools/javadoc/AnnotationValueImpl.java
! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java
! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java
! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java
! src/share/classes/com/sun/tools/javadoc/Messager.java
! src/share/classes/com/sun/tools/javadoc/TypeMaker.java
! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java
! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java
! test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java
! test/com/sun/javadoc/typeAnnotations/smoke/pkg/TargetTypes.java
! test/tools/javac/annotations/typeAnnotations/attribution/Scopes.java
! test/tools/javac/annotations/typeAnnotations/classfile/ClassfileTestHelper.java
! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest1.java
! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java
+ test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest3.java
! test/tools/javac/annotations/typeAnnotations/classfile/DeadCode.java
! test/tools/javac/annotations/typeAnnotations/classfile/NewTypeArguments.java
+ test/tools/javac/annotations/typeAnnotations/classfile/T8008762.java
+ test/tools/javac/annotations/typeAnnotations/classfile/T8008769.java
+ test/tools/javac/annotations/typeAnnotations/classfile/T8010015.java
+ test/tools/javac/annotations/typeAnnotations/classfile/TestNewCastArray.java
! test/tools/javac/annotations/typeAnnotations/classfile/TypeCasts.java
! test/tools/javac/annotations/typeAnnotations/classfile/Wildcards.java
! test/tools/javac/annotations/typeAnnotations/failures/LazyConstantValue.java
+ test/tools/javac/annotations/typeAnnotations/failures/LazyConstantValue.out
! test/tools/javac/annotations/typeAnnotations/failures/LintCast.out
! test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.java
! test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.out
+ test/tools/javac/annotations/typeAnnotations/failures/T8008751.java
+ test/tools/javac/annotations/typeAnnotations/failures/T8009360.java
+ test/tools/javac/annotations/typeAnnotations/failures/T8011722.java
+ test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DeclarationAnnotation.java
+ test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DeclarationAnnotation.out
+ test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DeclarationAnnotation.java
+ test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DeclarationAnnotation.out
! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/Nesting.java
! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/StaticThings.out
! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/WrongType.java
! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/WrongType.out
! test/tools/javac/annotations/typeAnnotations/failures/common/rest/MissingAnnotationValue.java
! test/tools/javac/annotations/typeAnnotations/failures/common/rest/MissingAnnotationValue.out
+ test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DeclarationAnnotation.java
+ test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DeclarationAnnotation.out
+ test/tools/javac/annotations/typeAnnotations/newlocations/AnonymousClass.java
! test/tools/javac/annotations/typeAnnotations/newlocations/Lambda.java
! test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java
! test/tools/javac/annotations/typeAnnotations/referenceinfos/Constructors.java
! test/tools/javac/annotations/typeAnnotations/referenceinfos/Driver.java
! test/tools/javac/annotations/typeAnnotations/referenceinfos/ExceptionParameters.java
+ test/tools/javac/annotations/typeAnnotations/referenceinfos/Initializers.java
! test/tools/javac/annotations/typeAnnotations/referenceinfos/Lambda.java
! test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodThrows.java
! test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java
! test/tools/javac/annotations/typeAnnotations/referenceinfos/NestedTypes.java
! test/tools/javac/annotations/typeAnnotations/referenceinfos/NewObjects.java
! test/tools/javac/annotations/typeAnnotations/referenceinfos/ReferenceInfoUtil.java
+ test/tools/javac/annotations/typeAnnotations/referenceinfos/Test.java
! test/tools/javac/api/TestJavacTaskScanner.java
+ test/tools/javac/diags/examples/ArrayAndReceiver.java
+ test/tools/javac/diags/examples/IncorrectConstructorReceiverName.java
+ test/tools/javac/diags/examples/IncorrectConstructorReceiverType.java
+ test/tools/javac/diags/examples/IncorrectReceiverName.java
+ test/tools/javac/diags/examples/ReceiverParameterNotApplicableConstructor.java
+ test/tools/javac/diags/examples/VarargsAndReceiver.java
! test/tools/javac/lib/DPrinter.java
+ test/tools/javac/processing/model/type/BasicAnnoTests.java
! test/tools/javac/tree/SourceTreeScannerTest.java
! test/tools/javap/output/RepeatingTypeAnnotations.java
! test/tools/javap/typeAnnotations/NewArray.java
! test/tools/javap/typeAnnotations/Presence.java
! test/tools/javap/typeAnnotations/TypeCasts.java

Changeset: 53b389eb39c1
Author:    sogoel
Date:      2013-05-14 18:02 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/53b389eb39c1

8013163: Convert 4 tools multicatch tests to jtreg format
Reviewed-by: jjg

+ test/tools/javac/multicatch/Pos11.java
+ test/tools/javac/multicatch/Pos12.java

Changeset: 529fb3ed5d2a
Author:    jjg
Date:      2013-05-14 21:08 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/529fb3ed5d2a

8014323: Add VariableTree.getNameExpression
Reviewed-by: darcy

! src/share/classes/com/sun/source/tree/VariableTree.java
! src/share/classes/com/sun/source/util/TreeScanner.java
! test/tools/javac/tree/SourceTreeScannerTest.java

Changeset: bcd927639039
Author:    darcy
Date:      2013-05-15 00:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/bcd927639039

8004133: Provide javax.lang.model.* implementation backed by core reflection
Summary: Joint work by darcy and jfranck to provide sample code for JEP 119.
Reviewed-by: jjg
Contributed-by: joe.darcy at oracle.com, joel.franck at oracle.com

+ src/share/sample/language/model/CoreReflectionFactory.java

Changeset: 05ec778794d0
Author:    mcimadamore
Date:      2013-05-15 14:00 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/05ec778794d0

8012003: Method diagnostics resolution need to be simplified in some cases
Summary: Unfold method resolution diagnostics when they mention errors in poly expressions
Reviewed-by: jjg, vromero

! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/Resolve.java
! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
! src/share/classes/com/sun/tools/javac/main/Option.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
! src/share/classes/com/sun/tools/javac/resources/javac.properties
! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java
! src/share/classes/com/sun/tools/javac/util/List.java
! src/share/classes/com/sun/tools/javac/util/Log.java
+ test/tools/javac/Diagnostics/compressed/T8012003a.java
+ test/tools/javac/Diagnostics/compressed/T8012003a.out
+ test/tools/javac/Diagnostics/compressed/T8012003b.java
+ test/tools/javac/Diagnostics/compressed/T8012003b.out
+ test/tools/javac/Diagnostics/compressed/T8012003c.java
+ test/tools/javac/Diagnostics/compressed/T8012003c.out
! test/tools/javac/diags/examples/BadArgTypesInLambda.java
+ test/tools/javac/diags/examples/CompressedDiags.java
! test/tools/javac/diags/examples/KindnameConstructor.java
+ test/tools/javac/diags/examples/ProbFoundReqFragment.java
! test/tools/javac/lambda/TargetType66.out

Changeset: 33d1937af1a3
Author:    mcimadamore
Date:      2013-05-15 14:02 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/33d1937af1a3

8012685: Spurious raw types warning when using unbound method references
Summary: Spurious raw type warning when unbound method reference qualifier parameter types are inferred from target
Reviewed-by: jjg, vromero

! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/Check.java
+ test/tools/javac/lambda/MethodReference67.java
+ test/tools/javac/lambda/MethodReference67.out

Changeset: 78717f2d00e8
Author:    mcimadamore
Date:      2013-05-15 14:03 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/78717f2d00e8

8013222: Javac issues spurious raw type warnings when lambda has implicit parameter types
Summary: Bad warnings and position for lambda inferred parameter types
Reviewed-by: jjg, vromero

! src/share/classes/com/sun/tools/javac/comp/Attr.java
+ test/tools/javac/lambda/NoWarnOnImplicitParams.java
+ test/tools/javac/lambda/NoWarnOnImplicitParams.out

Changeset: 31ef33db5e0e
Author:    rfield
Date:      2013-05-15 06:53 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/31ef33db5e0e

8010006: NPE in javac with interface super in lambda
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
+ test/tools/javac/lambda/LambdaWithInterfaceSuper.java

Changeset: 445b8b5ae9f4
Author:    jjg
Date:      2013-05-15 10:39 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/445b8b5ae9f4

8006879: Detection of windows in sjavac fails.
Reviewed-by: jjg
Contributed-by: erik.joelsson at oracle.com

! src/share/classes/com/sun/tools/sjavac/server/CompilerThread.java

Changeset: 997c0fae2b12
Author:    lana
Date:      2013-05-17 10:13 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/997c0fae2b12

Merge

- src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java
- src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java
- src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletOutput.java
- src/share/classes/javax/tools/annotation/GenerateNativeHeader.java
- test/tools/javac/nativeHeaders/javahComparison/TestClass2.java
- test/tools/javac/nativeHeaders/javahComparison/TestClass3.java

Changeset: 4830d661c4f9
Author:    katleman
Date:      2013-05-23 10:47 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/4830d661c4f9

Added tag jdk8-b91 for changeset 997c0fae2b12

! .hgtags


From jesper.wilhelmsson at oracle.com  Fri May 24 02:26:03 2013
From: jesper.wilhelmsson at oracle.com (jesper.wilhelmsson at oracle.com)
Date: Fri, 24 May 2013 09:26:03 +0000
Subject: hg: hsx/hotspot-main/hotspot: 9 new changesets
Message-ID: <20130524092624.43CD148D06@hg.openjdk.java.net>

Changeset: 001ec9515f84
Author:    ehelin
Date:      2013-05-17 11:57 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/001ec9515f84

8014277: Remove ObjectClosure as base class for BoolObjectClosure
Reviewed-by: brutisso, tschatzl

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp
! src/share/vm/gc_implementation/g1/concurrentMark.hpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp
! src/share/vm/gc_implementation/shared/markSweep.cpp
! src/share/vm/gc_implementation/shared/markSweep.hpp
! src/share/vm/memory/defNewGeneration.cpp
! src/share/vm/memory/defNewGeneration.hpp
! src/share/vm/memory/iterator.hpp
! src/share/vm/memory/referenceProcessor.cpp
! src/share/vm/memory/sharedHeap.cpp
! src/share/vm/runtime/jniHandles.cpp

Changeset: 2138a2c14831
Author:    jwilhelm
Date:      2013-05-19 20:31 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/2138a2c14831

Merge

! src/share/vm/gc_implementation/shared/markSweep.cpp

Changeset: 10f759898d40
Author:    tamao
Date:      2013-05-20 10:44 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/10f759898d40

7186737: Unable to allocate bit maps or card tables for parallel gc for the requested heap
Summary: Print helpful error message when VM aborts due to inability of allocating bit maps or card tables
Reviewed-by: jmasa, stefank
Contributed-by: tamao <tao.mao at oracle.com>

! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp
! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp

Changeset: 2b1a9d972fc2
Author:    jmasa
Date:      2013-05-20 22:34 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/2b1a9d972fc2

8014862: Add fast Metasapce capacity and used per MetadataType
Reviewed-by: ehelin, stefank

! src/share/vm/memory/metaspace.cpp
! src/share/vm/memory/metaspace.hpp

Changeset: 28e53b8db94f
Author:    brutisso
Date:      2013-05-21 08:50 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/28e53b8db94f

7066063: CMS: "Conservation Principle" assert failed
Summary: Add call to coalBirth() in CompactibleFreeListSpace::reset()
Reviewed-by: ysr, jmasa

! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp

Changeset: 5ed122fbd0ef
Author:    brutisso
Date:      2013-05-21 10:39 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/5ed122fbd0ef

Merge


Changeset: 6702da6b6082
Author:    tschatzl
Date:      2013-05-21 11:30 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/6702da6b6082

8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes
Summary: Instead of using a simple sizeof(), ask the PerRegionTable class about its size when iterating over the free list.
Reviewed-by: jwilhelm, brutisso

! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp
! src/share/vm/prims/jni.cpp

Changeset: 7c5a1b62f53d
Author:    brutisso
Date:      2013-05-22 08:04 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/7c5a1b62f53d

8014971: Minor code cleanup of the freelist management
Reviewed-by: jwilhelm, jmasa, tschatzl

! src/share/vm/gc_implementation/concurrentMarkSweep/adaptiveFreeList.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/adaptiveFreeList.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/memory/freeList.cpp
! src/share/vm/memory/freeList.hpp

Changeset: 62890ed7e2a8
Author:    jwilhelm
Date:      2013-05-24 09:29 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/62890ed7e2a8

Merge

- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java
- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java
- test/runtime/7158804/Test7158804.sh
- test/runtime/8003985/Test8003985.java


From serguei.spitsyn at oracle.com  Fri May 24 02:29:27 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Fri, 24 May 2013 02:29:27 -0700
Subject: Review Request (S) 8013945: CMS fatal error: must own lock
	MemberNameTable_lock
Message-ID: <519F32F7.6070900@oracle.com>

Please, review the fix for:
   bug: http://bugs.sun.com/view_bug.do?bug_id=8013945
   jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945

Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/

Summary:
   CMS calls InstanceKlass::release_C_heap_structures() concurrently.
   The "delete mnt" needs to take MemberNameTable_lock if 
!SafepointSynchronize::is_at_safepoint().

Testing:
   The vm/mlvm and Nashorn tests, the tests listed in the bug report

Thanks,
Serguei

From staffan.larsen at oracle.com  Fri May 24 03:22:46 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Fri, 24 May 2013 12:22:46 +0200
Subject: Review Request (S) 8013945: CMS fatal error: must own lock
	MemberNameTable_lock
In-Reply-To: <519F32F7.6070900@oracle.com>
References: <519F32F7.6070900@oracle.com>
Message-ID: <4A2AC0E6-20B3-4405-915E-2A3BFD04FCEA@oracle.com>

Looks good!

/Staffan

On 24 maj 2013, at 11:29, serguei.spitsyn at oracle.com wrote:

> Please, review the fix for:
>  bug: http://bugs.sun.com/view_bug.do?bug_id=8013945
>  jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945
> 
> Open webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/
> 
> Summary:
>  CMS calls InstanceKlass::release_C_heap_structures() concurrently.
>  The "delete mnt" needs to take MemberNameTable_lock if !SafepointSynchronize::is_at_safepoint().
> 
> Testing:
>  The vm/mlvm and Nashorn tests, the tests listed in the bug report
> 
> Thanks,
> Serguei


From serguei.spitsyn at oracle.com  Fri May 24 03:29:46 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Fri, 24 May 2013 03:29:46 -0700
Subject: Review Request (S) 8013945: CMS fatal error: must own lock
	MemberNameTable_lock
In-Reply-To: <4A2AC0E6-20B3-4405-915E-2A3BFD04FCEA@oracle.com>
References: <519F32F7.6070900@oracle.com>
	<4A2AC0E6-20B3-4405-915E-2A3BFD04FCEA@oracle.com>
Message-ID: <519F411A.5050408@oracle.com>

Thanks, Staffan!
Serguei

On 5/24/13 3:22 AM, Staffan Larsen wrote:
> Looks good!
>
> /Staffan
>
> On 24 maj 2013, at 11:29, serguei.spitsyn at oracle.com wrote:
>
>> Please, review the fix for:
>>   bug: http://bugs.sun.com/view_bug.do?bug_id=8013945
>>   jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945
>>
>> Open webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/
>>
>> Summary:
>>   CMS calls InstanceKlass::release_C_heap_structures() concurrently.
>>   The "delete mnt" needs to take MemberNameTable_lock if !SafepointSynchronize::is_at_safepoint().
>>
>> Testing:
>>   The vm/mlvm and Nashorn tests, the tests listed in the bug report
>>
>> Thanks,
>> Serguei


From mikael.gerdin at oracle.com  Fri May 24 03:29:59 2013
From: mikael.gerdin at oracle.com (Mikael Gerdin)
Date: Fri, 24 May 2013 12:29:59 +0200
Subject: Review Request (S) 8013945: CMS fatal error: must own lock
	MemberNameTable_lock
In-Reply-To: <519F32F7.6070900@oracle.com>
References: <519F32F7.6070900@oracle.com>
Message-ID: <519F4127.3040804@oracle.com>

Serguei,

On 2013-05-24 11:29, serguei.spitsyn at oracle.com wrote:
> Please, review the fix for:
>    bug: http://bugs.sun.com/view_bug.do?bug_id=8013945
>    jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945
>
> Open webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/

I agree with the semantic change but I'm not that fond of the duplication.
Instead of duplicating the code you could have a:

MutexLockerEx ml( ( SafepointSynchronize::is_at_safepoint() ? NULL : 
MemberNameTable_lock ), Mutex::_no_safepoint_check_flag );

Or maybe

Mutex* mutex_or_null = SafepointSynchronize::is_at_safepoint() ? NULL : 
MemberNameTable_lock;
MutexLockerEx ml(mutex_or_null, Mutex::_no_safepoint_check_flag);

MutexLockerEx already has a null-check in both constructor and destructor.

/Mikael

>
>
> Summary:
>    CMS calls InstanceKlass::release_C_heap_structures() concurrently.
>    The "delete mnt" needs to take MemberNameTable_lock if
> !SafepointSynchronize::is_at_safepoint().
>
> Testing:
>    The vm/mlvm and Nashorn tests, the tests listed in the bug report
>
> Thanks,
> Serguei

From serguei.spitsyn at oracle.com  Fri May 24 03:53:29 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Fri, 24 May 2013 03:53:29 -0700
Subject: Review Request (S) 8013945: CMS fatal error: must own lock
	MemberNameTable_lock
In-Reply-To: <519F4127.3040804@oracle.com>
References: <519F32F7.6070900@oracle.com> <519F4127.3040804@oracle.com>
Message-ID: <519F46A9.4000204@oracle.com>

Mikael,

I like your suggestion, will send new webrev tomorrow.

Thank you for the review!
Serguei

On 5/24/13 3:29 AM, Mikael Gerdin wrote:
> Serguei,
>
> On 2013-05-24 11:29, serguei.spitsyn at oracle.com wrote:
>> Please, review the fix for:
>>    bug: http://bugs.sun.com/view_bug.do?bug_id=8013945
>>    jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945
>>
>> Open webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/ 
>>
>
> I agree with the semantic change but I'm not that fond of the 
> duplication.
> Instead of duplicating the code you could have a:
>
> MutexLockerEx ml( ( SafepointSynchronize::is_at_safepoint() ? NULL : 
> MemberNameTable_lock ), Mutex::_no_safepoint_check_flag );
>
> Or maybe
>
> Mutex* mutex_or_null = SafepointSynchronize::is_at_safepoint() ? NULL 
> : MemberNameTable_lock;
> MutexLockerEx ml(mutex_or_null, Mutex::_no_safepoint_check_flag);
>
> MutexLockerEx already has a null-check in both constructor and 
> destructor.
>
> /Mikael
>
>>
>>
>> Summary:
>>    CMS calls InstanceKlass::release_C_heap_structures() concurrently.
>>    The "delete mnt" needs to take MemberNameTable_lock if
>> !SafepointSynchronize::is_at_safepoint().
>>
>> Testing:
>>    The vm/mlvm and Nashorn tests, the tests listed in the bug report
>>
>> Thanks,
>> Serguei


From david.holmes at oracle.com  Fri May 24 03:54:11 2013
From: david.holmes at oracle.com (David Holmes)
Date: Fri, 24 May 2013 20:54:11 +1000
Subject: Review Request (S) 8013945: CMS fatal error: must own lock
	MemberNameTable_lock
In-Reply-To: <519F32F7.6070900@oracle.com>
References: <519F32F7.6070900@oracle.com>
Message-ID: <519F46D3.7030304@oracle.com>

Hi Serguei,

You can avoid the code duplication if you use the safepoint check to 
assign either the MemberNameTable_lock or NULL to a Mutex variable:

Mutex* lock = (atsafepoint ? NULL : MemberNameTable_lock);
{
    MutexLockerEx ml(lock, ...);
    ...
}

David

On 24/05/2013 7:29 PM, serguei.spitsyn at oracle.com wrote:
> Please, review the fix for:
>    bug: http://bugs.sun.com/view_bug.do?bug_id=8013945
>    jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945
>
> Open webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/
>
>
> Summary:
>    CMS calls InstanceKlass::release_C_heap_structures() concurrently.
>    The "delete mnt" needs to take MemberNameTable_lock if
> !SafepointSynchronize::is_at_safepoint().
>
> Testing:
>    The vm/mlvm and Nashorn tests, the tests listed in the bug report
>
> Thanks,
> Serguei

From david.holmes at oracle.com  Fri May 24 03:56:08 2013
From: david.holmes at oracle.com (David Holmes)
Date: Fri, 24 May 2013 20:56:08 +1000
Subject: Review Request (S) 8013945: CMS fatal error: must own lock
	MemberNameTable_lock
In-Reply-To: <519F46D3.7030304@oracle.com>
References: <519F32F7.6070900@oracle.com> <519F46D3.7030304@oracle.com>
Message-ID: <519F4748.4070701@oracle.com>

Sorry just saw Mikael already suggested this. :)

David

On 24/05/2013 8:54 PM, David Holmes wrote:
> Hi Serguei,
>
> You can avoid the code duplication if you use the safepoint check to
> assign either the MemberNameTable_lock or NULL to a Mutex variable:
>
> Mutex* lock = (atsafepoint ? NULL : MemberNameTable_lock);
> {
>     MutexLockerEx ml(lock, ...);
>     ...
> }
>
> David
>
> On 24/05/2013 7:29 PM, serguei.spitsyn at oracle.com wrote:
>> Please, review the fix for:
>>    bug: http://bugs.sun.com/view_bug.do?bug_id=8013945
>>    jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945
>>
>> Open webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/
>>
>>
>>
>> Summary:
>>    CMS calls InstanceKlass::release_C_heap_structures() concurrently.
>>    The "delete mnt" needs to take MemberNameTable_lock if
>> !SafepointSynchronize::is_at_safepoint().
>>
>> Testing:
>>    The vm/mlvm and Nashorn tests, the tests listed in the bug report
>>
>> Thanks,
>> Serguei

From erik.joelsson at oracle.com  Fri May 24 06:22:02 2013
From: erik.joelsson at oracle.com (Erik Joelsson)
Date: Fri, 24 May 2013 15:22:02 +0200
Subject: RFR: 8014074: Building hotspot with ccache in new build is very slow
	with empty cache.
Message-ID: <519F697A.4070106@oracle.com>

This patch to configure disables precompiled headers in hotspot when 
ccache is in use.

Background is in this mail (and the bug report):
http://mail.openjdk.java.net/pipermail/build-dev/2013-April/008772.html

In short, build time is shortened considerably both with an empty and a 
perfect cache when ccache is in use.

Note that this only affects full builds from the root repo and not 
hotspot only builds.

http://cr.openjdk.java.net/~erikj/8014074/webrev.root.01/

/Erik

From jon.masamitsu at oracle.com  Fri May 24 07:37:59 2013
From: jon.masamitsu at oracle.com (Jon Masamitsu)
Date: Fri, 24 May 2013 07:37:59 -0700
Subject: Review Request (S) 8013945: CMS fatal error: must own lock
	MemberNameTable_lock
In-Reply-To: <519F32F7.6070900@oracle.com>
References: <519F32F7.6070900@oracle.com>
Message-ID: <519F7B47.10609@oracle.com>

Serguei,

I think the change is correct but would it be a problem
to just take the MemberNameTable_lock whether
at a safepoint or not?

Jon

On 5/24/2013 2:29 AM, serguei.spitsyn at oracle.com wrote:
> Please, review the fix for:
>   bug: http://bugs.sun.com/view_bug.do?bug_id=8013945
>   jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945
>
> Open webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/ 
>
>
> Summary:
>   CMS calls InstanceKlass::release_C_heap_structures() concurrently.
>   The "delete mnt" needs to take MemberNameTable_lock if 
> !SafepointSynchronize::is_at_safepoint().
>
> Testing:
>   The vm/mlvm and Nashorn tests, the tests listed in the bug report
>
> Thanks,
> Serguei


From karen.kinnear at oracle.com  Fri May 24 09:57:12 2013
From: karen.kinnear at oracle.com (Karen Kinnear)
Date: Fri, 24 May 2013 12:57:12 -0400
Subject: CFV: New HSX Committer: Aleksey Shipilev
In-Reply-To: <519AB210.1070901@oracle.com>
References: <5111D374.2090101@oracle.com> <519AB210.1070901@oracle.com>
Message-ID: <B23064AE-36CB-416F-9789-AD8B839535E3@oracle.com>

vote: veto

Justifications:
1. A significant number of the changesets were bugtails or cleanups from code reviews
2. Not yet taking responsibility for quality of the testing and of the product

A note - according to the bylaws you can vote multiple times, and your last
vote is the one that is counted

thanks,
Karen

On May 20, 2013, at 7:30 PM, Vladimir Kozlov wrote:

> I hereby nominate Aleksey Shipilev (OpenJDK user name: shade) to
> HSX Committer.
> 
> Aleksey is a member of the Hotspot Performance group. He is working on java concurrency related projects. He contributed 11 changesets to HSX project and he is qualified to be committer [1]:
> 
> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=shipilev
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/571076d3c79d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/205dd30230e1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/50e9396d5257
> 
> Votes are due by June 3, 2013.
> 
> Only current HSX Committers [2] are eligible to vote on this nomination.
> Votes must be cast in the open by replying to this mailing list.
> 
> For Lazy Consensus voting instructions, see [3].
> 
> Thanks,
> Vladimir Kozlov
> 
> [1] http://openjdk.java.net/projects/#project-committer
> [2] http://openjdk.java.net/census#hsx
> [3] http://openjdk.java.net/projects#committer-vote
> 
> 
> 
> 
> 
> 


From serguei.spitsyn at oracle.com  Fri May 24 10:05:15 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Fri, 24 May 2013 10:05:15 -0700
Subject: Review Request (S) 8013945: CMS fatal error: must own lock
	MemberNameTable_lock
In-Reply-To: <519F4748.4070701@oracle.com>
References: <519F32F7.6070900@oracle.com> <519F46D3.7030304@oracle.com>
	<519F4748.4070701@oracle.com>
Message-ID: <519F9DCB.7010907@oracle.com>

Ok, thank you for the review!
Serguei

On 5/24/13 3:56 AM, David Holmes wrote:
> Sorry just saw Mikael already suggested this. :)
>
> David
>
> On 24/05/2013 8:54 PM, David Holmes wrote:
>> Hi Serguei,
>>
>> You can avoid the code duplication if you use the safepoint check to
>> assign either the MemberNameTable_lock or NULL to a Mutex variable:
>>
>> Mutex* lock = (atsafepoint ? NULL : MemberNameTable_lock);
>> {
>>     MutexLockerEx ml(lock, ...);
>>     ...
>> }
>>
>> David
>>
>> On 24/05/2013 7:29 PM, serguei.spitsyn at oracle.com wrote:
>>> Please, review the fix for:
>>>    bug: http://bugs.sun.com/view_bug.do?bug_id=8013945
>>>    jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945
>>>
>>> Open webrev:
>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/ 
>>>
>>>
>>>
>>>
>>> Summary:
>>>    CMS calls InstanceKlass::release_C_heap_structures() concurrently.
>>>    The "delete mnt" needs to take MemberNameTable_lock if
>>> !SafepointSynchronize::is_at_safepoint().
>>>
>>> Testing:
>>>    The vm/mlvm and Nashorn tests, the tests listed in the bug report
>>>
>>> Thanks,
>>> Serguei


From serguei.spitsyn at oracle.com  Fri May 24 10:08:47 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Fri, 24 May 2013 10:08:47 -0700
Subject: Review Request (S) 8013945: CMS fatal error: must own lock
	MemberNameTable_lock
In-Reply-To: <519F7B47.10609@oracle.com>
References: <519F32F7.6070900@oracle.com> <519F7B47.10609@oracle.com>
Message-ID: <519F9E9F.3070103@oracle.com>

John,

Thank you for the review.
I'm taking a suggestion from Mikael G.

Thanks,
Serguei

On 5/24/13 7:37 AM, Jon Masamitsu wrote:
> Serguei,
>
> I think the change is correct but would it be a problem
> to just take the MemberNameTable_lock whether
> at a safepoint or not?
>
> Jon
>
> On 5/24/2013 2:29 AM, serguei.spitsyn at oracle.com wrote:
>> Please, review the fix for:
>>   bug: http://bugs.sun.com/view_bug.do?bug_id=8013945
>>   jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945
>>
>> Open webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/ 
>>
>>
>> Summary:
>>   CMS calls InstanceKlass::release_C_heap_structures() concurrently.
>>   The "delete mnt" needs to take MemberNameTable_lock if 
>> !SafepointSynchronize::is_at_safepoint().
>>
>> Testing:
>>   The vm/mlvm and Nashorn tests, the tests listed in the bug report
>>
>> Thanks,
>> Serguei
>


From serguei.spitsyn at oracle.com  Fri May 24 10:39:42 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Fri, 24 May 2013 10:39:42 -0700
Subject: Review Request (S) 8013945: CMS fatal error: must own lock
	MemberNameTable_lock
In-Reply-To: <519F32F7.6070900@oracle.com>
References: <519F32F7.6070900@oracle.com>
Message-ID: <519FA5DE.6060303@oracle.com>

Webrev with the fix suggested by Mikael G. :
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.2/ 


I'm going to integrate it after testing, but a couple of extra eyes to 
double-check it would be nice.

Thanks,
Serguei


On 5/24/13 2:29 AM, serguei.spitsyn at oracle.com wrote:
> Please, review the fix for:
>   bug: http://bugs.sun.com/view_bug.do?bug_id=8013945
>   jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945
>
> Open webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/ 
>
>
> Summary:
>   CMS calls InstanceKlass::release_C_heap_structures() concurrently.
>   The "delete mnt" needs to take MemberNameTable_lock if 
> !SafepointSynchronize::is_at_safepoint().
>
> Testing:
>   The vm/mlvm and Nashorn tests, the tests listed in the bug report
>
> Thanks,
> Serguei


From coleen.phillimore at oracle.com  Fri May 24 10:43:37 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Fri, 24 May 2013 13:43:37 -0400
Subject: RFR (S) JDK-8014912 Restore PrintSharedSpaces after NPG
In-Reply-To: <519E48FA.4000209@oracle.com>
References: <519BF549.3070808@oracle.com> <519D753E.8040009@oracle.com>
	<519E48FA.4000209@oracle.com>
Message-ID: <519FA6C9.5040305@oracle.com>


I think you can inherit from HistogramElement and add fields but I'm not 
going to make further suggestions at this time, I just wanted you to 
consider reusing this code.   Your code is good.

Coleen


On 5/23/2013 12:51 PM, Ioi Lam wrote:
> Coleen,
>
> I looked at histogram.hpp, but it has only one _count field:
>
>    class HistogramElement : public CHeapObj<mtInternal> {
>      protected:
>       jint _count;
>       const char* _name;
>
>      public:
>       HistogramElement();
>       virtual int count();
>       virtual const char* name();
>       virtual void increment_count();
>       void print_on(outputStream* st) const;
>       virtual int compare(HistogramElement* e1,HistogramElement* e2);
>    };
>
> For my purpose, I would need a count and size for each subtype of 
> metadata, so it doesn't look like this class is immediately usable for 
> me.
>
> I am actually planning (with a different bug ID) to dump a detailed 
> "map file" of every object in CDS. Now that I record all the 
> allocations under Metaspace::_alloc_record_head, I can iterate over 
> them and call, for example, Method::print_codes_on() on all the 
> methods. This will allow you to do all kinds of analysis, like
>
>     How many unquickened getfield bytecodes are inside CDS
>     How many methods contain unquickened bytecodes
>
> ... etc. When we were doing Monty's romizer, a mapfile like this was 
> very helpful in identifying possible areas for improvements.
>
> While I do that, I can also dump a table of the size distribution of 
> each type objects in a histogram format, similar to 
> PrintSymbolTableSizeHistogram.
>
> Thanks
> - Ioi
>
>
> On 05/22/2013 06:47 PM, Coleen Phillimore wrote:
>>
>> Ioi,
>>
>> This looks really good.  The only thing is that we have code to 
>> create histograms in the VM (see utilities/histogram.hpp). Couldn't 
>> you reuse this class instead of writing your own histogram creating 
>> function?   It would sort your data for you! I don't know if it would 
>> have the data you are looking for but lots of other jvm code uses 
>> this class for a similar purpose.
>>
>> Thanks,
>> Coleen
>>
>> On 5/21/2013 6:29 PM, Ioi Lam wrote:
>>> Please review:
>>>
>>> http://cr.openjdk.java.net/~iklam/8014912/print_sharedspc_001/
>>>
>>> Bug: Restore PrintSharedSpaces functionality after NPG
>>>
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014912
>>>     https://jbs.oracle.com/bugs/browse/JDK-8014912
>>>
>>> Summary of fix:
>>>
>>> I added a new enum, MetaspaceObj::Type, which is passed to
>>>
>>>     Metaspace::allocate(ClassLoaderData* loader_data, size_t word_size,
>>>                         bool read_only, MetaspaceObj::Type type, 
>>> TRAPS);
>>>
>>> During CDS dumping, all allocations are logged in a linked list to
>>> be processed later by metaspaceShared.cpp to generate statistics for
>>> objects in the CDS archive. See sample output below.
>>>
>>> * No such logging is doneat normal VM execution time so there
>>>   is no performance impact.
>>>
>>> * I verified that the patch can be applied cleanly on Jon's
>>>   recentpatch for JDK-8014862 "Add fast Metasapce capacity and
>>>   used per MetadataType"
>>>
>>> http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/2b1a9d972fc2
>>>
>>> Testing:
>>>
>>>     JPRT, UTE (vm.quick.testlist)
>>>
>>> Sample output:
>>>
>>>                         ro_cnt   ro_bytes     % | rw_cnt 
>>> rw_bytes     % |  all_cnt  all_bytes     %
>>> --------------------+---------------------------+---------------------------+-------------------------- 
>>>
>>> Unknown             :        1         64   0.0 | 1         64 0.0 
>>> |        2        128   0.0
>>> Class               :        0          0   0.0 | 2364 2006080 14.7 
>>> |     2364    2006080   9.2
>>> Symbol              :    49858    2507168  30.9 | 0          0 0.0 
>>> |    49858    2507168  11.5
>>> TypeArrayU1         :    13264     608336   7.5 | 2365 428784 3.1 
>>> |    15629    1037120   4.8
>>> TypeArrayU2         :     4796     341952   4.2 | 0          0 0.0 
>>> |     4796     341952   1.6
>>> TypeArrayU4         :     2371     178528   2.2 | 0          0 0.0 
>>> |     2371     178528   0.8
>>> TypeArrayU8         :     3708     365920   4.5 | 0          0 0.0 
>>> |     3708     365920   1.7
>>> TypeArrayOther      :        0          0   0.0 | 0          0 0.0 
>>> |        0          0   0.0
>>> Method              :        0          0   0.0 | 32552 3659888 26.8 
>>> |    32552    3659888  16.8
>>> ConstMethod         :    32552    4099008  50.6 | 0          0 0.0 
>>> |    32552    4099008  18.8
>>> MethodData          :        0          0   0.0 | 0          0 0.0 
>>> |        0          0   0.0
>>> ConstantPool        :        0          0   0.0 | 2365 3225600 23.6 
>>> |     2365    3225600  14.8
>>> ConstantPoolCache   :        0          0   0.0 | 2350 2212320 16.2 
>>> |     2350    2212320  10.2
>>> Annotation          :       26       1248   0.0 | 0          0 0.0 
>>> |       26       1248   0.0
>>> MethodCounters      :        0          0   0.0 | 0          0 0.0 
>>> |        0          0   0.0
>>> SymbolHashentry     :        0          0   0.0 | 49858 1595456 11.7 
>>> |    49858    1595456   7.3
>>> SymbolBuckets       :        0          0   0.0 | 20011 320176 2.3 
>>> |    20011     320176   1.5
>>> Other               :        0          0   0.0 | 0     203893 1.5 
>>> |        0     203893   0.9
>>> --------------------+---------------------------+---------------------------+-------------------------- 
>>>
>>> Total               :   106576    8102224 100.0 | 111866 13652261 
>>> 100.0 |   218442   21754485 100.0
>>>
>>>
>>> Thanks,
>>> Ioi
>>>
>>>
>>
>


From alejandro.murillo at oracle.com  Fri May 24 12:56:59 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 24 May 2013 19:56:59 +0000
Subject: hg: hsx/hsx25/hotspot: 41 new changesets
Message-ID: <20130524195824.BCD8948D25@hg.openjdk.java.net>

Changeset: ad47de214f0c
Author:    katleman
Date:      2013-05-23 10:47 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/ad47de214f0c

Added tag jdk8-b91 for changeset 7cbdf0e3725c

! .hgtags

Changeset: 7ec426e29e4c
Author:    amurillo
Date:      2013-05-17 09:10 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/7ec426e29e4c

8014760: new hotspot build - hs25-b34
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: f49e0508a38a
Author:    rbackman
Date:      2013-05-15 11:30 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/f49e0508a38a

4965252: JvmtiExport::post_raw_field_modification jni ref handling is odd
Reviewed-by: coleenp, sspitsyn

! src/share/vm/prims/jvmtiExport.cpp

Changeset: 243469d929e6
Author:    ctornqvi
Date:      2013-05-16 15:31 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/243469d929e6

8008169: test/runtime/7158804/Test7158804.sh has bad copyright header
Summary: Re-wrote test in Java in addition to fixing the Copyright notice. Also reviewed by leonid.mesnik at oracle.com
Reviewed-by: coleenp, ctornqvi
Contributed-by: Mikhailo Seledtsov <mikhailo.seledtsov at oracle.com>

- test/runtime/7158804/Test7158804.sh
+ test/runtime/CommandLine/ConfigFileParsing.java

Changeset: 17db82f22f1e
Author:    ctornqvi
Date:      2013-05-16 17:54 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/17db82f22f1e

8014511: runtime/RedefineObject/TestRedefineObject.java has incorrect classname in @run tag
Summary: Corrected the class name
Reviewed-by: coleenp, ctornqvi, hseigel
Contributed-by: Mikhailo Seledtsov <mikhailo.seledtsov at oracle.com>

! test/runtime/RedefineObject/TestRedefineObject.java

Changeset: 78332b46e604
Author:    kevinw
Date:      2013-05-16 12:40 +0100
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/78332b46e604

6313816: SA: jstack -m fails on Win32 : UnalignedAddressException
Reviewed-by: sla, poonam

- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java
- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java
! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgCDebugger.java
+ agent/src/share/classes/sun/jvm/hotspot/debugger/windows/amd64/WindowsAMD64CFrame.java
+ agent/src/share/classes/sun/jvm/hotspot/debugger/windows/x86/WindowsX86CFrame.java
! make/sa.files

Changeset: 205dd30230e1
Author:    shade
Date:      2013-05-17 01:43 +0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/205dd30230e1

8012939: @Contended doesn't work correctly with inheritance
Summary: Fix instance_size miscalculation.
Reviewed-by: jrose, kvn

! src/share/vm/classfile/classFileParser.cpp
+ test/runtime/contended/Inheritance1.java

Changeset: b334821dad92
Author:    dholmes
Date:      2013-05-16 21:19 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b334821dad92

Merge


Changeset: 50e9396d5257
Author:    shade
Date:      2013-05-17 01:58 +0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/50e9396d5257

8014509: @Contended: explicit default value behaves differently from the implicit value
Summary: Treat the empty string as the default value tag
Reviewed-by: kvn, twisti

! src/share/vm/classfile/classFileParser.cpp
+ test/runtime/contended/DefaultValue.java

Changeset: 074ba6269cf4
Author:    dholmes
Date:      2013-05-16 22:11 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/074ba6269cf4

Merge

- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java
- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java

Changeset: 1ba508fcd3e2
Author:    dholmes
Date:      2013-05-16 23:40 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/1ba508fcd3e2

Merge


Changeset: 6ce351ac7339
Author:    rdurbin
Date:      2013-05-17 08:51 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/6ce351ac7339

7145527: sscanf must use a length in the format string
Summary: Remove dead code containing last call to scanf with no string length specifier
Reviewed-by: dcubed, coleenp

! src/share/vm/utilities/debug.cpp

Changeset: a250c89cf9e3
Author:    dcubed
Date:      2013-05-17 08:56 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/a250c89cf9e3

Merge


Changeset: b5be63340698
Author:    dcubed
Date:      2013-05-17 11:36 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b5be63340698

Merge

- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java
- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java
! src/share/vm/classfile/classFileParser.cpp
- test/runtime/7158804/Test7158804.sh

Changeset: 386b77bf6427
Author:    dcubed
Date:      2013-05-17 17:52 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/386b77bf6427

Merge

- make/bsd/makefiles/launcher.make
- make/linux/makefiles/launcher.make
- make/solaris/makefiles/launcher.make
- make/windows/makefiles/launcher.make
- src/os/posix/launcher/java_md.c
- src/os/posix/launcher/java_md.h
- src/os/posix/launcher/launcher.script
- src/os/windows/launcher/java_md.c
- src/os/windows/launcher/java_md.h
- src/share/tools/launcher/java.c
- src/share/tools/launcher/java.h
- src/share/tools/launcher/jli_util.c
- src/share/tools/launcher/jli_util.h
- src/share/tools/launcher/wildcard.c
- src/share/tools/launcher/wildcard.h
- src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp

Changeset: a5d6f0c3585f
Author:    iklam
Date:      2013-05-18 20:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/a5d6f0c3585f

8014262: PrintStringTableStatistics should include more footprint info
Summary: Added info for the string/symbol objects and the hash entries
Reviewed-by: coleenp, rbackman

! src/share/vm/classfile/symbolTable.cpp
! src/share/vm/utilities/hashtable.cpp
! src/share/vm/utilities/hashtable.hpp

Changeset: 5e3573e08a83
Author:    shade
Date:      2013-05-20 15:43 +0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/5e3573e08a83

8014871: Move @Contended regression tests to the same place
Summary: Move the missing test to appropriate location.
Reviewed-by: dholmes, sla

- test/runtime/8003985/Test8003985.java
+ test/runtime/contended/Basic.java

Changeset: bbddfb08190f
Author:    shade
Date:      2013-05-20 23:41 +0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/bbddfb08190f

8014878: Clean up class field layout code
Summary: rename/remove local variables, re-arrange instance_size calculation, more comments.
Reviewed-by: kvn, coleenp

! src/share/vm/classfile/classFileParser.cpp

Changeset: 293b99787401
Author:    dholmes
Date:      2013-05-14 07:24 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/293b99787401

8014460: Need to check for non-empty EXT_LIBS_PATH before using it
Reviewed-by: tbell, collins, sla, coleenp

! make/bsd/makefiles/arm.make
! make/linux/makefiles/arm.make

Changeset: 26579ac80ce9
Author:    bpittore
Date:      2013-05-15 23:06 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/26579ac80ce9

8014669: arch specific flags not passed to some link commands
Summary: EXTRA_CFLAGS does not propagate to saproc and jsig makefiles
Reviewed-by: dholmes, tbell, collins

! make/linux/makefiles/jsig.make
! make/linux/makefiles/saproc.make

Changeset: f8c833eb2a5f
Author:    jiangli
Date:      2013-05-20 13:13 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/f8c833eb2a5f

Merge


Changeset: c838b672691c
Author:    jiangli
Date:      2013-05-23 13:40 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/c838b672691c

Merge


Changeset: 91eba9f82325
Author:    anoll
Date:      2013-05-16 15:46 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/91eba9f82325

8012371: Adjust Tiered compile threshold according to available space in code cache
Summary: Added command line parameter to define a threshold at which C1 compilation threshold for  is increased.
Reviewed-by: kvn, iveresov

! src/share/vm/code/codeCache.cpp
! src/share/vm/code/codeCache.hpp
! src/share/vm/runtime/advancedThresholdPolicy.cpp
! src/share/vm/runtime/advancedThresholdPolicy.hpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp

Changeset: ec922e5c545a
Author:    anoll
Date:      2013-05-22 10:28 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/ec922e5c545a

8012312: hsdis fails to compile with binutils-2.23.2
Summary: added <config.h> to header file to make hsdis compile with binutils 2.23.*
Reviewed-by: kvn, twisti

! src/share/tools/hsdis/hsdis.c

Changeset: b4907b24ed48
Author:    twisti
Date:      2013-05-22 11:44 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b4907b24ed48

Merge


Changeset: 1682bec79205
Author:    kvn
Date:      2013-05-22 09:02 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/1682bec79205

8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
Summary: Stop current iteration of loop opts if partial_peel() failed and it created node clones outside processed loop.
Reviewed-by: roland

! src/share/vm/opto/loopnode.hpp
! src/share/vm/opto/loopopts.cpp

Changeset: 71a2d06b9c2b
Author:    kvn
Date:      2013-05-22 17:39 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/71a2d06b9c2b

Merge


Changeset: 3f281b313240
Author:    kvn
Date:      2013-05-22 18:25 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/3f281b313240

8010927: Kitchensink crashed with SIGSEGV, Problematic frame: v ~StubRoutines::checkcast_arraycopy
Summary: Changed gen_write_ref_array_post_barrier() code on x64 to pass start address and number of copied oop elements. In generate_checkcast_copy() skip post barrier code if no elements are copied.
Reviewed-by: roland

! src/cpu/x86/vm/stubGenerator_x86_32.cpp
! src/cpu/x86/vm/stubGenerator_x86_64.cpp
+ test/compiler/8010927/Test8010927.java

Changeset: 01e51113b4f5
Author:    anoll
Date:      2013-05-23 14:11 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/01e51113b4f5

8014430: JRE crashes instead of stop compilation on full Code Cache. Internal Error (c1_Compiler.cpp:87)
Summary: Disable client compiler and switch to interpreter if there is not enough free space in the code cache.
Reviewed-by: kvn, twisti

! src/share/vm/c1/c1_Compiler.cpp
! src/share/vm/c1/c1_Compiler.hpp

Changeset: 59e18b573605
Author:    twisti
Date:      2013-05-23 15:30 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/59e18b573605

Merge


Changeset: 001ec9515f84
Author:    ehelin
Date:      2013-05-17 11:57 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/001ec9515f84

8014277: Remove ObjectClosure as base class for BoolObjectClosure
Reviewed-by: brutisso, tschatzl

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp
! src/share/vm/gc_implementation/g1/concurrentMark.hpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp
! src/share/vm/gc_implementation/shared/markSweep.cpp
! src/share/vm/gc_implementation/shared/markSweep.hpp
! src/share/vm/memory/defNewGeneration.cpp
! src/share/vm/memory/defNewGeneration.hpp
! src/share/vm/memory/iterator.hpp
! src/share/vm/memory/referenceProcessor.cpp
! src/share/vm/memory/sharedHeap.cpp
! src/share/vm/runtime/jniHandles.cpp

Changeset: 2138a2c14831
Author:    jwilhelm
Date:      2013-05-19 20:31 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/2138a2c14831

Merge

! src/share/vm/gc_implementation/shared/markSweep.cpp

Changeset: 10f759898d40
Author:    tamao
Date:      2013-05-20 10:44 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/10f759898d40

7186737: Unable to allocate bit maps or card tables for parallel gc for the requested heap
Summary: Print helpful error message when VM aborts due to inability of allocating bit maps or card tables
Reviewed-by: jmasa, stefank
Contributed-by: tamao <tao.mao at oracle.com>

! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp
! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp

Changeset: 2b1a9d972fc2
Author:    jmasa
Date:      2013-05-20 22:34 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/2b1a9d972fc2

8014862: Add fast Metasapce capacity and used per MetadataType
Reviewed-by: ehelin, stefank

! src/share/vm/memory/metaspace.cpp
! src/share/vm/memory/metaspace.hpp

Changeset: 28e53b8db94f
Author:    brutisso
Date:      2013-05-21 08:50 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/28e53b8db94f

7066063: CMS: "Conservation Principle" assert failed
Summary: Add call to coalBirth() in CompactibleFreeListSpace::reset()
Reviewed-by: ysr, jmasa

! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp

Changeset: 5ed122fbd0ef
Author:    brutisso
Date:      2013-05-21 10:39 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/5ed122fbd0ef

Merge


Changeset: 6702da6b6082
Author:    tschatzl
Date:      2013-05-21 11:30 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/6702da6b6082

8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes
Summary: Instead of using a simple sizeof(), ask the PerRegionTable class about its size when iterating over the free list.
Reviewed-by: jwilhelm, brutisso

! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp
! src/share/vm/prims/jni.cpp

Changeset: 7c5a1b62f53d
Author:    brutisso
Date:      2013-05-22 08:04 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/7c5a1b62f53d

8014971: Minor code cleanup of the freelist management
Reviewed-by: jwilhelm, jmasa, tschatzl

! src/share/vm/gc_implementation/concurrentMarkSweep/adaptiveFreeList.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/adaptiveFreeList.hpp
! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/memory/freeList.cpp
! src/share/vm/memory/freeList.hpp

Changeset: 62890ed7e2a8
Author:    jwilhelm
Date:      2013-05-24 09:29 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/62890ed7e2a8

Merge

- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java
- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java
- test/runtime/7158804/Test7158804.sh
- test/runtime/8003985/Test8003985.java

Changeset: 38da9f4f6709
Author:    amurillo
Date:      2013-05-24 09:25 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/38da9f4f6709

Merge

- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java
- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java
- test/runtime/7158804/Test7158804.sh
- test/runtime/8003985/Test8003985.java

Changeset: 092018493d3b
Author:    amurillo
Date:      2013-05-24 09:25 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/092018493d3b

Added tag hs25-b34 for changeset 38da9f4f6709

! .hgtags


From alejandro.murillo at oracle.com  Fri May 24 15:16:50 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 24 May 2013 22:16:50 +0000
Subject: hg: hsx/hotspot-main/hotspot: 4 new changesets
Message-ID: <20130524221702.2C26248D26@hg.openjdk.java.net>

Changeset: ad47de214f0c
Author:    katleman
Date:      2013-05-23 10:47 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/ad47de214f0c

Added tag jdk8-b91 for changeset 7cbdf0e3725c

! .hgtags

Changeset: 38da9f4f6709
Author:    amurillo
Date:      2013-05-24 09:25 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/38da9f4f6709

Merge

- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java
- agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java
- test/runtime/7158804/Test7158804.sh
- test/runtime/8003985/Test8003985.java

Changeset: 092018493d3b
Author:    amurillo
Date:      2013-05-24 09:25 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/092018493d3b

Added tag hs25-b34 for changeset 38da9f4f6709

! .hgtags

Changeset: 194b27b865bc
Author:    amurillo
Date:      2013-05-24 09:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/194b27b865bc

8015305: new hotspot build - hs25-b35
Reviewed-by: jcoomes

! make/hotspot_version


From david.holmes at oracle.com  Sun May 26 19:16:46 2013
From: david.holmes at oracle.com (David Holmes)
Date: Mon, 27 May 2013 12:16:46 +1000
Subject: CFV: New HSX Committer: Aleksey Shipilev
In-Reply-To: <519AB210.1070901@oracle.com>
References: <5111D374.2090101@oracle.com> <519AB210.1070901@oracle.com>
Message-ID: <51A2C20E.5010107@oracle.com>

Vote: veto

This is an updated vote. I was borderline on this one with regard to the 
number of "significant contributions" and upon further reflection I have 
to agree with Karen that the number of significant contributions (as 
opposed to number of changesets) falls short of the criteria at this time.

I'm sure, given Aleksey's ongoing work, that he will soon have the 
requisite number of contributions and so a new vote can be held.

David

On 21/05/2013 9:30 AM, Vladimir Kozlov wrote:
> I hereby nominate Aleksey Shipilev (OpenJDK user name: shade) to
> HSX Committer.
>
> Aleksey is a member of the Hotspot Performance group. He is working on
> java concurrency related projects. He contributed 11 changesets to HSX
> project and he is qualified to be committer [1]:
>
> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=shipilev
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/571076d3c79d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/205dd30230e1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/50e9396d5257
>
> Votes are due by June 3, 2013.
>
> Only current HSX Committers [2] are eligible to vote on this nomination.
> Votes must be cast in the open by replying to this mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> Thanks,
> Vladimir Kozlov
>
> [1] http://openjdk.java.net/projects/#project-committer
> [2] http://openjdk.java.net/census#hsx
> [3] http://openjdk.java.net/projects#committer-vote
>
>
>
>
>
>

From david.holmes at oracle.com  Sun May 26 20:11:42 2013
From: david.holmes at oracle.com (David Holmes)
Date: Mon, 27 May 2013 13:11:42 +1000
Subject: RFR: 8014074: Building hotspot with ccache in new build is very
	slow with empty cache.
In-Reply-To: <519F697A.4070106@oracle.com>
References: <519F697A.4070106@oracle.com>
Message-ID: <51A2CEEE.3080402@oracle.com>

Hi Erik,

I have mixed feelings on this one. On the one hand I don't like the idea 
that using/not-using an optimization like ccache, changes the way the 
build of hotspot is carried out. On the other hand, if this means we 
will do more builds without precompiled headers then it should help trap 
errors when there are missing #includes.

Does this have any impact on our actual RE builds?

Thanks,
David

On 24/05/2013 11:22 PM, Erik Joelsson wrote:
> This patch to configure disables precompiled headers in hotspot when
> ccache is in use.
>
> Background is in this mail (and the bug report):
> http://mail.openjdk.java.net/pipermail/build-dev/2013-April/008772.html
>
> In short, build time is shortened considerably both with an empty and a
> perfect cache when ccache is in use.
>
> Note that this only affects full builds from the root repo and not
> hotspot only builds.
>
> http://cr.openjdk.java.net/~erikj/8014074/webrev.root.01/
>
> /Erik

From erik.joelsson at oracle.com  Mon May 27 01:08:36 2013
From: erik.joelsson at oracle.com (Erik Joelsson)
Date: Mon, 27 May 2013 10:08:36 +0200
Subject: RFR: 8014074: Building hotspot with ccache in new build is very
	slow with empty cache.
In-Reply-To: <51A2CEEE.3080402@oracle.com>
References: <519F697A.4070106@oracle.com> <51A2CEEE.3080402@oracle.com>
Message-ID: <51A31484.2000200@oracle.com>



On 2013-05-27 05:11, David Holmes wrote:
> Hi Erik,
>
> I have mixed feelings on this one. On the one hand I don't like the 
> idea that using/not-using an optimization like ccache, changes the way 
> the build of hotspot is carried out. On the other hand, if this means 
> we will do more builds without precompiled headers then it should help 
> trap errors when there are missing #includes.
I agree, and it feels weird to me too. Precompiled header is also a kind 
of build optimization, though more intrusive than ccache. I was even 
more annoyed at the long build times when the cache didn't give any hits 
though.
>
> Does this have any impact on our actual RE builds?
I do not know if they have ccache installed and available on their 
machines. My guess is that if it is, it's by accident. We could instruct 
them to add --disable-ccache to make sure they don't accidentally pick 
it up. I could also readd and fix the support for precompiled header 
together with ccache and add another option for it.

/Erik
>
> Thanks,
> David
>
> On 24/05/2013 11:22 PM, Erik Joelsson wrote:
>> This patch to configure disables precompiled headers in hotspot when
>> ccache is in use.
>>
>> Background is in this mail (and the bug report):
>> http://mail.openjdk.java.net/pipermail/build-dev/2013-April/008772.html
>>
>> In short, build time is shortened considerably both with an empty and a
>> perfect cache when ccache is in use.
>>
>> Note that this only affects full builds from the root repo and not
>> hotspot only builds.
>>
>> http://cr.openjdk.java.net/~erikj/8014074/webrev.root.01/
>>
>> /Erik

From nils.loodin at oracle.com  Mon May 27 01:40:23 2013
From: nils.loodin at oracle.com (Nils Loodin)
Date: Mon, 27 May 2013 10:40:23 +0200
Subject: CFV: New HSX Committer: Aleksey Shipilev
In-Reply-To: <519AB210.1070901@oracle.com>
References: <5111D374.2090101@oracle.com> <519AB210.1070901@oracle.com>
Message-ID: <51A31BF7.4020903@oracle.com>

Vote: yes

/Nils Loodin

On 05/21/2013 01:30 AM, Vladimir Kozlov wrote:
> I hereby nominate Aleksey Shipilev (OpenJDK user name: shade) to
> HSX Committer.
>
> Aleksey is a member of the Hotspot Performance group. He is working on
> java concurrency related projects. He contributed 11 changesets to HSX
> project and he is qualified to be committer [1]:
>
> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=shipilev
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/571076d3c79d
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/205dd30230e1
> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/50e9396d5257
>
> Votes are due by June 3, 2013.
>
> Only current HSX Committers [2] are eligible to vote on this nomination.
> Votes must be cast in the open by replying to this mailing list.
>
> For Lazy Consensus voting instructions, see [3].
>
> Thanks,
> Vladimir Kozlov
>
> [1] http://openjdk.java.net/projects/#project-committer
> [2] http://openjdk.java.net/census#hsx
> [3] http://openjdk.java.net/projects#committer-vote
>
>
>
>
>
>


From stefan.karlsson at oracle.com  Mon May 27 04:35:33 2013
From: stefan.karlsson at oracle.com (Stefan Karlsson)
Date: Mon, 27 May 2013 13:35:33 +0200
Subject: Review request: 8015428: Remove unused CDS support from StringTable
Message-ID: <51A34505.9060406@oracle.com>

http://cr.openjdk.java.net/~stefank/8015428/webrev.00/

  <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015428>8015428  <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015428>: Remove unused CDS support from StringTable
Summary: The string in StringTable is not used by CDS anymore. Remove the unnecessary code in preparation for8015422  <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015422>: Large performance hit when the StringTable is walked twice in Parallel Scavenge

Tested with JPRT and ad-hoc benchmark allocating and deallocating interned Strings with and without -Xshare.

thanks,
StefanK


From per.liden at oracle.com  Mon May 27 06:28:53 2013
From: per.liden at oracle.com (=?ISO-8859-1?Q?Per_Lid=E9n?=)
Date: Mon, 27 May 2013 15:28:53 +0200
Subject: Review request: 8015428: Remove unused CDS support from
	StringTable
In-Reply-To: <51A34505.9060406@oracle.com>
References: <51A34505.9060406@oracle.com>
Message-ID: <51A35F95.2030004@oracle.com>

Hi Stefan,

On 2013-05-27 13:35, Stefan Karlsson wrote:
> http://cr.openjdk.java.net/~stefank/8015428/webrev.00/
>
>   <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015428>8015428
> <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015428>: Remove
> unused CDS support from StringTable
> Summary: The string in StringTable is not used by CDS anymore. Remove
> the unnecessary code in preparation for8015422
> <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015422>: Large
> performance hit when the StringTable is walked twice in Parallel Scavenge
>
> Tested with JPRT and ad-hoc benchmark allocating and deallocating
> interned Strings with and without -Xshare.

Looks good (not a reviewer), just one minor thing. Calling make_ptr() 
only makes sense if you have shared entries, so in unlink():

entry = (HashtableEntry<oop, mtSymbol>*)HashtableEntry<oop, 
mtSymbol>::make_ptr(*p);

could be;

entry = *p;

and in oops_do():

entry = (HashtableEntry<oop, mtSymbol>*)HashtableEntry<oop, 
mtSymbol>::make_ptr(entry->next());

could be:

entry = entry->next();

(actually, next() calls make_ptr() anyway before returning the next 
entry, but let's ignore that...)

/Per


From thomas.schatzl at oracle.com  Mon May 27 07:15:49 2013
From: thomas.schatzl at oracle.com (Thomas Schatzl)
Date: Mon, 27 May 2013 16:15:49 +0200
Subject: Review request: 8015428: Remove unused CDS support from
	StringTable
In-Reply-To: <51A34505.9060406@oracle.com>
References: <51A34505.9060406@oracle.com>
Message-ID: <1369664149.2702.83.camel@cirrus>

Hi,

On Mon, 2013-05-27 at 13:35 +0200, Stefan Karlsson wrote:
> http://cr.openjdk.java.net/~stefank/8015428/webrev.00/

Looks fine.

The new code for StringTable::oops_do() does not support that the
closure unlinks the literal - apparently this has been removed because
there is no closure that did that.
Maybe it is useful to add an assert for that case anyway.

Thanks,
Thomas



From stefan.karlsson at oracle.com  Mon May 27 10:49:45 2013
From: stefan.karlsson at oracle.com (Stefan Karlsson)
Date: Mon, 27 May 2013 19:49:45 +0200
Subject: Review request: 8015428: Remove unused CDS support from
	StringTable
In-Reply-To: <1369664149.2702.83.camel@cirrus>
References: <51A34505.9060406@oracle.com> <1369664149.2702.83.camel@cirrus>
Message-ID: <51A39CB9.4070303@oracle.com>

On 2013-05-27 16:15, Thomas Schatzl wrote:
> Hi,
>
> On Mon, 2013-05-27 at 13:35 +0200, Stefan Karlsson wrote:
>> http://cr.openjdk.java.net/~stefank/8015428/webrev.00/
> Looks fine.

Thanks.

>
> The new code for StringTable::oops_do() does not support that the
> closure unlinks the literal - apparently this has been removed because
> there is no closure that did that.

Yes. IMHO it doesn't make sense to have that kind of side-effect in a 
oops_do function, unless you really need it.

> Maybe it is useful to add an assert for that case anyway.
I can move down down the assert(entry->literal() != NULL,...) to after 
the f->do_oop(...) if you want to.

However, when thinking about this a bit more, I'd actually like to 
remove that assert all together. There's no reason for 
StringTable::oops_do to restrict the oops to be non-NULL. I think that 
part can be handled by the verification code that's already present:

  776 void StringTable::verify() {
  777   for (int i = 0; i < the_table()->table_size(); ++i) {
  778     HashtableEntry<oop, mtSymbol>* p = the_table()->bucket(i);
  779     for ( ; p != NULL; p = p->next()) {
  780       oop s = p->literal();
  781       guarantee(s != NULL, "interned string is NULL");


thanks,
StefanK

>
> Thanks,
> Thomas
>
>


From belevichp at gmail.com  Mon May 27 10:57:18 2013
From: belevichp at gmail.com (Pavel G. Belevich)
Date: Mon, 27 May 2013 13:57:18 -0400
Subject: Cannot find Symbols for jvm.dll
Message-ID: <CAM1MnmPZ8aFy0sB9+pY_6e9MyU6oTpM=m+mCvQkTznXOXD9u+A@mail.gmail.com>

Hi All,

I would greatly appreciate if someone can help me with building openjdk8 on
win7.

I cloned openjdk8 by
   hg clone http://hg.openjdk.java.net/jdk8/jdk8
then configured it by
   ./configure --enable-debug --with-target-bits=64
--with-freetype=/cygdrive/c/OpenJDK/freetype-2.3.12
then build by
   make all

After that I created VS project by running:

 c:\OpenJDK\jdk8\hotspot\make\windows\create.bat
c:\OpenJDK\jdk8\build\windows-x86_64-normal-server-fastdebug\jdk

When I tried to debug jvm VS said that it could not find or open the PDB
file for
C:\OpenJDK\jdk8\build\windows-x86_64-normal-server-fastdebug\jdk\bin\server\jvm.dll

Then I tried to manually load several pdb files(like jvm.pdb or java.pdb)
from c:\OpenJDK\jdk8\build\windows-x86_64-normal-server-fastdebug\jdk\objs
but w/o any luck.

Thank you!

Best regards, Pavel

From stefan.karlsson at oracle.com  Mon May 27 11:09:53 2013
From: stefan.karlsson at oracle.com (Stefan Karlsson)
Date: Mon, 27 May 2013 20:09:53 +0200
Subject: Review request: 8015428: Remove unused CDS support from
	StringTable
In-Reply-To: <51A35F95.2030004@oracle.com>
References: <51A34505.9060406@oracle.com> <51A35F95.2030004@oracle.com>
Message-ID: <51A3A171.5050303@oracle.com>

On 2013-05-27 15:28, Per Lid?n wrote:
> Hi Stefan,
>
> On 2013-05-27 13:35, Stefan Karlsson wrote:
>> http://cr.openjdk.java.net/~stefank/8015428/webrev.00/
>>
>> <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015428>8015428
>> <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015428>: Remove
>> unused CDS support from StringTable
>> Summary: The string in StringTable is not used by CDS anymore. Remove
>> the unnecessary code in preparation for8015422
>> <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015422>: Large
>> performance hit when the StringTable is walked twice in Parallel 
>> Scavenge
>>
>> Tested with JPRT and ad-hoc benchmark allocating and deallocating
>> interned Strings with and without -Xshare.
>
> Looks good (not a reviewer),

Thanks.

> just one minor thing. Calling make_ptr() only makes sense if you have 
> shared entries, so in unlink():
>
> entry = (HashtableEntry<oop, mtSymbol>*)HashtableEntry<oop, 
> mtSymbol>::make_ptr(*p);
>
> could be;
>
> entry = *p;
>
> and in oops_do():
>
> entry = (HashtableEntry<oop, mtSymbol>*)HashtableEntry<oop, 
> mtSymbol>::make_ptr(entry->next());
>
> could be:
>
> entry = entry->next();
>
> (actually, next() calls make_ptr() anyway before returning the next 
> entry, but let's ignore that...)

Updated webrev with your suggestion:

http://cr.openjdk.java.net/~stefank/8015428/webrev.01/

thanks,
StefanK
>
> /Per
>


From daniel.daugherty at oracle.com  Mon May 27 12:00:39 2013
From: daniel.daugherty at oracle.com (Daniel D. Daugherty)
Date: Mon, 27 May 2013 12:00:39 -0700 (PDT)
Subject: Cannot find Symbols for jvm.dll
In-Reply-To: <CAM1MnmPZ8aFy0sB9+pY_6e9MyU6oTpM=m+mCvQkTznXOXD9u+A@mail.gmail.com>
References: <CAM1MnmPZ8aFy0sB9+pY_6e9MyU6oTpM=m+mCvQkTznXOXD9u+A@mail.gmail.com>
Message-ID: <51A3AD57.6010601@oracle.com>

Pavel,

In order to save diskspace (by default), debug info files are ZIP'ed into
a '.diz' file; where 'diz' stands for Debug Info Zip...

To disable debug info ZIPing, set the following in your environment:

export ZIP_DEBUGINFO_FILES=0

There may be some other way of doing this in the new build system.

Dan


On 5/27/13 11:57 AM, Pavel G. Belevich wrote:
> Hi All,
>
> I would greatly appreciate if someone can help me with building openjdk8 on
> win7.
>
> I cloned openjdk8 by
>     hg clone http://hg.openjdk.java.net/jdk8/jdk8
> then configured it by
>     ./configure --enable-debug --with-target-bits=64
> --with-freetype=/cygdrive/c/OpenJDK/freetype-2.3.12
> then build by
>     make all
>
> After that I created VS project by running:
>
>   c:\OpenJDK\jdk8\hotspot\make\windows\create.bat
> c:\OpenJDK\jdk8\build\windows-x86_64-normal-server-fastdebug\jdk
>
> When I tried to debug jvm VS said that it could not find or open the PDB
> file for
> C:\OpenJDK\jdk8\build\windows-x86_64-normal-server-fastdebug\jdk\bin\server\jvm.dll
>
> Then I tried to manually load several pdb files(like jvm.pdb or java.pdb)
> from c:\OpenJDK\jdk8\build\windows-x86_64-normal-server-fastdebug\jdk\objs
> but w/o any luck.
>
> Thank you!
>
> Best regards, Pavel


From david.holmes at oracle.com  Mon May 27 17:52:44 2013
From: david.holmes at oracle.com (David Holmes)
Date: Tue, 28 May 2013 10:52:44 +1000
Subject: Cannot find Symbols for jvm.dll
In-Reply-To: <CAM1MnmPZ8aFy0sB9+pY_6e9MyU6oTpM=m+mCvQkTznXOXD9u+A@mail.gmail.com>
References: <CAM1MnmPZ8aFy0sB9+pY_6e9MyU6oTpM=m+mCvQkTznXOXD9u+A@mail.gmail.com>
Message-ID: <51A3FFDC.2030705@oracle.com>

On 28/05/2013 3:57 AM, Pavel G. Belevich wrote:
> Hi All,
>
> I would greatly appreciate if someone can help me with building openjdk8 on
> win7.
>
> I cloned openjdk8 by
>     hg clone http://hg.openjdk.java.net/jdk8/jdk8
> then configured it by
>     ./configure --enable-debug --with-target-bits=64
> --with-freetype=/cygdrive/c/OpenJDK/freetype-2.3.12
> then build by
>     make all

Try using "make images" to create a full JDK (images/j2sdk-image) rather 
than trying to use the build artifacts from the  jdk output directory. 
For a fastdebug build the symbols will be with the jvm.dll but as Dan 
said they will be zipped by default.

HTH.

David

> After that I created VS project by running:
>
>   c:\OpenJDK\jdk8\hotspot\make\windows\create.bat
> c:\OpenJDK\jdk8\build\windows-x86_64-normal-server-fastdebug\jdk
>
> When I tried to debug jvm VS said that it could not find or open the PDB
> file for
> C:\OpenJDK\jdk8\build\windows-x86_64-normal-server-fastdebug\jdk\bin\server\jvm.dll
>
> Then I tried to manually load several pdb files(like jvm.pdb or java.pdb)
> from c:\OpenJDK\jdk8\build\windows-x86_64-normal-server-fastdebug\jdk\objs
> but w/o any luck.
>
> Thank you!
>
> Best regards, Pavel
>

From thomas.schatzl at oracle.com  Tue May 28 01:58:05 2013
From: thomas.schatzl at oracle.com (Thomas Schatzl)
Date: Tue, 28 May 2013 10:58:05 +0200
Subject: Review request: 8015428: Remove unused CDS support from
	StringTable
In-Reply-To: <51A39CB9.4070303@oracle.com>
References: <51A34505.9060406@oracle.com> <1369664149.2702.83.camel@cirrus>
	<51A39CB9.4070303@oracle.com>
Message-ID: <1369731485.2616.40.camel@cirrus>

Hi,

On Mon, 2013-05-27 at 19:49 +0200, Stefan Karlsson wrote:
> On 2013-05-27 16:15, Thomas Schatzl wrote:
> 
> > Hi,
> > 
> > On Mon, 2013-05-27 at 13:35 +0200, Stefan Karlsson wrote:
> > > http://cr.openjdk.java.net/~stefank/8015428/webrev.00/
> > Looks fine.

(I had a look at http://cr.openjdk.java.net/~stefank/8015428/webrev.01/
in the meantime. Looks good too btw)

> > The new code for StringTable::oops_do() does not support that the
> > closure unlinks the literal - apparently this has been removed because
> > there is no closure that did that.
>
> Yes. IMHO it doesn't make sense to have that kind of side-effect in a
> oops_do function, unless you really need it.
>

Sure.

> > Maybe it is useful to add an assert for that case anyway.
> I can move down down the assert(entry->literal() != NULL,...) to after
> the f->do_oop(...) if you want to.
>
> However, when thinking about this a bit more, I'd actually like to
> remove that assert all together. There's no reason for
> StringTable::oops_do to restrict the oops to be non-NULL. I think that
> part can be handled by the verification code that's already present:
>  776 void StringTable::verify() {
>  777   for (int i = 0; i < the_table()->table_size(); ++i) {
>  778     HashtableEntry<oop, mtSymbol>* p = the_table()->bucket(i);
>  779     for ( ; p != NULL; p = p->next()) {
>  780       oop s = p->literal();
>  781       guarantee(s != NULL, "interned string is NULL");

That's fine with me. You're right, StringTable::verify() and
Universe::verify() which calls that are used if VerifyDuringGC is
enabled.

Thomas


From stefan.karlsson at oracle.com  Tue May 28 02:05:34 2013
From: stefan.karlsson at oracle.com (Stefan Karlsson)
Date: Tue, 28 May 2013 11:05:34 +0200
Subject: Review request: 8015428: Remove unused CDS support from
	StringTable
In-Reply-To: <1369731485.2616.40.camel@cirrus>
References: <51A34505.9060406@oracle.com> <1369664149.2702.83.camel@cirrus>
	<51A39CB9.4070303@oracle.com> <1369731485.2616.40.camel@cirrus>
Message-ID: <51A4735E.7010906@oracle.com>

On 05/28/2013 10:58 AM, Thomas Schatzl wrote:
> Hi,
>
> On Mon, 2013-05-27 at 19:49 +0200, Stefan Karlsson wrote:
>> On 2013-05-27 16:15, Thomas Schatzl wrote:
>>
>>> Hi,
>>>
>>> On Mon, 2013-05-27 at 13:35 +0200, Stefan Karlsson wrote:
>>>> http://cr.openjdk.java.net/~stefank/8015428/webrev.00/
>>> Looks fine.
> (I had a look at http://cr.openjdk.java.net/~stefank/8015428/webrev.01/
> in the meantime. Looks good too btw)
>
>>> The new code for StringTable::oops_do() does not support that the
>>> closure unlinks the literal - apparently this has been removed because
>>> there is no closure that did that.
>> Yes. IMHO it doesn't make sense to have that kind of side-effect in a
>> oops_do function, unless you really need it.
>>
> Sure.
>
>>> Maybe it is useful to add an assert for that case anyway.
>> I can move down down the assert(entry->literal() != NULL,...) to after
>> the f->do_oop(...) if you want to.
>>
>> However, when thinking about this a bit more, I'd actually like to
>> remove that assert all together. There's no reason for
>> StringTable::oops_do to restrict the oops to be non-NULL. I think that
>> part can be handled by the verification code that's already present:
>>   776 void StringTable::verify() {
>>   777   for (int i = 0; i < the_table()->table_size(); ++i) {
>>   778     HashtableEntry<oop, mtSymbol>* p = the_table()->bucket(i);
>>   779     for ( ; p != NULL; p = p->next()) {
>>   780       oop s = p->literal();
>>   781       guarantee(s != NULL, "interned string is NULL");
> That's fine with me. You're right, StringTable::verify() and
> Universe::verify() which calls that are used if VerifyDuringGC is
> enabled.

Thanks.

StefanK

> Thomas
>


From erik.helin at oracle.com  Tue May 28 04:42:26 2013
From: erik.helin at oracle.com (erik.helin at oracle.com)
Date: Tue, 28 May 2013 11:42:26 +0000
Subject: hg: hsx/hsx24/hotspot: 6843375: Debuggee VM crashes performing
	mark-sweep-compact
Message-ID: <20130528114232.AD3C148D7F@hg.openjdk.java.net>

Changeset: f1faa475b37d
Author:    ehelin
Date:      2013-05-28 11:27 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/f1faa475b37d

6843375: Debuggee VM crashes performing mark-sweep-compact
Reviewed-by: stefank, jmasa

! src/share/vm/prims/jvmtiImpl.cpp
! src/share/vm/prims/jvmtiImpl.hpp


From joel.franck at oracle.com  Tue May 28 06:10:10 2013
From: joel.franck at oracle.com (Joel Borggren-Franck)
Date: Tue, 28 May 2013 15:10:10 +0200
Subject: RFR (XS): 8014709  Constructor.getAnnotatedReturnType() returns
	empty AnnotatedType
Message-ID: <20130528131010.GA25459@jfranck-desktop.jrpg.bea.com>

Hi

Please review this fix and test update for 8014709:
Constructor.getAnnotatedReturnType() returns empty AnnotatedType.

When implementing VM support for reflection for type annotations I
forgot to store the type annotation byte array on
java.lang.reflect.Constructor objects. This is a fix and a test update
to address this.

Modified test fails with an old HotSpot passes with the fix.

This bug was found in internal testing that also passes with the fix.

Webrev: http://cr.openjdk.java.net/~jfranck/8014709/webrev.00/

cheers
/Joel

From coleen.phillimore at oracle.com  Tue May 28 06:13:54 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Tue, 28 May 2013 09:13:54 -0400
Subject: New hsx Reviewer: Staffan Larsen
Message-ID: <51A4AD92.4030305@oracle.com>

|
Voting for Staffan Larsen [1] is now closed.

Yes:*9*
Veto: 0
Abstain:*0*

According to the Bylaws definition of Three-Vote Consensus, this is
sufficient to approve the nomination.

*Coleen Phillimore*

[1]*http://mail.openjdk.java.net/pipermail/hotspot-dev/2013-May/009464.html*|


From joseph.provino at oracle.com  Tue May 28 07:53:47 2013
From: joseph.provino at oracle.com (JOSEPH PROVINO)
Date: Tue, 28 May 2013 10:53:47 -0400
Subject: review request -- JDK-8011064 Some tests have failed with SIGSEGV
	on arm-hflt on build b82
In-Reply-To: <519CE166.7050204@oracle.com>
References: <519A78F4.4010909@oracle.com> <519A9D5B.7060705@oracle.com>
	<519BB59E.3020801@oracle.com> <519BD13B.8030502@oracle.com>
	<519C4D01.40900@oracle.com> <519CE166.7050204@oracle.com>
Message-ID: <51A4C4FB.9040100@oracle.com>

Latest webrev is here: 
http://cr.openjdk.java.net/~jprovino/8011064/webrev.03

I added a comment that David Holmes suggested.

joe

On 5/22/2013 11:16 AM, JOSEPH PROVINO wrote:
> Latest webrev is here: 
> http://cr.openjdk.java.net/~jprovino/8011064/webrev.02
>
> joe
>
>
> On 5/22/2013 12:43 AM, David Holmes wrote:
>> Just for the benefit of others watching this, the undef approach is 
>> not ideal and there's another alternative in the pipeline.
>>
>> David
>>
>> On 22/05/2013 5:55 AM, JOSEPH PROVINO wrote:
>>> New webrev is here:
>>>
>>> http://cr.openjdk.java.net/~jprovino/8011064/webrev.01/
>>>
>>> joe
>>>
>>> On 5/21/2013 1:57 PM, JOSEPH PROVINO wrote:
>>>> That's a good solution.  Is there any reason NMT_detail_supported
>>>> can't be made const or
>>>> better yet eliminate the variable and just use if
>>>> (PLATFORM_NMT_DETAIL_SUPPORTED) ?
>>>>
>>>> joe
>>>>
>>>> On 5/20/2013 6:02 PM, BILL PITTORE wrote:
>>>>>  Maybe something like I did for SUPPORTS_NATIVE_CX8. This gets
>>>>> defined in globalDefinitions_<cpu>.hpp.
>>>>> In this situation maybe something like:
>>>>>
>>>>> memTracker.cpp
>>>>>   bool NMT_detail_supported = PLATFORM_NMT_DETAIL_SUPPORTED;
>>>>>
>>>>> then in globalDefinitions_<cpu>.hpp
>>>>>
>>>>> #define PLATFORM_NMT_DETAIL_SUPPORTED {true | false} as the case 
>>>>> may be.
>>>>>
>>>>> Then you eliminate the need to add code to pd_initialize()
>>>>>
>>>>> bill
>>>>>
>>>>> On 5/20/2013 3:26 PM, JOSEPH PROVINO wrote:
>>>>>> Make it easy to disable NMT detail in platform specific code.
>>>>>>
>>>>>> A new variable NMT_detail_supported is defined and set to true.
>>>>>> It can be disabled in platform specific code as needed.
>>>>>>
>>>>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8011064/webrev/
>>>>>>
>>>>>> JDK-8011064 <https://jbs.oracle.com/bugs/browse/JDK-8011064>Some
>>>>>> tests have failed with SIGSEGV on arm-hflt on build b82
>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8011064>
>>>>>
>>>>>
>>>>
>>>
>


From christian.thalinger at oracle.com  Tue May 28 11:35:05 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Tue, 28 May 2013 11:35:05 -0700
Subject: Review request: 8015428: Remove unused CDS support from
	StringTable
In-Reply-To: <51A34505.9060406@oracle.com>
References: <51A34505.9060406@oracle.com>
Message-ID: <25A437DC-1BDD-419D-8252-EB7C0D413DC1@oracle.com>


On May 27, 2013, at 4:35 AM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:

> http://cr.openjdk.java.net/~stefank/8015428/webrev.00/
> 
> <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015428>8015428  <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015428>: Remove unused CDS support from StringTable
> Summary: The string in StringTable is not used by CDS anymore. Remove the unnecessary code in preparation for8015422  <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015422>: Large performance hit when the StringTable is walked twice in Parallel Scavenge

I'm adding interned strings back to CDS right now with 8015086.  The changes should be okay though since I'll have two string tables then and we only need to walk the dynamic one.

-- Chris

> 
> Tested with JPRT and ad-hoc benchmark allocating and deallocating interned Strings with and without -Xshare.
> 
> thanks,
> StefanK
> 


From stefan.karlsson at oracle.com  Tue May 28 11:47:56 2013
From: stefan.karlsson at oracle.com (Stefan Karlsson)
Date: Tue, 28 May 2013 20:47:56 +0200
Subject: Review request: 8015428: Remove unused CDS support from
	StringTable
In-Reply-To: <25A437DC-1BDD-419D-8252-EB7C0D413DC1@oracle.com>
References: <51A34505.9060406@oracle.com>
	<25A437DC-1BDD-419D-8252-EB7C0D413DC1@oracle.com>
Message-ID: <51A4FBDC.8060709@oracle.com>

On 5/28/13 8:35 PM, Christian Thalinger wrote:
> On May 27, 2013, at 4:35 AM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
>
>> http://cr.openjdk.java.net/~stefank/8015428/webrev.00/
>>
>> <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015428>8015428  <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015428>: Remove unused CDS support from StringTable
>> Summary: The string in StringTable is not used by CDS anymore. Remove the unnecessary code in preparation for8015422  <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015422>: Large performance hit when the StringTable is walked twice in Parallel Scavenge
> I'm adding interned strings back to CDS right now with 8015086.  The changes should be okay though since I'll have two string tables then and we only need to walk the dynamic one.
Great!

thanks,
StefanK

>
> -- Chris
>
>> Tested with JPRT and ad-hoc benchmark allocating and deallocating interned Strings with and without -Xshare.
>>
>> thanks,
>> StefanK
>>


From coleen.phillimore at oracle.com  Tue May 28 12:22:57 2013
From: coleen.phillimore at oracle.com (Coleen Phillmore)
Date: Tue, 28 May 2013 15:22:57 -0400
Subject: Review request: 8015428: Remove unused CDS support from
	StringTable
In-Reply-To: <51A4FBDC.8060709@oracle.com>
References: <51A34505.9060406@oracle.com>
	<25A437DC-1BDD-419D-8252-EB7C0D413DC1@oracle.com>
	<51A4FBDC.8060709@oracle.com>
Message-ID: <51A50411.1030006@oracle.com>


Thanks Christian for the info.   Code looks good.
Coleen

On 5/28/2013 2:47 PM, Stefan Karlsson wrote:
> On 5/28/13 8:35 PM, Christian Thalinger wrote:
>> On May 27, 2013, at 4:35 AM, Stefan Karlsson 
>> <stefan.karlsson at oracle.com> wrote:
>>
>>> http://cr.openjdk.java.net/~stefank/8015428/webrev.00/
>>>
>>> <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015428>8015428 
>>> <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015428>: Remove 
>>> unused CDS support from StringTable
>>> Summary: The string in StringTable is not used by CDS anymore. 
>>> Remove the unnecessary code in preparation for8015422 
>>> <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015422>: Large 
>>> performance hit when the StringTable is walked twice in Parallel 
>>> Scavenge
>> I'm adding interned strings back to CDS right now with 8015086. The 
>> changes should be okay though since I'll have two string tables then 
>> and we only need to walk the dynamic one.
> Great!
>
> thanks,
> StefanK
>
>>
>> -- Chris
>>
>>> Tested with JPRT and ad-hoc benchmark allocating and deallocating 
>>> interned Strings with and without -Xshare.
>>>
>>> thanks,
>>> StefanK
>>>
>


From stefan.karlsson at oracle.com  Tue May 28 12:54:24 2013
From: stefan.karlsson at oracle.com (Stefan Karlsson)
Date: Tue, 28 May 2013 21:54:24 +0200
Subject: Review request: 8015428: Remove unused CDS support from
	StringTable
In-Reply-To: <51A50411.1030006@oracle.com>
References: <51A34505.9060406@oracle.com>
	<25A437DC-1BDD-419D-8252-EB7C0D413DC1@oracle.com>
	<51A4FBDC.8060709@oracle.com> <51A50411.1030006@oracle.com>
Message-ID: <51A50B70.2060700@oracle.com>

On 5/28/13 9:22 PM, Coleen Phillmore wrote:
>
> Thanks Christian for the info.   Code looks good.

Thanks, Coleen!

StefanK
> Coleen
>
> On 5/28/2013 2:47 PM, Stefan Karlsson wrote:
>> On 5/28/13 8:35 PM, Christian Thalinger wrote:
>>> On May 27, 2013, at 4:35 AM, Stefan Karlsson 
>>> <stefan.karlsson at oracle.com> wrote:
>>>
>>>> http://cr.openjdk.java.net/~stefank/8015428/webrev.00/
>>>>
>>>> <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015428>8015428 
>>>> <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015428>: 
>>>> Remove unused CDS support from StringTable
>>>> Summary: The string in StringTable is not used by CDS anymore. 
>>>> Remove the unnecessary code in preparation for8015422 
>>>> <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015422>: Large 
>>>> performance hit when the StringTable is walked twice in Parallel 
>>>> Scavenge
>>> I'm adding interned strings back to CDS right now with 8015086. The 
>>> changes should be okay though since I'll have two string tables then 
>>> and we only need to walk the dynamic one.
>> Great!
>>
>> thanks,
>> StefanK
>>
>>>
>>> -- Chris
>>>
>>>> Tested with JPRT and ad-hoc benchmark allocating and deallocating 
>>>> interned Strings with and without -Xshare.
>>>>
>>>> thanks,
>>>> StefanK
>>>>
>>
>


From mark at talios.com  Tue May 28 18:04:59 2013
From: mark at talios.com (Mark Derricutt)
Date: Wed, 29 May 2013 13:04:59 +1200
Subject: Class verifier issues with unboxing method handles
Message-ID: <51A5543B.10506@talios.com>

Hi all,

Mark Reinhold suggested I posted this question/bug report to hotspot-dev 
rather than jdk8-dev so here goes.

I have a fairly simple test case using the new streams API:

public static void main(String[] args) {
List<String> strings = Arrays.asList("1", "2", "3", "4", "5");
   strings.stream()
.mapToInt(s -> new Integer(s))
.forEach(i -> System.out.println(String.format("int %d", i)));
}


which compiles, runs, and prints out what I expect:

int 1
int 2
int 3
int 4
int 5


Given that mapToInt() is returning an IntegerStream wrapping primitive 
ints, the result of my closure is successfully autoboxed down to an int 
and all is happy with the world.

If I change this code to be:

   strings.stream()
          .mapToInt(Integer::parseInt)
          .forEach(i -> System.out.println(String.format("int %d", i)));

Again, everything works as expected as Integer::parseInt returns an int, 
so there's no boxing.

Changing this once again to:

   strings.stream()
          .mapToInt(Integer::valueOf)
          .forEach(i -> System.out.println(String.format("int %d", i)));

I also see the expected result, Integer::valueOf returns an Integer 
which is then being boxed down to an int.

However, if I change the code to:

  strings.stream()
         .mapToInt(Integer::new)
         .forEach(i -> System.out.println(String.format("int %d", i)));

which, if I understand correctly - Integer::new should be returning a 
method handle to the constructor. IntelliJ IDEA 13 autocompletes this 
for me, and hyperlinks to the Integer(String s) constructor, javac 
successfully compiles the code so my -assumption- is that the 
constructor would be called, returning an Integer which is then boxed 
down to an int, however, this is what I get:

Exception in thread "main" java.lang.BootstrapMethodError: call site 
initialization exception
     at java.lang.invoke.CallSite.makeSite(CallSite.java:298)
     at 
java.lang.invoke.MethodHandleNatives.linkCallSite(MethodHandleNatives.java:294)
     at com.talios.test.TestJdk.main(TestJdk.java:12)
     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
     at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     at java.lang.reflect.Method.invoke(Method.java:491)
     at com.intellij.rt.execution.application.AppMain.main(AppMain.java:120)
Caused by: java.lang.VerifyError: Bad type on operand stack
Exception Details:
   Location:
     com/talios/test/TestJdk$$Lambda$1.applyAsInt(Ljava/lang/Object;)I 
@11: ireturn
   Reason:
     Type 'java/lang/Integer' (current frame, stack[0]) is not 
assignable to integer
   Current Frame:
     bci: @11
     flags: { }
     locals: { 'com/talios/test/TestJdk$$Lambda$1', 'java/lang/Object' }
     stack: { 'java/lang/Integer' }
   Bytecode:
     0000000: bb00 0e59 2bc0 0010 b700 13ac

     at java.lang.Class.getDeclaredConstructors0(Native Method)
     at java.lang.Class.privateGetDeclaredConstructors(Class.java:2536)
     at java.lang.Class.getDeclaredConstructors(Class.java:1928)
     at 
java.lang.invoke.InnerClassLambdaMetafactory$1.run(InnerClassLambdaMetafactory.java:147)
     at 
java.lang.invoke.InnerClassLambdaMetafactory$1.run(InnerClassLambdaMetafactory.java:144)
     at java.security.AccessController.doPrivileged(Native Method)
     at 
java.lang.invoke.InnerClassLambdaMetafactory.buildCallSite(InnerClassLambdaMetafactory.java:143)
     at 
java.lang.invoke.LambdaMetafactory.metaFactory(LambdaMetafactory.java:191)
     at java.lang.invoke.CallSite.makeSite(CallSite.java:283)
     ... 7 more

This is on OSX Mountain Lion, with JDK 8 Build 91.

Have I walked in an obscure corner case of method handle breakage and 
found something new, or is this a new problem?

Cheers,
Mark


From david.holmes at oracle.com  Tue May 28 18:48:14 2013
From: david.holmes at oracle.com (David Holmes)
Date: Wed, 29 May 2013 11:48:14 +1000
Subject: Class verifier issues with unboxing method handles
In-Reply-To: <51A5543B.10506@talios.com>
References: <51A5543B.10506@talios.com>
Message-ID: <51A55E5E.4020605@oracle.com>

Hi Mark,

cc'ing lambda-dev. This may be a bug, a version mismatch, or something 
else. The lambda-dev folk will know.

David

On 29/05/2013 11:04 AM, Mark Derricutt wrote:
> Hi all,
>
> Mark Reinhold suggested I posted this question/bug report to hotspot-dev
> rather than jdk8-dev so here goes.
>
> I have a fairly simple test case using the new streams API:
>
> public static void main(String[] args) {
> List<String> strings = Arrays.asList("1", "2", "3", "4", "5");
>    strings.stream()
> .mapToInt(s -> new Integer(s))
> .forEach(i -> System.out.println(String.format("int %d", i)));
> }
>
>
> which compiles, runs, and prints out what I expect:
>
> int 1
> int 2
> int 3
> int 4
> int 5
>
>
> Given that mapToInt() is returning an IntegerStream wrapping primitive
> ints, the result of my closure is successfully autoboxed down to an int
> and all is happy with the world.
>
> If I change this code to be:
>
>    strings.stream()
>           .mapToInt(Integer::parseInt)
>           .forEach(i -> System.out.println(String.format("int %d", i)));
>
> Again, everything works as expected as Integer::parseInt returns an int,
> so there's no boxing.
>
> Changing this once again to:
>
>    strings.stream()
>           .mapToInt(Integer::valueOf)
>           .forEach(i -> System.out.println(String.format("int %d", i)));
>
> I also see the expected result, Integer::valueOf returns an Integer
> which is then being boxed down to an int.
>
> However, if I change the code to:
>
>   strings.stream()
>          .mapToInt(Integer::new)
>          .forEach(i -> System.out.println(String.format("int %d", i)));
>
> which, if I understand correctly - Integer::new should be returning a
> method handle to the constructor. IntelliJ IDEA 13 autocompletes this
> for me, and hyperlinks to the Integer(String s) constructor, javac
> successfully compiles the code so my -assumption- is that the
> constructor would be called, returning an Integer which is then boxed
> down to an int, however, this is what I get:
>
> Exception in thread "main" java.lang.BootstrapMethodError: call site
> initialization exception
>      at java.lang.invoke.CallSite.makeSite(CallSite.java:298)
>      at
> java.lang.invoke.MethodHandleNatives.linkCallSite(MethodHandleNatives.java:294)
>
>      at com.talios.test.TestJdk.main(TestJdk.java:12)
>      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>      at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>
>      at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>
>      at java.lang.reflect.Method.invoke(Method.java:491)
>      at
> com.intellij.rt.execution.application.AppMain.main(AppMain.java:120)
> Caused by: java.lang.VerifyError: Bad type on operand stack
> Exception Details:
>    Location:
>      com/talios/test/TestJdk$$Lambda$1.applyAsInt(Ljava/lang/Object;)I
> @11: ireturn
>    Reason:
>      Type 'java/lang/Integer' (current frame, stack[0]) is not
> assignable to integer
>    Current Frame:
>      bci: @11
>      flags: { }
>      locals: { 'com/talios/test/TestJdk$$Lambda$1', 'java/lang/Object' }
>      stack: { 'java/lang/Integer' }
>    Bytecode:
>      0000000: bb00 0e59 2bc0 0010 b700 13ac
>
>      at java.lang.Class.getDeclaredConstructors0(Native Method)
>      at java.lang.Class.privateGetDeclaredConstructors(Class.java:2536)
>      at java.lang.Class.getDeclaredConstructors(Class.java:1928)
>      at
> java.lang.invoke.InnerClassLambdaMetafactory$1.run(InnerClassLambdaMetafactory.java:147)
>
>      at
> java.lang.invoke.InnerClassLambdaMetafactory$1.run(InnerClassLambdaMetafactory.java:144)
>
>      at java.security.AccessController.doPrivileged(Native Method)
>      at
> java.lang.invoke.InnerClassLambdaMetafactory.buildCallSite(InnerClassLambdaMetafactory.java:143)
>
>      at
> java.lang.invoke.LambdaMetafactory.metaFactory(LambdaMetafactory.java:191)
>      at java.lang.invoke.CallSite.makeSite(CallSite.java:283)
>      ... 7 more
>
> This is on OSX Mountain Lion, with JDK 8 Build 91.
>
> Have I walked in an obscure corner case of method handle breakage and
> found something new, or is this a new problem?
>
> Cheers,
> Mark
>

From david.holmes at oracle.com  Tue May 28 19:50:40 2013
From: david.holmes at oracle.com (David Holmes)
Date: Wed, 29 May 2013 12:50:40 +1000
Subject: review request -- JDK-8011064 Some tests have failed with SIGSEGV
	on arm-hflt on build b82
In-Reply-To: <51A4C4FB.9040100@oracle.com>
References: <519A78F4.4010909@oracle.com> <519A9D5B.7060705@oracle.com>
	<519BB59E.3020801@oracle.com> <519BD13B.8030502@oracle.com>
	<519C4D01.40900@oracle.com> <519CE166.7050204@oracle.com>
	<51A4C4FB.9040100@oracle.com>
Message-ID: <51A56D00.60501@oracle.com>

Good to go - thanks Joe!

David

On 29/05/2013 12:53 AM, JOSEPH PROVINO wrote:
> Latest webrev is here:
> http://cr.openjdk.java.net/~jprovino/8011064/webrev.03
>
> I added a comment that David Holmes suggested.
>
> joe
>
> On 5/22/2013 11:16 AM, JOSEPH PROVINO wrote:
>> Latest webrev is here:
>> http://cr.openjdk.java.net/~jprovino/8011064/webrev.02
>>
>> joe
>>
>>
>> On 5/22/2013 12:43 AM, David Holmes wrote:
>>> Just for the benefit of others watching this, the undef approach is
>>> not ideal and there's another alternative in the pipeline.
>>>
>>> David
>>>
>>> On 22/05/2013 5:55 AM, JOSEPH PROVINO wrote:
>>>> New webrev is here:
>>>>
>>>> http://cr.openjdk.java.net/~jprovino/8011064/webrev.01/
>>>>
>>>> joe
>>>>
>>>> On 5/21/2013 1:57 PM, JOSEPH PROVINO wrote:
>>>>> That's a good solution.  Is there any reason NMT_detail_supported
>>>>> can't be made const or
>>>>> better yet eliminate the variable and just use if
>>>>> (PLATFORM_NMT_DETAIL_SUPPORTED) ?
>>>>>
>>>>> joe
>>>>>
>>>>> On 5/20/2013 6:02 PM, BILL PITTORE wrote:
>>>>>>  Maybe something like I did for SUPPORTS_NATIVE_CX8. This gets
>>>>>> defined in globalDefinitions_<cpu>.hpp.
>>>>>> In this situation maybe something like:
>>>>>>
>>>>>> memTracker.cpp
>>>>>>   bool NMT_detail_supported = PLATFORM_NMT_DETAIL_SUPPORTED;
>>>>>>
>>>>>> then in globalDefinitions_<cpu>.hpp
>>>>>>
>>>>>> #define PLATFORM_NMT_DETAIL_SUPPORTED {true | false} as the case
>>>>>> may be.
>>>>>>
>>>>>> Then you eliminate the need to add code to pd_initialize()
>>>>>>
>>>>>> bill
>>>>>>
>>>>>> On 5/20/2013 3:26 PM, JOSEPH PROVINO wrote:
>>>>>>> Make it easy to disable NMT detail in platform specific code.
>>>>>>>
>>>>>>> A new variable NMT_detail_supported is defined and set to true.
>>>>>>> It can be disabled in platform specific code as needed.
>>>>>>>
>>>>>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8011064/webrev/
>>>>>>>
>>>>>>> JDK-8011064 <https://jbs.oracle.com/bugs/browse/JDK-8011064>Some
>>>>>>> tests have failed with SIGSEGV on arm-hflt on build b82
>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8011064>
>>>>>>
>>>>>>
>>>>>
>>>>
>>
>

From rickard.backman at oracle.com  Wed May 29 07:14:09 2013
From: rickard.backman at oracle.com (rickard.backman at oracle.com)
Date: Wed, 29 May 2013 14:14:09 +0000
Subject: hg: hsx/hotspot-main/hotspot: 14 new changesets
Message-ID: <20130529141439.CE8A348DE0@hg.openjdk.java.net>

Changeset: ccdecfece956
Author:    bharadwaj
Date:      2013-05-21 16:17 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/ccdecfece956

8014059: JSR292: Failed to reject invalid class cplmhl00201m28n
Summary: Restrict reference of interface methods by invokestatic and invokespecial to classfile version 52 or later.
Reviewed-by: kvn, hseigel

! src/share/vm/classfile/classFileParser.cpp

Changeset: f54c85acc043
Author:    mikael
Date:      2013-05-21 09:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f54c85acc043

8013726: runtime/memory/ReserveMemory.java fails due to 'assert(bytes % os::vm_allocation_granularity() == 0) failed: reserve block size'
Summary: Fix regression test to work on all platforms
Reviewed-by: ctornqvi, dholmes

! src/share/vm/prims/whitebox.cpp
! test/runtime/memory/ReserveMemory.java
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: 1a07e086ff28
Author:    dholmes
Date:      2013-05-21 19:52 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/1a07e086ff28

Merge


Changeset: 6bd680e9ea35
Author:    coleenp
Date:      2013-05-22 14:37 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/6bd680e9ea35

8003421: NPG: Move oops out of InstanceKlass into mirror
Summary: Inject protection_domain, signers, init_lock into java_lang_Class
Reviewed-by: stefank, dholmes, sla

! agent/src/share/classes/sun/jvm/hotspot/memory/DictionaryEntry.java
! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java
! agent/src/share/classes/sun/jvm/hotspot/utilities/HeapGXLWriter.java
! agent/src/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java
! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaInstanceKlass.java
! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/classfile/javaClasses.cpp
! src/share/vm/classfile/javaClasses.hpp
! src/share/vm/classfile/vmSymbols.hpp
! src/share/vm/oops/arrayKlass.cpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/oops/klass.cpp
! src/share/vm/oops/klass.hpp
! src/share/vm/oops/objArrayKlass.hpp
! src/share/vm/oops/typeArrayKlass.hpp
! src/share/vm/prims/jvm.cpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: 699d9df07e59
Author:    ctornqvi
Date:      2013-05-23 17:39 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/699d9df07e59

8009576: Test returns ClassNotFoundException
Summary: Small classpath fix and move tests into open
Reviewed-by: mgerdin, zgu

+ test/runtime/Metaspace/FragmentMetaspace.java
+ test/runtime/Metaspace/FragmentMetaspaceSimple.java
+ test/runtime/Metaspace/classes/test/Empty.java
+ test/runtime/testlibrary/GeneratedClassLoader.java

Changeset: b7fa10a3a69a
Author:    sspitsyn
Date:      2013-05-23 23:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b7fa10a3a69a

8014288: perf regression in nashorn JDK-8008448.js test after 8008511 changes
Summary: The fix of perf regression is to use method_idnum() for direct indexing into NMT
Reviewed-by: twisti, kvn, coleenp, dholmes
Contributed-by: serguei.spitsyn at oracle.com

! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/prims/methodHandles.cpp
! src/share/vm/prims/methodHandles.hpp

Changeset: cd83e1d98347
Author:    dcubed
Date:      2013-05-24 10:21 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/cd83e1d98347

Merge


Changeset: 6c138b9851fb
Author:    sspitsyn
Date:      2013-05-24 17:36 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/6c138b9851fb

8013945: CMS fatal error: must own lock MemberNameTable_lock
Summary: The "delete mnt" needs to grab MemberNameTable_lock if !SafepointSynchronize::is_at_safepoint()
Reviewed-by: sla, mgerdin, dholmes, jmasa
Contributed-by: serguei.spitsyn at oracle.com

! src/share/vm/oops/instanceKlass.cpp

Changeset: 3970971c91e0
Author:    shade
Date:      2013-05-27 12:49 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/3970971c91e0

8015270: @Contended: fix multiple issues in the layout code
Summary: field count handling fixed, has_nonstatic_fields invariant fixed, oop map overrun fixed; new asserts
Reviewed-by: kvn, dcubed, coleenp

! src/share/vm/classfile/classFileParser.cpp
+ test/runtime/contended/HasNonStatic.java
+ test/runtime/contended/OopMaps.java

Changeset: a213d425d87a
Author:    ctornqvi
Date:      2013-05-28 15:08 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a213d425d87a

8015329: Print reason for failed MiniDumpWriteDump() call
Summary: Printing both result from GetLastError and text representation of error. Also changed so that we produce dumps by default on client versions of Windows when running with a debug build. Also reviewed by peter.allwin at oracle.com
Reviewed-by: sla, dholmes

! src/os/windows/vm/os_windows.cpp

Changeset: 51af5fae397d
Author:    ccheung
Date:      2013-05-24 17:19 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/51af5fae397d

8015265: revise the fix for 8007037
Reviewed-by: sspitsyn, dholmes, dcubed

! src/share/vm/oops/constantPool.cpp

Changeset: 4cc7d4d5dc92
Author:    zgu
Date:      2013-05-28 08:54 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/4cc7d4d5dc92

Merge


Changeset: 01c2bdd24bb5
Author:    shade
Date:      2013-05-28 19:54 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/01c2bdd24bb5

8015493: runtime/contended/OopMaps.java fails with OutOfMemory
Summary: limit the memory footprint to dodge OutOfMemory errors.
Reviewed-by: dcubed, ctornqvi, iignatyev

! test/runtime/contended/OopMaps.java

Changeset: 9ea643afcaaf
Author:    dcubed
Date:      2013-05-28 11:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/9ea643afcaaf

Merge



From zhengyu.gu at oracle.com  Wed May 29 12:23:24 2013
From: zhengyu.gu at oracle.com (Zhengyu Gu)
Date: Wed, 29 May 2013 15:23:24 -0400
Subject: review request -- JDK-8011064 Some tests have failed with SIGSEGV
	on arm-hflt on build b82
In-Reply-To: <51A56D00.60501@oracle.com>
References: <519A78F4.4010909@oracle.com> <519A9D5B.7060705@oracle.com>
	<519BB59E.3020801@oracle.com> <519BD13B.8030502@oracle.com>
	<519C4D01.40900@oracle.com> <519CE166.7050204@oracle.com>
	<51A4C4FB.9040100@oracle.com> <51A56D00.60501@oracle.com>
Message-ID: <51A655AC.3040703@oracle.com>

Good to me too.

Thanks,

-Zhengyu

On 5/28/2013 10:50 PM, David Holmes wrote:
> Good to go - thanks Joe!
>
> David
>
> On 29/05/2013 12:53 AM, JOSEPH PROVINO wrote:
>> Latest webrev is here:
>> http://cr.openjdk.java.net/~jprovino/8011064/webrev.03
>>
>> I added a comment that David Holmes suggested.
>>
>> joe
>>
>> On 5/22/2013 11:16 AM, JOSEPH PROVINO wrote:
>>> Latest webrev is here:
>>> http://cr.openjdk.java.net/~jprovino/8011064/webrev.02
>>>
>>> joe
>>>
>>>
>>> On 5/22/2013 12:43 AM, David Holmes wrote:
>>>> Just for the benefit of others watching this, the undef approach is
>>>> not ideal and there's another alternative in the pipeline.
>>>>
>>>> David
>>>>
>>>> On 22/05/2013 5:55 AM, JOSEPH PROVINO wrote:
>>>>> New webrev is here:
>>>>>
>>>>> http://cr.openjdk.java.net/~jprovino/8011064/webrev.01/
>>>>>
>>>>> joe
>>>>>
>>>>> On 5/21/2013 1:57 PM, JOSEPH PROVINO wrote:
>>>>>> That's a good solution.  Is there any reason NMT_detail_supported
>>>>>> can't be made const or
>>>>>> better yet eliminate the variable and just use if
>>>>>> (PLATFORM_NMT_DETAIL_SUPPORTED) ?
>>>>>>
>>>>>> joe
>>>>>>
>>>>>> On 5/20/2013 6:02 PM, BILL PITTORE wrote:
>>>>>>>  Maybe something like I did for SUPPORTS_NATIVE_CX8. This gets
>>>>>>> defined in globalDefinitions_<cpu>.hpp.
>>>>>>> In this situation maybe something like:
>>>>>>>
>>>>>>> memTracker.cpp
>>>>>>>   bool NMT_detail_supported = PLATFORM_NMT_DETAIL_SUPPORTED;
>>>>>>>
>>>>>>> then in globalDefinitions_<cpu>.hpp
>>>>>>>
>>>>>>> #define PLATFORM_NMT_DETAIL_SUPPORTED {true | false} as the case
>>>>>>> may be.
>>>>>>>
>>>>>>> Then you eliminate the need to add code to pd_initialize()
>>>>>>>
>>>>>>> bill
>>>>>>>
>>>>>>> On 5/20/2013 3:26 PM, JOSEPH PROVINO wrote:
>>>>>>>> Make it easy to disable NMT detail in platform specific code.
>>>>>>>>
>>>>>>>> A new variable NMT_detail_supported is defined and set to true.
>>>>>>>> It can be disabled in platform specific code as needed.
>>>>>>>>
>>>>>>>> Webrev is here: 
>>>>>>>> http://cr.openjdk.java.net/~jprovino/8011064/webrev/
>>>>>>>>
>>>>>>>> JDK-8011064 <https://jbs.oracle.com/bugs/browse/JDK-8011064>Some
>>>>>>>> tests have failed with SIGSEGV on arm-hflt on build b82
>>>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8011064>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>
>>


From maurizio.cimadamore at oracle.com  Wed May 29 04:25:19 2013
From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore)
Date: Wed, 29 May 2013 12:25:19 +0100
Subject: Class verifier issues with unboxing method handles
In-Reply-To: <51A55E5E.4020605@oracle.com>
References: <51A5543B.10506@talios.com> <51A55E5E.4020605@oracle.com>
Message-ID: <51A5E59F.9040007@oracle.com>

David, Mark,
a minimal test case to reproduce the issue is this:

interface IntFunction<X> {
    int m(X x);
}

class Test {
    public static void main(String[] args) {
       IntFunction<String> s = Integer::new;
    }
}


Looking at the javap output, in particular at the indy call details, we 
find this:

BootstrapMethods:
     0: #15 invokestatic 
java/lang/invoke/LambdaMetafactory.metaFactory:(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;Ljava/lang/invoke/MethodHandle;Ljava/lang/invoke/MethodHandle;Ljava/lang/invoke/MethodType;)Ljava/lang/invoke/CallSite;
       Method arguments:
         #16 invokeinterface IntFunction.m:(Ljava/lang/Object;)I
         #17 newinvokespecial 
java/lang/Integer."<init>":(Ljava/lang/String;)V
         #18 (Ljava/lang/String;)I


This seems correct; however, judging from the runtime error, it seems 
like the metafactory is not unboxing the Integer instance back to int 
(which is the expected return value of the implemented method). Hence 
the 292 link failure. Robert, Brian can you confirm?

Maurizio


On 29/05/13 02:48, David Holmes wrote:
> Hi Mark,
>
> cc'ing lambda-dev. This may be a bug, a version mismatch, or something
> else. The lambda-dev folk will know.
>
> David
>
> On 29/05/2013 11:04 AM, Mark Derricutt wrote:
>> Hi all,
>>
>> Mark Reinhold suggested I posted this question/bug report to hotspot-dev
>> rather than jdk8-dev so here goes.
>>
>> I have a fairly simple test case using the new streams API:
>>
>> public static void main(String[] args) {
>> List<String> strings = Arrays.asList("1", "2", "3", "4", "5");
>>     strings.stream()
>> .mapToInt(s -> new Integer(s))
>> .forEach(i -> System.out.println(String.format("int %d", i)));
>> }
>>
>>
>> which compiles, runs, and prints out what I expect:
>>
>> int 1
>> int 2
>> int 3
>> int 4
>> int 5
>>
>>
>> Given that mapToInt() is returning an IntegerStream wrapping primitive
>> ints, the result of my closure is successfully autoboxed down to an int
>> and all is happy with the world.
>>
>> If I change this code to be:
>>
>>     strings.stream()
>>            .mapToInt(Integer::parseInt)
>>            .forEach(i -> System.out.println(String.format("int %d", i)));
>>
>> Again, everything works as expected as Integer::parseInt returns an int,
>> so there's no boxing.
>>
>> Changing this once again to:
>>
>>     strings.stream()
>>            .mapToInt(Integer::valueOf)
>>            .forEach(i -> System.out.println(String.format("int %d", i)));
>>
>> I also see the expected result, Integer::valueOf returns an Integer
>> which is then being boxed down to an int.
>>
>> However, if I change the code to:
>>
>>    strings.stream()
>>           .mapToInt(Integer::new)
>>           .forEach(i -> System.out.println(String.format("int %d", i)));
>>
>> which, if I understand correctly - Integer::new should be returning a
>> method handle to the constructor. IntelliJ IDEA 13 autocompletes this
>> for me, and hyperlinks to the Integer(String s) constructor, javac
>> successfully compiles the code so my -assumption- is that the
>> constructor would be called, returning an Integer which is then boxed
>> down to an int, however, this is what I get:
>>
>> Exception in thread "main" java.lang.BootstrapMethodError: call site
>> initialization exception
>>       at java.lang.invoke.CallSite.makeSite(CallSite.java:298)
>>       at
>> java.lang.invoke.MethodHandleNatives.linkCallSite(MethodHandleNatives.java:294)
>>
>>       at com.talios.test.TestJdk.main(TestJdk.java:12)
>>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>       at
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>>
>>       at
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>>
>>       at java.lang.reflect.Method.invoke(Method.java:491)
>>       at
>> com.intellij.rt.execution.application.AppMain.main(AppMain.java:120)
>> Caused by: java.lang.VerifyError: Bad type on operand stack
>> Exception Details:
>>     Location:
>>       com/talios/test/TestJdk$$Lambda$1.applyAsInt(Ljava/lang/Object;)I
>> @11: ireturn
>>     Reason:
>>       Type 'java/lang/Integer' (current frame, stack[0]) is not
>> assignable to integer
>>     Current Frame:
>>       bci: @11
>>       flags: { }
>>       locals: { 'com/talios/test/TestJdk$$Lambda$1', 'java/lang/Object' }
>>       stack: { 'java/lang/Integer' }
>>     Bytecode:
>>       0000000: bb00 0e59 2bc0 0010 b700 13ac
>>
>>       at java.lang.Class.getDeclaredConstructors0(Native Method)
>>       at java.lang.Class.privateGetDeclaredConstructors(Class.java:2536)
>>       at java.lang.Class.getDeclaredConstructors(Class.java:1928)
>>       at
>> java.lang.invoke.InnerClassLambdaMetafactory$1.run(InnerClassLambdaMetafactory.java:147)
>>
>>       at
>> java.lang.invoke.InnerClassLambdaMetafactory$1.run(InnerClassLambdaMetafactory.java:144)
>>
>>       at java.security.AccessController.doPrivileged(Native Method)
>>       at
>> java.lang.invoke.InnerClassLambdaMetafactory.buildCallSite(InnerClassLambdaMetafactory.java:143)
>>
>>       at
>> java.lang.invoke.LambdaMetafactory.metaFactory(LambdaMetafactory.java:191)
>>       at java.lang.invoke.CallSite.makeSite(CallSite.java:283)
>>       ... 7 more
>>
>> This is on OSX Mountain Lion, with JDK 8 Build 91.
>>
>> Have I walked in an obscure corner case of method handle breakage and
>> found something new, or is this a new problem?
>>
>> Cheers,
>> Mark
>>


From vladimir.danushevsky at oracle.com  Wed May 29 15:35:44 2013
From: vladimir.danushevsky at oracle.com (vladimir.danushevsky at oracle.com)
Date: Wed, 29 May 2013 22:35:44 +0000
Subject: hg: hsx/hsx24/hotspot: 2 new changesets
Message-ID: <20130529223553.4538E48E06@hg.openjdk.java.net>

Changeset: 851f1e0cef3c
Author:    vladidan
Date:      2013-04-30 17:36 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/851f1e0cef3c

8013398: Adjust number of stack guard pages on systems with large memory page size
Summary: Auto adjust number of stack guard pages on systems with large memory page size
Reviewed-by: bobv, coleenp

! src/os/linux/vm/os_linux.cpp
! src/os/linux/vm/os_linux.hpp

Changeset: e9cab25ca15e
Author:    vladidan
Date:      2013-05-29 16:12 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/e9cab25ca15e

Merge



From vladimir.kozlov at oracle.com  Wed May 29 19:41:21 2013
From: vladimir.kozlov at oracle.com (vladimir.kozlov at oracle.com)
Date: Thu, 30 May 2013 02:41:21 +0000
Subject: hg: hsx/hsx24/hotspot: 2 new changesets
Message-ID: <20130530024131.1CA4348E11@hg.openjdk.java.net>

Changeset: 1a7a04b4e45f
Author:    kvn
Date:      2013-05-22 09:02 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/1a7a04b4e45f

8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
Summary: Stop current iteration of loop opts if partial_peel() failed and it created node clones outside processed loop.
Reviewed-by: roland

! src/share/vm/opto/loopnode.hpp
! src/share/vm/opto/loopopts.cpp

Changeset: 6250a3d948df
Author:    kvn
Date:      2013-05-22 18:25 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/6250a3d948df

8010927: Kitchensink crashed with SIGSEGV, Problematic frame: v ~StubRoutines::checkcast_arraycopy
Summary: Changed gen_write_ref_array_post_barrier() code on x64 to pass start address and number of copied oop elements. In generate_checkcast_copy() skip post barrier code if no elements are copied.
Reviewed-by: roland

! src/cpu/x86/vm/stubGenerator_x86_32.cpp
! src/cpu/x86/vm/stubGenerator_x86_64.cpp
+ test/compiler/8010927/Test8010927.java


From serguei.spitsyn at oracle.com  Wed May 29 21:08:45 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Wed, 29 May 2013 21:08:45 -0700
Subject: Review Request (S) 8015436: compiler/ciReplay/TestSA.sh fails with
	assert() index is out of bounds
Message-ID: <51A6D0CD.1000503@oracle.com>

Please, review the fix and unit test for:
   bug: http://bugs.sun.com/view_bug.do?bug_id=8015436
   jbs:  https://jbs.oracle.com/bugs/browse/JDK-8015436

Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8015436-JVMTI-JSR292.1

Summary:
   The InstanceKlass _initial_method_idnum value must be adjusted as 
necessary if the overpass methods are added.
   I guess, it is Ok to integrate a unit test covering the fix under the 
same bug id.

Testing:
   Newly added hotspot unit test: compiler/8015436/Test8015436.java
   The originally failed test:    compiler/ciReplay/TestSA.sh
   The vm/mlvm tests

Thanks,
Serguei

From christian.thalinger at oracle.com  Thu May 30 08:41:11 2013
From: christian.thalinger at oracle.com (Christian Thalinger)
Date: Thu, 30 May 2013 08:41:11 -0700
Subject: Review Request (S) 8015436: compiler/ciReplay/TestSA.sh fails
	with assert() index is out of bounds
In-Reply-To: <51A6D0CD.1000503@oracle.com>
References: <51A6D0CD.1000503@oracle.com>
Message-ID: <F09425EA-8F0B-425A-9E7D-ACC87E4B0F36@oracle.com>

Looks good.  -- Chris

On May 29, 2013, at 9:08 PM, serguei.spitsyn at oracle.com wrote:

> Please, review the fix and unit test for:
>  bug: http://bugs.sun.com/view_bug.do?bug_id=8015436
>  jbs:  https://jbs.oracle.com/bugs/browse/JDK-8015436
> 
> Open webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8015436-JVMTI-JSR292.1
> 
> Summary:
>  The InstanceKlass _initial_method_idnum value must be adjusted as necessary if the overpass methods are added.
>  I guess, it is Ok to integrate a unit test covering the fix under the same bug id.
> 
> Testing:
>  Newly added hotspot unit test: compiler/8015436/Test8015436.java
>  The originally failed test:    compiler/ciReplay/TestSA.sh
>  The vm/mlvm tests
> 
> Thanks,
> Serguei


From serguei.spitsyn at oracle.com  Thu May 30 10:29:23 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Thu, 30 May 2013 10:29:23 -0700
Subject: Review Request (S) 8015436: compiler/ciReplay/TestSA.sh fails
	with assert() index is out of bounds
In-Reply-To: <F09425EA-8F0B-425A-9E7D-ACC87E4B0F36@oracle.com>
References: <51A6D0CD.1000503@oracle.com>
	<F09425EA-8F0B-425A-9E7D-ACC87E4B0F36@oracle.com>
Message-ID: <51A78C73.20109@oracle.com>


Thanks, Chris!
Serguei

On 5/30/13 8:41 AM, Christian Thalinger wrote:
> Looks good.  -- Chris
>
> On May 29, 2013, at 9:08 PM, serguei.spitsyn at oracle.com wrote:
>
>> Please, review the fix and unit test for:
>>   bug: http://bugs.sun.com/view_bug.do?bug_id=8015436
>>   jbs:  https://jbs.oracle.com/bugs/browse/JDK-8015436
>>
>> Open webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8015436-JVMTI-JSR292.1
>>
>> Summary:
>>   The InstanceKlass _initial_method_idnum value must be adjusted as necessary if the overpass methods are added.
>>   I guess, it is Ok to integrate a unit test covering the fix under the same bug id.
>>
>> Testing:
>>   Newly added hotspot unit test: compiler/8015436/Test8015436.java
>>   The originally failed test:    compiler/ciReplay/TestSA.sh
>>   The vm/mlvm tests
>>
>> Thanks,
>> Serguei


From vladimir.kozlov at oracle.com  Thu May 30 11:10:51 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Thu, 30 May 2013 11:10:51 -0700
Subject: Review Request (S) 8015436: compiler/ciReplay/TestSA.sh fails
	with assert() index is out of bounds
In-Reply-To: <51A78C73.20109@oracle.com>
References: <51A6D0CD.1000503@oracle.com>
	<F09425EA-8F0B-425A-9E7D-ACC87E4B0F36@oracle.com>
	<51A78C73.20109@oracle.com>
Message-ID: <51A7962B.10308@oracle.com>

Sergey,

The fix is good.

You don't need to show the failure output in the test sources since you 
have bugid in it.

Also you don't need /othervm if you don't have command line flags.

Vladimir

On 5/30/13 10:29 AM, serguei.spitsyn at oracle.com wrote:
>
> Thanks, Chris!
> Serguei
>
> On 5/30/13 8:41 AM, Christian Thalinger wrote:
>> Looks good.  -- Chris
>>
>> On May 29, 2013, at 9:08 PM, serguei.spitsyn at oracle.com wrote:
>>
>>> Please, review the fix and unit test for:
>>>   bug: http://bugs.sun.com/view_bug.do?bug_id=8015436
>>>   jbs:  https://jbs.oracle.com/bugs/browse/JDK-8015436
>>>
>>> Open webrev:
>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8015436-JVMTI-JSR292.1
>>>
>>>
>>> Summary:
>>>   The InstanceKlass _initial_method_idnum value must be adjusted as
>>> necessary if the overpass methods are added.
>>>   I guess, it is Ok to integrate a unit test covering the fix under
>>> the same bug id.
>>>
>>> Testing:
>>>   Newly added hotspot unit test: compiler/8015436/Test8015436.java
>>>   The originally failed test:    compiler/ciReplay/TestSA.sh
>>>   The vm/mlvm tests
>>>
>>> Thanks,
>>> Serguei
>

From serguei.spitsyn at oracle.com  Thu May 30 11:18:04 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Thu, 30 May 2013 11:18:04 -0700
Subject: Review Request (S) 8015436: compiler/ciReplay/TestSA.sh fails
	with assert() index is out of bounds
In-Reply-To: <51A7962B.10308@oracle.com>
References: <51A6D0CD.1000503@oracle.com>
	<F09425EA-8F0B-425A-9E7D-ACC87E4B0F36@oracle.com>
	<51A78C73.20109@oracle.com> <51A7962B.10308@oracle.com>
Message-ID: <51A797DC.10109@oracle.com>

Hi Vladimir,

Thank you for the review!
I'll update the test according to your suggestion before the push.

Thanks,
Serguei

On 5/30/13 11:10 AM, Vladimir Kozlov wrote:
> Sergey,
>
> The fix is good.
>
> You don't need to show the failure output in the test sources since 
> you have bugid in it.
>
> Also you don't need /othervm if you don't have command line flags.
>
> Vladimir
>
> On 5/30/13 10:29 AM, serguei.spitsyn at oracle.com wrote:
>>
>> Thanks, Chris!
>> Serguei
>>
>> On 5/30/13 8:41 AM, Christian Thalinger wrote:
>>> Looks good.  -- Chris
>>>
>>> On May 29, 2013, at 9:08 PM, serguei.spitsyn at oracle.com wrote:
>>>
>>>> Please, review the fix and unit test for:
>>>>   bug: http://bugs.sun.com/view_bug.do?bug_id=8015436
>>>>   jbs:  https://jbs.oracle.com/bugs/browse/JDK-8015436
>>>>
>>>> Open webrev:
>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8015436-JVMTI-JSR292.1 
>>>>
>>>>
>>>>
>>>> Summary:
>>>>   The InstanceKlass _initial_method_idnum value must be adjusted as
>>>> necessary if the overpass methods are added.
>>>>   I guess, it is Ok to integrate a unit test covering the fix under
>>>> the same bug id.
>>>>
>>>> Testing:
>>>>   Newly added hotspot unit test: compiler/8015436/Test8015436.java
>>>>   The originally failed test:    compiler/ciReplay/TestSA.sh
>>>>   The vm/mlvm tests
>>>>
>>>> Thanks,
>>>> Serguei
>>


From jiangli.zhou at oracle.com  Thu May 30 21:05:07 2013
From: jiangli.zhou at oracle.com (jiangli.zhou at oracle.com)
Date: Fri, 31 May 2013 04:05:07 +0000
Subject: hg: hsx/hotspot-main/hotspot: 4 new changesets
Message-ID: <20130531040519.176D748E40@hg.openjdk.java.net>

Changeset: dcb062bea05b
Author:    jprovino
Date:      2013-05-28 11:17 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/dcb062bea05b

8013461: There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release
Summary: AsyncGetCallTrace is needed in libjvm.symbols so that programs which reference it can build correctly.
Reviewed-by: dholmes, bobv

! make/excludeSrc.make
! src/share/vm/prims/forte.cpp

Changeset: fb14e9ed1594
Author:    jprovino
Date:      2013-05-28 11:32 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/fb14e9ed1594

8011064: Some tests have failed with SIGSEGV on arm-hflt on build b82
Summary: NMT_detail is only supported when frame pointers are not omitted (-fno-omit-frame-pointer).
Reviewed-by: dholmes, cjplummer

! src/share/vm/services/memTracker.cpp
! src/share/vm/utilities/globalDefinitions.hpp

Changeset: 9e954e8d9139
Author:    jprovino
Date:      2013-05-28 15:24 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/9e954e8d9139

Merge


Changeset: 9e86c5544295
Author:    jiangli
Date:      2013-05-30 13:19 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/9e86c5544295

Merge



From serguei.spitsyn at oracle.com  Thu May 30 23:19:25 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Thu, 30 May 2013 23:19:25 -0700
Subject: Review Request (S) 8014052: JSR292: assert(end_offset == next_offset)
	failed: matched ending
Message-ID: <51A840ED.7030501@oracle.com>

Please, review the fix for:
   bug: https://jbs.oracle.com/bugs/browse/JDK-8014052
   jbs: https://jbs.oracle.com/bugs/browse/JDK-8014052


Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014052-JVMTI-JSR292.1

Summary:
   A call to the finalize_operands_merge() must be unconditional.
   Otherwise, the merge of the bootstrap method operands is not 
completed correctly.


Testing: vm/mlvm, nsk/jvmti, nsk/jdi, nsk/jdwp

Thanks,
Serguei

From john.coomes at oracle.com  Fri May 31 01:31:47 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 31 May 2013 08:31:47 +0000
Subject: hg: hsx/hotspot-main/corba: Added tag jdk8-b92 for changeset
	717aa26f8e0a
Message-ID: <20130531083150.5A82448E55@hg.openjdk.java.net>

Changeset: 8dc9d7ccbb2d
Author:    katleman
Date:      2013-05-30 10:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/corba/rev/8dc9d7ccbb2d

Added tag jdk8-b92 for changeset 717aa26f8e0a

! .hgtags


From john.coomes at oracle.com  Fri May 31 01:32:08 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 31 May 2013 08:32:08 +0000
Subject: hg: hsx/hotspot-main/jaxws: Added tag jdk8-b92 for changeset
	a0f604766ca1
Message-ID: <20130531083215.656D848E57@hg.openjdk.java.net>

Changeset: 7386eca865e1
Author:    katleman
Date:      2013-05-30 10:58 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxws/rev/7386eca865e1

Added tag jdk8-b92 for changeset a0f604766ca1

! .hgtags


From john.coomes at oracle.com  Fri May 31 01:31:44 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 31 May 2013 08:31:44 +0000
Subject: hg: hsx/hotspot-main: 4 new changesets
Message-ID: <20130531083144.7EFD348E54@hg.openjdk.java.net>

Changeset: e247ee3924d5
Author:    erikj
Date:      2013-05-22 17:26 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/e247ee3924d5

8014514: Fix jvm args for sjavac
Reviewed-by: tbell

! common/autoconf/basics.m4
! common/autoconf/build-performance.m4
! common/autoconf/generated-configure.sh

Changeset: e7c09a983c3c
Author:    erikj
Date:      2013-05-28 08:50 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/e7c09a983c3c

8007129: build-infra Add configure --with-jtreg option for location of JTREG
Reviewed-by: tbell

! common/autoconf/basics.m4
! common/autoconf/generated-configure.sh
! common/autoconf/spec.gmk.in
! common/autoconf/toolchain.m4

Changeset: 3a36c926a7aa
Author:    katleman
Date:      2013-05-28 17:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/3a36c926a7aa

Merge


Changeset: 46be9eb242d1
Author:    katleman
Date:      2013-05-30 10:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/rev/46be9eb242d1

Added tag jdk8-b92 for changeset 3a36c926a7aa

! .hgtags


From john.coomes at oracle.com  Fri May 31 01:31:54 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 31 May 2013 08:31:54 +0000
Subject: hg: hsx/hotspot-main/jaxp: 2 new changesets
Message-ID: <20130531083205.039B548E56@hg.openjdk.java.net>

Changeset: 1ab5d8d6eab8
Author:    katleman
Date:      2013-05-29 10:15 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/1ab5d8d6eab8

8015525: JDK8 b91 source with GPL header errors
Reviewed-by: dholmes, lancea

! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java

Changeset: a6596a06e10b
Author:    katleman
Date:      2013-05-30 10:58 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jaxp/rev/a6596a06e10b

Added tag jdk8-b92 for changeset 1ab5d8d6eab8

! .hgtags


From john.coomes at oracle.com  Fri May 31 01:32:24 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 31 May 2013 08:32:24 +0000
Subject: hg: hsx/hotspot-main/jdk: 2 new changesets
Message-ID: <20130531083350.66F5A48E59@hg.openjdk.java.net>

Changeset: a2a2a91075ad
Author:    katleman
Date:      2013-05-29 10:16 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/a2a2a91075ad

8015525: JDK8 b91 source with GPL header errors
Reviewed-by: dholmes, lancea

! test/java/util/stream/test/org/openjdk/tests/java/util/FillableStringTest.java
! test/java/util/stream/test/org/openjdk/tests/java/util/MapTest.java
! test/jdk/lambda/MethodReferenceTestInstanceMethod.java
! test/jdk/lambda/MethodReferenceTestKinds.java
! test/jdk/lambda/MethodReferenceTestSueCase1.java
! test/jdk/lambda/MethodReferenceTestSueCase2.java
! test/jdk/lambda/MethodReferenceTestSueCase4.java
! test/jdk/lambda/separate/AttributeInjector.java
! test/jdk/lambda/separate/ClassFile.java
! test/jdk/lambda/separate/ClassFilePreprocessor.java
! test/jdk/lambda/separate/ClassToInterfaceConverter.java
! test/jdk/lambda/separate/Compiler.java
! test/jdk/lambda/separate/DirectedClassLoader.java
! test/jdk/lambda/separate/SourceModel.java
! test/jdk/lambda/separate/TestHarness.java
! test/jdk/lambda/vm/DefaultMethodRegressionTests.java
! test/jdk/lambda/vm/DefaultMethodsTest.java
! test/jdk/lambda/vm/InterfaceAccessFlagsTest.java

Changeset: 3c08c9ebd1fb
Author:    katleman
Date:      2013-05-30 10:58 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/jdk/rev/3c08c9ebd1fb

Added tag jdk8-b92 for changeset a2a2a91075ad

! .hgtags


From john.coomes at oracle.com  Fri May 31 01:34:49 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 31 May 2013 08:34:49 +0000
Subject: hg: hsx/hotspot-main/langtools: 4 new changesets
Message-ID: <20130531083508.85C7748E5A@hg.openjdk.java.net>

Changeset: 58eace4d997f
Author:    erikj
Date:      2013-05-28 08:49 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/58eace4d997f

8012566: Replace find, rm, printf and similar with their proper variables
Reviewed-by: tbell

! makefiles/BuildLangtools.gmk

Changeset: 3597773628a4
Author:    katleman
Date:      2013-05-28 17:58 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/3597773628a4

Merge


Changeset: 149890642a0e
Author:    katleman
Date:      2013-05-29 10:16 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/149890642a0e

8015525: JDK8 b91 source with GPL header errors
Reviewed-by: dholmes, lancea

! test/tools/javac/annotations/typeAnnotations/classfile/TestNewCastArray.java

Changeset: 023e9a614d26
Author:    katleman
Date:      2013-05-30 10:58 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/langtools/rev/023e9a614d26

Added tag jdk8-b92 for changeset 149890642a0e

! .hgtags


From john.coomes at oracle.com  Fri May 31 01:35:12 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 31 May 2013 08:35:12 +0000
Subject: hg: hsx/hotspot-main/nashorn: Added tag jdk8-b92 for changeset
	dee23cce5235
Message-ID: <20130531083514.D114148E5B@hg.openjdk.java.net>

Changeset: 1c7481ac7fe0
Author:    katleman
Date:      2013-05-30 10:58 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/nashorn/rev/1c7481ac7fe0

Added tag jdk8-b92 for changeset dee23cce5235

! .hgtags


From jesper.wilhelmsson at oracle.com  Fri May 31 03:10:09 2013
From: jesper.wilhelmsson at oracle.com (jesper.wilhelmsson at oracle.com)
Date: Fri, 31 May 2013 10:10:09 +0000
Subject: hg: hsx/hotspot-main/hotspot: 7 new changesets
Message-ID: <20130531101034.8BC9548E7B@hg.openjdk.java.net>

Changeset: 0def34ab1c98
Author:    tamao
Date:      2013-05-21 16:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/0def34ab1c98

8015007: Incorrect print format in error message for VM cannot allocate the requested heap
Summary: Correct the wrong print format in error message for VM cannot allocate the requested heap; and clean up the error message call in check_alignment()
Reviewed-by: brutisso, tschatzl
Contributed-by: tamao <tao.mao at oracle.com>

! src/share/vm/memory/universe.cpp

Changeset: 14d3f71f831d
Author:    tamao
Date:      2013-05-22 11:11 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/14d3f71f831d

8007762: Rename a bunch of methods in size policy across collectors
Summary: Rename: compute_generations_free_space() = compute_eden_space_size() + compute_old_gen_free_space(); update related logging messages
Reviewed-by: jmasa, johnc, tschatzl, brutisso
Contributed-by: tamao <tao.mao at oracle.com>

! src/share/vm/gc_implementation/concurrentMarkSweep/cmsAdaptiveSizePolicy.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/cmsAdaptiveSizePolicy.hpp
! src/share/vm/gc_implementation/parNew/asParNewGeneration.cpp
! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp
! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.hpp
! src/share/vm/gc_implementation/parallelScavenge/psGCAdaptivePolicyCounters.hpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.cpp

Changeset: 0886b99a4d1b
Author:    jwilhelm
Date:      2013-05-24 14:16 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/0886b99a4d1b

Merge


Changeset: eda078b01c65
Author:    stefank
Date:      2013-05-27 15:22 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/eda078b01c65

8015268: NPG: 2.5% regression in young GC times on CRM Sales Opty
Summary: Split SystemDictionary and ClassLoaderDataGraph root processing to help load balancing.
Reviewed-by: tschatzl, johnc

! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp
! src/share/vm/gc_implementation/parallelScavenge/pcTasks.hpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp
! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp
! src/share/vm/gc_implementation/parallelScavenge/psTasks.hpp
! src/share/vm/memory/sharedHeap.cpp

Changeset: 95c00927be11
Author:    stefank
Date:      2013-05-27 12:56 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/95c00927be11

8015428: Remove unused CDS support from StringTable
Summary: The string in StringTable is not used by CDS anymore. Remove the unnecessary code in preparation for 8015422: Large performance hit when the StringTable is walked twice in Parallel Scavenge
Reviewed-by: pliden, tschatzl, coleenp

! src/share/vm/classfile/symbolTable.cpp

Changeset: 8dbc025ff709
Author:    stefank
Date:      2013-05-27 12:58 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/8dbc025ff709

8015422: Large performance hit when the StringTable is walked twice in Parallel Scavenge
Summary: Combine the calls to StringTable::unlink and StringTable::oops_do in Parallel Scavenge.
Reviewed-by: pliden, coleenp

! src/share/vm/classfile/symbolTable.cpp
! src/share/vm/classfile/symbolTable.hpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp

Changeset: f41a577cffb0
Author:    jwilhelm
Date:      2013-05-31 09:55 +0200
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/f41a577cffb0

Merge



From stefan.karlsson at oracle.com  Fri May 31 04:01:58 2013
From: stefan.karlsson at oracle.com (Stefan Karlsson)
Date: Fri, 31 May 2013 13:01:58 +0200
Subject: RFR (XS): 8014709  Constructor.getAnnotatedReturnType() returns
	empty AnnotatedType
In-Reply-To: <20130528131010.GA25459@jfranck-desktop.jrpg.bea.com>
References: <20130528131010.GA25459@jfranck-desktop.jrpg.bea.com>
Message-ID: <51A88326.3070808@oracle.com>

Looks good to me.

StefanK

On 05/28/2013 03:10 PM, Joel Borggren-Franck wrote:
> Hi
>
> Please review this fix and test update for 8014709:
> Constructor.getAnnotatedReturnType() returns empty AnnotatedType.
>
> When implementing VM support for reflection for type annotations I
> forgot to store the type annotation byte array on
> java.lang.reflect.Constructor objects. This is a fix and a test update
> to address this.
>
> Modified test fails with an old HotSpot passes with the fix.
>
> This bug was found in internal testing that also passes with the fix.
>
> Webrev: http://cr.openjdk.java.net/~jfranck/8014709/webrev.00/
>
> cheers
> /Joel


From rickard.backman at oracle.com  Fri May 31 03:59:52 2013
From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=)
Date: Fri, 31 May 2013 12:59:52 +0200
Subject: RFR (XS): 8014709 Constructor.getAnnotatedReturnType() returns
	empty AnnotatedType
In-Reply-To: <20130528131010.GA25459@jfranck-desktop.jrpg.bea.com>
References: <20130528131010.GA25459@jfranck-desktop.jrpg.bea.com>
Message-ID: <64DE597F-DF7D-4EA0-A38F-42D1928ECBA8@oracle.com>

Looks good!

I can sponsor the change if we get a Reviewer.

/R

On May 28, 2013, at 3:10 PM, Joel Borggren-Franck wrote:

> Hi
> 
> Please review this fix and test update for 8014709:
> Constructor.getAnnotatedReturnType() returns empty AnnotatedType.
> 
> When implementing VM support for reflection for type annotations I
> forgot to store the type annotation byte array on
> java.lang.reflect.Constructor objects. This is a fix and a test update
> to address this.
> 
> Modified test fails with an old HotSpot passes with the fix.
> 
> This bug was found in internal testing that also passes with the fix.
> 
> Webrev: http://cr.openjdk.java.net/~jfranck/8014709/webrev.00/
> 
> cheers
> /Joel


From joel.franck at oracle.com  Fri May 31 06:42:43 2013
From: joel.franck at oracle.com (Joel Borggren-Franck)
Date: Fri, 31 May 2013 15:42:43 +0200
Subject: RFR (XS): 8014709  Constructor.getAnnotatedReturnType() returns
	empty AnnotatedType
In-Reply-To: <64DE597F-DF7D-4EA0-A38F-42D1928ECBA8@oracle.com>
References: <20130528131010.GA25459@jfranck-desktop.jrpg.bea.com>
	<64DE597F-DF7D-4EA0-A38F-42D1928ECBA8@oracle.com>
Message-ID: <20130531134243.GE23367@jfranck-desktop.jrpg.bea.com>

Thanks Rickard!

cheers
/Joel

On 2013-05-31, Rickard B?ckman wrote:
> Looks good!
> 
> I can sponsor the change if we get a Reviewer.
> 
> /R
> 
> On May 28, 2013, at 3:10 PM, Joel Borggren-Franck wrote:
> 
> > Hi
> > 
> > Please review this fix and test update for 8014709:
> > Constructor.getAnnotatedReturnType() returns empty AnnotatedType.
> > 
> > When implementing VM support for reflection for type annotations I
> > forgot to store the type annotation byte array on
> > java.lang.reflect.Constructor objects. This is a fix and a test update
> > to address this.
> > 
> > Modified test fails with an old HotSpot passes with the fix.
> > 
> > This bug was found in internal testing that also passes with the fix.
> > 
> > Webrev: http://cr.openjdk.java.net/~jfranck/8014709/webrev.00/
> > 
> > cheers
> > /Joel
> 

From joel.franck at oracle.com  Fri May 31 06:44:05 2013
From: joel.franck at oracle.com (Joel Borggren-Franck)
Date: Fri, 31 May 2013 15:44:05 +0200
Subject: RFR (XS): 8014709  Constructor.getAnnotatedReturnType() returns
	empty AnnotatedType
In-Reply-To: <51A88326.3070808@oracle.com>
References: <20130528131010.GA25459@jfranck-desktop.jrpg.bea.com>
	<51A88326.3070808@oracle.com>
Message-ID: <20130531134405.GF23367@jfranck-desktop.jrpg.bea.com>

Thanks for the review Stefan

cheers
/Joel

On 2013-05-31, Stefan Karlsson wrote:
> Looks good to me.
> 
> StefanK
> 
> On 05/28/2013 03:10 PM, Joel Borggren-Franck wrote:
> >Hi
> >
> >Please review this fix and test update for 8014709:
> >Constructor.getAnnotatedReturnType() returns empty AnnotatedType.
> >
> >When implementing VM support for reflection for type annotations I
> >forgot to store the type annotation byte array on
> >java.lang.reflect.Constructor objects. This is a fix and a test update
> >to address this.
> >
> >Modified test fails with an old HotSpot passes with the fix.
> >
> >This bug was found in internal testing that also passes with the fix.
> >
> >Webrev: http://cr.openjdk.java.net/~jfranck/8014709/webrev.00/
> >
> >cheers
> >/Joel
> 

From vladimir.kozlov at oracle.com  Fri May 31 10:03:55 2013
From: vladimir.kozlov at oracle.com (Vladimir Kozlov)
Date: Fri, 31 May 2013 10:03:55 -0700
Subject: Review Request (S) 8014052: JSR292: assert(end_offset ==
	next_offset) failed: matched ending
In-Reply-To: <51A840ED.7030501@oracle.com>
References: <51A840ED.7030501@oracle.com>
Message-ID: <51A8D7FB.1070906@oracle.com>

Good.

Vladimir

On 5/30/13 11:19 PM, serguei.spitsyn at oracle.com wrote:
> Please, review the fix for:
>    bug: https://jbs.oracle.com/bugs/browse/JDK-8014052
>    jbs: https://jbs.oracle.com/bugs/browse/JDK-8014052
>
>
> Open webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014052-JVMTI-JSR292.1
>
>
> Summary:
>    A call to the finalize_operands_merge() must be unconditional.
>    Otherwise, the merge of the bootstrap method operands is not
> completed correctly.
>
>
> Testing: vm/mlvm, nsk/jvmti, nsk/jdi, nsk/jdwp
>
> Thanks,
> Serguei

From serguei.spitsyn at oracle.com  Fri May 31 10:29:32 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Fri, 31 May 2013 10:29:32 -0700 (PDT)
Subject: Review Request (S) 8014052: JSR292: assert(end_offset ==
	next_offset) failed: matched ending
In-Reply-To: <51A8D7FB.1070906@oracle.com>
References: <51A840ED.7030501@oracle.com> <51A8D7FB.1070906@oracle.com>
Message-ID: <51A8DDFC.7000107@oracle.com>

Thanks, Vladimir!
Serguei

On 5/31/13 10:03 AM, Vladimir Kozlov wrote:
> Good.
>
> Vladimir
>
> On 5/30/13 11:19 PM, serguei.spitsyn at oracle.com wrote:
>> Please, review the fix for:
>>    bug: https://jbs.oracle.com/bugs/browse/JDK-8014052
>>    jbs: https://jbs.oracle.com/bugs/browse/JDK-8014052
>>
>>
>> Open webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014052-JVMTI-JSR292.1 
>>
>>
>>
>> Summary:
>>    A call to the finalize_operands_merge() must be unconditional.
>>    Otherwise, the merge of the bootstrap method operands is not
>> completed correctly.
>>
>>
>> Testing: vm/mlvm, nsk/jvmti, nsk/jdi, nsk/jdwp
>>
>> Thanks,
>> Serguei


From john.coomes at oracle.com  Fri May 31 12:12:34 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 31 May 2013 19:12:34 +0000
Subject: hg: hsx/hsx24/hotspot: 6725714: par compact - add a table to speed up
	bitmap searches
Message-ID: <20130531191240.5075048E96@hg.openjdk.java.net>

Changeset: d2e053ead2e6
Author:    jcoomes
Date:      2013-05-31 08:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/d2e053ead2e6

6725714: par compact - add a table to speed up bitmap searches
Reviewed-by: jmasa, tschatzl

! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp


From alejandro.murillo at oracle.com  Fri May 31 14:22:23 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Fri, 31 May 2013 21:22:23 +0000
Subject: hg: hsx/hsx25/hotspot: 29 new changesets
Message-ID: <20130531212325.B7F7148E9F@hg.openjdk.java.net>

Changeset: 573d86d412cd
Author:    katleman
Date:      2013-05-30 10:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/573d86d412cd

Added tag jdk8-b92 for changeset 092018493d3b

! .hgtags

Changeset: 194b27b865bc
Author:    amurillo
Date:      2013-05-24 09:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/194b27b865bc

8015305: new hotspot build - hs25-b35
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: ccdecfece956
Author:    bharadwaj
Date:      2013-05-21 16:17 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/ccdecfece956

8014059: JSR292: Failed to reject invalid class cplmhl00201m28n
Summary: Restrict reference of interface methods by invokestatic and invokespecial to classfile version 52 or later.
Reviewed-by: kvn, hseigel

! src/share/vm/classfile/classFileParser.cpp

Changeset: f54c85acc043
Author:    mikael
Date:      2013-05-21 09:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/f54c85acc043

8013726: runtime/memory/ReserveMemory.java fails due to 'assert(bytes % os::vm_allocation_granularity() == 0) failed: reserve block size'
Summary: Fix regression test to work on all platforms
Reviewed-by: ctornqvi, dholmes

! src/share/vm/prims/whitebox.cpp
! test/runtime/memory/ReserveMemory.java
! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Changeset: 1a07e086ff28
Author:    dholmes
Date:      2013-05-21 19:52 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/1a07e086ff28

Merge


Changeset: 6bd680e9ea35
Author:    coleenp
Date:      2013-05-22 14:37 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/6bd680e9ea35

8003421: NPG: Move oops out of InstanceKlass into mirror
Summary: Inject protection_domain, signers, init_lock into java_lang_Class
Reviewed-by: stefank, dholmes, sla

! agent/src/share/classes/sun/jvm/hotspot/memory/DictionaryEntry.java
! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java
! agent/src/share/classes/sun/jvm/hotspot/utilities/HeapGXLWriter.java
! agent/src/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java
! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaInstanceKlass.java
! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/classfile/javaClasses.cpp
! src/share/vm/classfile/javaClasses.hpp
! src/share/vm/classfile/vmSymbols.hpp
! src/share/vm/oops/arrayKlass.cpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/oops/klass.cpp
! src/share/vm/oops/klass.hpp
! src/share/vm/oops/objArrayKlass.hpp
! src/share/vm/oops/typeArrayKlass.hpp
! src/share/vm/prims/jvm.cpp
! src/share/vm/runtime/vmStructs.cpp

Changeset: 699d9df07e59
Author:    ctornqvi
Date:      2013-05-23 17:39 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/699d9df07e59

8009576: Test returns ClassNotFoundException
Summary: Small classpath fix and move tests into open
Reviewed-by: mgerdin, zgu

+ test/runtime/Metaspace/FragmentMetaspace.java
+ test/runtime/Metaspace/FragmentMetaspaceSimple.java
+ test/runtime/Metaspace/classes/test/Empty.java
+ test/runtime/testlibrary/GeneratedClassLoader.java

Changeset: b7fa10a3a69a
Author:    sspitsyn
Date:      2013-05-23 23:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b7fa10a3a69a

8014288: perf regression in nashorn JDK-8008448.js test after 8008511 changes
Summary: The fix of perf regression is to use method_idnum() for direct indexing into NMT
Reviewed-by: twisti, kvn, coleenp, dholmes
Contributed-by: serguei.spitsyn at oracle.com

! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/instanceKlass.hpp
! src/share/vm/prims/methodHandles.cpp
! src/share/vm/prims/methodHandles.hpp

Changeset: cd83e1d98347
Author:    dcubed
Date:      2013-05-24 10:21 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/cd83e1d98347

Merge


Changeset: 6c138b9851fb
Author:    sspitsyn
Date:      2013-05-24 17:36 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/6c138b9851fb

8013945: CMS fatal error: must own lock MemberNameTable_lock
Summary: The "delete mnt" needs to grab MemberNameTable_lock if !SafepointSynchronize::is_at_safepoint()
Reviewed-by: sla, mgerdin, dholmes, jmasa
Contributed-by: serguei.spitsyn at oracle.com

! src/share/vm/oops/instanceKlass.cpp

Changeset: 3970971c91e0
Author:    shade
Date:      2013-05-27 12:49 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/3970971c91e0

8015270: @Contended: fix multiple issues in the layout code
Summary: field count handling fixed, has_nonstatic_fields invariant fixed, oop map overrun fixed; new asserts
Reviewed-by: kvn, dcubed, coleenp

! src/share/vm/classfile/classFileParser.cpp
+ test/runtime/contended/HasNonStatic.java
+ test/runtime/contended/OopMaps.java

Changeset: a213d425d87a
Author:    ctornqvi
Date:      2013-05-28 15:08 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/a213d425d87a

8015329: Print reason for failed MiniDumpWriteDump() call
Summary: Printing both result from GetLastError and text representation of error. Also changed so that we produce dumps by default on client versions of Windows when running with a debug build. Also reviewed by peter.allwin at oracle.com
Reviewed-by: sla, dholmes

! src/os/windows/vm/os_windows.cpp

Changeset: 51af5fae397d
Author:    ccheung
Date:      2013-05-24 17:19 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/51af5fae397d

8015265: revise the fix for 8007037
Reviewed-by: sspitsyn, dholmes, dcubed

! src/share/vm/oops/constantPool.cpp

Changeset: 4cc7d4d5dc92
Author:    zgu
Date:      2013-05-28 08:54 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/4cc7d4d5dc92

Merge


Changeset: 01c2bdd24bb5
Author:    shade
Date:      2013-05-28 19:54 +0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/01c2bdd24bb5

8015493: runtime/contended/OopMaps.java fails with OutOfMemory
Summary: limit the memory footprint to dodge OutOfMemory errors.
Reviewed-by: dcubed, ctornqvi, iignatyev

! test/runtime/contended/OopMaps.java

Changeset: 9ea643afcaaf
Author:    dcubed
Date:      2013-05-28 11:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/9ea643afcaaf

Merge


Changeset: dcb062bea05b
Author:    jprovino
Date:      2013-05-28 11:17 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/dcb062bea05b

8013461: There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release
Summary: AsyncGetCallTrace is needed in libjvm.symbols so that programs which reference it can build correctly.
Reviewed-by: dholmes, bobv

! make/excludeSrc.make
! src/share/vm/prims/forte.cpp

Changeset: fb14e9ed1594
Author:    jprovino
Date:      2013-05-28 11:32 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/fb14e9ed1594

8011064: Some tests have failed with SIGSEGV on arm-hflt on build b82
Summary: NMT_detail is only supported when frame pointers are not omitted (-fno-omit-frame-pointer).
Reviewed-by: dholmes, cjplummer

! src/share/vm/services/memTracker.cpp
! src/share/vm/utilities/globalDefinitions.hpp

Changeset: 9e954e8d9139
Author:    jprovino
Date:      2013-05-28 15:24 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/9e954e8d9139

Merge


Changeset: 9e86c5544295
Author:    jiangli
Date:      2013-05-30 13:19 -0400
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/9e86c5544295

Merge


Changeset: 0def34ab1c98
Author:    tamao
Date:      2013-05-21 16:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/0def34ab1c98

8015007: Incorrect print format in error message for VM cannot allocate the requested heap
Summary: Correct the wrong print format in error message for VM cannot allocate the requested heap; and clean up the error message call in check_alignment()
Reviewed-by: brutisso, tschatzl
Contributed-by: tamao <tao.mao at oracle.com>

! src/share/vm/memory/universe.cpp

Changeset: 14d3f71f831d
Author:    tamao
Date:      2013-05-22 11:11 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/14d3f71f831d

8007762: Rename a bunch of methods in size policy across collectors
Summary: Rename: compute_generations_free_space() = compute_eden_space_size() + compute_old_gen_free_space(); update related logging messages
Reviewed-by: jmasa, johnc, tschatzl, brutisso
Contributed-by: tamao <tao.mao at oracle.com>

! src/share/vm/gc_implementation/concurrentMarkSweep/cmsAdaptiveSizePolicy.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/cmsAdaptiveSizePolicy.hpp
! src/share/vm/gc_implementation/parNew/asParNewGeneration.cpp
! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp
! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.hpp
! src/share/vm/gc_implementation/parallelScavenge/psGCAdaptivePolicyCounters.hpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.cpp

Changeset: 0886b99a4d1b
Author:    jwilhelm
Date:      2013-05-24 14:16 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/0886b99a4d1b

Merge


Changeset: eda078b01c65
Author:    stefank
Date:      2013-05-27 15:22 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/eda078b01c65

8015268: NPG: 2.5% regression in young GC times on CRM Sales Opty
Summary: Split SystemDictionary and ClassLoaderDataGraph root processing to help load balancing.
Reviewed-by: tschatzl, johnc

! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp
! src/share/vm/gc_implementation/parallelScavenge/pcTasks.hpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp
! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp
! src/share/vm/gc_implementation/parallelScavenge/psTasks.hpp
! src/share/vm/memory/sharedHeap.cpp

Changeset: 95c00927be11
Author:    stefank
Date:      2013-05-27 12:56 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/95c00927be11

8015428: Remove unused CDS support from StringTable
Summary: The string in StringTable is not used by CDS anymore. Remove the unnecessary code in preparation for 8015422: Large performance hit when the StringTable is walked twice in Parallel Scavenge
Reviewed-by: pliden, tschatzl, coleenp

! src/share/vm/classfile/symbolTable.cpp

Changeset: 8dbc025ff709
Author:    stefank
Date:      2013-05-27 12:58 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/8dbc025ff709

8015422: Large performance hit when the StringTable is walked twice in Parallel Scavenge
Summary: Combine the calls to StringTable::unlink and StringTable::oops_do in Parallel Scavenge.
Reviewed-by: pliden, coleenp

! src/share/vm/classfile/symbolTable.cpp
! src/share/vm/classfile/symbolTable.hpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp

Changeset: f41a577cffb0
Author:    jwilhelm
Date:      2013-05-31 09:55 +0200
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/f41a577cffb0

Merge


Changeset: b786c04b7be1
Author:    amurillo
Date:      2013-05-31 09:37 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/b786c04b7be1

Merge


Changeset: 5a028ee56116
Author:    amurillo
Date:      2013-05-31 09:37 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/5a028ee56116

Added tag hs25-b35 for changeset b786c04b7be1

! .hgtags


From alejandro.murillo at oracle.com  Fri May 31 19:25:30 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Sat, 01 Jun 2013 02:25:30 +0000
Subject: hg: hsx/hsx24/hotspot: 3 new changesets
Message-ID: <20130601022537.36EB248EA8@hg.openjdk.java.net>

Changeset: ba0b94f82e71
Author:    katleman
Date:      2013-05-29 13:24 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/ba0b94f82e71

Added tag jdk7u40-b27 for changeset f2614c006bb7

! .hgtags

Changeset: 64aaeeee0a10
Author:    amurillo
Date:      2013-05-31 14:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/64aaeeee0a10

Merge


Changeset: 6206774b5959
Author:    amurillo
Date:      2013-05-31 14:14 -0700
URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/6206774b5959

Added tag hs24-b47 for changeset 64aaeeee0a10

! .hgtags


From alejandro.murillo at oracle.com  Fri May 31 22:19:11 2013
From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com)
Date: Sat, 01 Jun 2013 05:19:11 +0000
Subject: hg: hsx/hotspot-main/hotspot: 4 new changesets
Message-ID: <20130601051922.79F1A48EAC@hg.openjdk.java.net>

Changeset: 573d86d412cd
Author:    katleman
Date:      2013-05-30 10:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/573d86d412cd

Added tag jdk8-b92 for changeset 092018493d3b

! .hgtags

Changeset: b786c04b7be1
Author:    amurillo
Date:      2013-05-31 09:37 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b786c04b7be1

Merge


Changeset: 5a028ee56116
Author:    amurillo
Date:      2013-05-31 09:37 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/5a028ee56116

Added tag hs25-b35 for changeset b786c04b7be1

! .hgtags

Changeset: b7569f617285
Author:    amurillo
Date:      2013-05-31 10:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/b7569f617285

8015690: new hotspot build - hs25-b36
Reviewed-by: jcoomes

! make/hotspot_version