RFR: 8u40: Thread and management extension support
John Coomes
John.Coomes at oracle.com
Thu Sep 4 07:48:15 UTC 2014
Stefan Johansson (stefan.johansson at oracle.com) wrote:
> On 2014-09-04 08:36, John Coomes wrote:
> > Stefan Johansson (stefan.johansson at oracle.com) wrote:
> >> Hi,
> >>
> >> Please review these changes to allow thread and management extensions in
> >> the VM.
> >> http://cr.openjdk.java.net/~sjohanss/thread-ext/webrev.00/
> >>
> >> There is currently no JBS issue open for this issue but one will be open
> >> shortly.
> > Looks good to me.
> Thanks John,
>
> See updated webrev due to Mikaels comments:
> http://cr.openjdk.java.net/~sjohanss/thread-ext/webrev.01/
Looks good, ship it.
-John
> > FWIW, I don't care too much for the "break" in
> > Threads::find_java_thread_from_java_tid() (line 3891); it should
> > instead be "return thread". But since this code is just being moved
> > verbatim from management.cpp, it's ok to leave as is.
> >
> > -John
>
More information about the hotspot-dev
mailing list