RFR (XS) 8033946 - Hotspot build should ignore "ide" folder

Dmitry Samersoff dmitry.samersoff at oracle.com
Thu Sep 4 19:10:32 UTC 2014


we already have ./jdk/make/netbeans, ./langtools/make/netbeans and I
think it's a good pattern to follow. You can create hotspot/make/xcode
and don't change the makefile.

Also with upcoming switch to full forest build you may consider to
create ide folder at top level and move per ws projects to it.

Nevertheless, if you decide to go ahead with makefile changes, it
requires some find machinery. Something like

$(FIND) -L $(HOTSPOT_TOPDIR) -name ".hg" -prune -o \( -name "ide" -a
-type "d" \) -prune -o -print

current patch filter out all files and directories containing char
sequence "ide" e.g. "side", "accidental" etc.


On 2014-09-04 20:45, Gerard Ziemski wrote:
> hi all,
> Please review a very small fix that makes hotspot build ignore "ide"
> folder, which is where local users can store their own favorite IDE
> projects.
> For those interested, I have an Xcode project for JDK8 and JDK9 that I
> am personally actively supporting and using, which is hosted at
> https://orahub.oraclecorp.com/gerard.ziemski/xcode that is meant to be
> put in "jdk/hotspot/ide" folder.
> Summary of fix:
> Exclude "ide" folder from the makefile that searches for hotspot src
> files, or otherwise make bails out complaining that it does not know how
> to handle Xcode project files.
> Testing:
> Passes local build on Mac OS X
> References:
> bug: https://bugs.openjdk.java.net/browse/JDK-8033946
> webrev: http://cr.openjdk.java.net/~gziemski/8033946_rev0/
> Thank you!

Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.

More information about the hotspot-dev mailing list