RFR (S) 8057643: Unable to build --with-debug-level=optimized on OSX

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Sep 5 21:42:57 UTC 2014


Thank you, Gerard

On 9/5/14 12:37 PM, Gerard Ziemski wrote:
> hi Vladimir,
>
> I looked at the webrev and it looks to me like the optimized build was
> implemented on all platforms, except OS X, and therefore disabled for
> all, and your change implements it on OS X and then makes it available
> for all the supported platforms - did I get this right? If so, please
> consider this reviewed (with small "r")

It was not disabled for all platforms. On others platforms you could 
build with --with-debug-level=optimized without this fix (I verified that).

Note, 'optimized' is not 'release' version of JavaVM. It contains 
additional code (additional 10-15% JVM library size) which is not in 
product JVM. And it is only applied to Hotspot build, the rest jdk code 
is built with 'release' level.

The main motivation for this work and other (JDK-8056072) is the next 
problem and coming "Cross Component (hotspot+jdk) Development" which 
will require whole forest to build Hotspot:

https://bugs.openjdk.java.net/browse/INTJDK-7612693
"optimized build had been broken a dozen times, so it's need it to be 
added into jprt"

We want to add 'optimized' build of whole forest in JPRT jobs and we 
need to support it on all platforms for that.

Regards,
Vladimir

>
> Thank you for this fix!
>
>
> cheers
>
> On 9/4/2014 8:36 PM, Vladimir Kozlov wrote:
>> http://cr.openjdk.java.net/~kvn/8057643/webrev/
>> https://bugs.openjdk.java.net/browse/JDK-8057643
>>
>> Added missing Hotspot make targets for 'optimized' build.
>>
>> Hotspot VM has 'optimized' build version which is used to collect
>> statistic and for stress testing. A corresponding source code is
>> guarded by #ifndef PRODUCT and by 'notproduct' flags.
>> Switching to full forest build for Hotspot development requires to
>> build all JVM targets from top repository. Unfortunately
>> '--with-debug-level=optimized' build is broken on OSX because of
>> missing targets in Hotspot makefiles.
>>
>> Tested the build on OSX, Linux, Solaris (I don't have Windows).
>>
>> Thanks,
>> Vladimir
>>
>>
>


More information about the hotspot-dev mailing list