RFR: 8057752: WhiteBox extension support for testing

[Christian Tornqvist]

Hi Stefan,

This looks good.

Thanks,
Christian

-----Original Message-----
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of
Stefan Johansson
Sent: Wednesday, September 10, 2014 7:35 AM
To: Mikael Gerdin; hotspot-dev at openjdk.java.net
Subject: Re: RFR: 8057752: WhiteBox extension support for testing

Thanks for reviewing this Mikael.

Made a small addition to allow Windows to handle empty extensions:
http://cr.openjdk.java.net/~sjohanss/8057752/webrev.00-01/

Stefan

On 2014-09-10 11:11, Mikael Gerdin wrote:
> Stefan,
>
> On Monday 08 September 2014 16.52.41 Stefan Johansson wrote:
>> Hi,
>>
>> Please review these changes for RFE:
>> https://bugs.openjdk.java.net/browse/JDK-8057752
>>
>> Webrev:
>> http://cr.openjdk.java.net/~sjohanss/8057752/webrev.00/
> Looks good.
>
>> Summary:
>> Added the call to register_extended to make it possible extend the 
>> WhiteBox API. The Java API is still defined in WhiteBox.java, if the 
>> extension methods are not defined by an extension a linker error will 
>> occur.
> Right, the code is designed so that it's possible to use mismatching 
> versions of WhiteBox.java as long as you avoid calling the unlinkable
methods.
>
> /Mikael
>
>> Stefan