RFR: 8058716: Add include missing in 8015774

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Sep 18 20:25:00 UTC 2014


On 9/18/14 1:07 AM, Lindenmaier, Goetz wrote:
> Hi,
>
> 8015744 breaks the build on ppc as an inline function is not defined:

   8015774


> compile.hpp:812: warning: inline function 'Node_Notes* Compile::locate_node_notes(GrowableArray<Node_Notes*>*, int, bool)' used but never defined
>
> This is because compile.hpp declares and calls locate_node_notes(), which is defined in node.hpp. Therefore codeCache.cpp must include node.hpp, too.

Good.

Thanks,
Vladimir

>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8058716
> Webrev:
> http://cr.openjdk.java.net/~goetz/webrevs/8058716-inclFix/webrev.00/
>
> Please review this change.  I please need a sponsor to push it.
>
> Best regards,
>    Goetz
>


More information about the hotspot-dev mailing list