RFR: JDK-8058936 hotspot/test/Makefile should use jtreg script from $JT_HOME/bin/jreg (instead of $JT_HOME/win32/bin/jtreg)

Staffan Larsen staffan.larsen at oracle.com
Tue Sep 23 13:34:26 UTC 2014


On 23 sep 2014, at 15:30, David Holmes <david.holmes at oracle.com> wrote:

> Hi Staffan,
> 
> On 23/09/2014 6:54 PM, Staffan Larsen wrote:
>> An upcoming version of jtreg will remove the platform-specific scripts in the distribution in favor of one single script. Hotspot’s makefiles references the win32-specific script and needs to be updated. Please see the small fix below. I plan to backport this to 7u and 8u as well.
> 
> How is this change being coordinated?

Jtreg already has the bin/jtreg script, so the change can be applied directly. A coming release of jtreg will remove the old scripts.

> 
> Change itself looks okay.

Thanks,
Staffan

> 
> Thanks,
> David
> 
>> Thanks,
>> /Staffan
>> 
>> 
>> diff --git a/test/Makefile b/test/Makefile
>> --- a/test/Makefile
>> +++ b/test/Makefile
>> @@ -259,8 +259,8 @@
>>    EXTRA_JTREG_OPTIONS += -concurrency:$(CONCURRENCY)
>>  endif
>> 
>> -# Default JTREG to run (win32 script works for everybody)
>> -JTREG = $(JT_HOME)/win32/bin/jtreg
>> +# Default JTREG to run
>> +JTREG = $(JT_HOME)/bin/jtreg
>> 
>>  # Only run automatic tests
>>  JTREG_BASIC_OPTIONS += -a
>> 



More information about the hotspot-dev mailing list