[8u40] RFR (XS): 8059226 : Names of rtm_state_change and unstable_if deoptimization reasons were swapped in 8u40

Filipp Zhinkin filipp.zhinkin at oracle.com
Mon Sep 29 19:23:59 UTC 2014


Vladimir, thank you for review.

Filipp.

On 29.09.2014 20:35, Vladimir Kozlov wrote:
> Looks good. Thank you for fixing this.
>
> Vladimir K
>
> On 9/29/14 6:44 AM, Filipp Zhinkin wrote:
>> Hi,
>>
>> please review the fix aimed to fix a glitch happened during 8030976 
>> [1] backport
>> to 8u40, after which names of rtm_state_change and unstable_if 
>> deoptimization
>> reasonswere swapped [2][3], so rtm_state_change trap was loggingin 
>> compilation
>> logas 'unstable_if' and vice versa.
>>
>> I've fixed order of DeoptReason values declaration so now it matches 
>> the order
>> used in jdk9 and the names order in Deoptimization::_trap_reason_name.
>>
>> Bug id:https://bugs.openjdk.java.net/browse/JDK-8059226
>> Webrev: http://cr.openjdk.java.net/~fzhinkin/8059226/webrev.00/
>> Testing: JPRT, manual & automated using affected tests
>>
>> Thanks,
>> Filipp.
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8030976
>> [2] http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/6ad207fd3e26#l4.6
>> [3] http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/f6f9aec27858#l4.7



More information about the hotspot-dev mailing list