RFR: 8080947: Add uint as a valid VM flag type

David Holmes david.holmes at oracle.com
Wed Jun 3 08:01:46 UTC 2015


Hi David,

On 28/05/2015 9:28 PM, David Lindholm wrote:
> Hi,
>
> Please review this patch that adds uint and int as valid VM flag types.
> This patch adds the possibility to specify VM flags with types int and
> uint, it does not change the type of any flags.
>
>
> Webrev: http://cr.openjdk.java.net/~david/JDK-8080947/webrev.hotspot.00/
> Webrev: http://cr.openjdk.java.net/~david/JDK-8080947/webrev.jdk.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8080947

src/share/vm/services/management.cpp

+   } else if (flag->is_int()) {
+     global->value.j = (jlong)flag->get_int();
+     global->type = JMM_VMGLOBAL_TYPE_JLONG;
+   } else if (flag->is_uint()) {
+     global->value.j = (jlong)flag->get_uint();
+     global->type = JMM_VMGLOBAL_TYPE_JLONG;

These should be JINT types not JLONG.

Cheers,
David H.
-------

>
> Testing: Passed JPRT
>
>
> Thanks,
> David


More information about the hotspot-dev mailing list