RFR(S): 8087183: Fix call to inline function is_oop in header debugInfo.hpp.

David Holmes david.holmes at oracle.com
Fri Jun 12 02:06:58 UTC 2015

On 12/06/2015 3:17 AM, Kim Barrett wrote:
> On Jun 11, 2015, at 5:02 AM, Lindenmaier, Goetz <goetz.lindenmaier at sap.com> wrote:
>> Hi,
>> in debugInfo.hpp is_oop() is called.  This is an inline function defined in oop.inline.hpp.
>> As oop.inline.hpp is not included in debugInfo.hpp, and it should not be included there,
>> this leads to compilation failures in the fastdebug build on aix.
>> To fix this, I just move the function calling is_oop to debugInfo.cpp.  In that file also the
>> only call to that function is located, so that it still can be inlined.
>> Please review this change.  I please need a sponsor.
>> http://cr.openjdk.java.net/~goetz/webrevs/8087183-is_oop/webrev-01/
>> Best regards,
>>   Goetz.
> Looks good.
> I’m mildly surprised this doesn’t run into problems on other platforms.

Me too. My first thought was precompiled headers, but this code has been 
in place for a couple of years - so why is it now a problem ??


> The assert could use oop->is_oop_or_null(), though it makes no difference for this problem.

More information about the hotspot-dev mailing list