RFR (XXS): 8129602: Incorrect GPL header causes RE script to create wrong output

David Holmes david.holmes at oracle.com
Wed Jun 24 09:56:59 UTC 2015

Hi Thomas,

On 24/06/2015 7:03 PM, Thomas Schatzl wrote:
> Hi all,
>    I need reviews for a small set of fixes that removes superfluous
> commas after the year in the GPL header so that some release engineering
> script does not produce garbage.

Actually add the missing commas where needed :)

> This CR fixes these issues for several files across the hotspot
> repository, bundling multiple similar problems. That's why this issue
> has been sent for review to hotspot-dev.
> CR (confidential, sorry):
> https://bugs.openjdk.java.net/browse/JDK-8129602
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8129602/webrev.hotspot/

You need to look at the patch to see the whitespace fix :)

> http://cr.openjdk.java.net/~tschatzl/8129602/webrev.hs-gc/ (for
> whitebox.cpp).


> Here is the corresponding 8u60 patch that differs in paths and adds a
> few more typos that have been fixed in 9.
> http://cr.openjdk.java.net/~tschatzl/8129602/webrev.8u60/

This all looks fine too. So the commas are already fixed in 9?


> Thanks,
>    Thomas

More information about the hotspot-dev mailing list