RFR: 8153254: Delegate (v)write from Log to LogTagSet

[Robbin Ehn]

Hi,

On 04/04/2016 11:11 AM, Stefan Karlsson wrote:
> Hi Kim,
>
> On 2016-04-04 10:24, Kim Barrett wrote:
>>> On Apr 1, 2016, at 4:53 AM, Robbin Ehn <robbin.ehn at oracle.com> wrote:
>>>
>>> Hi all,
>>>
>>> Please review this patch.
>>>
>>> This moves log writes methods to LogTagSet.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8153254
>>> Webrev: http://cr.openjdk.java.net/~rehn/8153254/webrev/
>>>
>>> Tested with internal vm test and jprt.
>>>
>>> Thanks!
>>>
>>> /Robbin
>> I think LogTagSetMapping might need to have a GuardTag template
>> parameter added, similar to that of Log, so that things like
>>
>> LogTagSetMapping< LOG_TAGS(__VAR_ARGS__) >
>>
>> can be used in some of Stefan's planned followups to this change.
>
> Actually, I don't have a need for the GuardTag template parameter. All
> my usages of LogTagSetMapping are encapsulated within other classes and
> I don't expose them to code taking the tags as varargs macros. I'm OK
> with leaving out the GuardTag until we need it.

As I said to Kim, I found a place where they matters, so I added them back.

(as from IRL you are ok with this, hence no webrev)

Thanks, Robbin

>
> StefanK
>
>>
>> Otherwise, looks good.
>>
>