RFR: 8152637: Create a stack allocatable LogStream class

Bengt Rutisson bengt.rutisson at oracle.com
Tue Apr 5 08:23:36 UTC 2016


Hi StefanK,

On 2016-04-05 10:22, Stefan Karlsson wrote:
> Hi all,
>
> I did a code walkthrough with Bengt and have updated the webrev:
>
> http://cr.openjdk.java.net/~stefank/8152637/webrev.03.delta
>
> http://cr.openjdk.java.net/~stefank/8152637/webrev.03
>
>
> Changes:
> 1) Code style in test
> 2) Reverted the unneeded log.hpp functions
> 3) Removed the LogStreamNoResourceMark::print indirection
> 4) Renamed the local variable in the usage example in 
> binaryTreeDictionary

Thanks for fixing this!

Looks good.

Bengt

>
> StefanK
>
> On 2016-03-29 15:47, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review this patch to create a stack allocatable LogStream 
>> class that embeds the ResourceMark.
>>
>> http://cr.openjdk.java.net/~stefank/8152637/webrev.01
>> https://bugs.openjdk.java.net/browse/JDK-815263
>>
>> The patch is applied on top of the patch in:
>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-March/022303.html 
>>
>>
>> I've converted the code in binaryTreeDictionary.cpp to show how to 
>> use the class.
>>
>> Test: new internal vm test, jprt
>>
>> Thanks,
>> StefanK
>



More information about the hotspot-dev mailing list