RFR (S) 8152432: Implement setting jtreg @requires properties vm.flavor, vm.bits, vm.compMode

Dmitry Fazunenko dmitry.fazunenko at oracle.com
Thu Apr 7 13:47:28 UTC 2016


Thank you so much, Igor.

On 07.04.2016 16:41, Igor Ignatyev wrote:
> Dima,
>
> one minor comment : s/Ignatiev/Ignatyev/ )
> otherwise looks good to me, thanks for addressing my comments.
>
> — Igor
>
>> On Apr 6, 2016, at 7:09 PM, Dmitry Fazunenko <dmitry.fazunenko at oracle.com> wrote:
>>
>> I got offline comments from Igor Ignatiev.
>> New version:
>>   https://bugs.openjdk.java.net/browse/JDK-8152432
>>   http://cr.openjdk.java.net/~dfazunen/8152432/webrev.01/
>>   changes: http://cr.openjdk.java.net/~dfazunen/8152432/webrev.00vs01/
>>
>> Thanks,
>> Dima
>>
>>
>> On 05.04.2016 17:45, Dmitry Fazunenko wrote:
>>> Hello,
>>>
>>> Would you please review a relatively simple fix which starts using new jtreg functionality:
>>> ability to define custom properties for use with the @requires tag.
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8152432
>>> http://cr.openjdk.java.net/~dfazunen/8152432/webrev.00/
>>>
>>> As the first experience of using this functionality I just fixed setting of properties which set by jtreg,
>>> but set incorrectly relying only on specified vm flags.
>>> In the near future we are going to introduce new properties.
>>>
>>> Tested locally.
>>>
>>> Thanks,
>>> Dima
>>>
>>>
>>>
>>>



More information about the hotspot-dev mailing list