RFR (XL): 8152664 - Support non-continuous CodeBlobs in HotSpot

[Volker Simonis]

Thanks again Andrew.

I'm just waiting for Rickards evaluation and I'm sure he'll
incorporate your fix into his patch.

Regards,
Volker


On Mon, Apr 18, 2016 at 6:09 PM, Andrew Dinn <adinn at redhat.com> wrote:
> On 18/04/16 16:15, Andrew Dinn wrote:
>> Hi Volker,
>>
>> As expected your patch fixes the problems with Rickard's original patch
>> on AArch64.
>
> n.b as mentioned elsewhere in this thread I had to add a missing ? to
> Rickard's patch in file os_linux_aarch64.cpp.
>
>
> @@ -389,7 +389,7 @@
>          // here if the underlying file has been truncated.
>          // Do not crash the VM in such a case.
>          CodeBlob* cb = CodeCache::find_blob_unsafe(pc);
> -        nmethod* nm = (cb != NULL && cb->is_nmethod()) ? (nmethod*)cb :
> NULL;
> +        CompiledMethod* nm = (cb != NULL)
> cb->as_compiled_method_or_null() : NULL;
>          if (nm != NULL && nm->has_unsafe_access()) {
>            stub = handle_unsafe_access(thread, pc);
>          }
>
> As you can see there ought to be a ? on the modified line after (cb !=
> NULL).
>
> So, this needs to be included in whatever patch finally gets pushed
> (really it ought to go into Rickard's patch).
>
> regards,
>
>
>
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in UK and Wales under Company Registration No. 3798903
> Directors: Michael Cunningham (US), Michael O'Neill (Ireland), Paul
> Argiry (US)