RFR(S): 8170767: Zero fastdebug build triggers assertion

Severin Gehwolf sgehwolf at redhat.com
Thu Dec 8 11:36:42 UTC 2016


On Wed, 2016-12-07 at 22:58 -0500, Coleen Phillimore wrote:
> This looks good and I can sponsor this for you.  I haven't built Zero in 
> a while.

Thanks for the review Coleen! It still doesn't build (for me) after
this fix, but that's a separate issue.

The exported changeset is here:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8170767/JDK-8170767.export.patch

Cheers,
Severin

> Thanks,
> Coleen
> 
> On 12/7/16 7:57 AM, Severin Gehwolf wrote:
> > 
> > Hi,
> > 
> > Could somebody please review this Zero only change? The problem was
> > there before, but only the fix for JDK-8169711 brought it to the
> > surface. The returned method kind for
> > java_lang_math_fmaD/java_lang_math_fmaF is no longer guarded by UseFMA
> > in abstractInterpreter.cpp
> > 
> > The fix is to generate stub entries for
> > java_lang_math_fmaD/java_lang_math_fmaF which were missing. Thoughts?
> > 
> > bug: https://bugs.openjdk.java.net/browse/JDK-8170767
> > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8170767/webrev.01/
> > 
> > Thanks,
> > Severin
> 



More information about the hotspot-dev mailing list