RFR(xs): 8171408: [aix] TOC overflow when linking the gtest libjvm.so

David Holmes david.holmes at oracle.com
Mon Dec 19 20:47:01 UTC 2016


Hi Thomas,

On 18/12/2016 10:50 PM, Thomas Stüfe wrote:
> Hi all,
>
> please take a look at this small fix. In short, on AIX when linking the
> gtest version of libjvm.so, the TOC overflows.
>
> So the gtest libjvm.so must be linked with -bbigtoc, in contrast to the
> regular libjvm.so, which has no problems and can keep using a small TOC.
>
> Also, I compile all gtest objects with -qpic=large. Note that this only
> affects the gtest objects. The regular objects - which the gtest libjvm.so
> shares with the regular libjvm.so - I left at -qpic[=small]. This means we
> pay a bit of a performance overhead in the gtest libjvm.so but leave the
> regular libjvm.so at its optimal linker settings.
>
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8171408
>
> Webrev:
> http://cr.openjdk.java.net/~stuefe/webrevs/8171408-aix-TOC-overflow-when-linking-the-gtest-libjvm/webrev.00/

This looks okay to me.

Thanks,
David
------

> (Hope the webrev link works, the webserver is still down).
>
> Kind Regards, Thomas
>


More information about the hotspot-dev mailing list