RFR: 8146690: Make all classes in GC follow the naming convention.

David Holmes david.holmes at oracle.com
Wed Jan 13 09:29:35 UTC 2016

Hi David,

On 13/01/2016 6:55 PM, David Lindholm wrote:
> Hi,
> My latest cleanup effort has been to make sure that all class names in
> GC follow the CamelCase naming convention. Almost all classes does this
> already, but there are a few that doesn't. For a list of these classes,
> see https://bugs.openjdk.java.net/browse/JDK-8146690
> Please review this patch that renames these classes to follow the naming
> convention.
> I have not changed names of the gc vm operations, since all vm
> operations throughout hotspot follow the same naming convention
> (VM_Operation).
> Bug: https://bugs.openjdk.java.net/browse/JDK-8146690
> Webrev: http://cr.openjdk.java.net/~david/JDK-8146690/webrev.00/

Generally looks fine.

An indention fix needed here:

-Par_PushAndMarkClosure::Par_PushAndMarkClosure(CMSCollector* collector,
+ParPushAndMarkClosure::ParPushAndMarkClosure(CMSCollector* collector,
                                                 MemRegion span,
                                                 ReferenceProcessor* rp,
                                                 CMSBitMap* bit_map,

Are there any SA changes needed to match the vmStructs changes?

David H.

> Testing: JPRT.
> Thanks,
> David L

More information about the hotspot-dev mailing list