RFR: 8146985: Change output directory for hotspot's jtreg tets to build/conf/hotspot/testoutput

Erik Helin erik.helin at oracle.com
Thu Jan 14 16:19:24 UTC 2016

On 2016-01-13, Mikael Vidstedt wrote:
> The logic in this file (hotspot/test/Makefile) is very similar to that of
> jdk/test/Makefile, as a matter of fact some of it has been copy pasted.

The benefit is that if you learn one of the Makefiles, you can quickly
pick learn the other one ;)

On 2016-01-13, Mikael Vidstedt wrote:
> It would be nice if the output dir paths would be set up the same way
> in both cases, to avoid confusion and all of that.

Yep, agree, and looking at jdk/test/Makefile, it does things slightly
different. When running one of jtreg groups jdk_*, core_* or svc_* via
the top-level Makefiles, then the results will end up in:


Given the current feedback, the proposed change is to put the hotspot
results in:


We could align jdk/test/Makefile and hotspot/test/Makefile by having the
hotspot results in <top-level>/build/testoutput/<jtreg-group> as well.
The jtreg groups with identical suffixes are already prefixed by their
folder (e.g. jdk_svc, hotspot_svc), so there shouldn't be any name

I will send out a new patch soon.


> It would be even better to share the logic all together to avoid
> duplication, but that's a separate issue.
> Cheers,
> Mikael
> On 2016-01-13 06:04, Erik Helin wrote:
> >(added missing subject)
> >
> >On 2016-01-13, Erik Helin wrote:
> >>Hi all,
> >>
> >>this patch changes the output directory for hotspot's jtreg tests when
> >>run via the top-level Makefile targets such as
> >>`make test-hotspot-jtreg`.
> >>
> >>The current directory is
> >><top-level>/build/<conf>/hotspot/linux-x64/testoutput
> >>(on an x86-64 machine running Linux). There is no need to place the
> >>"testoutput" directory in a directory which name is based on OS and arch,
> >>that is already done by the current configuration. Therefore, we can
> >>instead place the "testoutput" directory in
> >><top-level>/build/<conf>/hotspot/, which is a more reasonable location
> >>for the output from hotspot's tests.
> >>
> >>Enhancement:
> >>https://bugs.openjdk.java.net/browse/JDK-8146985
> >>
> >>Webrev:
> >>http://cr.openjdk.java.net/~ehelin/8146985/00/webrev
> >>
> >>Testing:
> >>- Running `make test-hotspot-jtreg` locally
> >>- JPRT (the patch does not affect JPRT since JPRT does not use
> >>
> >>Thanks,
> >>Erik

More information about the hotspot-dev mailing list