[9] RFR(XS): 8147482: Zero build fails after 8144953
Severin Gehwolf
sgehwolf at redhat.com
Mon Jan 18 09:36:59 UTC 2016
On Sat, 2016-01-16 at 15:28 -0500, Coleen Phillimore wrote:
> Ok, I checked it in with author sgehwolf, through JPRT although JPRT
> doesn't build it.
> Thanks for the contribution Severin.
> Coleen
Thanks Volker and Coleen!
Cheers,
Severin
> On 1/16/16 5:43 AM, Volker Simonis wrote:
> > Hi Coleen,
> >
> > I totally agree and I'd like to but there have been complaints before
> > when we pushed ppc64 or AIX only changes to shared directories.
> >
> > So until we don't get a general and clear agreement on this topic I'd
> > like to ask you to be so kind and do the push.
> >
> > Thank you and best regards,
> > Volker
> >
> > On Friday, January 15, 2016, Coleen Phillimore
> > <coleen.phillimore at oracle.com coleen.phillimore at oracle.com>>
> > wrote:
> >
> >
> >
> > On 1/15/16 2:20 PM, Volker Simonis wrote:
> >
> > Hi Severin,
> >
> > the change looks good.
> >
> > Unfortunately I can't sponsor it because it is in shared code.
> >
> >
> > Actually, since it's in Zero only, I think it would be okay to
> > push directly. It's not technically in the cpu/zero/vm directory
> > but these files are only used for Zero.
> >
> > Alas, we don't test Zero with JPRT. If we start doing this, a. it
> > wouldn't break so often and b. we'd have to sponsor just to make
> > sure it doesn't break and prevent other integration jobs from
> > going through.
> >
> > Thanks,
> > Coleen
> >
> >
> > Regards,
> > Volker
> >
> >
> > On Fri, Jan 15, 2016 at 7:46 PM, Severin Gehwolf
> > <sgehwolf at redhat.com> wrote:
> >
> > Hi,
> >
> > Could somebody please review and sponsor this trivial
> > change to
> > bytecodeInterpreter.cpp. It fixes a Zero-only build problem.
> >
> > Webrev:
> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8147482/webrev.01/
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8147482
> >
> > Zero builds fine in release/fastdebug/slowdebug variants
> > after this.
> >
> > Thanks,
> > Severin
> >
> >
>
More information about the hotspot-dev
mailing list