RFR(S) : 8148012 : get rid of slash-dot-dot in @library directives

Igor Ignatyev igor.ignatyev at oracle.com
Wed Jan 27 12:57:44 UTC 2016


Hi David,

thanks for review.

> Remind me what is in /testlibrary versus /test/lib ?? :)
one is located in <root>/hotspot/test/ another in <root>, so one contains (is supposed to contain) hotspot specific library, another common used libraries and there is an RFE to make it so.

— Igor
 
> On Jan 27, 2016, at 8:05 AM, David Holmes <david.holmes at oracle.com> wrote:
> 
> Hi Igor,
> 
> On 26/01/2016 5:36 AM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev/8148012/webrev.00/
>>> 31 lines changed: 0 ins; 0 del; 31 mod;
>> 
>> Having ‘external.lib.roots=/../../' in TEST.ROOT made it possible not to use ‘/..’ in tests, the latest change in JTreg(https://bugs.openjdk.java.net/browse/CODETOOLS-7901585) made it illegal to have references to directories outside a test suite, so it’s required to fix all such entries for switching to the next jtreg version. the fix basically replaces all '/../../test/lib’ w/ ‘/test/lib’ in @library directives.
> 
> I Reviewed the patch and it looks good.
> 
> Remind me what is in /testlibrary versus /test/lib ?? :)
> 
> Thanks,
> David
> 
>> testing: run the affected tests
>> jbs: https://bugs.openjdk.java.net/browse/JDK-8148012
>> 
>> Thanks,
>> Igor
>> 



More information about the hotspot-dev mailing list