RFR: 8159364: Gtest unit tests does not support PCH

Erik Helin erik.helin at oracle.com
Mon Jun 20 09:35:35 UTC 2016


On 2016-06-14, Erik Joelsson wrote:
> Do you really need to exclude gTestLauncher.cpp from precompiled? That file
> should be excluded from compilation already.

No, you are right, I don't need to re-exclude gTestLauncher.cpp
(verified by running JPRT). I will remove gTestLauncher.cpp from
PRECOMPILED_HEADER_EXCLUDE before I push.

> Otherwise looks good.

Thanks,
Erik

> /Erik
> 
> On 2016-06-14 02:50, Erik Helin wrote:
> >Hi all,
> >
> >this patch adds support for pre-compiled headers (PCH) to the gtest unit
> >tests.
> >
> >Bug:
> >https://bugs.openjdk.java.net/browse/JDK-8159364
> >
> >Webrev:
> >http://cr.openjdk.java.net/~ehelin/8159364/00/
> >
> >Testing:
> >- JPRT
> >
> >Thanks,
> >Erik
> 


More information about the hotspot-dev mailing list