Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

David Holmes david.holmes at oracle.com
Thu Jun 23 07:57:25 UTC 2016


On 23/06/2016 5:51 PM, Alan Bateman wrote:
>
>
> On 23/06/2016 00:20, serguei.spitsyn at oracle.com wrote:
>> :
>>
>> I agree with it.
>> Thank you for pointing to this JVMTI example.
>> I did not find in the JNI where the names are checked to be legal.
>> We are going to open a can of worms with this kind of check as there
>> can be many corner cases to cover.
> The primary use-case for this function is from within the CLFH callback
> so have it return the unnamed module when calling with garage is
> probably okay, it just needs to be specified.

It already is specified :) If the name is garbage then it is, by 
definition, not a package that is associated with any module hence the 
else clause kicks in and the unnamed module is returned.

David
-----

> Will you update the webrev to reflect where we've got to this in this
> discussion?
>
> -Alan


More information about the hotspot-dev mailing list