Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

[serguei.spitsyn at oracle.com]

Hi Andrew,

You should not try to convince me that updating webrev in place is a 
generally bad idea.
I have the same opinion. :)
Just did not want to generate another round for a pretty small change.
Sorry.

Thanks,
Serguei



On 6/23/16 01:52, Andrew Dinn wrote:
> On 23/06/16 09:41, serguei.spitsyn at oracle.com wrote:
>> Updated the webrev in place:
>>
>> Hotspot:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8159145-jigsaw-jvmti-pkg.2
> Just as an aside, I think it's actually a bad idea to update in place.
> Much better to just add new webrevs.
>
> Why? Well, the mail lists provide an audit of the review process for a
> given change. Webrevs are the data on which those reviews are based. So,
> removing them (by overwriting) makes it harder to understand why a
> specific choice was made. This may not matter most of the time but when
> a fix gets revoked thanks, say, to a regression of some sort it's
> important to be able to go back and re-read that audit trail.
>
> regards,
>
>
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander