RFR 8160551: assert(c == Bytecodes::_putfield) failed: must be putfield

[Coleen Phillimore]

Under the trivial rules and because it's an integration blocker, I'm 
going to commit.
jck tests passed.
Thanks,
Coleen

On 6/29/16 5:28 PM, Coleen Phillimore wrote:
>
>
> On 6/29/16 5:26 PM, John Rose wrote:
>> Reviewed.
>>
>> One nit:  To read the test case more easily, I would like to see the 
>> original source code for Bad, preferably commented out in the main 
>> test file like so:
>>
>> public class PutfieldError {
>>    …
>> }
>> /* recoded in jasm:
>> class Bad {
>>    public static final int i; //rewritten
>>    //rewritten to: public final int i;
>>    static { i = 5; } // putstatic instruction
>> }
>> */
>
> Okay, will do.   Having a side-by-side .java file sometimes causes 
> problems in jtreg so I'll add as a comment as you suggest.
>
> thanks!
> Coleen
>
>>
>> On Jun 29, 2016, at 2:13 PM, Coleen Phillimore 
>> <coleen.phillimore at oracle.com> wrote:
>>> Summary: Illegal bytecodes which are detected later hit this assert 
>>> first.
>>>
>>> Removed the asserts in the new code in the rewriter, and added a 
>>> test that verifies that ICCE is thrown for the case in question.
>>>
>>> Tested in progress with jck tests.
>>>
>>> open webrev at http://cr.openjdk.java.net/~coleenp/8160551.01/webrev
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8160551
>>>
>>> Zoltan: I borrowed your test directory name from your last review to 
>>> also include my test.
>>>
>>> Thanks,
>>> Coleen
>