RFR for JDK-8165482 java in ldoms, with cpu-arch=generic has problems

[David Holmes]

On 4/10/2016 7:03 PM, Martin Walsh wrote:
> (dropped build-dev alias as there are no longer any build changes in the
> revised fix)
>
> On 04/10/2016 08:16, David Holmes wrote:
>> Hi Martin,
>
>>> All Oracle SPARC LDOMS use the "sun4-cpu" string as the CPU
>>> implementation, therefore I think the best short term fix is to add an
>>> additional match that checks for this string.  Long term, this could do
>>> with a re-write, but that is a JDK10 project.
>>>
>>> This updated fix also means there are no build changes.
>>>
>>> Updated the webrev accordingly.
>>>
>>> http://cr.openjdk.java.net/~mwalsh/JDK-8165482/
>>
>> These new changes seem okay to me.
>>
>> Only one nit in src/os_cpu/solaris_sparc/vm/vm_version_solaris_sparc.cpp
>>
>>  467             }
>>  468           }
>>  469   }
>>  470       }
>>
>> the indent on line 469 is wrong.
>
>
> Fixed.  Thanks David.  I have updated the webrev and the patch attached
> to the bug.
>
> Would anybody be willing to sponsor this changeset?

I can sponsor, but we still need a second review of this version.

Thanks,
David

> Thanks,
>
> Martin
>