RFR: 8167446: Add back PermGenSize and MaxPermGenSize

Thomas Stüfe thomas.stuefe at gmail.com
Thu Oct 13 07:05:51 UTC 2016


On Wed, Oct 12, 2016 at 2:03 AM, Jeremy Manson <jeremymanson at google.com>
wrote:

> FYI: At Google, to ease the transition, we just made those flags *mean*
> MetaspaceSize and MaxMetaspaceSize.  We got no complaints (as far as I
> know).
>

Do you also derive CompressedClassSpaceSize ?



>
> Jeremy
>
> On Tue, Oct 11, 2016 at 3:10 PM, Coleen Phillimore <
> coleen.phillimore at oracle.com> wrote:
>
> >
> > I think this looks great.  If we decide to never remove these options at
> > some point in the future, we can change the last element in the array to
> > undefined.
> >
> > Thanks for doing this so quickly, Max.
> > Coleen
> >
> >
> >
> > On 10/11/16 5:29 PM, Max Ockner wrote:
> >
> >>
> >> New webrev: http://oklahoma.us.oracle.com/~mockner/webrev/8167446.02
> >>   - Added a test
> >>   - Adjusted the obsolete field on both flags.
> >>
> >> On 10/11/2016 2:31 PM, harold seigel wrote:
> >>
> >>> Hi Max,
> >>>
> >>> Can you add a small test?  It would prevent someone else from removing
> >>> the options.
> >>>
> >>> I have added a simple test.
> >>
> >> Thanks, Harold
> >>>
> >>>
> >>> On 10/11/2016 1:44 PM, Max Ockner wrote:
> >>>
> >>>> Hello,
> >>>> Please Review this small change.
> >>>>
> >>>> http://cr.openjdk.java.net/~mockner/8167446/
> >>>> https://bugs.openjdk.java.net/browse/JDK-8167446
> >>>>
> >>>> Added PermSize and MaxPermSize to obsolete flags table. They are
> >>>> recognized but ignored.
> >>>>
> >>>> The bug title says "PermGenSize" and "MaxPermGenSize" but the comment
> >>>> says "PermSize" and MaxPermSize". Which one is correct?
> >>>>
> >>>> Tested both options on java -version. Nothing happens, but I don't get
> >>>> an "Unrecognized ..." error.
> >>>>
> >>>> Thanks,
> >>>> Max
> >>>>
> >>>
> >>>
> >>
> >
>


More information about the hotspot-dev mailing list