RFR(S): 8168483 Remove jtreg timeout handler timeout

Staffan Larsen staffan.larsen at oracle.com
Mon Oct 24 07:05:59 UTC 2016


Thanks Tim!

> On 22 Oct 2016, at 05:21, Tim Bell <tim.bell at oracle.com> wrote:
> 
> Looks good to me as well.
> 
> Tim
> 
> On 10/21/16 17:24, David Holmes wrote:
>> Looks fine.
>> 
>> Thanks,
>> David
>> 
>> On 21/10/2016 11:24 PM, Staffan Larsen wrote:
>>> When we run jtreg in the hotspot, jdk and nashorn folders we run it
>>> with the timeout handler found under test/failure_handler. This
>>> handler is sometimes very slow (since it creates core files of hung
>>> processes). The handler is also very good at handling its own timeouts.
>>> 
>>> The default implementation in jtreg tries to interrupt() a timeout
>>> handler after 300 seconds. This is not enough time for
>>> test/failure_handler. Rather than increasing the timeout, we should
>>> disable it when running with test/failure_handler and let it handle
>>> any timeouts itself.
>>> 
>>> webrev: http://cr.openjdk.java.net/~sla/8168483/webrev.00/
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8168483
>>> <https://bugs.openjdk.java.net/browse/JDK-8168483>
>>> 
>>> /Staffan
>>> 
> 



More information about the hotspot-dev mailing list