[9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

[Volker Simonis]

OK, thanks. I'll do that tomorrow.

For now I did built 'hotspot-only' and sent out a webrev with the
requiredppc/s390 changes for hotspot to the corresponding review
thread. Would be nice if you could integrate them into your patch
right away.

Thanks,
Volker


On Thu, Oct 27, 2016 at 6:24 PM, Vladimir Kozlov
<vladimir.kozlov at oracle.com> wrote:
> Yes, you need to integrate graal-core into hotspot for that.
>
> I just send final RFR which explains what to do:
>
> 8166417: Graal-core into JDK for AOT compiler
>
> Regards,
> Vladimir
>
>
> On 10/27/16 8:45 AM, Volker Simonis wrote:
>>
>> I can't even compile this on Linux/x86_64. I get the following error:
>>
>>
>> /usr/work/d046063/OpenJDK/jdk9-hs/jdk/src/java.base/share/classes/module-info.java:159:
>> error: module not found: jdk.vm.compiler
>>          jdk.vm.compiler;
>>                ^
>>
>> /usr/work/d046063/OpenJDK/jdk9-hs/jdk/src/java.base/share/classes/module-info.java:180:
>> error: module not found: jdk.vm.compiler
>>          jdk.vm.compiler,
>>                ^
>>
>> /usr/work/d046063/OpenJDK/jdk9-hs/jdk/src/java.base/share/classes/module-info.java:309:
>> error: module not found: jdk.vm.compiler
>>          jdk.vm.compiler;
>>
>> I have integrated this two webrevs and the hotspot webrev from
>> http://cr.openjdk.java.net/~kvn/aot/hs.webrev/
>>
>> What do I have to do, to get it at least compiled?
>>
>> Regards,
>> Volker
>>
>> On Thu, Oct 27, 2016 at 2:40 PM, Erik Joelsson <erik.joelsson at oracle.com>
>> wrote:
>>>
>>>
>>>
>>> On 2016-10-27 02:45, Vladimir Kozlov wrote:
>>>>
>>>>
>>>> AOT JEP:
>>>> https://bugs.openjdk.java.net/browse/JDK-8166089
>>>> Subtask:
>>>> https://bugs.openjdk.java.net/browse/JDK-8166416
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~kvn/aot/top.webrev/
>>>
>>>
>>> hotspot.m4: 296: Comment is misleading. Should just be removed.
>>>
>>> CompileJavaModules.gmk: Use of -g flag for java compilation is controlled
>>> globally. Please remove.
>>>
>>> Main.gmk: buildtools-hotspot should be declared inside the
>>> CREATING_BUILDJDK
>>> conditional like all other buildtools targets.
>>>
>>>> http://cr.openjdk.java.net/~kvn/aot/jdk.webrev/
>>>
>>>
>>> The extra exports from java.base needs to go in a new
>>> jdk/src/java.base/share/classes/module-info.java.extra since the module
>>> jdk.vm.compiler is optional.
>>>>
>>>>
>>>> http://cr.openjdk.java.net/~kvn/aot/hs.make.webrev/
>>>
>>>
>>> Lib-jdk.aot.gmk: Please inline LDFLAGS and LIBS and add $(LIBS_JDKLIB) to
>>> LIBS since that will provide -lc on Solaris automatically. No need to set
>>> DEBUG_SYMBOLS or STRIP_SYMBOLS as the defaults should be correct and
>>> controlled globally.
>>>
>>> /Erik
>>>
>>>>
>>>> Please, review build changes for AOT.  Only Linux/x64 platform is
>>>> supported. 'jaotc' and AOT part of Hotspot will be build only on
>>>> Linux/x64.
>>>>
>>>> Changes include new 'jaotc' launcher, makefile changes to build
>>>> jdk.vm.compiler (Graal) and jdk.aot modules used by 'jaotc'.
>>>> Both modules sources are located in Hotspot: hotspot/src/jdk.aot and
>>>> hotspot/src/jdk.vm.compiler.
>>>> 'jaotc' requires installed libelf package on a system to build native
>>>> part
>>>> of 'jaotc'. It is used to generated AOT shared libraries (.so) as result
>>>> of
>>>> AOT compilation.
>>>>
>>>> Hotspot makefile changes will be pushed together with Hotspot AOT
>>>> changes.
>>>>
>>>> Thanks,
>>>> Vladimir
>>>
>>>
>>>
>