RFR (M) 8223261 "JDK-8189208 followup - remove JDK_GetVersionInfo0 and the supporting code"

[gerard ziemski]

Thank you for the review, will remove the comment and updated the 
webrev, but only after Christop Langer gets his fix in - I'm going to 
wait for him to check in first.


cheers

On 11/13/19 1:29 PM, Mandy Chung wrote:
>
>
> On 11/13/19 10:50 AM, gerard ziemski wrote:
>> Hi all,
>>
>> Please review this cleanup, where we remove JDK_GetVersionInfo0 and 
>> related code, since we can get build versions directly from within 
>> the VM itself:
>>
>> I'm including core-libs and awt in this review because the proposed 
>> fix touches their corresponding files.
>>
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8223261
>> webrev: http://cr.openjdk.java.net/~gziemski/8223261_rev1
>> tests: passes Mach5 tier1,2,3,4,5,6
>>
>
> This is a good clean up.  JDK_GetVersionInfo0 was needed long time ago 
> in particular in HS express support that is no longer applicable.
>
> One leftover comment should also be removed.
>
> src/hotspot/share/runtime/vm_version.hpp
>   // Gets the jvm_version_info.jvm_version defined in jvm.h
>
> otherwise looks good.
>
> Mandy