RFR: 8234779: Provide idiom for declaring classes noncopyable

David Holmes david.holmes at oracle.com
Wed Nov 27 01:18:37 UTC 2019


Hi Kim,

That all seems fine to me.

Now we just have to remember that this macro exists. :)

Thanks,
David

On 27/11/2019 10:18 am, Kim Barrett wrote:
> Please review this change that adds a new macro NONCOPYABLE, for
> declaring a class to be noncopyable.  This change also modifies a
> bunch of classes to use the new macro.  Most of those classes already
> included equivalent code, and we're just replacing that with uses of
> the macro.
> 
> (A few classes in PtrQueue.hpp that weren't previously made
> noncopyable but should have been are now also using the NONCOPYABLE
> macro.)
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8234779
> 
> Webrev:
> https://cr.openjdk.java.net/~kbarrett/8234779/open.00/
> 
> Testing:
> mach5 tier1
> 
> linux fastdebug builds for the following:
> 1. platforms: aarch64, arm32, ppc64le, s390x, zero.
> 2. x86_64 with shenandoah included.
> 3. x86_64 minimal configuration.
> 


More information about the hotspot-dev mailing list