RFR: 8252505: C1/C2 compiler support for blackholes [v11]

Aleksey Shipilev shade at openjdk.java.net
Tue Dec 1 15:19:57 UTC 2020


On Tue, 1 Dec 2020 12:24:54 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cleanup BlackholeCallGenerator
>
> src/hotspot/share/c1/c1_InstructionPrinter.cpp line 865:
> 
>> 863: 
>> 864: void InstructionPrinter::do_Blackhole(Blackhole* x) {
>> 865:   if (x->v() != NULL) {
> 
> Should be an assert instead? (LIRGenerator::do_Blackhole doesn't expect NULL.)

Would be sad to `assert` in essentially debugging code. I see that `print_value` does the right thing: prints `NULL`, if any. So I simplified this piece of code to call `print_value` unconditionally.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1203


More information about the hotspot-dev mailing list