RFR: 8257563: Remove excessive include of klass.inline.hpp

[Stefan Karlsson]

On Wed, 2 Dec 2020 16:19:05 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/cpu/s390/s390.ad line 1329:
>> 
>>> 1327: 
>>> 1328: #include "oops/klass.inline.hpp"
>>> 1329: 
>> 
>> I wonder if this should be put in adlc/main.cpp. I'm not sure, but I don't think we usually put includes in the .ad files.
>
> We have #includes in the .ad files today. I am not sure what the rules are. I am guessing it is "add includes that are specific to the C code inside this .ad file". So I'd like to keep my changes in s390.ad as is.
> 
> $ find . -name *.ad | xargs grep -l '^#include '
> ./cpu/aarch64/aarch64.ad
> ./cpu/aarch64/gc/z/z_aarch64.ad
> ./cpu/aarch64/gc/shenandoah/shenandoah_aarch64.ad
> ./cpu/ppc/ppc.ad
> ./cpu/x86/gc/z/z_x86_64.ad
> ./cpu/x86/gc/shenandoah/shenandoah_x86_64.ad
> ./cpu/x86/gc/shenandoah/shenandoah_x86_32.ad
> ./cpu/x86/x86.ad

OK. So platform-specific files seems to have includes. Got it. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1552