RFR: JDK-8257588: Make os::_page_sizes a bitmask [v2]

Thomas Stuefe stuefe at openjdk.java.net
Thu Dec 3 13:53:56 UTC 2020


On Thu, 3 Dec 2020 13:39:47 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Not possible, since its used from within os::Linux, os::Aix etc.
>
> Your comment is probably related to the comment of making the `PageSizeSet` class private. Hmm, I did try that out though and compiled locally on Linux.... maybe I messed up somewhere. Leave it public then.
> 
> Otherwise I am a bit confused how this statement relates to the request to move the code comment to the .hpp file.

You know, communication was a bit easier when we wrote mails :) 
I thought you meant "make add() private". Sorry for my confusion.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1522


More information about the hotspot-dev mailing list