RFR: 8252505: C1/C2 compiler support for blackholes [v23]

Vladimir Ivanov vlivanov at openjdk.java.net
Fri Dec 4 09:37:57 UTC 2020


On Fri, 4 Dec 2020 09:23:58 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> src/hotspot/share/compiler/compilerOracle.cpp line 418:
>> 
>>> 416:     } else {
>>> 417:       ttyLocker ttyl;
>>> 418:       tty->print_cr("Warning: blackhole compile command only works for methods with void type: %s",
>> 
>> It is printed unconditionally. What about guarding it with `!CompilerOracle::be_quiet()`?
>
> As far as I can see, `CompilerOracle` prints warnings even with `quiet`. `quiet` seems to really only shun the successful messages. So this behavior is consistent. And frankly, it is a better UX: errors in compiler commands should be visible.

IMO `CompileCommand=quiet` is fine here, but another option is to check `PrintWarnings`. I believe the output can be quite noisy and there's no way to turn it off.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1203


More information about the hotspot-dev mailing list