RFR: JDK-8256155: os::Linux Populate all large_page_sizes, select smallest page size in reserve_memory_special_huge_tlbfs* [v9]

[Marcus G K Williams]

On Tue, 8 Dec 2020 16:19:27 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Marcus G K Williams has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix space format, use Linux:: for local func.
>>   
>>   Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
>
> src/hotspot/os/linux/os_linux.cpp line 4221:
> 
>> 4219: }
>> 4220: 
>> 4221: size_t os::Linux::select_large_page_size(size_t bytes) {
> 
> As mentioned by @tstuefe , this is duplicating `size_t os::page_size_for_region(size_t region_size, size_t min_pages, bool must_be_aligned) `

In latest patch I removed os::Linux::select_large_page_size and use os::page_size_for_region instead.

> src/hotspot/os/linux/os_linux.cpp line 3726:
> 
>> 3724: }
>> 3725: 
>> 3726: void os::Linux::register_large_page_sizes() {
> 
> Please refactor to remove duplicated code with` find_large_page_size`, probably use `register_large_page_sizes` to eliminate the need for `find_large_page_size`

In latest patch I removed Linux::find_large_page_size and use register_large_page_sizes. I tried to streamline Linux::setup_large_page_size.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1153