RFR: 8252148: vmError::controlled_crash should be #ifdef ASSERT [v2]

[Coleen Phillimore]

> Moved some unit tests from vmError into a gtest and moved controlled_crash code under #ifdef ASSERT rather than #ifndef PRODUCT since the tests that use this are @requires = vm.debug.  This change keeps the ErrorHandlerTest=n option and other handler test options, because there are some tests that use this more but moves them to develop options (they were notproduct).  There are some ErrorHandlerTest=n tests that do more thorough hs_err_pid.log file verification that remain.
> 
> Tested with tier1-3 with product and fastdebug builds.  Built with optimized.
> 
> This is for JDK 17.

Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:

  Fixed va_copy problem, and added changes from pull request.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1723/files
  - new: https://git.openjdk.java.net/jdk/pull/1723/files/fa795402..e3b6a555

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1723&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1723&range=00-01

  Stats: 21 lines in 5 files changed: 5 ins; 9 del; 7 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1723.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1723/head:pull/1723

PR: https://git.openjdk.java.net/jdk/pull/1723