RFR: 8252148: vmError::controlled_crash should be #ifdef ASSERT [v2]
Thomas Stuefe
stuefe at openjdk.java.net
Fri Dec 11 17:33:59 UTC 2020
On Fri, 11 Dec 2020 16:01:12 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Moved some unit tests from vmError into a gtest and moved controlled_crash code under #ifdef ASSERT rather than #ifndef PRODUCT since the tests that use this are @requires = vm.debug. This change keeps the ErrorHandlerTest=n option and other handler test options, because there are some tests that use this more but moves them to develop options (they were notproduct). There are some ErrorHandlerTest=n tests that do more thorough hs_err_pid.log file verification that remain.
>>
>> Tested with tier1-3 with product and fastdebug builds. Built with optimized.
>>
>> This is for JDK 17.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Fixed va_copy problem, and added changes from pull request.
Hi Coleen, sorry for forgetting to mention va_end too. That's still missing, otherwise we leak the copied va_list. Otherwise this looks nice, this is a good cleanup.
Thanks, Thomas
src/hotspot/share/utilities/debug.cpp line 264:
> 262: }
> 263: }
> 264: ::fflush(stderr);
You miss now a va_end(detail_args_copy) here to got with the va_copy.
-------------
Changes requested by stuefe (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1723
More information about the hotspot-dev
mailing list