RFR: 8252148: vmError::controlled_crash should be #ifdef ASSERT [v2]

Coleen Phillimore coleenp at openjdk.java.net
Fri Dec 11 18:21:15 UTC 2020


On Fri, 11 Dec 2020 17:28:07 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed va_copy problem, and added changes from pull request.
>
> src/hotspot/share/utilities/debug.cpp line 264:
> 
>> 262:         }
>> 263:       }
>> 264:       ::fflush(stderr);
> 
> You miss now a va_end(detail_args_copy) here to got with the va_copy.

Oh yeah.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1723


More information about the hotspot-dev mailing list