RFR: 8255917: runtime/cds/SharedBaseAddress.java failed "assert(reserved_rgn != 0LL) failed: No reserved region" [v2]

[Yumin Qi]

On Mon, 14 Dec 2020 06:57:54 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use default timeout number (120) for the test
>
> src/hotspot/share/runtime/os.cpp line 1727:
> 
>> 1725:   }
>> 1726:   if (!res) {
>> 1727:     log_info(os)("os::release_memory(" PTR_FORMAT ", " SIZE_FORMAT ") failed", p2i(addr), bytes);
> 
> I think it's better to use `"os::release_memory failed (" PTR_FORMAT ", " SIZE_FORMAT ")"`. That way it's easy to match the error message in the test case with a simple substring test of `"os::release_memory failed"`. Otherwise it's hard to see that the regexp in the test ` "os::release_memory\(0x[0-9a-fA-F]*,\\s[0-9]*\)\\sfailed"` indeed would match the error message.

Thanks for the suggestion.  Will make the check in test simple. (I have tested the pattern using online java pattern match and a local test program for it).

Thanks
Yumin

-------------

PR: https://git.openjdk.java.net/jdk/pull/1750