RFR: 8258074: Move some flags related to compiler to compiler_globals.hpp [v2]

Coleen Phillimore coleenp at openjdk.java.net
Tue Dec 15 23:08:58 UTC 2020


On Fri, 11 Dec 2020 07:22:19 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Many flags in globals.hpp are related to the compiler, and are mostly used only by the compiler source files. These flags should be moved to compiler_globals.hpp
>> 
>> Examples:
>> 
>> - CompileCommandFile
>> - Tier2CompileThreshold
>> - HugeMethodLimit
>> 
>> This speeds up HotSpot build time, and improves modularity.
>> 
>> This RFE is the first step -- it moves a few dozen flags that are straight-forward to move. Other flags may be moved by follow-up RFEs.
>> 
>> Tested with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5 on mach5, plus locally building arm, aarch64, s390, ppc64, and zero.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed gtest

Very nice!

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1746


More information about the hotspot-dev mailing list