RFR: JDK-8258479: Minor cleanups in VMError [v2]

Thomas Stuefe stuefe at openjdk.java.net
Wed Dec 16 13:54:09 UTC 2020


> A list of smaller cleanups, each one too small to justify an own issue:
> 
> 1) VMError exposes is_error_reported(), fatal_error_in_progress() and get_first_error_tid(). These functions are used from outside to check on the state of error handling. They can be combined and duplicate coding removed. Also, VMError::_error_reported can be removed, since its redundant with VMError::_first_error_tid != -1)
> 2) A lot of methods are unnecessarily public
> 3) the `env_var` array in vmError.cpp can be limited to file scope
> 4) definition of VMError static members should be combined to the start of the cpp file
> 5) the comment describing VMError::report() is misplaced
> 6) VMError::reset_signal_handlers() is badly named; nothing is reset here, the secondary signal handler is installed.

Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:

  Fix Windows builds

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1802/files
  - new: https://git.openjdk.java.net/jdk/pull/1802/files/47edef83..47c59b57

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1802&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1802&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1802.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1802/head:pull/1802

PR: https://git.openjdk.java.net/jdk/pull/1802


More information about the hotspot-dev mailing list