RFR: 8257815: Replace global log2 functions with efficient implementations [v11]

Martin Doerr mdoerr at openjdk.java.net
Wed Dec 16 16:34:04 UTC 2020


On Wed, 16 Dec 2020 11:10:03 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>>> Hi Claes, sorry, I won't get to this before the holidays. @TheRealMDoerr maybe?
>> 
>> I've put it into our nightly testing again. We should see results tomorrow if everything works.
>
>> I've put it into our nightly testing again. We should see results tomorrow if everything works.
> 
> Perfect, thanks!

Hi Claes,
I noticed that you're using `log2i_exact` in ppc.ad. That's wrong, we're hitting assertions because it's not used for exact powers of 2. Please change to `log2i`. I'll test with that change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1663


More information about the hotspot-dev mailing list