Review request (XS): 7167437 - Can't build on linux without precompiled headers

John Coomes John.Coomes at oracle.com
Thu May 10 16:48:19 UTC 2012


Stefan Karlsson (stefan.karlsson at oracle.com) wrote:
> http://cr.openjdk.java.net/~stefank/7167437/webrev/
> 
> The inline function set_concurrent_iteration_safe_limit is not available 
> when building binaryTreeDictionary.cpp. This breaks the build when 
> compiling with USE_PRECOMPILED_HEADER=0.
> 
> I moved the simple implementation to the .hpp file instead of the 
> .inline.hpp file.

Change looks fine.

I'm curious why it's necessary - Solaris compiles without pch.  Would
including space.inline.hpp in binaryTreeDictionary.cpp (or .hpp) also
solve it?

-John



More information about the hotspot-gc-dev mailing list