Review request: 8000230: Change os::print_location to be more descriptive when a location is pointing into an object

[Mikael Gerdin]

Stefan,

On 2012-09-28 15:49, Stefan Karlsson wrote:
> http://cr.openjdk.java.net/~stefank/8000230/webrev/

Looks good to me.

/Mikael

>
>  From the bug:
> ---
> When printing the "Register to memory mapping:" hs_err section, it's
> easy to get fooled when a register points into an object.
>
> For example:
> R13=0xfffffd7fcf900064 is an oop
> [Ljava.lang.Object;
>   - klass: 'java/lang/Object'[]
>   - length: 327680
>
> seems to indicate that an object starts at address 0xfffffd7fcf900064.
> In this case the real object start was at address 0xfffffd7fcf900000.
>
> I propose that we change this line to:
> R13=0xfffffd7fcf900064 is pointing into object: 0xfffffd7fcf900000
> [Ljava.lang.Object;
>   - klass: 'java/lang/Object'[]
>   - length: 327680
>
> If the address seems to be pointing at the start of an object, the old
> output can still be used.
> ---
>
> StefanK

-- 
Mikael Gerdin
Java SE VM SQE Stockholm