RFR(S): 8010780: G1: Eden occupancy/capacity output wrong after a full GC

[Thomas Schatzl]

Hi,

On Wed, 2013-03-27 at 15:12 -0700, John Cuthbertson wrote:
> Hi Everyone,
> 
> Can I have a couple of volunteers look review this fix? The webrev can 
> be found at: http://cr.openjdk.java.net/~johnc/8010780/webrev.0/
> 
> Summary:
> One of the performance team spotted and error in the G1 logs following a 
> full GC:
> 
> 411.322: [G1Ergonomics (Mixed GCs)  (to-space exhausted), 0.4279260 secs]
>
> [...]
>
> The heap transition line for the GC after the full GC was displaying the 
> eden capacity that was calculated by the GC preceding the full GC rather 
> than the eden capacity calculated at the end of the of the full GC. As a 
> result the reported eden occupancy is much larger than the reported 
> capacity.
> 
> The main part of the fix is the moving of 
> G1CollectorPolicy::_prev_eden_capacity from 
> G1CollectorPolicy::print_detailed_heap_transition() to 
> G1CollectorPolicy::record_collection_pause_start(). The code that 
> records the heap state before the GC has been refactored into a separate 
> routine and is invoked at the start of both an incremental and full GC.
> 

Seems fine.

Thomas