Request for review (s) - NPG: Replace the ChunkList implementation with class FreeList<Metachunk>

Thomas Schatzl thomas.schatzl at oracle.com
Thu Apr 4 08:33:17 UTC 2013


Hi,

On Tue, 2013-04-02 at 16:42 +0200, Mikael Gerdin wrote:
> Jon,
> 
> On 2013-04-02 00:13, Jon Masamitsu wrote:
> > For the perm gen removal project the ChunkList class
> > which implemented a simple freelist of Metachunk's was added.
> > This change replaces ChunkList with FreeList<Metachunk>.
> >
> > Changes include
> >
> > - Deletion of ChunkList
> > - Code to initialize the freelists in the FreeList style
> > - Replacement of call to ChunkList methods with the
> > equivalent calls to FreeList methods.
> >
> > http://cr.openjdk.java.net/~jmasa/8011173
> 
> This looks like a good cleanup step.

Same here.

> The name FreeList is kind of a misnomer since it's actually just the 
> head of a generic linked list.

Noticed the same about the naming. Other than that, seems fine.

Thomas






More information about the hotspot-gc-dev mailing list